2010-04-21 Sheriff Bot Unreviewed, rolling out r58028. http://trac.webkit.org/changeset/58028 https://bugs.webkit.org/show_bug.cgi?id=37962 broke the chromium build (Requested by tony^work on #webkit). * DEPS: 2010-04-21 Evan Martin Unreviewed, just a dependency change. [chromium] roll skia forward to r538 https://bugs.webkit.org/show_bug.cgi?id=37960 This will cause a bunch of pixel tests to fail due to bulleted lists rendering slightly differently. I will grab new baselines from the bots and check them in in a followup. * DEPS: 2010-04-21 Evan Stade Reviewed by Darin Fisher. [chromium] Web page serializer saves tag names in upper case https://bugs.webkit.org/show_bug.cgi?id=37940 Simply convert all tags to lower case. This is tested by chrome tests: - save page browser tests - encoding ui tests - web page serializer test shell tests * src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration): * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): 2010-04-20 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData): * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize): * src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding): 2010-04-20 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: add basic script editing capabilities to the front-end. https://bugs.webkit.org/show_bug.cgi?id=37875 * src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.editScriptLine): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_): * src/js/DevTools.js: * src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.editScriptLine): 2010-04-20 Kent Tamura Reviewed by Darin Adler. Change a parameter type of chooseIconForFiles() https://bugs.webkit.org/show_bug.cgi?id=37504 * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles): * src/ChromeClientImpl.h: 2010-04-20 Jay Civelli Reviewed by Dimitri Glazkov. [chromium] Tests that pressing tab now closes the select popup. https://bugs.webkit.org/show_bug.cgi?id=37721 * tests/PopupMenuTest.cpp: (WebKit::TEST_F): 2010-04-20 Evan Stade Reviewed by David Levin. [chromium] crash when dragging images https://bugs.webkit.org/show_bug.cgi?id=37715 Added unit tests for DragImageChromiumSkia. * WebKit.gyp: * tests/DragImageTest.cpp: Added. (WebCore::TestImage::TestImage): (WebCore::TestImage::~TestImage): (WebCore::TestImage::size): (WebCore::TestImage::nativeImageForCurrentFrame): (WebCore::TestImage::destroyDecodedData): (WebCore::TestImage::decodedSize): (WebCore::TestImage::draw): (WebCore::TEST): 2010-04-20 Stuart Morgan Reviewed by David Levin. Remove a workaround in plugin cursor setting that was obsoleted by the change in https://bugs.webkit.org/show_bug.cgi?id=35132 https://bugs.webkit.org/show_bug.cgi?id=37811 * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin): * src/ChromeClientImpl.h: 2010-04-19 Ada Chan Reviewed by Jeremy Orlow. https://bugs.webkit.org/show_bug.cgi?id=37717 Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and StorageNamespace::sessionStorageNamespace() take in a quota parameter. * src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace): * src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespace::createSessionStorageNamespace): 2010-04-17 Vangelis Kokkevis Reviewed by Dimitri Glazkov. Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context. https://bugs.webkit.org/show_bug.cgi?id=37541 * WebKit.gyp: * public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context): * src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers): 2010-04-16 Dumitru Daniliuc Reviewed by Eric Seidel. Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp. https://bugs.webkit.org/show_bug.cgi?id=37733 * src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): 2010-04-16 Dumitru Daniliuc Reviewed by Jeremy Orlow. Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier(). https://bugs.webkit.org/show_bug.cgi?id=34466 Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier() from WebSecurityOrigin* to WebSecurityOrigin, to make it more consistent with the other WebSecurityOrigin methods. * public/WebSecurityOrigin.h: * src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately): * src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): 2010-04-16 Dmitry Titov Reviewed by Yury Semikhatsky. [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror https://bugs.webkit.org/show_bug.cgi?id=37691 * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext. 2010-04-16 Albert J. Wong Not reviewed. Build fix. [chromium] Compile fix. Missing include header, and missing type conversion. * src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::beginPaint): 2010-04-16 Jarkko Sakkinen Reviewed by Simon Hausmann. [Qt] WebGL is not visible when QGLWidget viewport is used https://bugs.webkit.org/show_bug.cgi?id=37070 Added HostWindow parameter to the constructor of GraphicsContext3D. Shared OpenGL context is initialized with parent QGLWidget. * src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): 2010-04-16 Fumitoshi Ukai Reviewed by Jian Li. [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8 https://bugs.webkit.org/show_bug.cgi?id=37687 * src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string. 2010-04-16 Jay Civelli Reviewed by Dimitri Glazkov. [chromium] Select popups would assert when destroyed. Also adding unit-tests for the select popup code. https://bugs.webkit.org/show_bug.cgi?id=37436 * WebKit.gyp: * src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup): * tests/PopupMenuTest.cpp: Added. 2010-04-16 Tony Chang Reviewed by Dimitri Glazkov. [chromium] build DRT on Linux https://bugs.webkit.org/show_bug.cgi?id=37690 * DEPS: Need to roll deps to remove a dependency on src/chrome * gyp_webkit: generate makefiles for DRT.gyp on Linux 2010-04-15 Tony Chang Reviewed by Dimitri Glazkov. build DRT on chromium mac https://bugs.webkit.org/show_bug.cgi?id=37639 * gyp_webkit: generate build files for DRT on mac 2010-04-15 Yury Semikhatsky Reviewed by Pavel Feldman. Support basic debugging capabilities including step in/over/out in v8 implementation of ScriptDebugServer. https://bugs.webkit.org/show_bug.cgi?id=37604 * WebKit.gypi: * src/DebuggerAgent.h: * src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource): * src/DebuggerAgentImpl.h: * src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): * src/DebuggerAgentManager.h: * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared): * src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor): * src/js/DevTools.js: (WebInspector.loaded): (.): (): * src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource): * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): 2010-04-15 Matt Perry Reviewed by Dimitri Glazkov. Implement layoutTestController's addUserStyleSheet and setAuthorAndUserStylesEnabled on Chromium port. https://bugs.webkit.org/show_bug.cgi?id=37595 * public/WebSettings.h: * public/WebView.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled): * src/WebSettingsImpl.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserStyleSheet): * src/WebViewImpl.h: 2010-04-15 Zhenyao Mo Reviewed by Dimitri Glazkov. Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization https://bugs.webkit.org/show_bug.cgi?id=37178 * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebKit::WebGraphicsContext3DDefaultImpl::initialize): 2010-04-15 Albert J. Wong Unreviewed, rolling out r57660. http://trac.webkit.org/changeset/57660 https://bugs.webkit.org/show_bug.cgi?id=37604 Broke a large number of inspector layout tests in chromium. * WebKit.gypi: * src/DebuggerAgent.h: * src/DebuggerAgentImpl.cpp: * src/DebuggerAgentImpl.h: * src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): * src/DebuggerAgentManager.h: * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared): * src/js/DebuggerScript.js: Removed. * src/js/DevTools.js: (WebInspector.loaded): (WebInspector.UnresolvedPropertyValue): (): * src/js/DevToolsHostStub.js: * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): 2010-04-15 Yury Semikhatsky Reviewed by Pavel Feldman. Support basic debugging capabilities including step in/over/out in v8 implementation of ScriptDebugServer. https://bugs.webkit.org/show_bug.cgi?id=37604 * WebKit.gypi: * src/DebuggerAgent.h: * src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource): * src/DebuggerAgentImpl.h: * src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): * src/DebuggerAgentManager.h: * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared): * src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor): * src/js/DevTools.js: (WebInspector.loaded): (.): (): * src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource): * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): 2010-04-15 Ben Murdoch Unreviewed, rolling out r57652. http://trac.webkit.org/changeset/57652 https://bugs.webkit.org/show_bug.cgi?id=37609 Caused a build break on Chromium Mac and Layout Test fail on Qt * src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState): 2010-04-14 Ben Murdoch Reviewed by Kenneth Rohde Christiansen. The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler. https://bugs.webkit.org/show_bug.cgi?id=37609 After discussions at the WebKit contributors meeting, we decided that this is a currently unused state without a good future use case in the Touch API and thus decided to remove it. This patch actions that decision. * src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState): Remove TouchStationary. 2010-04-12 Tony Chang Reviewed by Darin Fisher. [chromium] update chromium DEPS for upstream compile https://bugs.webkit.org/show_bug.cgi?id=36578 * DEPS: Pull sub deps from chromium's DEPS file 2010-04-14 Sheriff Bot Unreviewed, rolling out r57599. http://trac.webkit.org/changeset/57599 https://bugs.webkit.org/show_bug.cgi?id=37605 "Broke Chromium build" (Requested by dglazkov on #webkit). * WebKit.gyp: * src/WebViewImpl.h: * tests/PopupMenuTest.cpp: Removed. 2010-04-14 Aaron Boodman Reviewed by David Levin. Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are unsupported. Fixed by resolving the relative URL first. https://bugs.webkit.org/show_bug.cgi?id=36623 Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows. * public/WebNotification.h: Remove deprecated icon() method. * src/WebNotification.cpp: Ditto. 2010-04-14 Jay Civelli Reviewed by Dimitri Glazkov. [chromium] Select popups would assert when destroyed. Also adding unit-tests for the select popup code. https://bugs.webkit.org/show_bug.cgi?id=37436 * WebKit.gyp: * src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup): * tests/PopupMenuTest.cpp: Added. 2010-04-14 Zhenyao Mo Reviewed by Dimitri Glazkov. readPixels must take PACK_ALIGNMENT into account https://bugs.webkit.org/show_bug.cgi?id=34718 * src/GraphicsContext3D.cpp: Refactor readPixels. * src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels. 2010-04-14 Mikhail Naganov Reviewed by Pavel Feldman. Re-write testProfilerTab to match the new implementation. https://bugs.webkit.org/show_bug.cgi?id=37516 * src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab): 2010-04-13 Timothy Hatcher Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. SecurityOrigin needs a way to remove individual OriginAccessEntries https://bugs.webkit.org/show_bug.cgi?id=37449 Reviewed by Dave Hyatt. * src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin): (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists): 2010-04-13 Mikhail Naganov Reviewed by Pavel Feldman. Fix search behavior in Heap profiles. https://bugs.webkit.org/show_bug.cgi?id=37498 * src/js/HeapProfilerPanel.js: 2010-04-13 Jeremy Moskovich Reviewed by David Levin. Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType(). https://bugs.webkit.org/show_bug.cgi?id=36426 * src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail): 2010-04-13 Mikhail Naganov Unreviewed Chromium build fix: pin to a newer V8 revision (4386). * DEPS: 2010-04-12 Mikhail Naganov Reviewed by Yury Semikhatsky. Replace hand-written JavaScriptProfile* bindings with idl-based, and in Chromium port, bind them to the new V8's profiler API that is aligned with JSC. https://bugs.webkit.org/show_bug.cgi?id=37448 * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): * src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines): * src/js/Tests.js: 2010-04-11 Sheriff Bot Unreviewed, rolling out r57468. http://trac.webkit.org/changeset/57468 https://bugs.webkit.org/show_bug.cgi?id=37433 Broke the world... Must have applied the patch wrong (Requested by abarth on #webkit). * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData): * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize): * src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding): 2010-04-11 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData): * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize): * src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding): 2010-04-11 Sheriff Bot Unreviewed, rolling out r57460. http://trac.webkit.org/changeset/57460 https://bugs.webkit.org/show_bug.cgi?id=37424 broke chromium builders (Requested by tony^work on #webkit). * DEPS: * gyp_webkit: 2010-04-11 Tony Chang Reviewed by Darin Fisher. [chromium] update chromium DEPS for upstream compile https://bugs.webkit.org/show_bug.cgi?id=36578 * DEPS: * gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT. 2010-04-10 Vangelis Kokkevis Reviewed by Dimitri Glazkov. Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h https://bugs.webkit.org/show_bug.cgi?id=37231 * src/WebViewImpl.h: 2010-04-10 Rafael Weinstein Reviewed by Eric Seidel. Cleanup after chromium breakage. All interface methods are returned to being abstract. * public/WebNotificationPresenter.h: 2010-04-09 Evan Stade Reviewed by Eric Seidel. [chromium] Linux: respect the scale factor during printing https://bugs.webkit.org/show_bug.cgi?id=37168 Chromium doesn't support testing .pdfs from printing at the moment, so this change is not covered by any tests. * src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage): 2010-04-09 Aaron Boodman Reviewed by Eric Seidel. Remove applicationID() from WebDocument as it is Chromium-specific. https://bugs.webkit.org/show_bug.cgi?id=37350 * public/WebDocument.h: * src/WebDocument.cpp: 2010-04-09 Jeremy Orlow Reviewed by Darin Adler. Move the IDB::open ExceptionCode paramter to be last https://bugs.webkit.org/show_bug.cgi?id=37277 Move the ExceptionCode paramter to the last position in IndexedDatabaseRequest::open and friends. It should definitely go after the callbacks to keep the parameters that come directly from javascript together. And having output parameters appear last is done often in the code base, so it makes sense to push it past the Frame* param as well. * public/WebIndexedDatabase.h: * src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open): * src/IndexedDatabaseProxy.h: * src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open): * src/WebIndexedDatabaseImpl.h: 2010-04-09 Jochen Eisinger Reviewed by Darin Fisher. Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient. https://bugs.webkit.org/show_bug.cgi?id=37330 * public/WebApplicationCacheHost.h: * public/WebKitClient.h: * src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal): 2010-04-09 Marcus Bulach Reviewed by Jeremy Orlow. Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection Should not try to access WebViewClient if the frame has already been disconnected. https://bugs.webkit.org/show_bug.cgi?id=37318 * src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): 2010-04-09 Jochen Eisinger Reviewed by Adam Barth. Expose SecurityOrigin::canRequest in WebSecurityOrigin. https://bugs.webkit.org/show_bug.cgi?id=37271 * public/WebSecurityOrigin.h: * src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canRequest): 2010-04-09 Zhenyao Mo Reviewed by Dimitri Glazkov. Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D https://bugs.webkit.org/show_bug.cgi?id=37174 Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): 2010-04-07 Pavel Feldman Reviewed by Yury Semikhatsky. Chromium: support themes in devtools window. https://bugs.webkit.org/attachment.cgi?bugid=37216 * WebKit.gypi: * src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors): * src/js/Images/segmentChromium2.png: Added. * src/js/Images/segmentHoverChromium2.png: Added. * src/js/Images/segmentSelectedChromium2.png: Added. * src/js/Images/statusbarBackgroundChromium2.png: Added. * src/js/Images/statusbarMenuButtonChromium2.png: Added. 2010-04-07 Andrey Kosyakov Reviewed by Yury Semikhatsky. Removed inspector methods from ScriptExecutionContext and derived classes. Removed MessageDestination parameter from console-related calls (we now always log to the same destination(s)). Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() https://bugs.webkit.org/show_bug.cgi?id=36949 * public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject): * src/FrameLoaderClientImpl.cpp: * src/FrameLoaderClientImpl.h: * src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask): * src/WebWorkerBase.h: * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask): * src/WebWorkerClientImpl.h: 2010-04-07 Jeremy Orlow Reviewed by Darin Fisher. [Chromium] WebIDBDatabaseError::assign doesn't work correctly https://bugs.webkit.org/show_bug.cgi?id=37209 * src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign): 2010-04-07 Dawit Alemayehu Reviewed by Simon Hausmann. https://bugs.webkit.org/show_bug.cgi?id=36827 Updated the WebCore::shouldTreatAsAttachement function call with the new more generic replacement WebCore::contentDispositionType. See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395 * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType): 2010-04-07 Jochen Eisinger Reviewed by Darin Fisher. Add createApplicationCacheHost to WebFrameClient so the ApplicationCacheHost has access to its frame. https://bugs.webkit.org/show_bug.cgi?id=36882 * public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost): * src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal): 2010-04-06 Nicolas Weber Reviewed by Dimitri Glazkov. Use drag images on OS X as well. https://bugs.webkit.org/show_bug.cgi?id=37069 * src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): 2010-04-06 Vangelis Kokkevis Reviewed by Dimitri Glazkov. Changing references to Graphics Layer related classes from *Skia to *Chromium. https://bugs.webkit.org/show_bug.cgi?id=37116 * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents): * src/WebViewImpl.h: 2010-04-06 James Hawkins Reviewed by Adam Barth. [Chromium] Implement WebInputElement::maxLength. https://bugs.webkit.org/show_bug.cgi?id=37172 * public/WebInputElement.h: * src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength): 2010-04-06 Evan Stade Reviewed by Dimitri Glazkov. [chromium] need DragImage implementation https://bugs.webkit.org/show_bug.cgi?id=35811 Basic implementation using SkBitmap. Transformations are not supported yet. No implementation for mac. This was previously committed but rolled back for breaking layout tests. * public/WebViewClient.h: (WebKit::WebViewClient::startDragging): * src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging): * src/WebViewImpl.h: 2010-04-06 James Hawkins Reviewed by Dimitri Glazkov. [Chromium] Move the getElementsByTagName from WebDocument to WebNode. https://bugs.webkit.org/show_bug.cgi?id=37161 * public/WebDocument.h: * public/WebNode.h: * src/WebDocument.cpp: * src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName): 2010-04-06 Ilya Tikhonovsky Unreviewed build fix for Chromium DEPS. * DEPS: 2010-04-06 Ilya Tikhonovsky Unreviewed: build fix. * DEPS: 2010-04-06 Mattias Nissler Reviewed by Pavel Feldman. Handle docking requests from the developer tools and forward them to WebDevToolsFrontendClient. https://bugs.webkit.org/show_bug.cgi?id=36944 * public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow): * src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow): * src/WebDevToolsFrontendImpl.h: 2010-04-06 Andrey Kosyakov Reviewed by Yury Semikhatsky. Fixed logging of unhndled worker exceptions. https://bugs.webkit.org/show_bug.cgi?id=37143 * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): 2010-04-05 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=37111 Draw replacement text when plug-in host crashes * src/LocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in failure. 2010-04-04 Pavel Feldman Not reviewed. Rolling out chromium changes r57028 and r57032 for breaking chromium layout tests. * public/WebViewClient.h: (WebKit::WebViewClient::startDragging): * src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging): * src/WebViewImpl.h: 2010-04-03 Darin Fisher Add default implementations of WebNotificationPresenter methods to repair the downstream Chromium build. * public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission): 2010-04-02 Michael Nordman Reviewed by Nate Chapin. Set the close policy used by the DatabaseCloseTask at this callsite to RemoveDatabaseFromContext. This restores its behavior to what it was prior to r56293. https://bugs.webkit.org/show_bug.cgi?id=37037 * src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately): 2010-04-02 Evan Stade Reviewed by Eric Seidel. [chromium] need DragImage implementation https://bugs.webkit.org/show_bug.cgi?id=35811 Use the DragImageRef that the DragController passes to us. * public/WebViewClient.h: (WebKit::WebViewClient::startDragging): * src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging): * src/WebViewImpl.h: 2010-04-02 Rafael Weinstein Reviewed by Adam Barth. Clean up unused calls after changes to checkPermission and requestPermission argument lists. * public/WebNotificationPresenter.h: * src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission): 2010-04-02 Zhenyao Mo Reviewed by Eric Seidel. Implement and test new framebuffer object attachment behavior. https://bugs.webkit.org/show_bug.cgi?id=35611 Test: fast/canvas/webgl/framebuffer-object-attachment.html * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): 2010-04-02 Jay Civelli Reviewed by Darin Fisher. The popup type (select or suggestion) is now passed to the WebClient::createPopupMenu() method. This is required for Chromium on Linux to make the select popups work correctly. https://bugs.webkit.org/show_bug.cgi?id=37013 * WebKit.gyp: * public/WebPopupType.h: Added. (WebKit::): * public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu): * src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened): 2010-04-02 Yury Semikhatsky Reviewed by Pavel Feldman. Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl. https://bugs.webkit.org/show_bug.cgi?id=36817 * WebKit.gyp: * src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged): * src/InspectorFrontendClientImpl.h: Added. * src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded): * src/WebDevToolsFrontendImpl.h: * src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_): * src/js/DevTools.js: (): 2010-04-01 Jay Civelli Reviewed by David Levin. Adds a method to WebFrame to execute JavaScript and get the value it evaluates to. https://bugs.webkit.org/show_bug.cgi?id=36907 * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptAndReturnValue): * src/WebFrameImpl.h: 2010-04-01 Kinuko Yasuda Reviewed by Dmitry Titov. Add FileThread for async file operation support in FileReader and FileWriter https://bugs.webkit.org/show_bug.cgi?id=36896 Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags. * features.gypi: 2010-04-01 Finnur Thorarinsson Reviewed by Eric Seidel. [chromium] FindInPage on multi-frame pages wasn't always updating tickmarks on scrollbars for the subframes. It was calling invalidateRect on the View and specifying a rect that's in window coordinates, whereas the invalidateRect expects frame coordinates. https://bugs.webkit.org/show_bug.cgi?id=36982 * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::invalidateArea): 2010-04-01 Finnur Thorarinsson Reviewed by Dimitri Glazkov. [chromium] FindInPage should clear the focused node when a match has been found. This is because WebFrameImpl::setFocus will try to refocus editable elements if it thinks they have focus, causing the page to scroll. https://bugs.webkit.org/show_bug.cgi?id=36923 * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): 2010-04-01 Marcus Bulach Reviewed by Jeremy Orlow. As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove: GeolocationServiceBridgeChromium.h dettachBridge() getGeolocationService() https://bugs.webkit.org/show_bug.cgi?id=36895 * WebKit.gyp: * public/GeolocationServiceBridgeChromium.h: Removed. * public/WebGeolocationService.h: (WebKit::WebGeolocationService::detachBridge): * public/WebViewClient.h: (WebKit::WebViewClient::geolocationService): 2010-03-31 Jeremy Orlow Reviewed by Nate Chapin. Misc IndexedDatabase cleanup https://bugs.webkit.org/show_bug.cgi?id=36889 Plumb the Frame* so Chromium knows where the request originated from. * public/WebIndexedDatabase.h: * src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open): * src/IndexedDatabaseProxy.h: * src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open): * src/WebIndexedDatabaseImpl.h: 2010-03-31 Alpha Lam Not reviewed. Build fix. Fixing a build break caused by 56872. One of the Chromium bots doesn't like std::strstr(). Includes string.h and use strstr() instead. * src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): Includes string.h and use strstr(). 2010-03-31 Zhenyao Mo Reviewed by Darin Fisher. Hook up WebGLContextAttributes to OpenGL context creation code https://bugs.webkit.org/show_bug.cgi?id=33416 * src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac. * src/WebGraphicsContext3DDefaultImpl.h: Add a function. 2010-03-31 Darin Fisher Reviewed by David Levin. [chromium] including WebKit.gyp:webkit should automatically add Skia and NPAPI include paths https://bugs.webkit.org/show_bug.cgi?id=36887 * WebKit.gyp: 2010-03-31 Marcus Bulach Reviewed by Jeremy Orlow. Implements cancelGeolocationPermissionRequestForFrame. https://bugs.webkit.org/show_bug.cgi?id=35031 * public/WebGeolocationService.h: (WebKit::WebGeolocationService::cancelPermissionRequestForFrame): * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame): * src/ChromeClientImpl.h: 2010-03-31 Pavel Feldman Not reviewed. Rolling out r56829 since it broke chromium layout tests. [REGRESSION] Inspector tests started crashing since r56829 https://bugs.webkit.org/show_bug.cgi?id=36888 * public/WebFrameClient.h: * src/FrameLoaderClientImpl.cpp: * src/FrameLoaderClientImpl.h: 2010-03-31 Yury Semikhatsky Reviewed by Pavel Feldman. Add stubs for moveWindowBy and setAttachedWindowHeight. https://bugs.webkit.org/show_bug.cgi?id=36842 * src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight): (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy): * src/WebDevToolsFrontendImpl.h: 2010-03-31 John Gregg Reviewed by Darin Fisher. [chromium] add logging of cross-frame property accesses for site isolation https://bugs.webkit.org/show_bug.cgi?id=35773 * public/WebFrameClient.h: (WebKit::WebFrameClient::logCrossFramePropertyAccess): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess): * src/FrameLoaderClientImpl.h: 2010-03-30 Gavin Barraclough Rubber stamped by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=36866 Move CString to WTF * public/WebCString.h: * src/FrameLoaderClientImpl.cpp: * src/GraphicsContext3D.cpp: * src/WebCString.cpp: (WebKit::WebCString::assign): (WebKit::WebCString::WebCString): (WebKit::WebCString::operator=): (WebKit::WebCString::operator WTF::CString): * src/WebMediaPlayerClientImpl.cpp: * src/WebString.cpp: * src/WebURLError.cpp: 2010-03-30 Marcus Bulach Reviewed by Darin Fisher. Rename / tidy up Geolocation bridge: Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h. https://bugs.webkit.org/show_bug.cgi?id=36535 * WebKit.gyp: * public/GeolocationServiceBridgeChromium.h: * public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. (WebKit::WebGeolocationService::detachBridge): * public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. * public/WebViewClient.h: (WebKit::WebViewClient::geolocationService): * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): * src/ChromiumBridge.cpp: * src/GeolocationServiceBridgeChromium.cpp: Removed. * src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp. (WebKit::createGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient): * src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. 2010-03-30 Jochen Eisinger Reviewed by Jeremy Orlow. Remove dysfunctional implementation of canEstablishDatabase for Workers. I postpone this implementation until Workers can actually access Web Databases. https://bugs.webkit.org/show_bug.cgi?id=36795 * src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase): * src/WebWorkerBase.h: 2010-03-29 Jeremy Orlow Reviewed by Darin Fisher. More IndexedDB work https://bugs.webkit.org/show_bug.cgi?id=36770 Start the implementation of WebIndexedDatabase (for entrance back into WebKit). * WebKit.gyp: * public/WebIndexedDatabase.h: * src/WebIndexedDatabaseImpl.cpp: Added. (WebKit::WebIndexedDatabase::create): (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl): (WebKit::WebIndexedDatabaseImpl::open): * src/WebIndexedDatabaseImpl.h: Added. 2010-03-29 Rafael Weinstein Reviewed by Adam Barth. Change NotificationPresenter::checkPermission() to take the source frames full KURL, rather than its SecurityOrigin. This will aid chromium in having more fine grained permissions to control notification spam. * public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::checkPermission): * src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): * src/NotificationPresenterImpl.h: 2010-03-29 Dawit Alemayehu Reviewed by Simon Hausmann. Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.* and replacted local version with the factored out version. The code was factored out to make possible its use in other implementations such as QtWebKit. * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType): 2010-03-29 Jochen Eisinger Reviewed by Darin Fisher. Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin https://bugs.webkit.org/show_bug.cgi?id=36743 * public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase): * src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase): 2010-03-24 Jeremy Orlow Reviewed by Darin Fisher. More IndexedDB plumbing https://bugs.webkit.org/show_bug.cgi?id=36546 Plumbing work towards the goal of making IndexedDatabase::open work. * WebKit.gyp: * public/WebIDBCallbacks.h: Added. (WebKit::WebIDBCallbacks::~WebIDBCallbacks): * public/WebIDBDatabase.h: Added. (WebKit::WebIDBDatabase::~WebIDBDatabase): * public/WebIDBDatabaseError.h: Added. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=): * public/WebIndexedDatabase.h: * public/WebKitClient.h: (WebKit::WebKitClient::indexedDatabase): * public/WebSerializedScriptValue.h: * src/IDBCallbacksProxy.h: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onSuccess): (WebCore::IDBCallbacksProxy::onError): * src/IDBDatabaseProxy.cpp: Added. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy): * src/IDBDatabaseProxy.h: Added. * src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open): * src/IndexedDatabaseProxy.h: * src/WebIDBDatabaseError.cpp: Added. (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::assign): (WebKit::WebIDBDatabaseError::code): (WebKit::WebIDBDatabaseError::message): (WebKit::WebIDBDatabaseError::operator=): (WebKit::WebIDBDatabaseError::operator PassRefPtr): 2010-03-29 Mikhail Naganov Reviewed by Pavel Feldman. Remove a possibility of confusion from Profiles panel Welcome screen by turning buttons into non-clickable glyphs. Also, span instructions alongside panel width. https://bugs.webkit.org/show_bug.cgi?id=34319 * src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): 2010-03-28 Alexey Proskuryakov Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h - these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers. * src/WebViewImpl.cpp: 2010-03-27 Kenneth Russell Reviewed by Darin Fisher. Use WebKitClient to instantiate WebGraphicsContext3D https://bugs.webkit.org/show_bug.cgi?id=36669 * src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): 2010-03-24 James Hawkins Reviewed by Darin Fisher. [Chromium] Implement WebFormControlElement and WebSelectElement. Add a getFormControlElements method to WebFormElement. https://bugs.webkit.org/show_bug.cgi?id=36562 * WebKit.gyp: * public/WebElement.h: * public/WebFormControlElement.h: Added. * public/WebFormElement.h: * public/WebInputElement.h: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign): * public/WebSelectElement.h: Added. * src/WebElement.cpp: (WebKit::WebElement::isFormControlElement): * src/WebFormControlElement.cpp: Added. * src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements): * src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): * src/WebSelectElement.cpp: Added. 2010-03-26 Andrey Kosyakov Reviewed by Pavel Feldman. Send worker resource content to inspector to enable display of web workers in inspector's resource tab. https://bugs.webkit.org/show_bug.cgi?id=36658 * src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished): 2010-03-25 Tony Chang Reviewed by David Levin. [chromium] correctly handle move drag operations https://bugs.webkit.org/show_bug.cgi?id=36484 * src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method and properly mask against the drag effect. (WebKit::WebViewImpl::createUniqueIdentifierForRequest): * src/WebViewImpl.h: 2010-03-25 Drew Wilson Reviewed by Nate Chapin. [v8] Error in getScriptExecutionContext() when worker context is terminating https://bugs.webkit.org/show_bug.cgi?id=36565 Test: Existing worker tests suffice. * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve(). 2010-03-25 Jeremy Orlow Reviewed by Darin Fisher. [Chromium] Add an ASSERT macro to the Chromium WebKit API https://bugs.webkit.org/show_bug.cgi?id=36545 * WebKit.gyp: Add WebCommon.cpp * public/WebCommon.h: Add the Macro. * public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::~WebPrivatePtr): Verify the pointer is now 0. * src/WebCommon.cpp: Added. (WebKit::failedAssertion): Calls the WTF assert function and then crashes. 2010-03-25 Jochen Eisinger Reviewed by Jeremy Orlow. Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point. https://bugs.webkit.org/show_bug.cgi?id=36614 * src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase): 2010-03-25 Jochen Eisinger Reviewed by Jeremy Orlow. Forward DatabaseTracker::canEstablishDatabase to chromium layer. https://bugs.webkit.org/show_bug.cgi?id=36595 * public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase): * src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase): * src/WebWorkerBase.h: (WebKit::WebWorkerBase::allowDatabase): 2010-03-10 John Abd-El-Malek Reviewed by Darin Fisher. [chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units https://bugs.webkit.org/show_bug.cgi?id=35989 * src/WebInputEventConversion.cpp: 2010-03-24 Vangelis Kokkevis Reviewed by Dimitri Glazkov. Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing: https://bugs.webkit.org/show_bug.cgi?id=36470 * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): Remove call that forced redrawing the contents of the entire layer hierarchy. 2010-03-24 Dmitry Titov No review, rolling out r56453. http://trac.webkit.org/changeset/56453 https://bugs.webkit.org/show_bug.cgi?id=36426 In Chromium port, it broke invalid-image-data-standalone.html invalid-image-data.html multipart-wait-before-boundary.html stop-crash.html win-boundary-crash.html * src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail): 2010-03-24 John Abd-El-Malek Reviewed by Darin Fisher. [chromium]WebKit side of adding search support to Pepper. https://bugs.webkit.org/show_bug.cgi?id=36434 * WebKit.gyp: * public/WebDocument.h: * public/WebNode.h: (WebKit::WebNode::to): (WebKit::WebNode::toConst): * public/WebPluginDocument.h: Added. (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::assign): * src/WebDocument.cpp: (WebKit::WebDocument::isPluginDocument): * src/WebPluginDocument.cpp: Added. (WebKit::WebPluginDocument::plugin): (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::operator PassRefPtr): 2010-03-24 Jeremy Moskovich Reviewed by Jeremy Orlow. Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType(). https://bugs.webkit.org/show_bug.cgi?id=36426 * src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail): 2010-03-24 Jay Campan Reviewed by Darin Fisher. Making Chromium select popups not steal activation from the browser. Select popups are now like autocomplete popups, shown in non-activated windows. https://bugs.webkit.org/show_bug.cgi?id=36062 * public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu): * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed): * src/ChromeClientImpl.h: * src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions): * src/WebViewImpl.h: 2010-03-24 Alexander Pavlov Reviewed by Pavel Feldman. Web Inspector: [Chromium] Audits never complete https://bugs.webkit.org/show_bug.cgi?id=36544 * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): 2010-03-24 Alexander Pavlov Reviewed by Pavel Feldman. [Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp https://bugs.webkit.org/show_bug.cgi?id=36524 * src/WebInputEvent.cpp: (WebKit::staticKeyIdentifiers): 2010-03-24 Kent Tamura Reviewed by Darin Adler. Make Icon::createIconForFiles() optional. https://bugs.webkit.org/show_bug.cgi?id=35072 - Rename iconForFiles() to chooseIconForFiles(). - Call Icon::createIconForFiles() from chooseIconForFiles(). * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles): * src/ChromeClientImpl.h: 2010-03-23 Kenneth Russell Unreviewed build fix. Add #include to fix Chromium Linux build. * src/WebGraphicsContext3DDefaultImpl.cpp: 2010-03-23 Nate Chapin Unreviewed, revert r56376. This revision introduced a crash in a couple of layout tests on Chromium Linux. * public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu): * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): * src/ChromeClientImpl.h: * src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions): * src/WebViewImpl.h: 2010-03-23 Sergey Ulanov Reviewed by Dmitry Titov. Changes needed to implement Show/Hide Controls command for