2010-06-13 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin support for Notifications UI https://bugs.webkit.org/show_bug.cgi?id=40005 Add an interface to the platform plugin to display notifications. Implemented the notification in the example platform plugin. This interface is enabled by default, but could be turned off with a build flag. The platform plugin should control its own lifecycle, so now the close timer applies only when using the QSystemTrayIcon. That's because QSystemTrayIcon does not inform its caller when it is closed. Changed the way NotificationPresenterClientQt is deleted because it is being accessed when GC is deleting the Notification objects. NotificationPresenterClientQt is now detaching itself from the Notifications before it is deleted. * Api/qwebkitplatformplugin.h: (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebKitPlatformPlugin::): * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationIconWrapper::NotificationIconWrapper): (WebCore::NotificationIconWrapper::title): (WebCore::NotificationIconWrapper::message): (WebCore::NotificationIconWrapper::iconData): (WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt): (WebCore::NotificationIconWrapper::notificationClosed): (WebCore::NotificationPresenterClientQt::displayNotification): (WebCore::NotificationPresenterClientQt::cancel): (WebCore::NotificationPresenterClientQt::notificationForWrapper): (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): (WebCore::NotificationPresenterClientQt::detachNotification): * WebCoreSupport/NotificationPresenterClientQt.h: * WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createNotificationPresenter): * WebCoreSupport/QtPlatformPlugin.h: * examples/platformplugin/WebNotificationPresenter.cpp: Added. (WebNotificationWidget::WebNotificationWidget): (WebNotificationWidget::~WebNotificationWidget): (WebNotificationWidget::showNotification): (WebNotificationWidget::event): * examples/platformplugin/WebNotificationPresenter.h: Added. (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter): (WebNotificationPresenter::showNotification): * examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): * examples/platformplugin/WebPlugin.h: (WebPlugin::createNotificationPresenter): * examples/platformplugin/platformplugin.pro: * examples/platformplugin/qwebkitplatformplugin.h: (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebKitPlatformPlugin::): 2010-06-14 Mahesh Kulkarni Reviewed by Laszlo Gombos. [Qt] navigator.geolocation support for Qt port https://bugs.webkit.org/show_bug.cgi?id=39724 Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest Layout and unit test cases for the are also added. * Api/qwebpage.cpp: (QWebPage::allowGeolocationRequest): * Api/qwebpage.h: * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMockGeolocationPosition): (DumpRenderTreeSupportQt::setMockGeolocationError): * WebCoreSupport/DumpRenderTreeSupportQt.h: * tests/qwebpage/tst_qwebpage.cpp: (JSTestPage::shouldInterruptJavaScript): (JSTestPage::allowGeolocationRequest): (JSTestPage::setGeolocationPermission): (tst_QWebPage::geolocationRequestJS): 2010-06-14 Ilya Tikhonovsky Reviewed by Pavel Feldman. WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc data from inspected page to WebInspector as JSON string via http. The native serialization to JSON string is supported by InspectorValue's classes. This patch has the implementation of sendMessageToFrontend function. WebKit version of it still uses ScriptFunctionCall and will be switched to another transport a little bit later. https://bugs.webkit.org/show_bug.cgi?id=40134 * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorClientQt::sendMessageToFrontend): * WebCoreSupport/InspectorClientQt.h: 2010-06-13 Charles Wei Reviewed by George Staikos. Fix the QtWebKit which doesn't recognize the MIME type of HTML/TEXT in uppercase https://bugs.webkit.org/show_bug.cgi?id=39492 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType): 2010-06-08 Robert Hogan Reviewed by Eric Seidel. [Qt] Add support for callShouldCloseOnWebView() to DRT https://bugs.webkit.org/show_bug.cgi?id=40330 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shouldClose): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-06-12 Dawit Alemayehu Reviewed by Kenneth Rohde Christiansen. Added an attribute to enable/disable site specific quirks mode in WebKit. The attribute is enabled by default. https://bugs.webkit.org/show_bug.cgi?id=40073 * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings): * Api/qwebsettings.h: 2010-06-12 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Fix tst_qwebframe regression from http://trac.webkit.org/changeset/61062 Only use cacheableBindingRootObject() if the object has QtOwnership. https://bugs.webkit.org/show_bug.cgi?id=40527 * Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject): 2010-06-13 Robert Hogan Reviewed by Alexey Proskuryakov. FrameLoader::clear() clears JS objects that cached pages later rely on https://bugs.webkit.org/show_bug.cgi?id=37725 https://bugs.webkit.org/show_bug.cgi?id=31626 Fix the following tests for Qt: fast/events/pageshow-pagehide-on-back-cached.html fast/events/pageshow-pagehide-on-back-cached-with-frames.html fast/loader/input-element-page-cache-crash.html fast/dom/Window/timer-resume-on-navigation-back.html loader/go-back-to-different-window-size.html fast/dom/javascript-url-crash-function.html fast/dom/location-new-window-no-crash.html http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html which currently fail because the page's Qt-bindings runtime objects are cleared when navigating away from the page containing them. Track Qt-bindings objects in a separate ScriptController::cacheableRootBindingObject(). RuntimeObjects tracked by this root object will not get invalidated on page navigations, so they will still be available when the pages containing them are retrieved from the b/f cache. This means the Qt bindings objects will only get cleared on Frame::pageDestroyed(). * Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject): 2010-06-12 No'am Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] Add documentation to the QtWebkit bridge https://bugs.webkit.org/show_bug.cgi?id=35861 The previous accepted patch was actually a faulty one; It was hard to trace since it's just a documentation change. The new patch amends that, with the correct snippets and grammar fixes. * docs/qtwebkit-bridge.qdoc: * docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): 2010-06-12 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Back-forward list dumping is incorrect https://bugs.webkit.org/show_bug.cgi?id=36392 Support dumping child history items in DRT. Unskip: fast/loader/frame-src-change-added-to-history.html fast/loader/frame-src-change-not-added-to-history.html fast/loader/frame-location-change-not-added-to-history.html * Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core): * Api/qwebhistory.h: * Api/qwebhistory_p.h: * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isTargetItem): (DumpRenderTreeSupportQt::historyItemTarget): (DumpRenderTreeSupportQt::getChildHistoryItems): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-06-11 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. [Qt] Typo error in QWebPluginFactory Documentation https://bugs.webkit.org/show_bug.cgi?id=40490 * Api/qwebpluginfactory.cpp: 2010-06-11 Jocelyn Turcotte Reviewed by nobody, build fix. [Qt] Second fix attempt for the build break introduced by r61002. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): 2010-06-11 Jocelyn Turcotte Reviewed by nobody, build fix. [Qt] Fix build break introduced by r61002. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): 2010-05-31 Jocelyn Turcotte Reviewed by Simon Hausmann. [Qt] Implement the simple text code path. https://bugs.webkit.org/show_bug.cgi?id=40077 Remove the FONT_FAST_PATH macro and use the Qt's fast text implementation instead of the one of WebKit. The Qt::TextBypassShaping flag is used to tell Qt to only use the glyph advances. Qt 4.7 is needed to get this flag thus the complex path is always used if QtWebKit is compiled against an earlier version. Contrary to the WebKit's implementation, the complex code path is taken if the text is RightToLeft, justified or is formatted with non-zero letter or word spacing. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): 2010-06-10 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] Support for loading notification icons https://bugs.webkit.org/show_bug.cgi?id=40004 Take into use the icon that was loaded for the notification. * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::show): 2010-06-10 Mahesh Kulkarni Reviewed by Simon Hausmann. [Qt] Memory leak in qwebpage unit test cases https://bugs.webkit.org/show_bug.cgi?id=40405 * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS): 2010-06-10 Raine Makelainen Reviewed by Kenneth Rohde Christiansen. Impossible to set input method hints based HTML5 input types https://bugs.webkit.org/show_bug.cgi?id=40107 EditorClientQt to set input method hints for "number", "tel", "email", and "url" HTML input elements. Tests for HTML input elements and input method hints added for QGraphicsWebView and QWebView. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState): * tests/qgraphicswebview/resources/input_types.html: Added. * tests/qgraphicswebview/tst_qgraphicswebview.cpp: (GraphicsWebView::GraphicsWebView): (GraphicsWebView::fireMouseClick): (tst_QGraphicsWebView::focusInputTypes): * tests/qgraphicswebview/tst_qgraphicswebview.qrc: Added. * tests/qwebview/resources/input_types.html: Added. * tests/qwebview/tst_qwebview.cpp: (WebView::fireMouseClick): (tst_QWebView::focusInputTypes): * tests/qwebview/tst_qwebview.qrc: 2010-06-10 Eric Seidel Reviewed by Adam Barth. Reduce FrameView.h includes to speed up build times https://bugs.webkit.org/show_bug.cgi?id=40408 * Api/qwebframe.cpp: - Include RenderLayer.h since it's used in this file. 2010-06-10 Andy Shaw Reviewed by Simon Hausmann. REGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default https://bugs.webkit.org/show_bug.cgi?id=40401 The correct pattern in Qt for Dnd events is to use acceptProposedAction() instead of accept(). * Api/qwebpage.cpp: (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent): 2010-06-09 Pierre Rossi Reviewed by Kenneth Rohde Christiansen. QWebPage::findText() does not clear selection when passed empty string https://bugs.webkit.org/show_bug.cgi?id=31779 * Api/qwebpage.cpp: (QWebPage::findText): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::findText): 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] PageClientQt.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40257 * WebCoreSupport/PageClientQt.h: 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] InspectorClientQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40255 * WebCoreSupport/InspectorClientQt.cpp: 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] FrameLoaderClientQt.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40251 * WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent): 2010-06-09 Anders Bakken Reviewed by Kenneth Rohde Christiansen. [Qt] EditorClientQt.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40249 * WebCoreSupport/EditorClientQt.h: 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] EditCommandQt.cpp/h have coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40248 * WebCoreSupport/EditCommandQt.cpp: (EditCommandQt::EditCommandQt): (EditCommandQt::~EditCommandQt): (EditCommandQt::redo): (EditCommandQt::undo): * WebCoreSupport/EditCommandQt.h: 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] DumpRenderTreeSupportQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40247 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::firstRectForCharacterRange): 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] DragClientQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40246 * WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag): 2010-06-09 Anders Bakken Reviewed by Laszlo Gombos. [Qt] ContextMenuClientQt.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40242 * WebCoreSupport/ContextMenuClientQt.h: 2010-06-09 Anders Bakken Reviewed by David Levin. [Qt] ChromeClientQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40240 * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::print): (WebCore::ChromeClientQt::attachRootGraphicsLayer): (WebCore::ChromeClientQt::visibleRectForTiledBackingStore): 2010-06-09 Sheriff Bot Unreviewed, rolling out r60889. http://trac.webkit.org/changeset/60889 https://bugs.webkit.org/show_bug.cgi?id=40365 gtk bot has some kind of memory corruption (Requested by loislo on #webkit). * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt): (WebCore::InspectorFrontendClientQt::closeWindow): * WebCoreSupport/InspectorClientQt.h: 2010-06-07 Ilya Tikhonovsky Reviewed by Pavel Feldman. WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc data from inspected page to WebInspector as JSON string via http. The native serialization to JSON string is supported by InspectorValue's classes. This patch has the implementation of sendMessageToFrontend function. WebKit version of it still uses ScriptFunctionCall and will be switched to another transport a little bit later. https://bugs.webkit.org/show_bug.cgi?id=40134 * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorClientQt::sendMessageToFrontend): * WebCoreSupport/InspectorClientQt.h: 2010-06-08 Antonio Gomes Reviewed by Ojan Vafai and Darin Adler. Refactor platform dependent editing behavior code out of Settings https://bugs.webkit.org/show_bug.cgi?id=39854 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setEditingBehavior): 2010-06-07 Anders Bakken Reviewed by David Levin. [Qt] NotificationPresenterClientQt.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=40256 * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::show): 2010-06-06 Antonio Gomes , Laszlo Gombos Reviewed by Kenneth Christiansen, Eric Seidel. [Qt] Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=39680 Make setEditingBehavior() a no-operation if the editingBehavior argument is not recognized to avoid using an uninitialized variable. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setEditingBehavior): 2010-06-04 Laszlo Gombos Symbian build fix. [Qt] Updated the def file with recent new exports. * symbian/eabi/QtWebKitu.def: 2010-06-03 Yael Aharon Reviewed by Laszlo Gombos. [Qt] Don't send notifications event after the page was navigated away https://bugs.webkit.org/show_bug.cgi?id=40127 Added a check before sending events to the notification and before logging. * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::cancel): (WebCore::NotificationPresenterClientQt::sendEvent): 2010-06-02 Tasuku Suzuki Reviewed by Shinichiro Hamaji. [Qt] Fix compilation with QT_NO_PROPERTIES https://bugs.webkit.org/show_bug.cgi?id=38324 * Api/qwebpage.cpp: (QWebPage::event): * Api/qwebpage_p.h: * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): 2010-06-02 Luiz Agostini Reviewed by Simon Hausmann. [Qt] Shared platform plugin https://bugs.webkit.org/show_bug.cgi?id=39968 Allow several instances of class QtPlatformPlugin to share the QWebKitPlatformPlugin object provided by a plugin. Updated plugin interface version number due to ABI breaking change. * Api/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): * WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::load): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin): * WebCoreSupport/QtPlatformPlugin.h: * examples/platformplugin/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): 2010-06-02 Raine Makelainen Reviewed by Kenneth Rohde Christiansen. [Qt] On Maemo6 platform auto upper case and predictive text input method hints are not disabled for password field. https://bugs.webkit.org/show_bug.cgi?id=40062 Introducing Q_WS_MAEMO_6 for Maemo6 specific code. Enabling code that sets input method hints Qt::ImhNoAutoUppercase and Qt::ImhNoPredictiveText true for Maemo6. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState): 2010-06-01 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] Fix the lifecycle of notification objects https://bugs.webkit.org/show_bug.cgi?id=40003 Notification objects are not tightly related to the page that created them, and should be decoupled from the page. Create one NotificationPresenter that handles all notifications. Add ref/deref to the notification objects when they are added/removed from the queue of active notifications. The same technique is used for XMLHttpRequest. Instead of deleting all notifications associated with a page when the page is navigated, delete them on a timer, using the same timeout that QSystemTrayIcon is using. Break up the show() method into smaller methods. Use OwnPtr instead of raw pointer for QSystemTrayIcon. Move creating the QIcon to just before showing it in the QSyetemTrayIcon. No new tests as this is just a refactoring. Existing notifications test cover the code. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::~QWebPagePrivate): * Api/qwebpage_p.h: * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setNotificationsReceiver): (DumpRenderTreeSupportQt::allowNotificationForOrigin): * WebCoreSupport/DumpRenderTreeSupportQt.h: * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): * WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::notificationPresenter): (WebCore::NotificationIconWrapper::NotificationIconWrapper): (WebCore::NotificationIconWrapper::~NotificationIconWrapper): (WebCore::NotificationIconWrapper::close): (WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt): (WebCore::NotificationPresenterClientQt::removeClient): (WebCore::NotificationPresenterClientQt::show): (WebCore::NotificationPresenterClientQt::displayNotification): (WebCore::NotificationPresenterClientQt::cancel): (WebCore::NotificationPresenterClientQt::notificationObjectDestroyed): (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::sendEvent): (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): (WebCore::NotificationPresenterClientQt::dumpReplacedIdText): (WebCore::NotificationPresenterClientQt::dumpShowText): * WebCoreSupport/NotificationPresenterClientQt.h: (WebCore::NotificationPresenterClientQt::addClient): 2010-06-01 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] Add documentation to the QtWebkit bridge https://bugs.webkit.org/show_bug.cgi?id=35861 This patch includes comprehensive qdoc documentation for the QtWebkit bridge. * docs/qtwebkit-bridge.qdoc: Added. * docs/qtwebkit.qdoc: * docs/webkitsnippets/doc_src_qtscript.qdoc: Added. * docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Added. (wrapInFunction): 2010-06-01 Raine Makelainen Reviewed by Simon Hausmann. [Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part. https://bugs.webkit.org/show_bug.cgi?id=39878 QWebSettings::JavaScriptCanAccessClipboard reverted back to QWebSettings::JavascriptCanAccessClipboard. QWebSettings::DOMPasteAllowed enum removed. Value of QWebSettings::JavascriptCanAccessClipboard to setDOMPasteAllowed and setJavaScriptCanAccessClipboard of WebCore::Settings. * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): * Api/qwebsettings.h: 2010-06-01 Simon Hausmann Reviewed by Laszlo Gombos. [Qt] Rename versioning .pri file to what Qt's mkspecs/features/qt.pri expects. * qt_webkit_version.pri: Renamed from WebKit/qt/qtwebkit_version.pri. 2010-05-31 Lyon Chen Reviewed by Kent Tamura. Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts. https://bugs.webkit.org/show_bug.cgi?id=35530 Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): 2010-05-31 Oswald Buddenhagen Reviewed by Simon Hausmann. [Qt] Escape backslashes in the .pro files qmake in Qt 4.7 warns about unescaped backspaces and deprecates them. * Api/DerivedSources.pro: * docs/docs.pri: 2010-05-30 Lyon Chen Reviewed by Kent Tamura. This is a coding style cleanup before fixing to bug 35530. Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts. https://bugs.webkit.org/show_bug.cgi?id=35530 * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::registerCommandForUndo): (WebCore::EditorClientQt::handleKeyboardEvent): 2010-05-29 Dawit Alemayehu Reviewed by Kenneth Rohde Christiansen. Added a WebAction to stop all pending page refresh/redirect requests set through the tag. https://bugs.webkit.org/show_bug.cgi?id=29899 * Api/qwebpage.cpp: (QWebPage::triggerAction): * Api/qwebpage.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testStopScheduledPageRefresh): 2010-05-28 Antti Koivisto Reviewed by Kenneth Rohde Christiansen. Add a missing #if ENABLE(), some null checking. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): 2010-05-28 Antti Koivisto Reviewed by Kenneth Rohde Christiansen. https://bugs.webkit.org/show_bug.cgi?id=39874 [Qt] Make tiled backing store more configurable Make tile size, tile creation delay and tiling area dynamically configurable. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): 2010-05-28 Yael Aharon Unreviewed build fix after r60348. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setNotificationsReceiver): 2010-05-28 Yael Aharon Reviewed by Laszlo Gombos. [Qt] Pass all web notification layout tests https://bugs.webkit.org/show_bug.cgi?id=39146 Add support for multiple simultaneous notifications. Add a private callback mechanism to the client for security checks. Notifications are disabled if the client does not set the callbacks. Support replaceId and cancel. Send close and display events when needed. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setNotificationsReceiver): (DumpRenderTreeSupportQt::allowNotificationForOrigin): (DumpRenderTreeSupportQt::setCheckPermissionFunction): (DumpRenderTreeSupportQt::setRequestPermissionFunction): * WebCoreSupport/DumpRenderTreeSupportQt.h: * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): * WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationIconWrapper::NotificationIconWrapper): (NotificationIconWrapper::~NotificationIconWrapper): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission): (NotificationPresenterClientQt::allowNotificationForOrigin): (NotificationPresenterClientQt::clearNotificationsList): (NotificationPresenterClientQt::sendEvent): * WebCoreSupport/NotificationPresenterClientQt.h: (WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt): (WebCore::NotificationPresenterClientQt::setReceiver): 2010-05-27 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin example https://bugs.webkit.org/show_bug.cgi?id=39489 Adding a Qt platform plugin example to repository. * examples/platformplugin/README: Added. * examples/platformplugin/WebPlugin.cpp: Added. (Popup::populateList): (Popup::onItemSelected): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleItemListDelegate::MultipleItemListDelegate): (MultipleItemListDelegate::paint): (MultipleSelectionPopup::MultipleSelectionPopup): (WebPlugin::supportsExtension): * examples/platformplugin/WebPlugin.h: Added. (Popup::Popup): (WebPlugin::createSelectInputMethod): * examples/platformplugin/platformplugin.pro: Added. * examples/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectData::): (QWebSelectMethod::~QWebSelectMethod): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): (QWebKitPlatformPlugin::): 2010-05-25 Antonio Gomes Reviewed by Ojan Vafai. [Qt] Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=39680 Add support to Qt's DRT to setting the editing behavior. Patch is a follow up of bug 38603, which just stubbed out the Qt bits of it. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: Implementation of editing behavior control. (DumpRenderTreeSupportQt::setEditingBehavior): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-05-24 Robert Hogan Reviewed by Laszlo Gombos. [Qt] DRT Support for removeOriginAccessWhitelistEntry Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html [Qt] DRT Support for removeOriginAccessWhitelistEntry https://bugs.webkit.org/show_bug.cgi?id=39565 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::removeWhiteListAccessFromOrigin): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-05-24 Darin Adler Reviewed by Eric Seidel. Move view-related functions from Frame to FrameView https://bugs.webkit.org/show_bug.cgi?id=39366 * Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): Call functions on FrameView. (QWebFrame::textSizeMultiplier): Ditto. (QWebFrame::setZoomFactor): Ditto. (QWebFrame::zoomFactor): Ditto. * Api/qwebpage.cpp: (QWebPage::setContentEditable): Removed call to empty function, removeEditingStyleFromBodyElement. 2010-05-23 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] GraphicsLayer: The rocket animation doesn't scroll together with the page https://bugs.webkit.org/show_bug.cgi?id=39517 A previous fix to this issue was overridden by the PageClientQt refactor. Reapplying. * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::update): 2010-05-23 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] Update the Symbian version for the user agent https://bugs.webkit.org/show_bug.cgi?id=38389 Fixes a regression introduced by r58648. Ensure that the "Symbian" string is only listed one time in the User Agent string. In addition make an effort to align the User Agent string to already released WebKit based products for Symbian. * Api/qwebpage.cpp: (QWebPage::userAgentForUrl): 2010-05-21 Steve Block Reviewed by Jeremy Orlow. Add DeviceOrientation and DeviceOrientationClient https://bugs.webkit.org/show_bug.cgi?id=39479 * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): 2010-05-21 Simon Hausmann Symbian build fix. [Qt] Updated the wins def file with one new export. The DRT symbols are still missing, but I can't build DRT ;( * symbian/bwins/QtWebKitu.def: 2010-05-20 Janne Koskinen Reviewed by Kenneth Rohde Christiansen. [Qt] WINSCW compile fix for qwebframe test https://bugs.webkit.org/show_bug.cgi?id=38722 WINSCW cannot determine template type up the hierarchy to common base class. * tests/qwebframe/tst_qwebframe.cpp: 2010-05-20 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. Remove unused "old style" private APIs These symbols were introduced after QtWebKit v4.6 so no-one should be using them * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 2010-05-20 Rajiv Ramanasankaran Reviewed by Simon Hausmann. [Qt] QWebPage::inputMethodQuery() returns wrong values for Qt::ImCursorPosition, Qt::ImAnchorPosition https://bugs.webkit.org/show_bug.cgi?id=38779 The earlier implementation was written with the assumption that in this scenario the anchor position always corresponds to the START index and that the current cursor position always corresponds to the END index in WebKit. Updated the implementation of QWebPage::inputMethodQuery(Qt::ImCursorPosition) and QWebPage::inputMethodQuery(Qt::ImAnchorPosition) for the case where the Editor is not in composition mode. In the non-composition mode, the Anchor and the Current cursor positions correspond to the Base and Extent position offsets in WebKit. Also added the auto-tests for the RIGHT to LEFT and LEFT to RIGHT selections. * Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Now returning correct values for Qt::ImCursorPosition and Qt::ImAnchorPosition when the Editor is not in composition mode. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Added auto-tests for RIGHT to LEFT and LEFT to RIGHT selections 2010-05-20 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Skipping popup focus test for maemo https://bugs.webkit.org/show_bug.cgi?id=39314 Skipping popup focus test for maemo in qwebframe auto test. The test method tst_QWebFrame::popupFocus() was testing popup focus AND input field focus. The input field focus has been removed from the method popupFocus() and a new test method named inputFieldFocus() has been added. Finally the test method popupFocus() has been skipped for maemo. * tests/qwebframe/tst_qwebframe.cpp: 2010-05-19 Jedrzej Nowacki Reviewed by Kenneth Rohde Christiansen. Crash fix in the HistoryController. The problem was casued by a documented feature of the QWebFrame::setHtml(). The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so m_currentItem and m_previousItem are not set. A null check was added. [Qt] The QWebPage crashes on history.pushState(). https://bugs.webkit.org/show_bug.cgi?id=38840 * tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::popPushState_data): (tst_QWebHistory::popPushState): 2010-05-19 Antti Koivisto Rubber-stamped by Kenneth Rohde Christiansen. [Qt] TiledBackingStore updates broken when not using resizesToContents mode https://bugs.webkit.org/show_bug.cgi?id=39359 Put the back logic that was lost in refactoring. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::visibleRectForTiledBackingStore): * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect): * WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::viewResizesToContentsEnabled): (WebCore::PageClientQGraphicsWidget::viewResizesToContentsEnabled): 2010-05-19 Simon Hausmann Symbian build fix. [Qt] Updated the def file with exports needed for DumpRenderTree. * symbian/eabi/QtWebKitu.def: 2010-05-19 Denis Dzyubenko Reviewed by Kenneth Rohde Christiansen. When creating the UA, do not sassmue the language code is a two-letter iso639-1 code. * Api/qwebpage.cpp: (QWebPage::userAgentForUrl): 2010-05-18 Antti Koivisto Reviewed by Kenneth Rohde Christiansen. [Qt] Move visible rect calculation from QGraphicsWebViewPrivate to PageClientQGraphicsWidget https://bugs.webkit.org/show_bug.cgi?id=39294 * Api/qgraphicswebview.cpp: * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect): * WebCoreSupport/PageClientQt.h: 2010-05-18 Laszlo Gombos Symbian build fix. [Qt] Updated the def file with new exports after r59335. * symbian/eabi/QtWebKitu.def: 2010-05-18 Jedrzej Nowacki Reviewed by Simon Hausmann. Fix QWebHistory serialization. Regression was caused by bug 33224. The streaming function should generate a documentSequenceNumber for all loaded values. [Qt] tst_QWebHistory::serialize_2() fails https://bugs.webkit.org/show_bug.cgi?id=37322 * Api/qwebhistory.cpp: (operator>>): 2010-05-17 Tasuku Suzuki Reviewed by Kenneth Rohde Christiansen. [Qt] Fix compilation with QT_NO_COMBOBOX https://bugs.webkit.org/show_bug.cgi?id=38324 * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup): * WebCoreSupport/QtFallbackWebPopup.cpp: * WebCoreSupport/QtFallbackWebPopup.h: 2010-05-17 Antti Koivisto Reviewed by Kenneth Rohde Christiansen. https://bugs.webkit.org/show_bug.cgi?id=39218 [Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation Tiles sometimes flicker when exiting a zoom animation. This happens as a result of the visible rectangle being momentarily out of sync. Instead of updating the visible rect by explicitly setting it, pull it through the client and recompute in WebKit the level. * Api/qgraphicswebview.cpp: (QGraphicsWebView::paint): * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::visibleRectForTiledBackingStore): * WebCoreSupport/ChromeClientQt.h: 2010-05-16 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Unskip fast/loader/main-document-url-for-non-http-loads.html Fix FrameLoaderClientQt.cpp to print relative filename paths correctly. Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt. Support for the old function names is retained until confirmed that no one uses them outside QtWebKit. https://bugs.webkit.org/show_bug.cgi?id=38867 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpFrameLoader): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull): (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders): (DumpRenderTreeSupportQt::dumpEditingCallbacks): (DumpRenderTreeSupportQt::dumpSetAcceptsEditing): (DumpRenderTreeSupportQt::dumpNotification): (qt_dump_frame_loader): (qt_dump_resource_load_callbacks): (qt_dump_resource_load_callbacks_path): (qt_set_will_send_request_returns_null_on_redirect): (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (qt_dump_editing_callbacks): (qt_dump_set_accepts_editing): (qt_dump_notification): * WebCoreSupport/DumpRenderTreeSupportQt.h: * WebCoreSupport/EditorClientQt.cpp: * WebCoreSupport/EditorClientQt.h: * WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult): * WebCoreSupport/FrameLoaderClientQt.h: * WebCoreSupport/NotificationPresenterClientQt.cpp: * WebCoreSupport/NotificationPresenterClientQt.h: 2010-05-16 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt]Unskip security/set-form-autocomplete-attribute.html Add support for layoutTestController.elementDoesAutoCompleteForElementWithId(). https://bugs.webkit.org/show_bug.cgi?id=38859 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-05-16 Simon Hausmann [Qt] Prospective Qt/Mac build fix. The friend declaration of QGraphicsWidget confuses gcc and thinks that it's an implicit forward declaration, moving the class into the WebCore namespace (WebCore::QGraphicsWidget). The declaration seems useless as no method of QGraphicsWidget is going to call anything in this class. * WebCoreSupport/PageClientQt.h: 2010-05-15 Charles Wei Reviewed by Simon Hausmann. This patch fixes the build failure of WebKit on Linux for Qt4.5 https://bugs.webkig.org/show_bug.cgi?id=39108 * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::syncLayers): * WebCoreSupport/QtPlatformPlugin.cpp: 2010-05-14 Kent Hansen , Jocelyn Turcotte , Tor Arne Vestbø , Henry Haverinen , Jedrzej Nowacki , Andreas Kling Reviewed by Simon Hausmann. [Qt] Merge overhaul of the QtWebKit API documentation Numerous improvements in wording, qdoc warning fixes and clarifications, done in a team work effort. No functional changes. * Api/qwebdatabase.cpp: * Api/qwebelement.cpp: * Api/qwebframe.cpp: * Api/qwebhistoryinterface.cpp: * Api/qwebinspector.cpp: * Api/qwebkitversion.cpp: * Api/qwebpage.cpp: * Api/qwebpluginfactory.cpp: * Api/qwebsecurityorigin.cpp: * Api/qwebsettings.cpp: * Api/qwebsettings.h: * docs/qtwebkit.qdoc: * docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: (wrapInFunction): * docs/webkitsnippets/webelement/main.cpp: (findButtonAndClick): (autocomplete1): (autocomplete2): (main): 2010-05-14 Martin Smith Reviewed by Simon Hausmann. Documentation: Fix overview grouping. * docs/qtwebkit.qdoc: 2010-05-14 Benjamin Poulain Reviewed by Laszlo Gombos. [QT] Update the Symbian version for the user agent https://bugs.webkit.org/show_bug.cgi?id=38389 Update the user agent for Symbian^2 to Symbian^4 * Api/qwebpage.cpp: (QWebPage::userAgentForUrl): 2010-05-14 Dawit Alemayehu Reviewed by Simon Hausmann. Implemented createJavaAppletWidget to activate Java applet support. https://bugs.webkit.org/show_bug.cgi?id=33044 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createJavaAppletWidget): 2010-05-13 Simon Hausmann Symbian build fix. [Qt] Updated the def file with new exports. * symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher 2010-05-13 Simon Hausmann Symbian build fix. [Qt] Updated the def file with new exports. * symbian/eabi/QtWebKitu.def: 2010-05-11 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] tst_QWebPage::inputMethods failing on Maemo5 https://bugs.webkit.org/show_bug.cgi?id=38685 Check if the SIP (Software Input Panel) is triggered, which normally happens on mobile platforms, when a user input form receives a mouse click. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): 2010-05-11 Kenneth Rohde Christiansen Reviewed by Laszlo Gombos. [Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing https://bugs.webkit.org/show_bug.cgi?id=38655 Fix double free by moving the connect till after the resize. The bug is causes by the fact that a resize of an empty page causes a layout, thus deleting the qgraphicswebview before setHtml is called, which then deletes it again, causing a double free. * tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnViewlessWebPages): 2010-05-12 Kenneth Rohde Christiansen Reviewed by Laszlo Gombos. [Qt] Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view https://bugs.webkit.org/show_bug.cgi?id=39016 Some forward calls got lost during the refatory. * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): 2010-05-13 Antonio Gomes , Yi Shen Reviewed by Kenneth Christiansen. [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo https://bugs.webkit.org/show_bug.cgi?id=37759 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-05-12 Joe Ligman Reviewed by Laszlo Gombos. [Qt] Nested overflow div does not scroll https://bugs.webkit.org/show_bug.cgi?id=38641 Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer does not scroll it will try and scroll the parent's render layer. Also export qtwebkit_webframe_scrollOverflow so we can use it independently of qtwebkit_webframe_scrollRecursively * Api/qwebframe.cpp: (qtwebkit_webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively): 2010-05-12 Antonio Gomes Reviewed by Kenneth Christiansen. [Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage https://bugs.webkit.org/show_bug.cgi?id=38989 Reasons: - There is no need to check for a QWidgetPageClient-based in QGraphicsWebView. - The client has always to be deleted anyways. * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachPage): 2010-05-12 Simon Hausmann Reviewed by Laszlo Gombos. Add a comment to explain the web inspector dynamic property url hook and that it's there on purpose :) https://bugs.webkit.org/show_bug.cgi?id=35340 * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): 2010-05-11 Antonio Gomes Reviewed by Kenneth Christiansen. [Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView https://bugs.webkit.org/show_bug.cgi?id=38939 unsetPageIfExists method was renamed to detachCurrentPage method and is now responsible for doing all the unset logic of page and pageClient references previously done by the Q{Graphics}WebView destructor(s). It is a code clean up, no behaviour change. * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebView::~QGraphicsWebView): (QGraphicsWebViewPrivate::detachCurrentPage): (QGraphicsWebView::setPage): * Api/qwebview.cpp: (QWebViewPrivate::~QWebViewPrivate): (QWebView::~QWebView): (QWebViewPrivate::detachCurrentPage): (QWebView::setPage): 2010-05-11 Antonio Gomes Reviewed by Kenneth Christiansen. [Qt] emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout https://bugs.webkit.org/show_bug.cgi?id=38921 Emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout instead of FrameLoaderClientQt::dispatchDidFirstLayout , because the former ensures that a visual content layed out on the frame. It matches to QWebFrame::initialLayoutCompleted signal documentation at: "... This is the first time you will see contents displayed on the frame ..." * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout): 2010-05-11 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. Add PageClientQGraphicsWidget specific implementation. QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore and the needed functions were moved to this new PageClient class, including Tiling and Accelerated Composite specific ones. [Qt] PageClientQt specific implementation for QGraphicsWidget https://bugs.webkit.org/show_bug.cgi?id=37866 * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebView::event): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry): (QGraphicsWebView::setResizesToContents): * WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHint): (WebCore::PageClientQGraphicsWidget::cursor): (WebCore::PageClientQGraphicsWidget::updateCursor): (WebCore::PageClientQGraphicsWidget::palette): (WebCore::PageClientQGraphicsWidget::screenNumber): (WebCore::PageClientQGraphicsWidget::ownerWidget): (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQGraphicsWidget::pluginParent): (WebCore::PageClientQGraphicsWidget::style): * WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page): (WebCore::QGraphicsItemOverlay::boundingRect): (WebCore::QGraphicsItemOverlay::paint): (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::isQWidgetClient): (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::): 2010-05-09 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used https://bugs.webkit.org/show_bug.cgi?id=38574 The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView. * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::setRootGraphicsLayer): (QGraphicsWebViewPrivate::updateCompositingScrollPosition): 2010-05-08 Luiz Agostini Reviewed by Simon Hausmann. [Qt] Platform plugin https://bugs.webkit.org/show_bug.cgi?id=38438 Select popups delegate private API. To provide select popup delegates a plugin that implements QWebKitPlatformPlugin must be found in QCoreApplication::libraryPaths. * Api/headers.pri: * Api/qwebkitplatformplugin.h: Added. (QWebSelectData::~QWebSelectData): (QWebSelectData::): (QWebSelectMethod::~QWebSelectMethod): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): (QWebKitPlatformPlugin::): * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup): * WebCoreSupport/ChromeClientQt.h: * WebCoreSupport/QtPlatformPlugin.cpp: Added. (WebCore::SelectData::SelectData): (WebCore::SelectData::itemText): (WebCore::SelectData::itemToolTip): (WebCore::SelectData::itemIsEnabled): (WebCore::SelectData::itemCount): (WebCore::SelectData::itemIsSelected): (WebCore::SelectData::multiple): (WebCore::SelectData::itemType): (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show): (WebCore::SelectInputMethodWrapper::hide): (WebCore::SelectInputMethodWrapper::selectItem): (WebCore::SelectInputMethodWrapper::didHide): (WebCore::getPluginObject): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin): (WebCore::QtPlatformPlugin::createSelectInputMethod): * WebCoreSupport/QtPlatformPlugin.h: Added. (WebCore::QtPlatformPlugin::QtPlatformPlugin): 2010-05-08 Jocelyn Turcotte Reviewed by Simon Hausmann. [Qt] Document a limitation of QWebPage::linkClicked https://bugs.webkit.org/show_bug.cgi?id=37694 * Api/qwebpage.cpp: 2010-05-02 Simon Hausmann [Qt] Unreviewed, QtWebKit versioning for the trunk. The next version is going to be 2.1, based off the trunk. * Api/qwebkitglobal.h: 2010-05-07 Simon Hausmann Symbian build fix. [Qt] Updated the def file with absent exports. * symbian/eabi/QtWebKitu.def: 2010-05-06 Andreas Kling Reviewed by Simon Hausmann. [Qt] Patch to fix compilation warnings for QGraphicsWebView https://bugs.webkit.org/show_bug.cgi?id=37428 Patch by Alexis Menard * Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange): 2010-05-06 Simon Hausmann Reviewed by Kenneth Rohde Christiansen. [Qt] Replace public inspector url with private property for QtLauncher https://bugs.webkit.org/show_bug.cgi?id=35340 Replace the public API with a private dynamic property until this feature is ready. * Api/qwebsettings.cpp: * Api/qwebsettings.h: * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): * symbian/bwins/QtWebKitu.def: * symbian/eabi/QtWebKitu.def: 2010-05-04 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] QWebPage viewMode property https://bugs.webkit.org/show_bug.cgi?id=38119 Rename the property from wrt_viewMode to _q_viewMode. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes): 2010-05-04 Simon Hausmann Rubber-stamped by Tor Arne Vestbø. [Qt] Preserve binary compatibility with qtwebkit-2.0 branch Moved the WebGL attribute in QWebSettings to the end of the enum, to ensure that the numeric values of the enum values following it are the same as in the release branch. * Api/qwebsettings.h: 2010-05-03 Laszlo Gombos Reviewed by Simon Hausmann. [Qt] Expose HTMLTokenizer yielding parameters https://bugs.webkit.org/show_bug.cgi?id=37023 Enables to set TimeDelay and ChunkSize for HTMLTokenizer. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): 2010-05-03 Abhishek Arya Reviewed by Adam Barth. Add support for controlling clipboard access from javascript. Clipboard access from javascript is disabled by default. https://bugs.webkit.org/show_bug.cgi?id=27751 * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): * Api/qwebsettings.h: 2010-05-03 Jens Alfke Reviewed by Darin Fisher. [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=38397 No tests (functionality is exposed only through native WebKit API.) * WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent): 2010-05-03 Tor Arne Vestbø Reviewed by Simon Hausmann. [Qt] Prune dead code in QWebPage * Api/qwebpage.cpp: 2010-05-02 Tasuku Suzuki Reviewed by Simon Hausmann. [Qt] Fix compilation with QT_NO_BEARERMANAGEMENT https://bugs.webkit.org/show_bug.cgi?id=38324 * Api/qwebsettings.cpp: 2010-04-29 Janne Koskinen Reviewed by Simon Hausmann. [Qt] QtWebKit versioning added https://bugs.webkit.org/show_bug.cgi?id=37207 QtWebkit releases separated from Qt release cycle. * qtwebkit_version.pri: Added. 2010-05-02 Benjamin Poulain Reviewed by Kenneth Rohde Christiansen. [Qt] QWebPage::userAgentForUrl is terrible API https://bugs.webkit.org/show_bug.cgi?id=33875 Simplify the creation of the user agent string to avoid some overhead for each loaded url. The static part of the user agent is cached so it only have to be made once. This creation has been made in order to simplify the code. The two variable: application name and current language are set dynamically when needed. The default locale is non longer created if the widget locale is used. * Api/qwebpage.cpp: (QWebPage::userAgentForUrl): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::userAgentApplicationName): (tst_QWebPage::userAgentLocaleChange): 2010-05-02 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] GraphicsLayer: animation incorrect when scrolling https://bugs.webkit.org/show_bug.cgi?id=38371 This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update() instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update. Tested by http://www.the-art-of-web.com/css/css-animation/ * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): 2010-05-01 Robert Hogan Reviewed by Simon Hausmann. [Qt] Add smart paste support https://bugs.webkit.org/show_bug.cgi?id=38136 * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Enable smart paste support by default. 2010-04-29 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release https://bugs.webkit.org/show_bug.cgi?id=38304 This change provides backward compatibility with some previously exported private symbols. No new functionality introduced. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (qt_resumeActiveDOMObjects): (qt_suspendActiveDOMObjects): (qt_drt_clearFrameName): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread): (qt_drt_javaScriptObjectsCount): (qt_drt_numberOfActiveAnimations): (qt_drt_overwritePluginDirectories): (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_resetOriginAccessWhiteLists): (qt_drt_run): (qt_drt_setJavaScriptProfilingEnabled): (qt_drt_whiteListAccessFromOrigin): (qt_webpage_groupName): (qt_webpage_setGroupName): 2010-04-29 Benjamin Poulain Reviewed by Kenneth Rohde Christiansen. Get rid of forceLayout() on FrameView https://bugs.webkit.org/show_bug.cgi?id=38199 The function FrameView::forceLayout() is missleading because it does not actually force the layout, the call is equivalent to layout(). This patch replace the call to forceLayout() by layout() in Qt to avoid the misunderstanding/improve readability. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::setPreferredContentsSize): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType): * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::forceLayout): 2010-04-29 Andreas Kling Reviewed by Simon Hausmann. Remove unnecessary call to FrameView::forceLayout() in setViewportSize() This prevents a double relayout on resize. https://bugs.webkit.org/show_bug.cgi?id=38179 Thanks to Nate Whetsell for spotting this. * Api/qwebpage.cpp: (QWebPage::setViewportSize): 2010-04-29 Simon Hausmann Reviewed by Tor Arne Vestbø. [Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes https://bugs.webkit.org/show_bug.cgi?id=38314 Make sure that there's always a main frame when returning from createWindow() to the caller in WebCore. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): 2010-04-28 Laszlo Gombos Unreviewed, Qt build fix. [Qt] Guard the body of the function instead of the function for exported functions. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): 2010-04-28 Antonio Gomes , Yi Shen Reviewed by Simon Hausmann. [Qt] tst_QWebHistoryInterface::visitedLinks() fails https://bugs.webkit.org/show_bug.cgi?id=37323 Patch fixes styleProperty method of QWebElement to make use of CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter and the corresponding failing QWebHistoryInterface::visitedLinks method. * Api/qwebelement.cpp: (QWebElement::styleProperty): * tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp: (tst_QWebHistoryInterface::visitedLinks): 2010-04-28 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] QWebPage viewMode property https://bugs.webkit.org/show_bug.cgi?id=38119 Replacing method qt_wrt_setViewMode by wrt_viewMode property. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::event): * Api/qwebpage_p.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::wrt_viewModes): 2010-04-28 Janne Koskinen Reviewed by Simon Hausmann [Qt] WINS DEF file freeze Updated WINSCW def file with added and removed symbols. * symbian/bwins/QtWebKitu.def: 2010-04-25 Sam Weinig Reviewed by Maciej Stachowiak. Fix for https://bugs.webkit.org/show_bug.cgi?id=38097 Disentangle initializing the main thread from initializing threading * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Add call to initializeMainThread. 2010-04-26 Thiago Macieira Reviewed by Simon Hausmann. [Qt] Fix the include header -> The module/header.h style inclusion removes the need to have -I$QTDIR/include/depending-module in the include search path for the application. * Api/qwebkitversion.h: 2010-04-26 Bruno Schmidt Reviewed by Kenneth Rohde Christiansen. [Qt] Exposing an QVariantMap containing QObjectStar to Javascript causes Segmentation Fault https://bugs.webkit.org/show_bug.cgi?id=34729 If an QVariantMap containing QObjectStar is added to the to QtWebkit Javascript, it's use causes Segmentation Fault. It happens because, in the case QMetaType::QVariantMap, the "root" object that is inside of a PassRefPtr is passed recursively inside a loop to recover the content of the map, but the PassRefPtr semantics prohibit its use inside a loop, so the "root" object mus be passed using the method "PassRefPtr::get" in order to keep the current reference. * tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): new property variantMapProperty (MyQObject::variantMapProperty): read variantMapProperty (MyQObject::setVariantMapProperty): write variantMapProperty 2010-04-25 Shinichiro Hamaji Reviewed by Simon Hausmann. [Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID https://bugs.webkit.org/show_bug.cgi?id=34573 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::counterValueForElementById): 2010-04-20 Robert Hogan Reviewed by Simon Hausmann. [Qt] Add more support for textInputController Add support for selectedRange(), setMarkedText(), insertText(), and firstRectForCharacterRange(). https://bugs.webkit.org/show_bug.cgi?id=35702 * Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::selectedRange): (DumpRenderTreeSupportQt::firstRectForCharacterRange): * WebCoreSupport/DumpRenderTreeSupportQt.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): 2010-04-22 John Pavan Reviewed by Laszlo Gombos. [Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates. https://bugs.webkit.org/show_bug.cgi?id=37163 QWebPage::inputMethodQuery is modified so that it returns coordinates in the widget's coordinate system. Tests are added for QGraphicsWebView and QWebView to verify that this behavior is correct after the webpage has been scrolled. * Api/qwebpage.cpp: (QWebPage::inputMethodQuery): * tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates): * tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates): 2010-04-22 Robert Hogan Reviewed by Simon Hausmann. [Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins when PluginsEnabled is false. tst_qwebpage should have been updated as part of r56662. (See https://bugs.webkit.org/show_bug.cgi?id=32196) Updated documentation of QWebPage::createPlugin and QWebSetting::pluginsEnabled to match the new behaviour. * Api/qwebpage.cpp: Update docs. * Api/qwebsettings.cpp: Update docs. * tests/qwebpage/tst_qwebpage.cpp: (createPlugin): (tst_QWebPage::createPluginWithPluginsEnabled): (tst_QWebPage::createPluginWithPluginsDisabled): 2010-04-22 Dave Moore Reviewed by Dimitri Glazkov. Added notification when the favicons for a page are changed from a script. The Document object will notify the frame loader, which will notify the client. Implementations of FrameLoaderClient will have to add one method; dispatchDidChangeIcons(). https://bugs.webkit.org/show_bug.cgi?id=33812 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::didChangeTitle): * WebCoreSupport/FrameLoaderClientQt.h: 2010-04-22 Jocelyn Turcotte Reviewed by Kenneth Rohde Christiansen. [Qt] Remove translatable strings from the hybridPixmap test. https://bugs.webkit.org/show_bug.cgi?id=37867 * tests/hybridPixmap/widget.ui: 2010-04-22 Jocelyn Turcotte Reviewed by Kenneth Rohde Christiansen. [Qt] Fix autotests .qrc file paths when built in Qt. Compiling auto-tests from qt/tests/auto/qweb* produced failing tests since these .pro files include the ones in WebKit/qt/tests and the .qrc file was not added to RESOURCES * tests/benchmarks/loading/loading.pro: * tests/benchmarks/painting/painting.pro: * tests/qgraphicswebview/qgraphicswebview.pro: * tests/qwebelement/qwebelement.pro: * tests/qwebframe/qwebframe.pro: * tests/qwebhistory/qwebhistory.pro: * tests/qwebhistoryinterface/qwebhistoryinterface.pro: * tests/qwebinspector/qwebinspector.pro: * tests/qwebpage/qwebpage.pro: * tests/qwebplugindatabase/qwebplugindatabase.pro: * tests/qwebview/qwebview.pro: * tests/tests.pri: 2010-04-22 Adam Barth Unreviewed, rolling out r58069. http://trac.webkit.org/changeset/58069 https://bugs.webkit.org/show_bug.cgi?id=27751 Broke compile on Windows. * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): * Api/qwebsettings.h: 2010-04-22 Abhishek Arya Reviewed by Adam Barth. Add support for controlling clipboard access from javascript. Clipboard access from javascript is disabled by default. https://bugs.webkit.org/show_bug.cgi?id=27751 * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): * Api/qwebsettings.h: 2010-04-21 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. Add PageClientQWidget implementation based on the old QWebPageWidgetClient to PageClientQt files. Also fix QWebPage::setView() to use PageClientQWidget. [Qt] PageClientQt specific implementation for QWidget https://bugs.webkit.org/show_bug.cgi?id=37858 * Api/qwebpage.cpp: (QWebPage::setView): * WebCoreSupport/PageClientQt.cpp: Added. (WebCore::PageClientQWidget::scroll): (WebCore::PageClientQWidget::update): (WebCore::PageClientQWidget::setInputMethodEnabled): (WebCore::PageClientQWidget::inputMethodEnabled): (WebCore::PageClientQWidget::setInputMethodHint): (WebCore::PageClientQWidget::cursor): (WebCore::PageClientQWidget::updateCursor): (WebCore::PageClientQWidget::palette): (WebCore::PageClientQWidget::screenNumber): (WebCore::PageClientQWidget::ownerWidget): (WebCore::PageClientQWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQWidget::pluginParent): (WebCore::PageClientQWidget::style): * WebCoreSupport/PageClientQt.h: Added. (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQWidget::isQWidgetClient): 2010-04-21 Jakub Wieczorek Reviewed by Darin Adler. List item markers are not always updated after changes in the DOM. https://bugs.webkit.org/show_bug.cgi?id=37060 * Api/qwebelement.h: Make DumpRenderTreeSupportQt a friend class. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): Add a private API to get the marker text for a list item. 2010-04-21 Yi Shen Reviewed by Simon Hausmann. [Qt] Check the request empty or not in ChromeClientQt::createWindow() https://bugs.webkit.org/show_bug.cgi?id=37821 * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): 2010-04-21 Shu Chang Reviewed by Simon Hausmann. [Qt] Fix Symbian build where QT_NO_SYSTEMTRAYICON is defined. https://bugs.webkit.org/show_bug.cgi?id=37442 * WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): * WebCoreSupport/NotificationPresenterClientQt.h: 2010-04-21 Eric Seidel Unreviewed, rolling out r57963. http://trac.webkit.org/changeset/57963 https://bugs.webkit.org/show_bug.cgi?id=37759 Three tests started crashing on the Qt bot. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isCommandEnabled): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-04-21 Yi Shen Reviewed by Simon Hausmann. [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo https://bugs.webkit.org/show_bug.cgi?id=37759 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-04-21 No'am Rosenthal Reviewed by Simon Fraser. [Qt] Fix or remove the runtime flag for accelerated compositing. https://bugs.webkit.org/show_bug.cgi?id=37313 This lets the QWebPageClient "veto" the settings value for accelerated compositing. In this case we allow accelerated compositing only on QGraphicsWebView. * Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::allowsAcceleratedCompositing): * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing): * WebCoreSupport/ChromeClientQt.h: 2010-04-20 Adam Barth Unreviewed build fix. * Api/qwebframe.cpp: (QWebFrame::setUrl): 2010-04-20 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading): 2010-04-20 Kent Tamura Reviewed by Darin Adler. Change a parameter type of chooseIconForFiles() https://bugs.webkit.org/show_bug.cgi?id=37504 * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles): * WebCoreSupport/ChromeClientQt.h: 2010-04-19 Jocelyn Turcotte Reviewed by Simon Hausmann. [Qt] Fix compilation against namespaced Qt. * WebCoreSupport/ChromeClientQt.h: * WebCoreSupport/QtFallbackWebPopup.h: 2010-04-18 Robert Hogan Reviewed by Simon Hausmann. [Qt] Add support for LayoutTestController commands: setSmartInsertDeleteEnabled setSelectTrailingWhitespaceEnabled execCommand isCommandEnabled https://bugs.webkit.org/show_bug.cgi?id=35844 * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): * Api/qwebpage_p.h: * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled): * WebCoreSupport/DumpRenderTreeSupportQt.h: * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled): * WebCoreSupport/EditorClientQt.h: 2010-04-15 Kent Hansen Reviewed by Kenneth Rohde Christiansen. [Qt] Mark QWebFrame::overloadedSlots autotest as expected failure https://bugs.webkit.org/show_bug.cgi?id=37319 * tests/qwebframe/tst_qwebframe.cpp: 2010-04-09 Antonio Gomes Reviewed by Kenneth Christiansen and Tor Arne Vestbø. REGRESSION(r56552): Broken scrollbars size https://bugs.webkit.org/show_bug.cgi?id=36853 The regression was caused by r56552, which introduced a fix to bug webkit.org/b/21300. The bug solved an issue with the resize handle on mac, but did it in a way that affected all Qt platforms and thus broke the behavior on non-mac platforms. This patch makes the mac specific change ifdef'ed and only applied for the mac platform. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowResizerRect): 2010-04-15 Bruno Schmidt Reviewed by Kenneth Rohde Christiansen. [Qt] Null QObjects properties cause Segmentation Fault https://bugs.webkit.org/show_bug.cgi?id=34730 QObjects exported to the QWebkit javascript with properties that are a null "QObject*" cause Segmentation Fault. If an QObject is added to the javascript context and it contains properties of the type QObject* with NULL value, calling the property causes Segmentation Fault. Follow the tests for the corrections done over WebCore. * tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): init the field m_objectStar (MyQObject::objectStarProperty): read the Object* prop (MyQObject::setObjectStarProperty): write the Object* prop (tst_QWebFrame::getSetStaticProperty): new tests for the new prop 2010-04-14 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. Changing view mode names due to specification changes https://bugs.webkit.org/show_bug.cgi?id=37615 test: fast/media/media-feature-wgt-view-mode.html specification: http://dev.w3.org/2006/waf/widgets-vmmf/ * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized): * WebCoreSupport/ChromeClientQt.h: 2010-04-14 Luiz Agostini Reviewed by Simon Hausmann. [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp https://bugs.webkit.org/show_bug.cgi?id=37622 Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433 (bug 35844). Moving it back. * Api/qwebpage.cpp: (qt_wrt_setViewMode): * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2010-04-14 Andreas Kling Reviewed by Kenneth Rohde Christiansen. [Qt] Rendering artifacts on Qt plugins when scrolling the page https://bugs.webkit.org/show_bug.cgi?id=37152 Because we no longer repaint the entire viewport on scroll, we must trigger a repaint of QtPluginWidgets when their geometry changes. * WebCoreSupport/FrameLoaderClientQt.cpp: 2010-04-14 Aaron Boodman Reviewed by David Levin. Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are unsupported. Fixed by resolving the relative URL first. https://bugs.webkit.org/show_bug.cgi?id=36623 Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows. * WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed. 2010-04-13 Timothy Hatcher Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. SecurityOrigin needs a way to remove individual OriginAccessEntries https://bugs.webkit.org/show_bug.cgi?id=37449 Reviewed by Dave Hyatt. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): 2010-04-11 Sheriff Bot Unreviewed, rolling out r57468. http://trac.webkit.org/changeset/57468 https://bugs.webkit.org/show_bug.cgi?id=37433 Broke the world... Must have applied the patch wrong (Requested by abarth on #webkit). * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading): 2010-04-11 Adam Barth Reviewed by Eric Seidel. Factor DocumentWriter out of FrameLoader https://bugs.webkit.org/show_bug.cgi?id=37175 Update these callsites because the method moved to DocumentWriter. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading): 2010-04-11 Robert Hogan Reviewed by Simon Hausmann. [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader https://bugs.webkit.org/show_bug.cgi?id=37410 * WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): 2010-04-10 Robert Hogan Reviewed by Kenneth Rohde Christiansen. Refactor Qt DRT support in QtWebKit Move all QT DRT support functions to a static class. https://bugs.webkit.org/show_bug.cgi?id=35844 * Api/qwebframe.cpp: Remove static functions. * Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend. * Api/qwebpage.cpp: Remove static functions. * Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend. * Api/qwebsecurityorigin.cpp: Remove static functions. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode): * WebCoreSupport/DumpRenderTreeSupportQt.h: Added. * WebCoreSupport/EditorClientQt.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector): 2010-04-11 Robert Hogan Reviewed by Simon Hausmann. [Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports. Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html http/tests/misc/will-send-request-returns-null-on-redirect.html fast/loader/user-style-sheet-resource-load-callbacks.html http/tests/misc/window-dot-stop.html http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html http/tests/security/XFrameOptions/x-frame-options-deny.html http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html http/tests/xmlhttprequest/abort-should-cancel-load.html QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly. https://bugs.webkit.org/show_bug.cgi?id=37237 * WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading): 2010-04-10 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] Implement Desktop Notifications API for QtWebKit https://bugs.webkit.org/show_bug.cgi?id=35503 Map WebKit notifications to Qt's SystemTray API and implement DRT tracing. This patch does not implement the security part of WebKit notifications. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): * Api/qwebpage.h: * Api/qwebpage_p.h: * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter): * WebCoreSupport/ChromeClientQt.h: * WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission): * WebCoreSupport/NotificationPresenterClientQt.h: Added. 2010-04-09 Tasuku Suzuki Reviewed by Simon Hausmann. [Qt]Fix compile error with QT_NO_IM https://bugs.webkit.org/show_bug.cgi?id=36533 * WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): 2010-04-09 Yi Shen Reviewed by Kenneth Rohde Christiansen. [Qt] tst_QWebFrame::popupFocus() fails https://bugs.webkit.org/show_bug.cgi?id=37320 The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu. * tests/qwebframe/tst_qwebframe.cpp: 2010-04-09 Antonio Gomes Reviewed by Holger Freyther. Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete since Qt 4.5. window() method is being used instead now. See http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::windowResizerRect): 2010-04-09 Tasuku Suzuki Reviewed by Simon Hausmann. [Qt] Fix compile error with QT_NO_ACTION https://bugs.webkit.org/show_bug.cgi?id=36529 Make sure QT_NO_ACTION is not defined to use QAction * Api/qgraphicswebview.cpp: (QGraphicsWebView::pageAction): * Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::updatePositionDependentActions): * Api/qwebpage.h: * Api/qwebview.cpp: * Api/qwebview.h: 2010-04-09 Simon Hausmann Reviewed by Lars Knoll. [Qt] tests/qgraphicswebview fails https://bugs.webkit.org/show_bug.cgi?id=37317 * Api/qwebpage.cpp: (QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null. 2010-04-08 Benjamin Poulain Reviewed by Simon Hausmann. [Qt] Warnings when compiling InspectorClientQt.cpp https://bugs.webkit.org/show_bug.cgi?id=37266 Add a default: for the switch()-case to avoid warnings. * WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting): 2010-04-01 Antonio Gomes Reviewed by David Hyatt. [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect. https://bugs.webkit.org/show_bug.cgi?id=29431 Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode. Always added a qt auto test for set scrollbar policy feature. * Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy): * tests/qwebframe/tst_qwebframe.cpp: * WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage): 2010-04-08 Joe Ligman Reviewed by Simon Hausmann. [Qt] WebKit crashes while input text through input method. The formatted text underline painting crashes when painting with invalid indexes. https://bugs.webkit.org/show_bug.cgi?id=36870 * Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat): 2010-04-08 Joe Ligman Reviewed by Simon Hausmann. [Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden" https://bugs.webkit.org/show_bug.cgi?id=36674 The scrolling check was based on the frameview's scrolloffset, and maximumScrollPosition, which does not acknowledge the overflow properties. I am now basing the scrolling off the scrollbar position. The scrollbars are affected by the overflow properties indicating when not to scroll. The scrollbar positions also continue to work for CSS ::-webkit-scrollbar styles. * Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively): 2010-04-07 Andrey Kosyakov Reviewed by Yury Semikhatsky. Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() https://bugs.webkit.org/show_bug.cgi?id=36949 * WebCoreSupport/FrameLoaderClientQt.cpp: * WebCoreSupport/FrameLoaderClientQt.h: 2010-04-07 Dawit Alemayehu Reviewed by Simon Hausmann. https://bugs.webkit.org/show_bug.cgi?id=36827 Updated the WebCore::shouldTreatAsAttachement function call with the new more generic replacement WebCore::contentDispositionType. See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType): 2010-04-07 Andreas Kling Reviewed by Simon Hausmann. [Qt] When providing a widget for the PDF mime type it will cause a crash m_pluginView may actually be a Widget (for embedded Qt widgets), so always check isPluginView() before calling PluginView specific methods. https://bugs.webkit.org/show_bug.cgi?id=29450 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): 2010-04-06 Diego Gonzalez Reviewed by Simon Hausmann. [Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor https://bugs.webkit.org/show_bug.cgi?id=36538 * Api/qwebkitglobal.h: 2010-04-02 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] [Symbian] Rebaseline Symbian def file https://bugs.webkit.org/show_bug.cgi?id=37038 Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively and QWebInspector::closeEvent to match QtWebkit 4.6 branch Fix the signature for qt_drt_setFrameFlatteningEnabled after r56718. Add new QtWebKit API symbols introduced not listed in the file yet. * symbian/eabi/QtWebKitu.def: 2010-03-30 Antonio Gomes Reviewed by Adam Treat. Stored focused frame and document in a vars, instead of querying for them many times. * Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent(QEvent* ev)): (QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev): 2010-04-02 Tasuku Suzuki Reviewed by Eric Seidel. [Qt]Fix compile error with QT_NO_SETTINGS https://bugs.webkit.org/show_bug.cgi?id=36533 If QT_NO_SETTINGS is defined, QSettings is not available. * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting): 2010-04-02 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Maemo5 theme - customized popup for