2010-06-25 Anders Carlsson Reviewed by Dan Bernstein. Add a LOG macro that expands to a no-op by default. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.m: (_didRecieveMessageFromInjectedBundle): * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowShouldClose:]): (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didFirstLayoutForFrame): (_didFirstVisuallyNonEmptyLayoutForFrame): (_didBecomeUnresponsive): (_didBecomeResponsive): (_decidePolicyForNavigationAction): (_decidePolicyForNewWindowAction): (_createNewPage): (_showPage): (_closePage): (_didNavigateWithNavigationData): (_didPerformClientRedirect): (_didPerformServerRedirect): (_didUpdateHistoryTitle): * MiniBrowser/mac/MiniBrowser_Prefix.pch: * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): (_didCreatePage): (_willDestroyPage): (_didRecieveMessage): 2010-06-24 Adam Barth Reviewed by Eric Seidel. commit-queue is taking too long to land patches because of red trees https://bugs.webkit.org/show_bug.cgi?id=41194 Instead of checking for the tree to be green, we'll just spin hot trying to land patches. This is probably too extreme in ignoring the tree, but I think we should try it for a while to see if we have trouble. That will help us find the right balance. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-06-24 Martin Robinson Reviewed by Xan Lopez. [GTK] Clean up the use of gdk_window_get_root_coords in EventSender https://bugs.webkit.org/show_bug.cgi?id=40843 Define the version for old GTK+s in a way that is forward-compatible and clean up the logic a bit. * DumpRenderTree/gtk/EventSender.cpp: (gdk_window_get_root_coords): Renamed and cleaned up. (prepareMouseButtonEvent): Remove #ifdefs. (mouseMoveToCallback): Remove #ifdefs. 2010-06-24 Dimitri Glazkov Reviewed by Eric Seidel. Fix NewRunWebKitTests to work on Windows. https://bugs.webkit.org/show_bug.cgi?id=41180 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments, because Windows fails to understand what we're asking of it. 2010-06-24 Martin Robinson Reviewed by Xan Lopez. [GTK] The url passed to the WebView during layout tests is invalid https://bugs.webkit.org/show_bug.cgi?id=40832 Set the test URL to the full real file URL and do a small cleanup. Previously a URL like file://relative/path/to/test.html was passed to the WebView. This malformed file URL would be returned by webkit_web_view_get_url and webkit_web_frame_get_url. * DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Change to take a const string& as the argument. (shouldOpenWebInspector): Change to take a const string& as the argument. (shouldEnableDeveloperExtras): Change to take a const string& as the argument. (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable. 2010-06-24 Sam Weinig Reviewed by Anders Carlsson. Fix WebKitTestRunner Makefile typos. * WebKitTestRunner/Makefile: 2010-06-24 Adele Peterson Reviewed by Eric Carlson. DumpRenderTree part of testing "Paste and Match Style" should fire paste events https://bugs.webkit.org/show_bug.cgi?id=41085 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects. 2010-06-23 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41086 Add new WebKitTestRunner project (ie. DRT for WebKit2). - Mac only. - run-webkit-tests has not been modified to call it yet. - Only dumps the render tree at this time. * WebKitTestRunner: Added. * WebKitTestRunner/Configurations: Added. * WebKitTestRunner/Configurations/Base.xcconfig: Added. * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added. * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added. * WebKitTestRunner/InjectedBundle: Added. * WebKitTestRunner/InjectedBundle-Info.plist: Added. * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added. (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didClearWindow): (_didCreatePage): (_willDestroyPage): (_didRecieveMessage): (WKBundleInitialize): * WebKitTestRunner/Makefile: Added. * WebKitTestRunner/PlatformWebView.h: Added. (WTR::PlatformWebView::platformView): * WebKitTestRunner/TestController.cpp: Added. (WTR::TestController::shared): (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::runTest): (WTR::TestController::runTestingServerLoop): (WTR::TestController::run): * WebKitTestRunner/TestController.h: Added. (WTR::TestController::verbose): (WTR::TestController::injectedBundlePath): * WebKitTestRunner/TestInvocation.cpp: Added. (WTR::createWKURL): (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::~TestInvocation): (WTR::TestInvocation::invoke): (WTR::TestInvocation::dump): (WTR::TestInvocation::initializeMainWebView): (WTR::TestInvocation::didStartProvisionalLoadForFrame): (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame): (WTR::TestInvocation::didCommitLoadForFrame): (WTR::TestInvocation::didFinishLoadForFrame): (WTR::TestInvocation::didFailLoadForFrame): (WTR::TestInvocation::renderTreeExternalRepresentationFunction): (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction): * WebKitTestRunner/TestInvocation.h: Added. * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added. * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added. * WebKitTestRunner/mac: Added. * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added. (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::page): * WebKitTestRunner/mac/TestInvocationMac.mm: Added. (WTR::TestInvocation::runUntil): * WebKitTestRunner/mac/main.mm: Added. (main): 2010-06-24 Luiz Agostini Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-23 Kevin Ollivier [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * wx/build/settings.py: 2010-06-23 James Robinson Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me. * Scripts/webkitpy/common/config/committers.py: 2010-06-23 Kent Tamura Reviewed by Dimitri Glazkov. Correct Chromium test configuration https://bugs.webkit.org/show_bug.cgi?id=41057 * BuildSlaveSupport/build.webkit.org-config/master.cfg: - Add "--use-drt" option for NRWT. It is required for Chromium and ignored for other platforms. - Skip JSC test on Chromium * BuildSlaveSupport/test-result-archive: Add Chromium support. 2010-06-23 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=41073 WebKit2: Flesh out more of the InjectedBundle client API * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didClearWindowForFrame): (_didCreatePage): (_willDestroyPage): (WKBundleInitialize): 2010-06-23 Yuzo Fujishima Reviewed by Shinichiro Hamaji. Implement page format data programming interface. Add methods for testing. https://bugs.webkit.org/show_bug.cgi?id=37538 * DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (isPageBoxVisibleCallback): (pageAreaRectInPixelsCallback): (preferredPageSizeInPixelsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): 2010-06-23 Sam Magnuson Reviewed by Shinichiro Hamaji. Follow proper convention for if/switch/while as I've discovered them to be through my review processes. https://bugs.webkit.org/show_bug.cgi?id=40723 Modified test so that if( foo ) is not allowed as it appears not to be the accepted convention. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-06-22 Eric Seidel Reviewed by Adam Barth. Run clean-header-guards to fix some header guards https://bugs.webkit.org/show_bug.cgi?id=41044 No functional changes, thus no tests. This entire change was generated by running clean-header-guards, and then reverting changes to files which shouldn't be changed. Those which are left all should be updated. Some of these changes are just fixing 755 permissions to be 644, since it seems various files have the wrong execute bit which don't need it. clean-header-guards made those (welcome) permission fixes unintentionally. * DumpRenderTree/chromium/WebThemeControlDRT.h: * DumpRenderTree/chromium/WebThemeEngineDRT.h: * QtTestBrowser/fpstimer.h: 2010-06-22 Adam Barth Reviewed by Eric Seidel. Rename HTMLDocumentParser to LegacyHTMLDocumentParser https://bugs.webkit.org/show_bug.cgi?id=41043 Update the hash. * Scripts/do-webcore-rename: 2010-06-22 Sam Magnuson Reviewed by Shinichiro Hamaji. Follow proper convention for variable declaration spacing. https://bugs.webkit.org/show_bug.cgi?id=40724 Modified test so that 'int a;' is not allowed. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-06-22 Eric Seidel Unreviewed. Add Tony Gentilcore now that he's a committer. * Scripts/webkitpy/common/config/committers.py: 2010-06-22 Eric Seidel Reviewed by Adam Barth. Remove Gtk 64-Release bot from core since it's broken https://bugs.webkit.org/show_bug.cgi?id=41022 This bot alone has been responsible for more than 72 hours of commit-queue blockage in the last week. The bot is broken -- keeps losing its display server or similar. Until the Gtk folks can fix the bot, we need to remove it from core. The WebKit community can't keep it green as is. * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/buildbot_unittest.py: 2010-06-21 Dumitru Daniliuc Reviewed by Eric Seidel. Fix the Windows build. https://bugs.webkit.org/show_bug.cgi?id=40972 * DumpRenderTree/win/ImageDiff.vcproj: 2010-06-21 Prasad Tammana Reviewed by Darin Adler, Dmitry Titov. DumpRenderTree should allow tests with modal dialogs https://bugs.webkit.org/show_bug.cgi?id=35350 * DumpRenderTree/LayoutTestController.cpp: (abortModalCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::abortModal): Add abortModal method to LayoutTestController and make it available from script. * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog. (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call abortModal from when modal window closes. (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop. 2010-06-21 Simon Fraser Reviewed by Anders Carlsson. Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea https://bugs.webkit.org/show_bug.cgi?id=40948 Have the script look in WebKit2. * Scripts/do-webcore-rename: 2010-06-21 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html It's a Mac-specific test so just add the required LayoutTestController function as a no-op to avoid failing. Similar approach adopted by other ports. https://bugs.webkit.org/show_bug.cgi?id=33344 * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL): 2010-06-21 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=40940 Add message passing support to the WebKit2 API. - Add some test messages. * MiniBrowser/mac/AppDelegate.m: (_didRecieveMessageFromInjectedBundle): (-[BrowserAppDelegate init]): * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindow): (_didCreatePage): (_didRecieveMessage): (WKBundleInitialize): 2010-06-21 Drew Wilson Unreviewed. Rolling back 61551 and 61555 due to test failures. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): * DumpRenderTree/mac/UIDelegate.mm: 2010-06-21 Anders Carlsson Reviewed by Sam Weinig. Make DumpRenderTree build with clang++ * DumpRenderTree/mac/DumpRenderTreePasteboard.m: (-[LocalPasteboard setPropertyList:forType:]): * DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow keyDown:]): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::elementDoesAutoCompleteForElementWithId): (LayoutTestController::isCommandEnabled): 2010-06-21 Satish Sampath Reviewed by Steve Block. Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. https://bugs.webkit.org/show_bug.cgi?id=40878 * Scripts/build-webkit: 2010-06-21 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Initialization for http/tests/loading/ https://bugs.webkit.org/show_bug.cgi?id=40902 * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): 2010-06-21 Jocelyn Turcotte Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-20 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Add --allow-external-pages option https://bugs.webkit.org/show_bug.cgi?id=40762 Add --allow-external-pages introduced by Chromium r45403. http://src.chromium.org/viewvc/chrome?view=rev&revision=45403 * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest): 2010-06-20 Joseph Pecoraro Reviewed by Adam Barth. Sheriffbot: Should allow "r" in SVN_REVISION https://bugs.webkit.org/show_bug.cgi?id=40889 * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r. 2010-06-20 Joseph Pecoraro Reviewed by Dimitri Glazkov. Python Tests Fail after r61508 https://bugs.webkit.org/show_bug.cgi?id=40891 Test's regex list needed to be updated to match the new regex list in the source code. Added new bots to the example_buildbots list. Regex list fixed in r61512. Updated bot list. * Scripts/webkitpy/common/net/buildbot_unittest.py: 2010-06-20 Dimitri Glazkov Unreviewed, build fix. Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508. * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp. 2010-06-19 Justin Schuh Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-19 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=40882 Add ability to have a WebProcess per WebContext. Move to use new shared contexts API. * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate getCurrentPageNamespace]): (-[BrowserAppDelegate validateMenuItem:]): (-[BrowserAppDelegate _setProcessModel:]): (-[BrowserAppDelegate setSharedProcessProcessModel:]): (-[BrowserAppDelegate setSharedThreadProcessModel:]): * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): 2010-06-02 Robert Hogan Reviewed by Adam Barth. [Qt] Support evaluateScriptInIsolatedWorld() https://bugs.webkit.org/show_bug.cgi?id=40079 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-06-18 Dimitri Glazkov Reviewed by Darin Adler. Add three more non-core Chromium builders to start testing DumpRenderTree. https://bugs.webkit.org/show_bug.cgi?id=40335 * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders. 2010-06-18 Drew Wilson Reviewed by Darin Fisher. [Chromium] Plumbing for top-level frame names https://bugs.webkit.org/show_bug.cgi?id=40430 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): Changed obsolete call to clearName() to use setName(WebString()) instead. 2010-06-18 Sam Weinig Rolling http://trac.webkit.org/changeset/61297 back in. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed. * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added. (_didClearWindow): (_didCreatePage): (WKBundleInitialize): 2010-06-18 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=40803 TestNetscapePlugin has an incorrect implementation of "property" property * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation. 2010-06-18 Leandro Pereira Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-17 Tony Chang Reviewed by Kent Tamura. [chromium] cleanup redundant DEPS value and remove buildbot cleanup code https://bugs.webkit.org/show_bug.cgi?id=40615 * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts 2010-06-17 Ada Chan Rolling out http://trac.webkit.org/changeset/61297 due to build errors. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c. * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed. 2010-06-17 Darin Adler One more try at fix for Chromium build. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use set again instead of =. 2010-06-17 Darin Adler Fix Chromium build. I didn't realize that neither Chromium nor Qt share the DumpRenderTree code with all the other platforms! Wow, that should be fixed at some point. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Changed back to using "new". * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr. 2010-06-17 Simon Hausmann Unreviewed Qt build fix. LayoutTestController in the Qt DRT is not using refs :) * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): 2010-06-17 Darin Adler Reviewed by Sam Weinig. Use adoptRef and create functions in more code paths https://bugs.webkit.org/show_bug.cgi?id=40760 * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::create): Added. * DumpRenderTree/LayoutTestController.h: Declare the create function. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use create instead of new. * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr. * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef instead of new. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/wx/DumpRenderTreeWx.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. (MyApp::OnInit): Removed unneeded code to delete the layout test controller. This is done during each test. 2010-06-17 Kent Tamura Reviewed by Shinichiro Hamaji. [DRT/Chromium] Fix a bug of Windows pixel tests https://bugs.webkit.org/show_bug.cgi?id=40763 * DumpRenderTree/chromium/TestEventPrinter.cpp: (TestShellPrinter::handleImage): 2010-06-16 Kent Tamura Reviewed by Shinichiro Hamaji. [DRT/Chromium] Fix crash on Mac Release https://bugs.webkit.org/show_bug.cgi?id=40759 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): We should not use m_canvas directly because it is created lazily in canvas(). 2010-06-16 Kevin Ollivier [wx] Build fix after new method addition. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::pageProperty): 2010-06-16 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Set current working directory for each of tests https://bugs.webkit.org/show_bug.cgi?id=40668 This change fixes tests with eventSender.beginDragWithFiles(). * DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): 2010-06-16 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] r60803 broke media/controls-drag-timebar.html https://bugs.webkit.org/show_bug.cgi?id=40269 Only queue events while the mouse button is down, if drag mode is enabled. Some tests may disable drag mode, to prevent the queuing of events in this situation. * DumpRenderTree/gtk/EventSender.cpp: (sendOrQueueEvent): Only queue events here if dragMode is true. 2010-06-16 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT https://bugs.webkit.org/show_bug.cgi?id=40600 * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME. 2010-06-16 Adam Barth Reviewed by Dimitri Glazkov. Add a hidden land-cowboy command to webkit-patch to help land quick build fixes. * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: 2010-06-16 Adam Roben Convert console messages to UTF-8 before printing them Speculative fix for REGRESSION (r61234): http/tests/security/xssAuditor/embed-tag-null-char.html and http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on Windows. (I can't test the fix because Apache is crashing on my computer.) Reviewed by Alexey Proskuryakov. * DumpRenderTree/win/DumpRenderTree.cpp: (toUTF8): Extracted the code into an overload that takes a wide string and a length, then added an overload that takes a wstring. * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8 overload. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to UTF-8 instead of letting printf convert to the current code page. 2010-06-16 Drew Wilson Reviewed by Kent Tamura. [Chromium] Plumbing for top-level frame names https://bugs.webkit.org/show_bug.cgi?id=40430 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Migrate to new createView() API. * DumpRenderTree/chromium/WebViewHost.h: Remove obsolete createView() methods, add new createView() API that takes a frameName parameter. 2010-06-16 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Scroll wheel event support to graphics based DRT https://bugs.webkit.org/show_bug.cgi?id=40577 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::continuousMouseScrollBy): (EventSender::createGraphicsSceneWheelEvent): * DumpRenderTree/qt/EventSenderQt.h: 2010-06-16 Adam Roben Remove a stray newline from the Windows version of TestNetscapePlugin Reviewed by Alexey Proskuryakov. Fixes plugins/geturlnotify-during-document-teardown.html fails on Windows * DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_Destroy): Removed extra newline that the Mac version doesn't have. 2010-06-16 Adam Roben Respect LayoutTestController::isPrinting on Windows This gets some printing tests closer to passing (like printing/page-rule-in-media-query.html). Fixes . Reviewed by Dan Bernstein. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): Pass LayoutTestController::isPrinting to IWebFramePrivate::renderTreeAsExternalRepresentation. 2010-06-15 Adam Barth Reviewed by Eric Seidel. Enable HTML5 lexer https://bugs.webkit.org/show_bug.cgi?id=40650 * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): 2010-06-10 Yuzo Fujishima Reviewed by Shinichiro Hamaji. Implement render style selection for pages to support CSS3 Paged Media. https://bugs.webkit.org/show_bug.cgi?id=35961 * DumpRenderTree/LayoutTestController.cpp: (parsePagePropertyParameters): (pagePropertyCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageProperty): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageProperty): 2010-06-15 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=40630 WebKit2: Add mechanism to inject code into the WebProcess on startup Add initial InjectedBundle support. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/WebBundle-Info.plist: Added. Add test InjectedBundle to the project. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): Get the path to the WebBundle from the the main bundle and pass it to the new WKContextCreateWithInjectedBundlePath function. * MiniBrowser/mac/BrowserWindowController.m: (_didChangeProgress): Fix the build. This has been broken for a while. * MiniBrowser/mac/WebBundle: Added. * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added. (_didCreatePage): (WKBundleInitialize): Add really basic InjectedBundle. * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code. 2010-06-15 Dumitru Daniliuc Reviewed by Darin Adler. Adding myself to the reviewers list. https://bugs.webkit.org/show_bug.cgi?id=40693 * Scripts/webkitpy/common/config/committers.py: 2010-06-15 Martin Robinson Reviewed by Xan Lopez. Switch to using GIO methods instead of realpath in GtkLauncher to determine the file URI. This should remove warnings about realpath being undefined when compiling with '-ansi'. * GtkLauncher/main.c: (filenameToURL): Use GIO instead of realpath to determine file URI. 2010-06-15 Adam Roben Remove the redundant set-apple-windows-environment-variables script Apparently update-webkit does this for you these days. Rubber-stamped by Steve Falkenburg. * Scripts/set-apple-windows-environment-variables: Removed. 2010-06-14 Adam Roben Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables Fixes . Reviewed by Steve Falkenburg. * Scripts/set-apple-windows-environment-variables: Added. (to_windows_path): Passes the passed-in path through cygpath to generate a Windows-style path. (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment variables to their defaults, if they aren't already set. 2010-06-14 Adam Roben Speed up run-safari/debug-safari on Windows Fixes . Reviewed by Steve Falkenburg. * Scripts/webkitdirs.pm: (runSafari): When debugging, set up the environment to run Safari using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to actually launch the debugger. When not debugging, just run WebKit.exe and it will do the rest for us. 2010-06-15 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] DRT EventSender support to graphics context events https://bugs.webkit.org/show_bug.cgi?id=40324 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick): 2010-06-14 Tony Chang Reviewed by Darin Fisher. [chromium] checkout chromium third_party directly https://bugs.webkit.org/show_bug.cgi?id=40556 * Scripts/update-webkit-chromium: some migration code for the bots 2010-06-14 Alexey Proskuryakov Chromium build fix. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE. 2010-06-14 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=40529 eventSender.keyDown("delete") incorrectly sends a backspace on some platforms * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those. 2010-06-14 Martin Robinson Reviewed by Xan Lopez. Small GtkLauncher build fix for some systems. * GtkLauncher/main.c: Add include. 2010-06-14 Mahesh Kulkarni Reviewed by Laszlo Gombos. [Qt] navigator.geolocation support for Qt port https://bugs.webkit.org/show_bug.cgi?id=39724 Implementation for geolocation cases to DumpRenderTreeQt * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::allowGeolocationRequest): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::isGeolocationPermissionSet): (LayoutTestController::geolocationPermission): 2010-06-13 Nathan Lawrence Reviewed by Darin Adler. Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to be a way of overwriting the Xcode system path. Making $WEBKITOUTPUTDIR take precedence over the system default would make this possible. * Scripts/webkitdirs.pm: 2010-06-13 Chris Fleizach Reviewed by Darin Adler. AX: link won't return linked element if URL contains # https://bugs.webkit.org/show_bug.cgi?id=40192 * DumpRenderTree/AccessibilityUIElement.cpp: (linkedUIElementAtIndexCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::linkedUIElementAtIndex): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::linkedUIElementAtIndex): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::linkedUIElementAtIndex): 2010-06-13 Adam Barth Reviewed by Darin Adler. webkit-patch should add a bug URL to ChangeLogs if they don't have one yet https://bugs.webkit.org/show_bug.cgi?id=39550 This can cause an extra request to bugs.webkit.org durig upload, but it shouldn't be too bad. Also, this won't work if you remove the boilerplate created by prepare-ChangeLog. * Scripts/webkitpy/common/checkout/changelog.py: * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added. 2010-06-08 Robert Hogan Reviewed by Eric Seidel. [Qt] Add support for callShouldCloseOnWebView() to DRT https://bugs.webkit.org/show_bug.cgi?id=40330 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews): 2010-06-12 Eric Seidel Reviewed by Daniel Bates. do-webcore-rename should have a --verbose option https://bugs.webkit.org/show_bug.cgi?id=40497 * Scripts/do-webcore-rename: - Unified how we handle skipping files/directories this will allow us to "black list" certain files and directories when performing renames. - Made do-webcore-rename log what it's skipping when passed --verbose. 2010-06-12 Darin Adler * Scripts/run-bindings-tests: Fixed a typo in a message. 2010-06-12 Kent Tamura Reviewed by Dimitri Glazkov. [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout https://bugs.webkit.org/show_bug.cgi?id=40402 _build_path() of each Chromium port check existence of build path of Chromium checkout first, then check existence of build path of WebKit-only checkout. * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2010-06-12 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Back-forward list dumping is incorrect https://bugs.webkit.org/show_bug.cgi?id=36392 Support dumping child history items in DRT. Unskip: fast/loader/frame-src-change-added-to-history.html fast/loader/frame-src-change-not-added-to-history.html fast/loader/frame-location-change-not-added-to-history.html * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem): 2010-06-10 Ojan Vafai Reviewed by Eric Seidel. upload all patches that lack in-rietveld to rietveld https://bugs.webkit.org/show_bug.cgi?id=40444 If it's a patch, then we'll try to upload it as long as it doesn't have in-rietveld set. No longer set in-rietveld? since it's not needed. * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-10 Ojan Vafai Reviewed by Darin Fisher. Fix rietveld upload when message length > 100 characters https://bugs.webkit.org/show_bug.cgi?id=40457 * Scripts/webkitpy/common/net/rietveld.py: 2010-06-11 Yael Aharon Reviewed by Laszlo Gombos. [Qt] There should be a way to enable popups in QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=40427 * QtTestBrowser/main.cpp: (LauncherWindow::toggleJavascriptCanOpenWindows): (LauncherWindow::createChrome): 2010-06-10 Adam Barth Reviewed by Daniel Bates. Make SheriffBot more chatty https://bugs.webkit.org/show_bug.cgi?id=40463 People seem to like to talk to SheriffBot, so let's make him chat back. * Scripts/webkitpy/thirdparty/__init__.py: * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added. * Scripts/webkitpy/tool/bot/sheriffircbot.py: * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 2010-06-10 Brian Weinstein Reviewed by Darin Adler. Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server. Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist, and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking WEXITSTATUS on $result instead of just comparing $result to 0. * Scripts/update-webkit-auxiliary-libs: 2010-06-10 Ojan Vafai Reviewed by Alexey Proskuryakov. don't use Exception.message as it's deprecated in python 2.6+ https://bugs.webkit.org/show_bug.cgi?id=40449 * Scripts/webkitpy/tool/commands/queues.py: 2010-06-10 Ojan Vafai Reviewed by Adam Barth. fix handle_script_error in rietveld upload queue and add testing for handle_script_error https://bugs.webkit.org/show_bug.cgi?id=40436 * Scripts/webkitpy/common/system/outputcapture.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-10 Jarkko Sakkinen Reviewed by Simon Hausmann. [Qt] *All* WebGL layout tests fail! https://bugs.webkit.org/show_bug.cgi?id=40296 Added test for WebKitWebGLEnabled to LayoutTestController::overridePreference(). * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): 2010-06-10 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] DRT EventSender support to graphics mouse events activation https://bugs.webkit.org/show_bug.cgi?id=40017 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::keyDown): (EventSender::contextClick): (EventSender::sendTouchEvent): (EventSender::sendOrQueueEvent): (EventSender::eventFilter): (EventSender::createGraphicsSceneMouseEvent): (EventSender::sendEvent): * DumpRenderTree/qt/EventSenderQt.h: (EventSender::isGraphicsBased): 2010-06-09 Adam Barth Reviewed by Ojan Vafai. webkit-patch upload fails for security bugs because there's no rietveld flag https://bugs.webkit.org/show_bug.cgi?id=40309 There's probably a more elegant way of seeing whether the form control exists, but this seems to work. * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-09 Ojan Vafai Reviewed by Adam Barth. make rietveld upload faster and avoid posting to bug on errors https://bugs.webkit.org/show_bug.cgi?id=40389 Only grab the first item of the upload queue instead of trying to compute the whole list upfront (which is O(n) bugzilla lookups!). Also, don't post comments to the bug when uploading fails. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/stepsequence.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-09 Ojan Vafai Reviewed by Adam Barth. Rietveld upload queue fails when setting in-rietveld flag https://bugs.webkit.org/show_bug.cgi?id=40371 Make the comment arguments to set_flag_on_attachment optional and add it to the MockBugzilla. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/bot/queueengine.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-09 Kenneth Russell Reviewed by Dimitri Glazkov. Rename FloatArray to Float32Array https://bugs.webkit.org/show_bug.cgi?id=40323 Used do-webcore-rename to perform renaming. Manually undid incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp, WebCore/manual-tests/resources/ArrayParameterTestApplet.java and ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran all layout tests on Safari; built Chromium and ran selected WebGL tests. * Scripts/do-webcore-rename: 2010-06-08 Tony Chang Reviewed by David Levin. [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out https://bugs.webkit.org/show_bug.cgi?id=40285 * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-03 Roland Steiner Reviewed by Tamura Kent. Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT https://bugs.webkit.org/show_bug.cgi?id=40052 Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907 * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/TestShellWin.cpp: (platformInit): * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added. (WebKit::): (WebKit::WebThemeControlDRT::WebThemeControlDRT): (WebKit::WebThemeControlDRT::~WebThemeControlDRT): (WebKit::WebThemeControlDRT::box): (WebKit::WebThemeControlDRT::line): (WebKit::WebThemeControlDRT::triangle): (WebKit::WebThemeControlDRT::roundRect): (WebKit::WebThemeControlDRT::oval): (WebKit::WebThemeControlDRT::circle): (WebKit::WebThemeControlDRT::nestedBoxes): (WebKit::WebThemeControlDRT::markState): (WebKit::WebThemeControlDRT::draw): (WebKit::WebThemeControlDRT::drawTextField): (WebKit::WebThemeControlDRT::drawProgressBar): * DumpRenderTree/chromium/WebThemeControlDRT.h: Added. (WebKit::WebThemeControlDRT::): * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added. (WebKit::): (WebKit::WebThemeEngineDRT::paintButton): (WebKit::WebThemeEngineDRT::paintMenuList): (WebKit::WebThemeEngineDRT::paintScrollbarArrow): (WebKit::WebThemeEngineDRT::paintScrollbarThumb): (WebKit::WebThemeEngineDRT::paintScrollbarTrack): (WebKit::WebThemeEngineDRT::paintTextField): (WebKit::WebThemeEngineDRT::paintTrackbar): (WebKit::WebThemeEngineDRT::paintProgressBar): * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added. (WebKit::WebThemeEngineDRT::WebThemeEngineDRT): 2010-06-08 Sheriff Bot Unreviewed, rolling out r60878. http://trac.webkit.org/changeset/60878 https://bugs.webkit.org/show_bug.cgi?id=40349 broke linux build (Requested by tony^work on #webkit). * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-08 Tony Chang Reviewed by David Levin. [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out https://bugs.webkit.org/show_bug.cgi?id=40285 * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-08 Kenneth Russell Unreviewed, build fix. Fix build breakage from 38145 https://bugs.webkit.org/show_bug.cgi?id=40346 The fix for bug 38145 broke the Chromium Win build because Microsoft's cmath doesn't define log2. Suggested fix by zmo is to change log2(x) to log(x) / log(2). Built and ran WebGL layout tests in Safari on Mac OS X. Changed download mirrors for python-irclib to working ones. * Scripts/webkitpy/thirdparty/__init__.py: 2010-06-08 Fumitoshi Ukai Reviewed by Eric Seidel. old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests https://bugs.webkit.org/show_bug.cgi?id=39058 * Scripts/old-run-webkit-tests: use sourceDir() to find ensure-valid-python in checkPythonVersion() 2010-06-08 Andras Becsi Unreviewed buildfix after r60479. [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK versions other than 2.17.3. * DumpRenderTree/gtk/EventSender.cpp: (getRootCoords): 2010-06-07 Martin Robinson Reviewed by Oliver Hunt. [GTK] Mouse movement should not trigger a replay of saved events in the event sender https://bugs.webkit.org/show_bug.cgi?id=40267 When a mouse button is down, automatically queue mouse motion events and do not play them back until the mouse button is released. This matches the behavior of other ports' EventSenders. * DumpRenderTree/gtk/EventSender.cpp: (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion. (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true. 2010-06-07 Nikolas Zimmermann Reviewed by Sam Weinig. Add CPP bindings generator https://bugs.webkit.org/show_bug.cgi?id=38279 Integrate CPP bindings in run-bindings-tests. * Scripts/run-bindings-tests: 2010-06-04 Tony Gentilcore Reviewed by Ojan Vafai. Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633. https://bugs.webkit.org/show_bug.cgi?id=40183 * Scripts/webkitpy/tool/steps/preparechangelog.py: 2010-06-04 Martin Robinson Unreviewed. Add my new email and IRC nick to committers.py. * Scripts/webkitpy/common/config/committers.py: 2010-06-04 Kinuko Yasuda Unreviewed. Revert changes in json_results_generator.py's _get_svn_revision. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 2010-06-04 Martin Robinson Reviewed by Xan Lopez. [GTK] GtkLauncher should support relative file paths https://bugs.webkit.org/show_bug.cgi?id=39944 Allow GtkLauncher to handle relative file paths passed via command-line arguments. * GtkLauncher/main.c: (filename_to_url): Added. (main): Try to resolve arguments as relative file URLs first. 2010-06-04 Martin Robinson Reviewed by Xan Lopez. [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly https://bugs.webkit.org/show_bug.cgi?id=40182 Instead of invoking signal handlers directly via g_signal_emit_by_name, call gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit without breaking DRT. * DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event. 2010-06-04 Anders Carlsson Reviewed by David Hyatt. Make the editing/spelling/context-menu-suggestions.html test more robust https://bugs.webkit.org/show_bug.cgi?id=40178 Change the contextClick method to return an array of strings describing the context menu items. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]): 2010-06-03 Kinuko Yasuda Reviewed by Shinichiro Hamaji. Clean up chromium-specific code from json_results_generator.py. https://bugs.webkit.org/show_bug.cgi?id=39665 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-06-04 Tony Gentilcore Reviewed by Adam Barth. Utilize new takeFirst() method where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset): 2010-06-04 Yael Aharon Reviewed by Simon Hausmann. [Qt] QtTestLauncher should allow notifications by default. https://bugs.webkit.org/show_bug.cgi?id=40078 * QtTestBrowser/main.cpp: (NotificationsPermissionController::NotificationsPermissionController): (NotificationsPermissionController::checkPermission): (NotificationsPermissionController::requestPermission): (LauncherWindow::LauncherWindow): 2010-06-04 Tony Gentilcore Reviewed by Adam Barth. Detect whether the user's environment can open a browser. https://bugs.webkit.org/show_bug.cgi?id=40136 Some environments like cygwin silently fail webbrowser.open() causing webkit-patch upload not to display any diff. This detects environments where webbrowser.open() would fail by testing if webbrowser.get() raises an exception. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/confirmdiff.py: 2010-06-03 Tony Gentilcore Reviewed by David Levin. Add dependencies required to link with VS Express 2005. https://bugs.webkit.org/show_bug.cgi?id=40038 Visual Studio implicitly links against these libs. VC++ Express does not. * WebKitAPITest/WebKitAPITestCommon.vsprops: * WinLauncher/WinLauncher.vcproj: 2010-06-03 Fumitoshi Ukai Reviewed by David Levin. bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py https://bugs.webkit.org/show_bug.cgi?id=40105 * Scripts/webkitpy/layout_tests/port/websocket_server.py: - kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running. - fix codecs.open parameters. 2010-06-03 Fumitoshi Ukai Reviewed by Alexey Proskuryakov. old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests https://bugs.webkit.org/show_bug.cgi?id=39058 * Scripts/ensure-valid-python: - Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead. - Add --check-only and --help option. - --check-only option only checks python version and don't try to install Python 2.5. - Set executable bit. * Scripts/old-run-webkit-tests: - Check if it can run the websocket tests by calling ensure-valid-python --check-only. 2010-05-14 Ojan Vafai Reviewed by Adam Barth. add a RietveldUploadQueue to upload in-rietveld? patches to rietveld https://bugs.webkit.org/show_bug.cgi?id=38918 Patches with in-rietveld? get uploaded to rietveld and get marked in-rietveld+. If the upload fails, they are marked in-rietveld- and an error is logged to the bug, like the commit-queue. Also, get rid of --fancy-review and the ability to upload to rietveld using webkit-patch upload/post. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla_unittest.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/options.py: * Scripts/webkitpy/tool/steps/postcodereview.py: 2010-05-24 Ojan Vafai Reviewed by Chris Jerdonek. many webkit-patch commands fail in a non-svn tracking git checkout https://bugs.webkit.org/show_bug.cgi?id=38156 If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master). If neither exists, then error out. This makes webkit-patch work for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit to checkout webkit. The fallback to master is for people who don't do the steps on that page for tracking svn. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: 2010-06-03 Mike Fenton Unreviewed. Reverse e-mail for myself in committers.py to correspond with bugzilla account. * Scripts/webkitpy/common/config/committers.py: 2010-06-03 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: a number of fixes that make InspectorController happy with null redirects. https://bugs.webkit.org/show_bug.cgi?id=40109 * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2010-06-02 Tasuku Suzuki Reviewed by Shinichiro Hamaji. [Qt] Fix compilation with QT_NO_PROPERTIES https://bugs.webkit.org/show_bug.cgi?id=38324 * QtTestBrowser/main.cpp: (LauncherWindow::init): 2010-06-02 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Make possible run DRT with QGraphicsWebView https://bugs.webkit.org/show_bug.cgi?id=40016 Make possible to use a environment variable for switching backend. Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): (WebCore::DumpRenderTree::DumpRenderTree): * DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setGraphicsBased): (WebCore::DumpRenderTree::isGraphicsBased): (WebCore::WebViewGraphicsBased::graphicsView): (WebCore::WebViewGraphicsBased::setPage): * Scripts/old-run-webkit-tests: 2010-06-02 Csaba Osztrogonác Reviewed by Eric Seidel. Slave lost shouldn't be recognized as build failed. https://bugs.webkit.org/show_bug.cgi?id=39282 * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green. * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost. 2010-06-01 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] Fix the lifecycle of notification objects https://bugs.webkit.org/show_bug.cgi?id=40003 Remove the dependency of notifications on QWebPage. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::requestPermissionCallback): (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::requestPermission): * DumpRenderTree/qt/DumpRenderTreeQt.h: 2010-06-02 Sheriff Bot Unreviewed, rolling out r60559. http://trac.webkit.org/changeset/60559 https://bugs.webkit.org/show_bug.cgi?id=40055 It broke python unit test (Requested by Ossy on #webkit). * Scripts/webkitpy/common/net/buildbot.py: 2010-06-02 Csaba Osztrogonác Reviewed by Eric Seidel. Slave lost shouldn't be recognized as build failed. https://bugs.webkit.org/show_bug.cgi?id=39282 * Scripts/webkitpy/common/net/buildbot.py: 2010-06-02 Tony Gentilcore Reviewed by Eric Seidel. Fix crash caused when assigned_to is disabled https://bugs.webkit.org/show_bug.cgi?id=40039 * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-02 Sterling Swigart Reviewed by David Levin. Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches. https://bugs.webkit.org/show_bug.cgi?id=39906 * Scripts/build-webkit: 2010-06-01 Raine Makelainen Reviewed by Simon Hausmann. Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard): 2010-06-01 Alexey Proskuryakov Reviewed by Mark Rowe. A nicer Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig. 2010-06-01 Alexey Proskuryakov A real Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS for all configurations, not just debug. 2010-06-01 Alexey Proskuryakov Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Get more mouse tests passing https://bugs.webkit.org/show_bug.cgi?id=39040 Reproduce the logic from the Windows EventSender for mapping button numbers to GDK button numbers. Move this logic to the prepareMouseButtonEvent helper. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Reproduce Windows logic. (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto. 2010-06-01 Alexey Proskuryakov Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=39434 REGRESSION (r59811): Geolocation callbacks cannot be created * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak into subsequent tests. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider. (LayoutTestController::setMockGeolocationError): Ditto. * DumpRenderTree/mac/MockGeolocationProvider.h: Added. * DumpRenderTree/mac/MockGeolocationProvider.mm: Added. (+[MockGeolocationProvider shared]): (-[MockGeolocationProvider dealloc]): (-[MockGeolocationProvider setPosition:]): (-[MockGeolocationProvider setError:]): (-[MockGeolocationProvider registerWebView:]): (-[MockGeolocationProvider unregisterWebView:]): (-[MockGeolocationProvider lastPosition]): (-[MockGeolocationProvider stopTimer]): (-[MockGeolocationProvider timerFired]): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): This delegate method must send a response. I'm not sure what the two-stage check is supposed to achieve, it seems unnecessary. 2010-05-12 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses the GDK event queue entirely, we simply do not send the extra event. * DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. (dispatchEvent): Properly handle GDK_3BUTTON_PRESS. 2010-06-01 Martin Robinson Not reviewed. Build fix. Fix GTK+ build caused by a bad merge. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 Small EventSender cleanups. Consolidate some common code. Style fixes. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Added. (contextClickCallback): Use prepareMouseButtonEvent. (mouseDownCallback): Use prepareMouseButtonEvent. (mouseUpCallback): Use prepareMouseButtonEvent. (mouseMoveToCallback): Small style fix. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test to pause for a specified amount of time. It is used in the processing of drag- -and-drop data as well as to separate distinct mouse double-clicks in some tests. This patch enables tests that rely on the latter behavior to pass. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame. * DumpRenderTree/gtk/EventSender.cpp: (leapForwardCallback): Add support for adjusting the time offset on leapForward(). (contextClickCallback): Use sendOrQueueEvent. (updateClickCount): Take the time offset into account when counting clicks. (mouseDownCallback): Use sendOrQueueEvent. (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. (mouseUpCallback): Use sendOrQueueEvent. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Added. (dispatchEvent): Added. (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. (makeEventSender): Only initialize the EventSender when loading the top frame. * DumpRenderTree/gtk/EventSender.h: Ditto. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot https://bugs.webkit.org/show_bug.cgi?id=39101 Work around timing issues for render tree dumps by pumping the main loop before doing the dump. Resize events are asynchronous in GTK+, so sometimes resize requests are still pending when DRT dumps the tree. * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Pump the main loop before dumping the render tree. 2010-05-31 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Fix crash of a test after another test with multiple windows https://bugs.webkit.org/show_bug.cgi?id=39942 If a test opens multiple windows, focuses on non-main window, and the focused window is closed, TestShell::m_focusedWidget points a deleted object. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeWindow): Clear m_focusedWidget. 2010-05-30 Kent Tamura Reviewed by Dimitri Glazkov. new-run-webkit-tests: Support DRT on Chromium-win https://bugs.webkit.org/show_bug.cgi?id=39810 Add --test-shell flag to DRT/Chromium, and it changes DRT so that it behaves like test_shell about command analysis, printing format, pixel dumping, and timeout handling. chromium.py and chromium_win.py supports the --test-shell flag and DRT/Chromium-win binary names. * DumpRenderTree/DumpRenderTree.gypi: Add new files. * DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Support for test_shell-style command. (main): Introduce --test-shell. * DumpRenderTree/chromium/TestEventPrinter.cpp: Added. * DumpRenderTree/chromium/TestEventPrinter.h: Added. TestEventPrinter class manages stdio output and image output. TestEventPrinter.cpp has two implementations; DRTPrinter and TestShellPrinter. * DumpRenderTree/chromium/TestShell.cpp: Some changes for TestEventPrinter. (TestShell::TestShell): (TestShell::runFileTest): (TestShell::testTimedOut): (TestShell::dump): (TestShell::dumpImage): * DumpRenderTree/chromium/TestShell.h: (TestShell::printer): (TestShell::layoutTestTimeout): (TestShell::layoutTestTimeoutForWatchDog): (TestShell::setLayoutTestTimeout): * DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog(). * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2010-05-30 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Enhance Qt DRT implementation to support platform scroll wheel events. https://bugs.webkit.org/show_bug.cgi?id=36004 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match Scrollbar::pixelsPerLineStep() for DRT testing. (EventSender::mouseScrollBy): Added (EventSender::continuousMouseScrollBy): Added * DumpRenderTree/qt/EventSenderQt.h: 2010-05-28 Adam Barth Reviewed by David Levin. webkit-patch should support CHANGE_LOG_EDIT_APPLICATION https://bugs.webkit.org/show_bug.cgi?id=39546 One sublty is that we want to wait for the user to finish editing the ChangeLog before moving on to the next step. That means we want to pass -W to open. However, if the user is using Xcode to edit the ChangeLog, we don't want them to have to exit the Xcode application. For this reason, we create a new instance of the application with -n. Overall, xed seems like a better solution, so we recommend that too. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/editchangelog.py: 2010-05-21 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: fix handling of Ctrl-C to exit even if some threads are wedged. Also, the script will print the results of the tests completed when the interrupt occurs. https://bugs.webkit.org/show_bug.cgi?id=33238 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-05-28 Darin Adler Ignore more Python messiness. * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore. * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore. * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore. * Scripts/webkitpy/test: Added property svn:ignore. * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore. 2010-05-28 Chris Fleizach Reviewed by Beth Dakin. Adding myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: 2010-05-28 Chris Fleizach Build fix. No review. AX: need to catch NSAccessibilityExceptions in DRT https://bugs.webkit.org/show_bug.cgi?id=39881 It looks like Tiger doesn't like seeing a NSMakeRange inside a @try. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::selectedTextRange): 2010-05-28 Chris Fleizach Reviewed by Darin Adler. AX: need to catch NSAccessibilityExceptions in DRT https://bugs.webkit.org/show_bug.cgi?id=39881 Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions. So DRT should wrap exception handlers around its AX related calls. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (attributesOfElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::ariaOwnsElementAtIndex): (AccessibilityUIElement::ariaFlowToElementAtIndex): (AccessibilityUIElement::disclosedRowAtIndex): (AccessibilityUIElement::selectedRowAtIndex): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::disclosedByRow): (AccessibilityUIElement::stringAttributeValue): (AccessibilityUIElement::boolAttributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::isAttributeSupported): (AccessibilityUIElement::role): (AccessibilityUIElement::subrole): (AccessibilityUIElement::roleDescription): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::orientation): (AccessibilityUIElement::stringValue): (AccessibilityUIElement::language): (AccessibilityUIElement::helpText): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::hierarchicalLevel): (AccessibilityUIElement::ariaIsGrabbed): (AccessibilityUIElement::ariaDropEffects): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::stringForRange): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::rowCount): (AccessibilityUIElement::columnCount): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement): (AccessibilityUIElement::showMenu): (AccessibilityUIElement::press): (AccessibilityUIElement::url): (AccessibilityUIElement::hasPopup): 2010-05-28 Yael Aharon Reviewed by Laszlo Gombos. [Qt] Pass all web notification layout tests https://bugs.webkit.org/show_bug.cgi?id=39146 Mimic Chromium's test_shell security model in Qt's DRT. It makes a list of origins which were granted permission to display notifications, and only those origins can display notifications. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::checkPermissionCallback): (WebCore::requestPermissionCallback): (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::checkPermission): (WebCore::DumpRenderTree::requestPermission): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-05-27 Philippe Normand Reviewed by Shinichiro Hamaji. check-webkit-style complains about use of NULL in GTK function calls that require sentinels https://bugs.webkit.org/show_bug.cgi?id=39372 Don't warn about NULL in g_*() calls. Zero can't be used instead for calls like g_build_filename and g_object_get/set. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-05-27 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin example https://bugs.webkit.org/show_bug.cgi?id=39489 Exempting directory WebKit/qt/examples/ from style guide. * Scripts/webkitpy/style/checker.py: 2010-05-26 Philippe Normand Reviewed by David Levin. [style] Allow usage of NULL in gst_*_many() https://bugs.webkit.org/show_bug.cgi?id=39740 Don't warn if NULL is used by gst_*_many() functions. Zero can't be used for the reason explained in Bug 32858. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-05-27 Adam Barth Reviewed by Eric Seidel. Update script to run the normal version of the parser tests. * Scripts/test-html5-parser: 2010-05-27 Adam Barth Reviewed by Eric Seidel. Add HTML5 parser support to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=39815 * Scripts/old-run-webkit-tests: 2010-05-26 Adam Barth Reviewed by Eric Seidel. Make HTML5 lexer not ASSERT when resuming partial parses https://bugs.webkit.org/show_bug.cgi?id=39755 Add webkit-resumer.html to the HTML5 parser test suite. * Scripts/test-html5-parser: 2010-05-24 Tony Chang Reviewed by Kent Tamura. [chromium] setup fonts on chromium linux DRT https://bugs.webkit.org/show_bug.cgi?id=39644 * DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): (platformInit): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): Fix a bug where in release builds, we didn't initialize m_canvas. * DumpRenderTree/chromium/fonts.conf: Added. 2010-05-24 Dirk Pranke Reviewed by Dimitri Glazkov. Re-commit r58765 - it had been rolled out to see if it was causing a perf regression (in r59787 and r59789), but that does not seem to have been the case. https://bugs.webkit.org/show_bug.cgi?id=39605 * DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show): 2010-05-25 Ojan Vafai Reviewed by Chris Jerdonek. remove suppression of rietveld logging https://bugs.webkit.org/show_bug.cgi?id=39693 Now that we only upload to rietveld explicitly, e.g. on the bot or via webkit-patch post-attachment-to-rietveld, we should print all the rietveld logging. It was suppressed before to avoid making webkit-patch upload too noisy. * Scripts/webkitpy/common/net/rietveld.py: 2010-05-25 Antonio Gomes Reviewed by Ojan Vafai. [Qt] Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=39680 Implement LayoutTestController::setEditingBehavior in Qt's DRT. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setEditingBehavior): 2010-05-25 Kevin Ollivier [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setEditingBehavior): * wx/build/settings.py: 2010-05-24 Antonio Gomes Reviewed by Eric Seidel and Kent Tamura (for the Chromium part). editingBehavior settings needs to be set back to a reasonable default between tests https://bugs.webkit.org/show_bug.cgi?id=39433 Similarly to r59861, hard code the default setting during reset for Gtk and Chromium, so that the serialized version of the setting stays in sync with expectations. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2010-05-24 Eric Seidel Reviewed by Adam Barth. webkit-patch land calls scm.changed_files 4 times! https://bugs.webkit.org/show_bug.cgi?id=39584 * Scripts/webkitpy/tool/commands/download_unittest.py: - Assert that we don't call modified_changelogs too often. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: - Use cached changelogs list instead of calling modified_changelogs directly. * Scripts/webkitpy/tool/steps/validatereviewer.py: - ditto. 2010-05-24 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Import layout_test_helper for Windows https://bugs.webkit.org/show_bug.cgi?id=39581 Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added. 2010-05-24 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Reset frame name https://bugs.webkit.org/show_bug.cgi?id=39586 This change fixes about 70 unexpected results. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): 2010-05-24 Marcus Bulach Reviewed by Kent Tamura. [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h https://bugs.webkit.org/show_bug.cgi?id=39587 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationService): 2010-05-24 Robert Hogan Reviewed by Laszlo Gombos. [Qt] DRT Support for removeOriginAccessWhitelistEntry Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html [Qt] DRT Support for removeOriginAccessWhitelistEntry https://bugs.webkit.org/show_bug.cgi?id=39565 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::removeOriginAccessWhitelistEntry): 2010-05-24 Marcus Bulach Reviewed by Ojan Vafai. _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head. https://bugs.webkit.org/show_bug.cgi?id=39603 * Scripts/webkitpy/common/checkout/scm.py: == Rolled over to ChangeLog-2010-05-24 ==