2010-10-20 David Kilzer New script to verify explicit source file types in Xcode project files Reviewed by Darin Adler. The script parses an Xcode project file and makes sure the file extension matches the explicit file type set for all source files. Note that the majority of source files will have their type set by Xcode, so the script doesn't check them since there is no need to second-guess Xcode. * Scripts/check-Xcode-source-file-types: Added. Code borrowed heavily from sort-Xcode-project-file. 2010-10-20 Adam Roben Windows build fix * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include. 2010-10-20 Adam Roben Qt test fix * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added PassDifferentNPPStruct.cpp. 2010-10-20 Sam Weinig Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=48027 Add ability to test injected bundle API using TestWebKitAPI * TestWebKitAPI/InjectedBundleController.cpp: Added. * TestWebKitAPI/InjectedBundleController.h: Added. Shared main object for bundle functionality. * TestWebKitAPI/InjectedBundleMain.cpp: Added. Bundle entry point. * TestWebKitAPI/InjectedBundleTest.h: Added. Base class for which the bundle portion of a test derives from. * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/PlatformUtilities.cpp: Added. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: (TestWebKitAPI::Util::createInjectedBundlePath): (TestWebKitAPI::Util::createURLForResource): (TestWebKitAPI::Util::URLForNonExistentResource): Add helper to create a context with the shared injected bundle, and send the initial message to set up the test. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added. * TestWebKitAPI/InjectedBundle-Info.plist: Added. Add mac configuration files. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new files. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added. Add a simple initial bundle test. 2010-10-20 Eric Seidel Unreviewed. Fixing /release-patch url used by the EWS bots. EWS should test patches with r+ https://bugs.webkit.org/show_bug.cgi?id=35460 * Scripts/webkitpy/common/net/statusserver.py: - I changed the URL during development, and 404s are intentionally silenced during release_patch. 2010-10-14 Adam Roben Test that passing a different NPP struct back to the browser doesn't cause an assertion failure Test for Assertion failure in NetscapePlugin::fromNPP when using Shockwave in WebKit2 Reviewed by John Sullivan. * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp. (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our members. (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the browser than the one it gave us in NPP_New and see if it works. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added PassDifferentNPPStruct. 2010-10-19 Adam Roben Gently nudge old-run-webkit-tests toward working with Win32 Perl This makes old-run-webkit-tests able to build DRT and find all the tests to run. It even invokes DRT and passes it the list of tests. But DRT ends up hung blocking on I/O. Fixes Get old-run-webkit-tests mostly working with Win32 Perl Reviewed by David Kilzer. * Scripts/old-run-webkit-tests: - Use File::Spec instead of manually concatenating paths - Use dirname instead of manually stripping off the base name - Use isCygwin/isWindows/isAppleWinWebKit more judiciously - Explicitly invoke Perl when running Perl scripts - Quote paths when using them in regular expressions to allow them to include characters that have special meanings in regular expressions * Scripts/run-webkit-tests: Use File::Spec instead of manually concatenating paths. * Scripts/webkitdirs.pm: - Remove the unused $windowsTmpPath variable - Use isCygwin/isWindows/isAppleWinWebKit more judiciously - Only pass paths to cygpath when using Cygwin Perl - Only use pdevenv when using Cygwin Perl, for now 2010-10-20 Daniel Bates Reviewed by Martin Robinson. Add Git-support to do-file-rename https://bugs.webkit.org/show_bug.cgi?id=48015 Also, abstracts the SCM move/rename functionality in do-file-rename and do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile(). Currently, do-file-rename is hard coded to assume the SCM is Subversion. Instead, we should abstract the rename logic to be SCM-independent. This will allow us to add Git support as well move such functionality into our SCM library VCSUtils, where it can be shared by do-webcore-rename. * Scripts/VCSUtils.pm: - Added function scmMoveOrRenameFile. * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile(). * Scripts/do-webcore-rename: Ditto. 2010-10-20 Adam Roben Fix old-run-webkit-tests when there's a space in the path to DRT Reviewed by Jon Honeycutt. * Scripts/old-run-webkit-tests: Quote the path to DRT before executing it. 2010-10-20 Kenneth Russell Reviewed by Dimitri Glazkov. Regression in chromium_gpu_unittests after r70175 https://bugs.webkit.org/show_bug.cgi?id=48008 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 2010-10-20 Kenneth Russell Reviewed by James Robinson. chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback https://bugs.webkit.org/show_bug.cgi?id=48005 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 2010-10-20 Adam Barth Reviewed by Eric Seidel. webkit-patch doesn't get along with git rm https://bugs.webkit.org/show_bug.cgi?id=47940 Turns out we need to pass "--" to tell git this is a path. * Scripts/webkitpy/common/checkout/scm.py: 2010-10-20 Robert Hogan Reviewed by Antonio Gomes. [Qt] Fix layoutTestController.getJsObjectCount Qt Bridge doesn't know size_t so pass result as unsigned int. Unskip fast/dom/gc-10.html https://bugs.webkit.org/show_bug.cgi?id=47931 * DumpRenderTree/qt/GCControllerQt.cpp: (GCController::getJSObjectCount): * DumpRenderTree/qt/GCControllerQt.h: 2010-10-20 Sheriff Bot Unreviewed, rolling out r70149. http://trac.webkit.org/changeset/70149 https://bugs.webkit.org/show_bug.cgi?id=47989 "Build breaks in mac and win" (Requested by satish on #webkit). * DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult): 2010-10-19 Leandro Gracia Gil Reviewed by Jeremy Orlow. Added a second parameter to setMockSpeechInputResult for the language used in speech input. https://bugs.webkit.org/show_bug.cgi?id=47089 * DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult): 2010-10-19 Adam Roben Teach update-webkit-support-libs about the new versioning of WebKitSupportLibrary Fixes update-webkit-support-libs should check version numbers instead of modification times Reviewed by Sam Weinig. * Scripts/update-webkit-support-libs: Fetch the expected version number from developer.apple.com, then compare with the version number of the extracted library and of the zipped library to see if anything needs to be done. Removed code that tracked the modified timestamp of the library, as it is no longer needed. 2010-10-19 Eric Seidel Reviewed by Adam Barth. EWS should test patches with r+ https://bugs.webkit.org/show_bug.cgi?id=35460 * QueueStatusServer/handlers/submittoews.py: * QueueStatusServer/model/queues.py: * Scripts/webkitpy/tool/bot/patchcollection.py: Removed. * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed. * Scripts/webkitpy/tool/commands/queues.py: 2010-10-19 Eric Seidel Reviewed by Adam Barth. Teach feeder-queue how to feed the EWS bots https://bugs.webkit.org/show_bug.cgi?id=47943 queues.webkit.org already knew how to accept EWS submissions via /submit-to-ews. This teaches the feeder queue how to post to that page with any new r? patches it sees. * QueueStatusServer/model/activeworkitems_unitest.py: Added. - More unit testing is always a good thing. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/common/net/statusserver.py: * Scripts/webkitpy/tool/bot/feeders.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-10-19 Eric Seidel Unreviewed, just fixing test-webkitpy. I'm really on a roll today. commit-queue gets stuck when release-patch returns 404 https://bugs.webkit.org/show_bug.cgi?id=47935 Fix test-webkitpy and unittest NetworkTransaction. * Scripts/webkitpy/common/net/networktransaction.py: * Scripts/webkitpy/common/net/networktransaction_unittest.py: 2010-10-19 Eric Seidel Unreviewed. commit-queue gets stuck when release-patch returns 404 https://bugs.webkit.org/show_bug.cgi?id=47935 Turns out ClientForm gets upset if passed an int() instead of a string type. Yay for untestable code. * Scripts/webkitpy/common/net/statusserver.py: 2010-10-19 Eric Seidel Unreviewed. Will get Adam's commentary after his meeting for now this gets the commit-cluster back running. commit-queue gets stuck when release-patch returns 404 https://bugs.webkit.org/show_bug.cgi?id=47935 I taught NetworkTransaction the basics of 404 handling. We'll want to go back and teach it how to handle urllib2 404's too and then deploy it to the places that want it. * QueueStatusServer/handlers/releasepatch.py: * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/networktransaction.py: * Scripts/webkitpy/common/net/statusserver.py: 2010-10-19 Eric Seidel Unreviewed. Fixing typos in my previous commit. Make patch release explicit and not a magic part of "retry" status https://bugs.webkit.org/show_bug.cgi?id=47909 All of these typos again due to our inability to unit test much of this code. I added one unit test where possible. activeworkitems_unittest.py will be in a separate patch. * QueueStatusServer/handlers/releasepatch.py: * QueueStatusServer/main.py: * QueueStatusServer/model/activeworkitems.py: * QueueStatusServer/model/workitems.py: * QueueStatusServer/model/workitems_unittest.py: * QueueStatusServer/templates/releasepatch.html: * Scripts/webkitpy/common/net/statusserver.py: 2010-10-19 Tony Chang Reviewed by Kent Tamura. [chromium] Use webkit's TestNetscapePlugIn in DRT mac https://bugs.webkit.org/show_bug.cgi?id=47850 * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked because we're going to name our plugin WebKitTestNetscapePlugIn temporarily until the chromium forked plugin goes away. 2010-10-19 Eric Seidel Reviewed by Adam Barth. Make patch release explicit and not a magic part of "retry" status https://bugs.webkit.org/show_bug.cgi?id=47909 This moves us another step closer to running r+ patches on the EWS bots. Currently all bots just spam /update-work-items with their list of current work items. queues.webkit.org uses that data for display. As part of making the EWS run r+ patches, we're moving the official list of patches-to-process into the server, and feeding them out to bots one at a time. We need to be able to remove patches from the queues one at a time instead of just spamming /update-work-items with a new complete list. That's what this patch adds. * QueueStatusServer/handlers/nextpatch.py: * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/handlers/releasepatch.py: Added. * QueueStatusServer/handlers/statusbubble_unittest.py: - Fix a typo causing test failure. This was not caught by the bots because they don't have AppEngineLauncher installed and thus don't run the QueueStatusServer tests. * QueueStatusServer/handlers/updatestatus.py: * QueueStatusServer/model/activeworkitems.py: * QueueStatusServer/templates/releasepatch.html: Added. * Scripts/webkitpy/common/net/statusserver.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/mocktool.py: 2010-10-19 Eric Seidel Reviewed by Adam Barth. cr-mac bubble has caused status bubbles to wrap https://bugs.webkit.org/show_bug.cgi?id=47928 We now have too many EWSes to fit in the bugs.webkit.org status-bubble iframe when more than a couple EWS builds are pending. To fix this I've reduced the space taken up by queue position, and also moved cr-mac to the end of the list (since it's going to be triple-digits for a while). * QueueStatusServer/model/queues.py: * QueueStatusServer/templates/statusbubble.html: 2010-10-19 Kenneth Russell Reviewed by David Levin. chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations https://bugs.webkit.org/show_bug.cgi?id=47874 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 2010-10-19 Tony Chang Reviewed by Kent Tamura. [chromium] DumpRenderTree shouldn't put '.' in include path https://bugs.webkit.org/show_bug.cgi?id=47877 Fix include paths. * DumpRenderTree/chromium/AccessibilityController.cpp: * DumpRenderTree/chromium/AccessibilityUIElement.cpp: * DumpRenderTree/chromium/AccessibilityUIElement.h: * DumpRenderTree/chromium/CppBoundClass.cpp: * DumpRenderTree/chromium/CppVariant.cpp: * DumpRenderTree/chromium/CppVariant.h: * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: * DumpRenderTree/chromium/DRTDevToolsAgent.h: * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: * DumpRenderTree/chromium/DRTDevToolsClient.cpp: * DumpRenderTree/chromium/DRTDevToolsClient.h: * DumpRenderTree/chromium/EventSender.cpp: * DumpRenderTree/chromium/EventSender.h: * DumpRenderTree/chromium/LayoutTestController.cpp: * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/MockSpellCheck.cpp: * DumpRenderTree/chromium/NotificationPresenter.cpp: * DumpRenderTree/chromium/NotificationPresenter.h: * DumpRenderTree/chromium/PlainTextController.cpp: * DumpRenderTree/chromium/Task.cpp: * DumpRenderTree/chromium/TestNavigationController.h: * DumpRenderTree/chromium/TestShell.cpp: * DumpRenderTree/chromium/TestWebWorker.h: * DumpRenderTree/chromium/TextInputController.cpp: * DumpRenderTree/chromium/WebPreferences.cpp: * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: * DumpRenderTree/chromium/WebThemeEngineDRT.h: * DumpRenderTree/chromium/WebViewHost.cpp: * DumpRenderTree/chromium/WebViewHost.h: 2010-10-19 Sam Weinig Reviewed by Dan Bernstein. Need to include WKErrorRef in the WKPageDidFail... functions https://bugs.webkit.org/show_bug.cgi?id=47871 Update tools for new parameter in failure callbacks. * MiniBrowser/mac/BrowserWindowController.m: (didFailProvisionalLoadWithErrorForFrame): (didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 2010-10-19 Luiz Agostini Reviewed by Antti Koivisto. [Qt] WebKit2 MacOS build fix https://bugs.webkit.org/show_bug.cgi?id=47897 Qt WebKit2 MacOS build fix. * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/qt/TestControllerQt.cpp: 2010-10-19 Adam Barth Reviewed by Eric Seidel. webkit-patch stats the filesystem too many times https://bugs.webkit.org/show_bug.cgi?id=47883 This patch attempts to cache the list of changed files more agressively and to use that list to compute the diff instead of stating the file system again. * Scripts/webkitpy/common/checkout/api.py: * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/editchangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: 2010-10-19 David Kilzer Make sort-Xcode-project-file a little more friendly Reviewed by Darin Adler. * Scripts/sort-Xcode-project-file: - Don't print an error message about missing arguments when -h|--help is used. - Allow Xcode project files to be specified as Project.xcodeproj instead of Project.xcodeproj/project.pbxproj. 2010-10-18 Jocelyn Turcotte Reviewed by Andreas Kling. [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode. https://bugs.webkit.org/show_bug.cgi?id=47809 Connecting a call to load from the loadFinished signal can cause re-entrance crashes in WebCore. This patch uses a timer to do so, also giving some time to subsequent frames to finish loading. * QtTestBrowser/urlloader.cpp: (UrlLoader::UrlLoader): (UrlLoader::loadNext): (UrlLoader::checkIfFinished): (UrlLoader::frameLoadStarted): (UrlLoader::frameLoadFinished): * QtTestBrowser/urlloader.h: 2010-10-19 Sergio Villar Senín Reviewed by Xan Lopez. [GTK] http/history tests are failing https://bugs.webkit.org/show_bug.cgi?id=36173 Clear the history each time a test is run. Return the actual history item count when calling LayoutTestController::webHistoryItemCount * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount): 2010-10-18 Eric Seidel Reviewed by Adam Barth. Add Chromium Mac EWS to the list of queues at queues.webkit.org https://bugs.webkit.org/show_bug.cgi?id=47878 * QueueStatusServer/model/queues.py: 2010-10-18 Eric Seidel Reviewed by Adam Barth. queues.webkit.org/next_patch is always 404 https://bugs.webkit.org/show_bug.cgi?id=47881 With the addition of the Queue class, I changed most of the code to lookup WorkItems using get_or_insert with a key_name instead of WorkItems.all().filter(queue_name=). Because the new get_or_insert code uses an explicit key_name (which is obviously different from the previously autogenerated ones), there were new WorkItem records created for each queue. However, some parts of the code still use WorkItems.all().filter, thus some parts were getting the new record and some parts the old record. The same basic bug was occurring with ActiveWorkItems, because I changed the key_name for that class as well. To fix this I've moved more of the code over to using Queue.*work_items. I've also enabled the datastore_admin (new in GAE 1.3.8) so that we can go delete the old WorkItems records. I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8). * QueueStatusServer/app.yaml: * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/handlers/recentstatus.py: * QueueStatusServer/handlers/updatestatus.py: * QueueStatusServer/handlers/updateworkitems.py: 2010-10-18 Eric Seidel Reviewed by Adam Barth. Correct a bunch of typos in QueueStatusServer https://bugs.webkit.org/show_bug.cgi?id=47880 These are all due to our complete lack of unit testing in QueueStatusServer. I added a couple unit tests to cover a few of these fixes, but most of these are still only caught by actually running the application. * QueueStatusServer/handlers/nextpatch.py: * QueueStatusServer/handlers/statusbubble.py: * QueueStatusServer/handlers/statusbubble_unittest.py: Added. * QueueStatusServer/handlers/updateworkitems.py: * QueueStatusServer/model/attachment.py: * QueueStatusServer/model/queuepropertymixin.py: * QueueStatusServer/model/queuepropertymixin_unittest.py: * QueueStatusServer/model/workitems.py: * QueueStatusServer/model/workitems_unittest.py: Added. 2010-10-18 Adam Barth Disable this test because it's failing on the bots and the authors aren't around to fix it. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-18 Adam Barth Reviewed by Eric Seidel. CC authors of flaky tests when the commit-queue hits a flaky test https://bugs.webkit.org/show_bug.cgi?id=47872 * Scripts/webkitpy/common/checkout/api.py: * Scripts/webkitpy/common/net/layouttestresults.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-10-18 Eric Seidel Reviewed by Adam Barth. Make it possible to run a chromium-mac-ews builder https://bugs.webkit.org/show_bug.cgi?id=47876 Since we can't run Mac OS X in a VM, we need to only run committer patches. There was a multiple inheritance problem which was holding this patch back, but I decided to just ignore the problem and go with a functional hack for now. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: 2010-10-18 Kenneth Russell Reviewed by Tony Chang. Regression in run_webkit_tests_unittest from r70017 https://bugs.webkit.org/show_bug.cgi?id=47875 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-18 Adam Barth Reviewed by Eric Seidel. Implement webkit-patch suggest-reviewers https://bugs.webkit.org/show_bug.cgi?id=47866 * Scripts/webkitpy/common/checkout/api.py: - The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers. * Scripts/webkitpy/common/checkout/api_unittest.py: - Test the logic with some fun mocks. * Scripts/webkitpy/common/checkout/scm.py: - Fix a bug when you have local git commits. * Scripts/webkitpy/common/checkout/scm_unittest.py: - Test that the bug is fixed. * Scripts/webkitpy/tool/commands/queries.py: - Add the query. 2010-10-18 Kenneth Russell Reviewed by Eric Seidel. new-run-webkit-tests produces corrupt PNG baselines on Windows https://bugs.webkit.org/show_bug.cgi?id=47867 * Scripts/webkitpy/layout_tests/port/base.py: 2010-10-18 Eric Seidel Reviewed by Adam Barth. Make it possible to submit patches to the EWS bots https://bugs.webkit.org/show_bug.cgi?id=47869 * QueueStatusServer/handlers/nextpatch.py: - Move more logic into Queue, so that it can be shared with SubmitToEWS. * QueueStatusServer/handlers/queuestatus.py: - Fix two typos from a previous commit. * QueueStatusServer/handlers/submittoews.py: Added. * QueueStatusServer/handlers/updatestatus.py: - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS * QueueStatusServer/main.py: - Add /submit-to-ews * QueueStatusServer/model/queuepropertymixin.py: - Fix circular imports caused by adding Queue.work_items() * QueueStatusServer/model/queues.py: - Add work_items() and active_work_items() * QueueStatusServer/model/queuestatus.py: * QueueStatusServer/model/workitems.py: - Add transaction-safe add/remove methods. * QueueStatusServer/templates/submittoews.html: Added. 2010-10-18 Eric Seidel Reviewed by Adam Barth. Deploy Queue class in more places throughout QueueStatusServer https://bugs.webkit.org/show_bug.cgi?id=47855 I also caught two typos from the previous change. Unfortunately I don't yet know how to unittest request handlers yet. * QueueStatusServer/handlers/dashboard.py: * QueueStatusServer/handlers/statusbubble.py: * QueueStatusServer/handlers/updateworkitems.py: * QueueStatusServer/model/activeworkitems.py: * QueueStatusServer/model/attachment.py: * QueueStatusServer/model/queuepropertymixin.py: Added. * QueueStatusServer/model/queuepropertymixin_unittest.py: Added. * QueueStatusServer/model/queuestatus.py: * QueueStatusServer/model/workitems.py: 2010-10-18 Adam Barth Reviewed by Eric Seidel. scm.py should be able tell us what revisions made changes to a given file https://bugs.webkit.org/show_bug.cgi?id=47863 Look again, your SCM.py can now log files. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: 2010-10-18 Dirk Pranke Reviewed by Eric Siedel. new-run-webkit-tests: clean up the options-parsing code in the port classes. This change modifies the Port interface to have a get_option() and set_option_default() method for accessing the options argument passed to the constructor. If the constructor is not passed an options argument, we default to a MockOptions() argument from mocktool, which has the same semantics we want. Note that there is a disadvantage to port.get_option('foo') over port._options.foo, which is that you lose some of the checking for whether 'foo' is set (typos result in the default value, not an exception being raised. This is desired in this case, since the Port class is not allowed to assume that options does have any particular values set, and so this change ensures that all of the subclasses are following the same, intended, logic. Arguably this is the wrong semantics to have, and the Port classes should be able to assume a default set of attributes/arguments, but that change will need to wait for a different CL where we can modify new-run-webkit-tests to pull a list of arguments from the port factory routines. Also, add unit tests for webkitpy.tool.mocktool.MockOptions . https://bugs.webkit.org/show_bug.cgi?id=47510 * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/port/dryrun.py: * Scripts/webkitpy/layout_tests/port/factory_unittest.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/port_testcase.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: * Scripts/webkitpy/tool/mocktool_unittest.py: Added. 2010-10-18 Dirk Pranke Reviewed by Eric Seidel. Re-submit a revised version of r69638 - enabling new-run-webkit-tests under cygwin. The initial version had a bug in base:uri_to_test_name that was causing tests to fail. This version corrects that bug, but also makes the code safer by calling cygpath more reliably, and leaving a long-running cygpath process open. This patch also corrects a couple of minor bugs in http_lock_unittest, chromium_unittest, and dedpulicate_tests_unittest that showed up while testing this. https://bugs.webkit.org/show_bug.cgi?id=47220 * Scripts/webkitpy/common/system/path.py: * Scripts/webkitpy/common/system/path_unittest.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-10-18 Eric Seidel Reviewed by Adam Barth. Add Queue class and add minimal unittesting of QueueStatusServer code https://bugs.webkit.org/show_bug.cgi?id=47847 * QueueStatusServer/handlers/dashboard.py: * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/handlers/recentstatus.py: * QueueStatusServer/handlers/statusbubble.py: * QueueStatusServer/handlers/updateworkitems.py: * QueueStatusServer/model/attachment.py: * QueueStatusServer/model/queues.py: * QueueStatusServer/model/queues_unittest.py: Added. * QueueStatusServer/model/svnrevision.py: * Scripts/test-webkitpy: * Scripts/webkitpy/test/main.py: 2010-10-18 Anders Carlsson Fix build. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon): 2010-10-18 Stuart Morgan Reviewed by Eric Seidel. Switch to using the new Carbon NPAPI event declarations, and remove the old ones. https://bugs.webkit.org/show_bug.cgi?id=40784 * DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon): 2010-10-18 David Levin Reviewed by Adam Barth. check-webkit-style should treat the GObject binding directory like other GTK directories. https://bugs.webkit.org/show_bug.cgi?id=47796 * Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo). 2010-10-18 David Levin Reviewed by Oliver Hunt. check-webkit-style needs to ignore underscores in opcode names and vm_throw https://bugs.webkit.org/show_bug.cgi?id=47789 * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory. * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases. 2010-10-18 MORITA Hajime Reviewed by Kent Tamura. TextInputController.hasSpellingMarkers() should be owned by LayoutTestController https://bugs.webkit.org/show_bug.cgi?id=47659 Moved hasSpellingMarkers() from TextInputController to LayoutTestController. Currently the implementation is available only for Mac and for Chromium. * DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString): * DumpRenderTree/chromium/TextInputController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker): * DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker): 2010-10-18 Adam Barth Reviewed by David Levin. commit-queue's flaky test notice is very Pythony https://bugs.webkit.org/show_bug.cgi?id=47790 This patch make the list of tests delimted by \n instead of just converting the array to a string. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-10-14 Antonio Gomes Reviewed by Martin Robinson and Xan Lopez. [Gtk]: DRT does not support frame flattening testing https://bugs.webkit.org/show_bug.cgi?id=38650 Implement DRT's support for toggling on/off frame flattening support. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setFrameFlatteningEnabled): 2010-10-15 Dirk Pranke Reviewed by Eric Siedel. mocktool.MockOptions is inheriting from Mock, which has the side effect of defaulting any attribute to another MockObject. So, MockOptions().foo would always evaluate to true. This was covering over bugs in the unit tests, and is probably the wrong default behavior for anything attempting to mock out the options argument returned from optparse.parse_args(). This patch changes the default behavior. The new MockOptions() class takes an optional list of keyword parameters to set; this patch doesn't use that feature but the fix for bug 47510 will. Also, this patch just fills in the default values necessary to get all of the tests to pass; I didn't stare at each test by hand to determine the "right" values. We can either fix that in subsequent patches or let me know if we want to do that now (and give me some guidance on what those values might want to be). https://bugs.webkit.org/show_bug.cgi?id=47709 * Scripts/webkitpy/tool/commands/commandtest.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: 2010-10-15 Simon Fraser Fix the build; need to add new slot to PageUIClient callbacks. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize): 2010-10-15 Simon Fraser Add Matt Delaney to committers.py. * Scripts/webkitpy/common/config/committers.py: 2010-10-15 Tony Chang Reviewed by Kent Tamura. [chromium] compile TestNetscapePlugIn on Chromium mac https://bugs.webkit.org/show_bug.cgi?id=47633 * DumpRenderTree/DumpRenderTree.gypi: files to compile * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue): * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added. 2010-10-15 Leandro Pereira Reviewed by Gustavo Noronha Silva. build-webkit: Should die when make fails when build a CMake project https://bugs.webkit.org/show_bug.cgi?id=47726 * Scripts/webkitdirs.pm: If make fails, die immediately. 2010-10-15 Sheriff Bot Unreviewed, rolling out r69809. http://trac.webkit.org/changeset/69809 https://bugs.webkit.org/show_bug.cgi?id=47725 Broke chromium mac compile (Requested by japhet on #webkit). * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue): * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed. 2010-10-15 Adam Barth Reviewed by Adam Barth. test-webkitpy fails on Linux https://bugs.webkit.org/show_bug.cgi?id=47713 The old code failed on Linux because the MacPort tries to read something out of platform that doesn't make sense on Linux. * Scripts/webkitpy/tool/mocktool.py: 2010-10-14 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] WTR is sloooow https://bugs.webkit.org/show_bug.cgi?id=47695 * WebKitTestRunner/qt/TestControllerQt.cpp: Change the timer interval of RunUntilConditionLoop from 50 milliseconds to 1 to avoid wasting time after the test had been finished. 2010-10-14 Eric Seidel Unreviewed, just fixing an exception seen on the commit-queue. I should have unit tested this function before. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-10-14 Eric Seidel Reviewed by Adam Barth. commit-queue should not fail patches due to flaky tests https://bugs.webkit.org/show_bug.cgi?id=47647 This patch makes it so that the *same* flaky test has to fail twice in a row to have a false negative from a flaky test. If different flaky tests fail (or if a test fails and then passes in a second run) then we will warn in the bug that we encountered a flaky test. This patch grew to include moving port off of steps onto tool (which Adam wrote and then I integrated), as well as removing the use of tool from CommitQueueTask. * Scripts/webkitpy/common/config/ports.py: - Added a layout_test_results_path method. This covers old-run-webkit-tests but doesn't cover NRWT. This is probably not the long term solution, but putting this knowledge on port makes more sense than in LayoutTestResults. * Scripts/webkitpy/common/net/buildbot.py: - LayoutTestResults shouldn't know how to fetch from the network, make the Build code do that instead. * Scripts/webkitpy/common/net/buildbot_unittest.py: - Code style fix. * Scripts/webkitpy/common/net/layouttestresults.py: - Remove code for reading from the network. * Scripts/webkitpy/common/net/layouttestresults_unittest.py: - Test the new entrypoint. * Scripts/webkitpy/tool/bot/commitqueuetask.py: - Make the delegate interface explicit. - Remove the _tool member, since using the delegate for everything is cleaner. - Teach the testing logic how to deal with flaky tests. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: - Update to match the CommitQueueTask changes. * Scripts/webkitpy/tool/commands/queues.py: - Use the new CommitQueueTaskDelegate interface. * Scripts/webkitpy/tool/commands/queues_unittest.py: - Fix the SecondThoughtsCommitQueue test which was broken. - Add a new test to make sure the flaky test reporting works. * Scripts/webkitpy/tool/main.py: - Store the port on the tool object. * Scripts/webkitpy/tool/mocktool.py: - Add a port() accessor to MockTool * Scripts/webkitpy/tool/steps/abstractstep.py: - Move port() off of Step and onto Tool. * Scripts/webkitpy/tool/steps/build.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/runtests.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: - Two tests with the same name! only the latter was being run. * Scripts/webkitpy/tool/steps/update.py: 2010-10-14 Dirk Pranke Reviewed by Eric Seidel. new-run-webkit-tests will now handle missing Ruby installs (or missing PrettyPatch scripts) more cleanly - previously this would be detected when we actually tried to create the diff, and the error message was obscure. Now we'll log a warning up front and otherwise be silent. This change also refactors some global variables to be class or instance variables to be slightly more testable and more modular. There are no cases where we create lots of port objects and can't afford to test for configurations repeatedly, so there's no performance concern here. https://bugs.webkit.org/show_bug.cgi?id=47466 * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-10-08 Martin Robinson Reviewed by Xan Lopez. [GTK] Form controls do not respect GTK+ font size https://bugs.webkit.org/show_bug.cgi?id=47134 * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Initialize the font control size when running DumpRenderTree to a standard value. 2010-10-14 Tony Chang Reviewed by Kent Tamura. [chromium] compile TestNetscapePlugIn on Chromium mac https://bugs.webkit.org/show_bug.cgi?id=47633 * DumpRenderTree/DumpRenderTree.gypi: files to compile * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue): * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added. * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added. 2010-10-14 Victor Wang Reviewed by Nate Chapin. [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff. https://bugs.webkit.org/show_bug.cgi?id=47686 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-10-14 Eric Seidel Reviewed by Adam Barth. test-webkitpy spews Delegate terminated queue messages https://bugs.webkit.org/show_bug.cgi?id=47678 * Scripts/webkitpy/tool/bot/queueengine_unittest.py: 2010-10-14 Adam Roben Test that pressing the Alt key generates a WM_SYSCOMMAND message Test for Pressing the Alt key when MiniBrowser's WKView is focused doesn't send focus to the menu bar Reviewed by Steve Falkenburg. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added TestWebKitAPI/win to the include path so that WindowMessageObserver can be found. * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and Windows-specific members. (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Added this simple setter. * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added. (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver): Initialize our lone data member. (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand): Simple getter. (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record when a WM_SYSCOMMAND message is received. (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a WM_SYSKEYUP message is not handled. (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate pressing the Alt key and check that a WM_SYSCOMMAND message got sent to the WKView's parent window. * TestWebKitAPI/win/PlatformWebViewWin.cpp: (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a member function so it could access PlatformWebView::wndProc. Use PlatformWebView::wndProc as the WNDPROC. (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new data member and pass the this pointer to CreateWindowEx so we can store it on the HWND. (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some constants from here to the top of the file. (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends the same messages that Notepad receives when you press the Alt key. (TestWebKitAPI::PlatformWebView::wndProc): Added. - When WM_CREATE is received, we set the PlatformWebView instance pointer as a property on the HWND so we can access it later. - For other messages, we try to get the PlatformWebView instance pointer from the HWND property. - When WM_NCDESTROY is received (which is the last message we will receive), we remove the PlatformWebView instance property. - Pass messages to the parent window's message observer, if there is one. - Pass all messages through to ::DefWindowProcW. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver and AltKeyGeneratesWMSysCommand. * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be used to observe messages sent to one or more windows. 2010-10-01 Martin Robinson Reviewed by Holger Freyther. [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558 https://bugs.webkit.org/show_bug.cgi?id=47033 * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Added this method which initializes XSettings font settings to consistent values before running a test. For the one test in which we need subpixel aliasing turned on, do that. (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings. (runTest): Pass the testURL to initializeFonts. 2010-10-14 Adam Barth Reviewed by Eric Seidel. ChromiumXVFBPort.run_webkit_tests_command has infinite recursion https://bugs.webkit.org/show_bug.cgi?id=47655 * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/config/ports_unittest.py: 2010-10-13 Eric Seidel Reviewed by Adam Barth. beat diff_parser with the ugly stick https://bugs.webkit.org/show_bug.cgi?id=47626 * Scripts/webkitpy/common/checkout/diff_parser.py: * Scripts/webkitpy/style/patchreader.py: * Scripts/webkitpy/style/patchreader_unittest.py: 2010-10-13 Eric Seidel Reviewed by Adam Barth. Break LayoutTestResults out into its own file https://bugs.webkit.org/show_bug.cgi?id=47637 * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/buildbot_unittest.py: * Scripts/webkitpy/common/net/layouttestresults.py: Added. * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added. 2010-10-13 Adam Barth Unreviewed. Chromium port can't run JavaScriptCore tests https://bugs.webkit.org/show_bug.cgi?id=47654 This lets webkit-patch build-and-test work on Chromium. * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/tool/steps/runtests.py: 2010-10-13 Adam Barth Reviewed by Eric Seidel. Make --port a global option and pass the port information to the commit-queue subprocess https://bugs.webkit.org/show_bug.cgi?id=47650 This patch paves the way to run the commit-queue on a non-Mac port. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/main.py: * Scripts/webkitpy/tool/steps/options.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/runtests.py: * Scripts/webkitpy/tool/steps/update.py: 2010-10-13 Adam Barth Reviewed by Eric Seidel. Introduce the ChromiumXVFBPort for running commit-queue on EC2 https://bugs.webkit.org/show_bug.cgi?id=47653 I'm not entirely sure this is the best way to do this, but we need to run the tests under XVFB on EC2 because the EC2 instances don't have a real monitor hooked up. This patch adds a ChromiumXVFBPort that runs that way. The idea is that XVFB is like a platform for the Chromium port, but we don't have a real notion of platform separate from port. * Scripts/webkitpy/common/config/ports.py: 2010-10-13 Sergio Villar Senin Reviewed by Martin Robinson. [GTK] Add HTTP caching support https://bugs.webkit.org/show_bug.cgi?id=44261 Add include paths for the new soup HTTP cache code. * GNUmakefile.am: Add paths for the new soup HTTP cache code. 2010-10-13 Yi Shen Reviewed by Antonio Gomes. [Qt] QtTestBrowser shows two Url input fields https://bugs.webkit.org/show_bug.cgi?id=47613 * QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): 2010-10-13 Yi Shen Reviewed by Tony Chang. [gdb] Add pretty-print supports for UString, Identifier and JSString https://bugs.webkit.org/show_bug.cgi?id=47601 * gdb/webkit.py: 2010-10-13 Adam Barth Reviewed by Eric Seidel. Add list of Ubuntu packages needed by the EWS bots https://bugs.webkit.org/show_bug.cgi?id=47628 I've been copy/pasting this list between bots, but it's better to have this checked in. * EWSTools/ubuntu-ews-packages: Added. 2010-10-13 Leandro Pereira Reviewed by Csaba Osztrogonác. [EFL] Adds a build slave. https://bugs.webkit.org/show_bug.cgi?id=47290 * BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the EFL port. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the EFL port. 2010-10-13 Adam Barth Reviewed by Csaba Osztrogonác. webkit-patch build shouldn't need --build to actually build! https://bugs.webkit.org/show_bug.cgi?id=47438 Yeah, requiring --build for the build command is really dumb. We did this originally because the build step is usually optional in other commands. We don't have a good way of reversing the default for an option in one command. This approach is slightly hacky since --build still shows up as an option on the help page, but at least it makes progress. Passing --build is harmless, so the EWS bots shouldn't explode because of this change. * Scripts/webkitpy/tool/bot/commitqueuetask.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-10-13 Sheriff Bot Unreviewed, rolling out r69638. http://trac.webkit.org/changeset/69638 https://bugs.webkit.org/show_bug.cgi?id=47595 "Broke win and chromium-win bots" (Requested by dglazkov on #webkit). * Scripts/webkitpy/common/system/path.py: * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-10-13 John Knottenbelt Reviewed by Steve Block. First step towards client-based Geolocation in Chromium. Build fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define. https://bugs.webkit.org/show_bug.cgi?id=47586 * DumpRenderTree/chromium/WebViewHost.cpp: * DumpRenderTree/chromium/WebViewHost.h: 2010-10-13 Adam Roben Test that pressing the spacebar in a text field does not scroll the document Test for REGRESSION: Pressing spacebar in a text field in WebKit2 does not insert a space, scrolls the page instead Reviewed by Sam Weinig. * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown. * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/copy-resources.cmd: Added new files. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added. (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): We use this to track what the result of calling into JavaScript was. (TestWebKitAPI::didFinishLoadForFrame): Records when the page finishes loading. (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down event is not handled. (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished executing and whether the result matched our expectation. (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef. (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to complete, and returns whether we got back the expected result. (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing spacebar inside a text field does not scroll the document and that pressing it outside the text field does scroll the document. * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::isKeyDown): Checks the event's type. * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied code from DRT's EventSendingController. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: (TestWebKitAPI::Util::isKeyDown): Checks the message's type. * TestWebKitAPI/win/PlatformWebViewWin.cpp: (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the same messages that get sent when you press spacebar in Notepad. 2010-10-13 Adam Roben Fix a couple of issues with the TestWebKitAPI build * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Fixed a typo. * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops to set our output and intermediate directories so that we don't spew files into the source tree. 2010-10-13 Balazs Kelemen Reviewed by Csaba Osztrogonác. WTR should accept relative paths https://bugs.webkit.org/show_bug.cgi?id=47486 * WebKitTestRunner/StringFunctions.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL): Moved from StringFunctions.h since it is used only here. Extend relative paths to absolute. 2010-10-12 Adam Roben Make TestWebKitAPI work on Windows Fixes . Reviewed by Sam Weinig. * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows. * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be run on Windows. (runTest): Added code to run TestWebKitAPI.exe on Windows and to die on unsupported platforms. (populateTests): Added code to run TestWebKitAPI.exe on Windows and to die on other platforms. Extracted some formerly-Mac-specific code to be cross-platform and made it handle any style of line-endings. * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added. Links against CFLite. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added. Contains most properties for the project. * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added. Links against CoreFoundation. * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific section and moved the cross-platform section after the platform-specific parts. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added. (TestWebKitAPI::Util::run): Runs a normal message pump until we're done. (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString. (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the resource path. (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus WKURL. * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added. (TestWebKitAPI::registerWindowClass): (TestWebKitAPI::PlatformWebView::PlatformWebView): (TestWebKitAPI::PlatformWebView::~PlatformWebView): (TestWebKitAPI::PlatformWebView::page): This was mostly copied from WebKitTestRunner's PlatformWebView. * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the build-api-tests script. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds TestWebKitAPI.exe. * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls through to copy-resources.cmd. * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into or deletes resources from TestWebKitAPI.resources. * TestWebKitAPI/win/main.cpp: Added. (main): Calls through to TestsController. 2010-10-13 Gyuyoung Kim Reviewed by Kenneth Rohde Christiansen. [EFL] Support viewport configuration and add new arguments for WebKit EFL https://bugs.webkit.org/show_bug.cgi?id=47084 Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port needs to be modified according to the changes. * EWebLauncher/main.c: (on_viewport_changed): 2010-10-12 Dirk Pranke Reviewed by Eric Seidel. This patch enables new-run-webkit-tests (in particular the chromium-win port) to run under Cygwin as well as Win32. Mostly this just required some conversions from cygwin paths to Win32 paths when we spawn off Win32 binaries like test_shell. https://bugs.webkit.org/show_bug.cgi?id=47220 * Scripts/webkitpy/common/system/path.py: - Expose the cygpath() function for path conversion * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: - shift filename->uri conversion in the TestInfo objects to the dump_render_tree thread * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium.py: - use cygpath() 2010-10-12 Yuta Kitamura Unreviewed. Add Yuta Kitamura (yutak) to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-10-12 Sam Weinig Reviewed by Dan Bernstein. When a provisional load fails, the provisional URL returned from WKFrameCopyProvisionalURL should be empty https://bugs.webkit.org/show_bug.cgi?id=47546 Add test. * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): 2010-10-12 Anders Carlsson Reviewed by Sam Weinig. Start fleshing out find page overlays https://bugs.webkit.org/show_bug.cgi?id=47559 * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController find:]): Pass kWKFindOptionsShowOverlay to WKPageFindString. 2010-10-12 Robert Hogan Reviewed by Antonio Gomes. [Qt] editing/input/emacs-ctrl-o.html ctrl-o is bound to a sequence of commands on Mac, namely: insertParagraphSeparator then moveLeft. In the DRT, we just interpret ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a result we only issue one command, so don't generate the change in caret position that results in the extra editing delegate messages. So for the sake of not managing suspicious-looking differences, just make DRT issue the appropriate edit commands to pass the test. https://bugs.webkit.org/show_bug.cgi?id=47548 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown): 2010-10-12 Anders Carlsson Reviewed by Sam Weinig. Add a simple Find UI to MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=47553 * MiniBrowser/mac/BrowserWindow.xib: Add Find panel. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController performFindPanelAction:]): Show the find panel. (-[BrowserWindowController find:]): Tell the WKPageRef to find the given string. 2010-10-12 Tony Chang Unreviewed, fixing DRT compile on Windows after r69586. * DumpRenderTree/chromium/WebThemeEngineDRT.h: 2010-10-12 Tony Chang Unreviewed, trying to fix NRWT on Windows. * Scripts/webkitpy/layout_tests/port/http_lock.py: 2010-10-12 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt][WTR] Checking the path of the injected bundle is bogus https://bugs.webkit.org/show_bug.cgi?id=47541 * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::isExistingLibrary): Added (static helper). Extend the path with the appropriate suffix(es) on the platform and check that the file exists. (WTR::TestController::initializeInjectedBundlePath): There were two bugs with the path checking: - the condition should have been inverted - QLibrary::fileName does not give back the filename with the library suffix so we cannot check that existance of the file this way. 2010-10-12 Gabor Rapcsanyi Reviewed by Tony Chang. Implement http locking in NRWT. https://bugs.webkit.org/show_bug.cgi?id=47072 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/http_lock.py: Added. * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-10-12 Mark Rowe Fix the 32-bit WebKit2 build. * MiniBrowser/mac/BrowserWindowController.m: (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns. (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects. 2010-10-11 Tony Chang Reviewed by Adam Barth. change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one https://bugs.webkit.org/show_bug.cgi?id=47513 bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete, which doesn't actually work. * Scripts/webkitpy/common/config/committers.py: 2010-10-11 Prasad Tammana Reviewed by Dmitry Titov. Added support for showModalDialog on chromium port. Implement showModalDialog for Layout tests for chromium port https://bugs.webkit.org/show_bug.cgi?id=46759 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop. (WebViewHost::runModal): Start a nested message loop and remember that. (WebViewHost::WebViewHost): Initialize m_inModalLoop. * DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop. 2010-10-11 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Cleanup font selection code for the Freetype backend https://bugs.webkit.org/show_bug.cgi?id=47503 Update DRT to set values for the cursive and fantasy font families, so that we can generate consistent results for tests that use these families. Add some missing information to fonts.conf. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always set the fantasy and cursive font family names. * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts to our default serif font. Eventually we may want to import or require some "real" fonts, but this should at least ensure consistent rendering during test runs. Also add aliases for some other commonly used fonts in tests (Arial and Lucida Grande). Finally, add a missing oblique specification for DejaVu Serif, which was resulting in some incorrect baselines for the synthetic oblique test. 2010-10-11 Adam Barth Unreviewed. Fix sheriffbot not to crash when there are failing tests. It turns out Python sets don't support the + operator. We need to use union instead. There's a more elegant way to do this in Python 2.6, but we need this code to work in 2.5. * Scripts/webkitpy/common/net/failuremap.py: * Scripts/webkitpy/common/net/failuremap_unittest.py: 2010-10-10 Robert Hogan Unreviewed, fix failing test from r69468. [Qt] Put all DRT-created pages in a page group Fix on r69468. Because we don't delete closed pages immediately in DRT we need to remove them from the page group explicitly instead. Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html https://bugs.webkit.org/show_bug.cgi?id=47469 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested): 2010-10-10 Leandro Pereira Reviewed by Adam Barth. commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the EFL-EWS bot is up and running. https://bugs.webkit.org/show_bug.cgi?id=47277 * QueueStatusServer/handlers/statusbubble.py: 2010-10-10 Robert Hogan Reviewed by Antonio Gomes. [Qt] Put all DRT-created pages in a page group https://bugs.webkit.org/show_bug.cgi?id=47469 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): 2010-10-09 Sam Weinig Reviewed by Dan Bernstein. WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped https://bugs.webkit.org/show_bug.cgi?id=47461 * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/Test.h: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added. (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::URLForNonExistentResource): Adds a test for the frame load state after a failed provisional load. I wanted to test the frame load state after a committed load failed, but I don't believe that is possible to do without hooking up the http server to serve a long loading page. 2010-10-09 Sam Weinig Reviewed by Dan Bernstein. Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage https://bugs.webkit.org/show_bug.cgi?id=47459 * MiniBrowser/mac/BrowserWindowController.m: (runBeforeUnloadConfirmPanel): (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize): 2010-10-09 Sam Weinig Reviewed by Dan Bernstein. Need implementation of ChromeClient windowRect related functions. https://bugs.webkit.org/show_bug.cgi?id=47386 * MiniBrowser/mac/BrowserWindowController.m: (getWindowFrame): (setWindowFrame): (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame): * WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame): 2010-10-08 Adam Barth Unreviewed (Eric is on vacation in this change is trivial). Add a "clean" command to webkit-patch to clean the working directory https://bugs.webkit.org/show_bug.cgi?id=47436 This command is useful when using SVN because "svn revert" leaves unversioned files behind. * Scripts/webkitpy/tool/commands/download.py: 2010-10-08 Andras Becsi Unreviewed build fix. [Qt] Add missing limits.h include since the Qt version currently ran on the bot does need that. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 2010-10-08 Balazs Kelemen Reviewed by Csaba Osztrogonác. [Qt] Turn on building WTR https://bugs.webkit.org/show_bug.cgi?id=47349 * Scripts/webkitdirs.pm: 2010-10-08 Balazs Kelemen Reviewed by Andreas Kling. [Qt] TestController needs its platform dependent methods https://bugs.webkit.org/show_bug.cgi?id=47413 * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::initializeInjectedBundlePath): If the WTR_INJECTEDBUNDLE_PATH environmental variable is set then use that otherwise use the path where the bundle lives in a normal trunk build. (WTR::TestController::initializeTestPluginDirectory): Set the bundle's value. It is not used currently. (WTR::TestController::platformInitializeContext): * WebKitTestRunner/qt/WebKitTestRunner.pro: 2010-10-08 Jocelyn Turcotte Reviewed by Kenneth Rohde Christiansen. WTR: Prevent sending the Done message twice on test timeout. https://bugs.webkit.org/show_bug.cgi?id=47410 When InjectedBundle::done() calls stopLoading, this may trigger InjectedBundlePage::didFailLoadWithErrorForFrame which calls InjectedBundle::done() itself later in the stack. This would output the timeout failure message twice and confuse the run-webkit-tests script. This patch adds a third state, Stopping, which prevents WebCore errors to trigger done() when testing is over. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 2010-10-08 Andras Becsi Reviewed by Kenneth Rohde Christiansen. [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts(). Original code by Simon Hausmann. https://bugs.webkit.org/show_bug.cgi?id=47402 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added. (WTR::activateFonts): 2010-10-08 Andras Becsi Reviewed by Csaba Osztrogonác. [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests. https://bugs.webkit.org/show_bug.cgi?id=47401 * Scripts/build-webkittestrunner: * Scripts/old-run-webkit-tests: 2010-10-07 Jocelyn Turcotte Reviewed by Kenneth Rohde Christiansen. [Qt] WTR first compile: fix compile issues. https://bugs.webkit.org/show_bug.cgi?id=47343 * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: * WebKitTestRunner/InjectedBundle/LayoutTestController.h: * WebKitTestRunner/TestController.cpp: * WebKitTestRunner/TestInvocation.cpp: 2010-10-07 Antonio Gomes Reviewed by Simon Fraser. [Mac] [DRT] implement setSpatialNavigationEnabled https://bugs.webkit.org/show_bug.cgi?id=47291 Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT so it can track regression on the existing implementation and future improvements we are making. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setSpatialNavigationEnabled): 2010-10-07 Dirk Pranke Reviewed by Adam Barth. rebaseline-chromium-webkit-tests relied on the filename_to_uri() hook in the Port infrastructure to generate URIs for the files in its summary HTML report; however, that method is supposed to only be used for test files (and should really be renamed), so this would crash. This change adds a new "path" module to the system package with a routine called abspath_to_uri() that handles converting paths to file: URIs independently of anything in the layout_tests package, and changes the code to use this. At some point in the near future the layout_tests/port/* code should use this as well. This change also deletes a bunch of unused code and fixes some comments in rebaseline_chromium_webkit_tests.py. https://bugs.webkit.org/show_bug.cgi?id=47319 * Scripts/webkitpy/common/system/path.py: Added. * Scripts/webkitpy/common/system/path_unittest.py: Added. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2010-10-07 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] The FreeType backend does not respect the FC_EMBOLDEN property https://bugs.webkit.org/show_bug.cgi?id=46216 Fix my latest commit, as it contained some bad changes from a merge gone wrong. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Also initialize the DevaVu Sans font. 2010-10-07 Daniel Cheng Reviewed by Tony Chang. [chromium] Minor naming cleanup in WebDragData, part 2 https://bugs.webkit.org/show_bug.cgi?id=47227 Update DRT to use the renamed methods. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles): * DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject): 2010-10-07 Anders Carlsson Reviewed by Sam Weinig. Add a WKPageFindClient, hook up WKPageCountStringMatches https://bugs.webkit.org/show_bug.cgi?id=47373 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Remove hard coded paths. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): Fix expected result. * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::didCountStringMatches): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/find.html: Added. Add test for WKPageCountStringMatches. 2010-09-21 Martin Robinson Reviewed by Chris Fleizach. [GTK] The FreeType backend does not respect the FC_EMBOLDEN property https://bugs.webkit.org/show_bug.cgi?id=46216 * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN for DejaVu Serif when there is no bold version available. This is necessary to properly test the property in layout tests. 2010-10-07 Jocelyn Turcotte , Andras Becsi , Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] Add WTR's InjectedBundle build files. https://bugs.webkit.org/show_bug.cgi?id=47333 * Scripts/webkitdirs.pm: * WebKitTestRunner/DerivedSources.pro: Added. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added. * WebKitTestRunner/WebKitTestRunner.pro: Added. * WebKitTestRunner/qt/DerivedSources.pro: Removed. Content merged in ../DerivedSources.pro 2010-10-07 Sheriff Bot Unreviewed, rolling out r69315. http://trac.webkit.org/changeset/69315 https://bugs.webkit.org/show_bug.cgi?id=47363 Forgot to add the new files (Requested by kbalazs on #webkit). * Scripts/webkitdirs.pm: * WebKitTestRunner/qt/DerivedSources.pro: Added. 2010-10-07 Sam Weinig Reviewed by Anders Carlsson. Change API tester to ask the executable for the list of all tests instead of relying on the directory structure. https://bugs.webkit.org/show_bug.cgi?id=47359 * Scripts/run-test-webkit-api: Added. * Scripts/webkitdirs.pm: Add additional script to just launch the api tester with the correct settings. * Scripts/run-api-tests: Change to use the new --dump-tests options to build the list of tests and change output to reflect a (suite, testcase) tuple for each test. Also adds some color. * TestWebKitAPI/Test.h: (TestWebKitAPI::Test::Register::Register): * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKString.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: (TestWebKitAPI::TEST): Give each test a suite name in addition to the test name. * TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::dumpTestNames): (TestWebKitAPI::TestsController::runTestNamed): * TestWebKitAPI/TestsController.h: * TestWebKitAPI/mac/main.mm: (main): Add option to print all registered tests. 2010-10-07 Jocelyn Turcotte , Andras Becsi , Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] Add WTR's InjectedBundle build files. https://bugs.webkit.org/show_bug.cgi?id=47333 * Scripts/webkitdirs.pm: * WebKitTestRunner/DerivedSources.pro: Added. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added. * WebKitTestRunner/WebKitTestRunner.pro: Added. * WebKitTestRunner/qt/DerivedSources.pro: Removed. Content merged in ../DerivedSources.pro 2010-10-07 Balazs Kelemen Unreviewed. Do a renaming that was recommended by the reviewer (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253) * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::RunUntilConditionLoop): (WTR::TestController::runUntil): 2010-10-07 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] Watchdog timer implementation for WTR https://bugs.webkit.org/show_bug.cgi?id=47337 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out the definition of the timer type to a typedef. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added. Timer implementation with QTimer and a helper QObject class. (WTR::WatchdogTimerHelper::instance): (WTR::WatchdogTimerHelper::timerFired): (WTR::WatchdogTimerHelper::WatchdogTimerHelper): (WTR::LayoutTestController::platformInitialize): (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer): (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): 2010-10-07 Balazs Kelemen Unreviewed buildfix for 69297 again * WebKitTestRunner/TestController.cpp: (WTR::blankURL): 2010-10-07 Balazs Kelemen Unreviewed trivial build fix for r69297 * WebKitTestRunner/TestController.cpp: (WTR::blankURL): 2010-10-07 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. WebKitTestRunner should be portable https://bugs.webkit.org/show_bug.cgi?id=45393 Use only the WebKit API for working with urls. * WebKitTestRunner/StringFunctions.h: (WTR::createWKURL): * WebKitTestRunner/TestController.cpp: (WTR::blankURL): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame): 2010-10-07 Carlos Garcia Campos Reviewed by Xan Lopez. [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3 https://bugs.webkit.org/show_bug.cgi?id=47332 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): 2010-10-06 Chris Guillory Reviewed by Chris Fleizach. Remove unused accessibility functions from webkit. https://bugs.webkit.org/attachment.cgi?bugid=46707 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): * DumpRenderTree/chromium/WebViewHost.h: 2010-10-06 Lucas Forschler Reviewed by Adam Roben. Fix the sunspider-compare-results to actually use the passed in value for $root. * Scripts/sunspider-compare-results: 2010-10-06 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] Runloop implementation for WTR https://bugs.webkit.org/show_bug.cgi?id=47280 * WebKitTestRunner/qt/TestControllerQt.cpp: Implemented TestController::runUntil by a timerEvent and a QEventLoop. We step into the event loop from runUntil. While we are waiting in the loop a timerEvent is periodically checking the value of the condition. Once the condition has becoming true the timerEvent wakes us up. (WTR::RunUntilLoop::start): (WTR::RunUntilLoop::RunUntilLoop): (WTR::RunUntilLoop::run): (WTR::RunUntilLoop::timerEvent): (WTR::TestController::platformInitialize): (WTR::TestController::runUntil): * WebKitTestRunner/qt/main.cpp: Start the main event loop first and creating the TestController later. (Launcher::Launcher): (Launcher::~Launcher): (Launcher::launch): Creating the TestController. (main): Setting up a timer for calling Launcher::launch from the main event loop. 2010-10-06 Dirk Pranke Reviewed by Kenneth Russell. new-run-webkit-tests: fix typo in chromium-gpu that was trying to enable 'accelerated-composting' instead of 'accelerated-compositing'. https://bugs.webkit.org/show_bug.cgi?id=47312 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: 2010-10-06 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] PlatformWebView implementation for WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=47276 The implementation follows the way how we use the API in MiniBrowser. * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::wkView): (WTR::WebView::~WebView): (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus): * WebKitTestRunner/qt/WebKitTestRunner.pro: 2010-10-06 Balazs Kelemen Reviewed by Kenneth Rohde Christiansen. [Qt] Add WebKitTestRunner's build files https://bugs.webkit.org/show_bug.cgi?id=44155 Parts was taken by Zoltan Horvath's patch. * Scripts/generate-forwarding-headers.pl: Moved from WebKit2. * Scripts/webkitdirs.pm: Make the generated files needed by WTR. * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for PlatformWKView and PlatformWindow (void* for now). Buildfix the case when __APPLE__ is not defined. * WebKitTestRunner/qt/DerivedSources.pro: Added. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus): * WebKitTestRunner/qt/TestControllerQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::TestController::runUntil): (WTR::TestController::platformInitialize): (WTR::TestController::initializeInjectedBundlePath): (WTR::TestController::initializeTestPluginDirectory): (WTR::TestController::platformInitializeContext): * WebKitTestRunner/qt/WebKitTestRunner.pro: Added. * WebKitTestRunner/qt/main.cpp: Added. (main): 2010-10-06 Tony Chang Unreviewed, rolling out r69202. http://trac.webkit.org/changeset/69202 https://bugs.webkit.org/show_bug.cgi?id=46937 Broke compile of test_shell * DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles): * DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject): 2010-10-06 Daniel Cheng Reviewed by Tony Chang. [chromium] Minor naming cleanup in WebDragData, part 2 https://bugs.webkit.org/show_bug.cgi?id=46937 Update DRT to use the renamed methods. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles): * DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject): 2010-10-06 David Kilzer Move WebArchive serialization code into its own file Reviewed by Adam Roben. This is the first step in making webarchive tests work on Windows. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new files to the project. * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved to WebArchiveDumpSupport.mm. * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added. * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm. (serializeWebArchiveToXML): 2010-10-05 Daniel Bates Reviewed by David Kilzer. Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog https://bugs.webkit.org/show_bug.cgi?id=46058 Make VCSUtils::fixChangeLogPatch() return a reference to a hash structure so as to support returning additional information about a change log diff. Currently, VCSUtils::fixChangeLogPatch() returns a string that represents the change log diff. Towards supporting the return of additional information, such as whether the change log diff inserts an entry at the top of the ChangeLog file, we need to make VCSUtils::fixChangeLogPatch() return a reference to hash structure. * Scripts/VCSUtils.pm: - Modified fixChangeLogPatch() to return a reference to a hash structure. - Added documentation to fixChangeLogPatch(). - Modified call site in mergeChangeLogs() as necessary. * Scripts/svn-apply: - Modified call site in patch() as necessary. * Scripts/svn-create-patch: - Modified call site in generateDiff() as necessary. * Scripts/svn-unapply: - Modified call site in patch() as necessary. * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: - Modified the unit tests as necessary. 2010-10-05 Tony Chang Reviewed by Darin Adler. fix the link to the expected image on windows https://bugs.webkit.org/show_bug.cgi?id=47228 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On windows, the file must be opened in binary mode when writing binary data. 2010-10-05 Adam Barth Update expected result of unittest to match Tony's change below. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2010-10-05 Tony Chang Reviewed by Ojan Vafai (over the shoulder). Paper over errors in image_diff so we don't crash the whole test run. * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-10-05 Tony Chang Unreviewed, make shutil.rmtree more resiliant to errors since windows was raising WindowsError: The process cannot access the file because it is being used by another process. * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-10-05 Tony Chang Reviewed by Ojan Vafai. [chromium] fix image diffing in NRWT https://bugs.webkit.org/show_bug.cgi?id=47128 * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using NamedTemporaryFile since it doesn't work on Windows. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2010-10-05 Kenneth Russell Reviewed by Tony Chang. [chromium] Implement layerTreeAsText in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=47216 Plumbed Frame::layerTreeAsText through Chromium's WebKit API to make it callable from DumpRenderTree. No new tests; verified with existing compositor layout tests. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText): * DumpRenderTree/chromium/LayoutTestController.h: 2010-10-05 Brent Fulgham Unreviewed build correction. * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug property sheet so proper libraries are linked. 2010-10-05 Robert Hogan Reviewed by Andreas Kling. [Qt] Fix url conversion in QWebHistory Converting from KURL to WFT::String to QUrl does not permit proper percent encoding later. https://bugs.webkit.org/show_bug.cgi?id=47048 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem): 2010-10-05 Anders Carlsson Reviewed by Sam Weinig. REGRESSION (r68966?): All dumpAsText test fail on WebKit2 https://bugs.webkit.org/show_bug.cgi?id=47188 When constructing the std::string, use the real string length instead of the maximum buffer size. * TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::toSTD): * WebKitTestRunner/StringFunctions.h: (WTR::toSTD): 2010-10-04 Sam Weinig Reviewed by Mark Rowe. Add MIMEType accessor to WKFrame https://bugs.webkit.org/show_bug.cgi?id=47138 * TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::toSTD): * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added. (TestWebKitAPI::didStartProvisionalLoadForFrame): (TestWebKitAPI::didCommitLoadForFrame): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added. (TestWebKitAPI::didStartProvisionalLoadForFrame): (TestWebKitAPI::didCommitLoadForFrame): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed. * TestWebKitAPI/Tests/WebKit2/icon.png: Added. * TestWebKitAPI/Tests/WebKit2/simple.html: Added. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::createURLForResource): 2010-10-05 Gabor Rapcsanyi Reviewed by Ojan Vafai. [NRWT] Rename current_dir to current_group because it's not a directory https://bugs.webkit.org/show_bug.cgi?id=47169 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-10-04 Dirk Pranke Unreviewed, build fix. r69065 broke test-webkitpy by trying to create a '/tmp-X' directory, which can't always be done. This test uses tempfile.mkdtemp(), which should be safe. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-04 Dirk Pranke Unreviewed, build fix. Add missing "from __future__ import with_statement" that was breaking test-webkitpy on the Leopard bots (broke in r69040). * Scripts/webkitpy/layout_tests/port/google_chrome.py: 2010-10-04 Sheriff Bot Unreviewed, rolling out r69066. http://trac.webkit.org/changeset/69066 https://bugs.webkit.org/show_bug.cgi?id=47163 Made NRWT reliability worse. (Requested by tkent on #webkit). * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2010-10-04 Gabor Rapcsanyi Reviewed by Tony Chang. [NRWT] Reverse the http tests to alphabetical order. https://bugs.webkit.org/show_bug.cgi?id=47075 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-10-04 Robert Hogan Reviewed by Andreas Kling. [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html We need to queue back and forward navigations in the DRT from the LayoutTestController so that maybeDump() knows about them. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): 2010-10-04 Tony Chang Reviewed by Kent Tamura. [chromium] fix image diffing in NRWT https://bugs.webkit.org/show_bug.cgi?id=47128 * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the temp file and check the image_diff error code more carefully * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2010-10-04 Dirk Pranke Reviewed by Adam Barth. aroben's change in r68792 actually broke new-run-webkit-tests when running the DRT code path. His change was intended to fix the way we were converting windows paths to URIs when running under Cygwin (the paths were getting one too many "/" on the front). However, the change ended up breaking the chromium_win port, which had slightly different logic. This patch removes the port-specific code and adds tests to make sure we're getting the behavior we expect. The Port object no longer exposes a get_absolute_path() method that can be used outside of of converting test filenames, because it's unreliable otherwise (we don't have the right context to know which conversion is intended). https://bugs.webkit.org/show_bug.cgi?id=47140 * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-04 Dirk Pranke Unreviewed, build fix. Handle crash introduced in r69040 if we are not running in a Chromium checkout. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 2010-10-04 Dirk Pranke Reviewed by Tony Chang. Add a way for us to have test expectations that are specific to the official builds of Google Chrome (as opposed to Chromium). This change looks for an additional "test_expectations_chrome.txt" file in Chromium's repository (webkit/tools/layout_tests), and uses the concatenation of that file and the regular test_expectations.txt file for test overrides. https://bugs.webkit.org/show_bug.cgi?id=46854 * Scripts/webkitpy/layout_tests/port/google_chrome.py: * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: 2010-10-04 Simon Fraser Color tests in the list based on existing pass/fail result. Fix the summary data to account for htmlOnly and nonHTML tests. * CSSTestSuiteHarness/harness/harness.css: (#test-list > option.pass): (#test-list > option.fail): (#test-list > option.skipped): * CSSTestSuiteHarness/harness/harness.js: (Test): (Test.prototype.statusForFormat): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.recordResult): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.countTestsWithFlag): (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction): (TestSuite.prototype.queryDatabaseForSummary): 2010-10-04 Chris Fleizach Reviewed by Beth Dakin. AX: doAXRangeForLine does not work https://bugs.webkit.org/show_bug.cgi?id=47101 DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute. * DumpRenderTree/AccessibilityUIElement.cpp: (rangeForLineCallback): (AccessibilityUIElement::rangeForLine): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::rangeForLine): 2010-10-04 Andrey Kosyakov Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-10-04 Sam Weinig Reviewed by Anders Carlsson. Add ability to set the CacheModel in Webkit2 https://bugs.webkit.org/show_bug.cgi?id=47066 * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): Opt minibrowser into a PrimaryWebBrowser cache model. 2010-10-03 Simon Fraser Make sure to enter all tests when creating the database for the first time. When migrating to a new version of the suite, be sure to sync up the database and testinfo.data by removing old tests, and inserting new ones. * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.insertTest): 2010-10-03 Simon Fraser More work on treating HTML4 and XHTML1 independently; when changing the format, rebuild the test list, and update the numbers in the chapter popup. * CSSTestSuiteHarness/harness/harness.js: (Test): (Test.prototype.runForFormat): (Test.prototype.completedForFormat): (ChapterSection): (ChapterSection.prototype.countTests): (Chapter): (Chapter.prototype.description): (Chapter.prototype.countTests): (Chapter.prototype.testCount): (Chapter.prototype.untestedCount): (TestSuite.prototype.buildChapters): (TestSuite.prototype.loadCurrentTest): (TestSuite.prototype.updateProgressLabel): (TestSuite.prototype.processFlags): (TestSuite.prototype.formatChanged): 2010-10-03 Simon Fraser Update test suite version 20101001. Handle database migration, and delete tests from the db that are not present in testinfo.data. Load about:blank into the test frame before the test url, to make missing tests more obvious. * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.openDatabase.migration1_0To1_1): (TestSuite.prototype.openDatabase.if.return): (TestSuite.prototype.databaseReady): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction): (TestSuite.prototype.syncDatabaseWithTestInfoData): 2010-10-02 Simon Fraser Add the ability to jump to a specific test. * CSSTestSuiteHarness/harness/harness.html: * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.goToTestByName): (TestSuite.prototype.switchToFormat): 2010-10-02 Simon Fraser For a ref test, load the ref in the same format (HTML4 vs XHTML1) as the test. * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef): 2010-10-02 Simon Fraser Update the UI to reflect the fact that each test needs to be tested in both HTML4 and XHTML1 format. * CSSTestSuiteHarness/harness/harness.js: (Test): (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.recordResult): (TestSuite.prototype.formatChanged): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus): 2010-10-01 Simon Fraser Add the ability to remove results for re-testing, and to import results. * CSSTestSuiteHarness/harness/harness.css: (.custom button): (#overlay): (#overlay.visible): (.overlay-contents): (.overlay-contents textarea): (.overlay-contents .buttons): (.overlay-contents .note): (.overlay-contents .buttons button): * CSSTestSuiteHarness/harness/harness.html: * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.importResults): (TestSuite.prototype.clearResults): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.importTestResults): (TestSuite.prototype.clearTestResults): 2010-10-01 Sam Weinig Reviewed by Jon Honeycutt. Deploy the new WKString functions to remove most uses of CF from the WebKitTestRunner. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::done): * WebKitTestRunner/StringFunctions.h: (WTR::toWK): (WTR::toJS): (WTR::toSTD): (WTR::operator<<): (WTR::copyURLString): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2010-10-01 Mihai Parparita Unreviewed TestResultsServer change. Add files introduced by http://crrev.com/61273 to the list of dashboard files to update. * TestResultServer/handlers/dashboardhandler.py: 2010-10-01 Brian Weinstein Build Fix for Windows. * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/ ForwardingHeaders to the include path. 2010-10-01 Sam Weinig Reviewed by Anders Carlsson. Add SPI to convert a WKStringRef to a JSStringRef and vice-versa. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKString.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added. (TestWebKitAPI::TEST): 2010-10-01 Sam Weinig Reviewed by Kenneth Rohde Christiansen. Add additional WKString API https://bugs.webkit.org/show_bug.cgi?id=46958 Add basic WKStringRef tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added. 2010-10-01 Sam Weinig Reviewed by Dan Bernstein. Add makefile for TestWebKitAPI and call it from the base makefile. * Makefile: * TestWebKitAPI/Makefile: Added. 2010-10-01 Sam Weinig Reviewed by Adam Roben. Remove unnecessary ForwardingHeaders from test runners. https://bugs.webkit.org/show_bug.cgi?id=47010 * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/ForwardingHeaders: Removed. * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/ForwardingHeaders: Removed. 2010-09-30 Adam Barth Reviewed by Eric Seidel. WebSocket tests are flaky https://bugs.webkit.org/show_bug.cgi?id=46956 Update these tools to understand how to run the WebSocket tests off the Apache server. * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/websocket_server.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-01 Adam Roben Encode Executive command arguments using UTF-8 on Cygwin Cygwin's Python's os.execv doesn't support unicode command arguments. Cygwin's execv expects arguments to be encoded using the current code page. But code pages are limited in what characters they can handle, and our tests include characters that the English code page can't handle. So for now we'll just encode everything in UTF-8 on Cygwin, which can handle all characters but might confuse some commands, for expediency's sake. I'm sure we'll run into cases where UTF-8 isn't good enough, but we can deal with that when the problem arises. Reviewed by Adam Barth. Fixes webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode fails on Windows * Scripts/webkitpy/common/system/executive.py: (Executive._run_command_with_teed_output): (Executive.run_command): On Cygwin, encode arguments using UTF-8. 2010-10-01 Sam Weinig Reviewed by Adam Roben. Add simple API tester for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=46953 This adds a very simple testing infrastructure for testing APIs exposed through the WebKit project. It consists of two parts: 1) a project that builds the all the tests 2) a script that searches the tests directory and calls the tester once for each test. This adds the infrastructure and two tests: - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures. - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API. This currently only works on the mac, but is designed to be easily ported to any platform. * Scripts/run-api-tests: Added. * Scripts/build-api-tests: Added. Scripts to build/run the tests. * TestWebKitAPI: Added. * TestWebKitAPI/Configurations: Added. * TestWebKitAPI/Configurations/Base.xcconfig: Added. * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added. * TestWebKitAPI/ForwardingHeaders: Added. * TestWebKitAPI/ForwardingHeaders/wtf: Added. * TestWebKitAPI/PlatformUtilities.h: Added. * TestWebKitAPI/PlatformWebView.h: Added. (TestWebKitAPI::PlatformWebView::platformView): * TestWebKitAPI/StringFunctions.h: Added. * TestWebKitAPI/Test.h: Added. (TestWebKitAPI::Test::~Test): (TestWebKitAPI::Test::name): (TestWebKitAPI::Test::Register::Register): (TestWebKitAPI::Test::Register::create): (TestWebKitAPI::Test::Test): * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added. * TestWebKitAPI/TestWebKitAPIPrefix.h: Added. * TestWebKitAPI/TestsController.cpp: Added. (TestWebKitAPI::TestsController::shared): (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::runTestNamed): (TestWebKitAPI::TestsController::testFailed): (TestWebKitAPI::TestsController::registerCreateTestFunction): * TestWebKitAPI/TestsController.h: Added. * TestWebKitAPI/mac: Added. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added. (TestWebKitAPI::Util::run): (TestWebKitAPI::Util::createURLForResource): * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added. (TestWebKitAPI::PlatformWebView::PlatformWebView): (TestWebKitAPI::PlatformWebView::resizeTo): (TestWebKitAPI::PlatformWebView::~PlatformWebView): (TestWebKitAPI::PlatformWebView::page): (TestWebKitAPI::PlatformWebView::focus): * TestWebKitAPI/mac/main.mm: Added. Infrastructure. * TestWebKitAPI/Tests: Added. * TestWebKitAPI/Tests/WTF: Added. * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added. * TestWebKitAPI/Tests/WebKit2: Added. * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added. (TestWebKitAPI::State::State): * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added. Proof of concept tests. 2010-10-01 Adam Roben Don't assume AccessibleObjectFromEvent succeeds Fixes Crash in DumpRenderTree!notificationListenerProc when running plugins/access-after-page-destroyed.html Reviewed by Sam Weinig. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (notificationListenerProc): Check both the return value of AccessibleObjectFromEvent and the object it returns, as MSDN recommends. 2010-10-01 Gabor Rapcsanyi Reviewed by Tony Chang. [NRWT] Put the http and websocket tests first in the test list. https://bugs.webkit.org/show_bug.cgi?id=46453 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-10-01 Fady Samuel Unreviewed, adding myself to the committer list. * Scripts/webkitpy/common/config/committers.py: 2010-10-01 Adam Roben Test NPN_GetValue(NPNVnetscapeWindow) Test for Right-clicking on windowless Flash plugin in WebKit2 makes a context menu appear in the bottom-right corner of the screen Reviewed by Anders Carlsson. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_GetValue): Added. Calls through to the browser. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue. * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added. (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members. (GetValueNetscapeWindow::NPP_SetWindow): Test that NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it isn't our HWND. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added GetValueNetscapeWindow. 2010-10-01 Andreas Kling Unreviewed, adding my webkit.org identity to reviewer list. * Scripts/webkitpy/common/config/committers.py: 2010-09-30 Adam Barth Reviewed by Eric Seidel. The WebSocket server should flush its logs https://bugs.webkit.org/show_bug.cgi?id=46946 The WebSocket server logs are truncated because the driver just terminates the child. It should run Python without buffering so we can see the end of the log. * Scripts/webkitpy/layout_tests/port/websocket_server.py: 2010-09-30 Simon Fraser Add a button to jump to the next untested test. * CSSTestSuiteHarness/harness/harness.css: (.test-type): (.name > button): * CSSTestSuiteHarness/harness/harness.html: * CSSTestSuiteHarness/harness/harness.js: (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.testInfoDataLoaded): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.buildTestListForChapter): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.testCompletionStateChanged): 2010-09-29 Jon Honeycutt WebKit2 on Windows should use Windows fonts for the various standard font families https://bugs.webkit.org/show_bug.cgi?id=43499 Reviewed by Adam Roben. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Use the Mac fonts for running tests. This matches DRT behavior. 2010-09-30 Adam Barth Third attempt. We need a better integration test environment. * Scripts/webkitpy/common/net/failuremap.py: * Scripts/webkitpy/common/net/failuremap_unittest.py: 2010-09-30 Robert Hogan Reviewed by Andreas Kling. [Qt] Support for PlainTextController Unskip editing/text-iterator/basic-iteration.html https://bugs.webkit.org/show_bug.cgi?id=38805 * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. (PlainTextController::PlainTextController): (PlainTextController::plainText): * DumpRenderTree/qt/PlainTextControllerQt.h: Added. 2010-09-30 Adam Barth Unreviewed. Second attempt to fix sheriffbot. * Scripts/webkitpy/common/net/buildbot.py: 2010-09-30 Adam Barth Unreviewed. This patch should stop the sheriffbot from throwing an exception. * Scripts/webkitpy/common/net/buildbot.py: 2010-09-30 Brian Weinstein Reviewed by Adam Roben. The same bots shouldn't run both Windows Debug Tests and Windows Release Tests. https://bugs.webkit.org/show_bug.cgi?id=46926 * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows Release Tests, and two bots running Windows Debug Tests, instead of four running both. 2010-09-30 Adam Barth Reviewed by Eric Seidel. webkit-patch find-flaky-tests should print results URLs https://bugs.webkit.org/show_bug.cgi?id=46917 Printing out the results URL makes find-flaky-tests more actionable because you can see what happens when a test fails. The output from the script is still pretty noisy, but it seems useful. * Scripts/webkitpy/tool/commands/queries.py: 2010-09-30 Chris Marrin Reviewed by Simon Fraser. Make 2D accelerated canvas rendering build on Mac https://bugs.webkit.org/show_bug.cgi?id=46007 Added ACCELERATED_2D_CANVAS to build-webkit * Scripts/build-webkit: 2010-09-29 Kenneth Russell Reviewed by Dimitri Glazkov. [chromium] Add accelerated compositing support to DumpRenderTree and test_shell https://bugs.webkit.org/show_bug.cgi?id=46849 Added offscreen code path for WebGraphicsContext3DDefaultImpl which works with the compositor integration in both DumpRenderTree and test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint and thereby trigger the compositor's readback code path. Added support for --enable-accelerated-compositing to DumpRenderTree. Tested in both test_shell and DumpRenderTree on Linux, the latter by modifying a compositing layout test, dumping the pixels and verifying that they matched the output when the compositor was active. * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingEnabled): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleComposite): * DumpRenderTree/chromium/WebViewHost.h: 2010-09-30 Adam Roben Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work Reviewed by Adam Barth. Fixes Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on Windows * Scripts/webkitpy/tool/bot/queueengine.py: (QueueEngine.run): Stop ourselves normally (including cleaning up log files) when the delegate tells us to stop processing work. * Scripts/webkitpy/tool/bot/queueengine_unittest.py: (LoggingDelegate.__init__): Moved code here from RaisingDelegate.__init__. (LoggingDelegate.expeced_callbacks): Added the stop_work_queue callback. (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate. (RaisingDelegate.__init__): Removed code that LoggingDelegate takes care of for us now. (QueueEngineTest.test_trivial): Make sure we got the expected stop message. (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly remove the callbacks that are related to processing a single work item, rather than removing all callbacks after a certain point, as there are now more callbacks we expect to receive at the end. 2010-09-30 Adam Roben Fix path -> URL conversion on Cygwin Reviewed by Adam Barth. Fixes Many tests in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows * Scripts/webkitpy/layout_tests/port/base.py: (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by assuming paths already have a leading slash. 2010-09-30 Adam Roben Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once The NPP_SetWindow call made when the plugin is torn down was confusing us, and was causing us to spew an error into the next test. Fixes REGRESSION (r68520): plugins/access-after-page-destroyed.html failing on Windows Reviewed by Anders Carlsson. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow): Initialize member. (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if this isn't the first time this is called. 2010-09-30 Eric Seidel Reviewed by Adam Barth. webkit-patch upload warns that I'm using Xcode when I'm not https://bugs.webkit.org/show_bug.cgi?id=46869 String.find returns -1 when not found, so switched to "in". * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/common/system/user_unittest.py: 2010-09-30 Eric Seidel Reviewed by Adam Barth. webkit-patch failure-reason dies if non-trunk commits are in the blame range https://bugs.webkit.org/show_bug.cgi?id=46866 I also made failure-reason use RegressionWindow in a cleaner way. * Scripts/webkitpy/tool/commands/queries.py: 2010-09-29 Adam Barth Reviewed by Eric Seidel. webkit-patch find-flaky-tests https://bugs.webkit.org/show_bug.cgi?id=46876 This command helps us find flaky tests so we can squash them. * Scripts/webkitpy/tool/commands/queries.py: 2010-09-29 Simon Fraser Fix export to use '?' instead of 'null' for tests with no results. * CSSTestSuiteHarness/harness/harness.js: 2010-09-29 Simon Fraser Add a warning when a test requires special steps. Add a Print Preview button for 'paged' tests that brings up the print dialog, allowing the user to judge paged media tests. * CSSTestSuiteHarness/harness/harness.css: * CSSTestSuiteHarness/harness/harness.html: * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.processFlags): 2010-09-29 Adam Barth Reviewed by Eric Seidel. Remove revisions_casuing_failures https://bugs.webkit.org/show_bug.cgi?id=46872 This function exists only to be unit tested. * Scripts/webkitpy/common/net/failuremap.py: * Scripts/webkitpy/common/net/failuremap_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-29 Adam Barth Reviewed by Eric Seidel. SheriffBot should post the list of failing tests to bugs https://bugs.webkit.org/show_bug.cgi?id=46871 * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/failuremap.py: * Scripts/webkitpy/common/net/regressionwindow.py: * Scripts/webkitpy/tool/bot/sheriff.py: * Scripts/webkitpy/tool/bot/sheriff_unittest.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-29 Brent Fulgham Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe. [WinCairo] Adds a build slave. https://bugs.webkit.org/show_bug.cgi?id=46360 * BuildSlaveSupport/build.webkit.org-config/config.json: Add entries for a debug build of the WinCairo port. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to configuration for wincairo (like gtk, chromium, etc.) * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo' * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo' 2010-09-29 Adam Barth Reviewed by Eric Seidel. Move more SheriffBot smarts into FailureMap https://bugs.webkit.org/show_bug.cgi?id=46703 This patch pushes the FailureMap model object further into the SheriffBot machine. In addition, it moves a couple operations on this object from SheriffBot itself to the model. Eventually, FailureMap will be the canonical context object for SheriffBot operations. FailureMap represents a map of the current failures on the bots that might require remediation. * Scripts/webkitpy/common/net/failuremap.py: * Scripts/webkitpy/common/net/regressionwindow.py: * Scripts/webkitpy/tool/commands/queries.py: * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-29 Tony Chang Reviewed by James Robinson. [chromium] enable -Werror for DRT and webkit_unit_tests on Linux https://bugs.webkit.org/show_bug.cgi?id=46829 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): (WebViewHost::WebViewHost): 2010-09-29 Chris Fleizach Reviewed by Darin Adler. AX: implement CSS3 Speech "speak" https://bugs.webkit.org/show_bug.cgi?id=46827 * DumpRenderTree/AccessibilityUIElement.cpp: (speakCallback): (AccessibilityUIElement::speak): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::speak): 2010-09-29 Mihai Parparita Reviewed by Adam Barth. Record bot ID when updating queue status https://bugs.webkit.org/show_bug.cgi?id=46764 Since we now have multiple bots handling patches from the commit queue, we need to differentiate status updates from them, so that we can group the queue status page in a less confusing way. * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input * QueueStatusServer/model/queuestatus.py: Add bot_id property * QueueStatusServer/templates/updatestatus.html: Add bot_id input * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser * Scripts/webkitpy/common/net/statusserver.py: Add bot_id * Scripts/webkitpy/common/net/statusserver_unittest.py: Added. * Scripts/webkitpy/tool/main.py: Add --bot-id * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser 2010-09-29 Simon Fraser No review. References always refert to a file in .xht format, even for HTML tests, so fix their loading. * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef): 2010-09-28 Johnny Ding Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=41292 Add a new parameter to the test plugin to allow specifying a script and a mouse/keyboard event. The specified script will be evaluated in the browser when the specified event is received by the plugin. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate): * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa): 2010-09-28 Simon Fraser Fix export by adding missing argument. * CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.showResultsForAllTests): 2010-09-28 Kevin Ollivier [wx] Build fix, add missing import. * wx/packaging/build-win-installer.py: 2010-09-28 Simon Fraser No review Show which tests have been run by dimming them out in the test list. Adjust some element sizes. * CSSTestSuiteHarness/harness/harness.css: (#test-list > option.untested): (#test-list > option.completed): (#output): (.output-options): * CSSTestSuiteHarness/harness/harness.js: (Test): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.setSelectedChapter): (TestSuite.prototype.recordResult): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.testCompletionStateChanged): (TestSuite.prototype.loadTestStatus): 2010-09-28 Simon Fraser No review. Implement export of various queries on the test database, sharing code with that which displays results inline. * CSSTestSuiteHarness/harness/harness.js: (): (TestSuite.prototype.exportResultsCompletion.var): (TestSuite.prototype.exportResultsCompletion): (TestSuite.prototype.showResultsForCompletedTests): (TestSuite.prototype.exportResultsForCompletedTests): (TestSuite.prototype.showResultsForAllTests): (TestSuite.prototype.exportResultsForAllTests): (TestSuite.prototype.exportResultsForTestsNotRun): (TestSuite.prototype.exportResultsForTestsWithStatus): (TestSuite.prototype.exportResultsForTestsWithMismatchedResults): 2010-09-28 Simon Fraser No review. Work around uncertainty about the order of database transactions when creating the database, so that we don't try to query the table before it has been created. * CSSTestSuiteHarness/harness/harness.js: (TestSuite): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.queryDatabaseForTestsWithStatus): (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus): (TestSuite.prototype.queryDatabaseForCompletedTests): (TestSuite.prototype.queryDatabaseForTestsNotRun): 2010-09-28 Tony Chang Reviewed by Eric Seidel. add python keyring support to webkit-patch https://bugs.webkit.org/show_bug.cgi?id=41269 * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using the python keyring module * Scripts/webkitpy/common/net/credentials_unittest.py: * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params. * Scripts/webkitpy/common/system/user_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-28 Martin Robinson Reviewed by Gustavo Noronha Silva. [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings https://bugs.webkit.org/show_bug.cgi?id=46740 * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common fonts which can be used to fully test FontConfig rendering settings. 2010-09-28 Martin Robinson Reviewed by Gustavo Noronha Silva. [gtk] Fedora has a different path for the liberation fonts https://bugs.webkit.org/show_bug.cgi?id=46709 When searching for DRT fonts, also look in the path where those fonts are commonly found on Fedora systems. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Include logic for looking for Fedora-style font paths. 2010-09-28 Martin Robinson Reviewed by Andreas Kling. run-webkit-tests needs an updated list of directories with webgl tests https://bugs.webkit.org/show_bug.cgi?id=46747 Update the list of directories containing WebGL tests and a unit test which depends on this list. * Scripts/old-run-webkit-tests: Update the list of directories. * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result. 2010-09-28 Adam Barth Reviewed by Eric Seidel. Introduce FailureMap to summaries the failures status of all the bots https://bugs.webkit.org/show_bug.cgi?id=46700 This patch gives the SheriffBot a handle on the list of failing tests. * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/failuremap.py: Added. * Scripts/webkitpy/tool/commands/queries.py: * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-28 Adam Roben Update for the addition of WKPageUIClient::didNotHandleKeyEvent Fixes Need API to tell a WebKit2 client application that a key event was not handled Reviewed by Kenneth Rohde Christiansen and Sam Weinig. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): * WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize): 2010-09-28 Simon Fraser Unreviewed. Update the CSSTestSuiteHarness to not scrape the XHTML chapter files for the test order, but instead use information from testinfo.data. * CSSTestSuiteHarness/harness/harness.html: * CSSTestSuiteHarness/harness/harness.js: 2010-09-28 Kevin Ollivier [wx] Build fix, don't try to get the svn revision from the git repo when packaging, it causes the process to hang on the gitorious repo. * wx/packaging/build-mac-installer.py: * wx/packaging/build-win-installer.py: 2010-09-28 Adam Roben Test that a plugin's HWND is sized/positioned before NPP_SetWindow is called Reviewed by Anders Carlsson. Test for Full-page Adobe Reader does not paint until window is resized * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at this level. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared NPP_SetWindow. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added. (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that the plugin's HWND has a non-zero size and that its size/position matches that specified in the NPWindow. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_SetWindow): Call through to the PluginTest. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder the files as it saw fit. 2010-09-28 Benjamin Poulain Reviewed by Andreas Kling. [Qt] Remove support for Qt 4.5 https://bugs.webkit.org/show_bug.cgi?id=46718 Remove the code for versions of Qt prior to 4.6. * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): (EventSender::updateTouchPoint): (EventSender::setTouchModifier): (EventSender::touchStart): (EventSender::touchMove): (EventSender::touchEnd): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::sendTouchEvent): * DumpRenderTree/qt/EventSenderQt.h: * DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText): * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::applyZoom): (LauncherWindow::setTouchMocking): * QtTestBrowser/launcherwindow.h: * QtTestBrowser/utils.cpp: (urlFromUserInput): * QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip): * QtTestBrowser/webview.h: (WebViewGraphicsBased::setYRotation): 2010-09-28 İsmail Dönmez Reviewed by Andreas Kling. Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable which should point to wcecompat installation. Needs wcecompat library from http://github.com/mauricek/wcecompat . * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2010-09-28 Daniel Bates Rollout changeset 68493 Rollout changeset 68493 because it broke Sheriffbot's rollout feature. In particular, this change caused Sheriffbot to raise an exception when trying to parse the bug id on a bug page. We need to look into this some more. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla_unittest.py: * Scripts/webkitpy/tool/bot/sheriff.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/steps/closebug.py: * Scripts/webkitpy/tool/steps/obsoletepatches.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: 2010-09-28 Adam Barth Reviewed by Eric Seidel. Move RegressionWindow further up the dependency chain https://bugs.webkit.org/show_bug.cgi?id=46698 Baby steps towards pushing this information into bug posts. * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/buildbot_unittest.py: * Scripts/webkitpy/common/net/regressionwindow.py: * Scripts/webkitpy/tool/commands/queries.py: 2010-09-27 Daniel Bates Reviewed by Adam Barth. sheriffbot can't roll out security patches https://bugs.webkit.org/show_bug.cgi?id=39136 Make SheriffBot determine if it's authorized to view a bug whose change it wants to rollout before it tries to rollout the change. Moreover, make both webkit-patch and Sheriffbot provide human- readable error messages when they are not authorized to view a bug and when a bug number is invalid. Currently, Sheriffbot does not parse Bugzilla bugs for , which indicates an error when retrieving a bug. In particular, error="NotPermitted" if a person (or bot) is not authorized to view a bug. For such error="NotPermitted" bugs, Sheriffbot raises an exception when parsing the bug report and this exception does not explicitly indicate Sheriffbot's lack of authorization. Instead, Sheriffbot should explicitly check for the presence before operating on a bug and error with a human-readable message if it's not permitted to view it. * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class. * Scripts/webkitpy/common/net/bugzilla_unittest.py: - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error(). - Added unit test test_bug_parsing_for_bugzilla_not_found_error(). - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error(). * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError. * Scripts/webkitpy/tool/commands/download.py: Ditto. * Scripts/webkitpy/tool/commands/queues.py: Ditto. * Scripts/webkitpy/tool/commands/upload.py: Ditto. * Scripts/webkitpy/tool/steps/closebug.py: Ditto. * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto. * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto. 2010-09-27 Adam Barth Reviewed by Eric Seidel. Expose more more failure information from Buildbot to SheriffBot https://bugs.webkit.org/show_bug.cgi?id=46697 This patch moves the information about what tests failured closer to SheriffBot. There are still a couple more patches to go before SheriffBot can post this information to bugs, but this is a step in that direction. Yay for unit tests, which caught some bugs in earlier versions of this patch. * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/buildbot_unittest.py: * Scripts/webkitpy/common/net/regressionwindow.py: Added. * Scripts/webkitpy/tool/commands/queries.py: 2010-09-27 Eric Seidel Unreviewed. Fixing 500 error seen in the status server. It turns out that a = b = []; b.append(1); then a[0] will be 1! This should have been obvious to me, I guess, but it was not what I was expecting. * QueueStatusServer/model/activeworkitems.py: 2010-09-27 Adam Barth Reviewed by Eric Seidel. commit-queue should reject patches that fail to land https://bugs.webkit.org/show_bug.cgi?id=46694 This can happen, for example, if there's no reviewer. Without this patch, we'll keep retrying the patch. * Scripts/webkitpy/tool/bot/commitqueuetask.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 2010-09-27 Simon Fraser Rubber-stamped by Adele Peterson. Add a harness for running the CSS 2.1 test suite. This harness assumes that you've got a local a copy of the suite adjacent to the 'harness' directory. The harness lets you go through the tests in chapter order, denoting pass/fail/skipped for each test. It uses a client-side database to store the results of testing. * CSSTestSuiteHarness/harness/harness.css: Added. * CSSTestSuiteHarness/harness/harness.html: Added. * CSSTestSuiteHarness/harness/harness.js: Added. 2010-09-27 Eric Seidel Reviewed by Adam Barth. Patch locks should expire if a patch is marked for retry https://bugs.webkit.org/show_bug.cgi?id=46682 This was part Adam's original CommitQueueTask design, but support for it was missing from the server. I added the support, but triggering lock-release based on this special "retry" status feels a bit strange so I added a FIXME. I also changed the text in queuestatus.html to say "Lock Acquired" since "Last Activity" isn't really true. We only update the lock date when the patch is started, not on every status update. I also noticed an exception in next-patch, which I fixed by re-writing the unzip logic in activeworkitems.py again. * QueueStatusServer/handlers/updatestatus.py: * QueueStatusServer/model/activeworkitems.py: * QueueStatusServer/templates/queuestatus.html: 2010-09-27 Tony Chang Reviewed by David Levin. [chromium] fix a warning when compiling DRT on 32-bit linux https://bugs.webkit.org/show_bug.cgi?id=46641 * DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleImage): 2010-09-27 Eric Seidel Reviewed by Adam Barth. queue-status should report when the patch was last locked to a queue https://bugs.webkit.org/show_bug.cgi?id=46674 This isn't necessarily the best way to expose this information but having this accessible via the web interface is very useful until we come up with a nicer way to display this. I also cleaned up the code in activeworkitems.py a little to use list comprehensions and to have the code work with pairs instead of two lists at once. Eventually I think those item/time pairs need to be their own little helper class. * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/model/activeworkitems.py: * QueueStatusServer/templates/queuestatus.html: 2010-09-27 Tony Chang Reviewed by David Levin. [chromium] fix detection of missing fonts on DRT https://bugs.webkit.org/show_bug.cgi?id=46651 * DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): Only print an error message if lohit isn't found in both locations. 2010-09-27 Tony Chang Reviewed by Dimitri Glazkov. add webkit unit tests to the chromium testers https://bugs.webkit.org/show_bug.cgi?id=46669 * BuildSlaveSupport/build.webkit.org-config/master.cfg: * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration. 2010-09-27 Kwang Yul Seo Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-27 Mihai Parparita Reviewed by Eric Seidel. webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console https://bugs.webkit.org/show_bug.cgi?id=46634 Use OutputCapture to prevent console spam (and also check for expected output). * Scripts/webkitpy/common/system/user_unittest.py: 2010-09-27 Eric Seidel Reviewed by James Robinson. start-commit-queue should abort any rebases in progress https://bugs.webkit.org/show_bug.cgi?id=46640 webkit-patch commit-queue would do this itself, but this just helps ensure that the commit-queue script is properly updated before we run it (in the case where a previous rebase is in progress the git svn rebase would not work before we run the commit-queue). * EWSTools/start-commit-queue.sh: 2010-09-18 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Clean up the DRT fonts.conf and switch to Liberation https://bugs.webkit.org/show_bug.cgi?id=46038 Switch to Liberation fonts for GTK+ layout tests. This will make our test results metric-compatible with many Windows/Chromium results. It also simplifies the fonts.conf that we load and prepares the way for fixing many font bugs. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Initialize a known list of fonts instead of loading every font in the WEBKIT_TESTFONTS directory. * DumpRenderTree/gtk/fonts.conf: Removed. * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF. * DumpRenderTree/gtk/fonts/fonts.conf: Added. * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that we can load both fonts.conf and AHEM____.TTF from this location. * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since it is no longer used. 2010-09-26 Mihai Parparita Reviewed by Ojan Vafai. new-run-webkit-httpd fails if Perl is not installed https://bugs.webkit.org/show_bug.cgi?id=46602 Make Port._read_configuration catch all exceptions, since trying to run perl (because of _webkit_build_directory) when it's not installed throws a WindowsError or OSError, not an IOError (this became an issue after r68268, since ChromiumPort ends up calling Port.default_configuration in its constructor, which means that we're ending up on this codepath in non-NRWT cases too, e.g. for the Chromium NaCl tests, which use new-run-webkit-httpd). * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2010-09-26 Gyuyoung Kim Reviewed by Antonio Gomes. [EFL] Add setting API to set a local storage database path. https://bugs.webkit.org/show_bug.cgi?id=45446 Add a setting API to set local storage database path. * EWebLauncher/main.c: (on_key_down): (browserCreate): (main): 2010-09-26 Sam Weinig Reviewed by Anders Carlsson. Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API https://bugs.webkit.org/show_bug.cgi?id=46587 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 2010-09-26 Antonio Gomes Reviewed by Kenneth Rohde Christiansen. DRT/Mac nodesFromRect support [Mac][DRT] Implement LayoutTestController::nodesFromRect https://bugs.webkit.org/show_bug.cgi?id=46580 Implements LayoutTestController::nodesFromRect for Mac DRT, and adding stubs for GTK+ and Windows. * DumpRenderTree/LayoutTestController.cpp: (nodesFromRectCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::LayoutTestController::nodesFromRect): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::nodesFromRect): 2010-09-25 Nicolas Weber Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=46555 Fix typo in prepare-ChangeLog's help output. * Scripts/prepare-ChangeLog: 2010-09-24 Sam Weinig Reviewed by Darin Adler. Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:] https://bugs.webkit.org/show_bug.cgi?id=46546 * MiniBrowser/mac/BrowserWindowController.m: (mouseDidMoveOverElement): (-[BrowserWindowController awakeFromNib]): * MiniBrowser/win/BrowserView.cpp: (mouseDidMoveOverElement): (BrowserView::create): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): * WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize): 2010-09-24 Mihai Parparita Reviewed by Adam Barth. Allow rebaselines for webkit-patch rebaseline to be chosen https://bugs.webkit.org/show_bug.cgi?id=46407 Instead of always rebaselining all failing tests, allow a subset to be chosen. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/commands/rebaseline.py: 2010-09-24 Ryosuke Niwa Reviewed by Tony Chang. [chromium] Implement TextInputController::firstRectForCharacterRange https://bugs.webkit.org/show_bug.cgi?id=38100 Implemented TextInputController::firstRectForCharacterRange for chromium platform. No new tests are added since we need to implement the same feature in chromium side in order to enable any tests that uses this function. * DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange): Added. 2010-09-24 Adam Barth Reviewed by Eric Seidel. commit-queue reports land failures as "PASS" https://bugs.webkit.org/show_bug.cgi?id=46530 We were ignoring the return value of land instead of passing it back to CommitQueue. Of course, this was the one case I forgot to test! * Scripts/webkitpy/tool/bot/commitqueuetask.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 2010-09-24 Kenichi Ishibashi Reviewed by Eric Seidel. new-run-webkit-tests prints out nothing when build-dumprendertree fails https://bugs.webkit.org/show_bug.cgi?id=37563 Print error message when build-dumprendertree fails. * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-09-24 Mihai Parparita Reviewed by Tony Chang. NRWT doesn't respect config set with set-webkit-configuration https://bugs.webkit.org/show_bug.cgi?id=46278 Use Port.default_configuration() instead of hardcoding Release in ChromiumPort configuration initialization, so that we still inherit the configuration set by set-webkit-configuration. * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 2010-09-24 Chang Shu Reviewed by Csaba Osztrogonác. [Qt] Fix the code to check file existence. https://bugs.webkit.org/show_bug.cgi?id=46465 * QtTestBrowser/main.cpp: (main): 2010-09-23 Tony Chang Unreviewed, rolling out r68232. http://trac.webkit.org/changeset/68232 Broken NRWT on the canary bots. * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-09-23 Dirk Pranke Unreviewed, build fix. r68008 broke new-run-webkit-tests in that the chromium ports no longer respect set-webkit-configuration. The correct fix for this is being pursued in bug 46278 (along with a bunch of unit tests), but in the meantime I'm reverting the particular lines that broke things. This was tested by hand. * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-09-23 Sam Weinig Reviewed by Anders Carlsson. WebKit2 API: Need way to know when a frame is removed from the hierarchy https://bugs.webkit.org/show_bug.cgi?id=46432 * MiniBrowser/mac/BrowserWindowController.m: (didRemoveFrameFromHierarchy): (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2010-09-23 Tony Chang Reviewed by Dimitri Glazkov. [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime https://bugs.webkit.org/show_bug.cgi?id=46426 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sampleSVGAnimationForElementAtTime): * DumpRenderTree/chromium/LayoutTestController.h: 2010-09-23 Martin Robinson Reviewed by Nate Chapin. [GTK] r68199 introduced two test failures https://bugs.webkit.org/show_bug.cgi?id=46424 Fix a regression handling preference overrides that are attached to boolean properties. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match so we must check for that when converting a string to a boolean. 2010-09-23 Dimitri Glazkov Reviewed by David Levin. Fix a condition check in ServerProcess, which becomes relevant when reading binary data. https://bugs.webkit.org/show_bug.cgi?id=46406 This breaks when the method is called with specified size of data (image data), and the buffer hasn't yet reached this size. * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of index larger than 0. 2010-09-23 Martin Robinson Reviewed by Nate Chapin. [GTK] Some tests from r68174 fail on the GTK+ bots https://bugs.webkit.org/show_bug.cgi?id=46396 Simplify LayoutTestController::overridePreference to make it easier for people unfamiliar with the code to keep the list of preferences up to date. Add the conversion for enable-hyperlink-auditing. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Use a simple if-else block to determine out the property name for overrridePreference. Also simplify the logic for setting string properties. Add the conversion for enable-hyperlink-auditing. 2010-09-23 Tony Chang Reviewed by David Levin. [chromium] add caretBrowsingEnabled to WebSettings and DRT https://bugs.webkit.org/show_bug.cgi?id=46388 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: 2010-09-23 Nate Chapin Reviewed by Darin Fisher. Allow DRT to toggle hyperlink auditing (i.e., ). https://bugs.webkit.org/show_bug.cgi?id=30458 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): 2010-09-21 Stephen White Reviewed by David Levin. Implement --enable-accelerated-2d-canvas flag in DumpRenderTree. https://bugs.webkit.org/show_bug.cgi?id=46208 This flag allows the layout tests to be run with or without accelerated 2D canvas rendering. * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Declare the new flag string, and check for it on startup. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Add a boolean for the new flag, in order to preserve its value over preferences reset. (TestShell::resetWebSettings): Set the new flag to the stored value on reset. * DumpRenderTree/chromium/TestShell.h: (TestShell::setAccelerated2dCanvasEnabled): Add an accessor for the new flag. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Initialize the new flag to false. (WebPreferences::applyTo): Copy the flag's value to the WebSettings. * DumpRenderTree/chromium/WebPreferences.h: Add the new flag. 2010-09-23 Tor Arne Vestbø Reviewed by Simon Hausmann. [Qt] Refactor QtWebKitPlatformPlugin interface Make it easier to keep source-compability for the QtWebKitPlatformPlugin interface, and run qmake on the example (but not build) for convenience. https://bugs.webkit.org/show_bug.cgi?id=46345 * Scripts/webkitdirs.pm: 2010-09-23 Adam Barth Reviewed by Eric Seidel. Tweak some status messages that Eric thought were confusing https://bugs.webkit.org/show_bug.cgi?id=46342 * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-22 Adam Barth Reviewed by Eric Seidel. Fix comm-queue typo https://bugs.webkit.org/show_bug.cgi?id=46339 We were missing a "self". The real problem is that we didn't have an integration test for the failure case. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-22 Adam Barth Reviewed by Eric Seidel. commit-queue should log more detailed messages to the QueueStatusServer https://bugs.webkit.org/show_bug.cgi?id=46333 When I created CommitQueueTask, I removed most of the previous logging. This patch adds back more detailed logging so folks can see their patch progress through the queue. * Scripts/webkitpy/tool/bot/commitqueuetask.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-22 Mihai Parparita Reviewed by Darin Fisher. [Chromium] User style layout tests don't pass on Chromium https://bugs.webkit.org/show_bug.cgi?id=46069 Fix a typo in LayoutTestController::addUserStyleSheet that was causing a crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT behavior from other ports. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addUserStyleSheet): 2010-09-22 Brent Fulgham Reviewed by Martin Robinson. [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build. https://bugs.webkit.org/show_bug.cgi?id=46303. * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added. * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved CoreFoundation-specific stuff to new MiniBrowserCoreFoundation property sheet. * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added. * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use appropriate property sheet for the build types. * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the configuration to use appropriate property sheet for CoreFoundation and CFLite-style builds. 2010-09-22 Adam Barth Reviewed by Eric Seidel. Optimize commit-queue performance for green trees https://bugs.webkit.org/show_bug.cgi?id=46254 This patch redesigns the controller logic for the commit-queue. In the new design, the controller exercises much finer-grained control over the landing process. In particular: - Patches that fail to apply now get rejected almost immediately. - Patches that fail to build get rejects after two builds (instead of three builds and one test run). - Patches that run into a flaky test now get accepted after one build and two test runs instead of three full build-and-test runs. The main cost of these optimizations is that we don't find out the tree has a failing test until the very end of the process, but if the tree has a busted test, there's not much we can do anyway. We might as well burn commit-queue resources spinning optimisticly. * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added. * Scripts/webkitpy/tool/commands/queues.py: 2010-09-22 Brent Fulgham Reviewed by Martin Robinson. [WinCairo] Update WebKitTestRunner and DumpRenderTree Build. https://bugs.webkit.org/show_bug.cgi?id=46303. * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the WinCairo build. * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added. * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo build targets that use the new InjectedBundleCFLite.vsprops file. 2010-09-22 Dirk Pranke Unreviewed, build fix. Fix bustage of rebaseline-chromium-webkit-tests resulting from r67974. Really need better unit tests for this tool :( * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-09-22 Adam Roben Unbreak test-webkitpy * Scripts/webkitpy/test/main.py: (Tester.run_tests): Add a line that mysteriously got deleted. 2010-09-22 Adam Roben Make test-webkitpy test WebKit2's scripts These scripts can't be in WebKitTools due to limitations of Apple's build process. But that doesn't mean we can't test them! Fixes test-webkitpy should test code in WebKit2/Scripts Reviewed by Adam Barth. * Scripts/test-webkitpy: (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test. Now takes an external_package_paths parameter and cleans both webkitpy and any external packages. (init): Added an external_package_paths parameter which we pass along to _clean_packages_with_test. (top level): Add WebKit2/Scripts/webkit2 as our only external package and pass it along to init and Tester.run_tests. * Scripts/webkitpy/test/main.py: (Tester.run_tests): Added an optional external_package_paths parameter. We modify sys.path so that the external packages can be imported, and search for unittest files inside all external packages in addition to inside webkitpy. 2010-09-22 Dirk Pranke Reviewed by Tony Chang. new-run-webkit-tests: r68063 broke linux python tests Add a missing "from __future__ import with_statement" to this new file; the perils of testing only on the Mac and by review :( https://bugs.webkit.org/show_bug.cgi?id=46293 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 2010-09-22 Dirk Pranke Reviewed by Tony Chang. Add a 'chromium-gpu' set of ports that will test the accelerated GPU paths. This patch adds: - support for the '--accelerated-compositing' and 'accelerated-2d-canvas' flags to new-run-webkit-tests (and the 'no-' flags) - adds a new set of Ports that will look under platform/chromium-gpu-$OS/ for baselines before looking in the regular chromium search path - adds a new test_expectations.txt file in platform/chromium-gpu that skips all but the tests we actually want to run with acceleration. This patch will allow us to run both with and without acceleration and to change the defaults for both the regular and -gpu options as the code evolves. We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to each test bot. https://bugs.webkit.org/show_bug.cgi?id=46225 * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: * Scripts/webkitpy/layout_tests/port/factory.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2010-09-22 Jamey Hicks Reviewed by Kenneth Rohde Christiansen. [Qt] Web Inspector: Remote Web Inspector support for QtWebKit https://bugs.webkit.org/show_bug.cgi?id=43988 Runs a web debug server on port specified by QtTestBrowser argument -remote-inspector-port. Property _q_webInspectorServerPort of the QWebPage instance will be set according to the argument. All pages with that property set will be remotely inspectable. URL for remote inspection of first QWebPage is http://localhost:9222/webkit/inspector/inspector.html?page=1 where 1 is the number of the QWebPage instance. The base URL yields an index page with links to the individual inspectors: http://localhost:9222/ * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): * QtTestBrowser/launcherwindow.h: * QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): 2010-09-22 Adam Roben Fix webkit-patch failure-reason now that build.webkit.org has been updated Fixes webkit-patch failure-reason crashes every time Reviewed by Eric Seidel. * Scripts/webkitpy/common/net/buildbot.py: (BuildBot._file_cell_text): Added. Travels down the firstChild chain looking for an element that contains text, then returns it. (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the text out of the cells. This way it doesn't matter whether the cells have children (as for cells in directory rows) or not (as for cells in file rows) (BuildBot._parse_twisted_directory_listing): Look for rows that have the "directory" or "file" class, rather than rows with any class, since header rows now have a class attribute. * Scripts/webkitpy/common/net/buildbot_unittest.py: (BuildBotTest._example_directory_listing): Updated to more closely match the markup that build.webkit.org is producing now. 2010-09-21 Dirk Pranke Unreviewed, build fix. new-run-webkit-tests: fix bug introduced in r68008 where if you specify --chromium and no --platform, and you're running on windows, you use the 'chromium-win' port by default instead of the version-specific port. This breaks the buildbots. It will be good for this refactoring to settle down so I can rewrite the logic for default ports and the unit tests to be clearer (and the testing more comprehensive). * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2010-09-21 Dirk Pranke Reviewed by Adam Barth. Modify the Port interface to take only a series of keyword arguments in the constructor, and modify Port/factory.get() to accomodate that, and to accept user=XXX as an argument so we can pass webkitpy.common.system.user.User objects in. Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests to use the common routine in webkitpy.common.system.user.open_url() to display HTML files. There was a routine in the Port interface to do the same thing, but I see no need for a port-specific hook for this, since it is something that will always be executed by the host environment and displaying web pages has nothing to do with running layout tests. Note that new-run-webkit-tests used to use test_shell to display the page; this is potentially useful so that you can actually click from a result to the broken page; however, since DumpRenderTree doesn't support this functionality, it will be going away eventually. https://bugs.webkit.org/show_bug.cgi?id=46128 * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/port/dryrun.py: * Scripts/webkitpy/layout_tests/port/factory.py: * Scripts/webkitpy/layout_tests/port/google_chrome.py: * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: * Scripts/webkitpy/layout_tests/port/gtk.py: * Scripts/webkitpy/layout_tests/port/mac.py: * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/win.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-09-21 Lucas De Marchi Reviewed by Kenneth Rohde Christiansen. [EFL] Get fresh theme when running EWebLauncher https://bugs.webkit.org/show_bug.cgi?id=46210 If user tried to run EWebLauncher outside of the build tree, it would not find the theme and fallback to the installed one. However, since EWebLauncher is not installed, we always want to take the theme from the just compiled source code. If user had never installed WebKit's EFL port it could even receive a segv since no theme would be found. Now EWebLauncher does not fallback to the installed theme and CMake gives as DATA_DIR the directory of the theme it has just built. * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to EWebLauncher. * EWebLauncher/main.c: Use only the theme from build director. Do not fallback to others as this could hide real bugs. (quit): (browserCreate): (findThemePath): (main): 2010-09-21 Dirk Pranke Unreviewed, build fix. Don't pass the --test-shell arg to the Chromium Mac port of DRT; it just confuses it. https://bugs.webkit.org/show_bug.cgi?id=46230 * Scripts/webkitpy/layout_tests/port/webkit.py: 2010-09-21 Lucas Forschler Reviewed by Stephanie Lewis. Make a new buildbot for Leopard Debug Test * BuildSlaveSupport/build.webkit.org-config/config.json: 2010-09-21 Dirk Pranke Unreviewed, build fix. Fix breakage of Chromium Mac DRT port caused by r67905. https://bugs.webkit.org/show_bug.cgi?id=46230 * Scripts/webkitpy/layout_tests/port/webkit.py: 2010-09-21 Dirk Pranke Unreviewed, build fix. Add missing import of 'tempfile'. * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-09-17 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: pull the list of tests from the Port, and make it possible to run with no actual test files in the filesystem. This set of changes allows us to delete the special webkitpy/layout_tests/data directory and test the generic code without touching the filesystem (except to write results). This speeds up test-webkitpy substantially. This also cleans up and removes several code paths in the generic code and fixes some minor bugs, notably in the test_expectations parsing, which was previously fragile if the tests weren't present. We also change the way we diff image results to be able to do so in memory, without relying on files. This slows down chromium test_shell, which always writes images to files, but should speed up DRT and ImageDiff-based implementations slightly. Note that pulling the list of tests to run from the Port will allow ports to specify what tests to run as an inclusive list; previously you could only do this as an exclusive list by using a test_expectations file or Skipped files; nothing actually uses this feature yet and it's unclear if it should be used. Note that there are no functional changes -- apart from now always printing out the location of the checksum file when we are tracing test runs -- and the total number of lines of non-test code actually drops by two. There is some more cleanup that can be done in the Port/Driver interface and in some handling of filenames, but I'll save that for another change. https://bugs.webkit.org/show_bug.cgi?id=45801 * Scripts/webkitpy/layout_tests/data/*: Removed. - no longer need special mock layout_tests_directory in the repository. * Scripts/webkitpy/layout_tests/layout_package/printing.py: - add code to display missing text files, checksums when tracing - update to not look at the filesystem directly. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: - add more unit tests * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: - remove tests_are_present flag - update with changes in Port interface - no longer access the filesystem directly, although we still use os.path for filename manipulation. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: - add more unit tests * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed. - renamed to port/test_files.py * Scripts/webkitpy/layout_tests/port/base.py: - change diff_image() to expect actual image data, not filenames - add expected_checksum(), expected_image(), expected_text() to return the content of the files so that we don't need a filesystem - add path_exists(), path_isdir() for filesystem-like access. - add test_dirs() to keep clobber-test-results from needing to actually look at a real layout tests dir - add tests() to return the list of tests to run on the port (calls port/test_files to do the work). - add update_baseline() to be able to save new baselines - add uri_to_test_name() from port/dryrun.py so we can easily check filename_to_uri() * Scripts/webkitpy/layout_tests/port/base_unittest.py: - add more unit tests * Scripts/webkitpy/layout_tests/port/chromium.py: - change diff_image() to accept image content, not filenames. This will be slower for test_shell/image_diff, but faster for DRT/ImageDiff. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: - add more unit tests * Scripts/webkitpy/layout_tests/port/dryrun.py: - simplify greatly * Scripts/webkitpy/layout_tests/port/port_testcase.py: - add more unit tests * Scripts/webkitpy/layout_tests/port/test.py: - massive rewrite to use in-script list of tests and expectations * Scripts/webkitpy/layout_tests/port/test_files.py: - rename from layout_package/test_files. * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: - add unit tests * Scripts/webkitpy/layout_tests/port/webkit.py: - update diff_image() to take image contents, not files. Should make things slightly faster. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: - update with changes to diff_image() * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: - update with changes to diff_image() * Scripts/webkitpy/layout_tests/run_webkit_tests.py: - remove tests_are_present from test_expectations - pull the list of tests from port.tests() instead of calling test_files.py directly. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: - update unit tests * Scripts/webkitpy/layout_tests/test_types/image_diff.py: - update with changes to * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: - update with change in Port interface * Scripts/webkitpy/layout_tests/test_types/text_diff.py: - update with change in Port interface * Scripts/webkitpy/style/checkers/test_expectations.py: - remove the tests_are_present flag 2010-09-21 Anders Carlsson Disable logging. * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2010-09-21 Tony Chang Reviewed by Kent Tamura. add a script for running webkit_unit_tests https://bugs.webkit.org/show_bug.cgi?id=46014 * Scripts/run-chromium-webkit-unit-tests: Added. 2010-09-21 Fridrich Strba Reviewed by Martin Robinson. Fix linking problems on Windows. https://bugs.webkit.org/show_bug.cgi?id=45844 * GNUmakefile.am: link the executables with winmm.dll 2010-09-21 Adam Barth Reviewed by Eric Seidel. feeder-queue svn updates more often than needed https://bugs.webkit.org/show_bug.cgi?id=46171 We don't need to poll SVN every time we feed the feeders. Rather, we can count on the wrapper shell script to auto-update the queue. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-21 Jocelyn Turcotte Reviewed by Andreas Kling. [Qt] Add robot loader timeout and extra time options. https://bugs.webkit.org/show_bug.cgi?id=46172 [-robot-timeout ]: Load the next page after s seconds if the current page didn't finish loading. [-robot-extra-time ]: Wait s seconds after the current page finished loading before loading the next one. This should allow some time for the page's JavaScript to execute. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::applyPrefs): * QtTestBrowser/main.cpp: (LauncherApplication::robotTimeout): (LauncherApplication::robotExtraTime): (LauncherApplication::LauncherApplication): (LauncherApplication::handleUserOptions): (main): * QtTestBrowser/urlloader.cpp: (UrlLoader::UrlLoader): (UrlLoader::loadNext): (UrlLoader::loadUrlList): * QtTestBrowser/urlloader.h: 2010-09-21 Pavel Podivilov Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-20 Philippe Normand Reviewed by Eric Carlson. [GTK] enhanced context menu for media elements https://bugs.webkit.org/show_bug.cgi?id=45021 EventSender::contextClick() now returns an array of js objects. Each object has a title property and a click() method. * DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback): 2010-09-20 Hayato Ito Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-20 Adam Barth Reviewed by Eric Seidel. The tool member variable should be called _tool https://bugs.webkit.org/show_bug.cgi?id=46160 Created by find-and-replace. * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/openbugs.py: * Scripts/webkitpy/tool/commands/queries.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/rebaseline.py: * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/multicommandtool.py: 2010-09-20 Adam Barth I ran the tests before landing but ignored the fact that they failed. :( * Scripts/webkitpy/tool/commands/queues.py: 2010-09-20 Adam Barth Reviewed by Eric Seidel. Add a feeder queue that polls bugs.webkit.org for the commit-cluster https://bugs.webkit.org/show_bug.cgi?id=46141 The feeder-queue polls bugs.webkit.org every 30 seconds and updates the list of work items on the status server. The individual commit-cluster nodes then grab the patches from the server and process them. * Scripts/webkitpy/tool/bot/feeders.py: Added. * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: 2010-09-20 Leandro Pereira Reviewed by Darin Adler. build-webkit: Add support for CMake build system https://bugs.webkit.org/show_bug.cgi?id=44979 * Scripts/build-webkit: Add "--efl" command-line option to build the EFL port of WebKit. * Scripts/webkitdirs.pm: Define buildCMakeProject() and buildEflCMakeProject() subroutines. 2010-09-20 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: refactor command line args getting passed to DRT This change cleans up some argument parsing between functions to get rid of some overlapping data structures. There should be no functional changes in this patch; it is pure refactoring in preparation for landing the Chrome GPU port and adding a generic way to pass args to DRT/TestShell. https://bugs.webkit.org/show_bug.cgi?id=46135 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: - pass the options argument explicitly to the threads and drivers, also consolidate the passing of options to the driver. - pass options directly to process_output() to remove a couple parameters (minor cleanup). * Scripts/webkitpy/layout_tests/port/base.py: - pass the options argument to Port.create_driver(). * Scripts/webkitpy/layout_tests/port/base_unittest.py: - update Port.create_driver() test * Scripts/webkitpy/layout_tests/port/chromium.py: - pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT. * Scripts/webkitpy/layout_tests/port/dryrun.py: - pass the options argument to Port.create_driver() * Scripts/webkitpy/layout_tests/port/test.py: - pass the options argument to Port.create_driver() * Scripts/webkitpy/layout_tests/port/webkit.py: - pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: - consolidate args in _get_dump_render_tree_args and rename to _get_test_args(); move all of the command-line args to the Port implementations. 2010-09-20 Andrew Wilson Revert change which was accidentally committed along with some expectation changes. * Scripts/webkitpy/layout_tests/port/base.py: 2010-09-20 Mihai Parparita Reviewed by Adam Barth. Add explicit --force-patch flag to webkitpy tools https://bugs.webkit.org/show_bug.cgi?id=46103 It wasn't obvious until I read the applypatch.py source code that --non-interfactive implies passing --force to patch. Add --force-patch as an alias to the flag, so that this behavior is more discoverable. * Scripts/webkitpy/tool/steps/applypatch.py: * Scripts/webkitpy/tool/steps/options.py: 2010-09-20 Eric Seidel Unreviewed, adding a line which got dropped and is trivially correct (and tested). commit-queue can't land patches https://bugs.webkit.org/show_bug.cgi?id=46138 Add a line of code I forgot in my last commit. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla_unittest.py: 2010-09-20 Adam Barth Reviewed by Eric Seidel. The commit-cluster bots still race to lock patch_ids https://bugs.webkit.org/show_bug.cgi?id=46130 It turns out we need to use a transaction object to make the read/modify/write lock operation atomic. From reading the AppEngine documentation, I think this patch should do what we want. It's hard to test locally because the test instance isn't distributed in the same way the production instance is. * QueueStatusServer/handlers/nextpatch.py: * QueueStatusServer/model/activeworkitems.py: Added. 2010-09-20 Andy Estes Reviewed by Adam Barth. REGRESSION (HTML5 Parser): Pages broken due to parsing changes https://bugs.webkit.org/show_bug.cgi?id=40961 Implement WebKitUsePreHTML5ParserQuirks preference. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks to false after a test finishes. 2010-09-20 Adam Roben Windows build fix * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so we'll pick up the most recent versions of the headers. 2010-09-20 Eric Seidel Reviewed by Adam Barth. commit-queue should check commit-queue+ again just before committing https://bugs.webkit.org/show_bug.cgi?id=32679 Added a _revalidate_patch check, right before landing. Since _revalidate_patch passes the patch_id from the work item back to bugzilla, I had to fix all of the previous queue tests to use valid attachment ids (that's the majority of this change). In order to validate that the bug was still open, I had to teach bugzilla.Bug about open/closed states. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-09-20 Mihai Parparita Unreviewed. Adding myself as a comitter. * Scripts/webkitpy/common/config/committers.py: 2010-09-20 Adam Barth Reviewed by Eric Seidel. Two instances of commit-queue try to process the same patch https://bugs.webkit.org/show_bug.cgi?id=46113 This patch makes next-patch atomic so that the server won't vend the same patch twice in the same hour. * QueueStatusServer/handlers/nextpatch.py: 2010-09-20 Adam Roben Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows We were previously trying to use a CFRunLoopTimer, but since Windows doesn't use CFRunLoop on most threads this doesn't work. Now we use a Windows-style timer on Windows. I also replaced all uses of "watchdog" with "watchdog timer". Fixes WebKitTestRunner's wait-to-dump watchdog timer doesn't work on Windows Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Updated for rename. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed platform-specific functions. (WTR::LayoutTestController::LayoutTestController): Added call to platformInitialize. (WTR::LayoutTestController::waitUntilDone): Changed to call initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work right in this function. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for rename. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new members needed to support the watchdog timer abstraction. Replaced some "watchdog"s with "watchdog timer". * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Added. (WTR::LayoutTestController::platformInitialize): Does nothing on this platform. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here from LayoutTestController.cpp and changed to use an early return. (WTR::waitUntilDoneWatchdogTimerFired): Moved here from LayoutTestController.cpp. (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): Moved code here from LayoutTestController::waitUntilDone and changed to use an early return. * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Added. (WTR::LayoutTestController::platformInitialize): Initialize our watchdog timer. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added. Kills and clears the watchdog timer. (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the LayoutTestController member function of the same name. (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded): Added. Sets up the timer if it isn't already set. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added LayoutTestControllerMac.mm. * WebKitTestRunner/win/InjectedBundle.vcproj: Added LayoutTestControllerWin.cpp. 2010-09-20 Martin Robinson Reviewed by Daniel Bates. [GTK] fast/forms/listbox-selection.html fails https://bugs.webkit.org/show_bug.cgi?id=45942 Use the gdkModifersFromJSValue helper to parse all appropriate modifier strings in keyDownCallback. * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the modifier parsing logic. 2010-09-19 Sam Weinig Reviewed by Anders Carlsson. WebKit2 decidePolicyForNavigationAction should include mouse button information https://bugs.webkit.org/show_bug.cgi?id=46060 * MiniBrowser/mac/BrowserWindowController.m: (decidePolicyForNavigationAction): (decidePolicyForNewWindowAction): 2010-09-19 Daniel Bates Reviewed by Martin Robinson. Add unit tests for diffs that delete or modify a change log entry or describe changes that are far apart https://bugs.webkit.org/show_bug.cgi?id=46046 Add additional unit tests to test change log diffs that contain deletions or changes that are far apart from each other in the ChangeLog file. * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: - Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)." 2010-09-19 Sam Weinig Reviewed by Anders Carlsson. Replace WKBundleRangeRef with WKBundleRangeHandleRef. https://bugs.webkit.org/show_bug.cgi?id=46054 The new one acts like WKBundleNodeHandleRef and allows for getting a wrapper in a specific world for the handle. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::propertyValue): (WTR::propertyValueDouble): (WTR::propertyValueInt): (WTR::numericWindowPropertyValue): (WTR::toStr): (WTR::InjectedBundlePage::shouldBeginEditing): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 2010-09-19 Kent Tamura Unreviewed. Fix WebGL test regressions by r67809. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled(). 2010-09-19 Kent Tamura Reviewed by Adam Barth. [DRT/Chromium] Fix a WebSettings handling bug https://bugs.webkit.org/show_bug.cgi?id=45945 Before this change, Chromium DRT reset WebSettings for every new window. It was wrong. If new window is not the first one, we have to apply the same settings as the first window. So, we introduce WebPreference to store the current settings, and apply it to new windows. It's same as test_shell's behavior. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView. * DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences): * DumpRenderTree/chromium/WebPreferences.cpp: Added. * DumpRenderTree/chromium/WebPreferences.h: Added. 2010-09-18 Prasad Tammana Reviewed by David Levin. update-webkit --chromium spitting out a spurious error https://bugs.webkit.org/show_bug.cgi?id=45868 * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient. 2010-09-18 Sam Weinig Reviewed by Dan Bernstein. Improve/unify the PageLoadClient interfaces https://bugs.webkit.org/show_bug.cgi?id=46043 * MiniBrowser/mac/BrowserWindowController.m: (didStartProvisionalLoadForFrame): (didReceiveServerRedirectForProvisionalLoadForFrame): (didFailProvisionalLoadWithErrorForFrame): (didCommitLoadForFrame): (didFinishDocumentLoadForFrame): (didFinishLoadForFrame): (didFailLoadWithErrorForFrame): (didReceiveTitleForFrame): (didFirstLayoutForFrame): (didFirstVisuallyNonEmptyLayoutForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didCommitLoadForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): (WTR::InjectedBundlePage::didReceiveTitleForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle): (WTR::TestController::didFinishLoadForFrame): * WebKitTestRunner/TestController.h: 2010-09-17 Eric Seidel Unreviewed. Adding a shell script I use to run the commit-queue. Now that multiple machines run the cq, it makes sense to share the script between them. * EWSTools/start-commit-queue.sh: Added. 2010-09-17 Brian Weinstein Reviewed by Jon Honeycutt. The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are slightly harder to read, so this reverts the previous background colors for various states, making it easier to read. * BuildSlaveSupport/build.webkit.org-config/public_html/default.css: (.success): (.failure): (.warnings): (.exception): (.start,.running,td.building): (.offline,td.offline): 2010-09-17 Sheriff Bot Unreviewed, rolling out r67692. http://trac.webkit.org/changeset/67692 https://bugs.webkit.org/show_bug.cgi?id=46011 broke layout test dashboard (Requested by johnny_g on #webkit). * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-09-17 Martin Robinson Reviewed by Oliver Hunt. Style bot complains about cairo forward declaration naming https://bugs.webkit.org/show_bug.cgi?id=45867 Exclude Cairo forward declarations from indentifiers with underscores checks. * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this. 2010-09-16 Kinuko Yasuda Reviewed by Ojan Vafai. Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests https://bugs.webkit.org/show_bug.cgi?id=45408 This change also tries to remove duplicated upload_results_json methods in run_webkit_tests.py and json_results_generator.py. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-09-16 Antonio Gomes Reviewed by Andreas Kling. [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set. Recently r67554 changed the way different views use the WebPage class: it was previously being shared between different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking all page specific stuff to the UI. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): * QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage): * QtTestBrowser/mainwindow.h: 2010-09-12 Antonio Gomes Reviewed by Andreas Kling. Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method. This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView object will move to the qgraphicsscene instead of the qgraphicsview. * QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip): * QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode): 2010-09-12 Antonio Gomes Reviewed by Andreas Kling. Moved setYRotation method body out of the class (WebViewGraphicsBased) definition. We usually separate methods whose body are larger than a few lines from the class definition. * QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation): 2010-09-12 Antonio Gomes Reviewed by Andreas Kling. Make initializeView method of LauncherWindow private. No one else needs to be able to call it but LauncherWindow. Also moving the declation of isGraphicsBased method down in the same file, in order to better group related methods. * QtTestBrowser/launcherwindow.h: 2010-09-12 Antonio Gomes Reviewed by Andreas Kling. Make the getter 'page' method of MainWindow const. * QtTestBrowser/mainwindow.cpp: (MainWindow::page): * QtTestBrowser/mainwindow.h: 2010-09-12 Antonio Gomes Reviewed by Andreas Kling. Remove useless parameter from MainWindow class' constructor. The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also not referred in the constructor body and does not make much sense. * QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): * QtTestBrowser/mainwindow.h: 2010-09-15 Tony Chang Reviewed by Kent Tamura. [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations https://bugs.webkit.org/show_bug.cgi?id=42151 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource): 2010-09-16 Adrienne Walker Reviewed by Kenneth Russell. Add script to synchronize WebKit and Khronos WebGL tests https://bugs.webkit.org/show_bug.cgi?id=42336 * Scripts/update-webgl-conformance-tests: Added. * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added. * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added. 2010-09-16 Sam Weinig Reviewed by Anders Carlsson. Add support for sending synchronous messages from the InjectedBundle to the WKContext https://bugs.webkit.org/show_bug.cgi?id=44785 * MiniBrowser/mac/AppDelegate.m: (didReceiveSynchronousMessageFromInjectedBundle): (-[BrowserAppDelegate init]): * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2010-09-16 Leonid Ebril Reviewed by Andreas Kling. [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform. https://bugs.webkit.org/show_bug.cgi?id=45885 Avoid creation of an additional window for screenshot to prevent overlapping with original window. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot): 2010-09-16 Anders Carlsson Fix clang++ build. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController zoomIn:]): (-[BrowserWindowController zoomOut:]): (-[BrowserWindowController resetZoom:]): Remove trailing semicolons. 2010-09-16 Sheriff Bot Unreviewed, rolling out r67628. http://trac.webkit.org/changeset/67628 https://bugs.webkit.org/show_bug.cgi?id=45904 broke the build (Requested by eric_carlson on #webkit). * DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): 2010-09-16 Balazs Kelemen Unreviewed. Adding myself as a comitter. * Scripts/webkitpy/common/config/committers.py: 2010-09-15 Philippe Normand Reviewed by Eric Carlson. [GTK] enhanced context menu for media elements https://bugs.webkit.org/show_bug.cgi?id=45021 EventSender::contextClick() now returns an array of js objects. Each object has a title property and a click() method. * DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback): 2010-09-14 Philippe Normand Reviewed by Eric Carlson and Martin Robinson. [GTK] eventSender.contextClick() should return the contents of the context menu https://bugs.webkit.org/show_bug.cgi?id=39102 Make the eventSender use the new private WebKitGtk+ API to retrieve the context-menu item titles and store them in an array. * DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): 2010-09-16 Eric Uhrhane Reviewed by Jian Li. Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM. https://bugs.webkit.org/show_bug.cgi?id=45798 * Scripts/build-webkit: 2010-09-16 Robert Hogan Reviewed by Antonio Gomes. [Qt] Support globalhistory tests https://bugs.webkit.org/show_bug.cgi?id=45774 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isGlobalHistoryTest): (WebCore::DumpRenderTree::open): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpHistoryCallbacks): (LayoutTestController::removeAllVisitedLinks): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-09-10 Tony Chang Reviewed by Eric Seidel. deduplicate-tests should be runnable from any WebKit directory https://bugs.webkit.org/show_bug.cgi?id=44709 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-15 Tony Chang Reviewed by Kent Tamura. [chromium] sort testing methods in DRT https://bugs.webkit.org/show_bug.cgi?id=45850 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): 2010-09-15 Mihai Parparita Reviewed by Adam Barth. CQ status shows items out of order https://bugs.webkit.org/show_bug.cgi?id=45846 Only group consecutive status items with the same patch ID into the same group, so that overall item ordering is preserved. Also don't indent status items that only have a single item in their group. * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/templates/includes/singlequeuestatus.html: Added. * QueueStatusServer/templates/queuestatus.html: 2010-09-15 Eric Seidel Reviewed by Adam Barth. Add queue start/stop messages https://bugs.webkit.org/show_bug.cgi?id=45853 I ended up needing to clean up a bunch of our unit testing in order to test this new code path nicely. There are also a few PEP8 changes needed to pass check-webkit-style. * Scripts/webkitpy/tool/bot/queueengine.py: * Scripts/webkitpy/tool/bot/queueengine_unittest.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: 2010-09-15 Simon Fraser https://bugs.webkit.org/show_bug.cgi?id=45849 WKURLCreateWithCFURL crashes with null url Fix MiniBrowser crash when the url is not parseable. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]): 2010-09-15 Patrick Gansterer Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-14 Eric Seidel Reviewed by Adam Barth. Make it possible to run more than one commit-queue instance https://bugs.webkit.org/show_bug.cgi?id=45786 Mostly we need to make sure the two (or more) instances get different patches to work on. To do this, I re-worked the code responsible for getting the next work item to round trip through the status server. The status server only vends patches from the work items list, only if those patches have not had status reported for them in the last hour. This is another step towards making all queues go through the status server, thus making it possible to run more than one instance of various EWS bots (as requested in bug 44292). The webkitpy changes are already covered by existing unit tests. The QueueStatusSever sadly has no testing infrastructure yet. :( * QueueStatusServer/handlers/nextpatch.py: Added. * QueueStatusServer/index.yaml: * QueueStatusServer/main.py: * Scripts/webkitpy/tool/commands/queues.py: 2010-09-15 Mihai Parparita Reviewed by Tony Chang. NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html https://bugs.webkit.org/show_bug.cgi?id=45791 Force filenames to be raw bytes before running difflib.unified_diff. * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2010-09-15 Simon Hausmann Reviewed by Tor Arne Vestbø. [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled https://bugs.webkit.org/show_bug.cgi?id=35247 The main issue when changing the views is that the plugins and any other components that depend on view specific attributes such as the native window id are not teared down. Even if we had a tear-down procedure, we'd have to re-initialize the plugin after switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so we decided to work around this in QtTestBrowser by making toggling between QWebView and QGraphicsWebView also re-create the page. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): * QtTestBrowser/mainwindow.h: 2010-09-14 Mihai Parparita Reviewed by Adam Barth. Send webkit accessibility notifications to Chromium https://bugs.webkit.org/show_bug.cgi?id=45156 Move printf inside shouldDumpAccessibilityNotifications check. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): 2010-09-14 Tony Chang Reviewed by Kent Tamura. [chromium] fix http/tests/security/local-user-CSS-from-remote.html https://bugs.webkit.org/show_bug.cgi?id=45788 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome 2010-09-14 Tony Chang Reviewed by Ojan Vafai. [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed https://bugs.webkit.org/show_bug.cgi?id=45768 * DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward. 2010-09-14 Kevin Ollivier [wx] Build fix, add newly added directories to the directory list. * wx/build/settings.py: 2010-09-14 Sam Weinig Reviewed by Anders Carlsson. Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef. https://bugs.webkit.org/show_bug.cgi?id=45785 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::propertyValue): (WTR::numericWindowPropertyValue): (WTR::dumpPath): (WTR::toStr): (WTR::operator<<): (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldBeginEditing): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 2010-09-14 Adam Barth Fix two typos in commit-queue. The first is harmless. The second causes the queue to reject patches when the build is broken. :( * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-14 Chris Guillory Reviewed by Chris Fleizach. Send all accessibility notifications to Chromium. https://bugs.webkit.org/show_bug.cgi?id=45156 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): * DumpRenderTree/chromium/WebViewHost.h: 2010-09-14 Adam Barth Reviewed by Eric Seidel. commit-queue is slow during the day https://bugs.webkit.org/show_bug.cgi?id=45780 Thanks to the new logging, we've noticed that checkout-is-out-of-date errors in the first pass of landing don't retry the land. Instead, they're treated as failures and cause the commit-queue to do two more builds before really trying to land the patch. Worse, in the second build, we can get bitten by a flaky test. This patch takes a slightly different approach to the commit-queue's main control logic. We now use a separate subprocess for building and testing and for landing. This means we should very rarely see the checkout-is-out-of-date error, and when we do see it, we should retry more quickly. If my understanding is correct, this should be a big speed win for the commit-queue. * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-14 Tony Chang Reviewed by Dimitri Glazkov. [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme https://bugs.webkit.org/show_bug.cgi?id=45762 * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): * DumpRenderTree/chromium/LayoutTestController.h: 2010-09-14 Csaba Osztrogonác Adding myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: 2010-09-14 Zoltan Horvath Reviewed by Kenneth Rohde Christiansen. [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist https://bugs.webkit.org/show_bug.cgi?id=45736 Build-webkit has showed a warning when WebKitBuild didn't exist, add an additional condition to avoid it. * Scripts/build-webkit: 2010-09-13 Eric Seidel Reviewed by Adam Barth. commit-queue should log when it's retrying due to checkout out of date error https://bugs.webkit.org/show_bug.cgi?id=45725 This will allow us to better track how often we see these errors and how long it takes the queue to recover from them. In order to pass the tests, I had to correct an error from a previous change. The UnitTestPort should not have ever been using the base port method as that will read a file from disk. If the unit tests haven't passed the contents it should raise an IOError as though the file doesn't exist. * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-09-13 Mihai Parparita Reviewed by Adam Barth. Upload results when cq patch landing fails https://bugs.webkit.org/show_bug.cgi?id=45683 Include script errors when CommitQueue._land fails. * Scripts/webkitpy/tool/commands/queues.py: 2010-09-13 Chris Fleizach Reviewed by David Kilzer. AX: accessibilityIsIgnored is returning nil when return value expects a BOOL https://bugs.webkit.org/show_bug.cgi?id=45548 * DumpRenderTree/AccessibilityUIElement.cpp: (isIgnoredCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isIgnored): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isIgnored): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isIgnored): 2010-09-13 Csaba Osztrogonác Reviewed by Andreas Kling. jscPath() is incorrect in Windows' cmd.exe shell https://bugs.webkit.org/show_bug.cgi?id=45651 * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows. 2010-09-13 Chris Fleizach Reviewed by Darin Adler. REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject https://bugs.webkit.org/show_bug.cgi?id=43807 * DumpRenderTree/AccessibilityUIElement.cpp: (textMarkerForPointCallback): (AccessibilityUIElement::textMarkerForPoint): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::textMarkerForPoint): 2010-09-13 Andreas Kling Reviewed by Kenneth Rohde Christiansen. [Qt] build-webkit: Add --v8 option to build against V8 Note that V8 is picked up from QtScript, so this currently requires building against the experimental qt-script-v8 branch. * Scripts/build-webkit: 2010-09-13 Hans Wennborg Reviewed by Jeremy Orlow. Add WebDeviceOrientationClientMock::create() and use it from DRT. https://bugs.webkit.org/show_bug.cgi?id=45650 Do not use the WebDeviceOrientationClientMock constructor directly, but use the create() member function. This should fix the linker errors for the multi-DLL Chromium DRT build. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient): 2010-08-27 Kenneth Rohde Christiansen Reviewed by Antti Koivisto. Add support for testing the viewport meta tag algorithm, based on the following draft spec: http://people.opera.com/rune/TR/ED-css-viewport-20100806/ Add common handling of viewport meta tag based on new Opera spec https://bugs.webkit.org/show_bug.cgi?id=44201 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-09-12 Kent Tamura Reviewed by Tony Chang. [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h https://bugs.webkit.org/show_bug.cgi?id=45517 Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h * DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): (Image::createFromFilename): (diffImages): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): 2010-09-10 MORITA Hajime Reviewed by Tony Chang. [Chromium] Implement textInputController.hasSpellingMarker() for Chromium https://bugs.webkit.org/show_bug.cgi?id=45441 Added TextInputController::hasSpellingMarker(). * DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::hasSpellingMarker): * DumpRenderTree/chromium/TextInputController.h: 2010-09-12 Dirk Pranke Unreviewed, build fix. My last change accidentally contained a local change to the rebaselinig script; webkit-patch land picked it up without telling me and committed it :( * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-09-11 Maciej Stachowiak Reviewed by Anders Carlsson. Attempt to fix Windows MiniBrowser build (untested) https://bugs.webkit.org/show_bug.cgi?id=45609 * MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt): 2010-09-11 Sam Weinig Reviewed by Maciej Stachowiak. Fix zoom related tests when testing WebKit2. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same. 2010-09-11 Sam Weinig Reviewed by Dan Bernstein. Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:] https://bugs.webkit.org/show_bug.cgi?id=45605 * MiniBrowser/mac/BrowserWindowController.m: (setStatusText): (contentsSizeChanged): (-[BrowserWindowController awakeFromNib]): * MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt): (setStatusText): (contentsSizeChanged): (BrowserView::create): * WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize): 2010-09-11 Sam Weinig Reviewed by Dan Bernstein. Add callback mechanism for the getting the source of a frame https://bugs.webkit.org/show_bug.cgi?id=45604 Add ability to dump the main frame's source to the console. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController dumpSourceToConsole:]): * MiniBrowser/mac/MainMenu.xib: 2010-09-11 Eric Seidel Reviewed by Adam Barth. Remove unneeded Empty Queue messages https://bugs.webkit.org/show_bug.cgi?id=45602 We already have a /gc job to delete these. recentstatus.py is already smart enough to use the most recent of the workitems last update or the most recent status, so removing these should not change the _last_status_date() return value more than a few milliseconds. These messages just spam the recent status log. * Scripts/webkitpy/tool/commands/queues.py: 2010-09-11 Mihai Parparita Reviewed by Adam Barth. Fix Python exception when generating synthetic patch IDs https://bugs.webkit.org/show_bug.cgi?id=45592 Can't concatenate strings and numbers directly. * QueueStatusServer/handlers/queuestatus.py: 2010-09-11 Mihai Parparita Reviewed by Adam Barth. Group statuses in queue status by patch ID https://bugs.webkit.org/show_bug.cgi?id=45588 Group statuses by patch ID so that the status page is easier to scan. * QueueStatusServer/handlers/queuestatus.py: * QueueStatusServer/stylesheets/dashboard.css: (.status-group): (.status-bug): (.status-group ul): (.status-group ul li): (.status-group ul li:hover): (.status-cell): (.status-cell:hover): (.status-cell.pass): (.status-cell.fail): (.status-cell.pending): (.status-cell.error): * QueueStatusServer/templates/dashboard.html: * QueueStatusServer/templates/queuestatus.html: 2010-09-11 Mihai Parparita Reviewed by Tony Chang. Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT https://bugs.webkit.org/show_bug.cgi?id=45479 Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after implementation in ResourceLoadDelegate in the Mac port). * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes): * DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse): 2010-09-11 Eric Seidel Reviewed by Adam Barth. queues.webkit.org should expose /remote_api for data upload/download https://bugs.webkit.org/show_bug.cgi?id=45559 * QueueStatusServer/app.yaml: - /remote_api is a standard app-engine service which allows use of the bulk uploader for data upload/download. Exposing this (for admin access only) allows us to use 2010-09-10 Sam Weinig Reviewed by Dan Bernstein. Add zoom support to WebKit2 API https://bugs.webkit.org/show_bug.cgi?id=45585 - Add zoom options to MiniBrowser that mimic Safari's options using the new WebKit2 zoom APIs. - Switch uses of float for the zoom APIs to use double. * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController initWithPageNamespace:]): (-[BrowserWindowController validateMenuItem:]): (-[BrowserWindowController validateUserInterfaceItem:]): (-[BrowserWindowController currentZoomFactor]): (-[BrowserWindowController setCurrentZoomFactor:]): (-[BrowserWindowController canZoomIn]): (-[BrowserWindowController zoomIn:]): (-[BrowserWindowController canZoomOut]): (-[BrowserWindowController zoomOut:]): (-[BrowserWindowController canResetZoom]): (-[BrowserWindowController resetZoom:]): (-[BrowserWindowController toggleZoomMode:]): * MiniBrowser/mac/MainMenu.xib: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::textZoomIn): (WTR::EventSendingController::textZoomOut): (WTR::EventSendingController::zoomPageIn): (WTR::EventSendingController::zoomPageOut): 2010-09-10 Robert Hogan Reviewed by Andreas Kling. [Qt] Fix crash in DRT in standalone mode https://bugs.webkit.org/show_bug.cgi?id=45454 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::loadNextTestInStandAloneMode): 2010-09-10 Sam Weinig Reviewed by Darin Adler. Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. Precursor to https://bugs.webkit.org/show_bug.cgi?id=45522 Update for changes to the Bundle API to allow separate control of page and text zoom levels. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::textZoomIn): (WTR::EventSendingController::textZoomOut): (WTR::EventSendingController::zoomPageIn): (WTR::EventSendingController::zoomPageOut): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset): 2010-09-10 Yael Aharon Reviewed by Andreas Kling. [Qt] Support click event for notifications https://bugs.webkit.org/show_bug.cgi?id=44836 Add support for simulateDesktopNotificationClick by calling back to DumpRenderTreeSupportQt.cpp. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::simulateDesktopNotificationClick): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-09-10 Mihai Parparita Reviewed by Eric Seidel. Update queue status when patches fail their first land attempt https://bugs.webkit.org/show_bug.cgi?id=45583 Add a few more _update_status calls to make it more obvious if a patch is being retried because tests failed. * Scripts/webkitpy/tool/commands/queues.py: 2010-09-10 Balazs Kelemen Reviewed by Andreas Kling. [Qt] MiniBrowser crashes with multiply windows when closing one of them https://bugs.webkit.org/show_bug.cgi?id=45536 * MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Reference the context instead of adopting it because it can be shared across different views. 2010-09-10 Tony Chang Unreviewed, rolling out r67241. http://trac.webkit.org/changeset/67241 https://bugs.webkit.org/show_bug.cgi?id=44709 Accidentally committed. * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-10 Tony Chang Reviewed by Ojan Vafai. deduplicate-tests should be runnable from any WebKit directory https://bugs.webkit.org/show_bug.cgi?id=44709 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-10 Tony Chang Unreviewed, rolling out r67216. http://trac.webkit.org/changeset/67216 https://bugs.webkit.org/show_bug.cgi?id=44709 Broke * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-10 Tony Chang Reviewed by Ojan Vafai. deduplicate-tests should be runnable from any WebKit directory https://bugs.webkit.org/show_bug.cgi?id=44709 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-09 Hans Wennborg Reviewed by Jeremy Orlow. Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree. https://bugs.webkit.org/show_bug.cgi?id=45460 This enables DumpRenderTree to run layout tests for DeviceOrientation. Also declare the LayoutTestController destructor out-of-line. Otherwise the implicit destructor would cause compiler errors because of the OwnPtr member. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::~LayoutTestController): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClient): * DumpRenderTree/chromium/WebViewHost.h: 2010-09-09 Sheriff Bot Unreviewed, rolling out r67119. http://trac.webkit.org/changeset/67119 https://bugs.webkit.org/show_bug.cgi?id=45505 Extra newlines in results (Requested by tony^work on #webkit). * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TestShell.h: * DumpRenderTree/chromium/WebViewHost.cpp: (printResponseDescription): (printNodeDescription): (printRangeDescription): (WebViewHost::shouldBeginEditing): (WebViewHost::shouldEndEditing): (WebViewHost::shouldInsertNode): (WebViewHost::shouldChangeSelectedRange): (WebViewHost::shouldDeleteRange): (WebViewHost::shouldApplyStyle): (WebViewHost::didBeginEditing): (WebViewHost::didChangeSelection): (WebViewHost::didChangeContents): (WebViewHost::didEndEditing): (WebViewHost::decidePolicyForNavigation): (WebViewHost::didCancelClientRedirect): (WebViewHost::didStartProvisionalLoad): (WebViewHost::didReceiveServerRedirectForProvisionalLoad): (WebViewHost::didFailProvisionalLoad): (WebViewHost::didCommitProvisionalLoad): (WebViewHost::didFinishDocumentLoad): (WebViewHost::didHandleOnloadEvents): (WebViewHost::didFailLoad): (WebViewHost::didFinishLoad): (WebViewHost::didChangeLocationWithinPage): (WebViewHost::willSendRequest): (WebViewHost::didReceiveResponse): (WebViewHost::didFinishResourceLoad): (WebViewHost::didFailResourceLoad): (WebViewHost::didDisplayInsecureContent): (WebViewHost::didRunInsecureContent): (WebViewHost::printFrameDescription): 2010-09-09 Michael Saboff Unreviewed, adding myself to committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-09 Mihai Parparita Reviewed by Tony Chang. Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT https://bugs.webkit.org/show_bug.cgi?id=45479 Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after implementation in ResourceLoadDelegate in the Mac port). * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes): * DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse): 2010-09-09 Mihai Parparita Reviewed by Daniel Bates. svn-apply tries to delete directories it shouldn't https://bugs.webkit.org/show_bug.cgi?id=45424 isDirectoryEmptyForRemoval had the wrong check. If an item in the directory is itself a directory, then the directory is definitely not empty. * Scripts/svn-apply: 2010-09-09 Chris Fleizach Fixing GTK and windows build failure. AX: Support AccessibilityTextMarkers in DRT https://bugs.webkit.org/show_bug.cgi?id=44778 * DumpRenderTree/AccessibilityTextMarker.h: (AccessibilityTextMarker::platformTextMarker): (AccessibilityTextMarkerRange::platformTextMarkerRange): * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: (AccessibilityTextMarker::platformTextMarker): (AccessibilityTextMarkerRange::platformTextMarkerRange): 2010-09-09 Chris Fleizach Reviewed by David Kilzer. AX: Support AccessibilityTextMarkers in DRT https://bugs.webkit.org/show_bug.cgi?id=44778 Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers that WebCore uses when vending information about its VisiblePositions through AX. There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic methods for encapsulating and checking equality. This will allow future bug fixes in the text marker system to be adequately tested. * DumpRenderTree/AccessibilityTextMarker.cpp: Added. (toTextMarker): (isMarkerEqualCallback): (markerFinalize): (AccessibilityTextMarker::makeJSAccessibilityTextMarker): (AccessibilityTextMarker::getJSClass): (toTextMarkerRange): (isMarkerRangeEqualCallback): (markerRangeFinalize): (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::getJSClass): * DumpRenderTree/AccessibilityTextMarker.h: Added. (AccessibilityTextMarker::platformTextMarker): (AccessibilityTextMarkerRange::platformTextMarkerRange): (AccessibilityTextMarker::AccessibilityTextMarker): (AccessibilityTextMarker::~AccessibilityTextMarker): (AccessibilityTextMarker::isEqual): (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::isEqual): * DumpRenderTree/AccessibilityUIElement.cpp: (textMarkerRangeForElementCallback): (textMarkerRangeLengthCallback): (textMarkerRangeForMarkersCallback): (startTextMarkerForTextMarkerRangeCallback): (endTextMarkerForTextMarkerRangeCallback): (accessibilityElementForTextMarkerCallback): (AccessibilityUIElement::textMarkerRangeForElement): (AccessibilityUIElement::textMarkerRangeLength): (AccessibilityUIElement::startTextMarkerForTextMarkerRange): (AccessibilityUIElement::endTextMarkerForTextMarkerRange): (AccessibilityUIElement::accessibilityElementForTextMarker): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added. (AccessibilityTextMarker::AccessibilityTextMarker): (AccessibilityTextMarker::~AccessibilityTextMarker): (AccessibilityTextMarker::isEqual): (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange): (AccessibilityTextMarkerRange::isEqual): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::textMarkerRangeForElement): (AccessibilityUIElement::textMarkerRangeLength): (AccessibilityUIElement::textMarkerRangeForMarkers): (AccessibilityUIElement::startTextMarkerForTextMarkerRange): (AccessibilityUIElement::endTextMarkerForTextMarkerRange): (AccessibilityUIElement::accessibilityElementForTextMarker): * DumpRenderTree/win/DumpRenderTree.vcproj: 2010-08-25 Tony Chang Reviewed by Ojan Vafai. don't delete duplicates needed because of intermediate results https://bugs.webkit.org/show_bug.cgi?id=44653 Also, output the full path so we can pipe the output to rm. * Scripts/webkitpy/layout_tests/deduplicate_tests.py: * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 2010-09-09 Balazs Kelemen Reviewed by Andreas Kling. [Qt] MiniBrowser does not starts properly https://bugs.webkit.org/show_bug.cgi?id=45459 Do not try set up the first window by calling newWindow on a newly created BrowserWindow since it creates a new object. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): * MiniBrowser/qt/main.cpp: (main): 2010-09-09 Martin Robinson Reviewed by Xan Lopez. [GTK] Get ImageDiff building on Win32 https://bugs.webkit.org/show_bug.cgi?id=45353 * DumpRenderTree/gtk/ImageDiff.cpp: (main): Switch from using strtok to g_strsplit. 2010-09-09 Zoltan Horvath Reviewed by Andreas Kling. [Qt] Modify load method of MiniBrowser's BrowserView class https://bugs.webkit.org/show_bug.cgi?id=45442 Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK. * MiniBrowser/qt/BrowserView.cpp: (BrowserView::load): * MiniBrowser/qt/BrowserView.h: * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::load): 2010-09-09 Tony Chang Reviewed by Ojan Vafai. fix show_results in new-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=45413 * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-09-08 Victor Wang Reviewed by Ojan Vafai. [Chromium] Fix test results server to make sure it does not have corrupted data. results.json file size coulbe be >1M and we split the data into multiple data store entries in this case. This patch fixes the issue that the data may be corrupted if data store error happens in the middle of saving multiple entries. https://bugs.webkit.org/show_bug.cgi?id=45063 * TestResultServer/model/datastorefile.py: 2010-09-08 Peter Varga Reviewed by Kenneth Rohde Christiansen. Fix ignoring return value warning in case of gcc 4.4.4 https://bugs.webkit.org/show_bug.cgi?id=45384 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testPostURLFile): If fwrite have written zero byte then the testPostURLFile function returns with false as tempFile can't be opened. * DumpRenderTree/qt/ImageDiff.cpp: (main): Put fwrite function into an if condition without body to avoid warning. It is safe because this function writes to the stdout. 2010-09-08 Satish Sampath Unreviewed, adding myself to committers list. * Scripts/webkitpy/common/config/committers.py: 2010-09-08 Hans Wennborg Unreviewed. Adding myself as a committer in committers.py. * Scripts/webkitpy/common/config/committers.py: 2010-09-08 Zoltan Horvath Reviewed by Simon Hausmann. [Qt] Refactor MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=45173 Split BrowserWindow into two source files and headers. Remove unnecessary header includes. * MiniBrowser/qt/BrowserView.cpp: Added. (createNewPage): (BrowserView::BrowserView): (BrowserView::resizeEvent): (BrowserView::load): (BrowserView::view): * MiniBrowser/qt/BrowserView.h: Added. (BrowserView::~BrowserView): * MiniBrowser/qt/BrowserWindow.cpp: * MiniBrowser/qt/BrowserWindow.h: * MiniBrowser/qt/MiniBrowser.pro: 2010-09-08 Adam Barth Rubber-stamped by Eric Seidel. Rename DocLoader to CachedResourceLoader because that's what it does. * Scripts/do-webcore-rename: 2010-09-07 Kinuko Yasuda Reviewed by Ojan Vafai. Enable incremental results.json generation for non-layout tests. https://bugs.webkit.org/show_bug.cgi?id=45315 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading. * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too. 2010-09-07 Dirk Pranke Unreviewed, build fix Missed one test in mac_unittest.py in previous change; for some reason the method is listed twice. I will fix both for now, but will figure this out in a later, not-time-sensitive patch. https://bugs.webkit.org/show_bug.cgi?id=45357 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2010-09-07 Kent Tamura Reviewed by Tony Chang. test-webkitpy: Fix load error of webkitpy/layout_tests/port/factory_unittest.py on Win32 Python https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short * Scripts/webkitpy/layout_tests/port/server_process.py: Avoid to import fcntl on win32. Win32 Python doesn't have fcntl and we don't use server_process.py on Win32 Python. However unittest.py tries to load everything in a module. 2010-09-07 Dirk Pranke Reviewed by Kent Tamura. Fix regression introduced in previous change to new-run-webkit-tests (bug 45090) to not try to run unittests for the Mac implementation of the Port interface if we aren't running on a Mac. Also fix the overrides implementation mock in the chromium unittests to fix the case where there are overrides checked in that cause problems. https://bugs.webkit.org/show_bug.cgi?id=45357 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/port_testcase.py: 2010-09-01 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: still more unit tests Clean up and remove unnecessary code. Biggest notable change is moving the chromium-specific imagediff code from port/base to port/chromium. Add more unit tests for run_webkit_tests.py, port/base.py, port/factory.py, port/dryrun.py, and layout_package/dump_render_tree_thread.py This covers almost all of the generic and test code paths except for a few error paths involving invalid or port-specific command line arguments, and the code path for uploading results files to the buildbots. https://bugs.webkit.org/show_bug.cgi?id=45090 * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added. * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt. * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html. * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added. * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/dryrun.py: * Scripts/webkitpy/layout_tests/port/factory_unittest.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added. * Scripts/webkitpy/layout_tests/port/server_process.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 2010-09-07 Joseph Pecoraro Reviewed by Darin Adler. Provide a way to trigger a UI implementation for Windows https://bugs.webkit.org/show_bug.cgi?id=42259 * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: (WebThemeEngineDRT::paintSpinButton): Added. Check state consistency and use existing arrow painting code. * DumpRenderTree/chromium/WebThemeEngineDRT.h: 2010-07-16 Alice Liu Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=42430 Make WebKitTestRunner on Windows actually load and run a test * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize. (WKBundleInitialize): * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added. Output is a dll. * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows (WTR::createWKURL): * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match other existing checks, and avoid including Platform.h * WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::registerWindowClass): Added. (WTR::PlatformWebView::PlatformWebView): Implemented. (WTR::PlatformWebView::~PlatformWebView): Implemented. (WTR::PlatformWebView::page): Implemented. * WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build configuration specific path to InjectedBundle.dll. * WebKitTestRunner/win/TestInvocationWin.cpp: (WTR::TestInvocation::runUntil): Implemented. * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project. * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies. 2010-07-16 Brady Eidson Reviewed by Sam Weinig. Make revalidation of back/forward work a little better with page loads https://bugs.webkit.org/show_bug.cgi?id=42470 * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController validateToolbar]): (_didStartProvisionalLoadForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): 2010-07-16 Nikolas Zimmermann Reviewed by Dirk Schulze. Add possibility to dumpAsText and generate a pixel test result https://bugs.webkit.org/show_bug.cgi?id=42374 Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode. setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests. This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result. At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test. Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled. (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything) * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsTextAndPixelsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::setDumpAsTextAndPixels): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::reset): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::shouldDumpAsTextAndPixels): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump): * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): * DumpRenderTree/mac/DumpRenderTree.mm: (dump): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump): * DumpRenderTree/win/DumpRenderTree.cpp: (dump): * DumpRenderTree/wx/DumpRenderTreeWx.cpp: (dump): 2010-07-16 Kent Hansen Unreviewed. Adding myself as committer. * Scripts/webkitpy/common/config/committers.py: 2010-07-16 Shinichiro Hamaji Another uneviewed attempt to fix build. Printing test results differ between machines, we should use ImageDiff instead https://bugs.webkit.org/show_bug.cgi?id=20011 * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext): 2010-07-16 Shinichiro Hamaji Unreviewed tiger build fix. Printing test results differ between machines, we should use ImageDiff instead https://bugs.webkit.org/show_bug.cgi?id=20011 * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): (createBitmapContextFromWebView): 2010-07-15 Shinichiro Hamaji Unreviewed build fix. Printing test results differ between machines, we should use ImageDiff instead https://bugs.webkit.org/show_bug.cgi?id=20011 * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): 2010-07-15 Shinichiro Hamaji Reviewed by Darin Adler. Printing test results differ between machines, we should use ImageDiff instead https://bugs.webkit.org/show_bug.cgi?id=20011 * DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected): * DumpRenderTree/PixelDumpSupport.h: * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): This function was added to share bitmap context creation code. (createBitmapContextFromWebView): (createPagedBitmapContext): 2010-07-15 Yuta Kitamura Reviewed by Kent Tamura. Pull in pywebsocket-0.5.1 https://bugs.webkit.org/show_bug.cgi?id=42353 pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test in Chromium. There is no other functional change. (*) http://code.google.com/p/pywebsocket/source/detail?r=265 * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1. 2010-07-15 Brady Eidson Reviewed by Sam Weinig. Add toolbar and toolbar item validation for MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=42422 * MiniBrowser/MBToolbarItem.h: Added. * MiniBrowser/MBToolbarItem.m: Added. (-[MBToolbarItem validate]): * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController validateUserInterfaceItem:]): * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/BrowserWindow.xib: 2010-07-15 Victor Wang Unreviewed, add victorw irc nickname to committer list. * Scripts/webkitpy/common/config/committers.py: 2010-07-15 Adam Roben Make killing Apache more reliable (on both Mac and Windows) We previously had two ways of determining whether we had succeeded in killing Apache: 1) checking the return value of kill(0, $apachePID) 2) checking whether Apache's PID file still exists On Cygwin, Apache doesn't always delete its PID file when it exits, making (2) unreliable. We unfortunately misdiagnosed this as an impotency of Perl's kill function, which led to r63177 and r63355. Now that we know that the real problem is that Apache doesn't always delete its PID file on Windows, we can make a much better fix: always use method (1) to determine whether we've killed Apache. Fixes Killing Apache is unreliable, leading to regression test failures (and general annoyance). Reviewed by Anders Carlsson. * Scripts/webkitperl/httpd.pm: (openHTTPD): Moved killing code from here to killHTTPD. Added a call to delete the PID file in case Apache doesn't do this itself when killed. Our later logic relies on the PID file being deleted after this point. (closeHTTPD): Removed killing logic and changed to just call killHTTPD instead. killHTTPD's logic is a bit different from the logic we had here, for the reasons stated above. (killHTTPD): Added. Code came from openHTTPD. (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C! On Mac, don't try to kill Apache when we receive a signal, as Apache will already have been killed by this point (though for some reason this isn't detected by our killing logic in killHTTPD). On Cygwin, we still need to kill Apache manually. 2010-07-15 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=42399 Update MiniBrowser for WKFrameNavigationType * MiniBrowser/mac/BrowserWindowController.m: (_decidePolicyForNavigationAction): (_decidePolicyForNewWindowAction): 2010-07-15 Stephanie Lewis Reviewed by Geoff Garen. http://bugs.webkit.org/show_bug.cgi?id=42406 Make SunSpider work better with roots. * Scripts/sunspider-compare-results: fix argument bug * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level. 2010-07-15 Brady Eidson Reviewed by Sam Weinig. Hook up back/forward in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=42397 * MiniBrowser/mac/BrowserWindow.xib: * MiniBrowser/mac/BrowserWindowController.h: * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController goBack:]): (-[BrowserWindowController goForward:]): 2010-07-15 Daniel Bates Reviewed by Darin Adler. [Mac] Implement LayoutTestController::markerTextForListItem() https://bugs.webkit.org/show_bug.cgi?id=37929 Implements DRT support for markerTextForListItem in the Mac port. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::markerTextForListItem): Implemented. 2010-07-15 Adam Barth Unreviewed. Update the port names to be more specific. Before this patch, port-specific results for Mac would end up in the wrong place. * Scripts/webkitpy/tool/commands/rebaseline.py: * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: 2010-07-14 Eric Seidel Reviewed by Adam Barth. WebKit needs a rebaselining tool (finally) https://bugs.webkit.org/show_bug.cgi?id=42339 This is a very basic rebaselining tool. It's not quite as fancy as chromium's as it will only handle updating failing results. It cannot yet handle adding new results, or updating results where the results should not replace existing results. * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/tool/commands/__init__.py: * Scripts/webkitpy/tool/commands/queries.py: * Scripts/webkitpy/tool/commands/rebaseline.py: Added. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added. 2010-07-14 Sheriff Bot Unreviewed, rolling out r63352. http://trac.webkit.org/changeset/63352 https://bugs.webkit.org/show_bug.cgi?id=42341 Broke plugin-initiate-popup-window.html and plugin-javascript- access.html on snow leopard (Requested by abarth on #webkit). * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate): * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa): 2010-07-14 Maciej Stachowiak Reviewed by Mark Rowe. Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2010-07-14 Sheriff Bot Unreviewed, rolling out r63346. http://trac.webkit.org/changeset/63346 https://bugs.webkit.org/show_bug.cgi?id=42295 Broke lots of tests, some of which probably just need new results (Requested by aroben on #webkit). * DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult): 2010-07-14 Adam Roben Speed up killing of Apache on Windows Fixes Killing Apache (and thus quitting run-webkit-tests) takes a long time on Windows Reviewed by Darin Adler and Jon Honeycutt. * Scripts/webkitperl/httpd.pm: (closeHTTPD): Use taskkill to kill Apache and its child processes. Perl's kill seems ineffectual. We were already using taskkill, but only after trying kill 20 times. Since kill never works, let's just skip it entirely. 2010-07-14 Johnny Ding Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=41292 Add a new parameter to the test plugin to allow to specify a script and a mouse/keyboard event. The specified script will be evaluated in the browser when the specified event is received by the plugin. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate): * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa): 2010-07-14 Adam Roben Make urlSuitableForTestResult work for http: URLs, too Fixes http/tests/loading/preload-slow-loading.php and http/tests/mime/uppercase-mime-type.html fail on Windows. Reviewed by Darin Adler. * DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult): Don't bail if the URL starts with http://. We want this function to work for those URLs, too! 2010-07-13 Maciej Stachowiak Reviewed by Oliver Hunt. Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests https://bugs.webkit.org/show_bug.cgi?id=42227 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize new bool members. (WTR::LayoutTestController::display): Dummy method. (WTR::displayCallback): Call the dummy. (WTR::repaintSweepHorizontallyCallback): ditto (WTR::testRepaintCallback): ditto (WTR::LayoutTestController::staticFunctions): Expose new methods. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does nothing). (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto 2010-07-13 Andreas Kling Unreviewed. Adding myself as committer. * Scripts/webkitpy/common/config/committers.py: 2010-07-07 Tor Arne Vestbø Reviewed by Darin Adler. Prevent assertion/duplicate loads for non-deferred subtitute-data loads https://bugs.webkit.org/show_bug.cgi?id=30879 MainResourceLoader uses the member m_initialRequest to store requests for future deferred loads. When doing the actual load in handleDataLoadNow(), we therefore have to clear this request so that subsequent entries into the loader will not start yet another load. This can happen as a result of a PageGroupLoadDeferrer going out of scope when returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false), but only in the case of using both substitute-data and non-deferred main resource load together. That's why two new DRT functions were added: * queueLoadHTMLString() * setDeferMainResourceLoad() The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac and Win the hook uses new SPI in WebDataSource. For Qt a new static member was added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (queueLoadHTMLStringCallback): (setDeferMainResourceDataLoadCallback): (LayoutTestController::staticFunctions): (LayoutTestController::queueLoadHTMLString): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad): (LayoutTestController::setDeferMainResourceDataLoad): * DumpRenderTree/WorkQueueItem.h: (LoadHTMLStringItem::LoadHTMLStringItem): * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadHTMLStringItem::invoke): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): * DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadHTMLStringItem::invoke): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad): (LayoutTestController::queueLoadHTMLString): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/qt/WorkQueueItemQt.cpp: (LoadHTMLStringItem::invoke): * DumpRenderTree/qt/WorkQueueItemQt.h: (LoadHTMLStringItem::LoadHTMLStringItem): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest): * DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadHTMLStringItem::invoke): * DumpRenderTree/wx/WorkQueueItemWx.cpp: (LoadHTMLStringItem::invoke): 2010-07-13 Maciej Stachowiak Reviewed by Nikolas Zimmermann. Activate test fonts for layout tests in WebKitTestRunner (on Mac) https://bugs.webkit.org/show_bug.cgi?id=42153 * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::initialize): Activate fonts on startup. * WebKitTestRunner/InjectedBundle/mac: Added. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added. (WTR::activateFonts): Activate our fonts. * WebKitTestRunner/InjectedBundle/win: Added. * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added. (WTR::activateFonts): Dummy version. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle; add more files. * WebKitTestRunner/fonts: Added. * WebKitTestRunner/fonts/AHEM____.TTF: Added. * WebKitTestRunner/fonts/ColorBits-A.png: Added. * WebKitTestRunner/fonts/ColorBits.ttf: Added. * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added. * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added. * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added. 2010-07-13 Dumitru Daniliuc Reviewed by Eric Seidel. Remove check-header-includes, as it didn't turn out to be very useful. https://bugs.webkit.org/show_bug.cgi?id=41970 * Scripts/check-header-includes: Removed. 2010-07-12 Steve Falkenburg Reviewed by Maciej Stachowiak. Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots) https://bugs.webkit.org/show_bug.cgi?id=40922 Always build WebKit2 on Windows. Necessary since our WebKit build on Windows is packaged into a DLL with WebKit2. * Scripts/build-webkit: Always build WebKit2 on Windows. 2010-07-12 Brian Weinstein Reviewed by Steve Falkenburg. One http test timing out on Windows can cause all future tests to time out https://bugs.webkit.org/show_bug.cgi?id=42146 There have been multiple times on the Windows bots where one http test timing out causes all future http tests to time out. This is because the httpd process becomes unresponsive. When an http test times out, we should restart httpd on Cygwin to prevent this. * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it. * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if using kill fails. 2010-07-12 Maciej Stachowiak Reviewed by Dan Bernstein. Remove use of auto_ptr in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=42134 Replaced auto_ptr with PassOwnPtr / OwnPtr. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::WKStringToUTF8): (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::addMessageToConsole): * WebKitTestRunner/TestInvocation.cpp: (WTR::WKStringToUTF8): (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): 2010-07-12 Maciej Stachowiak Reviewed by Sam Weinig. Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it) https://bugs.webkit.org/show_bug.cgi?id=42132 * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of platform directories. 2010-07-12 Maciej Stachowiak Reviewed by Anders Carlsson. Make WebKitTestRunner resize the view specially for the W3C SVG tests. https://bugs.webkit.org/show_bug.cgi?id=42126 * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): Store the path as a C string for later use. (WTR::TestInvocation::~TestInvocation): (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper size, depending on whether this is a W3C SVG test. (WTR::TestInvocation::invoke): Call the size function. * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::resizeTo): Implement. * WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::resizeTo): Placeholder. 2010-07-12 Mario Sanchez Prada Reviewed by Xan Lopez. Ensure DRT loads GAIL (Gtk+ module), for a11y tests https://bugs.webkit.org/show_bug.cgi?id=38648 Add the GTK_MODULES envvar (set to "gail") to the clean environment when running DRT for the Gtk+ port * Scripts/old-run-webkit-tests: 2010-07-12 Martin Robinson Reviewed by Dirk Schulze. [GTK] Support pixel tests https://bugs.webkit.org/show_bug.cgi?id=31518 Finish support for pixel tests on GTK+. * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only works on CoreFoundation systems) and add missing cstdio include. * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found in JSC library. MD5.cpp and MD5.h are only available for the Windows build. (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported by the ANSI standard and this fails on Linux, so unroll the loop here. * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior. (BitmapContext::BitmapContext): There is no reason to check the value of the m_context member in the constructor and it certainly should not be freed. Instead just initialize it with the incoming value. * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes. (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to dump pixels. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added. (createBitmapContextFromWebView): * GNUmakefile.am: Add new files to the build. 2010-07-12 Adam Barth Unreviewed. Remove stray "raise e" that got included in a previous patch. This caused the EWS bots to turn red instead of purple when a patch failed to apply. * Scripts/webkitpy/tool/commands/stepsequence.py: 2010-07-12 Sheriff Bot Unreviewed, rolling out r63101. http://trac.webkit.org/changeset/63101 https://bugs.webkit.org/show_bug.cgi?id=42103 Broke one API test (Requested by xan_ on #webkit). * Scripts/old-run-webkit-tests: 2010-07-12 Alexey Proskuryakov Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=13075 XMLHttpRequest with failed authentication should set status to 401 https://bugs.webkit.org/show_bug.cgi?id=6871 401 error page is never shown Fix crashes in Windows DumpRenderTree. * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge() again on a destroyed sender. 2010-07-12 Adam Roben Windows failure-to-launch fix * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like we already do for CoreFoundation, CFNetwork, etc. 2010-07-12 Mario Sanchez Prada Reviewed by Xan Lopez. Ensure DRT loads GAIL (Gtk+ module), for a11y tests https://bugs.webkit.org/show_bug.cgi?id=38648 Add the GTK_MODULES envvar (set to "gail") to the clean environment when running DRT for the Gtk+ port * Scripts/old-run-webkit-tests: 2010-07-09 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=13075 XMLHttpRequest with failed authentication should set status to 401 https://bugs.webkit.org/show_bug.cgi?id=6871 401 error page is never shown * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed the Cancel button. 2010-07-12 Andreas Kling Reviewed by Tor Arne Vestbø. [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=42082 * QtTestBrowser/main.cpp: (LauncherWindow::createChrome): * QtTestBrowser/mainwindow.cpp: (MainWindow::openLocation): * QtTestBrowser/mainwindow.h: 2010-07-12 Adam Roben Make the Python autoinstaller not use a dead SourceForge server Fixes webkit-patch is broken due to offline SourceForge server Reviewed by Anders Carlsson. * Scripts/webkitpy/thirdparty/__init__.py: Use surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net, which seems to be down. 2010-07-12 Adam Roben Make run-webkit-tests print how many tests timed out when exiting early The number of timed-out tests is taken into account when deciding whether to exit early. Leaving it out of the output just makes the script look buggy (because it might say something like "Exiting early after 0 crashes."). Fixes run-webkit-tests prints confusing messages when exiting early due to crashes and time-outs Reviewed by Anders Carlsson. * Scripts/old-run-webkit-tests: (stopRunningTestsEarlyIfNeeded): When stopping, print the number of timed-out tests, too. 2010-07-11 Maciej Stachowiak Reviewed by Dan Bernstein. Implement animation-related methods for WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=42053 Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many animation tests were hanging otherwise. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::numberOfActiveAnimations): (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::LayoutTestController::staticFunctions): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2010-07-11 Daniel Bates Reviewed by David Kilzer. Enable executable support for svn-apply and svn-unapply https://bugs.webkit.org/show_bug.cgi?id=39409 Connect up the Git and SVN executable bit support in parseDiff() so that executable bit changes are propagated via the returned diff hash to the patch function in svn-apply and svn-unapply. * Scripts/VCSUtils.pm: - Modified parseDiff() to call parseSvnDiffProperties when it finds the start of an SVN property change diff. - Removed FIXME comment above parseSvnDiffProperties() since it is now being used by parseDiff(). - Export method scmToggleExecutableBit() now that we added the executableBitDelta hash key. (This should have been exported when we added this function in Bug #38423 ). * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: - Updated results for: "rename (with executable bit change)" - Test value of executableBitDelta (now that we have support). "SVN: binary file (isBinary true)" - Remove the property change diff from svnConvertedText. We plan to remove svnConvertedText in the future. So, we decided against adding such support to any new code, such as the property parsing routines. Therefore, we do not keep SVN converted text for property change diffs. - Added unit tests: "SVN: file change diff with property change diff" "SVN: file change diff, followed by property change diff on different file" "SVN: property diff, followed by file change diff" "SVN: copied file with property change" "SVN: two consecutive property diffs" "SVN: binary file with executable bit change" "SVN: binary file followed by property change on different file" "SVN: binary file followed by file change on different file" "SVN: file change diff with property change, followed by property change diff" "SVN: file change diff with property change, followed by file change diff" 2010-07-11 Maciej Stachowiak Reviewed by Dan Bernstein. Implement waitUntilDone and notifyDone for WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=42049 With this fix, most of the DOM tests pass. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didCreatePage): Track the main page. Not a great way to do it in the future case where we may get multiple pages - we really need a way to send it over from the ui process. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::page): A way to get the main page. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we are loading. (WTR::InjectedBundlePage::dump): Factor into a method so this can be called by the layout test controller. Also, cancel any pending watchdogs. (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (WTR::InjectedBundlePage::isLoading): A way to track if we are loading. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump to false. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate the watchdog. (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer. (WTR::LayoutTestController::setWaitToDump): Set the flag. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case where waitUntilDone times out. (WTR::LayoutTestController::notifyDone): Dump, if loading is done. (WTR::waitUntilDoneCallback): JS glue for waitUntilDone. (WTR::notifyDoneCallback): JS glue for notifyDone. (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone to the layoutController. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::waitToDump): Inline method to get the wait state. 2010-07-09 Brian Weinstein Rubber-stamped by Dan Bernstein. Windows testers running Windows 7 were hanging during test_kill_process. Changing the number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to slow down the tests). * Scripts/webkitpy/common/system/executive.py: 2010-07-09 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Mac build fix https://bugs.webkit.org/show_bug.cgi?id=41967 Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 2010-07-09 Diego Gonzalez Reviewed by Antonio Gomes. [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar https://bugs.webkit.org/show_bug.cgi?id=41966 * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): 2010-07-09 Leon Clarke Reviewed by Adam Barth. add support for link prefetching https://bugs.webkit.org/show_bug.cgi?id=3652 * Scripts/build-webkit: 2010-07-09 Ojan Vafai Reviewed by Adam Barth. r63004 broke some python tests https://bugs.webkit.org/show_bug.cgi?id=42007 AbstractStep now checks options.no_squash and options.squash, so they needed to have real values. Mock would return an object for those, which would then act as if the values were True. * Scripts/webkitpy/tool/commands/commandtest.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/stepsequence.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: 2010-07-09 Ojan Vafai Reviewed by Adam Barth. --squash should go away and become the default https://bugs.webkit.org/show_bug.cgi?id=39624 If there are local commits and working copy changes, then prompt the user whether to continue. Setting git config webkit-patch.commit_should_always_squash true bypasses the prompt. --git-commit=HEAD.. operates on working copy changes only. --git-commit=committish operates on a range of commits as a single commit. e.g. --git-commit=HEAD only operates on the HEAD commit. --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit. --no-squash and --squash are left in with descriptive error messages if used. * Scripts/check-webkit-style: * Scripts/webkitpy/common/checkout/api.py: * Scripts/webkitpy/common/checkout/api_unittest.py: * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: * Scripts/webkitpy/common/net/rietveld.py: * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/style/optparser.py: * Scripts/webkitpy/style_references.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: * Scripts/webkitpy/tool/steps/checkstyle.py: * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed. * Scripts/webkitpy/tool/steps/commit.py: * Scripts/webkitpy/tool/steps/options.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: * Scripts/webkitpy/tool/steps/validatereviewer.py: 2010-07-09 Mark Rowe Add two new Windows test build slaves. * BuildSlaveSupport/build.webkit.org-config/config.json: 2010-07-09 Albert J. Wong Reviewed by David Levin. rebaseline_chromium_webkit_tests missing --use_drt option on linux https://bugs.webkit.org/show_bug.cgi?id=41985 This adds in the --use_drt option for rebaseline_chromium_webkit_tests so that it works on linux. This is essentially a "compile-fix" for the script. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-07-09 Nico Weber Unreviewed. Adding myself as committer. * Scripts/webkitpy/common/config/committers.py: 2010-07-09 David Kilzer Revert " commit-log-editor: wrong ChangeLog read when invoked from subdir with git" This reverts commit r62692. * Scripts/commit-log-editor: 2010-07-08 Kinuko Yasuda Reviewed by Ojan Vafai. cleanup json_results_generator dependencies so that non-layout-tests can also use it safely https://bugs.webkit.org/show_bug.cgi?id=38693 Introduced a new base class JSONResultsGeneratorBase that doesn't have any dependency on layout_tests packages. Turned JSONResultsGenerator into a wrapper class of the base class so that the old code can work with it during the cleanup. Added json_results_generator_unittest.py. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added 2010-07-09 Abhishek Arya Unreviewed. Marking myself as a committer. * Scripts/webkitpy/common/config/committers.py: 2010-07-09 Kenneth Rohde Christiansen Reviewed by Antti Koivisto. Implement MiniBrowser for Qt. https://bugs.webkit.org/show_bug.cgi?id=40233 * MiniBrowser/qt/BrowserWindow.cpp: Added. (createNewPage): (BrowserView::BrowserView): (BrowserView::resizeEvent): (BrowserView::load): (BrowserView::view): (BrowserWindow::BrowserWindow): (BrowserWindow::load): (BrowserWindow::changeLocation): (BrowserWindow::~BrowserWindow): * MiniBrowser/qt/BrowserWindow.h: Added. (BrowserView::~BrowserView): * MiniBrowser/qt/MiniBrowser.pro: Added. * MiniBrowser/qt/main.cpp: Added. (main): 2010-07-09 Jedrzej Nowacki Reviewed by Simon Hausmann. Introduce the Qt autotest launcher. Qt autotests should be executed more frequently, ideally by the Qt build bot. This is the first step to provide the tests more accessible. [Qt] It should be easier to run all Qt's autotests. https://bugs.webkit.org/show_bug.cgi?id=31625 * Scripts/run-qtwebkit-tests: Added. 2010-07-09 Adam Barth Reviewed by Eric Seidel. commit-queue should merge to TOT when checkout needs update https://bugs.webkit.org/show_bug.cgi?id=41944 There are a bunch of different designs that are possible here. This one merges to top of tree by cleaning out the working copy and re-applying the patch. Once you decide to merge that way, you need to decide who's going to retry. In this patch, we retry in the child process instead of plumbing the failure reason to the master process. This patch is difficult to test end-to-end, but hopefully it will work. :) * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/stepsequence.py: * Scripts/webkitpy/tool/multicommandtool.py: * Scripts/webkitpy/tool/multicommandtool_unittest.py: 2010-07-09 Dumitru Daniliuc Reviewed by Darin Adler. Add a script to check for unnecessary includes in header files. https://bugs.webkit.org/show_bug.cgi?id=41894 * Scripts/check-header-includes: Added. 2010-07-09 Adam Barth Reviewed by Eric Seidel. Add --html5-treebuilder option to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=41922 We're down to one or two regressions in the HTML5lib test suite. It's getting to be time to look at fixing LayoutTests. * Scripts/old-run-webkit-tests: 2010-07-08 Simon Fraser Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting in the drawing model never getting set on Tiger. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): 2010-07-08 Aaron Boodman Reviewed by Timothy Hatcher. Add the ability for user scripts and user styles to affect just the top frame. https://bugs.webkit.org/show_bug.cgi?id=41529 * DumpRenderTree/LayoutTestController.h: Added new allFrames param. * DumpRenderTree/LayoutTestController.cpp: Ditto. (addUserScriptCallback): (addUserStyleSheetCallback): * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): 2010-07-08 Adele Peterson Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler. Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721 Missing plug-in indicator should have a pressed state Log when the missing plugin button is pressed. * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:didPressMissingPluginButton:]): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::QueryInterface): (UIDelegate::createWebViewWithRequest): (UIDelegate::drawBackground): (UIDelegate::decidePolicyForGeolocationRequest): (UIDelegate::didPressMissingPluginButton): * DumpRenderTree/win/UIDelegate.h: 2010-07-08 Simon Fraser Fix the Tiger build. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): 2010-07-08 Simon Fraser Fix windows build. #ifdef code for Mac. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): 2010-07-08 Simon Fraser Reviewed by Anders Carlsson. Allow the TestPlugin to use Core Animation rendering for testing https://bugs.webkit.org/show_bug.cgi?id=41872 Add the ability for the TestPlugin to use the CoreAnimation rendering model when available, based on the "drawingmodel" attribute of the embed tag: drawingmodel="coreanimation" * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect when building on Tiger. Add a void* coreAnimationLayer member. * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added. (createCoreAnimationLayer): Obj-C method to create the CALayer. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Look for the drawingmodel attribute to decide which drawing model to use. (NPP_Destroy): Release the CALayer if we have one. (NPP_GetValue): Return the retained CALayer. 2010-07-08 Martin Robinson Reviewed by Xan Lopez. [GTK] Support pixel tests https://bugs.webkit.org/show_bug.cgi?id=31518 Convert this file from CRLF to NL line endings. It will soon be used on more than just the WinCairo platform. * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: (writeFunction): (printPNG): (computeMD5HashStringForBitmapContext): (dumpBitmap): 2010-07-08 Steve Falkenburg Reviewed by Darin Adler. Enable Data Execution Prevention for our test harnesses on Windows https://bugs.webkit.org/show_bug.cgi?id=41882 * DumpRenderTree/win/DumpRenderTree.vcproj: * DumpRenderTree/win/ImageDiff.vcproj: * WebKitAPITest/WebKitAPITest.vcproj: * WebKitTestRunner/win/WebKitTestRunner.vcproj: 2010-07-07 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Add DRT support for pageProperty etc. https://bugs.webkit.org/show_bug.cgi?id=41584 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageSizeAndMarginsInPixels): (LayoutTestController::pageProperty): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-07-08 Martin Robinson Reviewed by Xan Lopez. Remove a warnings from the ImageDiff build by using the proper printf format string for the gsize data type. * DumpRenderTree/gtk/ImageDiff.cpp: (printImage): Use the proper printf format string for the gsize data type. 2010-07-08 Alice Liu Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=41653 Add new WebKitTestRunner project for Windows * WebKitTestRunner/WebKitTestRunnerPrefix.h: Similar to how it's done in DumpRenderTree, define max and min early on so that they don't get replaced by a macro requiring 2 arguments. * WebKitTestRunner/win: Added. * WebKitTestRunner/win/WebKitTestRunner.sln: Added. * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added. * WebKitTestRunner/win/main.cpp: Added. (main): Implemented Added these files with stubbed out functions: * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added. (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::page): * WebKitTestRunner/win/TestControllerWin.cpp: Added. (WTR::TestController::initializeInjectedBundlePath): * WebKitTestRunner/win/TestInvocationWin.cpp: Added. (WTR::TestInvocation::runUntil): 2010-07-07 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Implement ImageDiff and add it to the build system https://bugs.webkit.org/show_bug.cgi?id=41779 Add the initial implementation of the ImageDiff tool for the GTK+ port. This is an essential tool for doing pixel tests. The implementation is based on the Mac and Chromium ports. * DumpRenderTree/gtk/ImageDiff.cpp: Added. (readPixbufFromStdin): Added. (differenceImageFromDifferenceBuffer): Ditto. (calculateDifference): Ditto. (printImage): Ditto. (printImageDifferences): Ditto. (main): Ditto. * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts. 2010-07-08 Jay Civelli Unreviewed. Adding myself as a committer. * Scripts/webkitpy/common/config/committers.py: 2010-07-08 Adam Roben Make Windows stop running tests from platform/mac r62742 made a change (at my suggestion!) that caused us to start looking for tests in platform/mac, rather than just looking for expected results in platform/mac. This patch just undoes that part of r62742. Fixes REGRESSION (r62742): Windows runs tests from platform/mac, but shouldn't Reviewed by Antti Koivisto and Anders Carlsson. * Scripts/old-run-webkit-tests: (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms, so we won't look in those directories for tests to run. (expectedDirectoryForTest): Added back code from pre-r62742 to look in platform/mac-snowleopard and platform/mac for expected results. 2010-07-08 Antonio Gomes Unreviewed. Adding myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: 2010-07-08 Tor Arne Vestbø Update my e-mail in committers.py * Scripts/webkitpy/common/config/committers.py: 2010-07-07 Daniel Bates Reviewed by Dumitru Daniliuc. VCSUtils.pm complains about uninitialized value $newLine https://bugs.webkit.org/show_bug.cgi?id=41333 Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of an array when fixing a change log entry that overlaps with an earlier entry. In particular, when a patch contains a change log entry inserted earlier in the change log file, but after an entry with the same author and date. * Scripts/VCSUtils.pm: - Added for-loop constraint to fixChangeLogPatch() so that it does not read off the end of the @overlappingLines array. * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test. 2010-07-07 Anders Carlsson Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): 2010-07-07 Kent Tamura Reviewed by Adam Barth. [DRT/Chromium] Support for indeterminate checkbox https://bugs.webkit.org/show_bug.cgi?id=41747 Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499 * DumpRenderTree/chromium/WebThemeControlDRT.cpp: (WebThemeControlDRT::draw): * DumpRenderTree/chromium/WebThemeControlDRT.h: (WebThemeControlDRT::): * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: (WebThemeEngineDRT::paintButton): 2010-07-07 Sam Weinig Reviewed by Mark Rowe. Clean up MiniBrowser Xcode project. - Use xcconfig files. - Rename plists to canonical Info.plist - Remove localizations. * MiniBrowser/Configurations: Added. * MiniBrowser/Configurations/Base.xcconfig: Added. * MiniBrowser/Configurations/DebugRelease.xcconfig: Added. * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added. * MiniBrowser/Configurations/WebBundle.xcconfig: Added. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/WebBundle-Info.plist: Removed. * MiniBrowser/mac/BrowserStatisticsWindowController.m: (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]): * MiniBrowser/mac/BrowserWindow.xib: Added. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController initWithPageNamespace:]): * MiniBrowser/mac/English.lproj: Removed. * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed. * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed. * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed. * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist. * MiniBrowser/mac/MainMenu.xib: Added. * MiniBrowser/mac/MiniBrowser-Info.plist: Removed. * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist. 2010-07-07 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Fix two regressions https://bugs.webkit.org/show_bug.cgi?id=41745 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion): Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg and svg/custom/use-on-g-containing-foreignObject-and-image.svg though test_shell does it twice. Probably DRT needs it because DRT delays painting as possible. 2010-07-07 Anders Carlsson Try to fix build. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_destroy_stream): 2010-07-07 Anders Carlsson Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_stream): (webkit_test_plugin_destroy_stream): (webkit_test_plugin_write_ready): (webkit_test_plugin_write): 2010-07-07 Sam Weinig Reviewed by Mark Rowe. Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 2010-07-07 Anders Carlsson Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (NPP_HandleEvent): 2010-07-07 Brian Weinstein Reviewed by Adam Roben. Need to have a way to specify different results for Windows XP and 7 https://bugs.webkit.org/show_bug.cgi?id=41776 Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7 subdirectories, so we can have different results for tests on Windows XP, Windows Vista, and Windows 7. Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac. Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac. Windows 7 will try the order: win-7, win, mac-snowleopard, mac. This matches the behavior of the mac. * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP or Vista, try looking in other win-* subdirectories before win. * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows we are running. 2010-07-07 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions https://bugs.webkit.org/show_bug.cgi?id=41753 The original code of the following functions in test_shell_devtools_client.cc have NOTIMPLEMENTED(), not ASSERT_NOT_REACHED(). The program shouldn't stop at these functions. * DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::activateWindow): (DRTDevToolsClient::closeWindow): (DRTDevToolsClient::dockWindow): (DRTDevToolsClient::undockWindow): 2010-07-07 Anders Carlsson Reviewed by Sam Weinig. Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function https://bugs.webkit.org/show_bug.cgi?id=41821 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginGetProperty): (pluginSetProperty): (pluginAllocate): * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add and initialize the returnNegativeOneFromWrite property. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_NewStream): Set the stream type to NP_NORMAL so we'll get write callbacks. (NPP_DestroyStream): Treat the onstreamdestroy attribute as a function name and not a string. (NPP_WriteReady): Have this return a nonzero value. (NPP_Write): If returnNegativeOneFromWrite is true return -1. 2010-07-07 Kevin Ollivier [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the latest version is selected by default, and allows the version to be specified. * wx/build/settings.py: 2010-07-07 Chris Fleizach Reviewed by Darin Adler. AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area https://bugs.webkit.org/show_bug.cgi?id=41810 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::selectedTextRange): 2010-07-07 Martin Robinson Unreviewed. Build fix after r62700. * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn source file locations. 2010-07-07 Ojan Vafai Reviewed by David Levin. change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts https://bugs.webkit.org/show_bug.cgi?id=41814 * BuildSlaveSupport/build.webkit.org-config/master.cfg: * Scripts/old-run-webkit-tests: 2010-07-07 Ojan Vafai Reviewed by David Levin. add --exit-after-n-crashes to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=41811 Change the bots at build.webkit.org to use --exit-after-n-crashes instead of --exit-after-n-failures since we want to be able to have more than 20 failures on those bots, but more than 20 crashes means something should be rolled out. * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-07-07 Brian Weinstein Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the TestNetscapePlugin project, because this was removed from the tree. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 2010-07-07 Anders Carlsson Reviewed by Simon Fraser. Unify Mac and Windows TestNetscapePlugin main.cpp files https://bugs.webkit.org/show_bug.cgi?id=41798 * DumpRenderTree/DumpRenderTree.sln: * DumpRenderTree/TestNetscapePlugIn/main.cpp: (strcasecmp): (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed. 2010-07-07 Kevin Ollivier [wx] Build fix. pageProperty needs to return a value. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::pageProperty): 2010-07-07 David Kilzer commit-log-editor: wrong ChangeLog read when invoked from subdir with git Reviewed by Anders Carlsson. For both svn and git, commit-log-editor is invoked from the root of the working directory. Unlike svn, git returns a list of changed files that are relative to the directory where the command was invoked. This caused the ChangeLog file in the root directory to be read instead of the ChangeLog in the current directory. The fix is to use $ENV{PWD} as the base directory when fixing the path to the ChangeLog files. With svn, this has no net effect since $ENV{PWD} is the root of the working directory and the ChangeLog paths are already relative to that directory. With git, $ENV{PWD} is the directory that the commit was invoked from, which fixes the ChangeLog paths so that the correct files are read when creating the commit log entry. Note that the call to makeFilePathRelative() was supposed to address this issue, but it doesn't because (a) it does nothing with svn working directories by design, and (b) it does nothing with git working directories because it's invoked when the current directory is the root of the working directory, thus giving no relative path. * Scripts/commit-log-editor: Removed call to makeFilePathRelative() since since it does nothing. Moved code to fix up $changeLog path so that it's fixed before trying to open the file, and use $ENV{PWD} as the base path. Also use canonicalizePath() to clean up paths with "../" in them. 2010-07-07 Anders Carlsson Another attempt at fixing the Qt build. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 2010-07-07 Anders Carlsson Try to fix Qt build. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 2010-07-07 Anders Carlsson Reviewed by Simon Fraser. Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories https://bugs.webkit.org/show_bug.cgi?id=41781 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp. * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h. * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp. * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h. * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist. * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def. * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h. * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed. 2010-07-07 Andras Becsi Unreviewed trivial fix. Remove DUMPRENDERTREE_TEMP environment variable from NRWT which was checked in accidentally in r62635. * Scripts/webkitpy/layout_tests/port/webkit.py: 2010-07-07 Gabor Rapcsanyi Reviewed by Eric Seidel. Pass port specific environment to server process. https://bugs.webkit.org/show_bug.cgi?id=41593 * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/webkit.py: 2010-07-06 Kent Tamura Reviewed by Shinichiro Hamaji. Fix a wrong dup detection of rebaseline-chromium-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=41644 rebaseline-chromium-webkit-tests used ImageDiff with 0.1% tolerance. We don't need tolerance for rebaseline. * Scripts/webkitpy/layout_tests/port/base.py: Add optional tolerance parameter to diff_image(). * Scripts/webkitpy/layout_tests/port/test.py: Add optional tolerance parameter to diff_image(). * Scripts/webkitpy/layout_tests/port/webkit.py: Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command. * Scripts/webkitpy/layout_tests/test_types/image_diff.py: diff_files() always calls diff_image() with tolerance=0. diff_files() is used only by rebaseline-chromium-webkit-tests. 2010-07-06 Sam Weinig Fix MiniBrowser build. * MiniBrowser/mac/WebBundle/WebBundleMain.m: 2010-07-06 Sam Weinig Reviewed by Anders Carlsson. Add support for dumping the contents of messages to the console to WebKitTestRunner * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::_addMessageToConsole): (WTR::InjectedBundlePage::addMessageToConsole): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 2010-07-06 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41708 Add dumpAsText support for WebKitTestRunner * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText API to dump the main frames text. 2010-07-06 Darin Adler Fix Chromium build. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource): Call leakPtr instead of release. (WebViewHost::didNavigateWithinPage): Ditto. (WebViewHost::updateURL): Ditto. 2010-07-06 Martin Robinson Reviewed by Xan Lopez. [GTK] build-webkit should not run autogen.sh unconditionally https://bugs.webkit.org/show_bug.cgi?id=41704 * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile doesn't exist. Autotools should re-run autogen.sh when necessary. Also do some very minor cleanup. 2010-07-06 Darin Adler Try to fix Chromium build. * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h. 2010-07-06 Darin Adler Fix build. * WebKitAPITest/TestsController.cpp: (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release. 2010-07-06 Roland Steiner Reviewed by Kent Tamura. Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT https://bugs.webkit.org/show_bug.cgi?id=40558 Upstream DevTools for Chromium DRT. (original Chromium files rev. 51287) * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added. (DRTDevToolsAgent::DRTDevToolsAgent): (DRTDevToolsAgent::setWebView): (DRTDevToolsAgent::sendMessageToFrontend): (DRTDevToolsAgent::forceRepaint): (DRTDevToolsAgent::runtimeFeatureStateChanged): (DRTDevToolsAgent::injectedScriptSource): (DRTDevToolsAgent::injectedScriptDispatcherSource): (DRTDevToolsAgent::debuggerScriptSource): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::call): (DRTDevToolsAgent::webDevToolsAgent): (DRTDevToolsAgent::attach): (DRTDevToolsAgent::detach): (DRTDevToolsAgent::setTimelineProfilingEnabled): (DRTDevToolsAgent::evaluateInWebInspector): (DRTDevToolsAgent::dispatchMessageLoop): * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added. (DRTDevToolsAgent::~DRTDevToolsAgent): (DRTDevToolsAgent::hostIdentifier): * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: (DRTDevToolsCallArgs::DRTDevToolsCallArgs): (DRTDevToolsCallArgs::~DRTDevToolsCallArgs): (DRTDevToolsCallArgs::callsCount): * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added. (DRTDevToolsClient::DRTDevToolsClient): (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::sendMessageToAgent): (DRTDevToolsClient::sendDebuggerCommandToAgent): (DRTDevToolsClient::activateWindow): (DRTDevToolsClient::closeWindow): (DRTDevToolsClient::dockWindow): (DRTDevToolsClient::undockWindow): (DRTDevToolsClient::asyncCall): (DRTDevToolsClient::call): (DRTDevToolsClient::allMessagesProcessed): * DumpRenderTree/chromium/DRTDevToolsClient.h: * DumpRenderTree/chromium/EventSender.cpp: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::closeWebInspector): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::evaluateInWebInspector): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::~TestShell): (TestShell::createDRTDevToolsClient): (TestShell::showDevTools): (TestShell::closeDevTools): (TestShell::runFileTest): (TestShell::createNewWindow): * DumpRenderTree/chromium/TestShell.h: (TestShell::drtDevToolsAgent): (TestShell::drtDevToolsClient): * DumpRenderTree/chromium/config.h: 2010-07-06 Gabor Rapcsanyi Reviewed by Eric Seidel. Don't pass image hash to DRT when pixel tests are disabled. https://bugs.webkit.org/show_bug.cgi?id=41597 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 2010-07-05 Csaba Osztrogonác Reviewed by Eric Seidel. REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory https://bugs.webkit.org/show_bug.cgi?id=41612 * Scripts/ensure-valid-python: File::Temp::tempdir call fixed. 2010-07-05 Adam Barth Reviewed by Eric Seidel. We should be able to specify a bug to block for webkit-patch upload https://bugs.webkit.org/show_bug.cgi?id=41648 This will be useful for working on the HTML5 parser. * Scripts/webkitpy/tool/steps/createbug.py: * Scripts/webkitpy/tool/steps/options.py: 2010-07-05 Martin Robinson Reviewed by Oliver Hunt. The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h https://bugs.webkit.org/show_bug.cgi?id=41017 * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change. 2010-07-04 MORITA Hajime rebaseline-chromium-webkit-tests: UnicodeDecodeError https://bugs.webkit.org/show_bug.cgi?id=41589 * run() method can result non-utf-8 bytes, that causes utf-8 decoding fail. Fixed to disable decoding. * Fixed Git.find_checkout_root() to make a test pass. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: 2010-07-03 Patrick Gansterer Reviewed by Simon Hausmann. [Qt] Fix DumpRenderTree userStyleSheet handling. https://bugs.webkit.org/show_bug.cgi?id=41570 DumpRenderTree did only set the userStyleSheet at layoutTestController.setUserStyleSheetEnabled(). * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-07-03 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] support dumpChildFrameScrollPositions https://bugs.webkit.org/show_bug.cgi?id=41088 Unskip: http/tests/navigation/anchor-subframeload.html http/tests/navigation/relativeanchor-frames.html * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFrameScrollPosition): (WebCore::DumpRenderTree::dump): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFrameScrollPositions): 2010-07-02 Sam Weinig Reviewed by Anders Carlsson. Rename new scripts so that they don't make autocompleting run-webkit-tests annoying. * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner. * Scripts/debug-webkittestrunner: Removed. * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner. * Scripts/run-webkittestrunner: Removed. 2010-07-02 Brian Weinstein Reviewed by Steve Falkenburg. Some http tests fail on Windows with Cygwin 1.7 https://bugs.webkit.org/show_bug.cgi?id=41537 With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work. 2010-06-23 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Separate DerivedSources per-project https://bugs.webkit.org/show_bug.cgi?id=41109 The JavaScriptCore cppflags used to include the top-level DerivedSources directory allowing the tools to build as a side-effect. Now that the top-level directory is no longer in the list of JavaScriptCore includes, include it explicitly. * GNUmakefile.am: 2010-07-01 Tor Arne Vestbø Reviewed by Kenneth Rohde Christiansen. [Qt] Make context menus show up in the right place in QTestBrowser Context menus were shown at scene-relative coordinates for QGraphicsWebView while QMenu expects them to be global. The change to the QWidget case was to get rid of the mapToGlobal. * QtTestBrowser/webview.cpp: 2010-07-01 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] dump frames in ascending alphabetical order of title https://bugs.webkit.org/show_bug.cgi?id=41261 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem): 2010-07-01 Martin Robinson Unreviewed. Fix the GTK+ build after r62278. * Scripts/webkitdirs.pm: If the make arguments have already been specified, let them override the automatic CPU detection for autotools builds. 2010-07-01 Martin Robinson Unreviewed. Fix the Windows build after r62278. * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories. 2010-07-01 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] build-webkit does not detect the number of CPUs https://bugs.webkit.org/show_bug.cgi?id=41469 Pass the appropriate -j<#> flag to make when building autotools builds. This causes make to spawn that many number of child processes for doing parallel builds. * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number of CPUs. This makes the script work across more platforms. * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the number of CPUs across several platforms. Use this new function to determine the appropriate arguments to pass to make for doing parallel builds with autotools build files. 2010-07-01 Simon Hausmann Rubber-stamped by Laszlo Gombos. [Qt][Symbian] Bumped up the maximum heap size to 96MB * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration and use the one from WebKit.pri instead. 2010-07-01 Adam Barth Reviewed by Eric Seidel. Promote webkit-patch land-safely to main help https://bugs.webkit.org/show_bug.cgi?id=41446 I've been using this command a bunch and recommending it to folks. We should show it in main help as it's past the experimental phase. * Scripts/webkitpy/tool/commands/upload.py: 2010-06-28 MORITA Hajime Reviewed by Shinichiro Hamaji. rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit https://bugs.webkit.org/show_bug.cgi?id=38775 - Introduced SCM.show_head() and SCM.diff_for_file(). - Replaced direct svn invocations with newly implement SCM methods. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-06-30 Simon Fraser Reviewed by Sam Weinig. Allow MiniBrowser to open local files https://bugs.webkit.org/show_bug.cgi?id=41104 Wire up the openDocument: message with an NSOpenPanel, so we can open local files. Also change the xib so that the window remembers its size. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate frontmostBrowserWindowController]): (-[BrowserAppDelegate openDocument:]): (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]): * MiniBrowser/mac/English.lproj/BrowserWindow.xib: 2010-06-30 Sam Weinig Rubber-stamped by Anders Carlsson. Add debug-webkittestrunner and cleanup related scripts. * Scripts/debug-webkittestrunner: Added. * Scripts/run-webkittestrunner: * Scripts/webkitdirs.pm: 2010-06-30 Kevin Ollivier [wx] Build fix after recent changes to LayoutTestController. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::pageSizeAndMarginsInPixels): 2010-06-29 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41389 Make WebKitTestRunner work with more than one test at a time. This converts WebKitTestRunner to a similar model as DumpRenderTree, where there is a single WKView and each test is run it, rather than the design I was using where each test got its own WKView. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didRecieveMessage): (WTR::InjectedBundle::reset): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::runTest): (WTR::TestController::_didRecieveMessageFromInjectedBundle): (WTR::TestController::didRecieveMessageFromInjectedBundle): * WebKitTestRunner/TestController.h: (WTR::TestController::mainWebView): (WTR::TestController::pageNamespace): (WTR::TestController::context): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::~TestInvocation): (WTR::TestInvocation::invoke): (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.h: 2010-06-30 Simon Hausmann Reviewed by Laszlo Gombos. [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0 https://bugs.webkit.org/show_bug.cgi?id=40446 We quickly run out of memory on Symbian when loading web pages. This is caused by the default heap size, which is not suited for a web browser. This change bumps the max heap size to 32MB. * QtTestBrowser/QtTestBrowser.pro: 2010-06-30 Eric Seidel Reviewed by Adam Barth. webkit-patch land allow the user to continue even if the builders are red https://bugs.webkit.org/show_bug.cgi?id=41395 I don't think it's good that we've been teaching people to always pass --ignore-builders. At least land is now useable w/o --ignore-builders. * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: 2010-06-29 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] support dumpResourceResponseMIMETypes https://bugs.webkit.org/show_bug.cgi?id=41260 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpResourceResponseMIMETypes): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-06-29 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Resize scene when Qt DRT WebPage receives a geometry change request https://bugs.webkit.org/show_bug.cgi?id=41173 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::setViewGeometry): * DumpRenderTree/qt/DumpRenderTreeQt.h: 2010-06-29 Diego Gonzalez Reviewed by Simon Hausmann. [Qt] Deal with postEvent in case of graphics based DRT https://bugs.webkit.org/show_bug.cgi?id=41174 QGraphicsScene does not have a postEvent method, so make scene send the event, in case of graphics based DRT, and delete it after that. * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::scheduleAsynchronousClick): (EventSender::replaySavedEvents): (EventSender::postEvent): * DumpRenderTree/qt/EventSenderQt.h: 2010-06-29 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT https://bugs.webkit.org/show_bug.cgi?id=41172 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::switchFocus): 2010-06-29 Mario Sanchez Prada Reviewed by Xan Lopez. [Gtk] Make DRT more coherent with other ports to allow reusing more tests https://bugs.webkit.org/show_bug.cgi?id=40009 Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes are used when returning those values, for coherency with other ports. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): 2010-06-29 Sheriff Bot Unreviewed, rolling out r62106. http://trac.webkit.org/changeset/62106 https://bugs.webkit.org/show_bug.cgi?id=41346 "Broke editing tests" (Requested by xan_ on #webkit). * Scripts/old-run-webkit-tests: 2010-06-29 Mario Sanchez Prada Reviewed by Xan Lopez. Ensure DRT loads GAIL (Gtk+ module), for a11y tests https://bugs.webkit.org/show_bug.cgi?id=38648 Add the GTK_MODULES envvar (set to "gail") to the clean environment when running DRT for the Gtk+ port * Scripts/old-run-webkit-tests: 2010-06-28 Adam Barth Unreviewed. Switch test-html5-parser back to using runner.html. * Scripts/test-html5-parser: 2010-06-28 Adam Barth Reviewed by Eric Seidel. Restore webkit-runner.html for use with new tree builder https://bugs.webkit.org/show_bug.cgi?id=41317 For now, we just want to run webkit-runner when we test-html5-parser. * Scripts/test-html5-parser: 2010-06-23 John Gregg Reviewed by Kent Tamura. add ENABLE_DIRECTORY_UPLOAD build support https://bugs.webkit.org/show_bug.cgi?id=41100 * Scripts/build-webkit: 2010-06-28 Gustavo Noronha Silva Rubber-stamped by Xan Lopez. Update webkitdirs's knowledge of our library's name. * Scripts/webkitdirs.pm: 2010-06-28 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41299 Build up WebKitTestRunner output in the InjectedBundle Simplify WebKitTestRunner by building up the output in the InjectedBundle and sending it over postMessage when done, instead of using the async WKPageRenderTreeExternalRepresentation. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): (WTR::InjectedBundle::didRecieveMessage): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::os): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::WKStringToUTF8): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): * WebKitTestRunner/TestInvocation.cpp: (WTR::WKStringToUTF8): (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::invoke): (WTR::TestInvocation::initializeMainWebView): (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle): (WTR::TestInvocation::didRecieveMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.h: 2010-06-28 Robert Hogan Unreviewed, rolling out r62021. http://trac.webkit.org/changeset/62021 https://bugs.webkit.org/show_bug.cgi?id=41261 Broke http/navigation tests among other * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText): 2010-06-28 Sam Weinig Reviewed by Anders Carlsson. Add run-webkittestrunner to run WebKitTestRunner with the appropriate environment. * Scripts/run-webkittestrunner: Added. * Scripts/webkitdirs.pm: 2010-06-28 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] dump frames in ascending alphabetical order of title https://bugs.webkit.org/show_bug.cgi?id=41261 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText): 2010-06-28 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] dump bf history of child windows https://bugs.webkit.org/show_bug.cgi?id=41266 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump): * DumpRenderTree/qt/DumpRenderTreeQt.h: 2010-06-28 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41288 WebKit2: Add frame API for InjectedBundle code * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): 2010-06-28 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode). https://bugs.webkit.org/show_bug.cgi?id=38597 Fix behavior so reload button really acts as a load and a reload button. * QtTestBrowser/mainwindow.cpp: (MainWindow::changeLocation): 2010-06-28 Xan Lopez Reviewed by Gustavo Noronha. [GTK] Does not compile with -DGSEAL_ENABLE https://bugs.webkit.org/show_bug.cgi?id=37851 Fix build with GSEAL enabled. * DumpRenderTree/gtk/EventSender.cpp: (gtk_widget_get_window): (prepareMouseButtonEvent): (mouseMoveToCallback): (mouseWheelToCallback): (keyDownCallback): 2010-06-28 Xan Lopez Reviewed by Gustavo Noronha. [GTK] Add support for GTK+3 https://bugs.webkit.org/show_bug.cgi?id=41253 Adapt build system for 3.x support. * GNUmakefile.am: 2010-06-10 Mahesh Kulkarni Reviewed by Simon Hausmann. [QT][S60] build-webkit scripts picks wrong make spec for windows build https://bugs.webkit.org/show_bug.cgi?id=41198 Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. * Scripts/webkitdirs.pm: (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well 2010-06-28 Eric Seidel Reviewed by Adam Barth. Make it possible to test the new HTML5 TreeBuilder https://bugs.webkit.org/show_bug.cgi?id=41276 Adam was concerned that someone might make their port depend on this setting (I guess we had some trouble with that with the HTML5Parser setting), so I littered the code with warnings. test-html5-parser now tests this code path. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions): * Scripts/test-html5-parser: 2010-06-27 MORITA Hajime Unreviewed. Some never-called @staticmethods touched self. Fixed it to replace these self with a class. * Scripts/webkitpy/common/checkout/scm.py: 2010-06-27 MORITA Hajime Unreviewed. Fixed exception raising syntax that is pointed out at https://bugs.webkit.org/show_bug.cgi?id=41153 * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: Removed a bad line that I accidentally checked-in at last revision. 2010-06-24 MORITA Hajime Reviewed by Eric Seidel. rebaseline-chromium-webkit-tests should add or remove files to local git repository https://bugs.webkit.org/show_bug.cgi?id=41153 - Added SCM.add() and SCM.remove() - Replaced "svn add" and "svn remove" rebaseline_chromium_webkit_tests.py: in with SCM method equivalents. - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py for debugging purpose. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2010-06-25 Yuzo Fujishima Reviewed by Shinichiro Hamaji. Improve default value handling for page format properties. https://bugs.webkit.org/show_bug.cgi?id=41150 * DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (parsePageNumberSizeMarings): (pageSizeAndMarginsInPixelsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageSizeAndMarginsInPixels): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageSizeAndMarginsInPixels): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageSizeAndMarginsInPixels): 2010-06-21 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] DRT Support for setCustomPolicyDelegate https://bugs.webkit.org/show_bug.cgi?id=39564 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setCustomPolicyDelegate): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-06-26 Robert Hogan Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879 Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer exported. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2010-06-26 Tony Gentilcore Reviewed by Dimitri Glazkov. Add a build-webkit option for enabling Web Timing support. https://bugs.webkit.org/show_bug.cgi?id=38924 * Scripts/build-webkit: 2010-06-25 Jesus Sanchez-Palencia Reviewed by Kenneth Rohde Christiansen. [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode). https://bugs.webkit.org/show_bug.cgi?id=38597 Make the reload button act as a load button as well. * QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::changeLocation): 2010-06-25 Prasad Tammana Reviewed by Dmitry Titov. Add empty abortModal() method to all platforms. https://bugs.webkit.org/show_bug.cgi?id=40864 Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in platform independent LayoutTestController code. Without this change, layout tests using LayoutTestController tests that use abortModal will become mac specific which is not desirable. * DumpRenderTree/LayoutTestController.cpp: (abortModalCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::abortModal): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::abortModal): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::abortModal): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::abortModal): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::abortModal): 2010-06-25 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41226 Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added. (WTR::InjectedBundle::shared): (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::_didCreatePage): (WTR::InjectedBundle::_willDestroyPage): (WTR::InjectedBundle::_didRecieveMessage): (WTR::InjectedBundle::initialize): (WTR::InjectedBundle::didCreatePage): (WTR::InjectedBundle::willDestroyPage): (WTR::InjectedBundle::didRecieveMessage): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added. (WTR::InjectedBundle::layoutTestController): * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: (WKBundleInitialize): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added. (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::~InjectedBundlePage): (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::_didCommitLoadForFrame): (WTR::InjectedBundlePage::_didFinishLoadForFrame): (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame): (WTR::InjectedBundlePage::_didReceiveTitleForFrame): (WTR::InjectedBundlePage::_didClearWindowForFrame): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didCommitLoadForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): (WTR::InjectedBundlePage::didReceiveTitleForFrame): (WTR::InjectedBundlePage::didClearWindowForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added. (WTR::InjectedBundlePage::page): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added. (WTR::LayoutTestController::create): (WTR::LayoutTestController::LayoutTestController): (WTR::LayoutTestController::~LayoutTestController): (WTR::dumpAsTextCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added. (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 2010-06-25 Sam Weinig Reviewed by Anders Carlsson. Make WebKitTestRunner really work with run-webkit-tests. - Add Forwarding headers to allow some cleanup. * WebKitTestRunner/ForwardingHeaders: Added. * WebKitTestRunner/ForwardingHeaders/wtf: Added. * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added. * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dump): Dump the right number of #EOFs. * WebKitTestRunner/TestInvocation.h: 2010-06-25 Sam Weinig Reviewed by Mark Rowe. Add support for WebKitTestRunner to old-run-webkit-tests - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use. * Scripts/build-webkittestrunner: Added. * Scripts/old-run-webkit-tests: 2010-06-25 Adam Barth Reviewed by David Levin. Incremental build failed on Chromium ews https://bugs.webkit.org/show_bug.cgi?id=41011 The division of responsibility between update-webkit --chromium and build-webkit --chromium is slightly unclear. In this patch, we make build-webkit --chromium also update DEPS and re-run GYP in case the developer has changed either since they updated. This change is also helpful for the EWS, which wants to update DEPS and re-run GYP after applying patches, but the EWS doesn't want to run update-webkit --chromium because it has a dirty working copy. * Scripts/webkitdirs.pm: 2010-06-25 Robert Hogan Reviewed by Simon Hausmann. [Qt] Support evaluateScriptInIsolatedWorld() https://bugs.webkit.org/show_bug.cgi?id=40079 Remove evaluateScriptInIsolatedWorld() from QtWebKit API. Remove QWebScriptWorld from exported headers. Confine support to DumpRenderTreeSupportQt so that the tests can pass. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::evaluateScriptInIsolatedWorld): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-06-25 Anders Carlsson Revert accidental part and add a newline. * MiniBrowser/mac/AppDelegate.m: * MiniBrowser/mac/MiniBrowser_Prefix.pch: 2010-06-25 Anders Carlsson Rubber-stamped by Dan Bernstein. Add a LOG macro that expands to a no-op by default. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/AppDelegate.m: (_didRecieveMessageFromInjectedBundle): * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController windowShouldClose:]): (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didFirstLayoutForFrame): (_didFirstVisuallyNonEmptyLayoutForFrame): (_didBecomeUnresponsive): (_didBecomeResponsive): (_decidePolicyForNavigationAction): (_decidePolicyForNewWindowAction): (_createNewPage): (_showPage): (_closePage): (_didNavigateWithNavigationData): (_didPerformClientRedirect): (_didPerformServerRedirect): (_didUpdateHistoryTitle): * MiniBrowser/mac/MiniBrowser_Prefix.pch: * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): (_didCreatePage): (_willDestroyPage): (_didRecieveMessage): 2010-06-24 Adam Barth Reviewed by Eric Seidel. commit-queue is taking too long to land patches because of red trees https://bugs.webkit.org/show_bug.cgi?id=41194 Instead of checking for the tree to be green, we'll just spin hot trying to land patches. This is probably too extreme in ignoring the tree, but I think we should try it for a while to see if we have trouble. That will help us find the right balance. * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: 2010-06-24 Martin Robinson Reviewed by Xan Lopez. [GTK] Clean up the use of gdk_window_get_root_coords in EventSender https://bugs.webkit.org/show_bug.cgi?id=40843 Define the version for old GTK+s in a way that is forward-compatible and clean up the logic a bit. * DumpRenderTree/gtk/EventSender.cpp: (gdk_window_get_root_coords): Renamed and cleaned up. (prepareMouseButtonEvent): Remove #ifdefs. (mouseMoveToCallback): Remove #ifdefs. 2010-06-24 Dimitri Glazkov Reviewed by Eric Seidel. Fix NewRunWebKitTests to work on Windows. https://bugs.webkit.org/show_bug.cgi?id=41180 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments, because Windows fails to understand what we're asking of it. 2010-06-24 Martin Robinson Reviewed by Xan Lopez. [GTK] The url passed to the WebView during layout tests is invalid https://bugs.webkit.org/show_bug.cgi?id=40832 Set the test URL to the full real file URL and do a small cleanup. Previously a URL like file://relative/path/to/test.html was passed to the WebView. This malformed file URL would be returned by webkit_web_view_get_url and webkit_web_frame_get_url. * DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Change to take a const string& as the argument. (shouldOpenWebInspector): Change to take a const string& as the argument. (shouldEnableDeveloperExtras): Change to take a const string& as the argument. (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable. 2010-06-24 Sam Weinig Reviewed by Anders Carlsson. Fix WebKitTestRunner Makefile typos. * WebKitTestRunner/Makefile: 2010-06-24 Adele Peterson Reviewed by Eric Carlson. DumpRenderTree part of testing "Paste and Match Style" should fire paste events https://bugs.webkit.org/show_bug.cgi?id=41085 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects. 2010-06-23 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=41086 Add new WebKitTestRunner project (ie. DRT for WebKit2). - Mac only. - run-webkit-tests has not been modified to call it yet. - Only dumps the render tree at this time. * WebKitTestRunner: Added. * WebKitTestRunner/Configurations: Added. * WebKitTestRunner/Configurations/Base.xcconfig: Added. * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added. * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added. * WebKitTestRunner/InjectedBundle: Added. * WebKitTestRunner/InjectedBundle-Info.plist: Added. * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added. (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didClearWindow): (_didCreatePage): (_willDestroyPage): (_didRecieveMessage): (WKBundleInitialize): * WebKitTestRunner/Makefile: Added. * WebKitTestRunner/PlatformWebView.h: Added. (WTR::PlatformWebView::platformView): * WebKitTestRunner/TestController.cpp: Added. (WTR::TestController::shared): (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::runTest): (WTR::TestController::runTestingServerLoop): (WTR::TestController::run): * WebKitTestRunner/TestController.h: Added. (WTR::TestController::verbose): (WTR::TestController::injectedBundlePath): * WebKitTestRunner/TestInvocation.cpp: Added. (WTR::createWKURL): (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::~TestInvocation): (WTR::TestInvocation::invoke): (WTR::TestInvocation::dump): (WTR::TestInvocation::initializeMainWebView): (WTR::TestInvocation::didStartProvisionalLoadForFrame): (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame): (WTR::TestInvocation::didCommitLoadForFrame): (WTR::TestInvocation::didFinishLoadForFrame): (WTR::TestInvocation::didFailLoadForFrame): (WTR::TestInvocation::renderTreeExternalRepresentationFunction): (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction): * WebKitTestRunner/TestInvocation.h: Added. * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added. * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added. * WebKitTestRunner/mac: Added. * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added. (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::page): * WebKitTestRunner/mac/TestInvocationMac.mm: Added. (WTR::TestInvocation::runUntil): * WebKitTestRunner/mac/main.mm: Added. (main): 2010-06-24 Luiz Agostini Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-23 Kevin Ollivier [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * wx/build/settings.py: 2010-06-23 James Robinson Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me. * Scripts/webkitpy/common/config/committers.py: 2010-06-23 Kent Tamura Reviewed by Dimitri Glazkov. Correct Chromium test configuration https://bugs.webkit.org/show_bug.cgi?id=41057 * BuildSlaveSupport/build.webkit.org-config/master.cfg: - Add "--use-drt" option for NRWT. It is required for Chromium and ignored for other platforms. - Skip JSC test on Chromium * BuildSlaveSupport/test-result-archive: Add Chromium support. 2010-06-23 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=41073 WebKit2: Flesh out more of the InjectedBundle client API * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFinishLoadForFrame): (_didFailLoadWithErrorForFrame): (_didReceiveTitleForFrame): (_didClearWindowForFrame): (_didCreatePage): (_willDestroyPage): (WKBundleInitialize): 2010-06-23 Yuzo Fujishima Reviewed by Shinichiro Hamaji. Implement page format data programming interface. Add methods for testing. https://bugs.webkit.org/show_bug.cgi?id=37538 * DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (isPageBoxVisibleCallback): (pageAreaRectInPixelsCallback): (preferredPageSizeInPixelsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels): 2010-06-23 Sam Magnuson Reviewed by Shinichiro Hamaji. Follow proper convention for if/switch/while as I've discovered them to be through my review processes. https://bugs.webkit.org/show_bug.cgi?id=40723 Modified test so that if( foo ) is not allowed as it appears not to be the accepted convention. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-06-22 Eric Seidel Reviewed by Adam Barth. Run clean-header-guards to fix some header guards https://bugs.webkit.org/show_bug.cgi?id=41044 No functional changes, thus no tests. This entire change was generated by running clean-header-guards, and then reverting changes to files which shouldn't be changed. Those which are left all should be updated. Some of these changes are just fixing 755 permissions to be 644, since it seems various files have the wrong execute bit which don't need it. clean-header-guards made those (welcome) permission fixes unintentionally. * DumpRenderTree/chromium/WebThemeControlDRT.h: * DumpRenderTree/chromium/WebThemeEngineDRT.h: * QtTestBrowser/fpstimer.h: 2010-06-22 Adam Barth Reviewed by Eric Seidel. Rename HTMLDocumentParser to LegacyHTMLDocumentParser https://bugs.webkit.org/show_bug.cgi?id=41043 Update the hash. * Scripts/do-webcore-rename: 2010-06-22 Sam Magnuson Reviewed by Shinichiro Hamaji. Follow proper convention for variable declaration spacing. https://bugs.webkit.org/show_bug.cgi?id=40724 Modified test so that 'int a;' is not allowed. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-06-22 Eric Seidel Unreviewed. Add Tony Gentilcore now that he's a committer. * Scripts/webkitpy/common/config/committers.py: 2010-06-22 Eric Seidel Reviewed by Adam Barth. Remove Gtk 64-Release bot from core since it's broken https://bugs.webkit.org/show_bug.cgi?id=41022 This bot alone has been responsible for more than 72 hours of commit-queue blockage in the last week. The bot is broken -- keeps losing its display server or similar. Until the Gtk folks can fix the bot, we need to remove it from core. The WebKit community can't keep it green as is. * Scripts/webkitpy/common/net/buildbot.py: * Scripts/webkitpy/common/net/buildbot_unittest.py: 2010-06-21 Dumitru Daniliuc Reviewed by Eric Seidel. Fix the Windows build. https://bugs.webkit.org/show_bug.cgi?id=40972 * DumpRenderTree/win/ImageDiff.vcproj: 2010-06-21 Prasad Tammana Reviewed by Darin Adler, Dmitry Titov. DumpRenderTree should allow tests with modal dialogs https://bugs.webkit.org/show_bug.cgi?id=35350 * DumpRenderTree/LayoutTestController.cpp: (abortModalCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::abortModal): Add abortModal method to LayoutTestController and make it available from script. * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog. (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call abortModal from when modal window closes. (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop. 2010-06-21 Simon Fraser Reviewed by Anders Carlsson. Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea https://bugs.webkit.org/show_bug.cgi?id=40948 Have the script look in WebKit2. * Scripts/do-webcore-rename: 2010-06-21 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html It's a Mac-specific test so just add the required LayoutTestController function as a no-op to avoid failing. Similar approach adopted by other ports. https://bugs.webkit.org/show_bug.cgi?id=33344 * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL): 2010-06-21 Sam Weinig Reviewed by Anders Carlsson. Patch for https://bugs.webkit.org/show_bug.cgi?id=40940 Add message passing support to the WebKit2 API. - Add some test messages. * MiniBrowser/mac/AppDelegate.m: (_didRecieveMessageFromInjectedBundle): (-[BrowserAppDelegate init]): * MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindow): (_didCreatePage): (_didRecieveMessage): (WKBundleInitialize): 2010-06-21 Drew Wilson Unreviewed. Rolling back 61551 and 61555 due to test failures. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): * DumpRenderTree/mac/UIDelegate.mm: 2010-06-21 Anders Carlsson Reviewed by Sam Weinig. Make DumpRenderTree build with clang++ * DumpRenderTree/mac/DumpRenderTreePasteboard.m: (-[LocalPasteboard setPropertyList:forType:]): * DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow keyDown:]): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::elementDoesAutoCompleteForElementWithId): (LayoutTestController::isCommandEnabled): 2010-06-21 Satish Sampath Reviewed by Steve Block. Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. https://bugs.webkit.org/show_bug.cgi?id=40878 * Scripts/build-webkit: 2010-06-21 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Initialization for http/tests/loading/ https://bugs.webkit.org/show_bug.cgi?id=40902 * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): 2010-06-21 Jocelyn Turcotte Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-20 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Add --allow-external-pages option https://bugs.webkit.org/show_bug.cgi?id=40762 Add --allow-external-pages introduced by Chromium r45403. http://src.chromium.org/viewvc/chrome?view=rev&revision=45403 * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest): 2010-06-20 Joseph Pecoraro Reviewed by Adam Barth. Sheriffbot: Should allow "r" in SVN_REVISION https://bugs.webkit.org/show_bug.cgi?id=40889 * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r. 2010-06-20 Joseph Pecoraro Reviewed by Dimitri Glazkov. Python Tests Fail after r61508 https://bugs.webkit.org/show_bug.cgi?id=40891 Test's regex list needed to be updated to match the new regex list in the source code. Added new bots to the example_buildbots list. Regex list fixed in r61512. Updated bot list. * Scripts/webkitpy/common/net/buildbot_unittest.py: 2010-06-20 Dimitri Glazkov Unreviewed, build fix. Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508. * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp. 2010-06-19 Justin Schuh Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-19 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=40882 Add ability to have a WebProcess per WebContext. Move to use new shared contexts API. * MiniBrowser/mac/AppDelegate.h: * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate getCurrentPageNamespace]): (-[BrowserAppDelegate validateMenuItem:]): (-[BrowserAppDelegate _setProcessModel:]): (-[BrowserAppDelegate setSharedProcessProcessModel:]): (-[BrowserAppDelegate setSharedThreadProcessModel:]): * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): 2010-06-02 Robert Hogan Reviewed by Adam Barth. [Qt] Support evaluateScriptInIsolatedWorld() https://bugs.webkit.org/show_bug.cgi?id=40079 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-06-18 Dimitri Glazkov Reviewed by Darin Adler. Add three more non-core Chromium builders to start testing DumpRenderTree. https://bugs.webkit.org/show_bug.cgi?id=40335 * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders. 2010-06-18 Drew Wilson Reviewed by Darin Fisher. [Chromium] Plumbing for top-level frame names https://bugs.webkit.org/show_bug.cgi?id=40430 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): Changed obsolete call to clearName() to use setName(WebString()) instead. 2010-06-18 Sam Weinig Rolling http://trac.webkit.org/changeset/61297 back in. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed. * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added. (_didClearWindow): (_didCreatePage): (WKBundleInitialize): 2010-06-18 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=40803 TestNetscapePlugin has an incorrect implementation of "property" property * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation. 2010-06-18 Leandro Pereira Unreviewed. Adding myself to the committers list. * Scripts/webkitpy/common/config/committers.py: 2010-06-17 Tony Chang Reviewed by Kent Tamura. [chromium] cleanup redundant DEPS value and remove buildbot cleanup code https://bugs.webkit.org/show_bug.cgi?id=40615 * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts 2010-06-17 Ada Chan Rolling out http://trac.webkit.org/changeset/61297 due to build errors. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c. * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed. 2010-06-17 Darin Adler One more try at fix for Chromium build. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use set again instead of =. 2010-06-17 Darin Adler Fix Chromium build. I didn't realize that neither Chromium nor Qt share the DumpRenderTree code with all the other platforms! Wow, that should be fixed at some point. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Changed back to using "new". * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr. 2010-06-17 Simon Hausmann Unreviewed Qt build fix. LayoutTestController in the Qt DRT is not using refs :) * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): 2010-06-17 Darin Adler Reviewed by Sam Weinig. Use adoptRef and create functions in more code paths https://bugs.webkit.org/show_bug.cgi?id=40760 * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::create): Added. * DumpRenderTree/LayoutTestController.h: Declare the create function. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use create instead of new. * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr. * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef instead of new. * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. * DumpRenderTree/wx/DumpRenderTreeWx.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. (MyApp::OnInit): Removed unneeded code to delete the layout test controller. This is done during each test. 2010-06-17 Kent Tamura Reviewed by Shinichiro Hamaji. [DRT/Chromium] Fix a bug of Windows pixel tests https://bugs.webkit.org/show_bug.cgi?id=40763 * DumpRenderTree/chromium/TestEventPrinter.cpp: (TestShellPrinter::handleImage): 2010-06-16 Kent Tamura Reviewed by Shinichiro Hamaji. [DRT/Chromium] Fix crash on Mac Release https://bugs.webkit.org/show_bug.cgi?id=40759 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): We should not use m_canvas directly because it is created lazily in canvas(). 2010-06-16 Kevin Ollivier [wx] Build fix after new method addition. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::pageProperty): 2010-06-16 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Set current working directory for each of tests https://bugs.webkit.org/show_bug.cgi?id=40668 This change fixes tests with eventSender.beginDragWithFiles(). * DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): 2010-06-16 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] r60803 broke media/controls-drag-timebar.html https://bugs.webkit.org/show_bug.cgi?id=40269 Only queue events while the mouse button is down, if drag mode is enabled. Some tests may disable drag mode, to prevent the queuing of events in this situation. * DumpRenderTree/gtk/EventSender.cpp: (sendOrQueueEvent): Only queue events here if dragMode is true. 2010-06-16 Martin Robinson Reviewed by Gustavo Noronha Silva. [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT https://bugs.webkit.org/show_bug.cgi?id=40600 * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME. 2010-06-16 Adam Barth Reviewed by Dimitri Glazkov. Add a hidden land-cowboy command to webkit-patch to help land quick build fixes. * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: 2010-06-16 Adam Roben Convert console messages to UTF-8 before printing them Speculative fix for REGRESSION (r61234): http/tests/security/xssAuditor/embed-tag-null-char.html and http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on Windows. (I can't test the fix because Apache is crashing on my computer.) Reviewed by Alexey Proskuryakov. * DumpRenderTree/win/DumpRenderTree.cpp: (toUTF8): Extracted the code into an overload that takes a wide string and a length, then added an overload that takes a wstring. * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8 overload. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to UTF-8 instead of letting printf convert to the current code page. 2010-06-16 Drew Wilson Reviewed by Kent Tamura. [Chromium] Plumbing for top-level frame names https://bugs.webkit.org/show_bug.cgi?id=40430 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Migrate to new createView() API. * DumpRenderTree/chromium/WebViewHost.h: Remove obsolete createView() methods, add new createView() API that takes a frameName parameter. 2010-06-16 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Scroll wheel event support to graphics based DRT https://bugs.webkit.org/show_bug.cgi?id=40577 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::continuousMouseScrollBy): (EventSender::createGraphicsSceneWheelEvent): * DumpRenderTree/qt/EventSenderQt.h: 2010-06-16 Adam Roben Remove a stray newline from the Windows version of TestNetscapePlugin Reviewed by Alexey Proskuryakov. Fixes plugins/geturlnotify-during-document-teardown.html fails on Windows * DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_Destroy): Removed extra newline that the Mac version doesn't have. 2010-06-16 Adam Roben Respect LayoutTestController::isPrinting on Windows This gets some printing tests closer to passing (like printing/page-rule-in-media-query.html). Fixes . Reviewed by Dan Bernstein. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): Pass LayoutTestController::isPrinting to IWebFramePrivate::renderTreeAsExternalRepresentation. 2010-06-15 Adam Barth Reviewed by Eric Seidel. Enable HTML5 lexer https://bugs.webkit.org/show_bug.cgi?id=40650 * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): 2010-06-10 Yuzo Fujishima Reviewed by Shinichiro Hamaji. Implement render style selection for pages to support CSS3 Paged Media. https://bugs.webkit.org/show_bug.cgi?id=35961 * DumpRenderTree/LayoutTestController.cpp: (parsePagePropertyParameters): (pagePropertyCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageProperty): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageProperty): 2010-06-15 Sam Weinig Reviewed by Anders Carlsson. Fix for https://bugs.webkit.org/show_bug.cgi?id=40630 WebKit2: Add mechanism to inject code into the WebProcess on startup Add initial InjectedBundle support. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: * MiniBrowser/WebBundle-Info.plist: Added. Add test InjectedBundle to the project. * MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): Get the path to the WebBundle from the the main bundle and pass it to the new WKContextCreateWithInjectedBundlePath function. * MiniBrowser/mac/BrowserWindowController.m: (_didChangeProgress): Fix the build. This has been broken for a while. * MiniBrowser/mac/WebBundle: Added. * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added. (_didCreatePage): (WKBundleInitialize): Add really basic InjectedBundle. * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code. 2010-06-15 Dumitru Daniliuc Reviewed by Darin Adler. Adding myself to the reviewers list. https://bugs.webkit.org/show_bug.cgi?id=40693 * Scripts/webkitpy/common/config/committers.py: 2010-06-15 Martin Robinson Reviewed by Xan Lopez. Switch to using GIO methods instead of realpath in GtkLauncher to determine the file URI. This should remove warnings about realpath being undefined when compiling with '-ansi'. * GtkLauncher/main.c: (filenameToURL): Use GIO instead of realpath to determine file URI. 2010-06-15 Adam Roben Remove the redundant set-apple-windows-environment-variables script Apparently update-webkit does this for you these days. Rubber-stamped by Steve Falkenburg. * Scripts/set-apple-windows-environment-variables: Removed. 2010-06-14 Adam Roben Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables Fixes . Reviewed by Steve Falkenburg. * Scripts/set-apple-windows-environment-variables: Added. (to_windows_path): Passes the passed-in path through cygpath to generate a Windows-style path. (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment variables to their defaults, if they aren't already set. 2010-06-14 Adam Roben Speed up run-safari/debug-safari on Windows Fixes . Reviewed by Steve Falkenburg. * Scripts/webkitdirs.pm: (runSafari): When debugging, set up the environment to run Safari using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to actually launch the debugger. When not debugging, just run WebKit.exe and it will do the rest for us. 2010-06-15 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] DRT EventSender support to graphics context events https://bugs.webkit.org/show_bug.cgi?id=40324 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick): 2010-06-14 Tony Chang Reviewed by Darin Fisher. [chromium] checkout chromium third_party directly https://bugs.webkit.org/show_bug.cgi?id=40556 * Scripts/update-webkit-chromium: some migration code for the bots 2010-06-14 Alexey Proskuryakov Chromium build fix. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE. 2010-06-14 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=40529 eventSender.keyDown("delete") incorrectly sends a backspace on some platforms * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those. 2010-06-14 Martin Robinson Reviewed by Xan Lopez. Small GtkLauncher build fix for some systems. * GtkLauncher/main.c: Add include. 2010-06-14 Mahesh Kulkarni Reviewed by Laszlo Gombos. [Qt] navigator.geolocation support for Qt port https://bugs.webkit.org/show_bug.cgi?id=39724 Implementation for geolocation cases to DumpRenderTreeQt * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::allowGeolocationRequest): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::isGeolocationPermissionSet): (LayoutTestController::geolocationPermission): 2010-06-13 Nathan Lawrence Reviewed by Darin Adler. Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to be a way of overwriting the Xcode system path. Making $WEBKITOUTPUTDIR take precedence over the system default would make this possible. * Scripts/webkitdirs.pm: 2010-06-13 Chris Fleizach Reviewed by Darin Adler. AX: link won't return linked element if URL contains # https://bugs.webkit.org/show_bug.cgi?id=40192 * DumpRenderTree/AccessibilityUIElement.cpp: (linkedUIElementAtIndexCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::linkedUIElementAtIndex): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::linkedUIElementAtIndex): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::linkedUIElementAtIndex): 2010-06-13 Adam Barth Reviewed by Darin Adler. webkit-patch should add a bug URL to ChangeLogs if they don't have one yet https://bugs.webkit.org/show_bug.cgi?id=39550 This can cause an extra request to bugs.webkit.org durig upload, but it shouldn't be too bad. Also, this won't work if you remove the boilerplate created by prepare-ChangeLog. * Scripts/webkitpy/common/checkout/changelog.py: * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added. 2010-06-08 Robert Hogan Reviewed by Eric Seidel. [Qt] Add support for callShouldCloseOnWebView() to DRT https://bugs.webkit.org/show_bug.cgi?id=40330 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews): 2010-06-12 Eric Seidel Reviewed by Daniel Bates. do-webcore-rename should have a --verbose option https://bugs.webkit.org/show_bug.cgi?id=40497 * Scripts/do-webcore-rename: - Unified how we handle skipping files/directories this will allow us to "black list" certain files and directories when performing renames. - Made do-webcore-rename log what it's skipping when passed --verbose. 2010-06-12 Darin Adler * Scripts/run-bindings-tests: Fixed a typo in a message. 2010-06-12 Kent Tamura Reviewed by Dimitri Glazkov. [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout https://bugs.webkit.org/show_bug.cgi?id=40402 _build_path() of each Chromium port check existence of build path of Chromium checkout first, then check existence of build path of WebKit-only checkout. * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2010-06-12 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Back-forward list dumping is incorrect https://bugs.webkit.org/show_bug.cgi?id=36392 Support dumping child history items in DRT. Unskip: fast/loader/frame-src-change-added-to-history.html fast/loader/frame-src-change-not-added-to-history.html fast/loader/frame-location-change-not-added-to-history.html * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem): 2010-06-10 Ojan Vafai Reviewed by Eric Seidel. upload all patches that lack in-rietveld to rietveld https://bugs.webkit.org/show_bug.cgi?id=40444 If it's a patch, then we'll try to upload it as long as it doesn't have in-rietveld set. No longer set in-rietveld? since it's not needed. * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-10 Ojan Vafai Reviewed by Darin Fisher. Fix rietveld upload when message length > 100 characters https://bugs.webkit.org/show_bug.cgi?id=40457 * Scripts/webkitpy/common/net/rietveld.py: 2010-06-11 Yael Aharon Reviewed by Laszlo Gombos. [Qt] There should be a way to enable popups in QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=40427 * QtTestBrowser/main.cpp: (LauncherWindow::toggleJavascriptCanOpenWindows): (LauncherWindow::createChrome): 2010-06-10 Adam Barth Reviewed by Daniel Bates. Make SheriffBot more chatty https://bugs.webkit.org/show_bug.cgi?id=40463 People seem to like to talk to SheriffBot, so let's make him chat back. * Scripts/webkitpy/thirdparty/__init__.py: * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added. * Scripts/webkitpy/tool/bot/sheriffircbot.py: * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 2010-06-10 Brian Weinstein Reviewed by Darin Adler. Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server. Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist, and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking WEXITSTATUS on $result instead of just comparing $result to 0. * Scripts/update-webkit-auxiliary-libs: 2010-06-10 Ojan Vafai Reviewed by Alexey Proskuryakov. don't use Exception.message as it's deprecated in python 2.6+ https://bugs.webkit.org/show_bug.cgi?id=40449 * Scripts/webkitpy/tool/commands/queues.py: 2010-06-10 Ojan Vafai Reviewed by Adam Barth. fix handle_script_error in rietveld upload queue and add testing for handle_script_error https://bugs.webkit.org/show_bug.cgi?id=40436 * Scripts/webkitpy/common/system/outputcapture.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-10 Jarkko Sakkinen Reviewed by Simon Hausmann. [Qt] *All* WebGL layout tests fail! https://bugs.webkit.org/show_bug.cgi?id=40296 Added test for WebKitWebGLEnabled to LayoutTestController::overridePreference(). * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): 2010-06-10 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] DRT EventSender support to graphics mouse events activation https://bugs.webkit.org/show_bug.cgi?id=40017 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::keyDown): (EventSender::contextClick): (EventSender::sendTouchEvent): (EventSender::sendOrQueueEvent): (EventSender::eventFilter): (EventSender::createGraphicsSceneMouseEvent): (EventSender::sendEvent): * DumpRenderTree/qt/EventSenderQt.h: (EventSender::isGraphicsBased): 2010-06-09 Adam Barth Reviewed by Ojan Vafai. webkit-patch upload fails for security bugs because there's no rietveld flag https://bugs.webkit.org/show_bug.cgi?id=40309 There's probably a more elegant way of seeing whether the form control exists, but this seems to work. * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-09 Ojan Vafai Reviewed by Adam Barth. make rietveld upload faster and avoid posting to bug on errors https://bugs.webkit.org/show_bug.cgi?id=40389 Only grab the first item of the upload queue instead of trying to compute the whole list upfront (which is O(n) bugzilla lookups!). Also, don't post comments to the bug when uploading fails. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/stepsequence.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-09 Ojan Vafai Reviewed by Adam Barth. Rietveld upload queue fails when setting in-rietveld flag https://bugs.webkit.org/show_bug.cgi?id=40371 Make the comment arguments to set_flag_on_attachment optional and add it to the MockBugzilla. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/tool/bot/queueengine.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/mocktool.py: 2010-06-09 Kenneth Russell Reviewed by Dimitri Glazkov. Rename FloatArray to Float32Array https://bugs.webkit.org/show_bug.cgi?id=40323 Used do-webcore-rename to perform renaming. Manually undid incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp, WebCore/manual-tests/resources/ArrayParameterTestApplet.java and ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran all layout tests on Safari; built Chromium and ran selected WebGL tests. * Scripts/do-webcore-rename: 2010-06-08 Tony Chang Reviewed by David Levin. [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out https://bugs.webkit.org/show_bug.cgi?id=40285 * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-03 Roland Steiner Reviewed by Tamura Kent. Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT https://bugs.webkit.org/show_bug.cgi?id=40052 Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907 * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/TestShellWin.cpp: (platformInit): * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added. (WebKit::): (WebKit::WebThemeControlDRT::WebThemeControlDRT): (WebKit::WebThemeControlDRT::~WebThemeControlDRT): (WebKit::WebThemeControlDRT::box): (WebKit::WebThemeControlDRT::line): (WebKit::WebThemeControlDRT::triangle): (WebKit::WebThemeControlDRT::roundRect): (WebKit::WebThemeControlDRT::oval): (WebKit::WebThemeControlDRT::circle): (WebKit::WebThemeControlDRT::nestedBoxes): (WebKit::WebThemeControlDRT::markState): (WebKit::WebThemeControlDRT::draw): (WebKit::WebThemeControlDRT::drawTextField): (WebKit::WebThemeControlDRT::drawProgressBar): * DumpRenderTree/chromium/WebThemeControlDRT.h: Added. (WebKit::WebThemeControlDRT::): * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added. (WebKit::): (WebKit::WebThemeEngineDRT::paintButton): (WebKit::WebThemeEngineDRT::paintMenuList): (WebKit::WebThemeEngineDRT::paintScrollbarArrow): (WebKit::WebThemeEngineDRT::paintScrollbarThumb): (WebKit::WebThemeEngineDRT::paintScrollbarTrack): (WebKit::WebThemeEngineDRT::paintTextField): (WebKit::WebThemeEngineDRT::paintTrackbar): (WebKit::WebThemeEngineDRT::paintProgressBar): * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added. (WebKit::WebThemeEngineDRT::WebThemeEngineDRT): 2010-06-08 Sheriff Bot Unreviewed, rolling out r60878. http://trac.webkit.org/changeset/60878 https://bugs.webkit.org/show_bug.cgi?id=40349 broke linux build (Requested by tony^work on #webkit). * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-08 Tony Chang Reviewed by David Levin. [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out https://bugs.webkit.org/show_bug.cgi?id=40285 * Scripts/webkitdirs.pm: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2010-06-08 Kenneth Russell Unreviewed, build fix. Fix build breakage from 38145 https://bugs.webkit.org/show_bug.cgi?id=40346 The fix for bug 38145 broke the Chromium Win build because Microsoft's cmath doesn't define log2. Suggested fix by zmo is to change log2(x) to log(x) / log(2). Built and ran WebGL layout tests in Safari on Mac OS X. Changed download mirrors for python-irclib to working ones. * Scripts/webkitpy/thirdparty/__init__.py: 2010-06-08 Fumitoshi Ukai Reviewed by Eric Seidel. old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests https://bugs.webkit.org/show_bug.cgi?id=39058 * Scripts/old-run-webkit-tests: use sourceDir() to find ensure-valid-python in checkPythonVersion() 2010-06-08 Andras Becsi Unreviewed buildfix after r60479. [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK versions other than 2.17.3. * DumpRenderTree/gtk/EventSender.cpp: (getRootCoords): 2010-06-07 Martin Robinson Reviewed by Oliver Hunt. [GTK] Mouse movement should not trigger a replay of saved events in the event sender https://bugs.webkit.org/show_bug.cgi?id=40267 When a mouse button is down, automatically queue mouse motion events and do not play them back until the mouse button is released. This matches the behavior of other ports' EventSenders. * DumpRenderTree/gtk/EventSender.cpp: (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion. (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true. 2010-06-07 Nikolas Zimmermann Reviewed by Sam Weinig. Add CPP bindings generator https://bugs.webkit.org/show_bug.cgi?id=38279 Integrate CPP bindings in run-bindings-tests. * Scripts/run-bindings-tests: 2010-06-04 Tony Gentilcore Reviewed by Ojan Vafai. Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633. https://bugs.webkit.org/show_bug.cgi?id=40183 * Scripts/webkitpy/tool/steps/preparechangelog.py: 2010-06-04 Martin Robinson Unreviewed. Add my new email and IRC nick to committers.py. * Scripts/webkitpy/common/config/committers.py: 2010-06-04 Kinuko Yasuda Unreviewed. Revert changes in json_results_generator.py's _get_svn_revision. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 2010-06-04 Martin Robinson Reviewed by Xan Lopez. [GTK] GtkLauncher should support relative file paths https://bugs.webkit.org/show_bug.cgi?id=39944 Allow GtkLauncher to handle relative file paths passed via command-line arguments. * GtkLauncher/main.c: (filename_to_url): Added. (main): Try to resolve arguments as relative file URLs first. 2010-06-04 Martin Robinson Reviewed by Xan Lopez. [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly https://bugs.webkit.org/show_bug.cgi?id=40182 Instead of invoking signal handlers directly via g_signal_emit_by_name, call gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit without breaking DRT. * DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event. 2010-06-04 Anders Carlsson Reviewed by David Hyatt. Make the editing/spelling/context-menu-suggestions.html test more robust https://bugs.webkit.org/show_bug.cgi?id=40178 Change the contextClick method to return an array of strings describing the context menu items. * DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]): 2010-06-03 Kinuko Yasuda Reviewed by Shinichiro Hamaji. Clean up chromium-specific code from json_results_generator.py. https://bugs.webkit.org/show_bug.cgi?id=39665 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/chromium.py: 2010-06-04 Tony Gentilcore Reviewed by Adam Barth. Utilize new takeFirst() method where appropriate. https://bugs.webkit.org/show_bug.cgi?id=40089 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset): 2010-06-04 Yael Aharon Reviewed by Simon Hausmann. [Qt] QtTestLauncher should allow notifications by default. https://bugs.webkit.org/show_bug.cgi?id=40078 * QtTestBrowser/main.cpp: (NotificationsPermissionController::NotificationsPermissionController): (NotificationsPermissionController::checkPermission): (NotificationsPermissionController::requestPermission): (LauncherWindow::LauncherWindow): 2010-06-04 Tony Gentilcore Reviewed by Adam Barth. Detect whether the user's environment can open a browser. https://bugs.webkit.org/show_bug.cgi?id=40136 Some environments like cygwin silently fail webbrowser.open() causing webkit-patch upload not to display any diff. This detects environments where webbrowser.open() would fail by testing if webbrowser.get() raises an exception. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/confirmdiff.py: 2010-06-03 Tony Gentilcore Reviewed by David Levin. Add dependencies required to link with VS Express 2005. https://bugs.webkit.org/show_bug.cgi?id=40038 Visual Studio implicitly links against these libs. VC++ Express does not. * WebKitAPITest/WebKitAPITestCommon.vsprops: * WinLauncher/WinLauncher.vcproj: 2010-06-03 Fumitoshi Ukai Reviewed by David Levin. bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py https://bugs.webkit.org/show_bug.cgi?id=40105 * Scripts/webkitpy/layout_tests/port/websocket_server.py: - kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running. - fix codecs.open parameters. 2010-06-03 Fumitoshi Ukai Reviewed by Alexey Proskuryakov. old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests https://bugs.webkit.org/show_bug.cgi?id=39058 * Scripts/ensure-valid-python: - Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead. - Add --check-only and --help option. - --check-only option only checks python version and don't try to install Python 2.5. - Set executable bit. * Scripts/old-run-webkit-tests: - Check if it can run the websocket tests by calling ensure-valid-python --check-only. 2010-05-14 Ojan Vafai Reviewed by Adam Barth. add a RietveldUploadQueue to upload in-rietveld? patches to rietveld https://bugs.webkit.org/show_bug.cgi?id=38918 Patches with in-rietveld? get uploaded to rietveld and get marked in-rietveld+. If the upload fails, they are marked in-rietveld- and an error is logged to the bug, like the commit-queue. Also, get rid of --fancy-review and the ability to upload to rietveld using webkit-patch upload/post. * Scripts/webkitpy/common/net/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla_unittest.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/upload.py: * Scripts/webkitpy/tool/commands/upload_unittest.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/options.py: * Scripts/webkitpy/tool/steps/postcodereview.py: 2010-05-24 Ojan Vafai Reviewed by Chris Jerdonek. many webkit-patch commands fail in a non-svn tracking git checkout https://bugs.webkit.org/show_bug.cgi?id=38156 If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master). If neither exists, then error out. This makes webkit-patch work for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit to checkout webkit. The fallback to master is for people who don't do the steps on that page for tracking svn. * Scripts/webkitpy/common/checkout/scm.py: * Scripts/webkitpy/common/checkout/scm_unittest.py: 2010-06-03 Mike Fenton Unreviewed. Reverse e-mail for myself in committers.py to correspond with bugzilla account. * Scripts/webkitpy/common/config/committers.py: 2010-06-03 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: a number of fixes that make InspectorController happy with null redirects. https://bugs.webkit.org/show_bug.cgi?id=40109 * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): 2010-06-02 Tasuku Suzuki Reviewed by Shinichiro Hamaji. [Qt] Fix compilation with QT_NO_PROPERTIES https://bugs.webkit.org/show_bug.cgi?id=38324 * QtTestBrowser/main.cpp: (LauncherWindow::init): 2010-06-02 Diego Gonzalez Reviewed by Kenneth Rohde Christiansen. [Qt] Make possible run DRT with QGraphicsWebView https://bugs.webkit.org/show_bug.cgi?id=40016 Make possible to use a environment variable for switching backend. Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): (WebCore::DumpRenderTree::DumpRenderTree): * DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setGraphicsBased): (WebCore::DumpRenderTree::isGraphicsBased): (WebCore::WebViewGraphicsBased::graphicsView): (WebCore::WebViewGraphicsBased::setPage): * Scripts/old-run-webkit-tests: 2010-06-02 Csaba Osztrogonác Reviewed by Eric Seidel. Slave lost shouldn't be recognized as build failed. https://bugs.webkit.org/show_bug.cgi?id=39282 * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green. * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost. 2010-06-01 Yael Aharon Reviewed by Kenneth Rohde Christiansen. [Qt] Fix the lifecycle of notification objects https://bugs.webkit.org/show_bug.cgi?id=40003 Remove the dependency of notifications on QWebPage. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::requestPermissionCallback): (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::requestPermission): * DumpRenderTree/qt/DumpRenderTreeQt.h: 2010-06-02 Sheriff Bot Unreviewed, rolling out r60559. http://trac.webkit.org/changeset/60559 https://bugs.webkit.org/show_bug.cgi?id=40055 It broke python unit test (Requested by Ossy on #webkit). * Scripts/webkitpy/common/net/buildbot.py: 2010-06-02 Csaba Osztrogonác Reviewed by Eric Seidel. Slave lost shouldn't be recognized as build failed. https://bugs.webkit.org/show_bug.cgi?id=39282 * Scripts/webkitpy/common/net/buildbot.py: 2010-06-02 Tony Gentilcore Reviewed by Eric Seidel. Fix crash caused when assigned_to is disabled https://bugs.webkit.org/show_bug.cgi?id=40039 * Scripts/webkitpy/common/net/bugzilla.py: 2010-06-02 Sterling Swigart Reviewed by David Levin. Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches. https://bugs.webkit.org/show_bug.cgi?id=39906 * Scripts/build-webkit: 2010-06-01 Raine Makelainen Reviewed by Simon Hausmann. Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard): 2010-06-01 Alexey Proskuryakov Reviewed by Mark Rowe. A nicer Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig. 2010-06-01 Alexey Proskuryakov A real Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS for all configurations, not just debug. 2010-06-01 Alexey Proskuryakov Tiger build fix. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Get more mouse tests passing https://bugs.webkit.org/show_bug.cgi?id=39040 Reproduce the logic from the Windows EventSender for mapping button numbers to GDK button numbers. Move this logic to the prepareMouseButtonEvent helper. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Reproduce Windows logic. (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto. 2010-06-01 Alexey Proskuryakov Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=39434 REGRESSION (r59811): Geolocation callbacks cannot be created * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak into subsequent tests. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider. (LayoutTestController::setMockGeolocationError): Ditto. * DumpRenderTree/mac/MockGeolocationProvider.h: Added. * DumpRenderTree/mac/MockGeolocationProvider.mm: Added. (+[MockGeolocationProvider shared]): (-[MockGeolocationProvider dealloc]): (-[MockGeolocationProvider setPosition:]): (-[MockGeolocationProvider setError:]): (-[MockGeolocationProvider registerWebView:]): (-[MockGeolocationProvider unregisterWebView:]): (-[MockGeolocationProvider lastPosition]): (-[MockGeolocationProvider stopTimer]): (-[MockGeolocationProvider timerFired]): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): This delegate method must send a response. I'm not sure what the two-stage check is supposed to achieve, it seems unnecessary. 2010-05-12 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses the GDK event queue entirely, we simply do not send the extra event. * DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. (dispatchEvent): Properly handle GDK_3BUTTON_PRESS. 2010-06-01 Martin Robinson Not reviewed. Build fix. Fix GTK+ build caused by a bad merge. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 Small EventSender cleanups. Consolidate some common code. Style fixes. * DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Added. (contextClickCallback): Use prepareMouseButtonEvent. (mouseDownCallback): Use prepareMouseButtonEvent. (mouseUpCallback): Use prepareMouseButtonEvent. (mouseMoveToCallback): Small style fix. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] Double clicks cause three button press events https://bugs.webkit.org/show_bug.cgi?id=38853 Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test to pause for a specified amount of time. It is used in the processing of drag- -and-drop data as well as to separate distinct mouse double-clicks in some tests. This patch enables tests that rely on the latter behavior to pass. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame. * DumpRenderTree/gtk/EventSender.cpp: (leapForwardCallback): Add support for adjusting the time offset on leapForward(). (contextClickCallback): Use sendOrQueueEvent. (updateClickCount): Take the time offset into account when counting clicks. (mouseDownCallback): Use sendOrQueueEvent. (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. (mouseUpCallback): Use sendOrQueueEvent. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Added. (dispatchEvent): Added. (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. (makeEventSender): Only initialize the EventSender when loading the top frame. * DumpRenderTree/gtk/EventSender.h: Ditto. 2010-06-01 Martin Robinson Reviewed by Xan Lopez. [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot https://bugs.webkit.org/show_bug.cgi?id=39101 Work around timing issues for render tree dumps by pumping the main loop before doing the dump. Resize events are asynchronous in GTK+, so sometimes resize requests are still pending when DRT dumps the tree. * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Pump the main loop before dumping the render tree. 2010-05-31 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Fix crash of a test after another test with multiple windows https://bugs.webkit.org/show_bug.cgi?id=39942 If a test opens multiple windows, focuses on non-main window, and the focused window is closed, TestShell::m_focusedWidget points a deleted object. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeWindow): Clear m_focusedWidget. 2010-05-30 Kent Tamura Reviewed by Dimitri Glazkov. new-run-webkit-tests: Support DRT on Chromium-win https://bugs.webkit.org/show_bug.cgi?id=39810 Add --test-shell flag to DRT/Chromium, and it changes DRT so that it behaves like test_shell about command analysis, printing format, pixel dumping, and timeout handling. chromium.py and chromium_win.py supports the --test-shell flag and DRT/Chromium-win binary names. * DumpRenderTree/DumpRenderTree.gypi: Add new files. * DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Support for test_shell-style command. (main): Introduce --test-shell. * DumpRenderTree/chromium/TestEventPrinter.cpp: Added. * DumpRenderTree/chromium/TestEventPrinter.h: Added. TestEventPrinter class manages stdio output and image output. TestEventPrinter.cpp has two implementations; DRTPrinter and TestShellPrinter. * DumpRenderTree/chromium/TestShell.cpp: Some changes for TestEventPrinter. (TestShell::TestShell): (TestShell::runFileTest): (TestShell::testTimedOut): (TestShell::dump): (TestShell::dumpImage): * DumpRenderTree/chromium/TestShell.h: (TestShell::printer): (TestShell::layoutTestTimeout): (TestShell::layoutTestTimeoutForWatchDog): (TestShell::setLayoutTestTimeout): * DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog(). * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2010-05-30 Robert Hogan Reviewed by Kenneth Rohde Christiansen. [Qt] Enhance Qt DRT implementation to support platform scroll wheel events. https://bugs.webkit.org/show_bug.cgi?id=36004 * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match Scrollbar::pixelsPerLineStep() for DRT testing. (EventSender::mouseScrollBy): Added (EventSender::continuousMouseScrollBy): Added * DumpRenderTree/qt/EventSenderQt.h: 2010-05-28 Adam Barth Reviewed by David Levin. webkit-patch should support CHANGE_LOG_EDIT_APPLICATION https://bugs.webkit.org/show_bug.cgi?id=39546 One sublty is that we want to wait for the user to finish editing the ChangeLog before moving on to the next step. That means we want to pass -W to open. However, if the user is using Xcode to edit the ChangeLog, we don't want them to have to exit the Xcode application. For this reason, we create a new instance of the application with -n. Overall, xed seems like a better solution, so we recommend that too. * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/editchangelog.py: 2010-05-21 Dirk Pranke Reviewed by Ojan Vafai. new-run-webkit-tests: fix handling of Ctrl-C to exit even if some threads are wedged. Also, the script will print the results of the tests completed when the interrupt occurs. https://bugs.webkit.org/show_bug.cgi?id=33238 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/layout_package/printing.py: * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2010-05-28 Darin Adler Ignore more Python messiness. * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore. * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore. * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore. * Scripts/webkitpy/test: Added property svn:ignore. * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore. 2010-05-28 Chris Fleizach Reviewed by Beth Dakin. Adding myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: 2010-05-28 Chris Fleizach Build fix. No review. AX: need to catch NSAccessibilityExceptions in DRT https://bugs.webkit.org/show_bug.cgi?id=39881 It looks like Tiger doesn't like seeing a NSMakeRange inside a @try. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::selectedTextRange): 2010-05-28 Chris Fleizach Reviewed by Darin Adler. AX: need to catch NSAccessibilityExceptions in DRT https://bugs.webkit.org/show_bug.cgi?id=39881 Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions. So DRT should wrap exception handlers around its AX related calls. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (attributesOfElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::ariaOwnsElementAtIndex): (AccessibilityUIElement::ariaFlowToElementAtIndex): (AccessibilityUIElement::disclosedRowAtIndex): (AccessibilityUIElement::selectedRowAtIndex): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::disclosedByRow): (AccessibilityUIElement::stringAttributeValue): (AccessibilityUIElement::boolAttributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::isAttributeSupported): (AccessibilityUIElement::role): (AccessibilityUIElement::subrole): (AccessibilityUIElement::roleDescription): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::orientation): (AccessibilityUIElement::stringValue): (AccessibilityUIElement::language): (AccessibilityUIElement::helpText): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::hierarchicalLevel): (AccessibilityUIElement::ariaIsGrabbed): (AccessibilityUIElement::ariaDropEffects): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::stringForRange): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::rowCount): (AccessibilityUIElement::columnCount): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement): (AccessibilityUIElement::showMenu): (AccessibilityUIElement::press): (AccessibilityUIElement::url): (AccessibilityUIElement::hasPopup): 2010-05-28 Yael Aharon Reviewed by Laszlo Gombos. [Qt] Pass all web notification layout tests https://bugs.webkit.org/show_bug.cgi?id=39146 Mimic Chromium's test_shell security model in Qt's DRT. It makes a list of origins which were granted permission to display notifications, and only those origins can display notifications. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::checkPermissionCallback): (WebCore::requestPermissionCallback): (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::checkPermission): (WebCore::DumpRenderTree::requestPermission): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2010-05-27 Philippe Normand Reviewed by Shinichiro Hamaji. check-webkit-style complains about use of NULL in GTK function calls that require sentinels https://bugs.webkit.org/show_bug.cgi?id=39372 Don't warn about NULL in g_*() calls. Zero can't be used instead for calls like g_build_filename and g_object_get/set. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-05-27 Luiz Agostini Reviewed by Kenneth Rohde Christiansen. [Qt] Platform plugin example https://bugs.webkit.org/show_bug.cgi?id=39489 Exempting directory WebKit/qt/examples/ from style guide. * Scripts/webkitpy/style/checker.py: 2010-05-26 Philippe Normand Reviewed by David Levin. [style] Allow usage of NULL in gst_*_many() https://bugs.webkit.org/show_bug.cgi?id=39740 Don't warn if NULL is used by gst_*_many() functions. Zero can't be used for the reason explained in Bug 32858. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: 2010-05-27 Adam Barth Reviewed by Eric Seidel. Update script to run the normal version of the parser tests. * Scripts/test-html5-parser: 2010-05-27 Adam Barth Reviewed by Eric Seidel. Add HTML5 parser support to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=39815 * Scripts/old-run-webkit-tests: 2010-05-26 Adam Barth Reviewed by Eric Seidel. Make HTML5 lexer not ASSERT when resuming partial parses https://bugs.webkit.org/show_bug.cgi?id=39755 Add webkit-resumer.html to the HTML5 parser test suite. * Scripts/test-html5-parser: 2010-05-24 Tony Chang Reviewed by Kent Tamura. [chromium] setup fonts on chromium linux DRT https://bugs.webkit.org/show_bug.cgi?id=39644 * DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): (platformInit): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): Fix a bug where in release builds, we didn't initialize m_canvas. * DumpRenderTree/chromium/fonts.conf: Added. 2010-05-24 Dirk Pranke Reviewed by Dimitri Glazkov. Re-commit r58765 - it had been rolled out to see if it was causing a perf regression (in r59787 and r59789), but that does not seem to have been the case. https://bugs.webkit.org/show_bug.cgi?id=39605 * DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show): 2010-05-25 Ojan Vafai Reviewed by Chris Jerdonek. remove suppression of rietveld logging https://bugs.webkit.org/show_bug.cgi?id=39693 Now that we only upload to rietveld explicitly, e.g. on the bot or via webkit-patch post-attachment-to-rietveld, we should print all the rietveld logging. It was suppressed before to avoid making webkit-patch upload too noisy. * Scripts/webkitpy/common/net/rietveld.py: 2010-05-25 Antonio Gomes Reviewed by Ojan Vafai. [Qt] Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=39680 Implement LayoutTestController::setEditingBehavior in Qt's DRT. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setEditingBehavior): 2010-05-25 Kevin Ollivier [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setEditingBehavior): * wx/build/settings.py: 2010-05-24 Antonio Gomes Reviewed by Eric Seidel and Kent Tamura (for the Chromium part). editingBehavior settings needs to be set back to a reasonable default between tests https://bugs.webkit.org/show_bug.cgi?id=39433 Similarly to r59861, hard code the default setting during reset for Gtk and Chromium, so that the serialized version of the setting stays in sync with expectations. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2010-05-24 Eric Seidel Reviewed by Adam Barth. webkit-patch land calls scm.changed_files 4 times! https://bugs.webkit.org/show_bug.cgi?id=39584 * Scripts/webkitpy/tool/commands/download_unittest.py: - Assert that we don't call modified_changelogs too often. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: - Use cached changelogs list instead of calling modified_changelogs directly. * Scripts/webkitpy/tool/steps/validatereviewer.py: - ditto. 2010-05-24 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Import layout_test_helper for Windows https://bugs.webkit.org/show_bug.cgi?id=39581 Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added. 2010-05-24 Kent Tamura Reviewed by Dimitri Glazkov. [DRT/Chromium] Reset frame name https://bugs.webkit.org/show_bug.cgi?id=39586 This change fixes about 70 unexpected results. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): 2010-05-24 Marcus Bulach Reviewed by Kent Tamura. [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h https://bugs.webkit.org/show_bug.cgi?id=39587 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationService): 2010-05-24 Robert Hogan Reviewed by Laszlo Gombos. [Qt] DRT Support for removeOriginAccessWhitelistEntry Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html [Qt] DRT Support for removeOriginAccessWhitelistEntry https://bugs.webkit.org/show_bug.cgi?id=39565 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::removeOriginAccessWhitelistEntry): 2010-05-24 Marcus Bulach Reviewed by Ojan Vafai. _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head. https://bugs.webkit.org/show_bug.cgi?id=39603 * Scripts/webkitpy/common/checkout/scm.py: == Rolled over to ChangeLog-2010-05-24 ==