diff options
author | Glenn Kasten <gkasten@google.com> | 2013-07-17 10:10:23 -0700 |
---|---|---|
committer | Glenn Kasten <gkasten@google.com> | 2013-07-29 10:49:59 -0700 |
commit | 3dcd00dddec86a1c5133083ad7ba2265d49c048c (patch) | |
tree | 0cb9279c20e16d3f059739818b71e9b77c185330 | |
parent | b283374cbf79dc5a36f1eef0015d7baf8881792e (diff) | |
download | frameworks_av-3dcd00dddec86a1c5133083ad7ba2265d49c048c.zip frameworks_av-3dcd00dddec86a1c5133083ad7ba2265d49c048c.tar.gz frameworks_av-3dcd00dddec86a1c5133083ad7ba2265d49c048c.tar.bz2 |
Declare methods in binder opcode order
Change-Id: I5f624b7a51ffe1a17a67c056cf984f74e4c56eac
-rw-r--r-- | include/media/IAudioRecord.h | 6 | ||||
-rw-r--r-- | media/libmedia/IAudioRecord.cpp | 23 | ||||
-rw-r--r-- | services/audioflinger/AudioFlinger.h | 3 | ||||
-rw-r--r-- | services/audioflinger/Tracks.cpp | 8 |
4 files changed, 21 insertions, 19 deletions
diff --git a/include/media/IAudioRecord.h b/include/media/IAudioRecord.h index d6e3141..eccc2ca 100644 --- a/include/media/IAudioRecord.h +++ b/include/media/IAudioRecord.h @@ -34,6 +34,9 @@ class IAudioRecord : public IInterface public: DECLARE_META_INTERFACE(AudioRecord); + /* get this tracks control block */ + virtual sp<IMemory> getCblk() const = 0; + /* After it's created the track is not active. Call start() to * make it active. */ @@ -44,9 +47,6 @@ public: * will be processed, unless flush() is called. */ virtual void stop() = 0; - - /* get this tracks control block */ - virtual sp<IMemory> getCblk() const = 0; }; // ---------------------------------------------------------------------------- diff --git a/media/libmedia/IAudioRecord.cpp b/media/libmedia/IAudioRecord.cpp index 0d06e98..4a7de65 100644 --- a/media/libmedia/IAudioRecord.cpp +++ b/media/libmedia/IAudioRecord.cpp @@ -42,6 +42,18 @@ public: { } + virtual sp<IMemory> getCblk() const + { + Parcel data, reply; + sp<IMemory> cblk; + data.writeInterfaceToken(IAudioRecord::getInterfaceDescriptor()); + status_t status = remote()->transact(GET_CBLK, data, &reply); + if (status == NO_ERROR) { + cblk = interface_cast<IMemory>(reply.readStrongBinder()); + } + return cblk; + } + virtual status_t start(int /*AudioSystem::sync_event_t*/ event, int triggerSession) { Parcel data, reply; @@ -64,17 +76,6 @@ public: remote()->transact(STOP, data, &reply); } - virtual sp<IMemory> getCblk() const - { - Parcel data, reply; - sp<IMemory> cblk; - data.writeInterfaceToken(IAudioRecord::getInterfaceDescriptor()); - status_t status = remote()->transact(GET_CBLK, data, &reply); - if (status == NO_ERROR) { - cblk = interface_cast<IMemory>(reply.readStrongBinder()); - } - return cblk; - } }; IMPLEMENT_META_INTERFACE(AudioRecord, "android.media.IAudioRecord"); diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h index 262d194..eee5da5 100644 --- a/services/audioflinger/AudioFlinger.h +++ b/services/audioflinger/AudioFlinger.h @@ -409,10 +409,11 @@ private: int64_t pts); virtual status_t setMediaTimeTransform(const LinearTransform& xform, int target); + virtual status_t setParameters(const String8& keyValuePairs); + virtual status_t onTransact( uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags); - virtual status_t setParameters(const String8& keyValuePairs); private: const sp<PlaybackThread::Track> mTrack; }; diff --git a/services/audioflinger/Tracks.cpp b/services/audioflinger/Tracks.cpp index ad4db98..f87689d 100644 --- a/services/audioflinger/Tracks.cpp +++ b/services/audioflinger/Tracks.cpp @@ -245,10 +245,6 @@ void AudioFlinger::TrackHandle::pause() { mTrack->pause(); } -status_t AudioFlinger::TrackHandle::setParameters(const String8& keyValuePairs) { - return mTrack->setParameters(keyValuePairs); -} - status_t AudioFlinger::TrackHandle::attachAuxEffect(int EffectId) { return mTrack->attachAuxEffect(EffectId); @@ -286,6 +282,10 @@ status_t AudioFlinger::TrackHandle::setMediaTimeTransform( xform, static_cast<TimedAudioTrack::TargetTimeline>(target)); } +status_t AudioFlinger::TrackHandle::setParameters(const String8& keyValuePairs) { + return mTrack->setParameters(keyValuePairs); +} + status_t AudioFlinger::TrackHandle::onTransact( uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags) { |