summaryrefslogtreecommitdiffstats
path: root/media/libstagefright/MPEG4Extractor.cpp
diff options
context:
space:
mode:
authorAndreas Huber <andih@google.com>2009-11-23 14:03:32 -0800
committerAndreas Huber <andih@google.com>2009-11-23 14:06:42 -0800
commit738c4315859395bfeeaae3d4c9d6fb9f414778f1 (patch)
tree914b3e3eb6702df6b62191ca96819f31ee20e1a1 /media/libstagefright/MPEG4Extractor.cpp
parentbfa6b2d7a1be1832ac40ed90aece1834f720b5c6 (diff)
downloadframeworks_av-738c4315859395bfeeaae3d4c9d6fb9f414778f1.zip
frameworks_av-738c4315859395bfeeaae3d4c9d6fb9f414778f1.tar.gz
frameworks_av-738c4315859395bfeeaae3d4c9d6fb9f414778f1.tar.bz2
Make sure the decoder's input buffers are large enough to hold the largest input data. Verify that the setting actually sticks.
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
-rw-r--r--media/libstagefright/MPEG4Extractor.cpp20
1 files changed, 12 insertions, 8 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp
index 9d17064..7969710 100644
--- a/media/libstagefright/MPEG4Extractor.cpp
+++ b/media/libstagefright/MPEG4Extractor.cpp
@@ -635,6 +635,15 @@ status_t MPEG4Extractor::parseChunk(off_t *offset, int depth) {
return err;
}
+ size_t max_size;
+ CHECK_EQ(mLastTrack->sampleTable->getMaxSampleSize(&max_size), OK);
+
+ // Assume that a given buffer only contains at most 10 fragments,
+ // each fragment originally prefixed with a 2 byte length will
+ // have a 4 byte header (0x00 0x00 0x00 0x01) after conversion,
+ // and thus will grow by 2 bytes per fragment.
+ mLastTrack->meta->setInt32(kKeyMaxInputSize, max_size + 10 * 2);
+
*offset += chunk_size;
break;
}
@@ -792,15 +801,10 @@ status_t MPEG4Source::start(MetaData *params) {
mGroup = new MediaBufferGroup;
- size_t max_size;
- status_t err = mSampleTable->getMaxSampleSize(&max_size);
- CHECK_EQ(err, OK);
+ int32_t max_size;
+ CHECK(mFormat->findInt32(kKeyMaxInputSize, &max_size));
- // Assume that a given buffer only contains at most 10 fragments,
- // each fragment originally prefixed with a 2 byte length will
- // have a 4 byte header (0x00 0x00 0x00 0x01) after conversion,
- // and thus will grow by 2 bytes per fragment.
- mGroup->add_buffer(new MediaBuffer(max_size + 10 * 2));
+ mGroup->add_buffer(new MediaBuffer(max_size));
mSrcBuffer = new uint8_t[max_size];