diff options
author | Marco Nelissen <marcone@google.com> | 2014-10-05 13:15:16 -0700 |
---|---|---|
committer | Marco Nelissen <marcone@google.com> | 2014-10-06 12:45:25 -0700 |
commit | c68cc33cd94cfc97c2a7b57955ce18b0ff931f19 (patch) | |
tree | 5d399af33f93be1839b34913ef15f46287997093 /media | |
parent | af1a4dc989d6707116eaefab300ad55124aace66 (diff) | |
download | frameworks_av-c68cc33cd94cfc97c2a7b57955ce18b0ff931f19.zip frameworks_av-c68cc33cd94cfc97c2a7b57955ce18b0ff931f19.tar.gz frameworks_av-c68cc33cd94cfc97c2a7b57955ce18b0ff931f19.tar.bz2 |
Recover from errors
When the AAC decoder encounters an error, the lists of submitted
and consumed sizes need to be resynchronized, to prevent timestamp
drift.
Bug: 17638652
Change-Id: Ia6d5f48dc36be355803589e4a5796b01559942b8
Diffstat (limited to 'media')
-rw-r--r-- | media/libstagefright/codecs/aacdec/SoftAAC2.cpp | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/media/libstagefright/codecs/aacdec/SoftAAC2.cpp b/media/libstagefright/codecs/aacdec/SoftAAC2.cpp index 1b6eac4..40925fd 100644 --- a/media/libstagefright/codecs/aacdec/SoftAAC2.cpp +++ b/media/libstagefright/codecs/aacdec/SoftAAC2.cpp @@ -654,6 +654,7 @@ void SoftAAC2::onQueueFilled(OMX_U32 /* portIndex */) { inHeader->nOffset += inBufferUsedLength; AAC_DECODER_ERROR decoderErr; + int numLoops = 0; do { if (outputDelayRingBufferSpaceLeft() < (mStreamInfo->frameSize * mStreamInfo->numChannels)) { @@ -661,20 +662,19 @@ void SoftAAC2::onQueueFilled(OMX_U32 /* portIndex */) { break; } - int numconsumed = mStreamInfo->numTotalBytes + mStreamInfo->numBadBytes; + int numConsumed = mStreamInfo->numTotalBytes; decoderErr = aacDecoder_DecodeFrame(mAACDecoder, tmpOutBuffer, 2048 * MAX_CHANNEL_COUNT, 0 /* flags */); - numconsumed = (mStreamInfo->numTotalBytes + mStreamInfo->numBadBytes) - numconsumed; - if (numconsumed != 0) { - mDecodedSizes.add(numconsumed); - } + numConsumed = mStreamInfo->numTotalBytes - numConsumed; + numLoops++; if (decoderErr == AAC_DEC_NOT_ENOUGH_BITS) { break; } + mDecodedSizes.add(numConsumed); if (decoderErr != AAC_DEC_OK) { ALOGW("aacDecoder_DecodeFrame decoderErr = 0x%4.4x", decoderErr); @@ -716,6 +716,15 @@ void SoftAAC2::onQueueFilled(OMX_U32 /* portIndex */) { aacDecoder_SetParam(mAACDecoder, AAC_TPDEC_CLEAR_BUFFER, 1); + // After an error, replace the last entry in mBufferSizes with the sum of the + // last <numLoops> entries from mDecodedSizes to resynchronize the in/out lists. + mBufferSizes.pop(); + int n = 0; + for (int i = 0; i < numLoops; i++) { + n += mDecodedSizes.itemAt(mDecodedSizes.size() - numLoops + i); + } + mBufferSizes.add(n); + // fall through } |