diff options
author | Eric Laurent <elaurent@google.com> | 2010-07-19 06:24:46 -0700 |
---|---|---|
committer | Eric Laurent <elaurent@google.com> | 2010-07-19 06:31:30 -0700 |
commit | f997cabca292d70d078ae828e21c28e6df62995f (patch) | |
tree | 8e82ee801d8465366f659028f7105ee3ca38d4cc /media | |
parent | 46bf665ea3687f06069ebd1a0acd01ed7b5ac9cb (diff) | |
download | frameworks_av-f997cabca292d70d078ae828e21c28e6df62995f.zip frameworks_av-f997cabca292d70d078ae828e21c28e6df62995f.tar.gz frameworks_av-f997cabca292d70d078ae828e21c28e6df62995f.tar.bz2 |
Fixed problems in audio effect volume control.
Fixed the following problems in audio effect volume control in AudioFlinger:
- Make sure that the volumes returned by EffectChain::setVolume_l() are correct even is
no change is detected since last call
- Do not use isEnabled() to validate volume control but mState >= ACTIVE instead as the volume control
must be also active in STOPPING and STOPPED states.
Change-Id: Id62da3164fad500ee8a5efd6cd78c77e8fdcb541
Diffstat (limited to 'media')
-rw-r--r-- | media/libeffects/visualizer/EffectVisualizer.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/media/libeffects/visualizer/EffectVisualizer.cpp b/media/libeffects/visualizer/EffectVisualizer.cpp index bcda06e..ec13557 100644 --- a/media/libeffects/visualizer/EffectVisualizer.cpp +++ b/media/libeffects/visualizer/EffectVisualizer.cpp @@ -230,9 +230,6 @@ extern "C" int Visualizer_process( if (pContext == NULL) { return -EINVAL; } - if (pContext->mState != VISUALIZER_STATE_ACTIVE) { - return -ENODATA; - } if (inBuffer == NULL || inBuffer->raw == NULL || outBuffer == NULL || outBuffer->raw == NULL || @@ -269,6 +266,9 @@ extern "C" int Visualizer_process( memcpy(outBuffer->raw, inBuffer->raw, outBuffer->frameCount * 2 * sizeof(int16_t)); } } + if (pContext->mState != VISUALIZER_STATE_ACTIVE) { + return -ENODATA; + } return 0; } // end Visualizer_process |