diff options
author | Eino-Ville Talvala <etalvala@google.com> | 2016-01-13 10:07:04 -0800 |
---|---|---|
committer | Eino-Ville Talvala <etalvala@google.com> | 2016-01-13 16:39:53 -0800 |
commit | c4003965258404a19b99280ac0f475e2f290bf27 (patch) | |
tree | c9a4ed77bfc9c2d5b677ffb4943e657b215e04e1 /services/camera/libcameraservice/CameraService.h | |
parent | a39f9818759155a2651995d6844f9821d83e3f0d (diff) | |
download | frameworks_av-c4003965258404a19b99280ac0f475e2f290bf27.zip frameworks_av-c4003965258404a19b99280ac0f475e2f290bf27.tar.gz frameworks_av-c4003965258404a19b99280ac0f475e2f290bf27.tar.bz2 |
Camera: Disallow dumping clients directly
Camera service dumps should only be initiated through
ICameraService::dump.
Bug: 26265403
Change-Id: If3ca4718ed74bf33ad8a416192689203029e2803
Diffstat (limited to 'services/camera/libcameraservice/CameraService.h')
-rw-r--r-- | services/camera/libcameraservice/CameraService.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/services/camera/libcameraservice/CameraService.h b/services/camera/libcameraservice/CameraService.h index b56c161..3905d62 100644 --- a/services/camera/libcameraservice/CameraService.h +++ b/services/camera/libcameraservice/CameraService.h @@ -84,6 +84,9 @@ public: // Default number of messages to store in eviction log static const size_t DEFAULT_EVENT_LOG_LENGTH = 100; + // Event log ID + static const int SN_EVENT_LOG_ID = 0x534e4554; + // Implementation of BinderService<T> static char const* getServiceName() { return "media.camera"; } @@ -189,7 +192,10 @@ public: return mRemoteBinder; } - virtual status_t dump(int fd, const Vector<String16>& args) = 0; + // Disallows dumping over binder interface + virtual status_t dump(int fd, const Vector<String16>& args); + // Internal dump method to be called by CameraService + virtual status_t dumpClient(int fd, const Vector<String16>& args) = 0; // Return the package name for this client virtual String16 getPackageName() const; |