| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \
| |/ /
| | /
| |/
|/|
| |
| | |
NULL interfaces"
* commit '7b28e4e709fcc90f9ca5ca987e2d4e8c05d1a731':
Camera: Guard against asBinder() calls on NULL interfaces
|
| |
| |
| |
| |
| | |
Bug: 18207548
Change-Id: I9879c9b4c0282a6b96b77398f62beedc47f7f0a0
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Passes the BufferItem for the queued buffer to the onFrameAvailable
callback so the consumer can track the BufferQueue's contents.
Bug: 18111837
Change-Id: If9d07229c9b586c668e5f99074e9b63b0468feb0
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Fix the wrong assumption that active array size equals to pixel array
size.
bug 17918247
Change-Id: Ic308f281fb677332a74e95abb473c5b13063eeca
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The threads shutting down may have callpaths that require taking the
binder interface mutex, so waiting to join them with that mutex held
can lead to deadlocks.
A specific instance is StreamingProcessor calling dataCallbackTimestamp,
which can immediately lead to a Camera2Client::releaseRecordingFrame call,
which requires the binder interface mutex. If this call happens right when
shutdown is occurring, and Camera2Client::disconnect is holding the mutex,
deadlock ensues.
Bug: 17997578
Change-Id: I71253cd5542b5920ad205976d315110ca0043d94
|
|
|
|
|
|
|
|
|
|
|
|
| |
When mediaRecorder starts without an active preview stream, Camera2Client
starts preview then immediately start recording, which could cause the second
configure_streams to call into HAL before any preview request is sent. This
could cause HAL to run into bad state. This change work around this issue
by making sure the first preview request is submitted to the HAL before
start recording.
Bug: 17915062
Change-Id: I94ae64ee76487603695a469240da601ddcb29a66
|
|
|
|
|
| |
Bug: 17682603
Change-Id: I7cba3365d00c33cf4267b1b59a94bd7d0bba08df
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Do not idle device before video snapshot stream configuration, to
avoid deadlock during waiting.
- Do not tear down ZSL stream
- Don't refresh ZSL stream after deletion was requested.
The v2 HAL implementations really don't like the ZSL stream being
touched ever.
Bug: 17634430
Bug: 17628507
Change-Id: I36b44a395e697be9802c4bd917a82b77c8d04be2
|
|
|
|
|
|
|
|
| |
Sometimes it's useful to ensure variables are initialized in
all code paths.
Bug: 17680416
Change-Id: I9bed8a3bcb94417384bf0551fe1c0eee6cc49577
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we set FLASH_MODE_OFF for FLASH_MODE when a flash unit
isn't available. However, per the API documentation, the key has to
be null instead.
- Make sure that the flash mode and supported flash mode keys are null
if there's no flash unit on start
- Don't set flash mode in later setParameters calls if there is no
flash unit
- Map NULL value for flash mode key to FLASH_MODE_OFF for internal
consistency.
Bug: 17660716
Change-Id: I3033682f0b882b8c2004114e2afef31662caebda
|
|
|
|
|
| |
Bug: 17555612
Change-Id: Ife33da712fbc8dc44d81e1e869fc75fb21026204
|
|
|
|
|
|
|
|
|
| |
ZSL counts on good auto focus (CAF). It is really tricky to enable ZSL for
manual focus mode. as it is bascically a locked focus mode, you can not tell
if the focus is good or not by reading the afstate.
Bug: 17577928
Change-Id: I68ff7d143e7d56f942bb00a8da6a9faea57b52a0
|
|
|
|
|
|
|
|
| |
Handle one more corner case.
Also remove redundant re-try path.
Bug: 17484683
Change-Id: I0b3e1223f4f28022e7ec6abe028ca3c2623829de
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Don't allow uncalibrated cameras to list a fixed focus mode for
variable-focus cameras, since uncalibrated cameras cannot do INFINITY
focus.
Bug: 17492043
Change-Id: I5835efd6f21be0ebb74a9b7ea3ef5b2e7cf63e7a
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Update ZSL processing tags according the still capture template
Also cache the request template to avoid extra cost of querying
into HAL every time.
Bug: 17463102
Change-Id: I2eeffefb0a4131c99a85dd3e4484cc6f0f025efa
|
|\ \
| |/
| |
| | |
devices" into lmp-dev
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Limit preview resolutions to a max of 1920x1920 instead of 1920x1080p,
so that any aspect ratio with a 1920 as the larger dimension can be used.
Also improve the initial preview/video size selection logic, to ensure
that the selected size is both a valid preview and video size, and not
too large.
Bug: 17458832
Change-Id: Iea006fadb5fbf0f03d23c3c5babb5b3611469688
|
|\ \ |
|
| |/
| |
| |
| |
| | |
Bug: 17484683
Change-Id: I09bb12698057555329286c777102b9b310452fb3
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Bug: 17290106
Change-Id: I08ac1659d0367613c37669d5bf6e6bf7b2b63bc2
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
1. Clear ZSL queue when focus mode is changed and autoFocus is
cancelled.
2. Do not check focus state is focus mode is fixed.
Bug: 17185356
Change-Id: I2cb10fb457b080f0db950c894e56995f638e147b
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| | |
After ZSL queue is cleared, don't add capture result to ZSL queue
if its corresponding buffer has been cleared.
Bug: 17185356
Change-Id: Iddac39ab09b2560e2ce9390895927217c1736d5a
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Bug: 15408128
- Lazily destroy ZSL stream when ZslProcessor is updated, or
when the camera client is disconnected, allowing HAL 2.*
devices that rely on the ZSL stream to capture video snapshots
to function correctly.
Change-Id: Ia5cf14c62acda4d9c640440dc5b8e0796dc0b3fa
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When recording fails to start due to stream configuration failed,
try configure stream again by setting jpeg stream to video size.
Bug: 16162133
Change-Id: Ib20271e787ae07719ce419f0b15c7f86434f7ebb
|
|\ \ \
| |_|/
|/| | |
|
| |/
| |
| |
| |
| |
| |
| | |
It is legal to transit to CONVERGED or FLASH_REQUIRED after a AE precapture
trigger.
Bug: 17365185
Change-Id: Id041eff5eac564c32d09b547a0139d24807336f4
|
|\ \
| |/
|/|
| | |
lmp-dev
|
| |
| |
| |
| |
| | |
Bug: 16986293
Change-Id: Icb68254d7ed1812fa9e60342749a2746d6fcfb17
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Zsl buffer needs to be longer than metadata queue to ensure that
oldest metadata can always find a match in buffer queue.
Since we don't want to add memory overhead, decrease metadata
queue size by one serves the same purpose.
bug 17264283
Change-Id: Ic53441cc29c98e57d3345f5845d92839d0ce6faf
|
|/
|
|
|
|
|
|
|
|
|
| |
ZSLProcessor3 shouldn't acquire mInputMutex in onBufferReleased call for output
buffers, because the caller (Camera3Stream::returnBuffer) holds the camera3
stream lock already. This could cause deadlock for ZSL reprocess request as it
holds the ZSLProcessor3 input lock and try to acquire camera3 stream lock to
submit the request.
Bug: 17299038
Change-Id: I6a7bf8ebd7c2064852358c655f3a3e9a67769213
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If there is no focuser, don't check AF state while picking ZSL
candidate frames.
bug 17164077
Change-Id: Ib56e260249dcfb1b3bafea22abeb3abeae4e2c1a
|
|/
|
|
|
|
|
|
|
|
|
| |
When using the connectLegacy binder interface (available only
through an @hide java api), then consider the camera to be in the
camera2 api legacy mode.
In legacy mode, allow disabling the shutter sound unconditionally.
Bug: 17109582
Change-Id: Ieb3fc61ff111d792cc657c018e278349c25472cf
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Do not list infinity focus mode if the focuser is not calibrated.
bug 13933979
Change-Id: I677ed22305703ac09eeaf986f5bc2a680cececd8
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
As a workaround, duplicate CameraParameters into CameraParameters2 to
prevent ABI break for some camera HALs that directly link into
CameraParameters.
CameraParameters2 implements the real fixes needed in the framework,
while CameraParameters is left in to satisfy older camera HALs.
Bug: 12609188
Bug: 16654949
Change-Id: I82ea6f5de2183dd046d4bf5683600c97f37ab4da
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Ignore the video size parameter change when recording is active.
Bug: 16524513
Change-Id: I55b7c961c06199764486f48bc2187838c2279606
|
|\ \
| | |
| | |
| | | |
anytime" into lmp-dev
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes a crash if the camera was locked by the media recorder and
another process tried to get the legacy parameters (for the camera
characteristics).
Bug: 16695955
Change-Id: I945a16a686a6987150c8754b5296353e76e5afa0
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| | |
- Only one place calculating the jpeg size-the device layer, Camera2Device and
Camera3Device.
- Remove size argument for CameraDeviceBase and cleanup related code.
Bug: 14327010
Change-Id: I45d2ab4859ee0cc9273e579254f0569108c748f1
|
|/
|
|
|
| |
Bug: 16569983
Change-Id: I65e604e382ac0b98777155ad480ec3f6071e1a76
|