| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Zsl buffer needs to be longer than metadata queue to ensure that
oldest metadata can always find a match in buffer queue.
Since we don't want to add memory overhead, decrease metadata
queue size by one serves the same purpose.
bug 17264283
Change-Id: Ic53441cc29c98e57d3345f5845d92839d0ce6faf
|
|\ \ \
| |_|/
|/| | |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ZSLProcessor3 shouldn't acquire mInputMutex in onBufferReleased call for output
buffers, because the caller (Camera3Stream::returnBuffer) holds the camera3
stream lock already. This could cause deadlock for ZSL reprocess request as it
holds the ZSLProcessor3 input lock and try to acquire camera3 stream lock to
submit the request.
Bug: 17299038
Change-Id: I6a7bf8ebd7c2064852358c655f3a3e9a67769213
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add more error codes to the binder camera2 callbacks
- Translate HAL errors to callback errors
- When flushing, report failures for queued requests
- Treat stream config failure as nonfatal
- Send request errors when buffers aren't available for captures
Bug: 15524101
Bug: 14448494
Bug: 11272459
Bug: 17160301
Change-Id: I81aa54e805a9cce1cb8a6a9374549daa7666deb2
|
|
|
|
|
|
|
|
|
|
| |
This check doesn't work with ZSL use case. Since the ZSL is both an input and
output stream, When an input buffer is acquired, checking the handout buffer
count for that stream could trigger false alarm when all the output buffers
are sent to hal, instead, we should wait for an output buffer to return.
Bug: 17188380
Change-Id: I7eb166eb49d2f063189d993195ef389d2cf4f2b4
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix missing triggerId introduced by previous cleanup change.
bug 17108154
bug 17053130
Change-Id: Ifda55d5fbe992d98f335a8427aa256d78a856586
|
|\ \
| | |
| | |
| | | |
into lmp-dev
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This makes the configuration more eager (no more waiting until the first
request) and also allows any errors to immediately be sent back to the
client.
Bug: 16629195
Change-Id: I0c365bc8f760466916dcc089217a43c43f9f4c9d
|
|\ \ \
| |/ /
|/| | |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
If there is no focuser, don't check AF state while picking ZSL
candidate frames.
bug 17164077
Change-Id: Ib56e260249dcfb1b3bafea22abeb3abeae4e2c1a
|
| |
| |
| |
| |
| |
| |
| | |
camera3_device_t::register_stream must always be NULL in HAL3.2+ cameras
Bug: 13914251
Change-Id: I116ee71135a827c8b4db61cd91f56ba56da3f0ef
|
|/
|
|
|
|
|
|
|
|
|
| |
When using the connectLegacy binder interface (available only
through an @hide java api), then consider the camera to be in the
camera2 api legacy mode.
In legacy mode, allow disabling the shutter sound unconditionally.
Bug: 17109582
Change-Id: Ieb3fc61ff111d792cc657c018e278349c25472cf
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Do not list infinity focus mode if the focuser is not calibrated.
bug 13933979
Change-Id: I677ed22305703ac09eeaf986f5bc2a680cececd8
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
As a workaround, duplicate CameraParameters into CameraParameters2 to
prevent ABI break for some camera HALs that directly link into
CameraParameters.
CameraParameters2 implements the real fixes needed in the framework,
while CameraParameters is left in to satisfy older camera HALs.
Bug: 12609188
Bug: 16654949
Change-Id: I82ea6f5de2183dd046d4bf5683600c97f37ab4da
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Ignore the video size parameter change when recording is active.
Bug: 16524513
Change-Id: I55b7c961c06199764486f48bc2187838c2279606
|
|\ \
| | |
| | |
| | | |
anytime" into lmp-dev
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes a crash if the camera was locked by the media recorder and
another process tried to get the legacy parameters (for the camera
characteristics).
Bug: 16695955
Change-Id: I945a16a686a6987150c8754b5296353e76e5afa0
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| | |
- Only one place calculating the jpeg size-the device layer, Camera2Device and
Camera3Device.
- Remove size argument for CameraDeviceBase and cleanup related code.
Bug: 14327010
Change-Id: I45d2ab4859ee0cc9273e579254f0569108c748f1
|
|/
|
|
|
| |
Bug: 16569983
Change-Id: I65e604e382ac0b98777155ad480ec3f6071e1a76
|
|
|
|
|
|
|
| |
Make sure ZSL and recording stream does not exist at the same
time.
Change-Id: I19e28dedd9dd5cc5118449860b612a5c950fdaec
|
|
|
|
| |
Change-Id: I3be5a720ac8b488d1e507c606a9146480faeef63
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactor where availability listeners are called to centralize behavior,
ensuring that all client creation/destruction invokes the listeners
- Clean up some of the client hierarchy
- Filter error codes from key HAL calls to ensure proper reporting
Bug: 16514157
Bug: 16483222
Change-Id: I59875a865b6a508b47423946c78862da8df34cd1
|
|
|
|
|
|
|
|
|
| |
Also override the disconnectLocked method in Camera3ZslStream to make sure the
Camera3ZslStream specific buffer queue is cleaned up properly.
Also revert 0be123df1897fd3fe1b7ba30f24d8ae4c91b4dc7, as it was not the right
fix.
Change-Id: I89bdcb2e206379ae1f2602421e7fdbcde9a31399
|
|\
| |
| |
| | |
into lmp-dev
|
| |
| |
| |
| |
| |
| | |
Otherwise, the metadata entries will be duplicated.
Change-Id: If0cd96e09960fdf746a70913d380e9036745a944
|
| |
| |
| |
| |
| |
| |
| | |
not clearing the queue here will eat up unnecessary memory every time
we switch from video to still mode.
Change-Id: I279ec709b485ca0dab672464e5b829be849bcaa5
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Remove recording stream every time stopPreview is called.
Change-Id: Iabb783a75418aa41ddc2693cfdfd5a2131109070
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Enable the normal partial result path for HAL3.2, the quirk is only used
for the HAL version lower than HAL3.2. The partial quirks is no longer supported
for HAL3.2 or higher versions.
- Add CameraDeviceBase getDeviceVersion API.
- Fix some build warnings
Change-Id: I7a1b03d4d5fd5258d2addfba4368bee2ba691337
|
|/
|
|
|
| |
Bug: 15116722
Change-Id: I3fcc9aea38afcbd665f86c511a9929fe9a6a3a8f
|
|
|
|
|
|
| |
Also fix the warning condition in input buffer return path.
Change-Id: I90e9edc1db9f1de87bc8936000b00c3306160c71
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
native_window_set_buffers_geometry is deprecated, but
__set_buffers_geometry is still used for device1 camera
support.
replace deprecated call with its equivalent combination of
native_window_set_buffers_dimensions and
native_window_set_buffers_format.
Change-Id: I4940367dcae6049451508bfdfc11c16907ec1afc
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is to WAR the case where HAL sends non-NULL input_buffer in capture
result even capture framework doesn't send input buffer in the request.
It's very likely the input_buffer is uninitialized, and we shouldn't
use it. Log a warning for such case as well.
Bug: 16115675
Bug: 16117312
Change-Id: Ib299b45fbfe084059a9f546ded239c8094b039e2
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Return input buffer in capture result. Per hal3.2 spec, we should return the
input buffer in process capture result rather than immediately after process
capture request.
- Make the depths of mZslQueue and mFrameList the same. It doesn't make sense
mFrameList depth is larger than mZslQueue depth.
- Set the depths of mZslQueue and mFrameList based on pipelineMaxDepth.
- Clear result queue while clearing zsl buffer queue.
- Hook up camera3 buffer listener with ZslProcessor3, make sure that adding the
same listener multiple times has no effect.
- Remove flush call in pushToReprocess, it is a guaranteed deadlock once
camera3 buffer listener is hooked up.
Change-Id: I285155ab4241e827145855d628f8e98b881c01d5
|
|
|
|
|
|
|
|
|
|
|
|
| |
FrameProcessorBase allows register the same metadata result listener multiple
times with the same range IDs, which causes the same metadata result is
delivered multiple times for the same listener. This is problematic as client
like ZslProcessor's updateStream is called multiple times between captures, and
each updateStream calls registerListener unconditionally. The the ZSL metadata
result queue will be flooded with same metadata result multiple times and the
number of same result will keep growing until the queue is full.
Change-Id: I2ff7808e5dce61068a7111e7fbbce2aba95198cd
|
|
|
|
|
|
|
|
|
| |
ZSL clients expect each received result as a complete result, and send back to
HAL as a reprocess capture request. CaptureSequencer client assumes results to
be non-partial too, it need look into some metadata that may not be present in
partial results.
Change-Id: Id716913fd6e1c914726abd6610fddf91141783c2
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The following two tags are deprecated from HAL 3.2:
ANDROID_CONTROL_AF_TRIGGER_ID
ANDROID_CONTROL_AE_PRECAPTURE_ID
Trigger IDs are now internal to camera service.
Change-Id: Iaebd62ecb0905a811fa37fe7850e0221c38a0006
|
|/
|
|
|
| |
Bug: 15284653
Change-Id: I4778e8443945d918801102ba600874568bde12dc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting from device version 3.2, the following tags:
ANDROID_SCALER_AVAILABLE_FORMATS
ANDROID_SCALER_AVAILABLE_JPEG_MIN_DURATIONS
ANDROID_SCALER_AVAILABLE_JPEG_SIZES
ANDROID_SCALER_AVAILABLE_PROCESSED_MIN_DURATIONS
ANDROID_SCALER_AVAILABLE_PROCESSED_SIZES
ANDROID_SCALER_AVAILABLE_RAW_MIN_DURATIONS
ANDROID_SCALER_AVAILABLE_RAW_SIZES
are deprecated and replaced by:
ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS
Change-Id: Iadc34af0ea985a16a25759d7a9a3eb4845c486fd
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Decrement the counter for those repeating requests never
sent to device.
Change-Id: I2064e51cb5d509d86dbde4a89e8157de33f574b0
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is dangerous to release all recording buffers when recording stream is
actively sending buffer to encoder. This change only releases all buffers when
recording stream is idle and recording stream is about to start.
Bug: 15667833
Change-Id: Ia4a84cac84a2062c13333467c66698273ffb0e23
|
| | |
| | |
| | |
| | | |
Change-Id: I168332a0d4699f6f5597d4883342aa7af7ed92c6
|