From f78aee70d15daf4690de7e7b4983ee68b0d1381d Mon Sep 17 00:00:00 2001 From: Glenn Kasten Date: Wed, 4 Jan 2012 11:00:47 -0800 Subject: Use audio_mode_t consistently It was int or uint32_t. Also make getMode() const. Change-Id: Ibe45aadbf413b9158e4dd17f2b3bcc6355288d37 --- include/media/AudioSystem.h | 6 +++--- include/media/IAudioFlinger.h | 2 +- include/media/IAudioPolicyService.h | 2 +- media/libmedia/AudioSystem.cpp | 4 ++-- media/libmedia/IAudioFlinger.cpp | 4 ++-- media/libmedia/IAudioPolicyService.cpp | 4 ++-- services/audioflinger/AudioFlinger.cpp | 10 +++++----- services/audioflinger/AudioFlinger.h | 12 ++++++------ services/audioflinger/AudioPolicyService.cpp | 2 +- services/audioflinger/AudioPolicyService.h | 2 +- 10 files changed, 24 insertions(+), 24 deletions(-) diff --git a/include/media/AudioSystem.h b/include/media/AudioSystem.h index 6a15f6e..9369078 100644 --- a/include/media/AudioSystem.h +++ b/include/media/AudioSystem.h @@ -62,8 +62,8 @@ public: static status_t setStreamMute(int stream, bool mute); static status_t getStreamMute(int stream, bool* mute); - // set audio mode in audio hardware (see audio_mode_t) - static status_t setMode(int mode); + // set audio mode in audio hardware + static status_t setMode(audio_mode_t mode); // returns true in *state if tracks are active on the specified stream or has been active // in the past inPastMs milliseconds @@ -142,7 +142,7 @@ public: // static status_t setDeviceConnectionState(audio_devices_t device, audio_policy_dev_state_t state, const char *device_address); static audio_policy_dev_state_t getDeviceConnectionState(audio_devices_t device, const char *device_address); - static status_t setPhoneState(int state); + static status_t setPhoneState(audio_mode_t state); static status_t setRingerMode(uint32_t mode, uint32_t mask); static status_t setForceUse(audio_policy_force_use_t usage, audio_policy_forced_cfg_t config); static audio_policy_forced_cfg_t getForceUse(audio_policy_force_use_t usage); diff --git a/include/media/IAudioFlinger.h b/include/media/IAudioFlinger.h index 9e3cb7f..b4a1970 100644 --- a/include/media/IAudioFlinger.h +++ b/include/media/IAudioFlinger.h @@ -96,7 +96,7 @@ public: virtual bool streamMute(int stream) const = 0; // set audio mode - virtual status_t setMode(int mode) = 0; + virtual status_t setMode(audio_mode_t mode) = 0; // mic mute/state virtual status_t setMicMute(bool state) = 0; diff --git a/include/media/IAudioPolicyService.h b/include/media/IAudioPolicyService.h index 9807cbe..2ad3d8c 100644 --- a/include/media/IAudioPolicyService.h +++ b/include/media/IAudioPolicyService.h @@ -45,7 +45,7 @@ public: const char *device_address) = 0; virtual audio_policy_dev_state_t getDeviceConnectionState(audio_devices_t device, const char *device_address) = 0; - virtual status_t setPhoneState(int state) = 0; + virtual status_t setPhoneState(audio_mode_t state) = 0; virtual status_t setRingerMode(uint32_t mode, uint32_t mask) = 0; virtual status_t setForceUse(audio_policy_force_use_t usage, audio_policy_forced_cfg_t config) = 0; virtual audio_policy_forced_cfg_t getForceUse(audio_policy_force_use_t usage) = 0; diff --git a/media/libmedia/AudioSystem.cpp b/media/libmedia/AudioSystem.cpp index 9d4137e..31a3b53 100644 --- a/media/libmedia/AudioSystem.cpp +++ b/media/libmedia/AudioSystem.cpp @@ -156,7 +156,7 @@ status_t AudioSystem::getStreamMute(int stream, bool* mute) return NO_ERROR; } -status_t AudioSystem::setMode(int mode) +status_t AudioSystem::setMode(audio_mode_t mode) { if (uint32_t(mode) >= AUDIO_MODE_CNT) return BAD_VALUE; const sp& af = AudioSystem::get_audio_flinger(); @@ -536,7 +536,7 @@ audio_policy_dev_state_t AudioSystem::getDeviceConnectionState(audio_devices_t d return aps->getDeviceConnectionState(device, device_address); } -status_t AudioSystem::setPhoneState(int state) +status_t AudioSystem::setPhoneState(audio_mode_t state) { const sp& aps = AudioSystem::get_audio_policy_service(); if (aps == 0) return PERMISSION_DENIED; diff --git a/media/libmedia/IAudioFlinger.cpp b/media/libmedia/IAudioFlinger.cpp index abd491f..ea9bcdd 100644 --- a/media/libmedia/IAudioFlinger.cpp +++ b/media/libmedia/IAudioFlinger.cpp @@ -289,7 +289,7 @@ public: return reply.readInt32(); } - virtual status_t setMode(int mode) + virtual status_t setMode(audio_mode_t mode) { Parcel data, reply; data.writeInterfaceToken(IAudioFlinger::getInterfaceDescriptor()); @@ -786,7 +786,7 @@ status_t BnAudioFlinger::onTransact( } break; case SET_MODE: { CHECK_INTERFACE(IAudioFlinger, data, reply); - int mode = data.readInt32(); + audio_mode_t mode = (audio_mode_t) data.readInt32(); reply->writeInt32( setMode(mode) ); return NO_ERROR; } break; diff --git a/media/libmedia/IAudioPolicyService.cpp b/media/libmedia/IAudioPolicyService.cpp index 50b4855..3a54347 100644 --- a/media/libmedia/IAudioPolicyService.cpp +++ b/media/libmedia/IAudioPolicyService.cpp @@ -91,7 +91,7 @@ public: return static_cast (reply.readInt32()); } - virtual status_t setPhoneState(int state) + virtual status_t setPhoneState(audio_mode_t state) { Parcel data, reply; data.writeInterfaceToken(IAudioPolicyService::getInterfaceDescriptor()); @@ -394,7 +394,7 @@ status_t BnAudioPolicyService::onTransact( case SET_PHONE_STATE: { CHECK_INTERFACE(IAudioPolicyService, data, reply); - reply->writeInt32(static_cast (setPhoneState(data.readInt32()))); + reply->writeInt32(static_cast (setPhoneState((audio_mode_t) data.readInt32()))); return NO_ERROR; } break; diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp index 9fb666e..22915e6 100644 --- a/services/audioflinger/AudioFlinger.cpp +++ b/services/audioflinger/AudioFlinger.cpp @@ -563,7 +563,7 @@ status_t AudioFlinger::setMasterVolume(float value) return NO_ERROR; } -status_t AudioFlinger::setMode(int mode) +status_t AudioFlinger::setMode(audio_mode_t mode) { status_t ret = initCheck(); if (ret != NO_ERROR) { @@ -5883,7 +5883,7 @@ sp AudioFlinger::ThreadBase::getEffectChain_l(int ses return chain; } -void AudioFlinger::ThreadBase::setMode(uint32_t mode) +void AudioFlinger::ThreadBase::setMode(audio_mode_t mode) { Mutex::Autolock _l(mLock); size_t size = mEffectChains.size(); @@ -6681,7 +6681,7 @@ status_t AudioFlinger::EffectModule::setDevice(uint32_t device) return status; } -status_t AudioFlinger::EffectModule::setMode(uint32_t mode) +status_t AudioFlinger::EffectModule::setMode(audio_mode_t mode) { Mutex::Autolock _l(mLock); status_t status = NO_ERROR; @@ -6690,7 +6690,7 @@ status_t AudioFlinger::EffectModule::setMode(uint32_t mode) uint32_t size = sizeof(status_t); status = (*mEffectInterface)->command(mEffectInterface, EFFECT_CMD_SET_AUDIO_MODE, - sizeof(int), + sizeof(audio_mode_t), &mode, &size, &cmdStatus); @@ -7340,7 +7340,7 @@ void AudioFlinger::EffectChain::setDevice_l(uint32_t device) } // setMode_l() must be called with PlaybackThread::mLock held -void AudioFlinger::EffectChain::setMode_l(uint32_t mode) +void AudioFlinger::EffectChain::setMode_l(audio_mode_t mode) { size_t size = mEffects.size(); for (size_t i = 0; i < size; i++) { diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h index f99e764..301ab6d 100644 --- a/services/audioflinger/AudioFlinger.h +++ b/services/audioflinger/AudioFlinger.h @@ -99,7 +99,7 @@ public: virtual float streamVolume(int stream, int output) const; virtual bool streamMute(int stream) const; - virtual status_t setMode(int mode); + virtual status_t setMode(audio_mode_t mode); virtual status_t setMicMute(bool state); virtual bool getMicMute() const; @@ -202,7 +202,7 @@ public: Parcel* reply, uint32_t flags); - uint32_t getMode() { return mMode; } + audio_mode_t getMode() const { return mMode; } bool btNrecIsOff() { return mBtNrecIsOff; } @@ -461,7 +461,7 @@ private: // unlock effect chains after process void unlockEffectChains(Vector >& effectChains); // set audio mode to all effect chains - void setMode(uint32_t mode); + void setMode(audio_mode_t mode); // get effect module with corresponding ID on specified audio session sp getEffect_l(int sessionId, int effectId); // add and effect module. Also creates the effect chain is none exists for @@ -1111,7 +1111,7 @@ private: status_t setDevice(uint32_t device); status_t setVolume(uint32_t *left, uint32_t *right, bool controller); - status_t setMode(uint32_t mode); + status_t setMode(audio_mode_t mode); status_t start(); status_t stop(); void setSuspended(bool suspended); @@ -1264,7 +1264,7 @@ mutable Mutex mLock; // mutex for process, commands and handl sp getEffectFromType_l(const effect_uuid_t *type); bool setVolume_l(uint32_t *left, uint32_t *right); void setDevice_l(uint32_t device); - void setMode_l(uint32_t mode); + void setMode_l(audio_mode_t mode); void setInBuffer(int16_t *buffer, bool ownsBuffer = false) { mInBuffer = buffer; @@ -1395,7 +1395,7 @@ mutable Mutex mLock; // mutex for process, commands and handl DefaultKeyedVector< pid_t, sp > mNotificationClients; volatile int32_t mNextUniqueId; - uint32_t mMode; + audio_mode_t mMode; bool mBtNrecIsOff; Vector mAudioSessionRefs; diff --git a/services/audioflinger/AudioPolicyService.cpp b/services/audioflinger/AudioPolicyService.cpp index 3f86d58..6b59538 100644 --- a/services/audioflinger/AudioPolicyService.cpp +++ b/services/audioflinger/AudioPolicyService.cpp @@ -185,7 +185,7 @@ audio_policy_dev_state_t AudioPolicyService::getDeviceConnectionState( device_address); } -status_t AudioPolicyService::setPhoneState(int state) +status_t AudioPolicyService::setPhoneState(audio_mode_t state) { if (mpAudioPolicy == NULL) { return NO_INIT; diff --git a/services/audioflinger/AudioPolicyService.h b/services/audioflinger/AudioPolicyService.h index 88cb1e9..4aafdfc 100644 --- a/services/audioflinger/AudioPolicyService.h +++ b/services/audioflinger/AudioPolicyService.h @@ -58,7 +58,7 @@ public: virtual audio_policy_dev_state_t getDeviceConnectionState( audio_devices_t device, const char *device_address); - virtual status_t setPhoneState(int state); + virtual status_t setPhoneState(audio_mode_t state); virtual status_t setRingerMode(uint32_t mode, uint32_t mask); virtual status_t setForceUse(audio_policy_force_use_t usage, audio_policy_forced_cfg_t config); virtual audio_policy_forced_cfg_t getForceUse(audio_policy_force_use_t usage); -- cgit v1.1