From 1bf291a765608ea51db743389e01e98d9a5a8bf8 Mon Sep 17 00:00:00 2001 From: vivek mehta Date: Tue, 12 Feb 2013 16:41:00 -0800 Subject: libstagefright: Check for duration > 0 to avoid DivideByZero crash - duration = 0 can cause divide by zero and for this clip duration is indiacted as 0. - check for duration > 0 rather than duration >= 0 Change-Id: I58ccacbf7ede892dff9626715162ea7b1f2ddbc6 CRs-Fixed: 451855 --- media/libstagefright/AwesomePlayer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/media/libstagefright/AwesomePlayer.cpp b/media/libstagefright/AwesomePlayer.cpp index 7d077f5..6dc18f8 100644 --- a/media/libstagefright/AwesomePlayer.cpp +++ b/media/libstagefright/AwesomePlayer.cpp @@ -638,7 +638,7 @@ void AwesomePlayer::notifyListener_l(int msg, int ext1, int ext2) { bool AwesomePlayer::getBitrate(int64_t *bitrate) { off64_t size; - if (mDurationUs >= 0 && mCachedSource != NULL + if (mDurationUs > 0 && mCachedSource != NULL && mCachedSource->getSize(&size) == OK) { *bitrate = size * 8000000ll / mDurationUs; // in bits/sec return true; -- cgit v1.1