From 14c858e80dfe2030c9f343dc0c6e2048e030731b Mon Sep 17 00:00:00 2001 From: James Dong Date: Mon, 10 Jan 2011 08:55:02 -0800 Subject: Avoid deadlock in OMX::freeNode by making sure OMXCodecObserver does not hold the last reference of OMXCodec object bug - 3336424 Change-Id: I4c79b66a900c527e3ae6a833f76d5da1b75c5a89 --- include/media/stagefright/OMXCodec.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'include/media/stagefright/OMXCodec.h') diff --git a/include/media/stagefright/OMXCodec.h b/include/media/stagefright/OMXCodec.h index bba5b53..f8daa4f 100644 --- a/include/media/stagefright/OMXCodec.h +++ b/include/media/stagefright/OMXCodec.h @@ -70,8 +70,6 @@ struct OMXCodec : public MediaSource, virtual status_t pause(); - void on_message(const omx_message &msg); - // from MediaBufferObserver virtual void signalBufferReturned(MediaBuffer *buffer); @@ -79,6 +77,13 @@ protected: virtual ~OMXCodec(); private: + + // Make sure mLock is accessible to OMXCodecObserver + friend class OMXCodecObserver; + + // Call this with mLock hold + void on_message(const omx_message &msg); + enum State { DEAD, LOADED, -- cgit v1.1