From a64bf2af4ef3219d9d897cd1bbc7b67a7e4c3f4c Mon Sep 17 00:00:00 2001 From: Steve Kondik Date: Wed, 18 Nov 2015 16:26:56 -0800 Subject: Revert "DataSource: Remove global variables in DataSource related to sniff" * Don't change the ABI. Fun times. This reverts commit 4440ef8efc77d1bd7838885e83d41e54deb5a3b8. Change-Id: Ie9e0812f5e4ee700c29b76a413083858ec0255c9 --- include/media/stagefright/DataSource.h | 42 +++++----------------------------- 1 file changed, 6 insertions(+), 36 deletions(-) (limited to 'include') diff --git a/include/media/stagefright/DataSource.h b/include/media/stagefright/DataSource.h index 56abe71..de5ddd3 100644 --- a/include/media/stagefright/DataSource.h +++ b/include/media/stagefright/DataSource.h @@ -36,40 +36,6 @@ class IDataSource; struct IMediaHTTPService; class String8; struct HTTPBase; -class DataSource; - -class Sniffer : public RefBase { -public: - Sniffer(); - - //////////////////////////////////////////////////////////////////////////// - - bool sniff(DataSource *source, String8 *mimeType, float *confidence, sp *meta); - - // The sniffer can optionally fill in "meta" with an AMessage containing - // a dictionary of values that helps the corresponding extractor initialize - // its state without duplicating effort already exerted by the sniffer. - typedef bool (*SnifferFunc)( - const sp &source, String8 *mimeType, - float *confidence, sp *meta); - - //if isExtendedExtractor = true, store the location of the sniffer to register - void registerSniffer_l(SnifferFunc func); - void registerDefaultSniffers(); - - virtual ~Sniffer() {} - -private: - Mutex mSnifferMutex; - List mSniffers; - List mExtraSniffers; - List::iterator extendedSnifferPosition; - - void registerSnifferPlugin(); - - Sniffer(const Sniffer &); - Sniffer &operator=(const Sniffer &); -}; class DataSource : public RefBase { public: @@ -91,7 +57,7 @@ public: static sp CreateMediaHTTP(const sp &httpService); static sp CreateFromIDataSource(const sp &source); - DataSource() : mSniffer(new Sniffer()) {} + DataSource() {} virtual status_t initCheck() const = 0; @@ -145,7 +111,11 @@ public: protected: virtual ~DataSource() {} - sp mSniffer; +private: + static Mutex gSnifferMutex; + static List gSniffers; + static List gExtraSniffers; + static bool gSniffersRegistered; static void RegisterSniffer_l(SnifferFunc func); static void RegisterSnifferPlugin(); -- cgit v1.1