From a189a6883ee55cf62da1d7bf5bf5a8ab501938a4 Mon Sep 17 00:00:00 2001 From: Glenn Kasten Date: Mon, 20 Feb 2012 12:16:30 -0800 Subject: Use struct assignment instead of explicit memcpy for POD structs effect_descriptor_t and effect_config_t Change-Id: Ib2fc47f85fb65ed91b0abb1f87217c49b5eb571d --- media/libeffects/visualizer/EffectVisualizer.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'media/libeffects/visualizer/EffectVisualizer.cpp') diff --git a/media/libeffects/visualizer/EffectVisualizer.cpp b/media/libeffects/visualizer/EffectVisualizer.cpp index d3c69f4..44baf93 100644 --- a/media/libeffects/visualizer/EffectVisualizer.cpp +++ b/media/libeffects/visualizer/EffectVisualizer.cpp @@ -106,7 +106,7 @@ int Visualizer_setConfig(VisualizerContext *pContext, effect_config_t *pConfig) pConfig->outputCfg.accessMode != EFFECT_BUFFER_ACCESS_ACCUMULATE) return -EINVAL; if (pConfig->inputCfg.format != AUDIO_FORMAT_PCM_16_BIT) return -EINVAL; - memcpy(&pContext->mConfig, pConfig, sizeof(effect_config_t)); + pContext->mConfig = *pConfig; Visualizer_reset(pContext); @@ -130,7 +130,7 @@ int Visualizer_setConfig(VisualizerContext *pContext, effect_config_t *pConfig) void Visualizer_getConfig(VisualizerContext *pContext, effect_config_t *pConfig) { - memcpy(pConfig, &pContext->mConfig, sizeof(effect_config_t)); + *pConfig = pContext->mConfig; } @@ -190,7 +190,7 @@ int VisualizerLib_QueryEffect(uint32_t index, if (index > 0) { return -EINVAL; } - memcpy(pDescriptor, &gVisualizerDescriptor, sizeof(effect_descriptor_t)); + *pDescriptor = gVisualizerDescriptor; return 0; } @@ -253,7 +253,7 @@ int VisualizerLib_GetDescriptor(const effect_uuid_t *uuid, } if (memcmp(uuid, &gVisualizerDescriptor.uuid, sizeof(effect_uuid_t)) == 0) { - memcpy(pDescriptor, &gVisualizerDescriptor, sizeof(effect_descriptor_t)); + *pDescriptor = gVisualizerDescriptor; return 0; } @@ -561,7 +561,7 @@ int Visualizer_getDescriptor(effect_handle_t self, return -EINVAL; } - memcpy(pDescriptor, &gVisualizerDescriptor, sizeof(effect_descriptor_t)); + *pDescriptor = gVisualizerDescriptor; return 0; } /* end Visualizer_getDescriptor */ -- cgit v1.1