From 704455a5a6cd22f03bb8984e0c7f46108eb1afb7 Mon Sep 17 00:00:00 2001 From: Eric Laurent Date: Mon, 13 May 2013 12:47:53 -0700 Subject: Fix unreleased mutex in ToneGenerator stopTone() Commit 09108ade introduced a regression by not releasing the ToneGenerator mutex before exiting in case of error. Bug: 8852855 Change-Id: I8ba2755b218842e2034ed8dbd54b18bf2a5fc571 --- media/libmedia/ToneGenerator.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'media/libmedia/ToneGenerator.cpp') diff --git a/media/libmedia/ToneGenerator.cpp b/media/libmedia/ToneGenerator.cpp index f09ce75..f55b697 100644 --- a/media/libmedia/ToneGenerator.cpp +++ b/media/libmedia/ToneGenerator.cpp @@ -1012,6 +1012,7 @@ void ToneGenerator::stopTone() { if (lStatus == NO_ERROR) { // If the tone was restarted exit now before calling clearWaveGens(); if (mState != TONE_INIT) { + mLock.unlock(); return; } ALOGV("track stop complete, time %d", (unsigned int)(systemTime()/1000000)); -- cgit v1.1