From 8f18da70cf611d6a2d066b0a7ef43ccc2a3d968f Mon Sep 17 00:00:00 2001 From: Leena Winterrowd Date: Thu, 10 Sep 2015 15:41:08 -0700 Subject: NuPlayerRenderer: Handle AMessage post error in openAudioSink AMessage::postAndAwaitResponse can fail if the target looper no longer exists or if allocation of the reply token fails. Check for error in these cases to avoid deferencing a NULL response. CRs-Fixed: 902117 Change-Id: I52d838e93768ba5b431a0ed8c74a67a5575f6685 --- media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp') diff --git a/media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp b/media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp index dd9ba6f..87e49bd 100644 --- a/media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp +++ b/media/libmediaplayerservice/nuplayer/NuPlayerRenderer.cpp @@ -361,10 +361,10 @@ status_t NuPlayer::Renderer::openAudioSink( msg->setInt32("isStreaming", isStreaming); sp response; - msg->postAndAwaitResponse(&response); + status_t postStatus = msg->postAndAwaitResponse(&response); int32_t err; - if (!response->findInt32("err", &err)) { + if (postStatus != OK || !response->findInt32("err", &err)) { err = INVALID_OPERATION; } else if (err == OK && isOffloaded != NULL) { int32_t offload; -- cgit v1.1