From 41cd3f51d445ea4e5f9984910e6eb95cdec1438a Mon Sep 17 00:00:00 2001 From: Chad Brubaker Date: Tue, 11 Aug 2015 15:21:02 -0700 Subject: Fix benign unsigned integer overflow Bug:23110888 Change-Id: Ibd6f1c7a9204cf584536c1ee63f6a8e5c6e4aa59 (cherry picked from commit 69c1e038717d3462ea5991425ba009f0aed148d2) --- media/libstagefright/DataURISource.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'media/libstagefright/DataURISource.cpp') diff --git a/media/libstagefright/DataURISource.cpp b/media/libstagefright/DataURISource.cpp index 2c39314..2a61c3a 100644 --- a/media/libstagefright/DataURISource.cpp +++ b/media/libstagefright/DataURISource.cpp @@ -42,7 +42,8 @@ sp DataURISource::Create(const char *uri) { AString encoded(commaPos + 1); // Strip CR and LF... - for (size_t i = encoded.size(); i-- > 0;) { + for (size_t i = encoded.size(); i > 0;) { + i--; if (encoded.c_str()[i] == '\r' || encoded.c_str()[i] == '\n') { encoded.erase(i, 1); } -- cgit v1.1