From 938e2b34b16c3c1fd29c753eeb53ee95a2b2e2b3 Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Sat, 13 Jun 2015 17:03:06 -0700 Subject: don't trigger an integer underflow when decrementing. When decrementing "i", eventually i will equal zero. When that happens, i-- underflows. This causes a crash when code which uses clang's -fsanitize=unsigned-integer-overflow is run. Avoid trigging an unsigned integer underflow. Change-Id: I61709cb01f56fdb36d631aa95579e8bd09cafd12 --- media/libstagefright/MediaCodecList.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'media/libstagefright/MediaCodecList.cpp') diff --git a/media/libstagefright/MediaCodecList.cpp b/media/libstagefright/MediaCodecList.cpp index 3f10be6..a47bfc7 100644 --- a/media/libstagefright/MediaCodecList.cpp +++ b/media/libstagefright/MediaCodecList.cpp @@ -220,7 +220,8 @@ void MediaCodecList::parseTopLevelXMLFile(const char *codecs_xml, bool ignore_er } } - for (size_t i = mCodecInfos.size(); i-- > 0;) { + for (size_t i = mCodecInfos.size(); i > 0;) { + i--; const MediaCodecInfo &info = *mCodecInfos.itemAt(i).get(); if (info.mCaps.size() == 0) { // No types supported by this component??? -- cgit v1.1