From 65890a73d53a25b0809b22e41cdee19e3f4aa68d Mon Sep 17 00:00:00 2001 From: Keith Mok Date: Wed, 2 Dec 2015 14:34:22 -0800 Subject: Fixed comparison on 64 bit system Fixed comparison in setSampleToChunkParams which return false since SIZE_MAX in 64 bit system is 18446744073709551615, but off64_t is signed. Change-Id: Idba6b94e2dbdcc34ced98a5f926f1b5e0b6cf5cb --- media/libstagefright/SampleTable.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'media/libstagefright/SampleTable.cpp') diff --git a/media/libstagefright/SampleTable.cpp b/media/libstagefright/SampleTable.cpp index 93cf055..ee5def5 100644 --- a/media/libstagefright/SampleTable.cpp +++ b/media/libstagefright/SampleTable.cpp @@ -246,7 +246,7 @@ status_t SampleTable::setSampleToChunkParams( for (uint32_t i = 0; i < mNumSampleToChunkOffsets; ++i) { uint8_t buffer[12]; - if ((off64_t)(SIZE_MAX - 8 - (i * 12)) < mSampleToChunkOffset) { + if ((off64_t)(INT64_MAX - 8 - (i * 12)) < mSampleToChunkOffset) { return ERROR_MALFORMED; } -- cgit v1.1