From 8a0554c63dc40a2a7c066b03041079ec9eb220e5 Mon Sep 17 00:00:00 2001 From: Glenn Kasten Date: Tue, 3 Mar 2015 12:17:06 -0800 Subject: Pull up comment to superclass Change-Id: I2e3632ee80744f2f8d932ac1a8597ff805883851 --- services/audioflinger/FastMixerDumpState.h | 6 ------ services/audioflinger/FastThreadDumpState.h | 7 ++++++- 2 files changed, 6 insertions(+), 7 deletions(-) (limited to 'services') diff --git a/services/audioflinger/FastMixerDumpState.h b/services/audioflinger/FastMixerDumpState.h index 1ef86fd..ac15e7c 100644 --- a/services/audioflinger/FastMixerDumpState.h +++ b/services/audioflinger/FastMixerDumpState.h @@ -59,12 +59,6 @@ struct FastTrackDump { size_t mFramesReady; // most recent value only; no long-term statistics kept }; -// The FastMixerDumpState keeps a cache of FastMixer statistics that can be logged by dumpsys. -// Each individual native word-sized field is accessed atomically. But the -// overall structure is non-atomic, that is there may be an inconsistency between fields. -// No barriers or locks are used for either writing or reading. -// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks). -// It has a different lifetime than the FastMixer, and so it can't be a member of FastMixer. struct FastMixerDumpState : FastThreadDumpState { FastMixerDumpState(); /*virtual*/ ~FastMixerDumpState(); diff --git a/services/audioflinger/FastThreadDumpState.h b/services/audioflinger/FastThreadDumpState.h index bbca7da..1ce0914 100644 --- a/services/audioflinger/FastThreadDumpState.h +++ b/services/audioflinger/FastThreadDumpState.h @@ -22,7 +22,12 @@ namespace android { -// FIXME extract common part of comment at FastMixerDumpState +// The FastThreadDumpState keeps a cache of FastThread statistics that can be logged by dumpsys. +// Each individual native word-sized field is accessed atomically. But the +// overall structure is non-atomic, that is there may be an inconsistency between fields. +// No barriers or locks are used for either writing or reading. +// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks). +// It has a different lifetime than the FastThread, and so it can't be a member of FastThread. struct FastThreadDumpState { FastThreadDumpState(); /*virtual*/ ~FastThreadDumpState(); -- cgit v1.1