From 22eb4e239fbe9103568147d566d7482e480350b8 Mon Sep 17 00:00:00 2001 From: Glenn Kasten Date: Wed, 7 Nov 2012 14:03:00 -0800 Subject: Update audio comments Change-Id: I85d7d2f6381b251db5695202fec75128883a8662 --- services/audioflinger/AudioFlinger.h | 6 +++++- services/audioflinger/StateQueue.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'services') diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h index 8cf58b1..54cf239 100644 --- a/services/audioflinger/AudioFlinger.h +++ b/services/audioflinger/AudioFlinger.h @@ -861,6 +861,9 @@ private: sp sharedBuffer() const { return mSharedBuffer; } + // framesWritten is cumulative, never reset, and is shared all tracks + // audioHalFrames is derived from output latency + // FIXME parameters not needed, could get them from the thread bool presentationComplete(size_t framesWritten, size_t audioHalFrames); public: @@ -893,6 +896,7 @@ private: bool mHasVolumeController; size_t mPresentationCompleteFrames; // number of frames written to the // audio HAL when this track will be fully rendered + // zero means not monitoring private: IAudioFlinger::track_flags_t mFlags; @@ -997,7 +1001,7 @@ private: }; - // playback track + // playback track, used by DuplicatingThread class OutputTrack : public Track { public: diff --git a/services/audioflinger/StateQueue.h b/services/audioflinger/StateQueue.h index c9b5111..e33b3c6 100644 --- a/services/audioflinger/StateQueue.h +++ b/services/audioflinger/StateQueue.h @@ -174,7 +174,7 @@ public: #endif private: - static const unsigned kN = 4; // values != 4 are not supported by this code + static const unsigned kN = 4; // values < 4 are not supported by this code T mStates[kN]; // written by mutator, read by observer // "volatile" is meaningless with SMP, but here it indicates that we're using atomic ops -- cgit v1.1