From f2f79cfcdec89052f49b74f9aab48e58daf606c6 Mon Sep 17 00:00:00 2001
From: Eric Laurent <elaurent@google.com>
Date: Thu, 23 Apr 2015 17:10:50 -0700
Subject: RadioService: fix error handling in attach().

Fix typo causing tuner open error to be ignored.

Change-Id: I10735f0cf6ae64ff9c4efa2eb4b20d94d3597ae5
---
 services/radio/RadioService.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'services')

diff --git a/services/radio/RadioService.cpp b/services/radio/RadioService.cpp
index a6c2bdf..cd0f5f3 100644
--- a/services/radio/RadioService.cpp
+++ b/services/radio/RadioService.cpp
@@ -146,7 +146,7 @@ status_t RadioService::attach(radio_handle_t handle,
     radio = module->addClient(client, config, withAudio);
 
     if (radio == 0) {
-        NO_INIT;
+        return NO_INIT;
     }
     return NO_ERROR;
 }
@@ -500,13 +500,12 @@ sp<RadioService::ModuleClient> RadioService::Module::addClient(const sp<IRadioCl
         if (audio) {
             notifyDeviceConnection(true, "");
         }
+        ALOGV("addClient() DONE moduleClient %p", moduleClient.get());
     } else {
+        ALOGW("%s open_tuner failed with error %d", __FUNCTION__, ret);
         moduleClient.clear();
     }
 
-
-    ALOGV("addClient() DONE moduleClient %p", moduleClient.get());
-
     return moduleClient;
 }
 
-- 
cgit v1.1