summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeon Scroggins <scroggo@google.com>2009-10-23 10:16:51 -0400
committerLeon Scroggins <scroggo@google.com>2009-10-23 11:22:36 -0400
commit1d60c5c16b92ddc64d10f13da8af7faaae22cd2f (patch)
treea5e6b100749470153c8332e4949a29eebf37fbe9
parent46a83b4ead517b9fc13b4bee4c59c3eaf4d3fdd9 (diff)
downloadframeworks_base-1d60c5c16b92ddc64d10f13da8af7faaae22cd2f.zip
frameworks_base-1d60c5c16b92ddc64d10f13da8af7faaae22cd2f.tar.gz
frameworks_base-1d60c5c16b92ddc64d10f13da8af7faaae22cd2f.tar.bz2
Do not hide the cursor ring when clicking on an input field.
When pressing the trackball on a text input field, do not call setFollowedLink, which results in the cursor ring disappearing and the WebTextView being torn down. Fixes http://b/issue?id=2210127
-rw-r--r--core/java/android/webkit/WebView.java14
1 files changed, 6 insertions, 8 deletions
diff --git a/core/java/android/webkit/WebView.java b/core/java/android/webkit/WebView.java
index a9083d8..c657765 100644
--- a/core/java/android/webkit/WebView.java
+++ b/core/java/android/webkit/WebView.java
@@ -3468,21 +3468,19 @@ public class WebView extends AbsoluteLayout
if (!nativeCursorIntersects(visibleRect)) {
return false;
}
- nativeSetFollowedLink(true);
nativeUpdatePluginReceivesEvents();
WebViewCore.CursorData data = cursorData();
mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE, data);
playSoundEffect(SoundEffectConstants.CLICK);
- boolean isTextInput = nativeCursorIsTextInput();
- if (isTextInput || !mCallbackProxy.uiOverrideUrlLoading(
- nativeCursorText())) {
+ if (nativeCursorIsTextInput()) {
+ rebuildWebTextView();
+ return true;
+ }
+ nativeSetFollowedLink(true);
+ if (!mCallbackProxy.uiOverrideUrlLoading(nativeCursorText())) {
mWebViewCore.sendMessage(EventHub.CLICK, data.mFrame,
nativeCursorNodePointer());
}
- if (isTextInput) {
- rebuildWebTextView();
- displaySoftKeyboard(true);
- }
return true;
}