diff options
| author | Ben Komalo <benkomalo@google.com> | 2010-11-03 12:18:40 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2010-11-03 12:18:40 -0700 |
| commit | 53eb6af2acce37f0d8e153187ab2af776f01beed (patch) | |
| tree | bbe158eafbe3bd23d90aa25ae28454100d839665 | |
| parent | 01f706260b710bbd4e8aeb123ed8013ebafa09b3 (diff) | |
| parent | ad199ecc441649f0ad816f7b139ab5ddffad98dd (diff) | |
| download | frameworks_base-53eb6af2acce37f0d8e153187ab2af776f01beed.zip frameworks_base-53eb6af2acce37f0d8e153187ab2af776f01beed.tar.gz frameworks_base-53eb6af2acce37f0d8e153187ab2af776f01beed.tar.bz2 | |
Merge "Fix issue where home layout click listener was being attached before it was initialized."
| -rw-r--r-- | core/java/com/android/internal/widget/ActionBarView.java | 29 |
1 files changed, 12 insertions, 17 deletions
diff --git a/core/java/com/android/internal/widget/ActionBarView.java b/core/java/com/android/internal/widget/ActionBarView.java index 15d42cb..95d6dd3 100644 --- a/core/java/com/android/internal/widget/ActionBarView.java +++ b/core/java/com/android/internal/widget/ActionBarView.java @@ -123,8 +123,6 @@ public class ActionBarView extends ViewGroup { } }; - private OnClickListener mHomeClickListener = null; - private OnClickListener mTabClickListener = null; public ActionBarView(Context context, AttributeSet attrs) { @@ -169,9 +167,6 @@ public class ActionBarView extends ViewGroup { mHomeLayout = new LinearLayout(context, null, com.android.internal.R.attr.actionButtonStyle); - mHomeLayout.setClickable(true); - mHomeLayout.setFocusable(true); - mHomeLayout.setOnClickListener(mHomeClickListener); mHomeLayout.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.MATCH_PARENT)); @@ -207,18 +202,18 @@ public class ActionBarView extends ViewGroup { a.recycle(); - if (mLogo != null || mIcon != null || mTitle != null) { - mLogoNavItem = new ActionMenuItem(context, 0, android.R.id.home, 0, 0, mTitle); - mHomeClickListener = new OnClickListener() { - public void onClick(View v) { - Context context = getContext(); - if (context instanceof Activity) { - Activity activity = (Activity) context; - activity.onOptionsItemSelected(mLogoNavItem); - } - } - }; - } + mLogoNavItem = new ActionMenuItem(context, 0, android.R.id.home, 0, 0, mTitle); + mHomeLayout.setOnClickListener(new OnClickListener() { + public void onClick(View v) { + Context context = getContext(); + if (context instanceof Activity) { + Activity activity = (Activity) context; + activity.onOptionsItemSelected(mLogoNavItem); + } + } + }); + mHomeLayout.setClickable(true); + mHomeLayout.setFocusable(true); } @Override |
