summaryrefslogtreecommitdiffstats
path: root/core/jni/android_nio_utils.cpp
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2011-04-12 11:28:59 -0700
committerElliott Hughes <enh@google.com>2011-04-12 11:28:59 -0700
commitdd66bcbf9d6ef0c50a18d9c4b1b39ce7ef7afcc4 (patch)
treed44c2b9758436b189a2091297fa1e22d350da4a3 /core/jni/android_nio_utils.cpp
parentae447967b5f07dd789a7488aa9e190637478a97c (diff)
downloadframeworks_base-dd66bcbf9d6ef0c50a18d9c4b1b39ce7ef7afcc4.zip
frameworks_base-dd66bcbf9d6ef0c50a18d9c4b1b39ce7ef7afcc4.tar.gz
frameworks_base-dd66bcbf9d6ef0c50a18d9c4b1b39ce7ef7afcc4.tar.bz2
More native code cleanup.
Don't keep unused global references to classes, don't throw exceptions when an exception is already pending, and fix a (harmless) misunderstanding about how GetStringChars works. Change-Id: Ie445036f057daa8a1c76aceb7bad2a84fb81d820
Diffstat (limited to 'core/jni/android_nio_utils.cpp')
-rw-r--r--core/jni/android_nio_utils.cpp9
1 files changed, 4 insertions, 5 deletions
diff --git a/core/jni/android_nio_utils.cpp b/core/jni/android_nio_utils.cpp
index 584e7a4..7cbbe12 100644
--- a/core/jni/android_nio_utils.cpp
+++ b/core/jni/android_nio_utils.cpp
@@ -32,20 +32,20 @@ void* android::nio_getPointer(JNIEnv *_env, jobject buffer, jarray *array) {
jlong pointer;
jint offset;
void *data;
-
+
pointer = _env->CallStaticLongMethod(gNioJNI.nioAccessClass,
gNioJNI.getBasePointerID, buffer);
if (pointer != 0L) {
*array = NULL;
return (void *) (jint) pointer;
}
-
+
*array = (jarray) _env->CallStaticObjectMethod(gNioJNI.nioAccessClass,
gNioJNI.getBaseArrayID, buffer);
offset = _env->CallStaticIntMethod(gNioJNI.nioAccessClass,
gNioJNI.getBaseArrayOffsetID, buffer);
data = _env->GetPrimitiveArrayCritical(*array, (jboolean *) 0);
-
+
return (void *) ((char *) data + offset);
}
@@ -94,8 +94,7 @@ static jfieldID getFieldID(JNIEnv* env, jclass c, const char name[],
}
namespace android {
-
-int register_android_nio_utils(JNIEnv* env);
+
int register_android_nio_utils(JNIEnv* env) {
jclass localClass = findClass(env, "java/nio/NIOAccess");
gNioJNI.getBasePointerID = findStaticMethod(env, localClass,