diff options
author | Ray Chen <> | 2009-04-02 01:31:49 -0700 |
---|---|---|
committer | The Android Open Source Project <initial-contribution@android.com> | 2009-04-02 01:31:49 -0700 |
commit | 0a6a0e9e95fffc3b53be92ba617e97fff66d1401 (patch) | |
tree | fdd30bf98f4b271551fbe62050ab2771e03cf73c /core | |
parent | 0827c81466dffc2f0f3470574733cc0956df0494 (diff) | |
download | frameworks_base-0a6a0e9e95fffc3b53be92ba617e97fff66d1401.zip frameworks_base-0a6a0e9e95fffc3b53be92ba617e97fff66d1401.tar.gz frameworks_base-0a6a0e9e95fffc3b53be92ba617e97fff66d1401.tar.bz2 |
AI 144176: To fix the race condition in case "requestCancelDecode"
happens earlier than AutoDecoderCancel object is added
to the gAutoDecoderCancelMutex linked list.
BUG=1692286
Automated import of CL 144176
Diffstat (limited to 'core')
-rw-r--r-- | core/jni/android/graphics/BitmapFactory.cpp | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/core/jni/android/graphics/BitmapFactory.cpp b/core/jni/android/graphics/BitmapFactory.cpp index 332b01c..4ad2eb0 100644 --- a/core/jni/android/graphics/BitmapFactory.cpp +++ b/core/jni/android/graphics/BitmapFactory.cpp @@ -22,6 +22,7 @@ static jfieldID gOptions_ditherFieldID; static jfieldID gOptions_widthFieldID; static jfieldID gOptions_heightFieldID; static jfieldID gOptions_mimeFieldID; +static jfieldID gOptions_mCancelID; static jclass gFileDescriptor_class; static jfieldID gFileDescriptor_descriptor; @@ -204,12 +205,12 @@ class AssetStreamAdaptor : public SkStream { public: AssetStreamAdaptor(Asset* a) : fAsset(a) {} - virtual bool rewind() { + virtual bool rewind() { off_t pos = fAsset->seek(0, SEEK_SET); return pos != (off_t)-1; } - virtual size_t read(void* buffer, size_t size) { + virtual size_t read(void* buffer, size_t size) { ssize_t amount; if (NULL == buffer) { @@ -322,6 +323,15 @@ static jobject doDecode(JNIEnv* env, SkStream* stream, jobject padding, AutoDecoderCancel adc(options, decoder); + // To fix the race condition in case "requestCancelDecode" + // happens earlier than AutoDecoderCancel object is added + // to the gAutoDecoderCancelMutex linked list. + if (NULL != options) { + if (env->GetBooleanField(options, gOptions_mCancelID)) { + return NULL; + } + } + if (!decoder->decode(stream, bitmap, prefConfig, mode)) { return NULL; } @@ -588,6 +598,7 @@ int register_android_graphics_BitmapFactory(JNIEnv* env) { gOptions_widthFieldID = getFieldIDCheck(env, gOptions_class, "outWidth", "I"); gOptions_heightFieldID = getFieldIDCheck(env, gOptions_class, "outHeight", "I"); gOptions_mimeFieldID = getFieldIDCheck(env, gOptions_class, "outMimeType", "Ljava/lang/String;"); + gOptions_mCancelID = getFieldIDCheck(env, gOptions_class, "mCancel", "Z"); gFileDescriptor_class = make_globalref(env, "java/io/FileDescriptor"); gFileDescriptor_descriptor = getFieldIDCheck(env, gFileDescriptor_class, "descriptor", "I"); |