diff options
| author | Jeff Brown <jeffbrown@google.com> | 2012-03-12 15:53:33 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-03-12 15:53:33 -0700 |
| commit | ed6aa3da03554ece6e8ec8a9e9db024cfaafd292 (patch) | |
| tree | d5c78b8fea43fccde87d74299d02bf9969fa6fea /core | |
| parent | 4d367c54d1b7394a470849c4c86e80ebc491f388 (diff) | |
| parent | b2679481b57d87945df02983f95ff8e6c9ba5928 (diff) | |
| download | frameworks_base-ed6aa3da03554ece6e8ec8a9e9db024cfaafd292.zip frameworks_base-ed6aa3da03554ece6e8ec8a9e9db024cfaafd292.tar.gz frameworks_base-ed6aa3da03554ece6e8ec8a9e9db024cfaafd292.tar.bz2 | |
Merge "Fix potential NPE in SQLiteProgram."
Diffstat (limited to 'core')
| -rw-r--r-- | core/java/android/database/sqlite/SQLiteProgram.java | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/core/java/android/database/sqlite/SQLiteProgram.java b/core/java/android/database/sqlite/SQLiteProgram.java index 94a23cb..e9b06c6 100644 --- a/core/java/android/database/sqlite/SQLiteProgram.java +++ b/core/java/android/database/sqlite/SQLiteProgram.java @@ -64,20 +64,20 @@ public abstract class SQLiteProgram extends SQLiteClosable { break; } + if (bindArgs != null && bindArgs.length > mNumParameters) { + throw new IllegalArgumentException("Too many bind arguments. " + + bindArgs.length + " arguments were provided but the statement needs " + + mNumParameters + " arguments."); + } + if (mNumParameters != 0) { mBindArgs = new Object[mNumParameters]; + if (bindArgs != null) { + System.arraycopy(bindArgs, 0, mBindArgs, 0, bindArgs.length); + } } else { mBindArgs = null; } - - if (bindArgs != null) { - if (bindArgs.length > mNumParameters) { - throw new IllegalArgumentException("Too many bind arguments. " - + bindArgs.length + " arguments were provided but the statement needs " - + mNumParameters + " arguments."); - } - System.arraycopy(bindArgs, 0, mBindArgs, 0, bindArgs.length); - } } final SQLiteDatabase getDatabase() { |
