summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorAndroid (Google) Code Review <android-gerrit@google.com>2009-09-02 16:45:33 -0700
committerAndroid (Google) Code Review <android-gerrit@google.com>2009-09-02 16:45:33 -0700
commitf6ca7fab5043e1c3e834c15b4e674ae0c5c37d0d (patch)
treea9315b6981b3571224a62fd07df066c76e022715 /core
parent010bed7419e96f5310be25d9317405d360f90b9c (diff)
parentef92e7a606167130d4ae52c1e23f32c3f0af291e (diff)
downloadframeworks_base-f6ca7fab5043e1c3e834c15b4e674ae0c5c37d0d.zip
frameworks_base-f6ca7fab5043e1c3e834c15b4e674ae0c5c37d0d.tar.gz
frameworks_base-f6ca7fab5043e1c3e834c15b4e674ae0c5c37d0d.tar.bz2
Merge change 23690 into eclair
* changes: Prevent a crash when webkit changes the selection.
Diffstat (limited to 'core')
-rw-r--r--core/java/android/webkit/WebTextView.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/core/java/android/webkit/WebTextView.java b/core/java/android/webkit/WebTextView.java
index a1f2223..95b3a12 100644
--- a/core/java/android/webkit/WebTextView.java
+++ b/core/java/android/webkit/WebTextView.java
@@ -697,8 +697,12 @@ import java.util.ArrayList;
* Set the selection, and disable our onSelectionChanged action.
*/
/* package */ void setSelectionFromWebKit(int start, int end) {
+ if (start < 0 || end < 0) return;
+ Spannable text = (Spannable) getText();
+ int length = text.length();
+ if (start > length || end > length) return;
mFromWebKit = true;
- Selection.setSelection((Spannable) getText(), start, end);
+ Selection.setSelection(text, start, end);
mFromWebKit = false;
}