diff options
author | Brad Fitzpatrick <bradfitz@android.com> | 2010-07-07 16:06:39 -0700 |
---|---|---|
committer | Brad Fitzpatrick <bradfitz@android.com> | 2010-07-15 13:18:05 -0700 |
commit | 727de40c6bc7c6521a0542ea9def5d5c7b1c5e06 (patch) | |
tree | 0d2f0f400211efbaf131020d7c4d38e647f5bbe3 /libs/binder | |
parent | d6343c26b8580f61a257a3045bfa124049201116 (diff) | |
download | frameworks_base-727de40c6bc7c6521a0542ea9def5d5c7b1c5e06.zip frameworks_base-727de40c6bc7c6521a0542ea9def5d5c7b1c5e06.tar.gz frameworks_base-727de40c6bc7c6521a0542ea9def5d5c7b1c5e06.tar.bz2 |
More StrictMode work, keeping Binder & BlockGuard's thread-locals in-sync.
Change-Id: Ia67cabcc17a73a0f15907ffea683d06bc41b90e5
Diffstat (limited to 'libs/binder')
-rw-r--r-- | libs/binder/IPCThreadState.cpp | 4 | ||||
-rw-r--r-- | libs/binder/Parcel.cpp | 13 |
2 files changed, 13 insertions, 4 deletions
diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp index 28706ba..f6582e6 100644 --- a/libs/binder/IPCThreadState.cpp +++ b/libs/binder/IPCThreadState.cpp @@ -372,8 +372,8 @@ void IPCThreadState::setStrictModePolicy(int32_t policy) mStrictModePolicy = policy; } - -int32_t IPCThreadState::getStrictModePolicy() const { +int32_t IPCThreadState::getStrictModePolicy() const +{ return mStrictModePolicy; } diff --git a/libs/binder/Parcel.cpp b/libs/binder/Parcel.cpp index 47be1bf..bed893a 100644 --- a/libs/binder/Parcel.cpp +++ b/libs/binder/Parcel.cpp @@ -48,6 +48,9 @@ #define PAD_SIZE(s) (((s)+3)&~3) +// Note: must be kept in sync with android/os/StrictMode.java's PENALTY_GATHER +#define STRICT_MODE_PENALTY_GATHER 0x100 + // XXX This can be made public if we want to provide // support for typed data. struct small_flat_data @@ -440,7 +443,8 @@ bool Parcel::hasFileDescriptors() const // Write RPC headers. (previously just the interface token) status_t Parcel::writeInterfaceToken(const String16& interface) { - writeInt32(IPCThreadState::self()->getStrictModePolicy()); + writeInt32(IPCThreadState::self()->getStrictModePolicy() | + STRICT_MODE_PENALTY_GATHER); // currently the interface identification token is just its name as a string return writeString16(interface); } @@ -450,9 +454,14 @@ bool Parcel::checkInterface(IBinder* binder) const return enforceInterface(binder->getInterfaceDescriptor()); } -bool Parcel::enforceInterface(const String16& interface) const +bool Parcel::enforceInterface(const String16& interface, + int32_t* strict_policy_out) const { int32_t strict_policy = readInt32(); + IPCThreadState::self()->setStrictModePolicy(strict_policy); + if (strict_policy_out != NULL) { + *strict_policy_out = strict_policy; + } const String16 str(readString16()); if (str == interface) { return true; |