diff options
author | James Dong <jdong@google.com> | 2010-08-26 19:12:59 -0700 |
---|---|---|
committer | James Dong <jdong@google.com> | 2010-08-27 13:59:26 -0700 |
commit | 90862e2a8b3ea522cf1dace5e93dcec109a1aa85 (patch) | |
tree | 95b2c116c4b3ae3b5d196ee16ff3f013ee970eab /media/libstagefright | |
parent | b86365ad74a197f2af6d70eedeb19083e31a9686 (diff) | |
download | frameworks_base-90862e2a8b3ea522cf1dace5e93dcec109a1aa85.zip frameworks_base-90862e2a8b3ea522cf1dace5e93dcec109a1aa85.tar.gz frameworks_base-90862e2a8b3ea522cf1dace5e93dcec109a1aa85.tar.bz2 |
Workaround for a QCOM issue where the output buffer size advertised by the AVC encoder
is occasionally too small.
bug - 2882917
Change-Id: Id59d8529084c5689a26f272e0cd3b1e955fd8a30
Diffstat (limited to 'media/libstagefright')
-rw-r--r-- | media/libstagefright/OMXCodec.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/media/libstagefright/OMXCodec.cpp b/media/libstagefright/OMXCodec.cpp index 4741b1d..165cec9 100644 --- a/media/libstagefright/OMXCodec.cpp +++ b/media/libstagefright/OMXCodec.cpp @@ -353,6 +353,15 @@ uint32_t OMXCodec::getComponentQuirks(const char *componentName) { quirks |= kRequiresLoadedToIdleAfterAllocation; quirks |= kRequiresAllocateBufferOnInputPorts; quirks |= kRequiresAllocateBufferOnOutputPorts; + if (!strncmp(componentName, "OMX.qcom.video.encoder.avc", 26)) { + + // The AVC encoder advertises the size of output buffers + // based on the input video resolution and assumes + // the worst/least compression ratio is 0.5. It is found that + // sometimes, the output buffer size is larger than + // size advertised by the encoder. + quirks |= kRequiresLargerEncoderOutputBuffer; + } } if (!strncmp(componentName, "OMX.qcom.7x30.video.encoder.", 28)) { } @@ -906,6 +915,10 @@ void OMXCodec::setVideoInputFormat( video_def->nBitrate = bitRate; // Q16 format video_def->eCompressionFormat = compressionFormat; video_def->eColorFormat = OMX_COLOR_FormatUnused; + if (mQuirks & kRequiresLargerEncoderOutputBuffer) { + // Increases the output buffer size + def.nBufferSize = ((def.nBufferSize * 3) >> 1); + } err = mOMX->setParameter( mNode, OMX_IndexParamPortDefinition, &def, sizeof(def)); |