summaryrefslogtreecommitdiffstats
path: root/packages/SettingsProvider
diff options
context:
space:
mode:
authorMike Lockwood <lockwood@android.com>2010-04-21 18:24:57 -0400
committerMike Lockwood <lockwood@android.com>2010-04-21 18:31:56 -0400
commitbdc7f891cf47c077c26ef418dbea23c04820c152 (patch)
tree794605a0ec15fe40a50ba68c92222181d8af49f5 /packages/SettingsProvider
parente3491b6b5f1d3fb871074766597b275d9f682faa (diff)
downloadframeworks_base-bdc7f891cf47c077c26ef418dbea23c04820c152.zip
frameworks_base-bdc7f891cf47c077c26ef418dbea23c04820c152.tar.gz
frameworks_base-bdc7f891cf47c077c26ef418dbea23c04820c152.tar.bz2
Fix broken logic in SettingsProvider.parseProviderList.
We were accidentally stripping both leading and trailing commas when removing a provider from the enabled provider list. Signed-off-by: Mike Lockwood <lockwood@android.com>
Diffstat (limited to 'packages/SettingsProvider')
-rw-r--r--packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java9
1 files changed, 6 insertions, 3 deletions
diff --git a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
index 9877342..ab186cf 100644
--- a/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
+++ b/packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
@@ -305,9 +305,12 @@ public class SettingsProvider extends ContentProvider {
}
} else if (prefix == '-' && index >= 0) {
// remove the provider from the list if present
- // remove leading and trailing commas
- if (index > 0) index--;
- if (end < providers.length()) end++;
+ // remove leading or trailing comma
+ if (index > 0) {
+ index--;
+ } else if (end < providers.length()) {
+ end++;
+ }
newProviders = providers.substring(0, index);
if (end < providers.length()) {