diff options
| author | Brad Fitzpatrick <bradfitz@android.com> | 2010-11-15 16:26:04 -0800 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@android.com> | 2010-11-15 16:26:04 -0800 |
| commit | 6689ac8a56a4e64c6f0ab4fa521e7ec3e28c02df (patch) | |
| tree | 68e252663ea35a2c12a7f29dab7152a42c931990 /services | |
| parent | c7bc3d09bda82c0641035966559b911785ccf90e (diff) | |
| download | frameworks_base-6689ac8a56a4e64c6f0ab4fa521e7ec3e28c02df.zip frameworks_base-6689ac8a56a4e64c6f0ab4fa521e7ec3e28c02df.tar.gz frameworks_base-6689ac8a56a4e64c6f0ab4fa521e7ec3e28c02df.tar.bz2 | |
Fix more things that CloseGuard found.
Not terribly happy with how the code looks after, though.
Change-Id: I7bf5f78ef6c0ac82339a2e49488ca6e64d13c05e
Diffstat (limited to 'services')
| -rw-r--r-- | services/java/com/android/server/PackageManagerService.java | 10 | ||||
| -rw-r--r-- | services/java/com/android/server/ProcessStats.java | 11 |
2 files changed, 17 insertions, 4 deletions
diff --git a/services/java/com/android/server/PackageManagerService.java b/services/java/com/android/server/PackageManagerService.java index cd58284..a0a1974 100644 --- a/services/java/com/android/server/PackageManagerService.java +++ b/services/java/com/android/server/PackageManagerService.java @@ -7327,16 +7327,22 @@ class PackageManagerService extends IPackageManager.Stub { pw.println(" "); pw.println("Package warning messages:"); File fname = getSettingsProblemFile(); - FileInputStream in; + FileInputStream in = null; try { in = new FileInputStream(fname); int avail = in.available(); byte[] data = new byte[avail]; in.read(data); pw.print(new String(data)); - in.close(); } catch (FileNotFoundException e) { } catch (IOException e) { + } finally { + if (in != null) { + try { + in.close(); + } catch (IOException e) { + } + } } } } diff --git a/services/java/com/android/server/ProcessStats.java b/services/java/com/android/server/ProcessStats.java index 43dbcc0..1a12a84 100644 --- a/services/java/com/android/server/ProcessStats.java +++ b/services/java/com/android/server/ProcessStats.java @@ -799,8 +799,9 @@ public class ProcessStats { } private String readFile(String file, char endChar) { + FileInputStream is = null; try { - FileInputStream is = new FileInputStream(file); + is = new FileInputStream(file); int len = is.read(mBuffer); is.close(); @@ -815,6 +816,13 @@ public class ProcessStats { } } catch (java.io.FileNotFoundException e) { } catch (java.io.IOException e) { + } finally { + if (is != null) { + try { + is.close(); + } catch (java.io.IOException e) { + } + } } return null; } @@ -841,4 +849,3 @@ public class ProcessStats { } } } - |
