diff options
author | Steve Block <steveblock@google.com> | 2010-09-29 11:16:49 +0100 |
---|---|---|
committer | Steve Block <steveblock@google.com> | 2010-09-29 18:51:41 +0100 |
commit | c0f90a8f93546f4e9a708c44ac610f36b5e9b1f8 (patch) | |
tree | 0a2e74f41acb2ebd63bc5d04b413770e9e50c993 /tests/DumpRenderTree2 | |
parent | 49aa65aa4651b9ee3a533f0bafb62bdb07a2a2b5 (diff) | |
download | frameworks_base-c0f90a8f93546f4e9a708c44ac610f36b5e9b1f8.zip frameworks_base-c0f90a8f93546f4e9a708c44ac610f36b5e9b1f8.tar.gz frameworks_base-c0f90a8f93546f4e9a708c44ac610f36b5e9b1f8.tar.bz2 |
Trim empty lines when comparing text results in DumpRenderTree2
Change-Id: I94c9de8e6131f6b60456700e9d5a3b27c8c9d1c3
Diffstat (limited to 'tests/DumpRenderTree2')
-rw-r--r-- | tests/DumpRenderTree2/src/com/android/dumprendertree2/TextResult.java | 30 |
1 files changed, 20 insertions, 10 deletions
diff --git a/tests/DumpRenderTree2/src/com/android/dumprendertree2/TextResult.java b/tests/DumpRenderTree2/src/com/android/dumprendertree2/TextResult.java index f835b6a..1460178 100644 --- a/tests/DumpRenderTree2/src/com/android/dumprendertree2/TextResult.java +++ b/tests/DumpRenderTree2/src/com/android/dumprendertree2/TextResult.java @@ -87,20 +87,30 @@ public class TextResult extends AbstractResult { @Override public ResultCode getResultCode() { - if (mResultCode != null) { - return mResultCode; - } - - if (mExpectedResult == null) { - mResultCode = AbstractResult.ResultCode.NO_EXPECTED_RESULT; - } else if (!mExpectedResult.equals(mActualResult)) { - mResultCode = AbstractResult.ResultCode.RESULTS_DIFFER; - } else { - mResultCode = AbstractResult.ResultCode.RESULTS_MATCH; + if (mResultCode == null) { + if (mExpectedResult == null) { + mResultCode = AbstractResult.ResultCode.NO_EXPECTED_RESULT; + } else { + mResultCode = resultsMatch() ? AbstractResult.ResultCode.RESULTS_MATCH + : AbstractResult.ResultCode.RESULTS_DIFFER; + } } return mResultCode; } + private boolean resultsMatch() { + assert mExpectedResult != null; + assert mActualResult != null; + // Trim leading and trailing empty lines, as other WebKit platforms do. + String leadingEmptyLines = "^\\n+"; + String trailingEmptyLines = "\\n+$"; + String trimmedExpectedResult = mExpectedResult.replaceFirst(leadingEmptyLines, "") + .replaceFirst(trailingEmptyLines, ""); + String trimmedActualResult = mActualResult.replaceFirst(leadingEmptyLines, "") + .replaceFirst(trailingEmptyLines, ""); + return trimmedExpectedResult.equals(trimmedActualResult); + } + @Override public boolean didCrash() { return false; |