diff options
Diffstat (limited to 'core')
119 files changed, 5219 insertions, 959 deletions
diff --git a/core/java/android/accessibilityservice/AccessibilityService.java b/core/java/android/accessibilityservice/AccessibilityService.java index cbc8150..19a91a6 100644 --- a/core/java/android/accessibilityservice/AccessibilityService.java +++ b/core/java/android/accessibilityservice/AccessibilityService.java @@ -353,6 +353,11 @@ public abstract class AccessibilityService extends Service { */ public static final int GLOBAL_ACTION_QUICK_SETTINGS = 5; + /** + * Action to open the power long-press dialog. + */ + public static final int GLOBAL_ACTION_POWER_DIALOG = 6; + private static final String LOG_TAG = "AccessibilityService"; /** diff --git a/core/java/android/app/ActionBar.java b/core/java/android/app/ActionBar.java index 5c98180..b74c824 100644 --- a/core/java/android/app/ActionBar.java +++ b/core/java/android/app/ActionBar.java @@ -993,6 +993,33 @@ public abstract class ActionBar { } } + /** + * Set the Z-axis elevation of the action bar in pixels. + * + * <p>The action bar's elevation is the distance it is placed from its parent surface. Higher + * values are closer to the user.</p> + * + * @param elevation Elevation value in pixels + */ + public void setElevation(float elevation) { + if (elevation != 0) { + throw new UnsupportedOperationException("Setting a non-zero elevation is " + + "not supported in this action bar configuration."); + } + } + + /** + * Get the Z-axis elevation of the action bar in pixels. + * + * <p>The action bar's elevation is the distance it is placed from its parent surface. Higher + * values are closer to the user.</p> + * + * @return Elevation value in pixels + */ + public float getElevation() { + return 0; + } + /** @hide */ public void setDefaultDisplayHomeAsUpEnabled(boolean enabled) { } diff --git a/core/java/android/app/ContextImpl.java b/core/java/android/app/ContextImpl.java index cacb2df..bbfb05e 100644 --- a/core/java/android/app/ContextImpl.java +++ b/core/java/android/app/ContextImpl.java @@ -565,9 +565,7 @@ class ContextImpl extends Context { registerService(PHONE_SERVICE, new ServiceFetcher() { public Object createService(ContextImpl ctx) { - IBinder b = ServiceManager.getService(TELECOMM_SERVICE); - return new PhoneManager(ctx.getOuterContext(), - ITelecommService.Stub.asInterface(b)); + return new PhoneManager(ctx.getOuterContext()); }}); registerService(UI_MODE_SERVICE, new ServiceFetcher() { diff --git a/core/java/android/app/UiAutomation.java b/core/java/android/app/UiAutomation.java index 64e3484..4aec9e0 100644 --- a/core/java/android/app/UiAutomation.java +++ b/core/java/android/app/UiAutomation.java @@ -673,6 +673,7 @@ public final class UiAutomation { canvas.translate(- screenshotWidth / 2, - screenshotHeight / 2); canvas.drawBitmap(screenShot, 0, 0, null); canvas.setBitmap(null); + screenShot.recycle(); screenShot = unrotatedScreenShot; } diff --git a/core/java/android/app/admin/DevicePolicyManager.java b/core/java/android/app/admin/DevicePolicyManager.java index 2feec1b..6ea6b4b 100644 --- a/core/java/android/app/admin/DevicePolicyManager.java +++ b/core/java/android/app/admin/DevicePolicyManager.java @@ -2375,6 +2375,24 @@ public class DevicePolicyManager { } /** + * Called by a device owner to switch the specified user to the foreground. + * + * @param admin Which {@link DeviceAdminReceiver} this request is associated with. + * @param userHandle the user to switch to; null will switch to primary. + * @return {@code true} if the switch was successful, {@code false} otherwise. + * + * @see Intent#ACTION_USER_FOREGROUND + */ + public boolean switchUser(ComponentName admin, UserHandle userHandle) { + try { + return mService.switchUser(admin, userHandle); + } catch (RemoteException re) { + Log.w(TAG, "Could not switch user ", re); + return false; + } + } + + /** * Called by a profile or device owner to get the application restrictions for a given target * application running in the managed profile. * diff --git a/core/java/android/app/admin/IDevicePolicyManager.aidl b/core/java/android/app/admin/IDevicePolicyManager.aidl index 40bd7d1..c27d1cc 100644 --- a/core/java/android/app/admin/IDevicePolicyManager.aidl +++ b/core/java/android/app/admin/IDevicePolicyManager.aidl @@ -139,6 +139,7 @@ interface IDevicePolicyManager { UserHandle createUser(in ComponentName who, in String name); UserHandle createAndInitializeUser(in ComponentName who, in String name, in String profileOwnerName, in ComponentName profileOwnerComponent, in Bundle adminExtras); boolean removeUser(in ComponentName who, in UserHandle userHandle); + boolean switchUser(in ComponentName who, in UserHandle userHandle); void setAccountManagementDisabled(in ComponentName who, in String accountType, in boolean disabled); String[] getAccountTypesWithManagementDisabled(); diff --git a/core/java/android/app/job/JobInfo.java b/core/java/android/app/job/JobInfo.java index a22e4cd..70f6966 100644 --- a/core/java/android/app/job/JobInfo.java +++ b/core/java/android/app/job/JobInfo.java @@ -64,7 +64,6 @@ public class JobInfo implements Parcelable { } private final int jobId; - // TODO: Change this to use PersistableBundle when that lands in master. private final PersistableBundle extras; private final ComponentName service; private final boolean requireCharging; @@ -75,6 +74,7 @@ public class JobInfo implements Parcelable { private final long minLatencyMillis; private final long maxExecutionDelayMillis; private final boolean isPeriodic; + private final boolean isPersisted; private final long intervalMillis; private final long initialBackoffMillis; private final int backoffPolicy; @@ -145,6 +145,13 @@ public class JobInfo implements Parcelable { } /** + * @return Whether or not this job should be persisted across device reboots. + */ + public boolean isPersisted() { + return isPersisted; + } + + /** * Set to the interval between occurrences of this job. This value is <b>not</b> set if the * job does not recur periodically. */ @@ -197,6 +204,7 @@ public class JobInfo implements Parcelable { minLatencyMillis = in.readLong(); maxExecutionDelayMillis = in.readLong(); isPeriodic = in.readInt() == 1; + isPersisted = in.readInt() == 1; intervalMillis = in.readLong(); initialBackoffMillis = in.readLong(); backoffPolicy = in.readInt(); @@ -214,6 +222,7 @@ public class JobInfo implements Parcelable { minLatencyMillis = b.mMinLatencyMillis; maxExecutionDelayMillis = b.mMaxExecutionDelayMillis; isPeriodic = b.mIsPeriodic; + isPersisted = b.mIsPersisted; intervalMillis = b.mIntervalMillis; initialBackoffMillis = b.mInitialBackoffMillis; backoffPolicy = b.mBackoffPolicy; @@ -237,6 +246,7 @@ public class JobInfo implements Parcelable { out.writeLong(minLatencyMillis); out.writeLong(maxExecutionDelayMillis); out.writeInt(isPeriodic ? 1 : 0); + out.writeInt(isPersisted ? 1 : 0); out.writeLong(intervalMillis); out.writeLong(initialBackoffMillis); out.writeInt(backoffPolicy); @@ -265,6 +275,7 @@ public class JobInfo implements Parcelable { private boolean mRequiresCharging; private boolean mRequiresDeviceIdle; private int mNetworkCapabilities; + private boolean mIsPersisted; // One-off parameters. private long mMinLatencyMillis; private long mMaxExecutionDelayMillis; @@ -342,11 +353,6 @@ public class JobInfo implements Parcelable { * Specify that this job should recur with the provided interval, not more than once per * period. You have no control over when within this interval this job will be executed, * only the guarantee that it will be executed at most once within this interval. - * A periodic job will be repeated until the phone is turned off, however it will only be - * persisted beyond boot if the client app has declared the - * {@link android.Manifest.permission#RECEIVE_BOOT_COMPLETED} permission. You can schedule - * periodic jobs without this permission, they simply will cease to exist after the phone - * restarts. * Setting this function on the builder with {@link #setMinimumLatency(long)} or * {@link #setOverrideDeadline(long)} will result in an error. * @param intervalMillis Millisecond interval for which this job will repeat. @@ -407,6 +413,19 @@ public class JobInfo implements Parcelable { } /** + * Set whether or not to persist this job across device reboots. This will only have an + * effect if your application holds the permission + * {@link android.Manifest.permission#RECEIVE_BOOT_COMPLETED}. Otherwise an exception will + * be thrown. + * @param isPersisted True to indicate that the job will be written to disk and loaded at + * boot. + */ + public Builder setIsPersisted(boolean isPersisted) { + mIsPersisted = isPersisted; + return this; + } + + /** * @return The job object to hand to the JobScheduler. This object is immutable. */ public JobInfo build() { diff --git a/core/java/android/content/Context.java b/core/java/android/content/Context.java index 04275d8..535aaa1 100644 --- a/core/java/android/content/Context.java +++ b/core/java/android/content/Context.java @@ -2422,6 +2422,7 @@ public abstract class Context { * @see android.net.wifi.WifiScanner * @hide */ + @SystemApi public static final String WIFI_SCANNING_SERVICE = "wifiscanner"; /** diff --git a/core/java/android/content/pm/ApplicationInfo.java b/core/java/android/content/pm/ApplicationInfo.java index 4939fb6..b93bbe0 100644 --- a/core/java/android/content/pm/ApplicationInfo.java +++ b/core/java/android/content/pm/ApplicationInfo.java @@ -491,18 +491,23 @@ public class ApplicationInfo extends PackageItemInfo implements Parcelable { public String nativeLibraryDir; /** - * The path under the apps data directory we store unpacked libraries. For - * new installs, we create subdirectories under legacyNativeLibraryDir that are - * architecture specific. For legacy installs, the shared libraries are - * placed directly under this path. + * The root path where unpacked native libraries are stored. + * <p> + * When {@link #nativeLibraryRootRequiresIsa} is set, the libraries are + * placed in ISA-specific subdirectories under this path, otherwise the + * libraries are placed directly at this path. * - * For "legacy" installs {@code nativeLibraryDir} will be equal to this path. - * For newer installs, it will be derived based on the codePath and the primary - * cpu abi. + * @hide + */ + public String nativeLibraryRootDir; + + /** + * Flag indicating that ISA must be appended to + * {@link #nativeLibraryRootDir} to be useful. * - * @hide. + * @hide */ - public String legacyNativeLibraryDir; + public boolean nativeLibraryRootRequiresIsa; /** * The primary ABI that this application requires, This is inferred from the ABIs @@ -683,7 +688,8 @@ public class ApplicationInfo extends PackageItemInfo implements Parcelable { splitSourceDirs = orig.splitSourceDirs; splitPublicSourceDirs = orig.splitPublicSourceDirs; nativeLibraryDir = orig.nativeLibraryDir; - legacyNativeLibraryDir = orig.legacyNativeLibraryDir; + nativeLibraryRootDir = orig.nativeLibraryRootDir; + nativeLibraryRootRequiresIsa = orig.nativeLibraryRootRequiresIsa; primaryCpuAbi = orig.primaryCpuAbi; secondaryCpuAbi = orig.secondaryCpuAbi; apkRoot = orig.apkRoot; @@ -730,7 +736,8 @@ public class ApplicationInfo extends PackageItemInfo implements Parcelable { dest.writeStringArray(splitSourceDirs); dest.writeStringArray(splitPublicSourceDirs); dest.writeString(nativeLibraryDir); - dest.writeString(legacyNativeLibraryDir); + dest.writeString(nativeLibraryRootDir); + dest.writeInt(nativeLibraryRootRequiresIsa ? 1 : 0); dest.writeString(primaryCpuAbi); dest.writeString(secondaryCpuAbi); dest.writeString(apkRoot); @@ -776,7 +783,8 @@ public class ApplicationInfo extends PackageItemInfo implements Parcelable { splitSourceDirs = source.readStringArray(); splitPublicSourceDirs = source.readStringArray(); nativeLibraryDir = source.readString(); - legacyNativeLibraryDir = source.readString(); + nativeLibraryRootDir = source.readString(); + nativeLibraryRootRequiresIsa = source.readInt() != 0; primaryCpuAbi = source.readString(); secondaryCpuAbi = source.readString(); apkRoot = source.readString(); diff --git a/core/java/android/content/pm/LauncherApps.java b/core/java/android/content/pm/LauncherApps.java index 6c10bb8..6e7a418 100644 --- a/core/java/android/content/pm/LauncherApps.java +++ b/core/java/android/content/pm/LauncherApps.java @@ -55,8 +55,6 @@ public class LauncherApps { private ILauncherApps mService; private PackageManager mPm; - private List<OnAppsChangedListener> mListeners - = new ArrayList<OnAppsChangedListener>(); private List<OnAppsChangedCallback> mCallbacks = new ArrayList<OnAppsChangedCallback>(); @@ -117,62 +115,6 @@ public class LauncherApps { boolean replacing); } - /** - * Callbacks for package changes to this and related managed profiles. - */ - public interface OnAppsChangedListener { - /** - * Indicates that a package was removed from the specified profile. - * - * @param user The UserHandle of the profile that generated the change. - * @param packageName The name of the package that was removed. - */ - void onPackageRemoved(UserHandle user, String packageName); - - /** - * Indicates that a package was added to the specified profile. - * - * @param user The UserHandle of the profile that generated the change. - * @param packageName The name of the package that was added. - */ - void onPackageAdded(UserHandle user, String packageName); - - /** - * Indicates that a package was modified in the specified profile. - * - * @param user The UserHandle of the profile that generated the change. - * @param packageName The name of the package that has changed. - */ - void onPackageChanged(UserHandle user, String packageName); - - /** - * Indicates that one or more packages have become available. For - * example, this can happen when a removable storage card has - * reappeared. - * - * @param user The UserHandle of the profile that generated the change. - * @param packageNames The names of the packages that have become - * available. - * @param replacing Indicates whether these packages are replacing - * existing ones. - */ - void onPackagesAvailable(UserHandle user, String[] packageNames, boolean replacing); - - /** - * Indicates that one or more packages have become unavailable. For - * example, this can happen when a removable storage card has been - * removed. - * - * @param user The UserHandle of the profile that generated the change. - * @param packageNames The names of the packages that have become - * unavailable. - * @param replacing Indicates whether the packages are about to be - * replaced with new versions. - */ - void onPackagesUnavailable(UserHandle user, String[] packageNames, boolean replacing); - - } - /** @hide */ public LauncherApps(Context context, ILauncherApps service) { mContext = context; @@ -321,43 +263,6 @@ public class LauncherApps { /** - * Adds a listener for changes to packages in current and managed profiles. - * - * @param listener The listener to add. - */ - public void addOnAppsChangedListener(OnAppsChangedListener listener) { - synchronized (this) { - if (listener != null && !mListeners.contains(listener)) { - mListeners.add(listener); - if (mListeners.size() == 1 && mCallbacks.size() == 0) { - try { - mService.addOnAppsChangedListener(mAppsChangedListener); - } catch (RemoteException re) { - } - } - } - } - } - - /** - * Removes a listener that was previously added. - * - * @param listener The listener to remove. - * @see #addOnAppsChangedListener(OnAppsChangedListener) - */ - public void removeOnAppsChangedListener(OnAppsChangedListener listener) { - synchronized (this) { - mListeners.remove(listener); - if (mListeners.size() == 0 && mCallbacks.size() == 0) { - try { - mService.removeOnAppsChangedListener(mAppsChangedListener); - } catch (RemoteException re) { - } - } - } - } - - /** * Adds a callback for changes to packages in current and managed profiles. * * @param callback The callback to add. @@ -366,7 +271,7 @@ public class LauncherApps { synchronized (this) { if (callback != null && !mCallbacks.contains(callback)) { mCallbacks.add(callback); - if (mCallbacks.size() == 1 && mListeners.size() == 0) { + if (mCallbacks.size() == 1) { try { mService.addOnAppsChangedListener(mAppsChangedListener); } catch (RemoteException re) { @@ -384,8 +289,8 @@ public class LauncherApps { */ public void removeOnAppsChangedCallback(OnAppsChangedCallback callback) { synchronized (this) { - mListeners.remove(callback); - if (mListeners.size() == 0 && mCallbacks.size() == 0) { + mCallbacks.remove(callback); + if (mCallbacks.size() == 0) { try { mService.removeOnAppsChangedListener(mAppsChangedListener); } catch (RemoteException re) { @@ -402,9 +307,6 @@ public class LauncherApps { Log.d(TAG, "onPackageRemoved " + user.getIdentifier() + "," + packageName); } synchronized (LauncherApps.this) { - for (OnAppsChangedListener listener : mListeners) { - listener.onPackageRemoved(user, packageName); - } for (OnAppsChangedCallback callback : mCallbacks) { callback.onPackageRemoved(packageName, user); } @@ -417,9 +319,6 @@ public class LauncherApps { Log.d(TAG, "onPackageChanged " + user.getIdentifier() + "," + packageName); } synchronized (LauncherApps.this) { - for (OnAppsChangedListener listener : mListeners) { - listener.onPackageChanged(user, packageName); - } for (OnAppsChangedCallback callback : mCallbacks) { callback.onPackageChanged(packageName, user); } @@ -432,9 +331,6 @@ public class LauncherApps { Log.d(TAG, "onPackageAdded " + user.getIdentifier() + "," + packageName); } synchronized (LauncherApps.this) { - for (OnAppsChangedListener listener : mListeners) { - listener.onPackageAdded(user, packageName); - } for (OnAppsChangedCallback callback : mCallbacks) { callback.onPackageAdded(packageName, user); } @@ -448,9 +344,6 @@ public class LauncherApps { Log.d(TAG, "onPackagesAvailable " + user.getIdentifier() + "," + packageNames); } synchronized (LauncherApps.this) { - for (OnAppsChangedListener listener : mListeners) { - listener.onPackagesAvailable(user, packageNames, replacing); - } for (OnAppsChangedCallback callback : mCallbacks) { callback.onPackagesAvailable(packageNames, user, replacing); } @@ -464,9 +357,6 @@ public class LauncherApps { Log.d(TAG, "onPackagesUnavailable " + user.getIdentifier() + "," + packageNames); } synchronized (LauncherApps.this) { - for (OnAppsChangedListener listener : mListeners) { - listener.onPackagesUnavailable(user, packageNames, replacing); - } for (OnAppsChangedCallback callback : mCallbacks) { callback.onPackagesUnavailable(packageNames, user, replacing); } diff --git a/core/java/android/content/pm/PackageManager.java b/core/java/android/content/pm/PackageManager.java index 625005b..a0e56f6 100644 --- a/core/java/android/content/pm/PackageManager.java +++ b/core/java/android/content/pm/PackageManager.java @@ -841,8 +841,9 @@ public abstract class PackageManager { public static final int DELETE_FAILED_USER_RESTRICTED = -3; /** - * Deletion failed return code: this is returned from the PackageInstaller - * activity if it failed to delete a package because the a profile + * Deletion failed return code: this is passed to the + * {@link IPackageDeleteObserver} by {@link #deletePackage()} if the system + * failed to delete the package because a profile * or device owner has marked the package as uninstallable. * * @hide diff --git a/core/java/android/content/pm/PackageParser.java b/core/java/android/content/pm/PackageParser.java index 6e0ca50..0b6a926 100644 --- a/core/java/android/content/pm/PackageParser.java +++ b/core/java/android/content/pm/PackageParser.java @@ -333,7 +333,7 @@ public class PackageParser { } public static final boolean isApkFile(File file) { - return file.isFile() && file.getName().endsWith(".apk"); + return file.getName().endsWith(".apk"); } /* @@ -1312,8 +1312,8 @@ public class PackageParser { } XmlUtils.skipCurrentTag(parser); - } else if (tagName.equals("keys")) { - if (!parseKeys(pkg, res, parser, attrs, outError)) { + } else if (tagName.equals("key-sets")) { + if (!parseKeySets(pkg, res, parser, attrs, outError)) { return null; } } else if (tagName.equals("permission-group")) { @@ -1328,17 +1328,6 @@ public class PackageParser { if (parsePermissionTree(pkg, res, parser, attrs, outError) == null) { return null; } - } else if (tagName.equals("upgrade-keyset")) { - sa = res.obtainAttributes(attrs, - com.android.internal.R.styleable.AndroidManifestUpgradeKeySet); - String name = sa.getNonResourceString( - com.android.internal.R.styleable.AndroidManifestUpgradeKeySet_name); - sa.recycle(); - if (pkg.mUpgradeKeySets == null) { - pkg.mUpgradeKeySets = new ArraySet<String>(); - } - pkg.mUpgradeKeySets.add(name); - XmlUtils.skipCurrentTag(parser); } else if (tagName.equals("uses-permission")) { if (!parseUsesPermission(pkg, res, parser, attrs, outError)) { return null; @@ -1849,84 +1838,141 @@ public class PackageParser { return buildCompoundName(pkg, procSeq, "taskAffinity", outError); } - private boolean parseKeys(Package owner, Resources res, + private boolean parseKeySets(Package owner, Resources res, XmlPullParser parser, AttributeSet attrs, String[] outError) throws XmlPullParserException, IOException { - // we've encountered the 'keys' tag + // we've encountered the 'key-sets' tag // all the keys and keysets that we want must be defined here // so we're going to iterate over the parser and pull out the things we want int outerDepth = parser.getDepth(); - + int currentKeySetDepth = -1; int type; - PublicKey currentKey = null; - int currentKeyDepth = -1; - Map<PublicKey, Set<String>> definedKeySets = new HashMap<PublicKey, Set<String>>(); + String currentKeySet = null; + ArrayMap<String, PublicKey> publicKeys = new ArrayMap<String, PublicKey>(); + ArraySet<String> upgradeKeySets = new ArraySet<String>(); + ArrayMap<String, ArraySet<String>> definedKeySets = new ArrayMap<String, ArraySet<String>>(); + ArraySet<String> improperKeySets = new ArraySet<String>(); while ((type = parser.next()) != XmlPullParser.END_DOCUMENT && (type != XmlPullParser.END_TAG || parser.getDepth() > outerDepth)) { if (type == XmlPullParser.END_TAG) { - if (parser.getDepth() == currentKeyDepth) { - currentKey = null; - currentKeyDepth = -1; + if (parser.getDepth() == currentKeySetDepth) { + currentKeySet = null; + currentKeySetDepth = -1; } continue; } - String tagname = parser.getName(); - if (tagname.equals("publicKey")) { - final TypedArray sa = res.obtainAttributes(attrs, - com.android.internal.R.styleable.PublicKey); - final String encodedKey = sa.getNonResourceString( - com.android.internal.R.styleable.PublicKey_value); - currentKey = parsePublicKey(encodedKey); - if (currentKey == null) { - Slog.w(TAG, "No valid key in 'publicKey' tag at " + String tagName = parser.getName(); + if (tagName.equals("key-set")) { + if (currentKeySet != null) { + Slog.w(TAG, "Improperly nested 'key-set' tag at " + parser.getPositionDescription()); - sa.recycle(); - continue; + return false; } - currentKeyDepth = parser.getDepth(); - definedKeySets.put(currentKey, new HashSet<String>()); + final TypedArray sa = res.obtainAttributes(attrs, + com.android.internal.R.styleable.AndroidManifestKeySet); + final String keysetName = sa.getNonResourceString( + com.android.internal.R.styleable.AndroidManifestKeySet_name); + definedKeySets.put(keysetName, new ArraySet<String>()); + currentKeySet = keysetName; + currentKeySetDepth = parser.getDepth(); sa.recycle(); - } else if (tagname.equals("keyset")) { - if (currentKey == null) { - Slog.i(TAG, "'keyset' not in 'publicKey' tag at " + } else if (tagName.equals("public-key")) { + if (currentKeySet == null) { + Slog.w(TAG, "Improperly nested 'public-key' tag at " + parser.getPositionDescription()); - continue; + return false; } final TypedArray sa = res.obtainAttributes(attrs, - com.android.internal.R.styleable.KeySet); - final String name = sa.getNonResourceString( - com.android.internal.R.styleable.KeySet_name); - definedKeySets.get(currentKey).add(name); + com.android.internal.R.styleable.AndroidManifestPublicKey); + final String publicKeyName = sa.getNonResourceString( + com.android.internal.R.styleable.AndroidManifestPublicKey_name); + final String encodedKey = sa.getNonResourceString( + com.android.internal.R.styleable.AndroidManifestPublicKey_value); + if (encodedKey == null && publicKeys.get(publicKeyName) == null) { + Slog.w(TAG, "'public-key' " + publicKeyName + " must define a public-key value" + + " on first use at " + parser.getPositionDescription()); + sa.recycle(); + return false; + } else if (encodedKey != null) { + PublicKey currentKey = parsePublicKey(encodedKey); + if (currentKey == null) { + Slog.w(TAG, "No recognized valid key in 'public-key' tag at " + + parser.getPositionDescription() + " key-set " + currentKeySet + + " will not be added to the package's defined key-sets."); + sa.recycle(); + improperKeySets.add(currentKeySet); + XmlUtils.skipCurrentTag(parser); + continue; + } + if (publicKeys.get(publicKeyName) == null + || publicKeys.get(publicKeyName).equals(currentKey)) { + + /* public-key first definition, or matches old definition */ + publicKeys.put(publicKeyName, currentKey); + } else { + Slog.w(TAG, "Value of 'public-key' " + publicKeyName + + " conflicts with previously defined value at " + + parser.getPositionDescription()); + sa.recycle(); + return false; + } + } + definedKeySets.get(currentKeySet).add(publicKeyName); + sa.recycle(); + XmlUtils.skipCurrentTag(parser); + } else if (tagName.equals("upgrade-key-set")) { + final TypedArray sa = res.obtainAttributes(attrs, + com.android.internal.R.styleable.AndroidManifestUpgradeKeySet); + String name = sa.getNonResourceString( + com.android.internal.R.styleable.AndroidManifestUpgradeKeySet_name); + upgradeKeySets.add(name); sa.recycle(); + XmlUtils.skipCurrentTag(parser); } else if (RIGID_PARSER) { - Slog.w(TAG, "Bad element under <keys>: " + parser.getName() + Slog.w(TAG, "Bad element under <key-sets>: " + parser.getName() + " at " + mArchiveSourcePath + " " + parser.getPositionDescription()); return false; } else { - Slog.w(TAG, "Unknown element under <keys>: " + parser.getName() + Slog.w(TAG, "Unknown element under <key-sets>: " + parser.getName() + " at " + mArchiveSourcePath + " " + parser.getPositionDescription()); XmlUtils.skipCurrentTag(parser); continue; } } - - owner.mKeySetMapping = new ArrayMap<String, Set<PublicKey>>(); - for (Map.Entry<PublicKey, Set<String>> e : definedKeySets.entrySet()) { - PublicKey key = e.getKey(); - Set<String> keySetNames = e.getValue(); - for (String alias : keySetNames) { - if (owner.mKeySetMapping.containsKey(alias)) { - owner.mKeySetMapping.get(alias).add(key); - } else { - Set<PublicKey> keys = new ArraySet<PublicKey>(); - keys.add(key); - owner.mKeySetMapping.put(alias, keys); - } + Set<String> publicKeyNames = publicKeys.keySet(); + if (publicKeyNames.removeAll(definedKeySets.keySet())) { + Slog.w(TAG, "Package" + owner.packageName + " AndroidManifext.xml " + + "'key-set' and 'public-key' names must be distinct."); + return false; + } + owner.mKeySetMapping = new ArrayMap<String, ArraySet<PublicKey>>(); + for (ArrayMap.Entry<String, ArraySet<String>> e: definedKeySets.entrySet()) { + final String keySetName = e.getKey(); + if (e.getValue().size() == 0) { + Slog.w(TAG, "Package" + owner.packageName + " AndroidManifext.xml " + + "'key-set' " + keySetName + " has no valid associated 'public-key'." + + " Not including in package's defined key-sets."); + continue; + } else if (improperKeySets.contains(keySetName)) { + Slog.w(TAG, "Package" + owner.packageName + " AndroidManifext.xml " + + "'key-set' " + keySetName + " contained improper 'public-key'" + + " tags. Not including in package's defined key-sets."); + continue; + } + owner.mKeySetMapping.put(keySetName, new ArraySet<PublicKey>()); + for (String s : e.getValue()) { + owner.mKeySetMapping.get(keySetName).add(publicKeys.get(s)); } } - + if (owner.mKeySetMapping.keySet().containsAll(upgradeKeySets)) { + owner.mUpgradeKeySets = upgradeKeySets; + } else { + Slog.w(TAG, "Package" + owner.packageName + " AndroidManifext.xml " + + "does not define all 'upgrade-key-set's ."); + return false; + } return true; } @@ -3925,11 +3971,11 @@ public class PackageParser { public boolean mTrustedOverlay; /** - * Data used to feed the KeySetManager + * Data used to feed the KeySetManagerService */ - public Set<PublicKey> mSigningKeys; - public Set<String> mUpgradeKeySets; - public Map<String, Set<PublicKey>> mKeySetMapping; + public ArraySet<PublicKey> mSigningKeys; + public ArraySet<String> mUpgradeKeySets; + public ArrayMap<String, ArraySet<PublicKey>> mKeySetMapping; public Package(String packageName) { this.packageName = packageName; diff --git a/core/java/android/hardware/camera2/CameraCharacteristics.java b/core/java/android/hardware/camera2/CameraCharacteristics.java index 44e3f76..4b1659f 100644 --- a/core/java/android/hardware/camera2/CameraCharacteristics.java +++ b/core/java/android/hardware/camera2/CameraCharacteristics.java @@ -1680,14 +1680,17 @@ public final class CameraCharacteristics extends CameraMetadata<CameraCharacteri * <p>This tag specifies the zero light value for each of the CFA mosaic * channels in the camera sensor. The maximal value output by the * sensor is represented by the value in {@link CameraCharacteristics#SENSOR_INFO_WHITE_LEVEL android.sensor.info.whiteLevel}.</p> - * <p>The values are given in row-column scan order, with the first value - * corresponding to the element of the CFA in row=0, column=0.</p> + * <p>The values are given in the same order as channels listed for the CFA + * layout tag (see {@link CameraCharacteristics#SENSOR_INFO_COLOR_FILTER_ARRANGEMENT android.sensor.info.colorFilterArrangement}), i.e. the + * nth value given corresponds to the black level offset for the nth + * color channel listed in the CFA.</p> * <p><b>Optional</b> - This value may be {@code null} on some devices.</p> * + * @see CameraCharacteristics#SENSOR_INFO_COLOR_FILTER_ARRANGEMENT * @see CameraCharacteristics#SENSOR_INFO_WHITE_LEVEL */ - public static final Key<int[]> SENSOR_BLACK_LEVEL_PATTERN = - new Key<int[]>("android.sensor.blackLevelPattern", int[].class); + public static final Key<android.hardware.camera2.params.BlackLevelPattern> SENSOR_BLACK_LEVEL_PATTERN = + new Key<android.hardware.camera2.params.BlackLevelPattern>("android.sensor.blackLevelPattern", android.hardware.camera2.params.BlackLevelPattern.class); /** * <p>Maximum sensitivity that is implemented diff --git a/core/java/android/hardware/camera2/CameraMetadata.java b/core/java/android/hardware/camera2/CameraMetadata.java index 6eeeff2..fa35f44 100644 --- a/core/java/android/hardware/camera2/CameraMetadata.java +++ b/core/java/android/hardware/camera2/CameraMetadata.java @@ -1131,7 +1131,8 @@ public abstract class CameraMetadata<TKey> { * image while recording video) use case.</p> * <p>The camera device should take the highest-quality image * possible (given the other settings) without disrupting the - * frame rate of video recording. </p> + * frame rate of video recording.<br /> + * </p> * @see CaptureRequest#CONTROL_CAPTURE_INTENT */ public static final int CONTROL_CAPTURE_INTENT_VIDEO_SNAPSHOT = 4; diff --git a/core/java/android/hardware/camera2/DngCreator.java b/core/java/android/hardware/camera2/DngCreator.java index 3e3303c..6fc99ac 100644 --- a/core/java/android/hardware/camera2/DngCreator.java +++ b/core/java/android/hardware/camera2/DngCreator.java @@ -17,6 +17,7 @@ package android.hardware.camera2; import android.graphics.Bitmap; +import android.graphics.Color; import android.graphics.ImageFormat; import android.hardware.camera2.impl.CameraMetadataNative; import android.location.Location; @@ -31,6 +32,7 @@ import java.io.OutputStream; import java.nio.ByteBuffer; import java.text.DateFormat; import java.text.SimpleDateFormat; +import java.util.Calendar; import java.util.TimeZone; /** @@ -68,17 +70,19 @@ public final class DngCreator implements AutoCloseable { * </p> * <p> * DNG metadata tags will be generated from the corresponding parameters in the - * {@link android.hardware.camera2.CaptureResult} object. This removes or overrides - * all previous tags set. + * {@link android.hardware.camera2.CaptureResult} object. + * </p> + * <p> + * For best quality DNG files, it is strongly recommended that lens shading map output is + * enabled if supported. See {@link CaptureRequest#STATISTICS_LENS_SHADING_MAP_MODE}. * </p> - * * @param characteristics an object containing the static * {@link android.hardware.camera2.CameraCharacteristics}. * @param metadata a metadata object to generate tags from. */ public DngCreator(CameraCharacteristics characteristics, CaptureResult metadata) { if (characteristics == null || metadata == null) { - throw new NullPointerException("Null argument to DngCreator constructor"); + throw new IllegalArgumentException("Null argument to DngCreator constructor"); } // Find current time @@ -121,10 +125,8 @@ public final class DngCreator implements AutoCloseable { * <li>{@link android.media.ExifInterface#ORIENTATION_ROTATE_270}</li> * </ul> * @return this {@link #DngCreator} object. - * @hide */ public DngCreator setOrientation(int orientation) { - if (orientation < ExifInterface.ORIENTATION_UNDEFINED || orientation > ExifInterface.ORIENTATION_ROTATE_270) { throw new IllegalArgumentException("Orientation " + orientation + @@ -139,32 +141,32 @@ public final class DngCreator implements AutoCloseable { * * <p> * Pixel data will be converted to a Baseline TIFF RGB image, with 8 bits per color channel. - * The alpha channel will be discarded. - * </p> - * - * <p> - * The given bitmap should not be altered while this object is in use. + * The alpha channel will be discarded. Thumbnail images with a dimension larger than + * {@link #MAX_THUMBNAIL_DIMENSION} will be rejected. * </p> * * @param pixels a {@link android.graphics.Bitmap} of pixel data. * @return this {@link #DngCreator} object. - * @hide + * @throws java.lang.IllegalArgumentException if the given thumbnail image has a dimension + * larger than {@link #MAX_THUMBNAIL_DIMENSION}. */ public DngCreator setThumbnail(Bitmap pixels) { if (pixels == null) { - throw new NullPointerException("Null argument to setThumbnail"); + throw new IllegalArgumentException("Null argument to setThumbnail"); } - Bitmap.Config config = pixels.getConfig(); + int width = pixels.getWidth(); + int height = pixels.getHeight(); - if (config != Bitmap.Config.ARGB_8888) { - pixels = pixels.copy(Bitmap.Config.ARGB_8888, false); - if (pixels == null) { - throw new IllegalArgumentException("Unsupported Bitmap format " + config); - } - nativeSetThumbnailBitmap(pixels); + if (width > MAX_THUMBNAIL_DIMENSION || height > MAX_THUMBNAIL_DIMENSION) { + throw new IllegalArgumentException("Thumbnail dimensions width,height (" + width + + "," + height + ") too large, dimensions must be smaller than " + + MAX_THUMBNAIL_DIMENSION); } + ByteBuffer rgbBuffer = convertToRGB(pixels); + nativeSetThumbnail(rgbBuffer, width, height); + return this; } @@ -173,37 +175,41 @@ public final class DngCreator implements AutoCloseable { * * <p> * Pixel data is interpreted as a {@link android.graphics.ImageFormat#YUV_420_888} image. - * </p> - * - * <p> - * The given image should not be altered while this object is in use. + * Thumbnail images with a dimension larger than {@link #MAX_THUMBNAIL_DIMENSION} will be + * rejected. * </p> * * @param pixels an {@link android.media.Image} object with the format * {@link android.graphics.ImageFormat#YUV_420_888}. * @return this {@link #DngCreator} object. - * @hide + * @throws java.lang.IllegalArgumentException if the given thumbnail image has a dimension + * larger than {@link #MAX_THUMBNAIL_DIMENSION}. */ public DngCreator setThumbnail(Image pixels) { if (pixels == null) { - throw new NullPointerException("Null argument to setThumbnail"); + throw new IllegalArgumentException("Null argument to setThumbnail"); } int format = pixels.getFormat(); if (format != ImageFormat.YUV_420_888) { - throw new IllegalArgumentException("Unsupported image format " + format); + throw new IllegalArgumentException("Unsupported Image format " + format); } - Image.Plane[] planes = pixels.getPlanes(); - nativeSetThumbnailImage(pixels.getWidth(), pixels.getHeight(), planes[0].getBuffer(), - planes[0].getRowStride(), planes[0].getPixelStride(), planes[1].getBuffer(), - planes[1].getRowStride(), planes[1].getPixelStride(), planes[1].getBuffer(), - planes[1].getRowStride(), planes[1].getPixelStride()); + int width = pixels.getWidth(); + int height = pixels.getHeight(); + + if (width > MAX_THUMBNAIL_DIMENSION || height > MAX_THUMBNAIL_DIMENSION) { + throw new IllegalArgumentException("Thumbnail dimensions width,height (" + width + + "," + height + ") too large, dimensions must be smaller than " + + MAX_THUMBNAIL_DIMENSION); + } + + ByteBuffer rgbBuffer = convertToRGB(pixels); + nativeSetThumbnail(rgbBuffer, width, height); return this; } - /** * Set image location metadata. * @@ -219,10 +225,26 @@ public final class DngCreator implements AutoCloseable { * * @throws java.lang.IllegalArgumentException if the given location object doesn't * contain enough information to set location metadata. - * @hide */ public DngCreator setLocation(Location location) { - /*TODO*/ + if (location == null) { + throw new IllegalArgumentException("Null location passed to setLocation"); + } + double latitude = location.getLatitude(); + double longitude = location.getLongitude(); + long time = location.getTime(); + + int[] latTag = toExifLatLong(latitude); + int[] longTag = toExifLatLong(longitude); + String latRef = latitude >= 0 ? GPS_LAT_REF_NORTH : GPS_LAT_REF_SOUTH; + String longRef = longitude >= 0 ? GPS_LONG_REF_EAST : GPS_LONG_REF_WEST; + + String dateTag = sExifGPSDateStamp.format(time); + mGPSTimeStampCalendar.setTimeInMillis(time); + int[] timeTag = new int[] { mGPSTimeStampCalendar.get(Calendar.HOUR_OF_DAY), 1, + mGPSTimeStampCalendar.get(Calendar.MINUTE), 1, + mGPSTimeStampCalendar.get(Calendar.SECOND), 1 }; + nativeSetGpsTags(latTag, latRef, longTag, longRef, dateTag, timeTag); return this; } @@ -235,10 +257,12 @@ public final class DngCreator implements AutoCloseable { * * @param description the user description string. * @return this {@link #DngCreator} object. - * @hide */ public DngCreator setDescription(String description) { - /*TODO*/ + if (description == null) { + throw new IllegalArgumentException("Null description passed to setDescription."); + } + nativeSetDescription(description); return this; } @@ -268,14 +292,26 @@ public final class DngCreator implements AutoCloseable { * @throws java.lang.IllegalStateException if not enough metadata information has been * set to write a well-formatted DNG file. * @throws java.lang.IllegalArgumentException if the size passed in does not match the - * @hide */ public void writeInputStream(OutputStream dngOutput, Size size, InputStream pixels, long offset) throws IOException { - if (dngOutput == null || pixels == null) { - throw new NullPointerException("Null argument to writeImage"); + if (dngOutput == null) { + throw new IllegalArgumentException("Null dngOutput passed to writeInputStream"); + } else if (size == null) { + throw new IllegalArgumentException("Null size passed to writeInputStream"); + } else if (pixels == null) { + throw new IllegalArgumentException("Null pixels passed to writeInputStream"); + } else if (offset < 0) { + throw new IllegalArgumentException("Negative offset passed to writeInputStream"); } - nativeWriteInputStream(dngOutput, pixels, offset); + + int width = size.getWidth(); + int height = size.getHeight(); + if (width <= 0 || height <= 0) { + throw new IllegalArgumentException("Size with invalid width, height: (" + width + "," + + height + ") passed to writeInputStream"); + } + nativeWriteInputStream(dngOutput, pixels, width, height, offset); } /** @@ -294,6 +330,11 @@ public final class DngCreator implements AutoCloseable { * {@link java.lang.IllegalStateException} will be thrown. * </p> * + * <p> + * Any mark or limit set on this {@link ByteBuffer} is ignored, and will be cleared by this + * method. + * </p> + * * @param dngOutput an {@link java.io.OutputStream} to write the DNG file to. * @param size the {@link Size} of the image to write, in pixels. * @param pixels an {@link java.nio.ByteBuffer} of pixel data to write. @@ -303,14 +344,24 @@ public final class DngCreator implements AutoCloseable { * @throws IOException if an error was encountered in the input or output stream. * @throws java.lang.IllegalStateException if not enough metadata information has been * set to write a well-formatted DNG file. - * @hide */ public void writeByteBuffer(OutputStream dngOutput, Size size, ByteBuffer pixels, long offset) throws IOException { - if (dngOutput == null || pixels == null) { - throw new NullPointerException("Null argument to writeImage"); + if (dngOutput == null) { + throw new IllegalArgumentException("Null dngOutput passed to writeByteBuffer"); + } else if (size == null) { + throw new IllegalArgumentException("Null size passed to writeByteBuffer"); + } else if (pixels == null) { + throw new IllegalArgumentException("Null pixels passed to writeByteBuffer"); + } else if (offset < 0) { + throw new IllegalArgumentException("Negative offset passed to writeByteBuffer"); } - nativeWriteByteBuffer(dngOutput, pixels, offset); + + int width = size.getWidth(); + int height = size.getHeight(); + + writeByteBuffer(width, height, pixels, dngOutput, DEFAULT_PIXEL_STRIDE, + width * DEFAULT_PIXEL_STRIDE, offset); } /** @@ -331,8 +382,10 @@ public final class DngCreator implements AutoCloseable { * set to write a well-formatted DNG file. */ public void writeImage(OutputStream dngOutput, Image pixels) throws IOException { - if (dngOutput == null || pixels == null) { - throw new NullPointerException("Null argument to writeImage"); + if (dngOutput == null) { + throw new IllegalArgumentException("Null dngOutput to writeImage"); + } else if (pixels == null) { + throw new IllegalArgumentException("Null pixels to writeImage"); } int format = pixels.getFormat(); @@ -341,8 +394,13 @@ public final class DngCreator implements AutoCloseable { } Image.Plane[] planes = pixels.getPlanes(); - nativeWriteImage(dngOutput, pixels.getWidth(), pixels.getHeight(), planes[0].getBuffer(), - planes[0].getRowStride(), planes[0].getPixelStride()); + if (planes == null || planes.length <= 0) { + throw new IllegalArgumentException("Image with no planes passed to writeImage"); + } + + ByteBuffer buf = planes[0].getBuffer(); + writeByteBuffer(pixels.getWidth(), pixels.getHeight(), buf, dngOutput, + planes[0].getPixelStride(), planes[0].getRowStride(), 0); } @Override @@ -350,6 +408,11 @@ public final class DngCreator implements AutoCloseable { nativeDestroy(); } + /** + * Max width or height dimension for thumbnails. + */ + public static final int MAX_THUMBNAIL_DIMENSION = 256; // max pixel dimension for TIFF/EP + @Override protected void finalize() throws Throwable { try { @@ -359,13 +422,181 @@ public final class DngCreator implements AutoCloseable { } } + private static final String GPS_LAT_REF_NORTH = "N"; + private static final String GPS_LAT_REF_SOUTH = "S"; + private static final String GPS_LONG_REF_EAST = "E"; + private static final String GPS_LONG_REF_WEST = "W"; + + private static final String GPS_DATE_FORMAT_STR = "yyyy:MM:dd"; private static final String TIFF_DATETIME_FORMAT = "yyyy:MM:dd kk:mm:ss"; + private static final DateFormat sExifGPSDateStamp = new SimpleDateFormat(GPS_DATE_FORMAT_STR); private static final DateFormat sDateTimeStampFormat = new SimpleDateFormat(TIFF_DATETIME_FORMAT); + private final Calendar mGPSTimeStampCalendar = Calendar + .getInstance(TimeZone.getTimeZone("UTC")); static { sDateTimeStampFormat.setTimeZone(TimeZone.getDefault()); + sExifGPSDateStamp.setTimeZone(TimeZone.getTimeZone("UTC")); + } + + private static final int DEFAULT_PIXEL_STRIDE = 2; // bytes per sample + private static final int BYTES_PER_RGB_PIX = 3; // byts per pixel + + /** + * Offset, rowStride, and pixelStride are given in bytes. Height and width are given in pixels. + */ + private void writeByteBuffer(int width, int height, ByteBuffer pixels, OutputStream dngOutput, + int pixelStride, int rowStride, long offset) throws IOException { + if (width <= 0 || height <= 0) { + throw new IllegalArgumentException("Image with invalid width, height: (" + width + "," + + height + ") passed to write"); + } + long capacity = pixels.capacity(); + long totalSize = rowStride * height + offset; + if (capacity < totalSize) { + throw new IllegalArgumentException("Image size " + capacity + + " is too small (must be larger than " + totalSize + ")"); + } + int minRowStride = pixelStride * width; + if (minRowStride > rowStride) { + throw new IllegalArgumentException("Invalid image pixel stride, row byte width " + + minRowStride + " is too large, expecting " + rowStride); + } + pixels.clear(); // Reset mark and limit + nativeWriteImage(dngOutput, width, height, pixels, rowStride, pixelStride, offset, + pixels.isDirect()); + pixels.clear(); + } + + /** + * Convert a single YUV pixel to RGB. + */ + private static void yuvToRgb(byte[] yuvData, int outOffset, /*out*/byte[] rgbOut) { + final int COLOR_MAX = 255; + + float y = yuvData[0] & 0xFF; // Y channel + float cb = yuvData[1] & 0xFF; // U channel + float cr = yuvData[2] & 0xFF; // V channel + + // convert YUV -> RGB (from JFIF's "Conversion to and from RGB" section) + float r = y + 1.402f * (cr - 128); + float g = y - 0.34414f * (cb - 128) - 0.71414f * (cr - 128); + float b = y + 1.772f * (cb - 128); + + // clamp to [0,255] + rgbOut[outOffset] = (byte) Math.max(0, Math.min(COLOR_MAX, r)); + rgbOut[outOffset + 1] = (byte) Math.max(0, Math.min(COLOR_MAX, g)); + rgbOut[outOffset + 2] = (byte) Math.max(0, Math.min(COLOR_MAX, b)); } + + /** + * Convert a single {@link Color} pixel to RGB. + */ + private static void colorToRgb(int color, int outOffset, /*out*/byte[] rgbOut) { + rgbOut[outOffset] = (byte) Color.red(color); + rgbOut[outOffset + 1] = (byte) Color.green(color); + rgbOut[outOffset + 2] = (byte) Color.blue(color); + // Discards Alpha + } + + /** + * Generate a direct RGB {@link ByteBuffer} from a YUV420_888 {@link Image}. + */ + private static ByteBuffer convertToRGB(Image yuvImage) { + // TODO: Optimize this with renderscript intrinsic. + int width = yuvImage.getWidth(); + int height = yuvImage.getHeight(); + ByteBuffer buf = ByteBuffer.allocateDirect(BYTES_PER_RGB_PIX * width * height); + + Image.Plane yPlane = yuvImage.getPlanes()[0]; + Image.Plane uPlane = yuvImage.getPlanes()[1]; + Image.Plane vPlane = yuvImage.getPlanes()[2]; + + ByteBuffer yBuf = yPlane.getBuffer(); + ByteBuffer uBuf = uPlane.getBuffer(); + ByteBuffer vBuf = vPlane.getBuffer(); + + yBuf.rewind(); + uBuf.rewind(); + vBuf.rewind(); + + int yRowStride = yPlane.getRowStride(); + int vRowStride = vPlane.getRowStride(); + int uRowStride = uPlane.getRowStride(); + + int yPixStride = yPlane.getPixelStride(); + int vPixStride = vPlane.getPixelStride(); + int uPixStride = uPlane.getPixelStride(); + + byte[] yuvPixel = { 0, 0, 0 }; + byte[] yFullRow = new byte[yPixStride * width]; + byte[] uFullRow = new byte[uPixStride * width / 2]; + byte[] vFullRow = new byte[vPixStride * width / 2]; + byte[] finalRow = new byte[BYTES_PER_RGB_PIX * width]; + for (int i = 0; i < height; i++) { + int halfH = i / 2; + yBuf.position(yRowStride * i); + yBuf.get(yFullRow); + uBuf.position(uRowStride * halfH); + uBuf.get(uFullRow); + vBuf.position(vRowStride * halfH); + vBuf.get(vFullRow); + for (int j = 0; j < width; j++) { + int halfW = j / 2; + yuvPixel[0] = yFullRow[yPixStride * j]; + yuvPixel[1] = uFullRow[uPixStride * halfW]; + yuvPixel[2] = vFullRow[vPixStride * halfW]; + yuvToRgb(yuvPixel, j * BYTES_PER_RGB_PIX, /*out*/finalRow); + } + buf.put(finalRow); + } + + yBuf.rewind(); + uBuf.rewind(); + vBuf.rewind(); + buf.rewind(); + return buf; + } + + /** + * Generate a direct RGB {@link ByteBuffer} from a {@link Bitmap}. + */ + private static ByteBuffer convertToRGB(Bitmap argbBitmap) { + // TODO: Optimize this. + int width = argbBitmap.getWidth(); + int height = argbBitmap.getHeight(); + ByteBuffer buf = ByteBuffer.allocateDirect(BYTES_PER_RGB_PIX * width * height); + + int[] pixelRow = new int[width]; + byte[] finalRow = new byte[BYTES_PER_RGB_PIX * width]; + for (int i = 0; i < height; i++) { + argbBitmap.getPixels(pixelRow, /*offset*/0, /*stride*/width, /*x*/0, /*y*/i, + /*width*/width, /*height*/1); + for (int j = 0; j < width; j++) { + colorToRgb(pixelRow[j], j * BYTES_PER_RGB_PIX, /*out*/finalRow); + } + buf.put(finalRow); + } + + buf.rewind(); + return buf; + } + + /** + * Convert coordinate to EXIF GPS tag format. + */ + private static int[] toExifLatLong(double value) { + // convert to the format dd/1 mm/1 ssss/100 + value = Math.abs(value); + int degrees = (int) value; + value = (value - degrees) * 60; + int minutes = (int) value; + value = (value - minutes) * 6000; + int seconds = (int) value; + return new int[] { degrees, 1, minutes, 1, seconds, 100 }; + } + /** * This field is used by native code, do not access or modify. */ @@ -381,24 +612,22 @@ public final class DngCreator implements AutoCloseable { private synchronized native void nativeSetOrientation(int orientation); - private synchronized native void nativeSetThumbnailBitmap(Bitmap bitmap); + private synchronized native void nativeSetDescription(String description); - private synchronized native void nativeSetThumbnailImage(int width, int height, - ByteBuffer yBuffer, int yRowStride, - int yPixStride, ByteBuffer uBuffer, - int uRowStride, int uPixStride, - ByteBuffer vBuffer, int vRowStride, - int vPixStride); + private synchronized native void nativeSetGpsTags(int[] latTag, String latRef, int[] longTag, + String longRef, String dateTag, + int[] timeTag); + + private synchronized native void nativeSetThumbnail(ByteBuffer buffer, int width, int height); private synchronized native void nativeWriteImage(OutputStream out, int width, int height, ByteBuffer rawBuffer, int rowStride, - int pixStride) throws IOException; - - private synchronized native void nativeWriteByteBuffer(OutputStream out, ByteBuffer rawBuffer, - long offset) throws IOException; + int pixStride, long offset, boolean isDirect) + throws IOException; private synchronized native void nativeWriteInputStream(OutputStream out, InputStream rawStream, - long offset) throws IOException; + int width, int height, long offset) + throws IOException; static { nativeClassInit(); diff --git a/core/java/android/hardware/camera2/impl/CameraMetadataNative.java b/core/java/android/hardware/camera2/impl/CameraMetadataNative.java index 83aee5d..6de5c25 100644 --- a/core/java/android/hardware/camera2/impl/CameraMetadataNative.java +++ b/core/java/android/hardware/camera2/impl/CameraMetadataNative.java @@ -27,6 +27,7 @@ import android.hardware.camera2.marshal.MarshalQueryable; import android.hardware.camera2.marshal.MarshalRegistry; import android.hardware.camera2.marshal.impl.MarshalQueryableArray; import android.hardware.camera2.marshal.impl.MarshalQueryableBoolean; +import android.hardware.camera2.marshal.impl.MarshalQueryableBlackLevelPattern; import android.hardware.camera2.marshal.impl.MarshalQueryableColorSpaceTransform; import android.hardware.camera2.marshal.impl.MarshalQueryableEnum; import android.hardware.camera2.marshal.impl.MarshalQueryableMeteringRectangle; @@ -1013,6 +1014,7 @@ public class CameraMetadataNative implements Parcelable { new MarshalQueryableStreamConfiguration(), new MarshalQueryableStreamConfigurationDuration(), new MarshalQueryableRggbChannelVector(), + new MarshalQueryableBlackLevelPattern(), // generic parcelable marshaler (MUST BE LAST since it has lowest priority) new MarshalQueryableParcelable(), diff --git a/core/java/android/hardware/camera2/legacy/PerfMeasurement.java b/core/java/android/hardware/camera2/legacy/PerfMeasurement.java new file mode 100644 index 0000000..b930ec2 --- /dev/null +++ b/core/java/android/hardware/camera2/legacy/PerfMeasurement.java @@ -0,0 +1,309 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.hardware.camera2.legacy; + +import android.os.SystemClock; +import android.util.Log; + +import java.io.BufferedWriter; +import java.io.File; +import java.io.FileWriter; +import java.io.IOException; +import java.util.ArrayList; +import java.util.LinkedList; +import java.util.Queue; + +/** + * GPU and CPU performance measurement for the legacy implementation. + * + * <p>Measures CPU and GPU processing duration for a set of operations, and dumps + * the results into a file.</p> + * + * <p>Rough usage: + * <pre> + * {@code + * <set up workload> + * <start long-running workload> + * mPerfMeasurement.startTimer(); + * ...render a frame... + * mPerfMeasurement.stopTimer(); + * <end workload> + * mPerfMeasurement.dumpPerformanceData("/sdcard/my_data.txt"); + * } + * </pre> + * </p> + * + * <p>All calls to this object must be made within the same thread, and the same GL context. + * PerfMeasurement cannot be used outside of a GL context. The only exception is + * dumpPerformanceData, which can be called outside of a valid GL context.</p> + */ +class PerfMeasurement { + private static final String TAG = "PerfMeasurement"; + + public static final int DEFAULT_MAX_QUERIES = 3; + + private final long mNativeContext; + + private int mCompletedQueryCount = 0; + + /** + * Values for completed measurements + */ + private ArrayList<Long> mCollectedGpuDurations = new ArrayList<>(); + private ArrayList<Long> mCollectedCpuDurations = new ArrayList<>(); + private ArrayList<Long> mCollectedTimestamps = new ArrayList<>(); + + /** + * Values for in-progress measurements (waiting for async GPU results) + */ + private Queue<Long> mTimestampQueue = new LinkedList<>(); + private Queue<Long> mCpuDurationsQueue = new LinkedList<>(); + + private long mStartTimeNs; + + /** + * The value returned by {@link #nativeGetNextGlDuration} if no new timing + * measurement is available since the last call. + */ + private static final long NO_DURATION_YET = -1l; + + /** + * The value returned by {@link #nativeGetNextGlDuration} if timing failed for + * the next timing interval + */ + private static final long FAILED_TIMING = -2l; + + /** + * Create a performance measurement object with a maximum of {@value #DEFAULT_MAX_QUERIES} + * in-progess queries. + */ + public PerfMeasurement() { + mNativeContext = nativeCreateContext(DEFAULT_MAX_QUERIES); + } + + /** + * Create a performance measurement object with maxQueries as the maximum number of + * in-progress queries. + * + * @param maxQueries maximum in-progress queries, must be larger than 0. + * @throws IllegalArgumentException if maxQueries is less than 1. + */ + public PerfMeasurement(int maxQueries) { + if (maxQueries < 1) throw new IllegalArgumentException("maxQueries is less than 1"); + mNativeContext = nativeCreateContext(maxQueries); + } + + /** + * Returns true if the Gl timing methods will work, false otherwise. + * + * <p>Must be called within a valid GL context.</p> + */ + public static boolean isGlTimingSupported() { + return nativeQuerySupport(); + } + + /** + * Dump collected data to file, and clear the stored data. + * + * <p> + * Format is a simple csv-like text file with a header, + * followed by a 3-column list of values in nanoseconds: + * <pre> + * timestamp gpu_duration cpu_duration + * <long> <long> <long> + * <long> <long> <long> + * <long> <long> <long> + * .... + * </pre> + * </p> + */ + public void dumpPerformanceData(String path) { + try (BufferedWriter dump = new BufferedWriter(new FileWriter(path))) { + dump.write("timestamp gpu_duration cpu_duration\n"); + for (int i = 0; i < mCollectedGpuDurations.size(); i++) { + dump.write(String.format("%d %d %d\n", + mCollectedTimestamps.get(i), + mCollectedGpuDurations.get(i), + mCollectedCpuDurations.get(i))); + } + mCollectedTimestamps.clear(); + mCollectedGpuDurations.clear(); + mCollectedCpuDurations.clear(); + } catch (IOException e) { + Log.e(TAG, "Error writing data dump to " + path + ":" + e); + } + } + + /** + * Start a GPU/CPU timing measurement. + * + * <p>Call before starting a rendering pass. Only one timing measurement can be active at once, + * so {@link #stopTimer} must be called before the next call to this method.</p> + * + * @throws IllegalStateException if the maximum number of queries are in progress already, + * or the method is called multiple times in a row, or there is + * a GPU error. + */ + public void startTimer() { + nativeStartGlTimer(mNativeContext); + mStartTimeNs = SystemClock.elapsedRealtimeNanos(); + } + + /** + * Finish a GPU/CPU timing measurement. + * + * <p>Call after finishing all the drawing for a rendering pass. Only one timing measurement can + * be active at once, so {@link #startTimer} must be called before the next call to this + * method.</p> + * + * @throws IllegalStateException if no GL timer is currently started, or there is a GPU + * error. + */ + public void stopTimer() { + // Complete CPU timing + long endTimeNs = SystemClock.elapsedRealtimeNanos(); + mCpuDurationsQueue.add(endTimeNs - mStartTimeNs); + // Complete GL timing + nativeStopGlTimer(mNativeContext); + + // Poll to see if GL timing results have arrived; if so + // store the results for a frame + long duration = getNextGlDuration(); + if (duration > 0) { + mCollectedGpuDurations.add(duration); + mCollectedTimestamps.add(mTimestampQueue.isEmpty() ? + NO_DURATION_YET : mTimestampQueue.poll()); + mCollectedCpuDurations.add(mCpuDurationsQueue.isEmpty() ? + NO_DURATION_YET : mCpuDurationsQueue.poll()); + } + if (duration == FAILED_TIMING) { + // Discard timestamp and CPU measurement since GPU measurement failed + if (!mTimestampQueue.isEmpty()) { + mTimestampQueue.poll(); + } + if (!mCpuDurationsQueue.isEmpty()) { + mCpuDurationsQueue.poll(); + } + } + } + + /** + * Add a timestamp to a timing measurement. These are queued up and matched to completed + * workload measurements as they become available. + */ + public void addTimestamp(long timestamp) { + mTimestampQueue.add(timestamp); + } + + /** + * Get the next available GPU timing measurement. + * + * <p>Since the GPU works asynchronously, the results of a single start/stopGlTimer measurement + * will only be available some time after the {@link #stopTimer} call is made. Poll this method + * until the result becomes available. If multiple start/endTimer measurements are made in a + * row, the results will be available in FIFO order.</p> + * + * @return The measured duration of the GPU workload for the next pending query, or + * {@link #NO_DURATION_YET} if no queries are pending or the next pending query has not + * yet finished, or {@link #FAILED_TIMING} if the GPU was unable to complete the + * measurement. + * + * @throws IllegalStateException If there is a GPU error. + * + */ + private long getNextGlDuration() { + long duration = nativeGetNextGlDuration(mNativeContext); + if (duration > 0) { + mCompletedQueryCount++; + } + return duration; + } + + /** + * Returns the number of measurements so far that returned a valid duration + * measurement. + */ + public int getCompletedQueryCount() { + return mCompletedQueryCount; + } + + @Override + protected void finalize() { + nativeDeleteContext(mNativeContext); + } + + /** + * Create a native performance measurement context. + * + * @param maxQueryCount maximum in-progress queries; must be >= 1. + */ + private static native long nativeCreateContext(int maxQueryCount); + + /** + * Delete the native context. + * + * <p>Not safe to call more than once.</p> + */ + private static native void nativeDeleteContext(long contextHandle); + + /** + * Query whether the relevant Gl extensions are available for Gl timing + */ + private static native boolean nativeQuerySupport(); + + /** + * Start a GL timing section. + * + * <p>All GL commands between this method and the next {@link #nativeEndGlTimer} will be + * included in the timing.</p> + * + * <p>Must be called from the same thread as calls to {@link #nativeEndGlTimer} and + * {@link #nativeGetNextGlDuration}.</p> + * + * @throws IllegalStateException if a GL error occurs or start is called repeatedly. + */ + protected static native void nativeStartGlTimer(long contextHandle); + + /** + * Finish a GL timing section. + * + * <p>Some time after this call returns, the time the GPU took to + * execute all work submitted between the latest {@link #nativeStartGlTimer} and + * this call, will become available from calling {@link #nativeGetNextGlDuration}.</p> + * + * <p>Must be called from the same thread as calls to {@link #nativeStartGlTimer} and + * {@link #nativeGetNextGlDuration}.</p> + * + * @throws IllegalStateException if a GL error occurs or stop is called before start + */ + protected static native void nativeStopGlTimer(long contextHandle); + + /** + * Get the next available GL duration measurement, in nanoseconds. + * + * <p>Must be called from the same thread as calls to {@link #nativeStartGlTimer} and + * {@link #nativeEndGlTimer}.</p> + * + * @return the next GL duration measurement, or {@link #NO_DURATION_YET} if + * no new measurement is available, or {@link #FAILED_TIMING} if timing + * failed for the next duration measurement. + * @throws IllegalStateException if a GL error occurs + */ + protected static native long nativeGetNextGlDuration(long contextHandle); + + +} diff --git a/core/java/android/hardware/camera2/legacy/SurfaceTextureRenderer.java b/core/java/android/hardware/camera2/legacy/SurfaceTextureRenderer.java index 9969fd2..daa64c0 100644 --- a/core/java/android/hardware/camera2/legacy/SurfaceTextureRenderer.java +++ b/core/java/android/hardware/camera2/legacy/SurfaceTextureRenderer.java @@ -17,6 +17,7 @@ package android.hardware.camera2.legacy; import android.graphics.ImageFormat; import android.graphics.SurfaceTexture; +import android.os.Environment; import android.opengl.EGL14; import android.opengl.EGLConfig; import android.opengl.EGLContext; @@ -25,10 +26,13 @@ import android.opengl.EGLSurface; import android.opengl.GLES11Ext; import android.opengl.GLES20; import android.opengl.Matrix; +import android.text.format.Time; import android.util.Log; import android.util.Size; import android.view.Surface; +import android.os.SystemProperties; +import java.io.File; import java.nio.ByteBuffer; import java.nio.ByteOrder; import java.nio.FloatBuffer; @@ -126,6 +130,9 @@ public class SurfaceTextureRenderer { private int maPositionHandle; private int maTextureHandle; + private PerfMeasurement mPerfMeasurer = null; + private static final String LEGACY_PERF_PROPERTY = "persist.camera.legacy_perf"; + public SurfaceTextureRenderer() { mTriangleVertices = ByteBuffer.allocateDirect(mTriangleVerticesData.length * FLOAT_SIZE_BYTES).order(ByteOrder.nativeOrder()).asFloatBuffer(); @@ -219,7 +226,6 @@ public class SurfaceTextureRenderer { GLES20.glDrawArrays(GLES20.GL_TRIANGLE_STRIP, /*offset*/ 0, /*count*/ 4); checkGlError("glDrawArrays"); - GLES20.glFinish(); } /** @@ -327,9 +333,16 @@ public class SurfaceTextureRenderer { EGL14.EGL_NONE }; for (EGLSurfaceHolder holder : surfaces) { - holder.eglSurface = EGL14.eglCreateWindowSurface(mEGLDisplay, mConfigs, holder.surface, - surfaceAttribs, 0); - checkEglError("eglCreateWindowSurface"); + try { + Size size = LegacyCameraDevice.getSurfaceSize(holder.surface); + holder.width = size.getWidth(); + holder.height = size.getHeight(); + holder.eglSurface = EGL14.eglCreateWindowSurface(mEGLDisplay, mConfigs, + holder.surface, surfaceAttribs, /*offset*/ 0); + checkEglError("eglCreateWindowSurface"); + } catch (LegacyExceptionUtils.BufferQueueAbandonedException e) { + Log.w(TAG, "Surface abandoned, skipping...", e); + } } } @@ -367,6 +380,7 @@ public class SurfaceTextureRenderer { if (mEGLDisplay != EGL14.EGL_NO_DISPLAY) { EGL14.eglMakeCurrent(mEGLDisplay, EGL14.EGL_NO_SURFACE, EGL14.EGL_NO_SURFACE, EGL14.EGL_NO_CONTEXT); + dumpGlTiming(); if (mSurfaces != null) { for (EGLSurfaceHolder holder : mSurfaces) { if (holder.eglSurface != null) { @@ -418,6 +432,65 @@ public class SurfaceTextureRenderer { } /** + * Save a measurement dump to disk, in + * {@code /sdcard/CameraLegacy/durations_<time>_<width1>x<height1>_...txt} + */ + private void dumpGlTiming() { + if (mPerfMeasurer == null) return; + + File legacyStorageDir = new File(Environment.getExternalStorageDirectory(), "CameraLegacy"); + if (!legacyStorageDir.exists()){ + if (!legacyStorageDir.mkdirs()){ + Log.e(TAG, "Failed to create directory for data dump"); + return; + } + } + + StringBuilder path = new StringBuilder(legacyStorageDir.getPath()); + path.append(File.separator); + path.append("durations_"); + + Time now = new Time(); + now.setToNow(); + path.append(now.format2445()); + path.append("_S"); + for (EGLSurfaceHolder surface : mSurfaces) { + path.append(String.format("_%d_%d", surface.width, surface.height)); + } + path.append("_C"); + for (EGLSurfaceHolder surface : mConversionSurfaces) { + path.append(String.format("_%d_%d", surface.width, surface.height)); + } + path.append(".txt"); + mPerfMeasurer.dumpPerformanceData(path.toString()); + } + + private void setupGlTiming() { + if (PerfMeasurement.isGlTimingSupported()) { + Log.d(TAG, "Enabling GL performance measurement"); + mPerfMeasurer = new PerfMeasurement(); + } else { + Log.d(TAG, "GL performance measurement not supported on this device"); + mPerfMeasurer = null; + } + } + + private void beginGlTiming() { + if (mPerfMeasurer == null) return; + mPerfMeasurer.startTimer(); + } + + private void addGlTimestamp(long timestamp) { + if (mPerfMeasurer == null) return; + mPerfMeasurer.addTimestamp(timestamp); + } + + private void endGlTiming() { + if (mPerfMeasurer == null) return; + mPerfMeasurer.stopTimer(); + } + + /** * Return the surface texture to draw to - this is the texture use to when producing output * surface buffers. * @@ -474,6 +547,11 @@ public class SurfaceTextureRenderer { mConversionSurfaces.get(0).eglSurface); initializeGLState(); mSurfaceTexture = new SurfaceTexture(getTextureId()); + + // Set up performance tracking if enabled + if (SystemProperties.getBoolean(LEGACY_PERF_PROPERTY, false)) { + setupGlTiming(); + } } /** @@ -494,8 +572,19 @@ public class SurfaceTextureRenderer { } checkGlError("before updateTexImage"); + + if (targetSurfaces == null) { + mSurfaceTexture.updateTexImage(); + return; + } + + beginGlTiming(); + mSurfaceTexture.updateTexImage(); - if (targetSurfaces == null) return; + + long timestamp = mSurfaceTexture.getTimestamp(); + addGlTimestamp(timestamp); + List<Long> targetSurfaceIds = LegacyCameraDevice.getSurfaceIds(targetSurfaces); for (EGLSurfaceHolder holder : mSurfaces) { if (LegacyCameraDevice.containsSurfaceId(holder.surface, targetSurfaceIds)) { @@ -522,6 +611,8 @@ public class SurfaceTextureRenderer { } } } + + endGlTiming(); } /** diff --git a/core/java/android/hardware/camera2/marshal/impl/MarshalQueryableBlackLevelPattern.java b/core/java/android/hardware/camera2/marshal/impl/MarshalQueryableBlackLevelPattern.java new file mode 100644 index 0000000..bcb035e --- /dev/null +++ b/core/java/android/hardware/camera2/marshal/impl/MarshalQueryableBlackLevelPattern.java @@ -0,0 +1,76 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package android.hardware.camera2.marshal.impl; + +import android.hardware.camera2.marshal.MarshalQueryable; +import android.hardware.camera2.marshal.Marshaler; +import android.hardware.camera2.params.BlackLevelPattern; +import android.hardware.camera2.utils.TypeReference; + +import java.nio.ByteBuffer; + +import static android.hardware.camera2.impl.CameraMetadataNative.TYPE_INT32; +import static android.hardware.camera2.marshal.MarshalHelpers.SIZEOF_INT32; + +/** + * Marshal {@link BlackLevelPattern} to/from {@link #TYPE_INT32} {@code x 4} + */ +public class MarshalQueryableBlackLevelPattern implements MarshalQueryable<BlackLevelPattern> { + private static final int SIZE = SIZEOF_INT32 * BlackLevelPattern.COUNT; + + private class MarshalerBlackLevelPattern extends Marshaler<BlackLevelPattern> { + protected MarshalerBlackLevelPattern(TypeReference<BlackLevelPattern> typeReference, + int nativeType) { + super(MarshalQueryableBlackLevelPattern.this, typeReference, nativeType); + } + + @Override + public void marshal(BlackLevelPattern value, ByteBuffer buffer) { + for (int i = 0; i < BlackLevelPattern.COUNT / 2; ++i) { + for (int j = 0; j < BlackLevelPattern.COUNT / 2; ++j) { + buffer.putInt(value.getOffsetForIndex(j, i)); + } + } + } + + @Override + public BlackLevelPattern unmarshal(ByteBuffer buffer) { + int[] channelOffsets = new int[BlackLevelPattern.COUNT]; + for (int i = 0; i < BlackLevelPattern.COUNT; ++i) { + channelOffsets[i] = buffer.getInt(); + } + return new BlackLevelPattern(channelOffsets); + } + + @Override + public int getNativeSize() { + return SIZE; + } + } + + @Override + public Marshaler<BlackLevelPattern> createMarshaler( + TypeReference<BlackLevelPattern> managedType, int nativeType) { + return new MarshalerBlackLevelPattern(managedType, nativeType); + } + + @Override + public boolean isTypeMappingSupported( + TypeReference<BlackLevelPattern> managedType, int nativeType) { + return nativeType == TYPE_INT32 && + (BlackLevelPattern.class.equals(managedType.getType())); + } +} diff --git a/core/java/android/hardware/camera2/params/BlackLevelPattern.java b/core/java/android/hardware/camera2/params/BlackLevelPattern.java new file mode 100644 index 0000000..a09f3d9 --- /dev/null +++ b/core/java/android/hardware/camera2/params/BlackLevelPattern.java @@ -0,0 +1,128 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.hardware.camera2.params; + +import java.util.Arrays; + +import static com.android.internal.util.Preconditions.checkNotNull; + +/** + * Immutable class to store a 4-element vector of integers corresponding to a 2x2 pattern + * of color channel offsets used for the black level offsets of each color channel. + */ +public final class BlackLevelPattern { + + /** + * The number of offsets in this vector. + */ + public static final int COUNT = 4; + + /** + * Create a new {@link BlackLevelPattern} from a given offset array. + * + * <p>The given offset array must contain offsets for each color channel in + * a 2x2 pattern corresponding to the color filter arrangement. Offsets are + * given in row-column scan order.</p> + * + * @param offsets an array containing a 2x2 pattern of offsets. + * + * @throws IllegalArgumentException if the given array has an incorrect length. + * @throws NullPointerException if the given array is null. + * @hide + */ + public BlackLevelPattern(int[] offsets) { + if (offsets == null) { + throw new NullPointerException("Null offsets array passed to constructor"); + } + if (offsets.length < COUNT) { + throw new IllegalArgumentException("Invalid offsets array length"); + } + mCfaOffsets = Arrays.copyOf(offsets, COUNT); + } + + /** + * Return the color channel offset for a given index into the array of raw pixel values. + * + * @param column the column index in the the raw pixel array. + * @param row the row index in the raw pixel array. + * @return a color channel offset. + * + * @throws IllegalArgumentException if a column or row given is negative. + */ + public int getOffsetForIndex(int column, int row) { + if (row < 0 || column < 0) { + throw new IllegalArgumentException("column, row arguments must be positive"); + } + return mCfaOffsets[((row & 1) << 1) | (column & 1)]; + } + + /** + * Copy the ColorChannel offsets into the destination vector. + * + * <p>Offsets are given in row-column scan order for a given 2x2 color pattern.</p> + * + * @param destination an array big enough to hold at least {@value #COUNT} elements after the + * {@code offset} + * @param offset a non-negative offset into the array + * + * @throws IllegalArgumentException if the offset is invalid. + * @throws ArrayIndexOutOfBoundsException if the destination vector is too small. + * @throws NullPointerException if the destination is null. + */ + public void copyTo(int[] destination, int offset) { + checkNotNull(destination, "destination must not be null"); + if (offset < 0) { + throw new IllegalArgumentException("Null offset passed to copyTo"); + } + if (destination.length - offset < COUNT) { + throw new ArrayIndexOutOfBoundsException("destination too small to fit elements"); + } + for (int i = 0; i < COUNT; ++i) { + destination[offset + i] = mCfaOffsets[i]; + } + } + + /** + * Check if this {@link BlackLevelPattern} is equal to another {@link BlackLevelPattern}. + * + * <p>Two vectors are only equal if and only if each of the respective elements is equal.</p> + * + * @return {@code true} if the objects were equal, {@code false} otherwise + */ + @Override + public boolean equals(Object obj) { + if (obj == null) { + return false; + } else if (this == obj) { + return true; + } else if (obj instanceof BlackLevelPattern) { + final BlackLevelPattern other = (BlackLevelPattern) obj; + return Arrays.equals(other.mCfaOffsets, mCfaOffsets); + } + return false; + } + + /** + * {@inheritDoc} + */ + @Override + public int hashCode() { + return Arrays.hashCode(mCfaOffsets); + } + + private final int[] mCfaOffsets; +} diff --git a/core/java/android/hardware/camera2/params/RggbChannelVector.java b/core/java/android/hardware/camera2/params/RggbChannelVector.java index 30591f6..cf3e1de 100644 --- a/core/java/android/hardware/camera2/params/RggbChannelVector.java +++ b/core/java/android/hardware/camera2/params/RggbChannelVector.java @@ -146,7 +146,7 @@ public final class RggbChannelVector { */ public void copyTo(final float[] destination, final int offset) { checkNotNull(destination, "destination must not be null"); - if (destination.length + offset < COUNT) { + if (destination.length - offset < COUNT) { throw new ArrayIndexOutOfBoundsException("destination too small to fit elements"); } @@ -167,11 +167,9 @@ public final class RggbChannelVector { public boolean equals(final Object obj) { if (obj == null) { return false; - } - if (this == obj) { + } else if (this == obj) { return true; - } - if (obj instanceof RggbChannelVector) { + } else if (obj instanceof RggbChannelVector) { final RggbChannelVector other = (RggbChannelVector) obj; return mRed == other.mRed && mGreenEven == other.mGreenEven && diff --git a/core/java/android/hardware/hdmi/HdmiClient.java b/core/java/android/hardware/hdmi/HdmiClient.java index bb0f4ba..c43e21a 100644 --- a/core/java/android/hardware/hdmi/HdmiClient.java +++ b/core/java/android/hardware/hdmi/HdmiClient.java @@ -24,6 +24,29 @@ public abstract class HdmiClient { mService = service; } + /** + * Send a key event to other logical device. + * + * @param keyCode key code to send. Defined in {@link android.view.KeyEvent}. + * @param isPressed true if this is key press event + */ + public void sendKeyEvent(int keyCode, boolean isPressed) { + try { + mService.sendKeyEvent(getDeviceType(), keyCode, isPressed); + } catch (RemoteException e) { + Log.e(TAG, "queryDisplayStatus threw exception ", e); + } + } + + /** + * Send vendor-specific command. + * + * @param targetAddress address of the target device + * @param params vendor-specific parameter. For <Vendor Command With ID> do not + * include the first 3 bytes (vendor ID). + * @param hasVendorId {@code true} if the command type will be <Vendor Command With ID>. + * {@code false} if the command will be <Vendor Command> + */ public void sendVendorCommand(int targetAddress, byte[] params, boolean hasVendorId) { try { mService.sendVendorCommand(getDeviceType(), targetAddress, params, hasVendorId); @@ -32,6 +55,11 @@ public abstract class HdmiClient { } } + /** + * Add a listener used to receive incoming vendor-specific command. + * + * @param listener listener object + */ public void addVendorCommandListener(VendorCommandListener listener) { try { mService.addVendorCommandListener(getListenerWrapper(listener), getDeviceType()); diff --git a/core/java/android/hardware/hdmi/IHdmiControlService.aidl b/core/java/android/hardware/hdmi/IHdmiControlService.aidl index 3a477fb..f3931e3 100644 --- a/core/java/android/hardware/hdmi/IHdmiControlService.aidl +++ b/core/java/android/hardware/hdmi/IHdmiControlService.aidl @@ -43,7 +43,7 @@ interface IHdmiControlService { void addDeviceEventListener(IHdmiDeviceEventListener listener); void deviceSelect(int logicalAddress, IHdmiControlCallback callback); void portSelect(int portId, IHdmiControlCallback callback); - void sendKeyEvent(int keyCode, boolean isPressed); + void sendKeyEvent(int deviceType, int keyCode, boolean isPressed); List<HdmiPortInfo> getPortInfo(); boolean canChangeSystemAudioMode(); boolean getSystemAudioMode(); diff --git a/core/java/android/hardware/location/GeofenceHardware.java b/core/java/android/hardware/location/GeofenceHardware.java index 4c074e9..2d7b7e1 100644 --- a/core/java/android/hardware/location/GeofenceHardware.java +++ b/core/java/android/hardware/location/GeofenceHardware.java @@ -56,8 +56,6 @@ public final class GeofenceHardware { /** * Constant for geofence monitoring done by the Fused hardware. - * - * @hide */ public static final int MONITORING_TYPE_FUSED_HARDWARE = 1; @@ -128,8 +126,6 @@ public final class GeofenceHardware { /** * The constant used to indicate that the operation failed due to insufficient memory. - * - * @hide */ public static final int GEOFENCE_ERROR_INSUFFICIENT_MEMORY = 6; diff --git a/core/java/android/service/voice/DspInfo.java b/core/java/android/hardware/soundtrigger/DspInfo.java index 0862309..517159d 100644 --- a/core/java/android/service/voice/DspInfo.java +++ b/core/java/android/hardware/soundtrigger/DspInfo.java @@ -1,4 +1,4 @@ -/* +/** * Copyright (C) 2014 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); @@ -14,12 +14,13 @@ * limitations under the License. */ -package android.service.voice; +package android.hardware.soundtrigger; import java.util.UUID; /** * Properties of the DSP hardware on the device. + * * @hide */ public class DspInfo { diff --git a/core/java/android/hardware/soundtrigger/Keyphrase.aidl b/core/java/android/hardware/soundtrigger/Keyphrase.aidl new file mode 100644 index 0000000..d9853a7 --- /dev/null +++ b/core/java/android/hardware/soundtrigger/Keyphrase.aidl @@ -0,0 +1,4 @@ +package android.hardware.soundtrigger; + +// @hide +parcelable Keyphrase;
\ No newline at end of file diff --git a/core/java/android/hardware/soundtrigger/Keyphrase.java b/core/java/android/hardware/soundtrigger/Keyphrase.java new file mode 100644 index 0000000..42fd350 --- /dev/null +++ b/core/java/android/hardware/soundtrigger/Keyphrase.java @@ -0,0 +1,101 @@ +/** + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.hardware.soundtrigger; + +import android.os.Parcel; +import android.os.Parcelable; + +/** + * A Voice Keyphrase. + * + * @hide + */ +public class Keyphrase implements Parcelable { + /** A unique identifier for this keyphrase */ + public final int id; + /** A hint text to display corresponding to this keyphrase, e.g. "Hello There". */ + public final String hintText; + /** The locale of interest when using this Keyphrase. */ + public String locale; + + public static final Parcelable.Creator<Keyphrase> CREATOR + = new Parcelable.Creator<Keyphrase>() { + public Keyphrase createFromParcel(Parcel in) { + return Keyphrase.fromParcel(in); + } + + public Keyphrase[] newArray(int size) { + return new Keyphrase[size]; + } + }; + + private static Keyphrase fromParcel(Parcel in) { + return new Keyphrase(in.readInt(), in.readString(), in.readString()); + } + + public Keyphrase(int id, String hintText, String locale) { + this.id = id; + this.hintText = hintText; + this.locale = locale; + } + + @Override + public void writeToParcel(Parcel dest, int flags) { + dest.writeInt(id); + dest.writeString(hintText); + dest.writeString(locale); + } + + @Override + public int describeContents() { + return 0; + } + + @Override + public int hashCode() { + final int prime = 31; + int result = 1; + result = prime * result + ((hintText == null) ? 0 : hintText.hashCode()); + result = prime * result + id; + result = prime * result + ((locale == null) ? 0 : locale.hashCode()); + return result; + } + + @Override + public boolean equals(Object obj) { + if (this == obj) + return true; + if (obj == null) + return false; + if (getClass() != obj.getClass()) + return false; + Keyphrase other = (Keyphrase) obj; + if (hintText == null) { + if (other.hintText != null) + return false; + } else if (!hintText.equals(other.hintText)) + return false; + if (id != other.id) + return false; + if (locale == null) { + if (other.locale != null) + return false; + } else if (!locale.equals(other.locale)) + return false; + return true; + } +} diff --git a/core/java/android/service/voice/KeyphraseEnrollmentInfo.java b/core/java/android/hardware/soundtrigger/KeyphraseEnrollmentInfo.java index ebe41ce..2f5de6a 100644 --- a/core/java/android/service/voice/KeyphraseEnrollmentInfo.java +++ b/core/java/android/hardware/soundtrigger/KeyphraseEnrollmentInfo.java @@ -1,4 +1,4 @@ -/* +/** * Copyright (C) 2014 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); @@ -14,7 +14,7 @@ * limitations under the License. */ -package android.service.voice; +package android.hardware.soundtrigger; import android.Manifest; import android.content.Intent; @@ -24,6 +24,7 @@ import android.content.pm.ResolveInfo; import android.content.res.Resources; import android.content.res.TypedArray; import android.content.res.XmlResourceParser; +import android.service.voice.AlwaysOnHotwordDetector; import android.util.AttributeSet; import android.util.Slog; import android.util.Xml; @@ -34,7 +35,11 @@ import org.xmlpull.v1.XmlPullParserException; import java.io.IOException; import java.util.List; -/** @hide */ +/** + * Enrollment information about the different available keyphrases. + * + * @hide + */ public class KeyphraseEnrollmentInfo { private static final String TAG = "KeyphraseEnrollmentInfo"; /** @@ -53,10 +58,14 @@ public class KeyphraseEnrollmentInfo { public static final String ACTION_MANAGE_VOICE_KEYPHRASES = "com.android.intent.action.MANAGE_VOICE_KEYPHRASES"; /** - * Intent extra: The intent extra for un-enrolling a user for a particular keyphrase. + * Intent extra: The intent extra for the specific manage action that needs to be performed. + * Possible values are {@link AlwaysOnHotwordDetector#MANAGE_ACTION_ENROLL}, + * {@link AlwaysOnHotwordDetector#MANAGE_ACTION_RE_ENROLL} + * or {@link AlwaysOnHotwordDetector#MANAGE_ACTION_UN_ENROLL}. */ - public static final String EXTRA_VOICE_KEYPHRASE_UNENROLL = - "com.android.intent.extra.VOICE_KEYPHRASE_UNENROLL"; + public static final String EXTRA_VOICE_KEYPHRASE_ACTION = + "com.android.intent.extra.VOICE_KEYPHRASE_ACTION"; + /** * Intent extra: The hint text to be shown on the voice keyphrase management UI. */ @@ -68,7 +77,7 @@ public class KeyphraseEnrollmentInfo { public static final String EXTRA_VOICE_KEYPHRASE_LOCALE = "com.android.intent.extra.VOICE_KEYPHRASE_LOCALE"; - private KeyphraseInfo[] mKeyphrases; + private KeyphraseMetadata[] mKeyphrases; private String mEnrollmentPackage; private String mParseError; @@ -156,8 +165,8 @@ public class KeyphraseEnrollmentInfo { && !searchKeyphraseSupportedLocales.isEmpty()) { supportedLocales = searchKeyphraseSupportedLocales.split(","); } - mKeyphrases = new KeyphraseInfo[1]; - mKeyphrases[0] = new KeyphraseInfo( + mKeyphrases = new KeyphraseMetadata[1]; + mKeyphrases[0] = new KeyphraseMetadata( searchKeyphraseId, searchKeyphrase, supportedLocales); } else { mParseError = "searchKeyphraseId not specified in meta-data"; @@ -188,7 +197,7 @@ public class KeyphraseEnrollmentInfo { * @return An array of available keyphrases that can be enrolled on the system. * It may be null if no keyphrases can be enrolled. */ - public KeyphraseInfo[] getKeyphrases() { + public KeyphraseMetadata[] listKeyphraseMetadata() { return mKeyphrases; } @@ -196,51 +205,56 @@ public class KeyphraseEnrollmentInfo { * Returns an intent to launch an activity that manages the given keyphrase * for the locale. * - * @param enroll Indicates if the intent should enroll the user or un-enroll them. + * @param action The enrollment related action that this intent is supposed to perform. + * This can be one of {@link AlwaysOnHotwordDetector#MANAGE_ACTION_ENROLL}, + * {@link AlwaysOnHotwordDetector#MANAGE_ACTION_RE_ENROLL} + * or {@link AlwaysOnHotwordDetector#MANAGE_ACTION_UN_ENROLL} * @param keyphrase The keyphrase that the user needs to be enrolled to. * @param locale The locale for which the enrollment needs to be performed. + * This is a Java locale, for example "en_US". * @return An {@link Intent} to manage the keyphrase. This can be null if managing the * given keyphrase/locale combination isn't possible. */ - public Intent getManageKeyphraseIntent(boolean enroll, String keyphrase, String locale) { + public Intent getManageKeyphraseIntent(int action, String keyphrase, String locale) { if (mEnrollmentPackage == null || mEnrollmentPackage.isEmpty()) { Slog.w(TAG, "No enrollment application exists"); return null; } - if (isKeyphraseEnrollmentSupported(keyphrase, locale)) { + if (getKeyphraseMetadata(keyphrase, locale) != null) { Intent intent = new Intent(ACTION_MANAGE_VOICE_KEYPHRASES) .setPackage(mEnrollmentPackage) .putExtra(EXTRA_VOICE_KEYPHRASE_HINT_TEXT, keyphrase) - .putExtra(EXTRA_VOICE_KEYPHRASE_LOCALE, locale); - if (!enroll) intent.putExtra(EXTRA_VOICE_KEYPHRASE_UNENROLL, true); + .putExtra(EXTRA_VOICE_KEYPHRASE_LOCALE, locale) + .putExtra(EXTRA_VOICE_KEYPHRASE_ACTION, action); return intent; } return null; } /** - * Indicates if enrollment is supported for the given keyphrase & locale. + * Gets the {@link KeyphraseMetadata} for the given keyphrase and locale, null if any metadata + * isn't available for the given combination. * * @param keyphrase The keyphrase that the user needs to be enrolled to. * @param locale The locale for which the enrollment needs to be performed. + * This is a Java locale, for example "en_US". * @return true, if an enrollment client supports the given keyphrase and the given locale. */ - public boolean isKeyphraseEnrollmentSupported(String keyphrase, String locale) { + public KeyphraseMetadata getKeyphraseMetadata(String keyphrase, String locale) { if (mKeyphrases == null || mKeyphrases.length == 0) { Slog.w(TAG, "Enrollment application doesn't support keyphrases"); - return false; + return null; } - for (KeyphraseInfo keyphraseInfo : mKeyphrases) { + for (KeyphraseMetadata keyphraseMetadata : mKeyphrases) { // Check if the given keyphrase is supported in the locale provided by // the enrollment application. - String supportedKeyphrase = keyphraseInfo.keyphrase; - if (supportedKeyphrase.equalsIgnoreCase(keyphrase) - && keyphraseInfo.supportedLocales.contains(locale)) { - return true; + if (keyphraseMetadata.supportsPhrase(keyphrase) + && keyphraseMetadata.supportsLocale(locale)) { + return keyphraseMetadata; } } - Slog.w(TAG, "Enrollment application doesn't support the given keyphrase"); - return false; + Slog.w(TAG, "Enrollment application doesn't support the given keyphrase/locale"); + return null; } } diff --git a/core/java/android/hardware/soundtrigger/KeyphraseMetadata.java b/core/java/android/hardware/soundtrigger/KeyphraseMetadata.java new file mode 100644 index 0000000..03a4939 --- /dev/null +++ b/core/java/android/hardware/soundtrigger/KeyphraseMetadata.java @@ -0,0 +1,60 @@ +/** + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.hardware.soundtrigger; + +import android.util.ArraySet; + +/** + * A Voice Keyphrase metadata read from the enrollment application. + * + * @hide + */ +public class KeyphraseMetadata { + public final int id; + public final String keyphrase; + public final ArraySet<String> supportedLocales; + + public KeyphraseMetadata(int id, String keyphrase, String[] supportedLocales) { + this.id = id; + this.keyphrase = keyphrase; + this.supportedLocales = new ArraySet<String>(supportedLocales.length); + for (String locale : supportedLocales) { + this.supportedLocales.add(locale); + } + } + + @Override + public String toString() { + return "id=" + id + ", keyphrase=" + keyphrase + ", supported-locales=" + supportedLocales; + } + + /** + * @return Indicates if we support the given phrase. + */ + public boolean supportsPhrase(String phrase) { + // TODO(sansid): Come up with a scheme for custom keyphrases that should always match. + return keyphrase.equalsIgnoreCase(phrase); + } + + /** + * @return Indicates if we support the given locale. + */ + public boolean supportsLocale(String locale) { + // TODO(sansid): Come up with a scheme for keyphrases that are available in all locales. + return supportedLocales.contains(locale); + } +} diff --git a/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.aidl b/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.aidl new file mode 100644 index 0000000..39b33cc --- /dev/null +++ b/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.aidl @@ -0,0 +1,4 @@ +package android.hardware.soundtrigger; + +// @hide +parcelable KeyphraseSoundModel;
\ No newline at end of file diff --git a/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.java b/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.java new file mode 100644 index 0000000..4ddba6a --- /dev/null +++ b/core/java/android/hardware/soundtrigger/KeyphraseSoundModel.java @@ -0,0 +1,68 @@ +package android.hardware.soundtrigger; + +import android.os.Parcel; +import android.os.Parcelable; + +import java.util.UUID; + +/** + * A KeyphraseSoundModel is a sound model capable of detecting voice keyphrases. + * It contains data needed by the hardware to detect a given number of key phrases + * and the list of corresponding {@link Keyphrase}s. + * + * @hide + */ +public class KeyphraseSoundModel implements Parcelable { + + /** Key phrases in this sound model */ + public final Keyphrase[] keyphrases; + public final byte[] data; + public final UUID uuid; + + public static final Parcelable.Creator<KeyphraseSoundModel> CREATOR + = new Parcelable.Creator<KeyphraseSoundModel>() { + public KeyphraseSoundModel createFromParcel(Parcel in) { + return KeyphraseSoundModel.fromParcel(in); + } + + public KeyphraseSoundModel[] newArray(int size) { + return new KeyphraseSoundModel[size]; + } + }; + + public KeyphraseSoundModel(UUID uuid, byte[] data,Keyphrase[] keyPhrases) { + this.uuid = uuid; + this.data = data; + this.keyphrases = keyPhrases; + } + + private static KeyphraseSoundModel fromParcel(Parcel in) { + UUID uuid = UUID.fromString(in.readString()); + int dataLength = in.readInt(); + byte[] data = null; + if (dataLength > 0) { + data = new byte[in.readInt()]; + in.readByteArray(data); + } + Keyphrase[] keyphrases = + (Keyphrase[]) in.readParcelableArray(Keyphrase.class.getClassLoader()); + return new KeyphraseSoundModel(uuid, data, keyphrases); + } + + @Override + public int describeContents() { + return 0; + } + + @Override + public void writeToParcel(Parcel dest, int flags) { + dest.writeString(uuid.toString()); + if (data != null) { + dest.writeInt(data.length); + dest.writeByteArray(data); + } else { + dest.writeInt(0); + } + dest.writeParcelableArray(keyphrases, 0); + } +} diff --git a/core/java/android/hardware/soundtrigger/SoundTrigger.java b/core/java/android/hardware/soundtrigger/SoundTrigger.java index 7a4e5a5..1f48a92 100644 --- a/core/java/android/hardware/soundtrigger/SoundTrigger.java +++ b/core/java/android/hardware/soundtrigger/SoundTrigger.java @@ -1,4 +1,4 @@ -/* +/** * Copyright (C) 2014 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); diff --git a/core/java/android/hardware/soundtrigger/SoundTriggerHelper.java b/core/java/android/hardware/soundtrigger/SoundTriggerHelper.java new file mode 100644 index 0000000..0be068d --- /dev/null +++ b/core/java/android/hardware/soundtrigger/SoundTriggerHelper.java @@ -0,0 +1,217 @@ +/** + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.hardware.soundtrigger; + +import android.hardware.soundtrigger.SoundTrigger.ModuleProperties; +import android.hardware.soundtrigger.SoundTrigger.RecognitionEvent; +import android.util.Slog; +import android.util.SparseArray; + +import java.util.ArrayList; + +/** + * Helper for {@link SoundTrigger} APIs. + * Currently this just acts as an abstraction over all SoundTrigger API calls. + * + * @hide + */ +public class SoundTriggerHelper implements SoundTrigger.StatusListener { + static final String TAG = "SoundTriggerHelper"; + // TODO: Remove this. + static final int TEMP_KEYPHRASE_ID = 1; + + /** + * Return codes for {@link #startRecognition(Keyphrase)}, {@link #stopRecognition(Keyphrase)} + * Note: Keep in sync with AlwaysOnKeyphraseInteractor.java + */ + public static final int STATUS_ERROR = Integer.MIN_VALUE; + public static final int STATUS_OK = 1; + + /** + * States for {@link Listener#onListeningStateChanged(int, int)}. + */ + public static final int STATE_STOPPED = 0; + public static final int STATE_STARTED = 1; + + private static final int INVALID_SOUND_MODEL_HANDLE = -1; + + /** The {@link DspInfo} for the system, or null if none exists. */ + public final DspInfo dspInfo; + + /** The properties for the DSP module */ + private final ModuleProperties mModuleProperties; + private final SoundTriggerModule mModule; + + private final SparseArray<Listener> mListeners; + + private int mCurrentSoundModelHandle = INVALID_SOUND_MODEL_HANDLE; + + /** + * The callback for sound trigger events. + */ + public interface Listener { + /** Called when the given keyphrase is spoken. */ + void onKeyphraseSpoken(); + + /** + * Called when the listening state for the given keyphrase changes. + * @param state Indicates the current state. + */ + void onListeningStateChanged(int state); + } + + public SoundTriggerHelper() { + ArrayList <ModuleProperties> modules = new ArrayList<>(); + int status = SoundTrigger.listModules(modules); + mListeners = new SparseArray<>(1); + if (status != SoundTrigger.STATUS_OK || modules.size() == 0) { + // TODO: Figure out how to handle errors in listing the modules here. + dspInfo = null; + mModuleProperties = null; + mModule = null; + } else { + // TODO: Figure out how to determine which module corresponds to the DSP hardware. + mModuleProperties = modules.get(0); + dspInfo = new DspInfo(mModuleProperties.uuid, mModuleProperties.implementor, + mModuleProperties.description, mModuleProperties.version, + mModuleProperties.powerConsumptionMw); + mModule = SoundTrigger.attachModule(mModuleProperties.id, this, null); + } + } + + /** + * @return True, if the given {@link Keyphrase} is supported on DSP. + */ + public boolean isKeyphraseSupported(Keyphrase keyphrase) { + // TODO: We also need to look into a SoundTrigger API that let's us + // query this. For now just return true. + return true; + } + + /** + * @return True, if the given {@link Keyphrase} has been enrolled. + */ + public boolean isKeyphraseEnrolled(Keyphrase keyphrase) { + // TODO: Query VoiceInteractionManagerService + // to list registered sound models. + return false; + } + + /** + * @return True, if a recognition for the given {@link Keyphrase} is active. + */ + public boolean isKeyphraseActive(Keyphrase keyphrase) { + // TODO: Check if the recognition for the keyphrase is currently active. + return false; + } + + /** + * Starts recognition for the given {@link Keyphrase}. + * + * @param keyphraseId The identifier of the keyphrase for which + * the recognition is to be started. + * @param listener The listener for the recognition events related to the given keyphrase. + * @return One of {@link #STATUS_ERROR} or {@link #STATUS_OK}. + */ + public int startRecognition(int keyphraseId, Listener listener) { + if (dspInfo == null || mModule == null) { + Slog.w(TAG, "Attempting startRecognition without the capability"); + return STATUS_ERROR; + } + + if (mListeners.get(keyphraseId) != listener) { + if (mCurrentSoundModelHandle != INVALID_SOUND_MODEL_HANDLE) { + Slog.w(TAG, "Canceling previous recognition"); + // TODO: Inspect the return codes here. + mModule.unloadSoundModel(mCurrentSoundModelHandle); + } + mListeners.get(keyphraseId).onListeningStateChanged(STATE_STOPPED); + } + + // Register the new listener. This replaces the old one. + // There can only be a maximum of one active listener for a keyphrase + // at any given time. + mListeners.put(keyphraseId, listener); + // TODO: Get the sound model for the given keyphrase here. + // mModule.loadSoundModel(model, soundModelHandle); + // mModule.startRecognition(soundModelHandle, data); + // mCurrentSoundModelHandle = soundModelHandle; + return STATUS_ERROR; + } + + /** + * Stops recognition for the given {@link Keyphrase} if a recognition is currently active. + * + * @return One of {@link #STATUS_ERROR} or {@link #STATUS_OK}. + */ + public int stopRecognition(int id, Listener listener) { + if (dspInfo == null || mModule == null) { + Slog.w(TAG, "Attempting stopRecognition without the capability"); + return STATUS_ERROR; + } + + if (mListeners.get(id) != listener) { + Slog.w(TAG, "Attempting stopRecognition for another recognition"); + return STATUS_ERROR; + } else { + // Stop recognition if it's the current one, ignore otherwise. + // TODO: Inspect the return codes here. + mModule.stopRecognition(mCurrentSoundModelHandle); + mModule.unloadSoundModel(mCurrentSoundModelHandle); + mCurrentSoundModelHandle = INVALID_SOUND_MODEL_HANDLE; + return STATUS_OK; + } + } + + //---- SoundTrigger.StatusListener methods + @Override + public void onRecognition(RecognitionEvent event) { + // Check which keyphrase triggered, and fire the appropriate event. + // TODO: Get the keyphrase out of the event and fire events on it. + // For now, as a nasty workaround, we fire all events to the listener for + // keyphrase with TEMP_KEYPHRASE_ID. + + switch (event.status) { + case SoundTrigger.RECOGNITION_STATUS_SUCCESS: + // TODO: The keyphrase should come from the recognition event + // as it may be for a different keyphrase than the current one. + if (mListeners.get(TEMP_KEYPHRASE_ID) != null) { + mListeners.get(TEMP_KEYPHRASE_ID).onKeyphraseSpoken(); + } + break; + case SoundTrigger.RECOGNITION_STATUS_ABORT: + // TODO: The keyphrase should come from the recognition event + // as it may be for a different keyphrase than the current one. + if (mListeners.get(TEMP_KEYPHRASE_ID) != null) { + mListeners.get(TEMP_KEYPHRASE_ID).onListeningStateChanged(STATE_STOPPED); + } + break; + case SoundTrigger.RECOGNITION_STATUS_FAILURE: + // TODO: The keyphrase should come from the recognition event + // as it may be for a different keyphrase than the current one. + if (mListeners.get(TEMP_KEYPHRASE_ID) != null) { + mListeners.get(TEMP_KEYPHRASE_ID).onListeningStateChanged(STATE_STOPPED); + } + break; + } + } + + @Override + public void onServiceDied() { + // TODO: Figure out how to restart the recognition here. + } +} diff --git a/core/java/android/inputmethodservice/InputMethodService.java b/core/java/android/inputmethodservice/InputMethodService.java index 3417de1..8423d09 100644 --- a/core/java/android/inputmethodservice/InputMethodService.java +++ b/core/java/android/inputmethodservice/InputMethodService.java @@ -53,6 +53,7 @@ import android.view.WindowManager.BadTokenException; import android.view.animation.AnimationUtils; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CursorAnchorInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.EditorInfo; import android.view.inputmethod.ExtractedText; import android.view.inputmethod.ExtractedTextRequest; @@ -251,18 +252,6 @@ public class InputMethodService extends AbstractInputMethodService { */ public static final int IME_VISIBLE = 0x2; - /** - * The IME does not require cursor/anchor position. - */ - public static final int CURSOR_ANCHOR_MONITOR_MODE_NONE = 0x0; - - /** - * Passing this flag into a call to {@link #setCursorAnchorMonitorMode(int)} will result in - * the cursor rectangle being provided in screen coordinates to subsequent - * {@link #onUpdateCursor(Rect)} callbacks. - */ - public static final int CURSOR_ANCHOR_MONITOR_MODE_CURSOR_RECT = 0x1; - InputMethodManager mImm; int mTheme = 0; @@ -1722,8 +1711,9 @@ public class InputMethodService extends AbstractInputMethodService { * Called when the application has reported a new location of its text cursor. This is only * called if explicitly requested by the input method. The default implementation does nothing. * @param newCursor The new cursor position, in screen coordinates if the input method calls - * {@link #setCursorAnchorMonitorMode} with {@link #CURSOR_ANCHOR_MONITOR_MODE_CURSOR_RECT}. - * Otherwise, this is in local coordinates. + * {@link InputConnection#requestCursorAnchorInfo(CursorAnchorInfoRequest)} with + * {@link CursorAnchorInfoRequest#FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES}. Otherwise, + * this is in local coordinates. */ public void onUpdateCursor(Rect newCursor) { // Intentionally empty @@ -1741,13 +1731,6 @@ public class InputMethodService extends AbstractInputMethodService { } /** - * Update the cursor/anthor monitor mode. - */ - public void setCursorAnchorMonitorMode(int monitorMode) { - mImm.setCursorAnchorMonitorMode(mToken, monitorMode); - } - - /** * Close this input method's soft input area, removing it from the display. * The input method will continue running, but the user can no longer use * it to generate input by touching the screen. diff --git a/core/java/android/net/ConnectivityManager.java b/core/java/android/net/ConnectivityManager.java index fb4912f..a7e03fc 100644 --- a/core/java/android/net/ConnectivityManager.java +++ b/core/java/android/net/ConnectivityManager.java @@ -743,7 +743,7 @@ public class ConnectivityManager { * network type or {@code null} if the type is not * supported by the device. * - * <p>This method requires the call to hold the permission + * <p>This method requires the caller to hold the permission * {@link android.Manifest.permission#ACCESS_NETWORK_STATE}. */ public NetworkInfo getNetworkInfo(int networkType) { @@ -755,13 +755,34 @@ public class ConnectivityManager { } /** + * Returns connection status information about a particular + * Network. + * + * @param network {@link Network} specifying which network + * in which you're interested. + * @return a {@link NetworkInfo} object for the requested + * network or {@code null} if the {@code Network} + * is not valid. + * + * <p>This method requires the caller to hold the permission + * {@link android.Manifest.permission#ACCESS_NETWORK_STATE}. + */ + public NetworkInfo getNetworkInfo(Network network) { + try { + return mService.getNetworkInfoForNetwork(network); + } catch (RemoteException e) { + return null; + } + } + + /** * Returns connection status information about all network * types supported by the device. * * @return an array of {@link NetworkInfo} objects. Check each * {@link NetworkInfo#getType} for which type each applies. * - * <p>This method requires the call to hold the permission + * <p>This method requires the caller to hold the permission * {@link android.Manifest.permission#ACCESS_NETWORK_STATE}. */ public NetworkInfo[] getAllNetworkInfo() { @@ -773,6 +794,23 @@ public class ConnectivityManager { } /** + * Returns an array of all {@link Network} currently tracked by the + * framework. + * + * @return an array of {@link Network} objects. + * + * <p>This method requires the caller to hold the permission + * {@link android.Manifest.permission#ACCESS_NETWORK_STATE}. + */ + public Network[] getAllNetworks() { + try { + return mService.getAllNetworks(); + } catch (RemoteException e) { + return null; + } + } + + /** * Returns details about the Provisioning or currently active default data network. When * connected, this network is the default route for outgoing connections. * You should always check {@link NetworkInfo#isConnected()} before initiating @@ -1462,6 +1500,20 @@ public class ConnectivityManager { } /** + * Get the set of tethered dhcp ranges. + * + * @return an array of 0 or more {@code String} of tethered dhcp ranges. + * {@hide} + */ + public String[] getTetheredDhcpRanges() { + try { + return mService.getTetheredDhcpRanges(); + } catch (RemoteException e) { + return new String[0]; + } + } + + /** * Attempt to tether the named interface. This will setup a dhcp server * on the interface, forward and NAT IP packets and forward DNS requests * to the best active upstream network interface. Note that if no upstream diff --git a/core/java/android/net/IConnectivityManager.aidl b/core/java/android/net/IConnectivityManager.aidl index 51d9b8c..b9c6491 100644 --- a/core/java/android/net/IConnectivityManager.aidl +++ b/core/java/android/net/IConnectivityManager.aidl @@ -48,7 +48,9 @@ interface IConnectivityManager NetworkInfo getActiveNetworkInfo(); NetworkInfo getActiveNetworkInfoForUid(int uid); NetworkInfo getNetworkInfo(int networkType); + NetworkInfo getNetworkInfoForNetwork(in Network network); NetworkInfo[] getAllNetworkInfo(); + Network[] getAllNetworks(); NetworkInfo getProvisioningOrActiveNetworkInfo(); @@ -91,6 +93,8 @@ interface IConnectivityManager String[] getTetheringErroredIfaces(); + String[] getTetheredDhcpRanges(); + String[] getTetherableUsbRegexs(); String[] getTetherableWifiRegexs(); @@ -111,8 +115,6 @@ interface IConnectivityManager void setDataDependency(int networkType, boolean met); - boolean protectVpn(in ParcelFileDescriptor socket); - boolean prepareVpn(String oldPackage, String newPackage); ParcelFileDescriptor establishVpn(in VpnConfig config); diff --git a/core/java/android/net/NetworkAgent.java b/core/java/android/net/NetworkAgent.java index 3d0874b..41eab02 100644 --- a/core/java/android/net/NetworkAgent.java +++ b/core/java/android/net/NetworkAgent.java @@ -92,6 +92,20 @@ public abstract class NetworkAgent extends Handler { */ public static final int EVENT_NETWORK_SCORE_CHANGED = BASE + 4; + /** + * Sent by the NetworkAgent to ConnectivityService to add new UID ranges + * to be forced into this Network. For VPNs only. + * obj = UidRange[] to forward + */ + public static final int EVENT_UID_RANGES_ADDED = BASE + 5; + + /** + * Sent by the NetworkAgent to ConnectivityService to remove UID ranges + * from being forced into this Network. For VPNs only. + * obj = UidRange[] to stop forwarding + */ + public static final int EVENT_UID_RANGES_REMOVED = BASE + 6; + public NetworkAgent(Looper looper, Context context, String logTag, NetworkInfo ni, NetworkCapabilities nc, LinkProperties lp, int score) { super(looper); @@ -194,6 +208,22 @@ public abstract class NetworkAgent extends Handler { } /** + * Called by the VPN code when it wants to add ranges of UIDs to be routed + * through the VPN network. + */ + public void addUidRanges(UidRange[] ranges) { + queueOrSendMessage(EVENT_UID_RANGES_ADDED, ranges); + } + + /** + * Called by the VPN code when it wants to remove ranges of UIDs from being routed + * through the VPN network. + */ + public void removeUidRanges(UidRange[] ranges) { + queueOrSendMessage(EVENT_UID_RANGES_REMOVED, ranges); + } + + /** * Called when ConnectivityService has indicated they no longer want this network. * The parent factory should (previously) have received indication of the change * as well, either canceling NetworkRequests or altering their score such that this diff --git a/core/java/android/net/NetworkCapabilities.java b/core/java/android/net/NetworkCapabilities.java index 00200d0..53f9fcd 100644 --- a/core/java/android/net/NetworkCapabilities.java +++ b/core/java/android/net/NetworkCapabilities.java @@ -18,6 +18,7 @@ package android.net; import android.os.Parcel; import android.os.Parcelable; +import android.text.TextUtils; import android.util.Log; import java.lang.IllegalArgumentException; @@ -56,6 +57,7 @@ public final class NetworkCapabilities implements Parcelable { mTransportTypes = nc.mTransportTypes; mLinkUpBandwidthKbps = nc.mLinkUpBandwidthKbps; mLinkDownBandwidthKbps = nc.mLinkDownBandwidthKbps; + mNetworkSpecifier = nc.mNetworkSpecifier; } } @@ -64,7 +66,7 @@ public final class NetworkCapabilities implements Parcelable { * by any Network that matches all of them. */ private long mNetworkCapabilities = (1 << NET_CAPABILITY_NOT_RESTRICTED) | - (1 << NET_CAPABILITY_TRUSTED); + (1 << NET_CAPABILITY_TRUSTED) | (1 << NET_CAPABILITY_NOT_VPN); /** * Indicates this is a network that has the ability to reach the @@ -158,9 +160,15 @@ public final class NetworkCapabilities implements Parcelable { */ public static final int NET_CAPABILITY_TRUSTED = 14; + /* + * Indicates that this network is not a VPN. This capability is set by default and should be + * explicitly cleared when creating VPN networks. + */ + public static final int NET_CAPABILITY_NOT_VPN = 15; + private static final int MIN_NET_CAPABILITY = NET_CAPABILITY_MMS; - private static final int MAX_NET_CAPABILITY = NET_CAPABILITY_TRUSTED; + private static final int MAX_NET_CAPABILITY = NET_CAPABILITY_NOT_VPN; /** * Adds the given capability to this {@code NetworkCapability} instance. @@ -271,8 +279,13 @@ public final class NetworkCapabilities implements Parcelable { */ public static final int TRANSPORT_ETHERNET = 3; + /** + * Indicates this network uses a VPN transport. + */ + public static final int TRANSPORT_VPN = 4; + private static final int MIN_TRANSPORT = TRANSPORT_CELLULAR; - private static final int MAX_TRANSPORT = TRANSPORT_ETHERNET; + private static final int MAX_TRANSPORT = TRANSPORT_VPN; /** * Adds the given transport type to this {@code NetworkCapability} instance. @@ -292,6 +305,7 @@ public final class NetworkCapabilities implements Parcelable { throw new IllegalArgumentException("TransportType out of range"); } mTransportTypes |= 1 << transportType; + setNetworkSpecifier(mNetworkSpecifier); // used for exception checking return this; } @@ -307,6 +321,7 @@ public final class NetworkCapabilities implements Parcelable { throw new IllegalArgumentException("TransportType out of range"); } mTransportTypes &= ~(1 << transportType); + setNetworkSpecifier(mNetworkSpecifier); // used for exception checking return this; } @@ -426,6 +441,62 @@ public final class NetworkCapabilities implements Parcelable { this.mLinkDownBandwidthKbps == nc.mLinkDownBandwidthKbps); } + private String mNetworkSpecifier; + /** + * Sets the optional bearer specific network specifier. + * This has no meaning if a single transport is also not specified, so calling + * this without a single transport set will generate an exception, as will + * subsequently adding or removing transports after this is set. + * </p> + * The interpretation of this {@code String} is bearer specific and bearers that use + * it should document their particulars. For example, Bluetooth may use some sort of + * device id while WiFi could used SSID and/or BSSID. Cellular may use carrier SPN (name) + * or Subscription ID. + * + * @param networkSpecifier An {@code String} of opaque format used to specify the bearer + * specific network specifier where the bearer has a choice of + * networks. + * @hide + */ + public void setNetworkSpecifier(String networkSpecifier) { + if (TextUtils.isEmpty(networkSpecifier) == false && Long.bitCount(mTransportTypes) != 1) { + throw new IllegalStateException("Must have a single transport specified to use " + + "setNetworkSpecifier"); + } + mNetworkSpecifier = networkSpecifier; + } + + /** + * Gets the optional bearer specific network specifier. + * + * @return The optional {@code String} specifying the bearer specific network specifier. + * See {@link #setNetworkSpecifier}. + * @hide + */ + public String getNetworkSpecifier() { + return mNetworkSpecifier; + } + + private void combineSpecifiers(NetworkCapabilities nc) { + String otherSpecifier = nc.getNetworkSpecifier(); + if (TextUtils.isEmpty(otherSpecifier)) return; + if (TextUtils.isEmpty(mNetworkSpecifier) == false) { + throw new IllegalStateException("Can't combine two networkSpecifiers"); + } + setNetworkSpecifier(otherSpecifier); + } + private boolean satisfiedBySpecifier(NetworkCapabilities nc) { + return (TextUtils.isEmpty(mNetworkSpecifier) || + mNetworkSpecifier.equals(nc.mNetworkSpecifier)); + } + private boolean equalsSpecifier(NetworkCapabilities nc) { + if (TextUtils.isEmpty(mNetworkSpecifier)) { + return TextUtils.isEmpty(nc.mNetworkSpecifier); + } else { + return mNetworkSpecifier.equals(nc.mNetworkSpecifier); + } + } + /** * Combine a set of Capabilities to this one. Useful for coming up with the complete set * {@hide} @@ -434,6 +505,7 @@ public final class NetworkCapabilities implements Parcelable { combineNetCapabilities(nc); combineTransportTypes(nc); combineLinkBandwidths(nc); + combineSpecifiers(nc); } /** @@ -444,7 +516,8 @@ public final class NetworkCapabilities implements Parcelable { return (nc != null && satisfiedByNetCapabilities(nc) && satisfiedByTransportTypes(nc) && - satisfiedByLinkBandwidths(nc)); + satisfiedByLinkBandwidths(nc) && + satisfiedBySpecifier(nc)); } @Override @@ -453,7 +526,8 @@ public final class NetworkCapabilities implements Parcelable { NetworkCapabilities that = (NetworkCapabilities)obj; return (equalsNetCapabilities(that) && equalsTransportTypes(that) && - equalsLinkBandwidths(that)); + equalsLinkBandwidths(that) && + equalsSpecifier(that)); } @Override @@ -463,7 +537,8 @@ public final class NetworkCapabilities implements Parcelable { ((int)(mTransportTypes & 0xFFFFFFFF) * 5) + ((int)(mTransportTypes >> 32) * 7) + (mLinkUpBandwidthKbps * 11) + - (mLinkDownBandwidthKbps * 13)); + (mLinkDownBandwidthKbps * 13) + + (TextUtils.isEmpty(mNetworkSpecifier) ? 0 : mNetworkSpecifier.hashCode() * 17)); } public int describeContents() { @@ -474,6 +549,7 @@ public final class NetworkCapabilities implements Parcelable { dest.writeLong(mTransportTypes); dest.writeInt(mLinkUpBandwidthKbps); dest.writeInt(mLinkDownBandwidthKbps); + dest.writeString(mNetworkSpecifier); } public static final Creator<NetworkCapabilities> CREATOR = new Creator<NetworkCapabilities>() { @@ -484,6 +560,7 @@ public final class NetworkCapabilities implements Parcelable { netCap.mTransportTypes = in.readLong(); netCap.mLinkUpBandwidthKbps = in.readInt(); netCap.mLinkDownBandwidthKbps = in.readInt(); + netCap.mNetworkSpecifier = in.readString(); return netCap; } public NetworkCapabilities[] newArray(int size) { @@ -500,6 +577,7 @@ public final class NetworkCapabilities implements Parcelable { case TRANSPORT_WIFI: transports += "WIFI"; break; case TRANSPORT_BLUETOOTH: transports += "BLUETOOTH"; break; case TRANSPORT_ETHERNET: transports += "ETHERNET"; break; + case TRANSPORT_VPN: transports += "VPN"; break; } if (++i < types.length) transports += "|"; } @@ -523,6 +601,7 @@ public final class NetworkCapabilities implements Parcelable { case NET_CAPABILITY_INTERNET: capabilities += "INTERNET"; break; case NET_CAPABILITY_NOT_RESTRICTED: capabilities += "NOT_RESTRICTED"; break; case NET_CAPABILITY_TRUSTED: capabilities += "TRUSTED"; break; + case NET_CAPABILITY_NOT_VPN: capabilities += "NOT_VPN"; break; } if (++i < types.length) capabilities += "&"; } @@ -532,6 +611,9 @@ public final class NetworkCapabilities implements Parcelable { String dnBand = ((mLinkDownBandwidthKbps > 0) ? " LinkDnBandwidth>=" + mLinkDownBandwidthKbps + "Kbps" : ""); - return "[" + transports + capabilities + upBand + dnBand + "]"; + String specifier = (mNetworkSpecifier == null ? + "" : " Specifier: <" + mNetworkSpecifier + ">"); + + return "[" + transports + capabilities + upBand + dnBand + specifier + "]"; } } diff --git a/core/java/android/net/NetworkRequest.java b/core/java/android/net/NetworkRequest.java index 36dc573..83bdfaa 100644 --- a/core/java/android/net/NetworkRequest.java +++ b/core/java/android/net/NetworkRequest.java @@ -153,6 +153,25 @@ public class NetworkRequest implements Parcelable { mNetworkCapabilities.setLinkDownstreamBandwidthKbps(downKbps); return this; } + + /** + * Sets the optional bearer specific network specifier. + * This has no meaning if a single transport is also not specified, so calling + * this without a single transport set will generate an exception, as will + * subsequently adding or removing transports after this is set. + * </p> + * The interpretation of this {@code String} is bearer specific and bearers that use + * it should document their particulars. For example, Bluetooth may use some sort of + * device id while WiFi could used ssid and/or bssid. Cellular may use carrier spn. + * + * @param networkSpecifier An {@code String} of opaque format used to specify the bearer + * specific network specifier where the bearer has a choice of + * networks. + */ + public Builder setNetworkSpecifier(String networkSpecifier) { + mNetworkCapabilities.setNetworkSpecifier(networkSpecifier); + return this; + } } // implement the Parcelable interface diff --git a/core/java/android/net/NetworkUtils.java b/core/java/android/net/NetworkUtils.java index c4b17b6..aa1e123 100644 --- a/core/java/android/net/NetworkUtils.java +++ b/core/java/android/net/NetworkUtils.java @@ -155,6 +155,13 @@ public class NetworkUtils { public native static boolean bindSocketToNetwork(int socketfd, int netId); /** + * Protect {@code socketfd} from VPN connections. After protecting, data sent through + * this socket will go directly to the underlying network, so its traffic will not be + * forwarded through the VPN. + */ + public native static boolean protectFromVpn(int socketfd); + + /** * Convert a IPv4 address from an integer to an InetAddress. * @param hostAddress an int corresponding to the IPv4 address in network byte order */ diff --git a/core/java/android/net/UidRange.aidl b/core/java/android/net/UidRange.aidl new file mode 100644 index 0000000..f9be628 --- /dev/null +++ b/core/java/android/net/UidRange.aidl @@ -0,0 +1,24 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.net; + +/** + * An inclusive range of UIDs. + * + * {@hide} + */ +parcelable UidRange; diff --git a/core/java/android/net/UidRange.java b/core/java/android/net/UidRange.java new file mode 100644 index 0000000..2e586b3 --- /dev/null +++ b/core/java/android/net/UidRange.java @@ -0,0 +1,102 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.net; + +import static android.os.UserHandle.PER_USER_RANGE; + +import android.os.Parcel; +import android.os.Parcelable; + +import java.lang.IllegalArgumentException; + +/** + * An inclusive range of UIDs. + * + * @hide + */ +public final class UidRange implements Parcelable { + public final int start; + public final int stop; + + public UidRange(int startUid, int stopUid) { + if (startUid < 0) throw new IllegalArgumentException("Invalid start UID."); + if (stopUid < 0) throw new IllegalArgumentException("Invalid stop UID."); + if (startUid > stopUid) throw new IllegalArgumentException("Invalid UID range."); + start = startUid; + stop = stopUid; + } + + public static UidRange createForUser(int userId) { + return new UidRange(userId * PER_USER_RANGE, (userId + 1) * PER_USER_RANGE - 1); + } + + public int getStartUser() { + return start / PER_USER_RANGE; + } + + @Override + public int hashCode() { + int result = 17; + result = 31 * result + start; + result = 31 * result + stop; + return result; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o instanceof UidRange) { + UidRange other = (UidRange) o; + return start == other.start && stop == other.stop; + } + return false; + } + + @Override + public String toString() { + return start + "-" + stop; + } + + // implement the Parcelable interface + @Override + public int describeContents() { + return 0; + } + + @Override + public void writeToParcel(Parcel dest, int flags) { + dest.writeInt(start); + dest.writeInt(stop); + } + + public static final Creator<UidRange> CREATOR = + new Creator<UidRange>() { + @Override + public UidRange createFromParcel(Parcel in) { + int start = in.readInt(); + int stop = in.readInt(); + + return new UidRange(start, stop); + } + @Override + public UidRange[] newArray(int size) { + return new UidRange[size]; + } + }; +} diff --git a/core/java/android/net/VpnService.java b/core/java/android/net/VpnService.java index 7385dff..5d61de2 100644 --- a/core/java/android/net/VpnService.java +++ b/core/java/android/net/VpnService.java @@ -16,11 +16,16 @@ package android.net; +import static android.system.OsConstants.AF_INET; +import static android.system.OsConstants.AF_INET6; + import android.app.Activity; import android.app.PendingIntent; import android.app.Service; import android.content.Context; import android.content.Intent; +import android.content.pm.PackageManager; +import android.net.NetworkUtils; import android.os.Binder; import android.os.IBinder; import android.os.Parcel; @@ -165,19 +170,7 @@ public class VpnService extends Service { * @return {@code true} on success. */ public boolean protect(int socket) { - ParcelFileDescriptor dup = null; - try { - dup = ParcelFileDescriptor.fromFd(socket); - return getService().protectVpn(dup); - } catch (Exception e) { - return false; - } finally { - try { - dup.close(); - } catch (Exception e) { - // ignore - } - } + return NetworkUtils.protectFromVpn(socket); } /** @@ -202,6 +195,52 @@ public class VpnService extends Service { } /** + * Adds a network address to the VPN interface. + * + * Both IPv4 and IPv6 addresses are supported. The VPN must already be established. Fails if the + * address is already in use or cannot be assigned to the interface for any other reason. + * + * Adding an address implicitly allows traffic from that address family (i.e., IPv4 or IPv6) to + * be routed over the VPN. @see Builder#allowFamily + * + * @throws {@link IllegalArgumentException} if the address is invalid. + * + * @param address The IP address (IPv4 or IPv6) to assign to the VPN interface. + * @param prefixLength The prefix length of the address. + * + * @return {@code true} on success. + * @see Builder#addAddress + */ + public boolean addAddress(InetAddress address, int prefixLength) { + // TODO + return true; + } + + /** + * Removes a network address from the VPN interface. + * + * Both IPv4 and IPv6 addresses are supported. The VPN must already be established. Fails if the + * address is not assigned to the VPN interface, or if it is the only address assigned (thus + * cannot be removed), or if the address cannot be removed for any other reason. + * + * After removing an address, if there are no addresses, routes or DNS servers of a particular + * address family (i.e., IPv4 or IPv6) configured on the VPN, that <b>DOES NOT</b> block that + * family from being routed. In other words, once an address family has been allowed, it stays + * allowed for the rest of the VPN's session. @see Builder#allowFamily + * + * @throws {@link IllegalArgumentException} if the address is invalid. + * + * @param address The IP address (IPv4 or IPv6) to assign to the VPN interface. + * @param prefixLength The prefix length of the address. + * + * @return {@code true} on success. + */ + public boolean removeAddress(InetAddress address, int prefixLength) { + // TODO + return true; + } + + /** * Return the communication interface to the service. This method returns * {@code null} on {@link Intent}s other than {@link #SERVICE_INTERFACE} * action. Applications overriding this method must identify the intent @@ -322,6 +361,9 @@ public class VpnService extends Service { * addresses are supported. At least one address must be set before * calling {@link #establish}. * + * Adding an address implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the address is invalid. */ public Builder addAddress(InetAddress address, int prefixLength) { @@ -339,6 +381,9 @@ public class VpnService extends Service { * using a numeric address string. See {@link InetAddress} for the * definitions of numeric address formats. * + * Adding an address implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the address is invalid. * @see #addAddress(InetAddress, int) */ @@ -350,6 +395,9 @@ public class VpnService extends Service { * Add a network route to the VPN interface. Both IPv4 and IPv6 * routes are supported. * + * Adding a route implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the route is invalid. */ public Builder addRoute(InetAddress address, int prefixLength) { @@ -373,6 +421,9 @@ public class VpnService extends Service { * using a numeric address string. See {@link InetAddress} for the * definitions of numeric address formats. * + * Adding a route implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the route is invalid. * @see #addRoute(InetAddress, int) */ @@ -385,6 +436,9 @@ public class VpnService extends Service { * addresses are supported. If none is set, the DNS servers of * the default network will be used. * + * Adding a server implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the address is invalid. */ public Builder addDnsServer(InetAddress address) { @@ -403,6 +457,9 @@ public class VpnService extends Service { * using a numeric address string. See {@link InetAddress} for the * definitions of numeric address formats. * + * Adding a server implicitly allows traffic from that address family + * (i.e., IPv4 or IPv6) to be routed over the VPN. @see #allowFamily + * * @throws IllegalArgumentException if the address is invalid. * @see #addDnsServer(InetAddress) */ @@ -422,6 +479,95 @@ public class VpnService extends Service { } /** + * Allows traffic from the specified address family. + * + * By default, if no address, route or DNS server of a specific family (IPv4 or IPv6) is + * added to this VPN, then all outgoing traffic of that family is blocked. If any address, + * route or DNS server is added, that family is allowed. + * + * This method allows an address family to be unblocked even without adding an address, + * route or DNS server of that family. Traffic of that family will then typically + * fall-through to the underlying network if it's supported. + * + * {@code family} must be either {@code AF_INET} (for IPv4) or {@code AF_INET6} (for IPv6). + * {@link IllegalArgumentException} is thrown if it's neither. + * + * @param family The address family ({@code AF_INET} or {@code AF_INET6}) to allow. + * + * @return this {@link Builder} object to facilitate chaining of method calls. + */ + public Builder allowFamily(int family) { + // TODO + return this; + } + + /** + * Adds an application that's allowed to access the VPN connection. + * + * If this method is called at least once, only applications added through this method (and + * no others) are allowed access. Else (if this method is never called), all applications + * are allowed by default. + * + * A {@link Builder} may have only a set of allowed applications OR a set of disallowed + * ones, but not both. Calling this method after {@link #addDisallowedApplication} has + * already been called, or vice versa, will throw an {@link UnsupportedOperationException}. + * + * {@code packageName} must be the canonical name of a currently installed application. + * {@link PackageManager.NameNotFoundException} is thrown if there's no such application. + * + * @throws {@link PackageManager.NameNotFoundException} If the application isn't installed. + * + * @param packageName The full name (e.g.: "com.google.apps.contacts") of an application. + * + * @return this {@link Builder} object to facilitate chaining method calls. + */ + public Builder addAllowedApplication(String packageName) + throws PackageManager.NameNotFoundException { + // TODO + return this; + } + + /** + * Adds an application that's denied access to the VPN connection. + * + * By default, all applications are allowed access, except for those denied through this + * method. + * + * A {@link Builder} may have only a set of allowed applications OR a set of disallowed + * ones, but not both. Calling this method after {@link #addAllowedApplication} has already + * been called, or vice versa, will throw an {@link UnsupportedOperationException}. + * + * {@code packageName} must be the canonical name of a currently installed application. + * {@link PackageManager.NameNotFoundException} is thrown if there's no such application. + * + * @throws {@link PackageManager.NameNotFoundException} If the application isn't installed. + * + * @param packageName The full name (e.g.: "com.google.apps.contacts") of an application. + * + * @return this {@link Builder} object to facilitate chaining method calls. + */ + public Builder addDisallowedApplication(String packageName) + throws PackageManager.NameNotFoundException { + // TODO + return this; + } + + /** + * Allows all apps to bypass this VPN connection. + * + * By default, all traffic from apps is forwarded through the VPN interface and it is not + * possible for apps to side-step the VPN. If this method is called, apps may use methods + * such as {@link ConnectivityManager#setProcessDefaultNetwork} to instead send/receive + * directly over the underlying network or any other network they have permissions for. + * + * @return this {@link Builder} object to facilitate chaining of method calls. + */ + public Builder allowBypass() { + // TODO + return this; + } + + /** * Create a VPN interface using the parameters supplied to this * builder. The interface works on IP packets, and a file descriptor * is returned for the application to access them. Each read diff --git a/core/java/android/os/BatteryStats.java b/core/java/android/os/BatteryStats.java index d0a6f08..c22c4b6 100644 --- a/core/java/android/os/BatteryStats.java +++ b/core/java/android/os/BatteryStats.java @@ -2076,7 +2076,7 @@ public abstract class BatteryStats implements Parcelable { if (val != 0) hasData = true; } if (hasData) { - dumpLine(pw, 0 /* uid */, category, USER_ACTIVITY_DATA, args); + dumpLine(pw, uid /* uid */, category, USER_ACTIVITY_DATA, args); } } diff --git a/core/java/android/os/INetworkManagementService.aidl b/core/java/android/os/INetworkManagementService.aidl index eb9ba13..d997e44 100644 --- a/core/java/android/os/INetworkManagementService.aidl +++ b/core/java/android/os/INetworkManagementService.aidl @@ -22,6 +22,7 @@ import android.net.INetworkManagementEventObserver; import android.net.LinkAddress; import android.net.NetworkStats; import android.net.RouteInfo; +import android.net.UidRange; import android.net.wifi.WifiConfiguration; import android.os.INetworkActivityListener; @@ -325,28 +326,14 @@ interface INetworkManagementService void setFirewallUidRule(int uid, boolean allow); /** - * Set all packets from users [uid_start,uid_end] to go through interface iface - * iface must already be set for marked forwarding by {@link setMarkedForwarding} + * Set all packets from users in ranges to go through VPN specified by netId. */ - void setUidRangeRoute(String iface, int uid_start, int uid_end, boolean forward_dns); + void addVpnUidRanges(int netId, in UidRange[] ranges); /** - * Clears the special routing rules for users [uid_start,uid_end] + * Clears the special VPN rules for users in ranges and VPN specified by netId. */ - void clearUidRangeRoute(String iface, int uid_start, int uid_end); - - /** - * Setup an interface for routing packets marked by {@link setUidRangeRoute} - * - * This sets up a dedicated routing table for packets marked for {@code iface} and adds - * source-NAT rules so that the marked packets have the correct source address. - */ - void setMarkedForwarding(String iface); - - /** - * Removes marked forwarding for an interface - */ - void clearMarkedForwarding(String iface); + void removeVpnUidRanges(int netId, in UidRange[] ranges); /** * Get the SO_MARK associated with routing packets for user {@code uid} @@ -410,9 +397,14 @@ interface INetworkManagementService boolean isNetworkActive(); /** - * Setup a new network. + * Setup a new physical network. + */ + void createPhysicalNetwork(int netId); + + /** + * Setup a new VPN. */ - void createNetwork(int netId); + void createVirtualNetwork(int netId, boolean hasDNS); /** * Remove a network. @@ -437,4 +429,14 @@ interface INetworkManagementService void setPermission(boolean internal, boolean changeNetState, in int[] uids); void clearPermission(in int[] uids); + + /** + * Allow UID to call protect(). + */ + void allowProtect(int uid); + + /** + * Deny UID from calling protect(). + */ + void denyProtect(int uid); } diff --git a/core/java/android/os/Process.java b/core/java/android/os/Process.java index 86c749a..8caea25 100644 --- a/core/java/android/os/Process.java +++ b/core/java/android/os/Process.java @@ -1085,4 +1085,18 @@ public class Process { */ public boolean usingWrapper; } + + /** + * Kill all processes in a process group started for the given + * pid. + * @hide + */ + public static final native int killProcessGroup(int uid, int pid); + + /** + * Remove all process groups. Expected to be called when ActivityManager + * is restarted. + * @hide + */ + public static final native void removeAllProcessGroups(); } diff --git a/core/java/android/print/PrintDocumentInfo.java b/core/java/android/print/PrintDocumentInfo.java index 928be6c..e4e753e 100644 --- a/core/java/android/print/PrintDocumentInfo.java +++ b/core/java/android/print/PrintDocumentInfo.java @@ -308,7 +308,7 @@ public final class PrintDocumentInfo implements Parcelable { public Builder setPageCount(int pageCount) { if (pageCount < 0 && pageCount != PAGE_COUNT_UNKNOWN) { throw new IllegalArgumentException("pageCount" - + " must be greater than or euqal to zero or" + + " must be greater than or equal to zero or" + " DocumentInfo#PAGE_COUNT_UNKNOWN"); } mPrototype.mPageCount = pageCount; @@ -338,6 +338,12 @@ public final class PrintDocumentInfo implements Parcelable { * @return The new instance. */ public PrintDocumentInfo build() { + // Zero pages is the same as unknown as in this case + // we will have to ask for all pages and look a the + // wiritten PDF file for the page count. + if (mPrototype.mPageCount == 0) { + mPrototype.mPageCount = PAGE_COUNT_UNKNOWN; + } return new PrintDocumentInfo(mPrototype); } } diff --git a/core/java/android/provider/CallLog.java b/core/java/android/provider/CallLog.java index acc74d8..760f2a5 100644 --- a/core/java/android/provider/CallLog.java +++ b/core/java/android/provider/CallLog.java @@ -20,6 +20,7 @@ package android.provider; import android.content.ContentResolver; import android.content.ContentValues; import android.content.Context; +import android.content.Intent; import android.database.Cursor; import android.net.Uri; import android.provider.ContactsContract.CommonDataKinds.Callable; @@ -87,6 +88,27 @@ public class CallLog { public static final String ALLOW_VOICEMAILS_PARAM_KEY = "allow_voicemails"; /** + * An optional extra used with {@link #CONTENT_TYPE Calls.CONTENT_TYPE} and + * {@link Intent#ACTION_VIEW} to specify that the presented list of calls should be + * filtered for a particular call type. + * + * Applications implementing a call log UI should check for this extra, and display a + * filtered list of calls based on the specified call type. If not applicable within the + * application's UI, it should be silently ignored. + * + * <p> + * The following example brings up the call log, showing only missed calls. + * <pre> + * Intent intent = new Intent(Intent.ACTION_VIEW); + * intent.setType(CallLog.Calls.CONTENT_TYPE); + * intent.putExtra(CallLog.Calls.EXTRA_CALL_TYPE_FILTER, CallLog.Calls.MISSED_TYPE); + * startActivity(intent); + * </pre> + * </p> + */ + public static final String EXTRA_CALL_TYPE_FILTER = "extra_call_type_filter"; + + /** * Content uri used to access call log entries, including voicemail records. You must have * the READ_CALL_LOG and WRITE_CALL_LOG permissions to read and write to the call log. */ @@ -127,6 +149,18 @@ public class CallLog { public static final int VOICEMAIL_TYPE = 4; /** + * Bit-mask describing features of the call (e.g. video). + * + * <P>Type: INTEGER (int)</P> + */ + public static final String FEATURES = "features"; + + /** Call had no associated features (e.g. voice-only). */ + public static final int FEATURES_NONE = 0x0; + /** Call had video. */ + public static final int FEATURES_VIDEO = 0x1; + + /** * The phone number as the user entered it. * <P>Type: TEXT</P> */ @@ -180,6 +214,12 @@ public class CallLog { public static final String DURATION = "duration"; /** + * The data usage of the call in bytes. + * <P>Type: INTEGER (long)</P> + */ + public static final String DATA_USAGE = "data_usage"; + + /** * Whether or not the call has been acknowledged * <P>Type: INTEGER (boolean)</P> */ @@ -302,14 +342,18 @@ public class CallLog { * is set by the network and denotes the number presenting rules for * "allowed", "payphone", "restricted" or "unknown" * @param callType enumerated values for "incoming", "outgoing", or "missed" + * @param features features of the call (e.g. Video). * @param account The account object describing the provider of the call * @param start time stamp for the call in milliseconds * @param duration call duration in seconds + * @param dataUsage data usage for the call in bytes, null if data usage was not tracked for + * the call. * * {@hide} */ public static Uri addCall(CallerInfo ci, Context context, String number, - int presentation, int callType, PhoneAccount account, long start, int duration) { + int presentation, int callType, int features, PhoneAccount account, long start, + int duration, Long dataUsage) { final ContentResolver resolver = context.getContentResolver(); int numberPresentation = PRESENTATION_ALLOWED; @@ -346,8 +390,12 @@ public class CallLog { values.put(NUMBER, number); values.put(NUMBER_PRESENTATION, Integer.valueOf(numberPresentation)); values.put(TYPE, Integer.valueOf(callType)); + values.put(FEATURES, features); values.put(DATE, Long.valueOf(start)); values.put(DURATION, Long.valueOf(duration)); + if (dataUsage != null) { + values.put(DATA_USAGE, dataUsage); + } values.put(PHONE_ACCOUNT_COMPONENT_NAME, accountComponentString); values.put(PHONE_ACCOUNT_ID, accountId); values.put(NEW, Integer.valueOf(1)); diff --git a/core/java/android/provider/ContactsContract.java b/core/java/android/provider/ContactsContract.java index cfe926d..93f834a 100644 --- a/core/java/android/provider/ContactsContract.java +++ b/core/java/android/provider/ContactsContract.java @@ -1670,6 +1670,24 @@ public final class ContactsContract { */ public static final String CONTENT_VCARD_TYPE = "text/x-vcard"; + + /** + * Mimimal ID for corp contacts returned from + * {@link PhoneLookup#ENTERPRISE_CONTENT_FILTER_URI}. + * + * @hide + */ + public static long CORP_CONTACT_ID_BASE = 1000000000; // slightly smaller than 2 ** 30 + + /** + * Return TRUE if a contact ID is from the contacts provider on the corp profile. + * + * {@link PhoneLookup#ENTERPRISE_CONTENT_FILTER_URI} may return such a contact. + */ + public static boolean isCorpContactId(long contactId) { + return (contactId >= CORP_CONTACT_ID_BASE) && (contactId < Profile.MIN_ID); + } + /** * A sub-directory of a single contact that contains all of the constituent raw contact * {@link ContactsContract.Data} rows. This directory can be used either @@ -4842,20 +4860,15 @@ public final class ContactsContract { * <p> * If a result is from the corp profile, it makes the following changes to the data: * <ul> - * <li>The following columns will be set to null, as they don't make sense on a - * different profile: - * {@link #_ID}, - * {@link #PHOTO_ID}, - * {@link #PHOTO_FILE_ID}, - * {@link #LOOKUP_KEY}, - * {@link #CUSTOM_RINGTONE}, - * {@link #IN_VISIBLE_GROUP}, - * and {@link #IN_DEFAULT_DIRECTORY}. - * </li> * <li> * {@link #PHOTO_THUMBNAIL_URI} and {@link #PHOTO_URI} will be rewritten to special * URIs. Use {@link ContentResolver#openAssetFileDescriptor} or its siblings to * load pictures from them. + * {@link #PHOTO_ID} and {@link #PHOTO_FILE_ID} will be set to null. Do not use them. + * </li> + * <li> + * Corp contacts will get artificial {@link #_ID}s. In order to tell whether a contact + * is from the corp profile, use {@link ContactsContract.Contacts#isCorpContactId(long)}. * </li> * </ul> * <p> diff --git a/core/java/android/provider/SearchIndexablesContract.java b/core/java/android/provider/SearchIndexablesContract.java index a8b4cfb..1b5f72a 100644 --- a/core/java/android/provider/SearchIndexablesContract.java +++ b/core/java/android/provider/SearchIndexablesContract.java @@ -65,7 +65,7 @@ public class SearchIndexablesContract { public static final String NON_INDEXABLES_KEYS_PATH = SETTINGS + "/" + NON_INDEXABLES_KEYS; /** - * Indexable xml resources colums. + * Indexable xml resources columns. */ public static final String[] INDEXABLES_XML_RES_COLUMNS = new String[] { XmlResource.COLUMN_RANK, // 0 @@ -78,7 +78,7 @@ public class SearchIndexablesContract { }; /** - * Indexable xml resources colums indices. + * Indexable xml resources columns indices. */ public static final int COLUMN_INDEX_XML_RES_RANK = 0; public static final int COLUMN_INDEX_XML_RES_RESID = 1; @@ -89,7 +89,7 @@ public class SearchIndexablesContract { public static final int COLUMN_INDEX_XML_RES_INTENT_TARGET_CLASS = 6; /** - * Indexable raw data colums. + * Indexable raw data columns. */ public static final String[] INDEXABLES_RAW_COLUMNS = new String[] { RawData.COLUMN_RANK, // 0 @@ -105,10 +105,11 @@ public class SearchIndexablesContract { RawData.COLUMN_INTENT_TARGET_PACKAGE, // 10 RawData.COLUMN_INTENT_TARGET_CLASS, // 11 RawData.COLUMN_KEY, // 12 + RawData.COLUMN_USER_ID, // 13 }; /** - * Indexable raw data colums indices. + * Indexable raw data columns indices. */ public static final int COLUMN_INDEX_RAW_RANK = 0; public static final int COLUMN_INDEX_RAW_TITLE = 1; @@ -123,16 +124,17 @@ public class SearchIndexablesContract { public static final int COLUMN_INDEX_RAW_INTENT_TARGET_PACKAGE = 10; public static final int COLUMN_INDEX_RAW_INTENT_TARGET_CLASS = 11; public static final int COLUMN_INDEX_RAW_KEY = 12; + public static final int COLUMN_INDEX_RAW_USER_ID = 13; /** - * Indexable raw data colums. + * Indexable raw data columns. */ public static final String[] NON_INDEXABLES_KEYS_COLUMNS = new String[] { NonIndexableKey.COLUMN_KEY_VALUE // 0 }; /** - * Non indexable data keys colums indices. + * Non indexable data keys columns indices. */ public static final int COLUMN_INDEX_NON_INDEXABLE_KEYS_KEY_VALUE = 0; @@ -204,6 +206,11 @@ public class SearchIndexablesContract { * Key associated with the raw data. The key needs to be unique. */ public static final String COLUMN_KEY = "key"; + + /** + * UserId associated with the raw data. + */ + public static final String COLUMN_USER_ID = "user_id"; } /** diff --git a/core/java/android/provider/Settings.java b/core/java/android/provider/Settings.java index f48855a..07397973 100644 --- a/core/java/android/provider/Settings.java +++ b/core/java/android/provider/Settings.java @@ -5112,6 +5112,61 @@ public final class Settings { public static final String INSTALL_NON_MARKET_APPS = Secure.INSTALL_NON_MARKET_APPS; /** + * Whether HDMI control shall be enabled. If disabled, no CEC/MHL command will be + * sent or processed. (0 = false, 1 = true) + * @hide + */ + public static final String HDMI_CONTROL_ENABLED = "hdmi_control_enabled"; + + /** + * Whether HDMI system audio is enabled. If enabled, TV internal speaker is muted, + * and the output is redirected to AV Receiver connected via + * {@Global#HDMI_SYSTEM_AUDIO_OUTPUT}. + * @hide + */ + public static final String HDMI_SYSTEM_AUDIO_ENABLED = "hdmi_system_audio_enabled"; + + /** + * Output of the audio to be used for system audio mode, as defined in AudioSystem.java. + * <ul> + * <li>DEVICE_OUT_SPDIF</li> + * <li>DEVICE_OUT_HDMI_ARC</li> + * <li>DEVICE_OUT_LINE</li> + * </ul> + * @hide + */ + public static final String HDMI_SYSTEM_AUDIO_OUTPUT = "hdmi_system_audio_output"; + + /** + * Whether TV will automatically turn on upon reception of the CEC command + * <Text View On> or <Image View On>. (0 = false, 1 = true) + * @hide + */ + public static final String HDMI_CONTROL_AUTO_WAKEUP_ENABLED = + "hdmi_control_auto_wakeup_enabled"; + + /** + * Whether TV will also turn off other CEC devices when it goes to standby mode. + * (0 = false, 1 = true) + * @hide + */ + public static final String HDMI_CONTROL_AUTO_DEVICE_OFF_ENABLED = + "hdmi_control_auto_device_off_enabled"; + + /** + * Whether TV will switch to MHL port when a mobile device is plugged in. + * (0 = false, 1 = true) + * @hide + */ + public static final String MHL_INPUT_SWITCHING_ENABLED = "mhl_input_switching_enabled"; + + /** + * Whether TV will charge the mobile device connected at MHL port. (0 = false, 1 = true) + * @hide + */ + public static final String MHL_POWER_CHARGE_ENABLED = "mhl_power_charge_enabled"; + + /** * Whether mobile data connections are allowed by the user. See * ConnectivityManager for more info. * @hide diff --git a/core/java/android/service/notification/NotificationListenerService.java b/core/java/android/service/notification/NotificationListenerService.java index 8bd0f4d..7d5ff33 100644 --- a/core/java/android/service/notification/NotificationListenerService.java +++ b/core/java/android/service/notification/NotificationListenerService.java @@ -29,7 +29,6 @@ import android.os.Parcel; import android.os.Parcelable; import android.os.RemoteException; import android.os.ServiceManager; -import android.util.ArrayMap; import android.util.Log; import java.util.List; @@ -410,28 +409,20 @@ public abstract class NotificationListenerService extends Service { } /** - * Provides access to ranking information on a currently active - * notification. + * Stores ranking related information on a currently active notification. * * <p> - * Note that this object is not updated on notification events (such as - * {@link #onNotificationPosted(StatusBarNotification, RankingMap)}, - * {@link #onNotificationRemoved(StatusBarNotification)}, etc.). Make sure - * to retrieve a new Ranking from the current {@link RankingMap} whenever - * a notification event occurs. + * Ranking objects aren't automatically updated as notification events + * occur. Instead, ranking information has to be retrieved again via the + * current {@link RankingMap}. */ public static class Ranking { - private final String mKey; - private final int mRank; - private final boolean mIsAmbient; - private final boolean mIsInterceptedByDnd; + private String mKey; + private int mRank = -1; + private boolean mIsAmbient; + private boolean mMeetsInterruptionFilter; - private Ranking(String key, int rank, boolean isAmbient, boolean isInterceptedByDnd) { - mKey = key; - mRank = rank; - mIsAmbient = isAmbient; - mIsInterceptedByDnd = isInterceptedByDnd; - } + public Ranking() {} /** * Returns the key of the notification this Ranking applies to. @@ -459,11 +450,19 @@ public abstract class NotificationListenerService extends Service { } /** - * Returns whether the notification was intercepted by - * "Do not disturb". + * Returns whether the notification meets the user's interruption + * filter. */ - public boolean isInterceptedByDoNotDisturb() { - return mIsInterceptedByDnd; + public boolean meetsInterruptionFilter() { + return mMeetsInterruptionFilter; + } + + private void populate(String key, int rank, boolean isAmbient, + boolean meetsInterruptionFilter) { + mKey = key; + mRank = rank; + mIsAmbient = isAmbient; + mMeetsInterruptionFilter = meetsInterruptionFilter; } } @@ -477,12 +476,9 @@ public abstract class NotificationListenerService extends Service { */ public static class RankingMap implements Parcelable { private final NotificationRankingUpdate mRankingUpdate; - private final ArrayMap<String, Ranking> mRankingCache; - private boolean mRankingCacheInitialized; private RankingMap(NotificationRankingUpdate rankingUpdate) { mRankingUpdate = rankingUpdate; - mRankingCache = new ArrayMap<>(rankingUpdate.getOrderedKeys().length); } /** @@ -496,37 +492,42 @@ public abstract class NotificationListenerService extends Service { } /** - * Returns the Ranking for the notification with the given key. + * Populates outRanking with ranking information for the notification + * with the given key. * - * @return the Ranking of the notification with the given key; - * <code>null</code> when the key is unknown. + * @return true if a valid key has been passed and outRanking has + * been populated; false otherwise */ - public Ranking getRanking(String key) { - synchronized (mRankingCache) { - if (!mRankingCacheInitialized) { - initializeRankingCache(); - mRankingCacheInitialized = true; - } - } - return mRankingCache.get(key); + public boolean getRanking(String key, Ranking outRanking) { + int rank = getRank(key); + outRanking.populate(key, rank, isAmbient(key), !isIntercepted(key)); + return rank >= 0; } - private void initializeRankingCache() { + private int getRank(String key) { + // TODO: Optimize. String[] orderedKeys = mRankingUpdate.getOrderedKeys(); - int firstAmbientIndex = mRankingUpdate.getFirstAmbientIndex(); for (int i = 0; i < orderedKeys.length; i++) { - String key = orderedKeys[i]; - boolean isAmbient = firstAmbientIndex > -1 && firstAmbientIndex <= i; - boolean isInterceptedByDnd = false; - // TODO: Optimize. - for (String s : mRankingUpdate.getDndInterceptedKeys()) { - if (s.equals(key)) { - isInterceptedByDnd = true; - break; - } + if (orderedKeys[i].equals(key)) { + return i; } - mRankingCache.put(key, new Ranking(key, i, isAmbient, isInterceptedByDnd)); } + return -1; + } + + private boolean isAmbient(String key) { + int rank = getRank(key); + return rank >= 0 && rank >= mRankingUpdate.getFirstAmbientIndex(); + } + + private boolean isIntercepted(String key) { + // TODO: Optimize. + for (String interceptedKey : mRankingUpdate.getInterceptedKeys()) { + if (interceptedKey.equals(key)) { + return true; + } + } + return false; } // ----------- Parcelable diff --git a/core/java/android/service/notification/NotificationRankingUpdate.java b/core/java/android/service/notification/NotificationRankingUpdate.java index 4b13d95..26af38b 100644 --- a/core/java/android/service/notification/NotificationRankingUpdate.java +++ b/core/java/android/service/notification/NotificationRankingUpdate.java @@ -24,20 +24,20 @@ import android.os.Parcelable; public class NotificationRankingUpdate implements Parcelable { // TODO: Support incremental updates. private final String[] mKeys; - private final String[] mDndInterceptedKeys; + private final String[] mInterceptedKeys; private final int mFirstAmbientIndex; - public NotificationRankingUpdate(String[] keys, String[] dndInterceptedKeys, + public NotificationRankingUpdate(String[] keys, String[] interceptedKeys, int firstAmbientIndex) { mKeys = keys; mFirstAmbientIndex = firstAmbientIndex; - mDndInterceptedKeys = dndInterceptedKeys; + mInterceptedKeys = interceptedKeys; } public NotificationRankingUpdate(Parcel in) { mKeys = in.readStringArray(); mFirstAmbientIndex = in.readInt(); - mDndInterceptedKeys = in.readStringArray(); + mInterceptedKeys = in.readStringArray(); } @Override @@ -49,7 +49,7 @@ public class NotificationRankingUpdate implements Parcelable { public void writeToParcel(Parcel out, int flags) { out.writeStringArray(mKeys); out.writeInt(mFirstAmbientIndex); - out.writeStringArray(mDndInterceptedKeys); + out.writeStringArray(mInterceptedKeys); } public static final Parcelable.Creator<NotificationRankingUpdate> CREATOR @@ -71,7 +71,7 @@ public class NotificationRankingUpdate implements Parcelable { return mFirstAmbientIndex; } - public String[] getDndInterceptedKeys() { - return mDndInterceptedKeys; + public String[] getInterceptedKeys() { + return mInterceptedKeys; } } diff --git a/core/java/android/service/voice/AlwaysOnHotwordDetector.java b/core/java/android/service/voice/AlwaysOnHotwordDetector.java new file mode 100644 index 0000000..67ce31e --- /dev/null +++ b/core/java/android/service/voice/AlwaysOnHotwordDetector.java @@ -0,0 +1,270 @@ +/** + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.service.voice; + +import android.content.Intent; +import android.hardware.soundtrigger.Keyphrase; +import android.hardware.soundtrigger.KeyphraseEnrollmentInfo; +import android.hardware.soundtrigger.KeyphraseMetadata; +import android.hardware.soundtrigger.SoundTriggerHelper; +import android.util.Slog; + +/** + * A class that lets a VoiceInteractionService implementation interact with + * always-on keyphrase detection APIs. + */ +public class AlwaysOnHotwordDetector { + //---- States of Keyphrase availability ----// + /** + * Indicates that the given keyphrase is not available on the system because of the + * hardware configuration. + */ + public static final int KEYPHRASE_HARDWARE_UNAVAILABLE = -2; + /** + * Indicates that the given keyphrase is not supported. + */ + public static final int KEYPHRASE_UNSUPPORTED = -1; + /** + * Indicates that the given keyphrase is not enrolled. + */ + public static final int KEYPHRASE_UNENROLLED = 1; + /** + * Indicates that the given keyphrase is currently enrolled but not being actively listened for. + */ + public static final int KEYPHRASE_ENROLLED = 2; + + // Keyphrase management actions ----// + /** Indicates that we need to enroll. */ + public static final int MANAGE_ACTION_ENROLL = 0; + /** Indicates that we need to re-enroll. */ + public static final int MANAGE_ACTION_RE_ENROLL = 1; + /** Indicates that we need to un-enroll. */ + public static final int MANAGE_ACTION_UN_ENROLL = 2; + + /** + * Return codes for {@link #startRecognition()}, {@link #stopRecognition()} + */ + public static final int STATUS_ERROR = Integer.MIN_VALUE; + public static final int STATUS_OK = 1; + + //---- Keyphrase recognition status ----// + // TODO: Figure out if they are exclusive or should be flags instead? + public static final int RECOGNITION_NOT_AVAILABLE = -3; + public static final int RECOGNITION_NOT_REQUESTED = -2; + public static final int RECOGNITION_DISABLED_TEMPORARILY = -1; + public static final int RECOGNITION_REQUESTED = 1; + public static final int RECOGNITION_ACTIVE = 2; + static final String TAG = "AlwaysOnHotwordDetector"; + + private final String mText; + private final String mLocale; + private final Keyphrase mKeyphrase; + private final KeyphraseEnrollmentInfo mKeyphraseEnrollmentInfo; + private final SoundTriggerHelper mSoundTriggerHelper; + private final SoundTriggerHelper.Listener mListener; + private final int mAvailability; + + private int mRecognitionState; + + /** + * Callbacks for always-on hotword detection. + */ + public interface Callback { + /** + * Called when the keyphrase is spoken. + * TODO: Add more data to the callback. + */ + void onDetected(); + /** + * Called when the detection for the associated keyphrase starts. + */ + void onDetectionStarted(); + /** + * Called when the detection for the associated keyphrase stops. + */ + void onDetectionStopped(); + } + + /** + * @param text The keyphrase text to get the detector for. + * @param locale The java locale for the detector. + * @param callback A non-null Callback for receiving the recognition events. + * + * @hide + */ + public AlwaysOnHotwordDetector(String text, String locale, Callback callback, + KeyphraseEnrollmentInfo keyphraseEnrollmentInfo, + SoundTriggerHelper soundTriggerHelper) { + mText = text; + mLocale = locale; + mKeyphraseEnrollmentInfo = keyphraseEnrollmentInfo; + KeyphraseMetadata keyphraseMetadata = + mKeyphraseEnrollmentInfo.getKeyphraseMetadata(text, locale); + if (keyphraseMetadata != null) { + mKeyphrase = new Keyphrase(keyphraseMetadata.id, text, locale); + } else { + mKeyphrase = null; + } + mListener = new SoundTriggerListener(callback); + mSoundTriggerHelper = soundTriggerHelper; + mAvailability = getAvailabilityInternal(); + } + + /** + * Gets the state of always-on hotword detection for the given keyphrase and locale + * on this system. + * Availability implies that the hardware on this system is capable of listening for + * the given keyphrase or not. + * + * @return Indicates if always-on hotword detection is available for the given keyphrase. + * The return code is one of {@link #KEYPHRASE_HARDWARE_UNAVAILABLE}, + * {@link #KEYPHRASE_UNSUPPORTED}, {@link #KEYPHRASE_UNENROLLED} or + * {@link #KEYPHRASE_ENROLLED}. + */ + public int getAvailability() { + return mAvailability; + } + + /** + * Gets the status of the recognition. + * @return One of {@link #RECOGNITION_NOT_AVAILABLE}, {@link #RECOGNITION_NOT_REQUESTED}, + * {@link #RECOGNITION_DISABLED_TEMPORARILY} or {@link #RECOGNITION_ACTIVE}. + * @throws UnsupportedOperationException if the recognition isn't supported. + * Callers should check the availability by calling {@link #getAvailability()} + * before calling this method to avoid this exception. + */ + public int getRecognitionStatus() { + if (mAvailability != KEYPHRASE_ENROLLED) { + throw new UnsupportedOperationException( + "Recognition for the given keyphrase is not supported"); + } + + return mRecognitionState; + } + + /** + * Starts recognition for the associated keyphrase. + * + * @return One of {@link #STATUS_ERROR} or {@link #STATUS_OK}. + * @throws UnsupportedOperationException if the recognition isn't supported. + * Callers should check the availability by calling {@link #getAvailability()} + * before calling this method to avoid this exception. + */ + public int startRecognition() { + if (mAvailability != KEYPHRASE_ENROLLED) { + throw new UnsupportedOperationException( + "Recognition for the given keyphrase is not supported"); + } + + mRecognitionState = RECOGNITION_REQUESTED; + int code = mSoundTriggerHelper.startRecognition(mKeyphrase.id, mListener); + if (code != SoundTriggerHelper.STATUS_OK) { + Slog.w(TAG, "startRecognition() failed with error code " + code); + return STATUS_ERROR; + } else { + return STATUS_OK; + } + } + + /** + * Stops recognition for the associated keyphrase. + * + * @return One of {@link #STATUS_ERROR} or {@link #STATUS_OK}. + * @throws UnsupportedOperationException if the recognition isn't supported. + * Callers should check the availability by calling {@link #getAvailability()} + * before calling this method to avoid this exception. + */ + public int stopRecognition() { + if (mAvailability != KEYPHRASE_ENROLLED) { + throw new UnsupportedOperationException( + "Recognition for the given keyphrase is not supported"); + } + + mRecognitionState = RECOGNITION_NOT_REQUESTED; + int code = mSoundTriggerHelper.stopRecognition(mKeyphrase.id, mListener); + if (code != SoundTriggerHelper.STATUS_OK) { + Slog.w(TAG, "stopRecognition() failed with error code " + code); + return STATUS_ERROR; + } else { + return STATUS_OK; + } + } + + /** + * Gets an intent to manage the associated keyphrase. + * + * @param action The manage action that needs to be performed. + * One of {@link #MANAGE_ACTION_ENROLL}, {@link #MANAGE_ACTION_RE_ENROLL} or + * {@link #MANAGE_ACTION_UN_ENROLL}. + * @return An {@link Intent} to manage the given keyphrase. + * @throws UnsupportedOperationException if managing they keyphrase isn't supported. + * Callers should check the availability by calling {@link #getAvailability()} + * before calling this method to avoid this exception. + */ + public Intent getManageIntent(int action) { + if (mAvailability == KEYPHRASE_HARDWARE_UNAVAILABLE + || mAvailability == KEYPHRASE_UNSUPPORTED) { + throw new UnsupportedOperationException( + "Managing the given keyphrase is not supported"); + } + if (action != MANAGE_ACTION_ENROLL + && action != MANAGE_ACTION_RE_ENROLL + && action != MANAGE_ACTION_UN_ENROLL) { + throw new IllegalArgumentException("Invalid action specified " + action); + } + + return mKeyphraseEnrollmentInfo.getManageKeyphraseIntent(action, mText, mLocale); + } + + private int getAvailabilityInternal() { + if (mSoundTriggerHelper.dspInfo == null) { + return KEYPHRASE_HARDWARE_UNAVAILABLE; + } + if (mKeyphrase == null || !mSoundTriggerHelper.isKeyphraseSupported(mKeyphrase)) { + return KEYPHRASE_UNSUPPORTED; + } + if (!mSoundTriggerHelper.isKeyphraseEnrolled(mKeyphrase)) { + return KEYPHRASE_UNENROLLED; + } + return KEYPHRASE_ENROLLED; + } + + /** @hide */ + static final class SoundTriggerListener implements SoundTriggerHelper.Listener { + private final Callback mCallback; + + public SoundTriggerListener(Callback callback) { + this.mCallback = callback; + } + + @Override + public void onKeyphraseSpoken() { + Slog.i(TAG, "onKeyphraseSpoken"); + mCallback.onDetected(); + } + + @Override + public void onListeningStateChanged(int state) { + Slog.i(TAG, "onListeningStateChanged: state=" + state); + if (state == SoundTriggerHelper.STATE_STARTED) { + mCallback.onDetectionStarted(); + } else if (state == SoundTriggerHelper.STATE_STOPPED) { + mCallback.onDetectionStopped(); + } + } + } +} diff --git a/core/java/android/service/voice/KeyphraseInfo.java b/core/java/android/service/voice/KeyphraseInfo.java deleted file mode 100644 index d266e1a..0000000 --- a/core/java/android/service/voice/KeyphraseInfo.java +++ /dev/null @@ -1,27 +0,0 @@ -package android.service.voice; - -import android.util.ArraySet; - -/** - * A Voice Keyphrase. - * @hide - */ -public class KeyphraseInfo { - public final int id; - public final String keyphrase; - public final ArraySet<String> supportedLocales; - - public KeyphraseInfo(int id, String keyphrase, String[] supportedLocales) { - this.id = id; - this.keyphrase = keyphrase; - this.supportedLocales = new ArraySet<String>(supportedLocales.length); - for (String locale : supportedLocales) { - this.supportedLocales.add(locale); - } - } - - @Override - public String toString() { - return "id=" + id + ", keyphrase=" + keyphrase + ", supported-locales=" + supportedLocales; - } -} diff --git a/core/java/android/service/voice/SoundTriggerManager.java b/core/java/android/service/voice/SoundTriggerManager.java deleted file mode 100644 index 2d049b9..0000000 --- a/core/java/android/service/voice/SoundTriggerManager.java +++ /dev/null @@ -1,73 +0,0 @@ -/* - * Copyright (C) 2014 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package android.service.voice; - -import android.hardware.soundtrigger.SoundTrigger; -import android.hardware.soundtrigger.SoundTrigger.ModuleProperties; - -import java.util.ArrayList; - -/** - * Manager for {@link SoundTrigger} APIs. - * Currently this just acts as an abstraction over all SoundTrigger API calls. - * @hide - */ -public class SoundTriggerManager { - /** The {@link DspInfo} for the system, or null if none exists. */ - public DspInfo dspInfo; - - public SoundTriggerManager() { - ArrayList <ModuleProperties> modules = new ArrayList<>(); - int status = SoundTrigger.listModules(modules); - if (status != SoundTrigger.STATUS_OK || modules.size() == 0) { - // TODO(sansid, elaurent): Figure out how to handle errors in listing the modules here. - dspInfo = null; - } else { - // TODO(sansid, elaurent): Figure out how to determine which module corresponds to the - // DSP hardware. - ModuleProperties properties = modules.get(0); - dspInfo = new DspInfo(properties.uuid, properties.implementor, properties.description, - properties.version, properties.powerConsumptionMw); - } - } - - /** - * @return True, if the keyphrase is supported on DSP for the given locale. - */ - public boolean isKeyphraseSupported(String keyphrase, String locale) { - // TODO(sansid): We also need to look into a SoundTrigger API that let's us - // query this. For now just return supported if there's a DSP available. - return dspInfo != null; - } - - /** - * @return True, if the keyphrase is has been enrolled for the given locale. - */ - public boolean isKeyphraseEnrolled(String keyphrase, String locale) { - // TODO(sansid, elaurent): Query SoundTrigger to list currently loaded sound models. - // They have been enrolled. - return false; - } - - /** - * @return True, if a recognition for the keyphrase is active for the given locale. - */ - public boolean isKeyphraseActive(String keyphrase, String locale) { - // TODO(sansid, elaurent): Check if the recognition for the keyphrase is currently active. - return false; - } -} diff --git a/core/java/android/service/voice/VoiceInteractionService.java b/core/java/android/service/voice/VoiceInteractionService.java index e0329f8..cf8d502 100644 --- a/core/java/android/service/voice/VoiceInteractionService.java +++ b/core/java/android/service/voice/VoiceInteractionService.java @@ -20,6 +20,8 @@ import android.annotation.SdkConstant; import android.app.Service; import android.content.Context; import android.content.Intent; +import android.hardware.soundtrigger.KeyphraseEnrollmentInfo; +import android.hardware.soundtrigger.SoundTriggerHelper; import android.os.Bundle; import android.os.IBinder; import android.os.RemoteException; @@ -53,16 +55,6 @@ public class VoiceInteractionService extends Service { public static final String SERVICE_INTERFACE = "android.service.voice.VoiceInteractionService"; - // TODO(sansid): Unhide these. - /** @hide */ - public static final int KEYPHRASE_UNAVAILABLE = 0; - /** @hide */ - public static final int KEYPHRASE_UNENROLLED = 1; - /** @hide */ - public static final int KEYPHRASE_ENROLLED = 2; - /** @hide */ - public static final int KEYPHRASE_ACTIVE = 3; - /** * Name under which a VoiceInteractionService component publishes information about itself. * This meta-data should reference an XML resource containing a @@ -76,8 +68,8 @@ public class VoiceInteractionService extends Service { IVoiceInteractionManagerService mSystemService; - private SoundTriggerManager mSoundTriggerManager; private KeyphraseEnrollmentInfo mKeyphraseEnrollmentInfo; + private SoundTriggerHelper mSoundTriggerHelper; public void startSession(Bundle args) { try { @@ -92,7 +84,7 @@ public class VoiceInteractionService extends Service { mSystemService = IVoiceInteractionManagerService.Stub.asInterface( ServiceManager.getService(Context.VOICE_INTERACTION_MANAGER_SERVICE)); mKeyphraseEnrollmentInfo = new KeyphraseEnrollmentInfo(getPackageManager()); - mSoundTriggerManager = new SoundTriggerManager(); + mSoundTriggerHelper = new SoundTriggerHelper(); } @Override @@ -104,34 +96,18 @@ public class VoiceInteractionService extends Service { } /** - * Gets the state of always-on hotword detection for the given keyphrase and locale - * on this system. - * Availability implies that the hardware on this system is capable of listening for - * the given keyphrase or not. - * The return code is one of {@link #KEYPHRASE_UNAVAILABLE}, {@link #KEYPHRASE_UNENROLLED} - * {@link #KEYPHRASE_ENROLLED} or {@link #KEYPHRASE_ACTIVE}. - * - * @param keyphrase The keyphrase whose availability is being checked. - * @param locale The locale for which the availability is being checked. - * @return Indicates if always-on hotword detection is available for the given keyphrase. - * TODO(sansid): Unhide this. - * @hide + * @param keyphrase The keyphrase that's being used, for example "Hello Android". + * @param locale The locale for which the enrollment needs to be performed. + * This is a Java locale, for example "en_US". + * @param callback The callback to notify of detection events. + * @return An always-on hotword detector for the given keyphrase and locale. */ - public final int getAlwaysOnKeyphraseAvailability(String keyphrase, String locale) { - // The available keyphrases is a combination of DSP availability and - // the keyphrases that have an enrollment application for them. - if (!mSoundTriggerManager.isKeyphraseSupported(keyphrase, locale) - || !mKeyphraseEnrollmentInfo.isKeyphraseEnrollmentSupported(keyphrase, locale)) { - return KEYPHRASE_UNAVAILABLE; - } - if (!mSoundTriggerManager.isKeyphraseEnrolled(keyphrase, locale)) { - return KEYPHRASE_UNENROLLED; - } - if (!mSoundTriggerManager.isKeyphraseActive(keyphrase, locale)) { - return KEYPHRASE_ENROLLED; - } else { - return KEYPHRASE_ACTIVE; - } + public final AlwaysOnHotwordDetector getAlwaysOnHotwordDetector( + String keyphrase, String locale, AlwaysOnHotwordDetector.Callback callback) { + // TODO: Cache instances and return the same one instead of creating a new interactor + // for the same keyphrase/locale combination. + return new AlwaysOnHotwordDetector(keyphrase, locale, callback, + mKeyphraseEnrollmentInfo, mSoundTriggerHelper); } /** diff --git a/core/java/android/text/SpannableStringBuilder.java b/core/java/android/text/SpannableStringBuilder.java index 6b984d6..06df683 100644 --- a/core/java/android/text/SpannableStringBuilder.java +++ b/core/java/android/text/SpannableStringBuilder.java @@ -251,6 +251,21 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable return replace(length, length, text, 0, text.length()); } + /** + * Appends the character sequence {@code text} and spans {@code what} over the appended part. + * See {@link Spanned} for an explanation of what the flags mean. + * @param text the character sequence to append. + * @param what the object to be spanned over the appended text. + * @param flags see {@link Spanned}. + * @return this {@code SpannableStringBuilder}. + */ + public SpannableStringBuilder append(CharSequence text, Object what, int flags) { + int start = length(); + append(text); + setSpan(what, start, length(), flags); + return this; + } + // Documentation from interface public SpannableStringBuilder append(CharSequence text, int start, int end) { int length = length(); diff --git a/core/java/android/view/HardwareRenderer.java b/core/java/android/view/HardwareRenderer.java index d69d01d..be677ea 100644 --- a/core/java/android/view/HardwareRenderer.java +++ b/core/java/android/view/HardwareRenderer.java @@ -18,6 +18,7 @@ package android.view; import android.content.Context; import android.graphics.Bitmap; +import android.graphics.Rect; import android.util.DisplayMetrics; import android.view.Surface.OutOfResourcesException; @@ -247,21 +248,24 @@ public abstract class HardwareRenderer { abstract void detachSurfaceTexture(long hardwareLayer); /** - * Setup the hardware renderer for drawing. This is called whenever the - * size of the target surface changes or when the surface is first created. + * Setup the hardware renderer for drawing. This is called whenever the size + * of the target surface changes or when the surface is first created. * * @param width Width of the drawing surface. * @param height Height of the drawing surface. + * @param surfaceInsets Insets between the drawing surface and actual + * surface bounds. * @param lightX X position of the shadow casting light * @param lightY Y position of the shadow casting light * @param lightZ Z position of the shadow casting light * @param lightRadius radius of the shadow casting light */ - abstract void setup(int width, int height, float lightX, float lightY, float lightZ, float lightRadius); + abstract void setup(int width, int height, Rect surfaceInsets, float lightX, float lightY, + float lightZ, float lightRadius); /** * Gets the current width of the surface. This is the width that the surface - * was last set to in a call to {@link #setup(int, int, float, float, float, float)}. + * was last set to in a call to {@link #setup(int, int, Rect, float, float, float, float)}. * * @return the current width of the surface */ @@ -269,7 +273,7 @@ public abstract class HardwareRenderer { /** * Gets the current height of the surface. This is the height that the surface - * was last set to in a call to {@link #setup(int, int, float, float, float, float)}. + * was last set to in a call to {@link #setup(int, int, Rect, float, float, float, float)}. * * @return the current width of the surface */ @@ -344,7 +348,6 @@ public abstract class HardwareRenderer { * @param view The view to draw. * @param attachInfo AttachInfo tied to the specified view. * @param callbacks Callbacks invoked when drawing happens. - * @param dirty The dirty rectangle to update, can be null. */ abstract void draw(View view, View.AttachInfo attachInfo, HardwareDrawCallbacks callbacks); @@ -369,17 +372,18 @@ public abstract class HardwareRenderer { * @param height The height of the drawing surface. * @param surface The surface to hardware accelerate * @param metrics The display metrics used to draw the output. + * @param surfaceInsets The drawing surface insets to apply * * @return true if the surface was initialized, false otherwise. Returning * false might mean that the surface was already initialized. */ - boolean initializeIfNeeded(int width, int height, Surface surface, DisplayMetrics metrics) + boolean initializeIfNeeded(int width, int height, Surface surface, Rect surfaceInsets, DisplayMetrics metrics) throws OutOfResourcesException { if (isRequested()) { // We lost the gl context, so recreate it. if (!isEnabled()) { if (initialize(surface)) { - setup(width, height, metrics); + setup(width, height, surfaceInsets, metrics); return true; } } @@ -387,12 +391,12 @@ public abstract class HardwareRenderer { return false; } - void setup(int width, int height, DisplayMetrics metrics) { + void setup(int width, int height, Rect surfaceInsets, DisplayMetrics metrics) { float lightX = width / 2.0f; float lightY = -400 * metrics.density; float lightZ = 800 * metrics.density; float lightRadius = 800 * metrics.density; - setup(width, height, lightX, lightY, lightZ, lightRadius); + setup(width, height, surfaceInsets, lightX, lightY, lightZ, lightRadius); } /** diff --git a/core/java/android/view/ThreadedRenderer.java b/core/java/android/view/ThreadedRenderer.java index 57d1beb..acb2fe4 100644 --- a/core/java/android/view/ThreadedRenderer.java +++ b/core/java/android/view/ThreadedRenderer.java @@ -19,6 +19,7 @@ package android.view; import android.content.Context; import android.content.res.Resources; import android.graphics.Bitmap; +import android.graphics.Rect; import android.graphics.drawable.Drawable; import android.os.IBinder; import android.os.RemoteException; @@ -67,7 +68,16 @@ public class ThreadedRenderer extends HardwareRenderer { PROFILE_PROPERTY_VISUALIZE_BARS, }; + // Size of the rendered content. private int mWidth, mHeight; + + // Actual size of the drawing surface. + private int mSurfaceWidth, mSurfaceHeight; + + // Insets between the drawing surface and rendered content. These are + // applied as translation when updating the root render node. + private int mInsetTop, mInsetLeft; + private long mNativeProxy; private boolean mInitialized = false; private RenderNode mRootNode; @@ -154,11 +164,23 @@ public class ThreadedRenderer extends HardwareRenderer { } @Override - void setup(int width, int height, float lightX, float lightY, float lightZ, float lightRadius) { + void setup(int width, int height, Rect surfaceInsets, float lightX, float lightY, float lightZ, + float lightRadius) { mWidth = width; mHeight = height; - mRootNode.setLeftTopRightBottom(0, 0, mWidth, mHeight); - nSetup(mNativeProxy, width, height, lightX, lightY, lightZ, lightRadius); + if (surfaceInsets != null) { + mInsetLeft = surfaceInsets.left; + mInsetTop = surfaceInsets.top; + mSurfaceWidth = width + mInsetLeft + surfaceInsets.right; + mSurfaceHeight = height + mInsetTop + surfaceInsets.bottom; + } else { + mInsetLeft = 0; + mInsetTop = 0; + mSurfaceWidth = width; + mSurfaceHeight = height; + } + mRootNode.setLeftTopRightBottom(-mInsetLeft, -mInsetTop, mSurfaceWidth, mSurfaceHeight); + nSetup(mNativeProxy, mSurfaceWidth, mSurfaceHeight, lightX, lightY, lightZ, lightRadius); } @Override @@ -214,9 +236,10 @@ public class ThreadedRenderer extends HardwareRenderer { view.mPrivateFlags &= ~View.PFLAG_INVALIDATED; Trace.traceBegin(Trace.TRACE_TAG_VIEW, "getDisplayList"); - HardwareCanvas canvas = mRootNode.start(mWidth, mHeight); + HardwareCanvas canvas = mRootNode.start(mSurfaceWidth, mSurfaceHeight); try { canvas.save(); + canvas.translate(mInsetLeft, mInsetTop); callbacks.onHardwarePreDraw(canvas); canvas.drawRenderNode(view.getDisplayList()); callbacks.onHardwarePostDraw(canvas); diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 675b96d..31d2b1e 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -7431,7 +7431,8 @@ public class View implements Drawable.Callback, KeyEvent.Callback, ViewParent ancestor = mParent; while (ancestor instanceof ViewGroup) { final ViewGroup vgAncestor = (ViewGroup) ancestor; - if (vgAncestor.getDescendantFocusability() == ViewGroup.FOCUS_BLOCK_DESCENDANTS) { + if (vgAncestor.getDescendantFocusability() == ViewGroup.FOCUS_BLOCK_DESCENDANTS + || vgAncestor.shouldBlockFocusForTouchscreen()) { return true; } else { ancestor = vgAncestor.getParent(); diff --git a/core/java/android/view/ViewGroup.java b/core/java/android/view/ViewGroup.java index 36e5996..edc9971 100644 --- a/core/java/android/view/ViewGroup.java +++ b/core/java/android/view/ViewGroup.java @@ -18,6 +18,7 @@ package android.view; import android.animation.LayoutTransition; import android.content.Context; +import android.content.pm.PackageManager; import android.content.res.Configuration; import android.content.res.TypedArray; import android.graphics.Bitmap; @@ -361,6 +362,11 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager static final int FLAG_IS_TRANSITION_GROUP_SET = 0x2000000; /** + * When set, focus will not be permitted to enter this group if a touchscreen is present. + */ + static final int FLAG_TOUCHSCREEN_BLOCKS_FOCUS = 0x4000000; + + /** * Indicates which types of drawing caches are to be kept in memory. * This field should be made private, so it is hidden from the SDK. * {@hide} @@ -567,6 +573,9 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager case R.styleable.ViewGroup_transitionGroup: setTransitionGroup(a.getBoolean(attr, false)); break; + case R.styleable.ViewGroup_touchscreenBlocksFocus: + setTouchscreenBlocksFocus(a.getBoolean(attr, false)); + break; } } @@ -660,6 +669,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager // shortcut: don't report a new focusable view if we block our descendants from // getting focus && (getDescendantFocusability() != FOCUS_BLOCK_DESCENDANTS) + && !shouldBlockFocusForTouchscreen() // shortcut: don't report a new focusable view if we already are focused // (and we don't prefer our descendants) // @@ -901,7 +911,8 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager } final int descendantFocusability = getDescendantFocusability(); - if (descendantFocusability != FOCUS_BLOCK_DESCENDANTS) { + if (descendantFocusability != FOCUS_BLOCK_DESCENDANTS && + !shouldBlockFocusForTouchscreen()) { final int count = mChildrenCount; final View[] children = mChildren; @@ -925,7 +936,8 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager final int descendantFocusability = getDescendantFocusability(); - if (descendantFocusability != FOCUS_BLOCK_DESCENDANTS) { + if (descendantFocusability != FOCUS_BLOCK_DESCENDANTS && + !shouldBlockFocusForTouchscreen()) { final int count = mChildrenCount; final View[] children = mChildren; @@ -941,13 +953,46 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager // FOCUS_AFTER_DESCENDANTS and there are some descendants focusable. this is // to avoid the focus search finding layouts when a more precise search // among the focusable children would be more interesting. - if (descendantFocusability != FOCUS_AFTER_DESCENDANTS + if ((descendantFocusability != FOCUS_AFTER_DESCENDANTS // No focusable descendants - || (focusableCount == views.size())) { + || (focusableCount == views.size())) && !shouldBlockFocusForTouchscreen()) { super.addFocusables(views, direction, focusableMode); } } + /** + * Set whether this ViewGroup should ignore focus requests for itself and its children. + * If this option is enabled and the ViewGroup or a descendant currently has focus, focus + * will proceed forward. + * + * @param touchscreenBlocksFocus true to enable blocking focus in the presence of a touchscreen + */ + public void setTouchscreenBlocksFocus(boolean touchscreenBlocksFocus) { + if (touchscreenBlocksFocus) { + mGroupFlags |= FLAG_TOUCHSCREEN_BLOCKS_FOCUS; + if (hasFocus()) { + final View newFocus = focusSearch(FOCUS_FORWARD); + if (newFocus != null) { + newFocus.requestFocus(); + } + } + } else { + mGroupFlags &= ~FLAG_TOUCHSCREEN_BLOCKS_FOCUS; + } + } + + /** + * Check whether this ViewGroup should ignore focus requests for itself and its children. + */ + public boolean getTouchscreenBlocksFocus() { + return (mGroupFlags & FLAG_TOUCHSCREEN_BLOCKS_FOCUS) != 0; + } + + boolean shouldBlockFocusForTouchscreen() { + return getTouchscreenBlocksFocus() && + mContext.getPackageManager().hasSystemFeature(PackageManager.FEATURE_TOUCHSCREEN); + } + @Override public void findViewsWithText(ArrayList<View> outViews, CharSequence text, int flags) { super.findViewsWithText(outViews, text, flags); @@ -2440,6 +2485,10 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager } int descendantFocusability = getDescendantFocusability(); + if (shouldBlockFocusForTouchscreen()) { + return false; + } + switch (descendantFocusability) { case FOCUS_BLOCK_DESCENDANTS: return super.requestFocus(direction, previouslyFocusedRect); diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java index 5def940..9405299 100644 --- a/core/java/android/view/ViewRootImpl.java +++ b/core/java/android/view/ViewRootImpl.java @@ -1713,7 +1713,8 @@ public final class ViewRootImpl implements ViewParent, if (hwInitialized || mWidth != mAttachInfo.mHardwareRenderer.getWidth() || mHeight != mAttachInfo.mHardwareRenderer.getHeight()) { - mAttachInfo.mHardwareRenderer.setup(mWidth, mHeight, + final Rect shadowInsets = params != null ? params.shadowInsets : null; + mAttachInfo.mHardwareRenderer.setup(mWidth, mHeight, shadowInsets, mAttachInfo.mRootView.getResources().getDisplayMetrics()); if (!hwInitialized) { mAttachInfo.mHardwareRenderer.invalidate(mSurface); @@ -2211,20 +2212,22 @@ public final class ViewRootImpl implements ViewParent, return measureSpec; } + int mHardwareXOffset; int mHardwareYOffset; int mResizeAlpha; final Paint mResizePaint = new Paint(); @Override public void onHardwarePreDraw(HardwareCanvas canvas) { - canvas.translate(0, -mHardwareYOffset); + canvas.translate(-mHardwareXOffset, -mHardwareYOffset); } @Override public void onHardwarePostDraw(HardwareCanvas canvas) { if (mResizeBuffer != null) { mResizePaint.setAlpha(mResizeAlpha); - canvas.drawHardwareLayer(mResizeBuffer, 0.0f, mHardwareYOffset, mResizePaint); + canvas.drawHardwareLayer(mResizeBuffer, mHardwareXOffset, mHardwareYOffset, + mResizePaint); } drawAccessibilityFocusedDrawableIfNeeded(canvas); } @@ -2368,15 +2371,17 @@ public final class ViewRootImpl implements ViewParent, attachInfo.mTreeObserver.dispatchOnScrollChanged(); } - int yoff; + final WindowManager.LayoutParams params = mWindowAttributes; + final Rect surfaceInsets = params != null ? params.shadowInsets : null; boolean animating = mScroller != null && mScroller.computeScrollOffset(); + final int curScrollY; if (animating) { - yoff = mScroller.getCurrY(); + curScrollY = mScroller.getCurrY(); } else { - yoff = mScrollY; + curScrollY = mScrollY; } - if (mCurScrollY != yoff) { - mCurScrollY = yoff; + if (mCurScrollY != curScrollY) { + mCurScrollY = curScrollY; fullRedrawNeeded = true; } @@ -2425,11 +2430,14 @@ public final class ViewRootImpl implements ViewParent, attachInfo.mTreeObserver.dispatchOnDraw(); + final int xOffset = surfaceInsets != null ? -surfaceInsets.left : 0; + final int yOffset = curScrollY + (surfaceInsets != null ? -surfaceInsets.top : 0); if (!dirty.isEmpty() || mIsAnimating) { if (attachInfo.mHardwareRenderer != null && attachInfo.mHardwareRenderer.isEnabled()) { // Draw with hardware renderer. mIsAnimating = false; - mHardwareYOffset = yoff; + mHardwareYOffset = yOffset; + mHardwareXOffset = xOffset; mResizeAlpha = resizeAlpha; dirty.setEmpty(); @@ -2450,8 +2458,9 @@ public final class ViewRootImpl implements ViewParent, attachInfo.mHardwareRenderer.isRequested()) { try { - attachInfo.mHardwareRenderer.initializeIfNeeded(mWidth, mHeight, - mSurface, attachInfo.mRootView.getResources().getDisplayMetrics()); + attachInfo.mHardwareRenderer.initializeIfNeeded( + mWidth, mHeight, mSurface, surfaceInsets, + attachInfo.mRootView.getResources().getDisplayMetrics()); } catch (OutOfResourcesException e) { handleOutOfResourcesException(e); return; @@ -2462,7 +2471,7 @@ public final class ViewRootImpl implements ViewParent, return; } - if (!drawSoftware(surface, attachInfo, yoff, scalingRequired, dirty)) { + if (!drawSoftware(surface, attachInfo, xOffset, yOffset, scalingRequired, dirty)) { return; } } @@ -2475,9 +2484,9 @@ public final class ViewRootImpl implements ViewParent, } /** - * @return true if drawing was succesfull, false if an error occurred + * @return true if drawing was successful, false if an error occurred */ - private boolean drawSoftware(Surface surface, AttachInfo attachInfo, int yoff, + private boolean drawSoftware(Surface surface, AttachInfo attachInfo, int xoff, int yoff, boolean scalingRequired, Rect dirty) { // Draw with software renderer. @@ -2526,7 +2535,7 @@ public final class ViewRootImpl implements ViewParent, // If we are applying an offset, we need to clear the area // where the offset doesn't appear to avoid having garbage // left in the blank areas. - if (!canvas.isOpaque() || yoff != 0) { + if (!canvas.isOpaque() || yoff != 0 || xoff != 0) { canvas.drawColor(0, PorterDuff.Mode.CLEAR); } @@ -2542,7 +2551,7 @@ public final class ViewRootImpl implements ViewParent, ", compatibilityInfo=" + cxt.getResources().getCompatibilityInfo()); } try { - canvas.translate(0, -yoff); + canvas.translate(-xoff, -yoff); if (mTranslator != null) { mTranslator.translateCanvas(canvas); } @@ -3147,8 +3156,10 @@ public final class ViewRootImpl implements ViewParent, if (mAttachInfo.mHardwareRenderer != null && mSurface.isValid()){ mFullRedrawNeeded = true; try { + final WindowManager.LayoutParams lp = mWindowAttributes; + final Rect surfaceInsets = lp != null ? lp.shadowInsets : null; mAttachInfo.mHardwareRenderer.initializeIfNeeded( - mWidth, mHeight, mSurface, + mWidth, mHeight, mSurface, surfaceInsets, mAttachInfo.mRootView.getResources().getDisplayMetrics()); } catch (OutOfResourcesException e) { Log.e(TAG, "OutOfResourcesException locking surface", e); diff --git a/core/java/android/view/WindowManager.java b/core/java/android/view/WindowManager.java index 4eecc6a..c06b5d8 100644 --- a/core/java/android/view/WindowManager.java +++ b/core/java/android/view/WindowManager.java @@ -19,7 +19,9 @@ package android.view; import android.app.Presentation; import android.content.Context; import android.content.pm.ActivityInfo; +import android.graphics.Insets; import android.graphics.PixelFormat; +import android.graphics.Rect; import android.os.IBinder; import android.os.Parcel; import android.os.Parcelable; @@ -1290,6 +1292,13 @@ public interface WindowManager extends ViewManager { * field is added with {@link #y} to supply the <var>yAdj</var> parameter. */ public float verticalMargin; + + /** + * Positive insets between the drawing surface and window content. + * + * @hide + */ + public Rect shadowInsets = new Rect(); /** * The desired bitmap format. May be one of the constants in @@ -1571,6 +1580,10 @@ public interface WindowManager extends ViewManager { out.writeInt(hasSystemUiListeners ? 1 : 0); out.writeInt(inputFeatures); out.writeLong(userActivityTimeout); + out.writeInt(shadowInsets.left); + out.writeInt(shadowInsets.top); + out.writeInt(shadowInsets.right); + out.writeInt(shadowInsets.bottom); } public static final Parcelable.Creator<LayoutParams> CREATOR @@ -1613,6 +1626,7 @@ public interface WindowManager extends ViewManager { hasSystemUiListeners = in.readInt() != 0; inputFeatures = in.readInt(); userActivityTimeout = in.readLong(); + shadowInsets.set(in.readInt(), in.readInt(), in.readInt(), in.readInt()); } @SuppressWarnings({"PointlessBitwiseExpression"}) @@ -1644,6 +1658,8 @@ public interface WindowManager extends ViewManager { /** {@hide} */ public static final int TRANSLUCENT_FLAGS_CHANGED = 1<<19; /** {@hide} */ + public static final int SHADOW_INSETS_CHANGED = 1<<20; + /** {@hide} */ public static final int EVERYTHING_CHANGED = 0xffffffff; // internal buffer to backup/restore parameters under compatibility mode. @@ -1778,6 +1794,11 @@ public interface WindowManager extends ViewManager { changes |= USER_ACTIVITY_TIMEOUT_CHANGED; } + if (!shadowInsets.equals(o.shadowInsets)) { + shadowInsets.set(o.shadowInsets); + changes |= SHADOW_INSETS_CHANGED; + } + return changes; } @@ -1877,6 +1898,9 @@ public interface WindowManager extends ViewManager { if (userActivityTimeout >= 0) { sb.append(" userActivityTimeout=").append(userActivityTimeout); } + if (!shadowInsets.equals(Insets.NONE)) { + sb.append(" shadowInsets=").append(shadowInsets); + } sb.append('}'); return sb.toString(); } diff --git a/core/java/android/view/WindowManagerInternal.java b/core/java/android/view/WindowManagerInternal.java index bf5c84e..38e3723 100644 --- a/core/java/android/view/WindowManagerInternal.java +++ b/core/java/android/view/WindowManagerInternal.java @@ -164,6 +164,11 @@ public abstract class WindowManagerInternal { public abstract void getWindowFrame(IBinder token, Rect outBounds); /** + * Opens the global actions dialog. + */ + public abstract void showGlobalActions(); + + /** * Invalidate all visible windows. Then report back on the callback once all windows have * redrawn. */ diff --git a/core/java/android/view/WindowManagerPolicy.java b/core/java/android/view/WindowManagerPolicy.java index ee542a1..5f0fa18 100644 --- a/core/java/android/view/WindowManagerPolicy.java +++ b/core/java/android/view/WindowManagerPolicy.java @@ -1162,6 +1162,12 @@ public interface WindowManagerPolicy { public void showRecentApps(); /** + * Show the global actions dialog. + * @hide + */ + public void showGlobalActions(); + + /** * @return The current height of the input method window. */ public int getInputMethodWindowVisibleHeightLw(); diff --git a/core/java/android/view/inputmethod/BaseInputConnection.java b/core/java/android/view/inputmethod/BaseInputConnection.java index e1f40b7..338f3d2 100644 --- a/core/java/android/view/inputmethod/BaseInputConnection.java +++ b/core/java/android/view/inputmethod/BaseInputConnection.java @@ -429,6 +429,21 @@ public class BaseInputConnection implements InputConnection { } /** + * The default implementation is responsible for handling + * {@link CursorAnchorInfoRequest#TYPE_CURSOR_RECT}. In fact, for derived classes, calling + * {@code super.requestCursorAnchorInfo(request)} is the only way to handle + * {@link CursorAnchorInfoRequest#TYPE_CURSOR_RECT}. + */ + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request) { + if (request != null && mIMM != null && + request.getRequestType() == CursorAnchorInfoRequest.TYPE_CURSOR_RECT) { + mIMM.setCursorRectMonitorMode(request.getRequestFlags()); + return CursorAnchorInfoRequest.RESULT_SCHEDULED; + } + return CursorAnchorInfoRequest.RESULT_NOT_HANDLED; + } + + /** * The default implementation places the given text into the editable, * replacing any existing composing text. The new text is marked as * in a composing state with the composing style. diff --git a/core/java/android/view/inputmethod/CursorAnchorInfoRequest.aidl b/core/java/android/view/inputmethod/CursorAnchorInfoRequest.aidl new file mode 100644 index 0000000..41ef7cc6 --- /dev/null +++ b/core/java/android/view/inputmethod/CursorAnchorInfoRequest.aidl @@ -0,0 +1,19 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.view.inputmethod; + +parcelable CursorAnchorInfoRequest; diff --git a/core/java/android/view/inputmethod/CursorAnchorInfoRequest.java b/core/java/android/view/inputmethod/CursorAnchorInfoRequest.java new file mode 100644 index 0000000..e4c94f2 --- /dev/null +++ b/core/java/android/view/inputmethod/CursorAnchorInfoRequest.java @@ -0,0 +1,203 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +package android.view.inputmethod; + +import android.inputmethodservice.InputMethodService; +import android.os.Parcel; +import android.os.Parcelable; +import android.view.View; + +/** + * Used to enable or disable event notification for + * {@link InputMethodService#onUpdateCursorAnchorInfo(CursorAnchorInfo)}. This class is also used to + * enable {@link InputMethodService#onUpdateCursor(android.graphics.Rect)} for existing editors + * that have not supported {@link InputMethodService#onUpdateCursorAnchorInfo(CursorAnchorInfo)}. + */ +public final class CursorAnchorInfoRequest implements Parcelable { + private final int mRequestType; + private final int mRequestFlags; + + /** + * Not handled by the editor. + */ + public static final int RESULT_NOT_HANDLED = 0x00; + /** + * Request is scheduled in the editor task queue. + */ + public static final int RESULT_SCHEDULED = 0x01; + + /** + * The request is for {@link InputMethodService#onUpdateCursorAnchorInfo(CursorAnchorInfo)}. + * This mechanism is powerful enough to retrieve fine-grained positional information of + * characters in the editor. + */ + public static final int TYPE_CURSOR_ANCHOR_INFO = 0x01; + /** + * The editor is requested to call + * {@link InputMethodManager#updateCursorAnchorInfo(android.view.View, CursorAnchorInfo)} + * whenever cursor/anchor position is changed. To disable monitoring, call + * {@link InputConnection#requestCursorAnchorInfo(CursorAnchorInfoRequest)} again with + * {@link #TYPE_CURSOR_ANCHOR_INFO} and this flag off. + * <p> + * This flag can be used together with {@link #FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE}. + * </p> + */ + public static final int FLAG_CURSOR_ANCHOR_INFO_MONITOR = 0x01; + /** + * The editor is requested to call + * {@link InputMethodManager#updateCursorAnchorInfo(android.view.View, CursorAnchorInfo)} at + * once, as soon as possible, regardless of cursor/anchor position changes. This flag can be + * used together with {@link #FLAG_CURSOR_ANCHOR_INFO_MONITOR}. + */ + public static final int FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE = 0x02; + + /** + * The request is for {@link InputMethodService#onUpdateCursor(android.graphics.Rect)}. This + * mechanism has been available since API Level 3 (CUPCAKE) but only the cursor rectangle can + * be retrieved with this mechanism. + */ + public static final int TYPE_CURSOR_RECT = 0x02; + /** + * The editor is requested to call + * {@link InputMethodManager#updateCursor(android.view.View, int, int, int, int)} + * whenever the cursor position is changed. To disable monitoring, call + * {@link InputConnection#requestCursorAnchorInfo(CursorAnchorInfoRequest)} again with + * {@link #TYPE_CURSOR_RECT} and this flag off. + * <p> + * This flag can be used together with {@link #FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES}. + * </p> + */ + public static final int FLAG_CURSOR_RECT_MONITOR = 0x01; + /** + * {@link InputMethodManager#updateCursor(android.view.View, int, int, int, int)} should be + * called back in screen coordinates. To receive cursor position in local coordinates, call + * {@link InputConnection#requestCursorAnchorInfo(CursorAnchorInfoRequest)} again with + * {@link #TYPE_CURSOR_RECT} and this flag off. + */ + public static final int FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES = 0x02; + /** + * {@link InputMethodManager#updateCursor(android.view.View, int, int, int, int)} should be + * called back in screen coordinates after coordinate conversion with {@link View#getMatrix()}. + * To disable coordinate conversion with {@link View#getMatrix()} again, call + * {@link InputConnection#requestCursorAnchorInfo(CursorAnchorInfoRequest)} with + * {@link #TYPE_CURSOR_RECT} and this flag off. + * + * <p> + * The flag is ignored if {@link #FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES} is off. + * </p> + */ + public static final int FLAG_CURSOR_RECT_WITH_VIEW_MATRIX = 0x04; + + /** + * Constructs the object with request type and type-specific flags. + * + * @param requestType the type of this request. Currently {@link #TYPE_CURSOR_ANCHOR_INFO} or + * {@link #TYPE_CURSOR_RECT} is supported. + * @param requestFlags the flags for the given request type. + */ + public CursorAnchorInfoRequest(int requestType, int requestFlags) { + mRequestType = requestType; + mRequestFlags = requestFlags; + } + + /** + * Used to make this class parcelable. + * + * @param source the parcel from which the object is unmarshalled. + */ + public CursorAnchorInfoRequest(Parcel source) { + mRequestType = source.readInt(); + mRequestFlags = source.readInt(); + } + + /** + * @return the type of this request. + */ + public int getRequestType() { + return mRequestType; + } + + /** + * @return the flags that are specific to the type of this request. + */ + public int getRequestFlags() { + return mRequestFlags; + } + + /** + * Used to package this object into a {@link Parcel}. + * + * @param dest The {@link Parcel} to be written. + * @param flags The flags used for parceling. + */ + @Override + public void writeToParcel(Parcel dest, int flags) { + dest.writeInt(mRequestType); + dest.writeInt(mRequestFlags); + } + + @Override + public int hashCode(){ + return mRequestType * 31 + mRequestFlags; + } + + @Override + public boolean equals(Object obj){ + if (obj == null) { + return false; + } + if (this == obj) { + return true; + } + if (!(obj instanceof CursorAnchorInfoRequest)) { + return false; + } + final CursorAnchorInfoRequest that = (CursorAnchorInfoRequest) obj; + if (hashCode() != that.hashCode()) { + return false; + } + return mRequestType != that.mRequestType && mRequestFlags == that.mRequestFlags; + } + + @Override + public String toString() { + return "CursorAnchorInfoRequest{mRequestType=" + mRequestType + + " mRequestFlags=" + mRequestFlags + + "}"; + } + + /** + * Used to make this class parcelable. + */ + public static final Parcelable.Creator<CursorAnchorInfoRequest> CREATOR = + new Parcelable.Creator<CursorAnchorInfoRequest>() { + @Override + public CursorAnchorInfoRequest createFromParcel(Parcel source) { + return new CursorAnchorInfoRequest(source); + } + + @Override + public CursorAnchorInfoRequest[] newArray(int size) { + return new CursorAnchorInfoRequest[size]; + } + }; + + @Override + public int describeContents() { + return 0; + } +} diff --git a/core/java/android/view/inputmethod/InputConnection.java b/core/java/android/view/inputmethod/InputConnection.java index 3537aec..dff91dc 100644 --- a/core/java/android/view/inputmethod/InputConnection.java +++ b/core/java/android/view/inputmethod/InputConnection.java @@ -723,4 +723,15 @@ public interface InputConnection { * valid. */ public boolean performPrivateCommand(String action, Bundle data); + + /** + * Called by the IME to ask the editor for calling back + * {@link InputMethodManager#updateCursorAnchorInfo(android.view.View, CursorAnchorInfo)} to + * notify cursor/anchor locations. + * + * @param request the details of the request. + * @return a result code that depends on {@link CursorAnchorInfoRequest#getRequestType()}. See + * {@link CursorAnchorInfoRequest} for details. + */ + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request); } diff --git a/core/java/android/view/inputmethod/InputConnectionWrapper.java b/core/java/android/view/inputmethod/InputConnectionWrapper.java index a48473e..c831d7c 100644 --- a/core/java/android/view/inputmethod/InputConnectionWrapper.java +++ b/core/java/android/view/inputmethod/InputConnectionWrapper.java @@ -125,4 +125,8 @@ public class InputConnectionWrapper implements InputConnection { public boolean performPrivateCommand(String action, Bundle data) { return mTarget.performPrivateCommand(action, data); } -} + + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request) { + return mTarget.requestCursorAnchorInfo(request); + } + } diff --git a/core/java/android/view/inputmethod/InputMethodManager.java b/core/java/android/view/inputmethod/InputMethodManager.java index ace8808..623b5f9 100644 --- a/core/java/android/view/inputmethod/InputMethodManager.java +++ b/core/java/android/view/inputmethod/InputMethodManager.java @@ -25,8 +25,9 @@ import com.android.internal.view.IInputMethodSession; import com.android.internal.view.InputBindResult; import android.content.Context; +import android.graphics.Matrix; import android.graphics.Rect; -import android.inputmethodservice.InputMethodService; +import android.graphics.RectF; import android.os.Bundle; import android.os.Handler; import android.os.IBinder; @@ -312,8 +313,9 @@ public final class InputMethodManager { CompletionInfo[] mCompletions; // Cursor position on the screen. - Rect mTmpCursorRect = new Rect(); + Rect mNextCursorRect = new Rect(); Rect mCursorRect = new Rect(); + RectF mTempRectF = new RectF(); int mCursorSelStart; int mCursorSelEnd; int mCursorCandStart; @@ -348,8 +350,13 @@ public final class InputMethodManager { */ private final int[] mViewTopLeft = new int[2]; + /** + * The matrix to convert the view location into screen coordinates in {@link #updateCursor}. + */ + private final Matrix mViewToScreenMatrix = new Matrix(); + // ----------------------------------------------------------- - + /** * Sequence number of this binding, as returned by the server. */ @@ -365,10 +372,28 @@ public final class InputMethodManager { InputChannel mCurChannel; ImeInputEventSender mCurSender; + private static final int CURSOR_RECT_MONITOR_MODE_NONE = 0x0; + + private static final int CURSOR_RECT_MONITOR_FLAG_MASK = + CursorAnchorInfoRequest.FLAG_CURSOR_RECT_MONITOR | + CursorAnchorInfoRequest.FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES | + CursorAnchorInfoRequest.FLAG_CURSOR_RECT_WITH_VIEW_MATRIX; + + private static final int CURSOR_ANCHOR_INFO_MONITOR_MODE_NONE = 0x0; + + private static final int CURSOR_ANCHOR_INFO_MONITOR_FLAG_MASK = + CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_MONITOR | + CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE; + + /** + * The monitor mode for {@link #updateCursor(View, int, int, int, int)}. + */ + private int mCursorRectMonitorMode = CURSOR_RECT_MONITOR_MODE_NONE; + /** - * The current cursor/anchor monitor mode. + * The monitor mode for {@link #updateCursorAnchorInfo(View, CursorAnchorInfo)}. */ - int mCursorAnchorMonitorMode = InputMethodService.CURSOR_ANCHOR_MONITOR_MODE_NONE; + private int mCursorAnchorInfoMonitorMode = CURSOR_ANCHOR_INFO_MONITOR_MODE_NONE; final Pool<PendingEvent> mPendingEventPool = new SimplePool<PendingEvent>(20); final SparseArray<PendingEvent> mPendingEvents = new SparseArray<PendingEvent>(20); @@ -382,7 +407,6 @@ public final class InputMethodManager { static final int MSG_SEND_INPUT_EVENT = 5; static final int MSG_TIMEOUT_INPUT_EVENT = 6; static final int MSG_FLUSH_INPUT_EVENT = 7; - static final int MSG_SET_CURSOR_ANCHOR_MONITOR_MODE = 8; static final int MSG_SET_USER_ACTION_NOTIFICATION_SEQUENCE_NUMBER = 9; class H extends Handler { @@ -422,6 +446,9 @@ public final class InputMethodManager { return; } + mCursorAnchorInfoMonitorMode = CURSOR_ANCHOR_INFO_MONITOR_MODE_NONE; + mCursorRectMonitorMode = CURSOR_RECT_MONITOR_MODE_NONE; + setInputChannelLocked(res.channel); mCurMethod = res.method; mCurId = res.id; @@ -514,15 +541,6 @@ public final class InputMethodManager { finishedInputEvent(msg.arg1, false, false); return; } - case MSG_SET_CURSOR_ANCHOR_MONITOR_MODE: { - synchronized (mH) { - mCursorAnchorMonitorMode = msg.arg1; - // Clear the cache. - mCursorRect.setEmpty(); - mCursorAnchorInfo = null; - } - return; - } case MSG_SET_USER_ACTION_NOTIFICATION_SEQUENCE_NUMBER: { synchronized (mH) { mNextUserActionNotificationSequenceNumber = msg.arg1; @@ -594,11 +612,6 @@ public final class InputMethodManager { } @Override - public void setCursorAnchorMonitorMode(int monitorMode) { - mH.sendMessage(mH.obtainMessage(MSG_SET_CURSOR_ANCHOR_MONITOR_MODE, monitorMode, 0)); - } - - @Override public void setUserActionNotificationSequenceNumber(int sequenceNumber) { mH.sendMessage(mH.obtainMessage(MSG_SET_USER_ACTION_NOTIFICATION_SEQUENCE_NUMBER, sequenceNumber, 0)); @@ -1535,37 +1548,45 @@ public final class InputMethodManager { return false; } synchronized (mH) { - return (mCursorAnchorMonitorMode & - InputMethodService.CURSOR_ANCHOR_MONITOR_MODE_CURSOR_RECT) != 0; + return (mCursorRectMonitorMode & CursorAnchorInfoRequest.FLAG_CURSOR_RECT_MONITOR) != 0; } } /** - * Returns true if the current input method wants to receive the cursor rectangle in - * screen coordinates rather than local coordinates in the attached view. + * Updates the result of {@link #isWatchingCursor(View)}. * * @hide */ - public boolean usesScreenCoordinatesForCursorLocked() { - // {@link InputMethodService#CURSOR_ANCHOR_MONITOR_MODE_CURSOR_RECT} also means - // that {@link InputMethodService#onUpdateCursor} should provide the cursor rectangle - // in screen coordinates rather than local coordinates. - return (mCursorAnchorMonitorMode & - InputMethodService.CURSOR_ANCHOR_MONITOR_MODE_CURSOR_RECT) != 0; + public void setCursorRectMonitorMode(int flags) { + synchronized (mH) { + mCursorRectMonitorMode = (CURSOR_RECT_MONITOR_FLAG_MASK & flags); + } } /** - * Set cursor/anchor monitor mode via {@link com.android.server.InputMethodManagerService}. - * This is an internal method for {@link android.inputmethodservice.InputMethodService} and - * should never be used from IMEs and applications. + * Returns true if the current input method wants to be notified when cursor/anchor location + * is changed. * * @hide */ - public void setCursorAnchorMonitorMode(IBinder imeToken, int monitorMode) { - try { - mService.setCursorAnchorMonitorMode(imeToken, monitorMode); - } catch (RemoteException e) { - throw new RuntimeException(e); + public boolean isCursorAnchorInfoEnabled() { + synchronized (mH) { + final boolean isImmediate = (mCursorAnchorInfoMonitorMode & + CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE) != 0; + final boolean isMonitoring = (mCursorAnchorInfoMonitorMode & + CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_MONITOR) != 0; + return isImmediate || isMonitoring; + } + } + + /** + * Updates the result of {@link #isWatchingCursor(View)}. + * + * @hide + */ + public void setCursorAnchorInfoMonitorMode(int flags) { + synchronized (mH) { + mCursorAnchorInfoMonitorMode = (CURSOR_ANCHOR_INFO_MONITOR_FLAG_MASK & flags); } } @@ -1581,16 +1602,32 @@ public final class InputMethodManager { return; } if (DEBUG) Log.d(TAG, "updateCursor"); - mTmpCursorRect.set(left, top, right, bottom); - if (!Objects.equals(mCursorRect, mTmpCursorRect)) { + final boolean usesScreenCoordinates = (mCursorRectMonitorMode & + CursorAnchorInfoRequest.FLAG_CURSOR_RECT_IN_SCREEN_COORDINATES) != 0; + if (usesScreenCoordinates) { + view.getLocationOnScreen(mViewTopLeft); + final Matrix viewMatrix = view.getMatrix(); + final boolean usesViewMatrix = (viewMatrix != null) && ((mCursorRectMonitorMode & + CursorAnchorInfoRequest.FLAG_CURSOR_RECT_WITH_VIEW_MATRIX) != 0); + if (usesViewMatrix) { + mTempRectF.set(left, top, right, bottom); + mViewToScreenMatrix.set(viewMatrix); + mViewToScreenMatrix.postTranslate(mViewTopLeft[0], mViewTopLeft[1]); + mViewToScreenMatrix.mapRect(mTempRectF); + mNextCursorRect.set((int)mTempRectF.left, (int)mTempRectF.top, + (int)mTempRectF.right, (int)mTempRectF.bottom); + } else { + mNextCursorRect.set(left + mViewTopLeft[0], top + mViewTopLeft[1], + right + mViewTopLeft[0], bottom + mViewTopLeft[1]); + } + } else { + mNextCursorRect.set(left, top, right, bottom); + } + if (!Objects.equals(mCursorRect, mNextCursorRect)) { + if (DEBUG) Log.v(TAG, "CURSOR CHANGE: " + mNextCursorRect); try { - if (DEBUG) Log.v(TAG, "CURSOR CHANGE: " + mCurMethod); - mCursorRect.set(mTmpCursorRect); - if (usesScreenCoordinatesForCursorLocked()) { - view.getLocationOnScreen(mViewTopLeft); - mTmpCursorRect.offset(mViewTopLeft[0], mViewTopLeft[1]); - } - mCurMethod.updateCursor(mTmpCursorRect); + mCurMethod.updateCursor(mNextCursorRect); + mCursorRect.set(mNextCursorRect); } catch (RemoteException e) { Log.w(TAG, "IME died: " + mCurId, e); } @@ -1613,7 +1650,11 @@ public final class InputMethodManager { || mCurrentTextBoxAttribute == null || mCurMethod == null) { return; } - if (Objects.equals(mCursorAnchorInfo, cursorAnchorInfo)) { + // If immediate bit is set, we will call updateCursorAnchorInfo() even when the data has + // not been changed from the previous call. + final boolean isImmediate = (mCursorAnchorInfoMonitorMode & + CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE) != 0; + if (!isImmediate && Objects.equals(mCursorAnchorInfo, cursorAnchorInfo)) { Log.w(TAG, "Ignoring redundant updateCursorAnchorInfo: info=" + cursorAnchorInfo); return; } @@ -1621,6 +1662,9 @@ public final class InputMethodManager { try { mCurMethod.updateCursorAnchorInfo(cursorAnchorInfo); mCursorAnchorInfo = cursorAnchorInfo; + // Clear immediate bit (if any). + mCursorAnchorInfoMonitorMode &= + ~CursorAnchorInfoRequest.FLAG_CURSOR_ANCHOR_INFO_IMMEDIATE; } catch (RemoteException e) { Log.w(TAG, "IME died: " + mCurId, e); } diff --git a/core/java/android/widget/AbsListView.java b/core/java/android/widget/AbsListView.java index 3a1f6ed..9701c6f 100644 --- a/core/java/android/widget/AbsListView.java +++ b/core/java/android/widget/AbsListView.java @@ -68,6 +68,7 @@ import android.view.animation.LinearInterpolator; import android.view.inputmethod.BaseInputConnection; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CorrectionInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.EditorInfo; import android.view.inputmethod.ExtractedText; import android.view.inputmethod.ExtractedTextRequest; @@ -5696,6 +5697,11 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te public boolean performPrivateCommand(String action, Bundle data) { return getTarget().performPrivateCommand(action, data); } + + @Override + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request) { + return getTarget().requestCursorAnchorInfo(request); + } } /** diff --git a/core/java/android/widget/ActionMenuView.java b/core/java/android/widget/ActionMenuView.java index acee592..96abf51 100644 --- a/core/java/android/widget/ActionMenuView.java +++ b/core/java/android/widget/ActionMenuView.java @@ -18,6 +18,7 @@ package android.widget; import android.content.Context; import android.content.res.Configuration; import android.util.AttributeSet; +import android.view.ContextThemeWrapper; import android.view.Gravity; import android.view.Menu; import android.view.MenuItem; @@ -28,7 +29,6 @@ import android.view.accessibility.AccessibilityEvent; import com.android.internal.view.menu.ActionMenuItemView; import com.android.internal.view.menu.MenuBuilder; import com.android.internal.view.menu.MenuItemImpl; -import com.android.internal.view.menu.MenuPresenter; import com.android.internal.view.menu.MenuView; /** @@ -45,6 +45,12 @@ public class ActionMenuView extends LinearLayout implements MenuBuilder.ItemInvo private MenuBuilder mMenu; + /** Context against which to inflate popup menus. */ + private Context mPopupContext; + + /** Theme resource against which to inflate popup menus. */ + private int mPopupTheme; + private boolean mReserveOverflow; private ActionMenuPresenter mPresenter; private boolean mFormatItems; @@ -64,9 +70,41 @@ public class ActionMenuView extends LinearLayout implements MenuBuilder.ItemInvo final float density = context.getResources().getDisplayMetrics().density; mMinCellSize = (int) (MIN_CELL_SIZE * density); mGeneratedItemPadding = (int) (GENERATED_ITEM_PADDING * density); + mPopupContext = context; + mPopupTheme = 0; } - /** @hide */ + /** + * Specifies the theme to use when inflating popup menus. By default, uses + * the same theme as the action menu view itself. + * + * @param resId theme used to inflate popup menus + * @see #getPopupTheme() + */ + public void setPopupTheme(int resId) { + if (mPopupTheme != resId) { + mPopupTheme = resId; + if (resId == 0) { + mPopupContext = mContext; + } else { + mPopupContext = new ContextThemeWrapper(mContext, resId); + } + } + } + + /** + * @return resource identifier of the theme used to inflate popup menus, or + * 0 if menus are inflated against the action menu view theme + * @see #setPopupTheme(int) + */ + public int getPopupTheme() { + return mPopupTheme; + } + + /** + * @param presenter Menu presenter used to display popup menu + * @hide + */ public void setPresenter(ActionMenuPresenter presenter) { mPresenter = presenter; mPresenter.setMenuView(this); @@ -571,7 +609,7 @@ public class ActionMenuView extends LinearLayout implements MenuBuilder.ItemInvo mMenu.setCallback(new MenuBuilderCallback()); mPresenter = new ActionMenuPresenter(context); mPresenter.setCallback(new ActionMenuPresenterCallback()); - mMenu.addMenuPresenter(mPresenter); + mMenu.addMenuPresenter(mPresenter, mPopupContext); mPresenter.setMenuView(this); } diff --git a/core/java/android/widget/Editor.java b/core/java/android/widget/Editor.java index 170a316..66c4b81 100644 --- a/core/java/android/widget/Editor.java +++ b/core/java/android/widget/Editor.java @@ -3027,8 +3027,11 @@ public class Editor { if (null == imm) { return; } + if (!imm.isActive(mTextView)) { + return; + } // Skip if the IME has not requested the cursor/anchor position. - if (!imm.isWatchingCursor(mTextView)) { + if (!imm.isCursorAnchorInfoEnabled()) { return; } Layout layout = mTextView.getLayout(); diff --git a/core/java/android/widget/PopupWindow.java b/core/java/android/widget/PopupWindow.java index 01632ae..a35d447 100644 --- a/core/java/android/widget/PopupWindow.java +++ b/core/java/android/widget/PopupWindow.java @@ -22,6 +22,7 @@ import android.animation.ValueAnimator; import android.content.Context; import android.content.res.Resources; import android.content.res.TypedArray; +import android.graphics.Insets; import android.graphics.PixelFormat; import android.graphics.Rect; import android.graphics.drawable.Drawable; @@ -109,6 +110,8 @@ public class PopupWindow { private int mPopupWidth; private int mPopupHeight; + private float mElevation; + private int[] mDrawingLocation = new int[2]; private int[] mScreenLocation = new int[2]; private Rect mTempRect = new Rect(); @@ -196,6 +199,7 @@ public class PopupWindow { attrs, com.android.internal.R.styleable.PopupWindow, defStyleAttr, defStyleRes); mBackground = a.getDrawable(R.styleable.PopupWindow_popupBackground); + mElevation = a.getDimension(R.styleable.PopupWindow_popupElevation, 0); mOverlapAnchor = a.getBoolean(R.styleable.PopupWindow_overlapAnchor, false); final int animStyle = a.getResourceId(R.styleable.PopupWindow_popupAnimationStyle, -1); @@ -319,25 +323,49 @@ public class PopupWindow { } /** - * <p>Return the drawable used as the popup window's background.</p> + * Return the drawable used as the popup window's background. * - * @return the background drawable or null + * @return the background drawable or {@code null} if not set + * @see #setBackgroundDrawable(Drawable) + * @attr ref android.R.styleable#PopupWindow_popupBackground */ public Drawable getBackground() { return mBackground; } /** - * <p>Change the background drawable for this popup window. The background - * can be set to null.</p> + * Specifies the background drawable for this popup window. The background + * can be set to {@code null}. * * @param background the popup's background + * @see #getBackground() + * @attr ref android.R.styleable#PopupWindow_popupBackground */ public void setBackgroundDrawable(Drawable background) { mBackground = background; } /** + * @return the elevation for this popup window in pixels + * @see #setElevation(float) + * @attr ref android.R.styleable#PopupWindow_popupElevation + */ + public float getElevation() { + return mElevation; + } + + /** + * Specifies the elevation for this popup window. + * + * @param elevation the popup's elevation in pixels + * @see #getElevation() + * @attr ref android.R.styleable#PopupWindow_popupElevation + */ + public void setElevation(float elevation) { + mElevation = elevation; + } + + /** * <p>Return the animation style to use the popup appears and disappears</p> * * @return the animation style to use the popup appears and disappears @@ -973,7 +1001,7 @@ public class PopupWindow { /** * <p>Prepare the popup by embedding in into a new ViewGroup if the * background drawable is not null. If embedding is required, the layout - * parameters' height is mnodified to take into account the background's + * parameters' height is modified to take into account the background's * padding.</p> * * @param p the layout parameters of the popup's content view @@ -998,13 +1026,15 @@ public class PopupWindow { PopupViewContainer.LayoutParams listParams = new PopupViewContainer.LayoutParams( ViewGroup.LayoutParams.MATCH_PARENT, height ); - popupViewContainer.setBackgroundDrawable(mBackground); + popupViewContainer.setBackground(mBackground); popupViewContainer.addView(mContentView, listParams); mPopupView = popupViewContainer; } else { mPopupView = mContentView; } + + mPopupView.setElevation(mElevation); mPopupViewInitialLayoutDirectionInherited = (mPopupView.getRawLayoutDirection() == View.LAYOUT_DIRECTION_INHERIT); mPopupWidth = p.width; @@ -1066,6 +1096,10 @@ public class PopupWindow { p.softInputMode = mSoftInputMode; p.setTitle("PopupWindow:" + Integer.toHexString(hashCode())); + // TODO: Use real shadow insets once that algorithm is finalized. + final int shadowInset = (int) Math.ceil(mElevation * 2); + p.shadowInsets.set(shadowInset, shadowInset, shadowInset, shadowInset); + return p; } diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java index dd58ba6..fac0eb2 100644 --- a/core/java/android/widget/TextView.java +++ b/core/java/android/widget/TextView.java @@ -279,6 +279,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener private ColorStateList mTextColor; private ColorStateList mHintTextColor; private ColorStateList mLinkTextColor; + @ViewDebug.ExportedProperty(category = "text") private int mCurTextColor; private int mCurHintTextColor; private boolean mFreezesText; @@ -2519,6 +2520,26 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener } /** + * @return the size (in scaled pixels) of thee default text size in this TextView. + * @hide + */ + @ViewDebug.ExportedProperty(category = "text") + public float getScaledTextSize() { + return mTextPaint.getTextSize() / mTextPaint.density; + } + + /** @hide */ + @ViewDebug.ExportedProperty(category = "text", mapping = { + @ViewDebug.IntToString(from = Typeface.NORMAL, to = "NORMAL"), + @ViewDebug.IntToString(from = Typeface.BOLD, to = "BOLD"), + @ViewDebug.IntToString(from = Typeface.ITALIC, to = "ITALIC"), + @ViewDebug.IntToString(from = Typeface.BOLD_ITALIC, to = "BOLD_ITALIC") + }) + public int getTypefaceStyle() { + return mTextPaint.getTypeface().getStyle(); + } + + /** * Set the default text size to the given value, interpreted as "scaled * pixel" units. This size is adjusted based on the current density and * user font size preference. diff --git a/core/java/android/widget/Toolbar.java b/core/java/android/widget/Toolbar.java index 24950f6..712e6d0 100644 --- a/core/java/android/widget/Toolbar.java +++ b/core/java/android/widget/Toolbar.java @@ -14,7 +14,6 @@ * limitations under the License. */ - package android.widget; import android.annotation.NonNull; @@ -27,16 +26,15 @@ import android.os.Parcelable; import android.text.Layout; import android.text.TextUtils; import android.util.AttributeSet; -import android.util.Log; import android.view.CollapsibleActionView; +import android.view.ContextThemeWrapper; import android.view.Gravity; import android.view.Menu; import android.view.MenuInflater; import android.view.MenuItem; import android.view.View; -import android.view.ViewDebug; import android.view.ViewGroup; -import android.view.Window; + import com.android.internal.R; import com.android.internal.view.menu.MenuBuilder; import com.android.internal.view.menu.MenuItemImpl; @@ -104,6 +102,12 @@ public class Toolbar extends ViewGroup { private ImageButton mCollapseButtonView; View mExpandedActionView; + /** Context against which to inflate popup menus. */ + private Context mPopupContext; + + /** Theme resource against which to inflate popup menus. */ + private int mPopupTheme; + private int mTitleTextAppearance; private int mSubtitleTextAppearance; private int mNavButtonStyle; @@ -230,6 +234,36 @@ public class Toolbar extends ViewGroup { setSubtitle(subtitle); } a.recycle(); + + mPopupContext = context; + mPopupTheme = 0; + } + + /** + * Specifies the theme to use when inflating popup menus. By default, uses + * the same theme as the toolbar itself. + * + * @param resId theme used to inflate popup menus + * @see #getPopupTheme() + */ + public void setPopupTheme(int resId) { + if (mPopupTheme != resId) { + mPopupTheme = resId; + if (resId == 0) { + mPopupContext = mContext; + } else { + mPopupContext = new ContextThemeWrapper(mContext, resId); + } + } + } + + /** + * @return resource identifier of the theme used to inflate popup menus, or + * 0 if menus are inflated against the toolbar theme + * @see #setPopupTheme(int) + */ + public int getPopupTheme() { + return mPopupTheme; } @Override @@ -306,22 +340,21 @@ public class Toolbar extends ViewGroup { oldMenu.removeMenuPresenter(mExpandedMenuPresenter); } - final Context context = getContext(); - if (mExpandedMenuPresenter == null) { mExpandedMenuPresenter = new ExpandedActionViewMenuPresenter(); } outerPresenter.setExpandedActionViewsExclusive(true); if (menu != null) { - menu.addMenuPresenter(outerPresenter); - menu.addMenuPresenter(mExpandedMenuPresenter); + menu.addMenuPresenter(outerPresenter, mPopupContext); + menu.addMenuPresenter(mExpandedMenuPresenter, mPopupContext); } else { - outerPresenter.initForMenu(context, null); - mExpandedMenuPresenter.initForMenu(context, null); + outerPresenter.initForMenu(mPopupContext, null); + mExpandedMenuPresenter.initForMenu(mPopupContext, null); outerPresenter.updateMenuView(true); mExpandedMenuPresenter.updateMenuView(true); } + mMenuView.setPopupTheme(mPopupTheme); mMenuView.setPresenter(outerPresenter); mOuterActionMenuPresenter = outerPresenter; } @@ -768,13 +801,14 @@ public class Toolbar extends ViewGroup { mExpandedMenuPresenter = new ExpandedActionViewMenuPresenter(); } mMenuView.setExpandedActionViewsExclusive(true); - menu.addMenuPresenter(mExpandedMenuPresenter); + menu.addMenuPresenter(mExpandedMenuPresenter, mPopupContext); } } private void ensureMenuView() { if (mMenuView == null) { mMenuView = new ActionMenuView(getContext()); + mMenuView.setPopupTheme(mPopupTheme); mMenuView.setOnMenuItemClickListener(mMenuViewItemClickListener); final LayoutParams lp = generateDefaultLayoutParams(); lp.gravity = Gravity.END | (mButtonGravity & Gravity.VERTICAL_GRAVITY_MASK); diff --git a/core/java/com/android/internal/app/IVoiceInteractionManagerService.aidl b/core/java/com/android/internal/app/IVoiceInteractionManagerService.aidl index 98e35dd..c78f770 100644 --- a/core/java/com/android/internal/app/IVoiceInteractionManagerService.aidl +++ b/core/java/com/android/internal/app/IVoiceInteractionManagerService.aidl @@ -20,6 +20,7 @@ import android.content.Intent; import android.os.Bundle; import com.android.internal.app.IVoiceInteractor; +import android.hardware.soundtrigger.KeyphraseSoundModel; import android.service.voice.IVoiceInteractionService; import android.service.voice.IVoiceInteractionSession; @@ -29,4 +30,16 @@ interface IVoiceInteractionManagerService { IVoiceInteractor interactor); int startVoiceActivity(IBinder token, in Intent intent, String resolvedType); void finish(IBinder token); + + /** + * Lists the registered Sound models for keyphrase detection. + * May be null if no matching sound models exist. + * + * @param service The current voice interaction service. + */ + List<KeyphraseSoundModel> listRegisteredKeyphraseSoundModels(in IVoiceInteractionService service); + /** + * Updates the given keyphrase sound model. Adds the model if it doesn't exist currently. + */ + int updateKeyphraseSoundModel(in KeyphraseSoundModel model); } diff --git a/core/java/com/android/internal/app/ToolbarActionBar.java b/core/java/com/android/internal/app/ToolbarActionBar.java index e8a3f0a..7af52f3 100644 --- a/core/java/com/android/internal/app/ToolbarActionBar.java +++ b/core/java/com/android/internal/app/ToolbarActionBar.java @@ -122,6 +122,16 @@ public class ToolbarActionBar extends ActionBar { } @Override + public void setElevation(float elevation) { + mToolbar.setElevation(elevation); + } + + @Override + public float getElevation() { + return mToolbar.getElevation(); + } + + @Override public Context getThemedContext() { return mToolbar.getContext(); } diff --git a/core/java/com/android/internal/app/WindowDecorActionBar.java b/core/java/com/android/internal/app/WindowDecorActionBar.java index 7bd316f..b5ff0cc 100644 --- a/core/java/com/android/internal/app/WindowDecorActionBar.java +++ b/core/java/com/android/internal/app/WindowDecorActionBar.java @@ -222,6 +222,10 @@ public class WindowDecorActionBar extends ActionBar implements if (a.getBoolean(R.styleable.ActionBar_hideOnContentScroll, false)) { setHideOnContentScrollEnabled(true); } + final int elevation = a.getDimensionPixelSize(R.styleable.ActionBar_elevation, 0); + if (elevation != 0) { + setElevation(elevation); + } a.recycle(); } @@ -236,6 +240,19 @@ public class WindowDecorActionBar extends ActionBar implements } } + @Override + public void setElevation(float elevation) { + mContainerView.setElevation(elevation); + if (mSplitView != null) { + mSplitView.setElevation(elevation); + } + } + + @Override + public float getElevation() { + return mContainerView.getElevation(); + } + public void onConfigurationChanged(Configuration newConfig) { setHasEmbeddedTabs(ActionBarPolicy.get(mContext).hasEmbeddedTabs()); } diff --git a/core/java/com/android/internal/os/BatteryStatsHelper.java b/core/java/com/android/internal/os/BatteryStatsHelper.java index 273de61..023ba03 100644 --- a/core/java/com/android/internal/os/BatteryStatsHelper.java +++ b/core/java/com/android/internal/os/BatteryStatsHelper.java @@ -48,6 +48,7 @@ import java.util.Collections; import java.util.Comparator; import java.util.List; import java.util.Map; +import java.util.Arrays; /** * A helper class for retrieving the power usage information for all applications and services. @@ -82,7 +83,6 @@ public class BatteryStatsHelper { private final List<BatterySipper> mMobilemsppList = new ArrayList<BatterySipper>(); private int mStatsType = BatteryStats.STATS_SINCE_CHARGED; - private int mAsUser = 0; long mRawRealtime; long mRawUptime; @@ -176,11 +176,34 @@ public class BatteryStatsHelper { * Refreshes the power usage list. */ public void refreshStats(int statsType, int asUser) { - refreshStats(statsType, asUser, SystemClock.elapsedRealtime() * 1000, + SparseArray<UserHandle> users = new SparseArray<UserHandle>(1); + users.put(asUser, new UserHandle(asUser)); + refreshStats(statsType, users); + } + + /** + * Refreshes the power usage list. + */ + public void refreshStats(int statsType, List<UserHandle> asUsers) { + final int n = asUsers.size(); + SparseArray<UserHandle> users = new SparseArray<UserHandle>(n); + for (int i = 0; i < n; ++i) { + UserHandle userHandle = asUsers.get(i); + users.put(userHandle.getIdentifier(), userHandle); + } + refreshStats(statsType, users); + } + + /** + * Refreshes the power usage list. + */ + public void refreshStats(int statsType, SparseArray<UserHandle> asUsers) { + refreshStats(statsType, asUsers, SystemClock.elapsedRealtime() * 1000, SystemClock.uptimeMillis() * 1000); } - public void refreshStats(int statsType, int asUser, long rawRealtimeUs, long rawUptimeUs) { + public void refreshStats(int statsType, SparseArray<UserHandle> asUsers, long rawRealtimeUs, + long rawUptimeUs) { // Initialize mStats if necessary. getStats(); @@ -204,7 +227,6 @@ public class BatteryStatsHelper { } mStatsType = statsType; - mAsUser = asUser; mRawUptime = rawUptimeUs; mRawRealtime = rawRealtimeUs; mBatteryUptime = mStats.getBatteryUptime(rawUptimeUs); @@ -227,7 +249,7 @@ public class BatteryStatsHelper { mMaxDrainedPower = (mStats.getHighDischargeAmountSinceCharge() * mPowerProfile.getBatteryCapacity()) / 100; - processAppUsage(); + processAppUsage(asUsers); // Before aggregating apps in to users, collect all apps to sort by their ms per packet. for (int i=0; i<mUsageList.size(); i++) { @@ -280,7 +302,8 @@ public class BatteryStatsHelper { Collections.sort(mUsageList); } - private void processAppUsage() { + private void processAppUsage(SparseArray<UserHandle> asUsers) { + final boolean forAllUsers = (asUsers.get(UserHandle.USER_ALL) != null); SensorManager sensorManager = (SensorManager) mContext.getSystemService( Context.SENSOR_SERVICE); final int which = mStatsType; @@ -499,7 +522,7 @@ public class BatteryStatsHelper { } else if (u.getUid() == Process.BLUETOOTH_UID) { mBluetoothSippers.add(app); mBluetoothPower += power; - } else if (mAsUser != UserHandle.USER_ALL && userId != mAsUser + } else if (!forAllUsers && asUsers.get(userId) == null && UserHandle.getAppId(u.getUid()) >= Process.FIRST_APPLICATION_UID) { List<BatterySipper> list = mUserSippers.get(userId); if (list == null) { diff --git a/core/java/com/android/internal/view/IInputConnectionWrapper.java b/core/java/com/android/internal/view/IInputConnectionWrapper.java index c792d78..897381d 100644 --- a/core/java/com/android/internal/view/IInputConnectionWrapper.java +++ b/core/java/com/android/internal/view/IInputConnectionWrapper.java @@ -25,6 +25,7 @@ import android.util.Log; import android.view.KeyEvent; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CorrectionInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.ExtractedTextRequest; import android.view.inputmethod.InputConnection; @@ -54,6 +55,7 @@ public class IInputConnectionWrapper extends IInputContext.Stub { private static final int DO_REPORT_FULLSCREEN_MODE = 100; private static final int DO_PERFORM_PRIVATE_COMMAND = 120; private static final int DO_CLEAR_META_KEY_STATES = 130; + private static final int DO_REQUEST_CURSOR_ANCHOR_INFO = 140; private WeakReference<InputConnection> mInputConnection; @@ -175,6 +177,11 @@ public class IInputConnectionWrapper extends IInputContext.Stub { dispatchMessage(obtainMessageOO(DO_PERFORM_PRIVATE_COMMAND, action, data)); } + public void requestCursorAnchorInfo(CursorAnchorInfoRequest request, int seq, + IInputContextCallback callback) { + dispatchMessage(obtainMessageOSC(DO_REQUEST_CURSOR_ANCHOR_INFO, request, seq, callback)); + } + void dispatchMessage(Message msg) { // If we are calling this from the main thread, then we can call // right through. Otherwise, we need to send the message to the @@ -420,6 +427,23 @@ public class IInputConnectionWrapper extends IInputContext.Stub { (Bundle)args.arg2); return; } + case DO_REQUEST_CURSOR_ANCHOR_INFO: { + SomeArgs args = (SomeArgs)msg.obj; + try { + InputConnection ic = mInputConnection.get(); + if (ic == null || !isActive()) { + Log.w(TAG, "requestCursorAnchorInfo on inactive InputConnection"); + args.callback.setRequestCursorAnchorInfoResult(0, args.seq); + return; + } + args.callback.setRequestCursorAnchorInfoResult( + ic.requestCursorAnchorInfo((CursorAnchorInfoRequest)args.arg1), + args.seq); + } catch (RemoteException e) { + Log.w(TAG, "Got RemoteException calling requestCursorAnchorInfo", e); + } + return; + } } Log.w(TAG, "Unhandled message code: " + msg.what); } @@ -449,7 +473,15 @@ public class IInputConnectionWrapper extends IInputContext.Stub { args.seq = seq; return mH.obtainMessage(what, arg1, arg2, args); } - + + Message obtainMessageOSC(int what, Object arg1, int seq, IInputContextCallback callback) { + SomeArgs args = new SomeArgs(); + args.arg1 = arg1; + args.callback = callback; + args.seq = seq; + return mH.obtainMessage(what, 0, 0, args); + } + Message obtainMessageIOSC(int what, int arg1, Object arg2, int seq, IInputContextCallback callback) { SomeArgs args = new SomeArgs(); diff --git a/core/java/com/android/internal/view/IInputContext.aidl b/core/java/com/android/internal/view/IInputContext.aidl index 719a24f..c06596a 100644 --- a/core/java/com/android/internal/view/IInputContext.aidl +++ b/core/java/com/android/internal/view/IInputContext.aidl @@ -20,6 +20,7 @@ import android.os.Bundle; import android.view.KeyEvent; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CorrectionInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.ExtractedTextRequest; import com.android.internal.view.IInputContextCallback; @@ -73,4 +74,6 @@ import com.android.internal.view.IInputContextCallback; void getSelectedText(int flags, int seq, IInputContextCallback callback); + void requestCursorAnchorInfo(in CursorAnchorInfoRequest request, int seq, + IInputContextCallback callback); } diff --git a/core/java/com/android/internal/view/IInputContextCallback.aidl b/core/java/com/android/internal/view/IInputContextCallback.aidl index 661066b..ab2fbdc 100644 --- a/core/java/com/android/internal/view/IInputContextCallback.aidl +++ b/core/java/com/android/internal/view/IInputContextCallback.aidl @@ -27,4 +27,5 @@ oneway interface IInputContextCallback { void setCursorCapsMode(int capsMode, int seq); void setExtractedText(in ExtractedText extractedText, int seq); void setSelectedText(CharSequence selectedText, int seq); + void setRequestCursorAnchorInfoResult(int result, int seq); } diff --git a/core/java/com/android/internal/view/IInputMethodClient.aidl b/core/java/com/android/internal/view/IInputMethodClient.aidl index b100d27..89d36ff 100644 --- a/core/java/com/android/internal/view/IInputMethodClient.aidl +++ b/core/java/com/android/internal/view/IInputMethodClient.aidl @@ -27,6 +27,5 @@ oneway interface IInputMethodClient { void onBindMethod(in InputBindResult res); void onUnbindMethod(int sequence); void setActive(boolean active); - void setCursorAnchorMonitorMode(int monitorMode); void setUserActionNotificationSequenceNumber(int sequenceNumber); } diff --git a/core/java/com/android/internal/view/IInputMethodManager.aidl b/core/java/com/android/internal/view/IInputMethodManager.aidl index b84c359..6f104dd 100644 --- a/core/java/com/android/internal/view/IInputMethodManager.aidl +++ b/core/java/com/android/internal/view/IInputMethodManager.aidl @@ -78,5 +78,4 @@ interface IInputMethodManager { void setAdditionalInputMethodSubtypes(String id, in InputMethodSubtype[] subtypes); int getInputMethodWindowVisibleHeight(); oneway void notifyUserAction(int sequenceNumber); - void setCursorAnchorMonitorMode(in IBinder token, int monitorMode); } diff --git a/core/java/com/android/internal/view/InputConnectionWrapper.java b/core/java/com/android/internal/view/InputConnectionWrapper.java index 9024d8d..8535a98 100644 --- a/core/java/com/android/internal/view/InputConnectionWrapper.java +++ b/core/java/com/android/internal/view/InputConnectionWrapper.java @@ -23,6 +23,7 @@ import android.util.Log; import android.view.KeyEvent; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CorrectionInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.ExtractedText; import android.view.inputmethod.ExtractedTextRequest; import android.view.inputmethod.InputConnection; @@ -40,6 +41,7 @@ public class InputConnectionWrapper implements InputConnection { public CharSequence mSelectedText; public ExtractedText mExtractedText; public int mCursorCapsMode; + public int mCursorAnchorInfoRequestResult; // A 'pool' of one InputContextCallback. Each ICW request will attempt to gain // exclusive access to this object. @@ -152,7 +154,20 @@ public class InputConnectionWrapper implements InputConnection { } } } - + + public void setRequestCursorAnchorInfoResult(int result, int seq) { + synchronized (this) { + if (seq == mSeq) { + mCursorAnchorInfoRequestResult = result; + mHaveValue = true; + notifyAll(); + } else { + Log.i(TAG, "Got out-of-sequence callback " + seq + " (expected " + mSeq + + ") in setCursorAnchorInfoRequestResult, ignoring."); + } + } + } + /** * Waits for a result for up to {@link #MAX_WAIT_TIME_MILLIS} milliseconds. * @@ -413,4 +428,22 @@ public class InputConnectionWrapper implements InputConnection { return false; } } + + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request) { + int value = CursorAnchorInfoRequest.RESULT_NOT_HANDLED; + try { + InputContextCallback callback = InputContextCallback.getInstance(); + mIInputContext.requestCursorAnchorInfo(request, callback.mSeq, callback); + synchronized (callback) { + callback.waitForResultLocked(); + if (callback.mHaveValue) { + value = callback.mCursorAnchorInfoRequestResult; + } + } + callback.dispose(); + } catch (RemoteException e) { + return CursorAnchorInfoRequest.RESULT_NOT_HANDLED; + } + return value; + } } diff --git a/core/java/com/android/internal/view/menu/MenuBuilder.java b/core/java/com/android/internal/view/menu/MenuBuilder.java index 5d7d322..e8d1ead 100644 --- a/core/java/com/android/internal/view/menu/MenuBuilder.java +++ b/core/java/com/android/internal/view/menu/MenuBuilder.java @@ -212,8 +212,21 @@ public class MenuBuilder implements Menu { * @param presenter The presenter to add */ public void addMenuPresenter(MenuPresenter presenter) { + addMenuPresenter(presenter, mContext); + } + + /** + * Add a presenter to this menu that uses an alternate context for + * inflating menu items. This will only hold a WeakReference; you do not + * need to explicitly remove a presenter, but you can using + * {@link #removeMenuPresenter(MenuPresenter)}. + * + * @param presenter The presenter to add + * @param menuContext The context used to inflate menu items + */ + public void addMenuPresenter(MenuPresenter presenter, Context menuContext) { mPresenters.add(new WeakReference<MenuPresenter>(presenter)); - presenter.initForMenu(mContext, this); + presenter.initForMenu(menuContext, this); mIsActionItemsStale = true; } diff --git a/core/java/com/android/internal/view/menu/MenuPopupHelper.java b/core/java/com/android/internal/view/menu/MenuPopupHelper.java index 5a12893..40f58e9 100644 --- a/core/java/com/android/internal/view/menu/MenuPopupHelper.java +++ b/core/java/com/android/internal/view/menu/MenuPopupHelper.java @@ -95,7 +95,8 @@ public class MenuPopupHelper implements AdapterView.OnItemClickListener, View.On mAnchorView = anchorView; - menu.addMenuPresenter(this); + // Present the menu using our context, not the menu builder's context. + menu.addMenuPresenter(this, context); } public void setAnchorView(View anchor) { diff --git a/core/java/com/android/internal/view/menu/MenuPresenter.java b/core/java/com/android/internal/view/menu/MenuPresenter.java index d913a39..f207b98 100644 --- a/core/java/com/android/internal/view/menu/MenuPresenter.java +++ b/core/java/com/android/internal/view/menu/MenuPresenter.java @@ -18,7 +18,6 @@ package com.android.internal.view.menu; import android.content.Context; import android.os.Parcelable; -import android.view.Menu; import android.view.ViewGroup; /** @@ -61,7 +60,7 @@ public interface MenuPresenter { /** * Retrieve a MenuView to display the menu specified in - * {@link #initForMenu(Context, Menu)}. + * {@link #initForMenu(Context, MenuBuilder)}. * * @param root Intended parent of the MenuView. * @return A freshly created MenuView. diff --git a/core/java/com/android/internal/widget/AbsActionBarView.java b/core/java/com/android/internal/widget/AbsActionBarView.java index 9e7ff93..850ea23 100644 --- a/core/java/com/android/internal/widget/AbsActionBarView.java +++ b/core/java/com/android/internal/widget/AbsActionBarView.java @@ -16,6 +16,9 @@ package com.android.internal.widget; import com.android.internal.R; + +import android.util.TypedValue; +import android.view.ContextThemeWrapper; import android.widget.ActionMenuPresenter; import android.widget.ActionMenuView; @@ -32,6 +35,15 @@ import android.view.ViewGroup; import android.view.animation.DecelerateInterpolator; public abstract class AbsActionBarView extends ViewGroup { + private static final TimeInterpolator sAlphaInterpolator = new DecelerateInterpolator(); + + private static final int FADE_DURATION = 200; + + protected final VisibilityAnimListener mVisAnimListener = new VisibilityAnimListener(); + + /** Context against which to inflate popup menus. */ + protected final Context mPopupContext; + protected ActionMenuView mMenuView; protected ActionMenuPresenter mActionMenuPresenter; protected ViewGroup mSplitView; @@ -40,11 +52,6 @@ public abstract class AbsActionBarView extends ViewGroup { protected int mContentHeight; protected Animator mVisibilityAnim; - protected final VisibilityAnimListener mVisAnimListener = new VisibilityAnimListener(); - - private static final TimeInterpolator sAlphaInterpolator = new DecelerateInterpolator(); - - private static final int FADE_DURATION = 200; public AbsActionBarView(Context context) { this(context, null); @@ -61,6 +68,14 @@ public abstract class AbsActionBarView extends ViewGroup { public AbsActionBarView( Context context, AttributeSet attrs, int defStyleAttr, int defStyleRes) { super(context, attrs, defStyleAttr, defStyleRes); + + final TypedValue tv = new TypedValue(); + if (context.getTheme().resolveAttribute(R.attr.actionBarPopupTheme, tv, true) + && tv.resourceId != 0) { + mPopupContext = new ContextThemeWrapper(context, tv.resourceId); + } else { + mPopupContext = context; + } } @Override diff --git a/core/java/com/android/internal/widget/ActionBarContextView.java b/core/java/com/android/internal/widget/ActionBarContextView.java index 6ff77a0..c7ac815 100644 --- a/core/java/com/android/internal/widget/ActionBarContextView.java +++ b/core/java/com/android/internal/widget/ActionBarContextView.java @@ -16,6 +16,9 @@ package com.android.internal.widget; import com.android.internal.R; + +import android.util.TypedValue; +import android.view.ContextThemeWrapper; import android.widget.ActionMenuPresenter; import android.widget.ActionMenuView; import com.android.internal.view.menu.MenuBuilder; @@ -231,7 +234,7 @@ public class ActionBarContextView extends AbsActionBarView implements AnimatorLi final LayoutParams layoutParams = new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.MATCH_PARENT); if (!mSplitActionBar) { - menu.addMenuPresenter(mActionMenuPresenter); + menu.addMenuPresenter(mActionMenuPresenter, mPopupContext); mMenuView = (ActionMenuView) mActionMenuPresenter.getMenuView(this); mMenuView.setBackgroundDrawable(null); addView(mMenuView, layoutParams); @@ -244,7 +247,7 @@ public class ActionBarContextView extends AbsActionBarView implements AnimatorLi // Span the whole width layoutParams.width = LayoutParams.MATCH_PARENT; layoutParams.height = mContentHeight; - menu.addMenuPresenter(mActionMenuPresenter); + menu.addMenuPresenter(mActionMenuPresenter, mPopupContext); mMenuView = (ActionMenuView) mActionMenuPresenter.getMenuView(this); mMenuView.setBackgroundDrawable(mSplitBackground); mSplitView.addView(mMenuView, layoutParams); diff --git a/core/java/com/android/internal/widget/ActionBarView.java b/core/java/com/android/internal/widget/ActionBarView.java index 77559c0..e53af69 100644 --- a/core/java/com/android/internal/widget/ActionBarView.java +++ b/core/java/com/android/internal/widget/ActionBarView.java @@ -29,7 +29,9 @@ import android.os.Parcelable; import android.text.Layout; import android.text.TextUtils; import android.util.AttributeSet; +import android.util.TypedValue; import android.view.CollapsibleActionView; +import android.view.ContextThemeWrapper; import android.view.Gravity; import android.view.LayoutInflater; import android.view.Menu; @@ -435,11 +437,11 @@ public class ActionBarView extends AbsActionBarView implements DecorToolbar { private void configPresenters(MenuBuilder builder) { if (builder != null) { - builder.addMenuPresenter(mActionMenuPresenter); - builder.addMenuPresenter(mExpandedMenuPresenter); + builder.addMenuPresenter(mActionMenuPresenter, mPopupContext); + builder.addMenuPresenter(mExpandedMenuPresenter, mPopupContext); } else { - mActionMenuPresenter.initForMenu(mContext, null); - mExpandedMenuPresenter.initForMenu(mContext, null); + mActionMenuPresenter.initForMenu(mPopupContext, null); + mExpandedMenuPresenter.initForMenu(mPopupContext, null); mActionMenuPresenter.updateMenuView(true); mExpandedMenuPresenter.updateMenuView(true); } diff --git a/core/java/com/android/internal/widget/EditableInputConnection.java b/core/java/com/android/internal/widget/EditableInputConnection.java index 4cbdf78..10a7794 100644 --- a/core/java/com/android/internal/widget/EditableInputConnection.java +++ b/core/java/com/android/internal/widget/EditableInputConnection.java @@ -25,6 +25,7 @@ import android.util.Log; import android.view.inputmethod.BaseInputConnection; import android.view.inputmethod.CompletionInfo; import android.view.inputmethod.CorrectionInfo; +import android.view.inputmethod.CursorAnchorInfoRequest; import android.view.inputmethod.ExtractedText; import android.view.inputmethod.ExtractedTextRequest; import android.widget.TextView; @@ -185,4 +186,18 @@ public class EditableInputConnection extends BaseInputConnection { return success; } + + @Override + public int requestCursorAnchorInfo(CursorAnchorInfoRequest request) { + if (DEBUG) Log.v(TAG, "requestCursorAnchorInfo " + request); + final int result = super.requestCursorAnchorInfo(request); + if (mIMM != null && request != null && (request.getRequestType() == + CursorAnchorInfoRequest.TYPE_CURSOR_ANCHOR_INFO)) { + mIMM.setCursorAnchorInfoMonitorMode(request.getRequestFlags()); + // One-shot event is not yet fully supported. + // TODO: Support one-shot event correctly. + return CursorAnchorInfoRequest.RESULT_SCHEDULED; + } + return result; + } } diff --git a/core/jni/Android.mk b/core/jni/Android.mk index 869a91b..ef7ef0a 100644 --- a/core/jni/Android.mk +++ b/core/jni/Android.mk @@ -139,6 +139,7 @@ LOCAL_SRC_FILES:= \ android_hardware_Camera.cpp \ android_hardware_camera2_CameraMetadata.cpp \ android_hardware_camera2_legacy_LegacyCameraDevice.cpp \ + android_hardware_camera2_legacy_PerfMeasurement.cpp \ android_hardware_camera2_DngCreator.cpp \ android_hardware_SensorManager.cpp \ android_hardware_SerialPort.cpp \ @@ -242,7 +243,8 @@ LOCAL_SHARED_LIBRARIES := \ libnetd_client \ libsoundtrigger \ libminikin \ - libstlport + libstlport \ + libprocessgroup \ ifeq ($(USE_OPENGL_RENDERER),true) LOCAL_SHARED_LIBRARIES += libhwui diff --git a/core/jni/AndroidRuntime.cpp b/core/jni/AndroidRuntime.cpp index f7cd8c3..9b66734 100644 --- a/core/jni/AndroidRuntime.cpp +++ b/core/jni/AndroidRuntime.cpp @@ -79,6 +79,7 @@ extern int register_android_opengl_jni_GLES31Ext(JNIEnv* env); extern int register_android_hardware_Camera(JNIEnv *env); extern int register_android_hardware_camera2_CameraMetadata(JNIEnv *env); extern int register_android_hardware_camera2_legacy_LegacyCameraDevice(JNIEnv *env); +extern int register_android_hardware_camera2_legacy_PerfMeasurement(JNIEnv *env); extern int register_android_hardware_camera2_DngCreator(JNIEnv *env); extern int register_android_hardware_SensorManager(JNIEnv *env); extern int register_android_hardware_SerialPort(JNIEnv *env); @@ -1314,6 +1315,7 @@ static const RegJNIRec gRegJNI[] = { REG_JNI(register_android_hardware_Camera), REG_JNI(register_android_hardware_camera2_CameraMetadata), REG_JNI(register_android_hardware_camera2_legacy_LegacyCameraDevice), + REG_JNI(register_android_hardware_camera2_legacy_PerfMeasurement), REG_JNI(register_android_hardware_camera2_DngCreator), REG_JNI(register_android_hardware_SensorManager), REG_JNI(register_android_hardware_SerialPort), diff --git a/core/jni/android_hardware_camera2_DngCreator.cpp b/core/jni/android_hardware_camera2_DngCreator.cpp index 33100bf..3a3328f 100644 --- a/core/jni/android_hardware_camera2_DngCreator.cpp +++ b/core/jni/android_hardware_camera2_DngCreator.cpp @@ -24,11 +24,14 @@ #include <img_utils/TiffIfd.h> #include <img_utils/TiffWriter.h> #include <img_utils/Output.h> +#include <img_utils/Input.h> +#include <img_utils/StripSource.h> #include <utils/Log.h> #include <utils/Errors.h> #include <utils/StrongPointer.h> #include <utils/RefBase.h> +#include <utils/Vector.h> #include <cutils/properties.h> #include <string.h> @@ -42,17 +45,17 @@ using namespace android; using namespace img_utils; -#define BAIL_IF_INVALID(expr, jnienv, tagId) \ +#define BAIL_IF_INVALID(expr, jnienv, tagId, writer) \ if ((expr) != OK) { \ jniThrowExceptionFmt(jnienv, "java/lang/IllegalArgumentException", \ - "Invalid metadata for tag %x", tagId); \ + "Invalid metadata for tag %s (%x)", (writer)->getTagName(tagId), (tagId)); \ return; \ } -#define BAIL_IF_EMPTY(entry, jnienv, tagId) \ +#define BAIL_IF_EMPTY(entry, jnienv, tagId, writer) \ if (entry.count == 0) { \ jniThrowExceptionFmt(jnienv, "java/lang/IllegalArgumentException", \ - "Missing metadata fields for tag %x", tagId); \ + "Missing metadata fields for tag %s (%x)", (writer)->getTagName(tagId), (tagId)); \ return; \ } @@ -66,15 +69,98 @@ static struct { jmethodID mWriteMethod; } gOutputStreamClassInfo; +static struct { + jmethodID mReadMethod; + jmethodID mSkipMethod; +} gInputStreamClassInfo; + +static struct { + jmethodID mGetMethod; +} gInputByteBufferClassInfo; + enum { BITS_PER_SAMPLE = 16, BYTES_PER_SAMPLE = 2, - TIFF_IFD_0 = 0 + BYTES_PER_RGB_PIXEL = 3, + BITS_PER_RGB_SAMPLE = 8, + BYTES_PER_RGB_SAMPLE = 1, + SAMPLES_PER_RGB_PIXEL = 3, + SAMPLES_PER_RAW_PIXEL = 1, + TIFF_IFD_0 = 0, + TIFF_IFD_SUB1 = 1, + TIFF_IFD_GPSINFO = 2, }; // ---------------------------------------------------------------------------- -// This class is not intended to be used across JNI calls. +/** + * Container class for the persistent native context. + */ + +class NativeContext : public LightRefBase<NativeContext> { + +public: + NativeContext(); + virtual ~NativeContext(); + + TiffWriter* getWriter(); + + uint32_t getThumbnailWidth(); + uint32_t getThumbnailHeight(); + const uint8_t* getThumbnail(); + + bool setThumbnail(const uint8_t* buffer, uint32_t width, uint32_t height); + +private: + Vector<uint8_t> mCurrentThumbnail; + TiffWriter mWriter; + uint32_t mThumbnailWidth; + uint32_t mThumbnailHeight; +}; + +NativeContext::NativeContext() : mThumbnailWidth(0), mThumbnailHeight(0) {} + +NativeContext::~NativeContext() {} + +TiffWriter* NativeContext::getWriter() { + return &mWriter; +} + +uint32_t NativeContext::getThumbnailWidth() { + return mThumbnailWidth; +} + +uint32_t NativeContext::getThumbnailHeight() { + return mThumbnailHeight; +} + +const uint8_t* NativeContext::getThumbnail() { + return mCurrentThumbnail.array(); +} + +bool NativeContext::setThumbnail(const uint8_t* buffer, uint32_t width, uint32_t height) { + mThumbnailWidth = width; + mThumbnailHeight = height; + + size_t size = BYTES_PER_RGB_PIXEL * width * height; + if (mCurrentThumbnail.resize(size) < 0) { + ALOGE("%s: Could not resize thumbnail buffer.", __FUNCTION__); + return false; + } + + uint8_t* thumb = mCurrentThumbnail.editArray(); + memcpy(thumb, buffer, size); + return true; +} + +// End of NativeContext +// ---------------------------------------------------------------------------- + +/** + * Wrapper class for a Java OutputStream. + * + * This class is not intended to be used across JNI calls. + */ class JniOutputStream : public Output, public LightRefBase<JniOutputStream> { public: JniOutputStream(JNIEnv* env, jobject outStream); @@ -82,11 +168,13 @@ public: virtual ~JniOutputStream(); status_t open(); + status_t write(const uint8_t* buf, size_t offset, size_t count); + status_t close(); private: enum { - BYTE_ARRAY_LENGTH = 1024 + BYTE_ARRAY_LENGTH = 4096 }; jobject mOutputStream; JNIEnv* mEnv; @@ -138,27 +226,465 @@ status_t JniOutputStream::close() { return OK; } +// End of JniOutputStream // ---------------------------------------------------------------------------- +/** + * Wrapper class for a Java InputStream. + * + * This class is not intended to be used across JNI calls. + */ +class JniInputStream : public Input, public LightRefBase<JniInputStream> { +public: + JniInputStream(JNIEnv* env, jobject inStream); + + status_t open(); + + status_t close(); + + ssize_t read(uint8_t* buf, size_t offset, size_t count); + + ssize_t skip(size_t count); + + virtual ~JniInputStream(); +private: + enum { + BYTE_ARRAY_LENGTH = 4096 + }; + jobject mInStream; + JNIEnv* mEnv; + jbyteArray mByteArray; + +}; + +JniInputStream::JniInputStream(JNIEnv* env, jobject inStream) : mInStream(inStream), mEnv(env) { + mByteArray = env->NewByteArray(BYTE_ARRAY_LENGTH); + if (mByteArray == NULL) { + jniThrowException(env, "java/lang/OutOfMemoryError", "Could not allocate byte array."); + } +} + +JniInputStream::~JniInputStream() { + mEnv->DeleteLocalRef(mByteArray); +} + +ssize_t JniInputStream::read(uint8_t* buf, size_t offset, size_t count) { + + jint realCount = BYTE_ARRAY_LENGTH; + if (count < BYTE_ARRAY_LENGTH) { + realCount = count; + } + jint actual = mEnv->CallIntMethod(mInStream, gInputStreamClassInfo.mReadMethod, mByteArray, 0, + realCount); + + if (actual < 0) { + return NOT_ENOUGH_DATA; + } + + if (mEnv->ExceptionCheck()) { + return BAD_VALUE; + } + + mEnv->GetByteArrayRegion(mByteArray, 0, actual, reinterpret_cast<jbyte*>(buf + offset)); + if (mEnv->ExceptionCheck()) { + return BAD_VALUE; + } + return actual; +} + +ssize_t JniInputStream::skip(size_t count) { + jlong actual = mEnv->CallLongMethod(mInStream, gInputStreamClassInfo.mSkipMethod, + static_cast<jlong>(count)); + + if (mEnv->ExceptionCheck()) { + return BAD_VALUE; + } + if (actual < 0) { + return NOT_ENOUGH_DATA; + } + return actual; +} + +status_t JniInputStream::open() { + // Do nothing + return OK; +} + +status_t JniInputStream::close() { + // Do nothing + return OK; +} + +// End of JniInputStream +// ---------------------------------------------------------------------------- + +/** + * Wrapper class for a non-direct Java ByteBuffer. + * + * This class is not intended to be used across JNI calls. + */ +class JniInputByteBuffer : public Input, public LightRefBase<JniInputByteBuffer> { +public: + JniInputByteBuffer(JNIEnv* env, jobject inBuf); + + status_t open(); + + status_t close(); + + ssize_t read(uint8_t* buf, size_t offset, size_t count); + + virtual ~JniInputByteBuffer(); +private: + enum { + BYTE_ARRAY_LENGTH = 4096 + }; + jobject mInBuf; + JNIEnv* mEnv; + jbyteArray mByteArray; +}; + +JniInputByteBuffer::JniInputByteBuffer(JNIEnv* env, jobject inBuf) : mInBuf(inBuf), mEnv(env) { + mByteArray = env->NewByteArray(BYTE_ARRAY_LENGTH); + if (mByteArray == NULL) { + jniThrowException(env, "java/lang/OutOfMemoryError", "Could not allocate byte array."); + } +} + +JniInputByteBuffer::~JniInputByteBuffer() { + mEnv->DeleteLocalRef(mByteArray); +} + +ssize_t JniInputByteBuffer::read(uint8_t* buf, size_t offset, size_t count) { + jint realCount = BYTE_ARRAY_LENGTH; + if (count < BYTE_ARRAY_LENGTH) { + realCount = count; + } + + mEnv->CallObjectMethod(mInBuf, gInputByteBufferClassInfo.mGetMethod, mByteArray, 0, + realCount); + + if (mEnv->ExceptionCheck()) { + return BAD_VALUE; + } + + mEnv->GetByteArrayRegion(mByteArray, 0, realCount, reinterpret_cast<jbyte*>(buf + offset)); + if (mEnv->ExceptionCheck()) { + return BAD_VALUE; + } + return realCount; +} + +status_t JniInputByteBuffer::open() { + // Do nothing + return OK; +} + +status_t JniInputByteBuffer::close() { + // Do nothing + return OK; +} + +// End of JniInputByteBuffer +// ---------------------------------------------------------------------------- + +/** + * StripSource subclass for Input types. + * + * This class is not intended to be used across JNI calls. + */ + +class InputStripSource : public StripSource, public LightRefBase<InputStripSource> { +public: + InputStripSource(JNIEnv* env, Input& input, uint32_t ifd, uint32_t width, uint32_t height, + uint32_t pixStride, uint32_t rowStride, uint64_t offset, uint32_t bytesPerSample, + uint32_t samplesPerPixel); + + virtual ~InputStripSource(); + + virtual status_t writeToStream(Output& stream, uint32_t count); + + virtual uint32_t getIfd() const; +protected: + uint32_t mIfd; + Input* mInput; + uint32_t mWidth; + uint32_t mHeight; + uint32_t mPixStride; + uint32_t mRowStride; + uint64_t mOffset; + JNIEnv* mEnv; + uint32_t mBytesPerSample; + uint32_t mSamplesPerPixel; +}; + +InputStripSource::InputStripSource(JNIEnv* env, Input& input, uint32_t ifd, uint32_t width, + uint32_t height, uint32_t pixStride, uint32_t rowStride, uint64_t offset, + uint32_t bytesPerSample, uint32_t samplesPerPixel) : mIfd(ifd), mInput(&input), + mWidth(width), mHeight(height), mPixStride(pixStride), mRowStride(rowStride), + mOffset(offset), mEnv(env), mBytesPerSample(bytesPerSample), + mSamplesPerPixel(samplesPerPixel) {} + +InputStripSource::~InputStripSource() {} + +status_t InputStripSource::writeToStream(Output& stream, uint32_t count) { + status_t err = OK; + uint32_t fullSize = mRowStride * mHeight; + jlong offset = mOffset; + + if (fullSize != count) { + ALOGE("%s: Amount to write %u doesn't match image size %u", __FUNCTION__, count, + fullSize); + jniThrowException(mEnv, "java/lang/IllegalStateException", "Not enough data to write"); + return BAD_VALUE; + } + + // Skip offset + while (offset > 0) { + ssize_t skipped = mInput->skip(offset); + if (skipped <= 0) { + if (skipped == NOT_ENOUGH_DATA || skipped == 0) { + jniThrowExceptionFmt(mEnv, "java/io/IOException", + "Early EOF encountered in skip, not enough pixel data for image of size %u", + fullSize); + skipped = NOT_ENOUGH_DATA; + } else { + if (!mEnv->ExceptionCheck()) { + jniThrowException(mEnv, "java/io/IOException", + "Error encountered while skip bytes in input stream."); + } + } + + return skipped; + } + offset -= skipped; + } + + Vector<uint8_t> row; + if (row.resize(mRowStride) < 0) { + jniThrowException(mEnv, "java/lang/OutOfMemoryError", "Could not allocate row vector."); + return BAD_VALUE; + } + + uint8_t* rowBytes = row.editArray(); + + for (uint32_t i = 0; i < mHeight; ++i) { + size_t rowFillAmt = 0; + size_t rowSize = mPixStride; + + while (rowFillAmt < mRowStride) { + ssize_t bytesRead = mInput->read(rowBytes, rowFillAmt, rowSize); + if (bytesRead <= 0) { + if (bytesRead == NOT_ENOUGH_DATA || bytesRead == 0) { + jniThrowExceptionFmt(mEnv, "java/io/IOException", + "Early EOF encountered, not enough pixel data for image of size %u", + fullSize); + bytesRead = NOT_ENOUGH_DATA; + } else { + if (!mEnv->ExceptionCheck()) { + jniThrowException(mEnv, "java/io/IOException", + "Error encountered while reading"); + } + } + return bytesRead; + } + rowFillAmt += bytesRead; + rowSize -= bytesRead; + } + + if (mPixStride == mBytesPerSample * mSamplesPerPixel) { + ALOGV("%s: Using stream per-row write for strip.", __FUNCTION__); + + if (stream.write(rowBytes, 0, mBytesPerSample * mSamplesPerPixel * mWidth) != OK || + mEnv->ExceptionCheck()) { + if (!mEnv->ExceptionCheck()) { + jniThrowException(mEnv, "java/io/IOException", "Failed to write pixel data"); + } + return BAD_VALUE; + } + } else { + ALOGV("%s: Using stream per-pixel write for strip.", __FUNCTION__); + jniThrowException(mEnv, "java/lang/IllegalStateException", + "Per-pixel strides are not supported for RAW16 -- pixels must be contiguous"); + return BAD_VALUE; + + // TODO: Add support for non-contiguous pixels if needed. + } + } + return OK; +} + +uint32_t InputStripSource::getIfd() const { + return mIfd; +} + +// End of InputStripSource +// ---------------------------------------------------------------------------- + +/** + * StripSource subclass for direct buffer types. + * + * This class is not intended to be used across JNI calls. + */ + +class DirectStripSource : public StripSource, public LightRefBase<DirectStripSource> { +public: + DirectStripSource(JNIEnv* env, const uint8_t* pixelBytes, uint32_t ifd, uint32_t width, + uint32_t height, uint32_t pixStride, uint32_t rowStride, uint64_t offset, + uint32_t bytesPerSample, uint32_t samplesPerPixel); + + virtual ~DirectStripSource(); + + virtual status_t writeToStream(Output& stream, uint32_t count); + + virtual uint32_t getIfd() const; +protected: + uint32_t mIfd; + const uint8_t* mPixelBytes; + uint32_t mWidth; + uint32_t mHeight; + uint32_t mPixStride; + uint32_t mRowStride; + uint16_t mOffset; + JNIEnv* mEnv; + uint32_t mBytesPerSample; + uint32_t mSamplesPerPixel; +}; + +DirectStripSource::DirectStripSource(JNIEnv* env, const uint8_t* pixelBytes, uint32_t ifd, + uint32_t width, uint32_t height, uint32_t pixStride, uint32_t rowStride, + uint64_t offset, uint32_t bytesPerSample, uint32_t samplesPerPixel) : mIfd(ifd), + mPixelBytes(pixelBytes), mWidth(width), mHeight(height), mPixStride(pixStride), + mRowStride(rowStride), mOffset(offset), mEnv(env), mBytesPerSample(bytesPerSample), + mSamplesPerPixel(samplesPerPixel) {} + +DirectStripSource::~DirectStripSource() {} + +status_t DirectStripSource::writeToStream(Output& stream, uint32_t count) { + uint32_t fullSize = mRowStride * mHeight; + + if (fullSize != count) { + ALOGE("%s: Amount to write %u doesn't match image size %u", __FUNCTION__, count, + fullSize); + jniThrowException(mEnv, "java/lang/IllegalStateException", "Not enough data to write"); + return BAD_VALUE; + } + + if (mPixStride == mBytesPerSample * mSamplesPerPixel + && mRowStride == mWidth * mBytesPerSample * mSamplesPerPixel) { + ALOGV("%s: Using direct single-pass write for strip.", __FUNCTION__); + + if (stream.write(mPixelBytes, mOffset, fullSize) != OK || mEnv->ExceptionCheck()) { + if (!mEnv->ExceptionCheck()) { + jniThrowException(mEnv, "java/io/IOException", "Failed to write pixel data"); + } + return BAD_VALUE; + } + } else if (mPixStride == mBytesPerSample * mSamplesPerPixel) { + ALOGV("%s: Using direct per-row write for strip.", __FUNCTION__); + + for (size_t i = 0; i < mHeight; ++i) { + if (stream.write(mPixelBytes, mOffset + i * mRowStride, mPixStride * mWidth) != OK || + mEnv->ExceptionCheck()) { + if (!mEnv->ExceptionCheck()) { + jniThrowException(mEnv, "java/io/IOException", "Failed to write pixel data"); + } + return BAD_VALUE; + } + } + } else { + ALOGV("%s: Using direct per-pixel write for strip.", __FUNCTION__); + + jniThrowException(mEnv, "java/lang/IllegalStateException", + "Per-pixel strides are not supported for RAW16 -- pixels must be contiguous"); + return BAD_VALUE; + + // TODO: Add support for non-contiguous pixels if needed. + } + return OK; + +} + +uint32_t DirectStripSource::getIfd() const { + return mIfd; +} + +// End of DirectStripSource +// ---------------------------------------------------------------------------- + +static bool validateDngHeader(JNIEnv* env, TiffWriter* writer, jint width, jint height) { + bool hasThumbnail = writer->hasIfd(TIFF_IFD_SUB1); + + // TODO: handle lens shading map, etc. conversions for other raw buffer sizes. + uint32_t metadataWidth = *(writer->getEntry(TAG_IMAGEWIDTH, (hasThumbnail) ? TIFF_IFD_SUB1 : TIFF_IFD_0)->getData<uint32_t>()); + uint32_t metadataHeight = *(writer->getEntry(TAG_IMAGELENGTH, (hasThumbnail) ? TIFF_IFD_SUB1 : TIFF_IFD_0)->getData<uint32_t>()); + + if (width < 0 || metadataWidth != static_cast<uint32_t>(width)) { + jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", \ + "Metadata width %d doesn't match image width %d", metadataWidth, width); + return false; + } + + if (height < 0 || metadataHeight != static_cast<uint32_t>(height)) { + jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", \ + "Metadata height %d doesn't match image height %d", metadataHeight, height); + return false; + } + + return true; +} + +static status_t moveEntries(TiffWriter* writer, uint32_t ifdFrom, uint32_t ifdTo, + const Vector<uint16_t>& entries) { + for (size_t i = 0; i < entries.size(); ++i) { + uint16_t tagId = entries[i]; + sp<TiffEntry> entry = writer->getEntry(tagId, ifdFrom); + if (entry == NULL) { + ALOGE("%s: moveEntries failed, entry %u not found in IFD %u", __FUNCTION__, tagId, + ifdFrom); + return BAD_VALUE; + } + if (writer->addEntry(entry, ifdTo) != OK) { + ALOGE("%s: moveEntries failed, could not add entry %u to IFD %u", __FUNCTION__, tagId, + ifdFrom); + return BAD_VALUE; + } + writer->removeEntry(tagId, ifdFrom); + } + return OK; +} + +// ---------------------------------------------------------------------------- extern "C" { -static TiffWriter* DngCreator_getCreator(JNIEnv* env, jobject thiz) { +static NativeContext* DngCreator_getNativeContext(JNIEnv* env, jobject thiz) { ALOGV("%s:", __FUNCTION__); - return reinterpret_cast<TiffWriter*>(env->GetLongField(thiz, + return reinterpret_cast<NativeContext*>(env->GetLongField(thiz, gDngCreatorClassInfo.mNativeContext)); } -static void DngCreator_setCreator(JNIEnv* env, jobject thiz, sp<TiffWriter> writer) { +static void DngCreator_setNativeContext(JNIEnv* env, jobject thiz, sp<NativeContext> context) { ALOGV("%s:", __FUNCTION__); - TiffWriter* current = DngCreator_getCreator(env, thiz); - if (writer != NULL) { - writer->incStrong((void*) DngCreator_setCreator); + NativeContext* current = DngCreator_getNativeContext(env, thiz); + + if (context != NULL) { + context->incStrong((void*) DngCreator_setNativeContext); } + if (current) { - current->decStrong((void*) DngCreator_setCreator); + current->decStrong((void*) DngCreator_setNativeContext); } + env->SetLongField(thiz, gDngCreatorClassInfo.mNativeContext, - reinterpret_cast<jlong>(writer.get())); + reinterpret_cast<jlong>(context.get())); +} + +static TiffWriter* DngCreator_getCreator(JNIEnv* env, jobject thiz) { + ALOGV("%s:", __FUNCTION__); + NativeContext* current = DngCreator_getNativeContext(env, thiz); + if (current) { + return current->getWriter(); + } + return NULL; } static void DngCreator_nativeClassInit(JNIEnv* env, jclass clazz) { @@ -174,6 +700,19 @@ static void DngCreator_nativeClassInit(JNIEnv* env, jclass clazz) { LOG_ALWAYS_FATAL_IF(outputStreamClazz == NULL, "Can't find java/io/OutputStream class"); gOutputStreamClassInfo.mWriteMethod = env->GetMethodID(outputStreamClazz, "write", "([BII)V"); LOG_ALWAYS_FATAL_IF(gOutputStreamClassInfo.mWriteMethod == NULL, "Can't find write method"); + + jclass inputStreamClazz = env->FindClass("java/io/InputStream"); + LOG_ALWAYS_FATAL_IF(inputStreamClazz == NULL, "Can't find java/io/InputStream class"); + gInputStreamClassInfo.mReadMethod = env->GetMethodID(inputStreamClazz, "read", "([BII)I"); + LOG_ALWAYS_FATAL_IF(gInputStreamClassInfo.mReadMethod == NULL, "Can't find read method"); + gInputStreamClassInfo.mSkipMethod = env->GetMethodID(inputStreamClazz, "skip", "(J)J"); + LOG_ALWAYS_FATAL_IF(gInputStreamClassInfo.mSkipMethod == NULL, "Can't find skip method"); + + jclass inputBufferClazz = env->FindClass("java/nio/ByteBuffer"); + LOG_ALWAYS_FATAL_IF(inputBufferClazz == NULL, "Can't find java/nio/ByteBuffer class"); + gInputByteBufferClassInfo.mGetMethod = env->GetMethodID(inputBufferClazz, "get", + "([BII)Ljava/nio/ByteBuffer;"); + LOG_ALWAYS_FATAL_IF(gInputByteBufferClassInfo.mGetMethod == NULL, "Can't find get method"); } static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPtr, @@ -192,7 +731,8 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt return; } - sp<TiffWriter> writer = new TiffWriter(); + sp<NativeContext> nativeContext = new NativeContext(); + TiffWriter* writer = nativeContext->getWriter(); writer->addIfd(TIFF_IFD_0); @@ -208,96 +748,99 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // TODO: Greensplit. // TODO: Add remaining non-essential tags + + // Setup main image tags + { // Set orientation uint16_t orientation = 1; // Normal BAIL_IF_INVALID(writer->addEntry(TAG_ORIENTATION, 1, &orientation, TIFF_IFD_0), env, - TAG_ORIENTATION); + TAG_ORIENTATION, writer); } { // Set subfiletype uint32_t subfileType = 0; // Main image BAIL_IF_INVALID(writer->addEntry(TAG_NEWSUBFILETYPE, 1, &subfileType, TIFF_IFD_0), env, - TAG_NEWSUBFILETYPE); + TAG_NEWSUBFILETYPE, writer); } { // Set bits per sample uint16_t bits = static_cast<uint16_t>(bitsPerSample); BAIL_IF_INVALID(writer->addEntry(TAG_BITSPERSAMPLE, 1, &bits, TIFF_IFD_0), env, - TAG_BITSPERSAMPLE); + TAG_BITSPERSAMPLE, writer); } { // Set compression uint16_t compression = 1; // None BAIL_IF_INVALID(writer->addEntry(TAG_COMPRESSION, 1, &compression, TIFF_IFD_0), env, - TAG_COMPRESSION); + TAG_COMPRESSION, writer); } { // Set dimensions camera_metadata_entry entry = characteristics.find(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE); - BAIL_IF_EMPTY(entry, env, TAG_IMAGEWIDTH); + BAIL_IF_EMPTY(entry, env, TAG_IMAGEWIDTH, writer); uint32_t width = static_cast<uint32_t>(entry.data.i32[2]); uint32_t height = static_cast<uint32_t>(entry.data.i32[3]); BAIL_IF_INVALID(writer->addEntry(TAG_IMAGEWIDTH, 1, &width, TIFF_IFD_0), env, - TAG_IMAGEWIDTH); + TAG_IMAGEWIDTH, writer); BAIL_IF_INVALID(writer->addEntry(TAG_IMAGELENGTH, 1, &height, TIFF_IFD_0), env, - TAG_IMAGELENGTH); + TAG_IMAGELENGTH, writer); imageWidth = width; imageHeight = height; } { // Set photometric interpretation - uint16_t interpretation = 32803; + uint16_t interpretation = 32803; // CFA BAIL_IF_INVALID(writer->addEntry(TAG_PHOTOMETRICINTERPRETATION, 1, &interpretation, - TIFF_IFD_0), env, TAG_PHOTOMETRICINTERPRETATION); + TIFF_IFD_0), env, TAG_PHOTOMETRICINTERPRETATION, writer); } { // Set blacklevel tags camera_metadata_entry entry = characteristics.find(ANDROID_SENSOR_BLACK_LEVEL_PATTERN); - BAIL_IF_EMPTY(entry, env, TAG_BLACKLEVEL); + BAIL_IF_EMPTY(entry, env, TAG_BLACKLEVEL, writer); const uint32_t* blackLevel = reinterpret_cast<const uint32_t*>(entry.data.i32); BAIL_IF_INVALID(writer->addEntry(TAG_BLACKLEVEL, entry.count, blackLevel, TIFF_IFD_0), env, - TAG_BLACKLEVEL); + TAG_BLACKLEVEL, writer); uint16_t repeatDim[2] = {2, 2}; BAIL_IF_INVALID(writer->addEntry(TAG_BLACKLEVELREPEATDIM, 2, repeatDim, TIFF_IFD_0), env, - TAG_BLACKLEVELREPEATDIM); + TAG_BLACKLEVELREPEATDIM, writer); } { // Set samples per pixel uint16_t samples = static_cast<uint16_t>(samplesPerPixel); BAIL_IF_INVALID(writer->addEntry(TAG_SAMPLESPERPIXEL, 1, &samples, TIFF_IFD_0), - env, TAG_SAMPLESPERPIXEL); + env, TAG_SAMPLESPERPIXEL, writer); } { // Set planar configuration uint16_t config = 1; // Chunky BAIL_IF_INVALID(writer->addEntry(TAG_PLANARCONFIGURATION, 1, &config, TIFF_IFD_0), - env, TAG_PLANARCONFIGURATION); + env, TAG_PLANARCONFIGURATION, writer); } { // Set CFA pattern dimensions uint16_t repeatDim[2] = {2, 2}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAREPEATPATTERNDIM, 2, repeatDim, TIFF_IFD_0), - env, TAG_CFAREPEATPATTERNDIM); + env, TAG_CFAREPEATPATTERNDIM, writer); } { // Set CFA pattern camera_metadata_entry entry = characteristics.find(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT); - BAIL_IF_EMPTY(entry, env, TAG_CFAPATTERN); + BAIL_IF_EMPTY(entry, env, TAG_CFAPATTERN, writer); camera_metadata_enum_android_sensor_info_color_filter_arrangement_t cfa = static_cast<camera_metadata_enum_android_sensor_info_color_filter_arrangement_t>( entry.data.u8[0]); @@ -305,28 +848,28 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt case ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_RGGB: { uint8_t cfa[4] = {0, 1, 1, 2}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAPATTERN, 4, cfa, TIFF_IFD_0), - env, TAG_CFAPATTERN); + env, TAG_CFAPATTERN, writer); opcodeCfaLayout = OpcodeListBuilder::CFA_RGGB; break; } case ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GRBG: { uint8_t cfa[4] = {1, 0, 2, 1}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAPATTERN, 4, cfa, TIFF_IFD_0), - env, TAG_CFAPATTERN); + env, TAG_CFAPATTERN, writer); opcodeCfaLayout = OpcodeListBuilder::CFA_GRBG; break; } case ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GBRG: { uint8_t cfa[4] = {1, 2, 0, 1}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAPATTERN, 4, cfa, TIFF_IFD_0), - env, TAG_CFAPATTERN); + env, TAG_CFAPATTERN, writer); opcodeCfaLayout = OpcodeListBuilder::CFA_GBRG; break; } case ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_BGGR: { uint8_t cfa[4] = {2, 1, 1, 0}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAPATTERN, 4, cfa, TIFF_IFD_0), - env, TAG_CFAPATTERN); + env, TAG_CFAPATTERN, writer); opcodeCfaLayout = OpcodeListBuilder::CFA_BGGR; break; } @@ -342,21 +885,21 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set CFA plane color uint8_t cfaPlaneColor[3] = {0, 1, 2}; BAIL_IF_INVALID(writer->addEntry(TAG_CFAPLANECOLOR, 3, cfaPlaneColor, TIFF_IFD_0), - env, TAG_CFAPLANECOLOR); + env, TAG_CFAPLANECOLOR, writer); } { // Set CFA layout uint16_t cfaLayout = 1; BAIL_IF_INVALID(writer->addEntry(TAG_CFALAYOUT, 1, &cfaLayout, TIFF_IFD_0), - env, TAG_CFALAYOUT); + env, TAG_CFALAYOUT, writer); } { // image description uint8_t imageDescription = '\0'; // empty BAIL_IF_INVALID(writer->addEntry(TAG_IMAGEDESCRIPTION, 1, &imageDescription, TIFF_IFD_0), - env, TAG_IMAGEDESCRIPTION); + env, TAG_IMAGEDESCRIPTION, writer); } { @@ -368,7 +911,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint32_t count = static_cast<uint32_t>(strlen(manufacturer)) + 1; BAIL_IF_INVALID(writer->addEntry(TAG_MAKE, count, reinterpret_cast<uint8_t*>(manufacturer), - TIFF_IFD_0), env, TAG_MAKE); + TIFF_IFD_0), env, TAG_MAKE, writer); } { @@ -380,23 +923,23 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint32_t count = static_cast<uint32_t>(strlen(model)) + 1; BAIL_IF_INVALID(writer->addEntry(TAG_MODEL, count, reinterpret_cast<uint8_t*>(model), - TIFF_IFD_0), env, TAG_MODEL); + TIFF_IFD_0), env, TAG_MODEL, writer); } { // x resolution uint32_t xres[] = { 72, 1 }; // default 72 ppi BAIL_IF_INVALID(writer->addEntry(TAG_XRESOLUTION, 1, xres, TIFF_IFD_0), - env, TAG_XRESOLUTION); + env, TAG_XRESOLUTION, writer); // y resolution uint32_t yres[] = { 72, 1 }; // default 72 ppi BAIL_IF_INVALID(writer->addEntry(TAG_YRESOLUTION, 1, yres, TIFF_IFD_0), - env, TAG_YRESOLUTION); + env, TAG_YRESOLUTION, writer); uint16_t unit = 2; // inches BAIL_IF_INVALID(writer->addEntry(TAG_RESOLUTIONUNIT, 1, &unit, TIFF_IFD_0), - env, TAG_RESOLUTIONUNIT); + env, TAG_RESOLUTIONUNIT, writer); } { @@ -405,7 +948,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt property_get("ro.build.fingerprint", software, ""); uint32_t count = static_cast<uint32_t>(strlen(software)) + 1; BAIL_IF_INVALID(writer->addEntry(TAG_SOFTWARE, count, reinterpret_cast<uint8_t*>(software), - TIFF_IFD_0), env, TAG_SOFTWARE); + TIFF_IFD_0), env, TAG_SOFTWARE, writer); } { @@ -420,12 +963,22 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt return; } - BAIL_IF_INVALID(writer->addEntry(TAG_DATETIME, DATETIME_COUNT, - reinterpret_cast<const uint8_t*>(captureTime), TIFF_IFD_0), env, TAG_DATETIMEORIGINAL); + if (writer->addEntry(TAG_DATETIME, DATETIME_COUNT, + reinterpret_cast<const uint8_t*>(captureTime), TIFF_IFD_0) != OK) { + env->ReleaseStringUTFChars(formattedCaptureTime, captureTime); + jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", + "Invalid metadata for tag %x", TAG_DATETIME); + return; + } // datetime original - BAIL_IF_INVALID(writer->addEntry(TAG_DATETIMEORIGINAL, DATETIME_COUNT, - reinterpret_cast<const uint8_t*>(captureTime), TIFF_IFD_0), env, TAG_DATETIMEORIGINAL); + if (writer->addEntry(TAG_DATETIMEORIGINAL, DATETIME_COUNT, + reinterpret_cast<const uint8_t*>(captureTime), TIFF_IFD_0) != OK) { + env->ReleaseStringUTFChars(formattedCaptureTime, captureTime); + jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", + "Invalid metadata for tag %x", TAG_DATETIMEORIGINAL); + return; + } env->ReleaseStringUTFChars(formattedCaptureTime, captureTime); } @@ -433,21 +986,21 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // TIFF/EP standard id uint8_t standardId[] = { 1, 0, 0, 0 }; BAIL_IF_INVALID(writer->addEntry(TAG_TIFFEPSTANDARDID, 4, standardId, - TIFF_IFD_0), env, TAG_TIFFEPSTANDARDID); + TIFF_IFD_0), env, TAG_TIFFEPSTANDARDID, writer); } { // copyright uint8_t copyright = '\0'; // empty BAIL_IF_INVALID(writer->addEntry(TAG_COPYRIGHT, 1, ©right, - TIFF_IFD_0), env, TAG_COPYRIGHT); + TIFF_IFD_0), env, TAG_COPYRIGHT, writer); } { // exposure time camera_metadata_entry entry = results.find(ANDROID_SENSOR_EXPOSURE_TIME); - BAIL_IF_EMPTY(entry, env, TAG_EXPOSURETIME); + BAIL_IF_EMPTY(entry, env, TAG_EXPOSURETIME, writer); int64_t exposureTime = *(entry.data.i64); @@ -473,7 +1026,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint32_t exposure[] = { static_cast<uint32_t>(exposureTime), denominator }; BAIL_IF_INVALID(writer->addEntry(TAG_EXPOSURETIME, 1, exposure, - TIFF_IFD_0), env, TAG_EXPOSURETIME); + TIFF_IFD_0), env, TAG_EXPOSURETIME, writer); } @@ -481,7 +1034,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // ISO speed ratings camera_metadata_entry entry = results.find(ANDROID_SENSOR_SENSITIVITY); - BAIL_IF_EMPTY(entry, env, TAG_ISOSPEEDRATINGS); + BAIL_IF_EMPTY(entry, env, TAG_ISOSPEEDRATINGS, writer); int32_t tempIso = *(entry.data.i32); if (tempIso < 0) { @@ -497,57 +1050,57 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint16_t iso = static_cast<uint16_t>(tempIso); BAIL_IF_INVALID(writer->addEntry(TAG_ISOSPEEDRATINGS, 1, &iso, - TIFF_IFD_0), env, TAG_ISOSPEEDRATINGS); + TIFF_IFD_0), env, TAG_ISOSPEEDRATINGS, writer); } { // focal length camera_metadata_entry entry = results.find(ANDROID_LENS_FOCAL_LENGTH); - BAIL_IF_EMPTY(entry, env, TAG_FOCALLENGTH); + BAIL_IF_EMPTY(entry, env, TAG_FOCALLENGTH, writer); uint32_t focalLength[] = { static_cast<uint32_t>(*(entry.data.f) * 100), 100 }; BAIL_IF_INVALID(writer->addEntry(TAG_FOCALLENGTH, 1, focalLength, - TIFF_IFD_0), env, TAG_FOCALLENGTH); + TIFF_IFD_0), env, TAG_FOCALLENGTH, writer); } { // f number camera_metadata_entry entry = results.find(ANDROID_LENS_APERTURE); - BAIL_IF_EMPTY(entry, env, TAG_FNUMBER); + BAIL_IF_EMPTY(entry, env, TAG_FNUMBER, writer); uint32_t fnum[] = { static_cast<uint32_t>(*(entry.data.f) * 100), 100 }; BAIL_IF_INVALID(writer->addEntry(TAG_FNUMBER, 1, fnum, - TIFF_IFD_0), env, TAG_FNUMBER); + TIFF_IFD_0), env, TAG_FNUMBER, writer); } { // Set DNG version information uint8_t version[4] = {1, 4, 0, 0}; BAIL_IF_INVALID(writer->addEntry(TAG_DNGVERSION, 4, version, TIFF_IFD_0), - env, TAG_DNGVERSION); + env, TAG_DNGVERSION, writer); uint8_t backwardVersion[4] = {1, 1, 0, 0}; BAIL_IF_INVALID(writer->addEntry(TAG_DNGBACKWARDVERSION, 4, backwardVersion, TIFF_IFD_0), - env, TAG_DNGBACKWARDVERSION); + env, TAG_DNGBACKWARDVERSION, writer); } { // Set whitelevel camera_metadata_entry entry = characteristics.find(ANDROID_SENSOR_INFO_WHITE_LEVEL); - BAIL_IF_EMPTY(entry, env, TAG_WHITELEVEL); + BAIL_IF_EMPTY(entry, env, TAG_WHITELEVEL, writer); uint32_t whiteLevel = static_cast<uint32_t>(entry.data.i32[0]); BAIL_IF_INVALID(writer->addEntry(TAG_WHITELEVEL, 1, &whiteLevel, TIFF_IFD_0), env, - TAG_WHITELEVEL); + TAG_WHITELEVEL, writer); } { // Set default scale uint32_t defaultScale[4] = {1, 1, 1, 1}; BAIL_IF_INVALID(writer->addEntry(TAG_DEFAULTSCALE, 2, defaultScale, TIFF_IFD_0), - env, TAG_DEFAULTSCALE); + env, TAG_DEFAULTSCALE, writer); } bool singleIlluminant = false; @@ -555,7 +1108,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set calibration illuminants camera_metadata_entry entry1 = characteristics.find(ANDROID_SENSOR_REFERENCE_ILLUMINANT1); - BAIL_IF_EMPTY(entry1, env, TAG_CALIBRATIONILLUMINANT1); + BAIL_IF_EMPTY(entry1, env, TAG_CALIBRATIONILLUMINANT1, writer); camera_metadata_entry entry2 = characteristics.find(ANDROID_SENSOR_REFERENCE_ILLUMINANT2); if (entry2.count == 0) { @@ -564,12 +1117,12 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint16_t ref1 = entry1.data.u8[0]; BAIL_IF_INVALID(writer->addEntry(TAG_CALIBRATIONILLUMINANT1, 1, &ref1, - TIFF_IFD_0), env, TAG_CALIBRATIONILLUMINANT1); + TIFF_IFD_0), env, TAG_CALIBRATIONILLUMINANT1, writer); if (!singleIlluminant) { uint16_t ref2 = entry2.data.u8[0]; BAIL_IF_INVALID(writer->addEntry(TAG_CALIBRATIONILLUMINANT2, 1, &ref2, - TIFF_IFD_0), env, TAG_CALIBRATIONILLUMINANT2); + TIFF_IFD_0), env, TAG_CALIBRATIONILLUMINANT2, writer); } } @@ -577,7 +1130,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set color transforms camera_metadata_entry entry1 = characteristics.find(ANDROID_SENSOR_COLOR_TRANSFORM1); - BAIL_IF_EMPTY(entry1, env, TAG_COLORMATRIX1); + BAIL_IF_EMPTY(entry1, env, TAG_COLORMATRIX1, writer); int32_t colorTransform1[entry1.count * 2]; @@ -587,12 +1140,12 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt colorTransform1[ctr++] = entry1.data.r[i].denominator; } - BAIL_IF_INVALID(writer->addEntry(TAG_COLORMATRIX1, entry1.count, colorTransform1, TIFF_IFD_0), - env, TAG_COLORMATRIX1); + BAIL_IF_INVALID(writer->addEntry(TAG_COLORMATRIX1, entry1.count, colorTransform1, + TIFF_IFD_0), env, TAG_COLORMATRIX1, writer); if (!singleIlluminant) { camera_metadata_entry entry2 = characteristics.find(ANDROID_SENSOR_COLOR_TRANSFORM2); - BAIL_IF_EMPTY(entry2, env, TAG_COLORMATRIX2); + BAIL_IF_EMPTY(entry2, env, TAG_COLORMATRIX2, writer); int32_t colorTransform2[entry2.count * 2]; ctr = 0; @@ -601,8 +1154,8 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt colorTransform2[ctr++] = entry2.data.r[i].denominator; } - BAIL_IF_INVALID(writer->addEntry(TAG_COLORMATRIX2, entry2.count, colorTransform2, TIFF_IFD_0), - env, TAG_COLORMATRIX2); + BAIL_IF_INVALID(writer->addEntry(TAG_COLORMATRIX2, entry2.count, colorTransform2, + TIFF_IFD_0), env, TAG_COLORMATRIX2, writer); } } @@ -610,7 +1163,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set calibration transforms camera_metadata_entry entry1 = characteristics.find(ANDROID_SENSOR_CALIBRATION_TRANSFORM1); - BAIL_IF_EMPTY(entry1, env, TAG_CAMERACALIBRATION1); + BAIL_IF_EMPTY(entry1, env, TAG_CAMERACALIBRATION1, writer); int32_t calibrationTransform1[entry1.count * 2]; @@ -621,12 +1174,12 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt } BAIL_IF_INVALID(writer->addEntry(TAG_CAMERACALIBRATION1, entry1.count, calibrationTransform1, - TIFF_IFD_0), env, TAG_CAMERACALIBRATION1); + TIFF_IFD_0), env, TAG_CAMERACALIBRATION1, writer); if (!singleIlluminant) { camera_metadata_entry entry2 = characteristics.find(ANDROID_SENSOR_CALIBRATION_TRANSFORM2); - BAIL_IF_EMPTY(entry2, env, TAG_CAMERACALIBRATION2); + BAIL_IF_EMPTY(entry2, env, TAG_CAMERACALIBRATION2, writer); int32_t calibrationTransform2[entry2.count * 2]; ctr = 0; @@ -636,7 +1189,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt } BAIL_IF_INVALID(writer->addEntry(TAG_CAMERACALIBRATION2, entry2.count, calibrationTransform1, - TIFF_IFD_0), env, TAG_CAMERACALIBRATION2); + TIFF_IFD_0), env, TAG_CAMERACALIBRATION2, writer); } } @@ -644,7 +1197,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set forward transforms camera_metadata_entry entry1 = characteristics.find(ANDROID_SENSOR_FORWARD_MATRIX1); - BAIL_IF_EMPTY(entry1, env, TAG_FORWARDMATRIX1); + BAIL_IF_EMPTY(entry1, env, TAG_FORWARDMATRIX1, writer); int32_t forwardTransform1[entry1.count * 2]; @@ -655,12 +1208,12 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt } BAIL_IF_INVALID(writer->addEntry(TAG_FORWARDMATRIX1, entry1.count, forwardTransform1, - TIFF_IFD_0), env, TAG_FORWARDMATRIX1); + TIFF_IFD_0), env, TAG_FORWARDMATRIX1, writer); if (!singleIlluminant) { camera_metadata_entry entry2 = characteristics.find(ANDROID_SENSOR_FORWARD_MATRIX2); - BAIL_IF_EMPTY(entry2, env, TAG_FORWARDMATRIX2); + BAIL_IF_EMPTY(entry2, env, TAG_FORWARDMATRIX2, writer); int32_t forwardTransform2[entry2.count * 2]; ctr = 0; @@ -670,7 +1223,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt } BAIL_IF_INVALID(writer->addEntry(TAG_FORWARDMATRIX2, entry2.count, forwardTransform2, - TIFF_IFD_0), env, TAG_FORWARDMATRIX2); + TIFF_IFD_0), env, TAG_FORWARDMATRIX2, writer); } } @@ -678,7 +1231,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt // Set camera neutral camera_metadata_entry entry = results.find(ANDROID_SENSOR_NEUTRAL_COLOR_POINT); - BAIL_IF_EMPTY(entry, env, TAG_ASSHOTNEUTRAL); + BAIL_IF_EMPTY(entry, env, TAG_ASSHOTNEUTRAL, writer); uint32_t cameraNeutral[entry.count * 2]; size_t ctr = 0; @@ -690,23 +1243,18 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt } BAIL_IF_INVALID(writer->addEntry(TAG_ASSHOTNEUTRAL, entry.count, cameraNeutral, - TIFF_IFD_0), env, TAG_ASSHOTNEUTRAL); + TIFF_IFD_0), env, TAG_ASSHOTNEUTRAL, writer); } { // Setup data strips // TODO: Switch to tiled implementation. - uint32_t offset = 0; - BAIL_IF_INVALID(writer->addEntry(TAG_STRIPOFFSETS, 1, &offset, TIFF_IFD_0), env, - TAG_STRIPOFFSETS); - - BAIL_IF_INVALID(writer->addEntry(TAG_ROWSPERSTRIP, 1, &imageHeight, TIFF_IFD_0), env, - TAG_ROWSPERSTRIP); - - uint32_t byteCount = imageWidth * imageHeight * bitsPerSample * samplesPerPixel / - bitsPerByte; - BAIL_IF_INVALID(writer->addEntry(TAG_STRIPBYTECOUNTS, 1, &byteCount, TIFF_IFD_0), env, - TAG_STRIPBYTECOUNTS); + if (writer->addStrip(TIFF_IFD_0) != OK) { + ALOGE("%s: Could not setup strip tags.", __FUNCTION__); + jniThrowException(env, "java/lang/IllegalStateException", + "Failed to setup strip tags."); + return; + } } { @@ -717,9 +1265,9 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt uint32_t defaultCropOrigin[] = {margin, margin}; uint32_t defaultCropSize[] = {imageWidth - margin, imageHeight - margin}; BAIL_IF_INVALID(writer->addEntry(TAG_DEFAULTCROPORIGIN, 2, defaultCropOrigin, - TIFF_IFD_0), env, TAG_DEFAULTCROPORIGIN); + TIFF_IFD_0), env, TAG_DEFAULTCROPORIGIN, writer); BAIL_IF_INVALID(writer->addEntry(TAG_DEFAULTCROPSIZE, 2, defaultCropSize, - TIFF_IFD_0), env, TAG_DEFAULTCROPSIZE); + TIFF_IFD_0), env, TAG_DEFAULTCROPSIZE, writer); } } @@ -742,21 +1290,26 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt BAIL_IF_INVALID(writer->addEntry(TAG_UNIQUECAMERAMODEL, cameraModel.size() + 1, reinterpret_cast<const uint8_t*>(cameraModel.string()), TIFF_IFD_0), env, - TAG_UNIQUECAMERAMODEL); + TAG_UNIQUECAMERAMODEL, writer); } { // Setup opcode List 2 camera_metadata_entry entry1 = characteristics.find(ANDROID_LENS_INFO_SHADING_MAP_SIZE); - BAIL_IF_EMPTY(entry1, env, TAG_OPCODELIST2); - uint32_t lsmWidth = static_cast<uint32_t>(entry1.data.i32[0]); - uint32_t lsmHeight = static_cast<uint32_t>(entry1.data.i32[1]); + + uint32_t lsmWidth = 0; + uint32_t lsmHeight = 0; + + if (entry1.count != 0) { + lsmWidth = static_cast<uint32_t>(entry1.data.i32[0]); + lsmHeight = static_cast<uint32_t>(entry1.data.i32[1]); + } camera_metadata_entry entry2 = results.find(ANDROID_STATISTICS_LENS_SHADING_MAP); - BAIL_IF_EMPTY(entry2, env, TAG_OPCODELIST2); - if (entry2.count == lsmWidth * lsmHeight * 4) { + + if (entry2.count > 0 && entry2.count == lsmWidth * lsmHeight * 4) { OpcodeListBuilder builder; status_t err = builder.addGainMapsForMetadata(lsmWidth, @@ -773,7 +1326,7 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt err = builder.buildOpList(opcodeListBuf); if (err == OK) { BAIL_IF_INVALID(writer->addEntry(TAG_OPCODELIST2, listSize, opcodeListBuf, - TIFF_IFD_0), env, TAG_OPCODELIST2); + TIFF_IFD_0), env, TAG_OPCODELIST2, writer); } else { ALOGE("%s: Could not build Lens shading map opcode.", __FUNCTION__); jniThrowRuntimeException(env, "failed to construct lens shading map opcode."); @@ -783,138 +1336,505 @@ static void DngCreator_init(JNIEnv* env, jobject thiz, jobject characteristicsPt jniThrowRuntimeException(env, "failed to add lens shading map."); } } else { - ALOGW("%s: Lens shading map not present in results, skipping...", __FUNCTION__); + ALOGW("%s: No lens shading map found in result metadata. Image quality may be reduced.", + __FUNCTION__); } } - DngCreator_setCreator(env, thiz, writer); + DngCreator_setNativeContext(env, thiz, nativeContext); } static void DngCreator_destroy(JNIEnv* env, jobject thiz) { ALOGV("%s:", __FUNCTION__); - DngCreator_setCreator(env, thiz, NULL); + DngCreator_setNativeContext(env, thiz, NULL); } -static void DngCreator_nativeSetOrientation(JNIEnv* env, jobject thiz) { +static void DngCreator_nativeSetOrientation(JNIEnv* env, jobject thiz, jint orient) { ALOGV("%s:", __FUNCTION__); - jniThrowRuntimeException(env, "nativeSetOrientation is not implemented"); -} -static void DngCreator_nativeSetThumbnailBitmap(JNIEnv* env, jobject thiz, jobject bitmap) { - ALOGV("%s:", __FUNCTION__); - jniThrowRuntimeException(env, "nativeSetThumbnailBitmap is not implemented"); + TiffWriter* writer = DngCreator_getCreator(env, thiz); + if (writer == NULL) { + ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); + jniThrowException(env, "java/lang/AssertionError", + "setOrientation called with uninitialized DngCreator"); + return; + } + + uint16_t orientation = static_cast<uint16_t>(orient); + BAIL_IF_INVALID(writer->addEntry(TAG_ORIENTATION, 1, &orientation, TIFF_IFD_0), env, + TAG_ORIENTATION, writer); + + // Set main image orientation also if in a separate IFD + if (writer->hasIfd(TIFF_IFD_SUB1)) { + BAIL_IF_INVALID(writer->addEntry(TAG_ORIENTATION, 1, &orientation, TIFF_IFD_SUB1), env, + TAG_ORIENTATION, writer); + } } -static void DngCreator_nativeSetThumbnailImage(JNIEnv* env, jobject thiz, jint width, jint height, - jobject yBuffer, jint yRowStride, jint yPixStride, jobject uBuffer, jint uRowStride, - jint uPixStride, jobject vBuffer, jint vRowStride, jint vPixStride) { +static void DngCreator_nativeSetDescription(JNIEnv* env, jobject thiz, jstring description) { ALOGV("%s:", __FUNCTION__); - jniThrowRuntimeException(env, "nativeSetThumbnailImage is not implemented"); + + TiffWriter* writer = DngCreator_getCreator(env, thiz); + if (writer == NULL) { + ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); + jniThrowException(env, "java/lang/AssertionError", + "setDescription called with uninitialized DngCreator"); + return; + } + + const char* desc = env->GetStringUTFChars(description, NULL); + size_t len = strlen(desc) + 1; + + if (writer->addEntry(TAG_IMAGEDESCRIPTION, len, + reinterpret_cast<const uint8_t*>(desc), TIFF_IFD_0) != OK) { + jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", + "Invalid metadata for tag %x", TAG_IMAGEDESCRIPTION); + } + + env->ReleaseStringUTFChars(description, desc); } -static void DngCreator_nativeWriteImage(JNIEnv* env, jobject thiz, jobject outStream, jint width, - jint height, jobject inBuffer, jint rowStride, jint pixStride) { +static void DngCreator_nativeSetGpsTags(JNIEnv* env, jobject thiz, jintArray latTag, jstring latRef, + jintArray longTag, jstring longRef, jstring dateTag, jintArray timeTag) { ALOGV("%s:", __FUNCTION__); - sp<JniOutputStream> out = new JniOutputStream(env, outStream); - if(env->ExceptionCheck()) { - ALOGE("%s: Could not allocate buffers for output stream", __FUNCTION__); + TiffWriter* writer = DngCreator_getCreator(env, thiz); + if (writer == NULL) { + ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); + jniThrowException(env, "java/lang/AssertionError", + "setGpsTags called with uninitialized DngCreator"); return; } - uint8_t* pixelBytes = reinterpret_cast<uint8_t*>(env->GetDirectBufferAddress(inBuffer)); - if (pixelBytes == NULL) { - ALOGE("%s: Could not get native byte buffer", __FUNCTION__); - jniThrowException(env, "java/lang/IllegalArgumentException", "Invalid bytebuffer"); + if (!writer->hasIfd(TIFF_IFD_GPSINFO)) { + if (writer->addSubIfd(TIFF_IFD_0, TIFF_IFD_GPSINFO, TiffWriter::GPSINFO) != OK) { + ALOGE("%s: Failed to add GpsInfo IFD %u to IFD %u", __FUNCTION__, TIFF_IFD_GPSINFO, + TIFF_IFD_0); + jniThrowException(env, "java/lang/IllegalStateException", "Failed to add GPSINFO"); + return; + } + } + + const jsize GPS_VALUE_LENGTH = 6; + jsize latLen = env->GetArrayLength(latTag); + jsize longLen = env->GetArrayLength(longTag); + jsize timeLen = env->GetArrayLength(timeTag); + if (latLen != GPS_VALUE_LENGTH) { + jniThrowException(env, "java/lang/IllegalArgumentException", + "invalid latitude tag length"); + return; + } else if (longLen != GPS_VALUE_LENGTH) { + jniThrowException(env, "java/lang/IllegalArgumentException", + "invalid longitude tag length"); return; + } else if (timeLen != GPS_VALUE_LENGTH) { + jniThrowException(env, "java/lang/IllegalArgumentException", + "invalid time tag length"); + return; + } + + uint32_t latitude[GPS_VALUE_LENGTH]; + uint32_t longitude[GPS_VALUE_LENGTH]; + uint32_t timestamp[GPS_VALUE_LENGTH]; + + env->GetIntArrayRegion(latTag, 0, static_cast<jsize>(GPS_VALUE_LENGTH), + reinterpret_cast<jint*>(&latitude)); + env->GetIntArrayRegion(longTag, 0, static_cast<jsize>(GPS_VALUE_LENGTH), + reinterpret_cast<jint*>(&longitude)); + env->GetIntArrayRegion(timeTag, 0, static_cast<jsize>(GPS_VALUE_LENGTH), + reinterpret_cast<jint*>(×tamp)); + + const jsize GPS_REF_LENGTH = 2; + const jsize GPS_DATE_LENGTH = 11; + uint8_t latitudeRef[GPS_REF_LENGTH]; + uint8_t longitudeRef[GPS_REF_LENGTH]; + uint8_t date[GPS_DATE_LENGTH]; + + env->GetStringUTFRegion(latRef, 0, 1, reinterpret_cast<char*>(&latitudeRef)); + latitudeRef[GPS_REF_LENGTH - 1] = '\0'; + env->GetStringUTFRegion(longRef, 0, 1, reinterpret_cast<char*>(&longitudeRef)); + longitudeRef[GPS_REF_LENGTH - 1] = '\0'; + + env->GetStringUTFRegion(dateTag, 0, GPS_DATE_LENGTH - 1, reinterpret_cast<char*>(&date)); + date[GPS_DATE_LENGTH - 1] = '\0'; + + { + uint8_t version[] = {2, 3, 0, 0}; + BAIL_IF_INVALID(writer->addEntry(TAG_GPSVERSIONID, 4, version, + TIFF_IFD_GPSINFO), env, TAG_GPSVERSIONID, writer); + } + + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSLATITUDEREF, GPS_REF_LENGTH, latitudeRef, + TIFF_IFD_GPSINFO), env, TAG_GPSLATITUDEREF, writer); + } + + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSLONGITUDEREF, GPS_REF_LENGTH, longitudeRef, + TIFF_IFD_GPSINFO), env, TAG_GPSLONGITUDEREF, writer); } + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSLATITUDE, 3, latitude, + TIFF_IFD_GPSINFO), env, TAG_GPSLATITUDE, writer); + } + + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSLONGITUDE, 3, longitude, + TIFF_IFD_GPSINFO), env, TAG_GPSLONGITUDE, writer); + } + + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSTIMESTAMP, 3, timestamp, + TIFF_IFD_GPSINFO), env, TAG_GPSTIMESTAMP, writer); + } + + { + BAIL_IF_INVALID(writer->addEntry(TAG_GPSDATESTAMP, GPS_DATE_LENGTH, date, + TIFF_IFD_GPSINFO), env, TAG_GPSDATESTAMP, writer); + } +} + +static void DngCreator_nativeSetThumbnail(JNIEnv* env, jobject thiz, jobject buffer, jint width, + jint height) { + ALOGV("%s:", __FUNCTION__); + + NativeContext* context = DngCreator_getNativeContext(env, thiz); TiffWriter* writer = DngCreator_getCreator(env, thiz); - if (writer == NULL) { + if (writer == NULL || context == NULL) { ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); jniThrowException(env, "java/lang/AssertionError", - "Write called with uninitialized DngCreator"); + "setThumbnail called with uninitialized DngCreator"); return; } - // TODO: handle lens shading map, etc. conversions for other raw buffer sizes. - uint32_t metadataWidth = *(writer->getEntry(TAG_IMAGEWIDTH, TIFF_IFD_0)->getData<uint32_t>()); - uint32_t metadataHeight = *(writer->getEntry(TAG_IMAGELENGTH, TIFF_IFD_0)->getData<uint32_t>()); - if (metadataWidth != width) { - jniThrowExceptionFmt(env, "java/lang/IllegalStateException", \ - "Metadata width %d doesn't match image width %d", metadataWidth, width); + + size_t fullSize = width * height * BYTES_PER_RGB_PIXEL; + jlong capacity = env->GetDirectBufferCapacity(buffer); + if (capacity != fullSize) { + jniThrowExceptionFmt(env, "java/lang/AssertionError", + "Invalid size %d for thumbnail, expected size was %d", + capacity, fullSize); return; } - if (metadataHeight != height) { - jniThrowExceptionFmt(env, "java/lang/IllegalStateException", \ - "Metadata height %d doesn't match image height %d", metadataHeight, height); + uint8_t* pixelBytes = reinterpret_cast<uint8_t*>(env->GetDirectBufferAddress(buffer)); + if (pixelBytes == NULL) { + ALOGE("%s: Could not get native ByteBuffer", __FUNCTION__); + jniThrowException(env, "java/lang/IllegalArgumentException", "Invalid ByteBuffer"); return; } - uint32_t stripOffset = writer->getTotalSize(); + if (!writer->hasIfd(TIFF_IFD_SUB1)) { + if (writer->addSubIfd(TIFF_IFD_0, TIFF_IFD_SUB1) != OK) { + ALOGE("%s: Failed to add SubIFD %u to IFD %u", __FUNCTION__, TIFF_IFD_SUB1, + TIFF_IFD_0); + jniThrowException(env, "java/lang/IllegalStateException", "Failed to add SubIFD"); + return; + } - BAIL_IF_INVALID(writer->addEntry(TAG_STRIPOFFSETS, 1, &stripOffset, TIFF_IFD_0), env, - TAG_STRIPOFFSETS); + Vector<uint16_t> tagsToMove; + tagsToMove.add(TAG_ORIENTATION); + tagsToMove.add(TAG_NEWSUBFILETYPE); + tagsToMove.add(TAG_BITSPERSAMPLE); + tagsToMove.add(TAG_COMPRESSION); + tagsToMove.add(TAG_IMAGEWIDTH); + tagsToMove.add(TAG_IMAGELENGTH); + tagsToMove.add(TAG_PHOTOMETRICINTERPRETATION); + tagsToMove.add(TAG_BLACKLEVEL); + tagsToMove.add(TAG_BLACKLEVELREPEATDIM); + tagsToMove.add(TAG_SAMPLESPERPIXEL); + tagsToMove.add(TAG_PLANARCONFIGURATION); + tagsToMove.add(TAG_CFAREPEATPATTERNDIM); + tagsToMove.add(TAG_CFAPATTERN); + tagsToMove.add(TAG_CFAPLANECOLOR); + tagsToMove.add(TAG_CFALAYOUT); + tagsToMove.add(TAG_XRESOLUTION); + tagsToMove.add(TAG_YRESOLUTION); + tagsToMove.add(TAG_RESOLUTIONUNIT); + tagsToMove.add(TAG_WHITELEVEL); + tagsToMove.add(TAG_DEFAULTSCALE); + tagsToMove.add(TAG_ROWSPERSTRIP); + tagsToMove.add(TAG_STRIPBYTECOUNTS); + tagsToMove.add(TAG_STRIPOFFSETS); + tagsToMove.add(TAG_DEFAULTCROPORIGIN); + tagsToMove.add(TAG_DEFAULTCROPSIZE); + tagsToMove.add(TAG_OPCODELIST2); + + if (moveEntries(writer, TIFF_IFD_0, TIFF_IFD_SUB1, tagsToMove) != OK) { + jniThrowException(env, "java/lang/IllegalStateException", "Failed to move entries"); + return; + } - if (writer->write(out.get()) != OK) { - if (!env->ExceptionCheck()) { - jniThrowException(env, "java/io/IOException", "Failed to write metadata"); + // Make sure both IFDs get the same orientation tag + sp<TiffEntry> orientEntry = writer->getEntry(TAG_ORIENTATION, TIFF_IFD_SUB1); + if (orientEntry != NULL) { + writer->addEntry(orientEntry, TIFF_IFD_0); } + } + + // Setup thumbnail tags + + { + // Set photometric interpretation + uint16_t interpretation = 2; // RGB + BAIL_IF_INVALID(writer->addEntry(TAG_PHOTOMETRICINTERPRETATION, 1, &interpretation, + TIFF_IFD_0), env, TAG_PHOTOMETRICINTERPRETATION, writer); + } + + { + // Set planar configuration + uint16_t config = 1; // Chunky + BAIL_IF_INVALID(writer->addEntry(TAG_PLANARCONFIGURATION, 1, &config, TIFF_IFD_0), + env, TAG_PLANARCONFIGURATION, writer); + } + + { + // Set samples per pixel + uint16_t samples = SAMPLES_PER_RGB_PIXEL; + BAIL_IF_INVALID(writer->addEntry(TAG_SAMPLESPERPIXEL, 1, &samples, TIFF_IFD_0), + env, TAG_SAMPLESPERPIXEL, writer); + } + + { + // Set bits per sample + uint16_t bits = BITS_PER_RGB_SAMPLE; + BAIL_IF_INVALID(writer->addEntry(TAG_BITSPERSAMPLE, 1, &bits, TIFF_IFD_0), env, + TAG_BITSPERSAMPLE, writer); + } + + { + // Set subfiletype + uint32_t subfileType = 1; // Thumbnail image + BAIL_IF_INVALID(writer->addEntry(TAG_NEWSUBFILETYPE, 1, &subfileType, TIFF_IFD_0), env, + TAG_NEWSUBFILETYPE, writer); + } + + { + // Set compression + uint16_t compression = 1; // None + BAIL_IF_INVALID(writer->addEntry(TAG_COMPRESSION, 1, &compression, TIFF_IFD_0), env, + TAG_COMPRESSION, writer); + } + + { + // Set dimensions + uint32_t uWidth = static_cast<uint32_t>(width); + uint32_t uHeight = static_cast<uint32_t>(height); + BAIL_IF_INVALID(writer->addEntry(TAG_IMAGEWIDTH, 1, &uWidth, TIFF_IFD_0), env, + TAG_IMAGEWIDTH, writer); + BAIL_IF_INVALID(writer->addEntry(TAG_IMAGELENGTH, 1, &uHeight, TIFF_IFD_0), env, + TAG_IMAGELENGTH, writer); + } + + { + // x resolution + uint32_t xres[] = { 72, 1 }; // default 72 ppi + BAIL_IF_INVALID(writer->addEntry(TAG_XRESOLUTION, 1, xres, TIFF_IFD_0), + env, TAG_XRESOLUTION, writer); + + // y resolution + uint32_t yres[] = { 72, 1 }; // default 72 ppi + BAIL_IF_INVALID(writer->addEntry(TAG_YRESOLUTION, 1, yres, TIFF_IFD_0), + env, TAG_YRESOLUTION, writer); + + uint16_t unit = 2; // inches + BAIL_IF_INVALID(writer->addEntry(TAG_RESOLUTIONUNIT, 1, &unit, TIFF_IFD_0), + env, TAG_RESOLUTIONUNIT, writer); + } + + { + // Setup data strips + if (writer->addStrip(TIFF_IFD_0) != OK) { + ALOGE("%s: Could not setup thumbnail strip tags.", __FUNCTION__); + jniThrowException(env, "java/lang/IllegalStateException", + "Failed to setup thumbnail strip tags."); + return; + } + if (writer->addStrip(TIFF_IFD_SUB1) != OK) { + ALOGE("%s: Could not main image strip tags.", __FUNCTION__); + jniThrowException(env, "java/lang/IllegalStateException", + "Failed to setup main image strip tags."); + return; + } + } + + if (!context->setThumbnail(pixelBytes, width, height)) { + jniThrowException(env, "java/lang/IllegalStateException", + "Failed to set thumbnail."); return; } +} - size_t fullSize = rowStride * height; - jlong capacity = env->GetDirectBufferCapacity(inBuffer); - if (capacity < 0 || fullSize > capacity) { - jniThrowExceptionFmt(env, "java/lang/IllegalStateException", - "Invalid size %d for Image, size given in metadata is %d at current stride", - capacity, fullSize); +// TODO: Refactor out common preamble for the two nativeWrite methods. +static void DngCreator_nativeWriteImage(JNIEnv* env, jobject thiz, jobject outStream, jint width, + jint height, jobject inBuffer, jint rowStride, jint pixStride, jlong offset, + jboolean isDirect) { + ALOGV("%s:", __FUNCTION__); + ALOGV("%s: nativeWriteImage called with: width=%d, height=%d, rowStride=%d, pixStride=%d," + " offset=%lld", __FUNCTION__, width, height, rowStride, pixStride, offset); + uint32_t rStride = static_cast<uint32_t>(rowStride); + uint32_t pStride = static_cast<uint32_t>(pixStride); + uint32_t uWidth = static_cast<uint32_t>(width); + uint32_t uHeight = static_cast<uint32_t>(height); + uint64_t uOffset = static_cast<uint64_t>(offset); + + sp<JniOutputStream> out = new JniOutputStream(env, outStream); + if(env->ExceptionCheck()) { + ALOGE("%s: Could not allocate buffers for output stream", __FUNCTION__); return; } - if (pixStride == BYTES_PER_SAMPLE && rowStride == width * BYTES_PER_SAMPLE) { - if (out->write(pixelBytes, 0, fullSize) != OK || env->ExceptionCheck()) { - if (!env->ExceptionCheck()) { - jniThrowException(env, "java/io/IOException", "Failed to write pixel data"); - } + TiffWriter* writer = DngCreator_getCreator(env, thiz); + NativeContext* context = DngCreator_getNativeContext(env, thiz); + if (writer == NULL || context == NULL) { + ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); + jniThrowException(env, "java/lang/AssertionError", + "Write called with uninitialized DngCreator"); + return; + } + + // Validate DNG header + if (!validateDngHeader(env, writer, width, height)) { + return; + } + + sp<JniInputByteBuffer> inBuf; + Vector<StripSource*> sources; + sp<DirectStripSource> thumbnailSource; + uint32_t targetIfd = TIFF_IFD_0; + + bool hasThumbnail = writer->hasIfd(TIFF_IFD_SUB1); + + if (hasThumbnail) { + ALOGV("%s: Adding thumbnail strip sources.", __FUNCTION__); + uint32_t bytesPerPixel = SAMPLES_PER_RGB_PIXEL * BYTES_PER_RGB_SAMPLE; + uint32_t thumbWidth = context->getThumbnailWidth(); + thumbnailSource = new DirectStripSource(env, context->getThumbnail(), TIFF_IFD_0, + thumbWidth, context->getThumbnailHeight(), bytesPerPixel, + bytesPerPixel * thumbWidth, /*offset*/0, BYTES_PER_RGB_SAMPLE, + SAMPLES_PER_RGB_PIXEL); + sources.add(thumbnailSource.get()); + targetIfd = TIFF_IFD_SUB1; + } + + if (isDirect) { + size_t fullSize = rStride * uHeight; + jlong capacity = env->GetDirectBufferCapacity(inBuffer); + if (capacity < 0 || fullSize + uOffset > static_cast<uint64_t>(capacity)) { + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Invalid size %d for Image, size given in metadata is %d at current stride", + capacity, fullSize); return; } - } else if (pixStride == BYTES_PER_SAMPLE) { - for (size_t i = 0; i < height; ++i) { - if (out->write(pixelBytes, i * rowStride, pixStride * width) != OK || - env->ExceptionCheck()) { - if (!env->ExceptionCheck()) { - jniThrowException(env, "java/io/IOException", "Failed to write pixel data"); - } - return; + + uint8_t* pixelBytes = reinterpret_cast<uint8_t*>(env->GetDirectBufferAddress(inBuffer)); + if (pixelBytes == NULL) { + ALOGE("%s: Could not get native ByteBuffer", __FUNCTION__); + jniThrowException(env, "java/lang/IllegalArgumentException", "Invalid ByteBuffer"); + return; + } + + ALOGV("%s: Using direct-type strip source.", __FUNCTION__); + DirectStripSource stripSource(env, pixelBytes, targetIfd, uWidth, uHeight, pStride, + rStride, uOffset, BYTES_PER_SAMPLE, SAMPLES_PER_RAW_PIXEL); + sources.add(&stripSource); + + status_t ret = OK; + if ((ret = writer->write(out.get(), sources.editArray(), sources.size())) != OK) { + ALOGE("%s: write failed with error %d.", __FUNCTION__, ret); + if (!env->ExceptionCheck()) { + jniThrowExceptionFmt(env, "java/io/IOException", + "Encountered error %d while writing file.", ret); } + return; } } else { - for (size_t i = 0; i < height; ++i) { - for (size_t j = 0; j < width; ++j) { - if (out->write(pixelBytes, i * rowStride + j * pixStride, - BYTES_PER_SAMPLE) != OK || !env->ExceptionCheck()) { - if (env->ExceptionCheck()) { - jniThrowException(env, "java/io/IOException", "Failed to write pixel data"); - } - return; - } + inBuf = new JniInputByteBuffer(env, inBuffer); + + ALOGV("%s: Using input-type strip source.", __FUNCTION__); + InputStripSource stripSource(env, *inBuf, targetIfd, uWidth, uHeight, pStride, + rStride, uOffset, BYTES_PER_SAMPLE, SAMPLES_PER_RAW_PIXEL); + sources.add(&stripSource); + + status_t ret = OK; + if ((ret = writer->write(out.get(), sources.editArray(), sources.size())) != OK) { + ALOGE("%s: write failed with error %d.", __FUNCTION__, ret); + if (!env->ExceptionCheck()) { + jniThrowExceptionFmt(env, "java/io/IOException", + "Encountered error %d while writing file.", ret); } + return; } } - -} - -static void DngCreator_nativeWriteByteBuffer(JNIEnv* env, jobject thiz, jobject outStream, - jobject rawBuffer, jlong offset) { - ALOGV("%s:", __FUNCTION__); - jniThrowRuntimeException(env, "nativeWriteByteBuffer is not implemented."); } static void DngCreator_nativeWriteInputStream(JNIEnv* env, jobject thiz, jobject outStream, - jobject inStream, jlong offset) { + jobject inStream, jint width, jint height, jlong offset) { ALOGV("%s:", __FUNCTION__); - jniThrowRuntimeException(env, "nativeWriteInputStream is not implemented."); + + uint32_t rowStride = width * BYTES_PER_SAMPLE; + uint32_t pixStride = BYTES_PER_SAMPLE; + uint32_t uWidth = static_cast<uint32_t>(width); + uint32_t uHeight = static_cast<uint32_t>(height); + uint64_t uOffset = static_cast<uint32_t>(offset); + + ALOGV("%s: nativeWriteInputStream called with: width=%d, height=%d, rowStride=%u," + "pixStride=%u, offset=%lld", __FUNCTION__, width, height, rowStride, pixStride, + offset); + + sp<JniOutputStream> out = new JniOutputStream(env, outStream); + if(env->ExceptionCheck()) { + ALOGE("%s: Could not allocate buffers for output stream", __FUNCTION__); + return; + } + + TiffWriter* writer = DngCreator_getCreator(env, thiz); + NativeContext* context = DngCreator_getNativeContext(env, thiz); + if (writer == NULL || context == NULL) { + ALOGE("%s: Failed to initialize DngCreator", __FUNCTION__); + jniThrowException(env, "java/lang/AssertionError", + "Write called with uninitialized DngCreator"); + return; + } + + // Validate DNG header + if (!validateDngHeader(env, writer, width, height)) { + return; + } + + sp<DirectStripSource> thumbnailSource; + uint32_t targetIfd = TIFF_IFD_0; + bool hasThumbnail = writer->hasIfd(TIFF_IFD_SUB1); + Vector<StripSource*> sources; + + if (hasThumbnail) { + ALOGV("%s: Adding thumbnail strip sources.", __FUNCTION__); + uint32_t bytesPerPixel = SAMPLES_PER_RGB_PIXEL * BYTES_PER_RGB_SAMPLE; + uint32_t width = context->getThumbnailWidth(); + thumbnailSource = new DirectStripSource(env, context->getThumbnail(), TIFF_IFD_0, + width, context->getThumbnailHeight(), bytesPerPixel, + bytesPerPixel * width, /*offset*/0, BYTES_PER_RGB_SAMPLE, + SAMPLES_PER_RGB_PIXEL); + sources.add(thumbnailSource.get()); + targetIfd = TIFF_IFD_SUB1; + } + + sp<JniInputStream> in = new JniInputStream(env, inStream); + + ALOGV("%s: Using input-type strip source.", __FUNCTION__); + InputStripSource stripSource(env, *in, targetIfd, uWidth, uHeight, pixStride, + rowStride, uOffset, BYTES_PER_SAMPLE, SAMPLES_PER_RAW_PIXEL); + sources.add(&stripSource); + + status_t ret = OK; + if ((ret = writer->write(out.get(), sources.editArray(), sources.size())) != OK) { + ALOGE("%s: write failed with error %d.", __FUNCTION__, ret); + if (!env->ExceptionCheck()) { + jniThrowExceptionFmt(env, "java/io/IOException", + "Encountered error %d while writing file.", ret); + } + return; + } } } /*extern "C" */ @@ -926,16 +1846,13 @@ static JNINativeMethod gDngCreatorMethods[] = { (void*) DngCreator_init}, {"nativeDestroy", "()V", (void*) DngCreator_destroy}, {"nativeSetOrientation", "(I)V", (void*) DngCreator_nativeSetOrientation}, - {"nativeSetThumbnailBitmap","(Landroid/graphics/Bitmap;)V", - (void*) DngCreator_nativeSetThumbnailBitmap}, - {"nativeSetThumbnailImage", - "(IILjava/nio/ByteBuffer;IILjava/nio/ByteBuffer;IILjava/nio/ByteBuffer;II)V", - (void*) DngCreator_nativeSetThumbnailImage}, - {"nativeWriteImage", "(Ljava/io/OutputStream;IILjava/nio/ByteBuffer;II)V", + {"nativeSetDescription", "(Ljava/lang/String;)V", (void*) DngCreator_nativeSetDescription}, + {"nativeSetGpsTags", "([ILjava/lang/String;[ILjava/lang/String;Ljava/lang/String;[I)V", + (void*) DngCreator_nativeSetGpsTags}, + {"nativeSetThumbnail","(Ljava/nio/ByteBuffer;II)V", (void*) DngCreator_nativeSetThumbnail}, + {"nativeWriteImage", "(Ljava/io/OutputStream;IILjava/nio/ByteBuffer;IIJZ)V", (void*) DngCreator_nativeWriteImage}, - {"nativeWriteByteBuffer", "(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;J)V", - (void*) DngCreator_nativeWriteByteBuffer}, - {"nativeWriteInputStream", "(Ljava/io/OutputStream;Ljava/io/InputStream;J)V", + {"nativeWriteInputStream", "(Ljava/io/OutputStream;Ljava/io/InputStream;IIJ)V", (void*) DngCreator_nativeWriteInputStream}, }; diff --git a/core/jni/android_hardware_camera2_legacy_PerfMeasurement.cpp b/core/jni/android_hardware_camera2_legacy_PerfMeasurement.cpp new file mode 100644 index 0000000..93473a5 --- /dev/null +++ b/core/jni/android_hardware_camera2_legacy_PerfMeasurement.cpp @@ -0,0 +1,335 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#define LOG_TAG "Camera2-Legacy-PerfMeasurement-JNI" +#include <utils/Log.h> +#include <utils/Errors.h> +#include <utils/Trace.h> +#include <utils/Vector.h> + +#include "jni.h" +#include "JNIHelp.h" +#include "android_runtime/AndroidRuntime.h" + +#include <ui/GraphicBuffer.h> +#include <system/window.h> +#include <GLES2/gl2.h> +#include <GLES2/gl2ext.h> + +using namespace android; + +// fully-qualified class name +#define PERF_MEASUREMENT_CLASS_NAME "android/hardware/camera2/legacy/PerfMeasurement" + +/** GL utility methods copied from com_google_android_gles_jni_GLImpl.cpp */ + +// Check if the extension at the head of pExtensions is pExtension. Note that pExtensions is +// terminated by either 0 or space, while pExtension is terminated by 0. + +static bool +extensionEqual(const GLubyte* pExtensions, const GLubyte* pExtension) { + while (true) { + char a = *pExtensions++; + char b = *pExtension++; + bool aEnd = a == '\0' || a == ' '; + bool bEnd = b == '\0'; + if (aEnd || bEnd) { + return aEnd == bEnd; + } + if (a != b) { + return false; + } + } +} + +static const GLubyte* +nextExtension(const GLubyte* pExtensions) { + while (true) { + char a = *pExtensions++; + if (a == '\0') { + return pExtensions-1; + } else if ( a == ' ') { + return pExtensions; + } + } +} + +static bool +checkForExtension(const GLubyte* pExtensions, const GLubyte* pExtension) { + for (; *pExtensions != '\0'; pExtensions = nextExtension(pExtensions)) { + if (extensionEqual(pExtensions, pExtension)) { + return true; + } + } + return false; +} + +/** End copied GL utility methods */ + +bool checkGlError(JNIEnv* env) { + int error; + if ((error = glGetError()) != GL_NO_ERROR) { + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "GLES20 error: 0x%d", error); + return true; + } + return false; +} + +/** + * Asynchronous low-overhead GL performance measurement using + * http://www.khronos.org/registry/gles/extensions/EXT/EXT_disjoint_timer_query.txt + * + * Measures the duration of GPU processing for a set of GL commands, delivering + * the measurement asynchronously once processing completes. + * + * All calls must come from a single thread with a valid GL context active. + **/ +class PerfMeasurementContext { + private: + Vector<GLuint> mTimingQueries; + size_t mTimingStartIndex; + size_t mTimingEndIndex; + size_t mTimingQueryIndex; + size_t mFreeQueries; + + bool mInitDone; + public: + + /** + * maxQueryCount should be a conservative estimate of how many query objects + * will be active at once, which is a function of the GPU's level of + * pipelining and the frequency of queries. + */ + PerfMeasurementContext(size_t maxQueryCount): + mTimingStartIndex(0), + mTimingEndIndex(0), + mTimingQueryIndex(0) { + mTimingQueries.resize(maxQueryCount); + mFreeQueries = maxQueryCount; + mInitDone = false; + } + + int getMaxQueryCount() { + return mTimingQueries.size(); + } + + /** + * Start a measurement period using the next available query object. + * Returns INVALID_OPERATION if called multiple times in a row, + * and BAD_VALUE if no more query objects are available. + */ + int startGlTimer() { + // Lazy init of queries to avoid needing GL context during construction + if (!mInitDone) { + glGenQueriesEXT(mTimingQueries.size(), mTimingQueries.editArray()); + mInitDone = true; + } + + if (mTimingEndIndex != mTimingStartIndex) { + return INVALID_OPERATION; + } + + if (mFreeQueries == 0) { + return BAD_VALUE; + } + + glBeginQueryEXT(GL_TIME_ELAPSED_EXT, mTimingQueries[mTimingStartIndex]); + + mTimingStartIndex = (mTimingStartIndex + 1) % mTimingQueries.size(); + mFreeQueries--; + + return OK; + } + + /** + * Finish the current measurement period + * Returns INVALID_OPERATION if called before any startGLTimer calls + * or if called multiple times in a row. + */ + int stopGlTimer() { + size_t nextEndIndex = (mTimingEndIndex + 1) % mTimingQueries.size(); + if (nextEndIndex != mTimingStartIndex) { + return INVALID_OPERATION; + } + glEndQueryEXT(GL_TIME_ELAPSED_EXT); + + mTimingEndIndex = nextEndIndex; + + return OK; + } + + static const nsecs_t NO_DURATION_YET = -1L; + static const nsecs_t FAILED_MEASUREMENT = -2L; + + /** + * Get the next available duration measurement. + * + * Returns NO_DURATION_YET if no new measurement is available, + * and FAILED_MEASUREMENT if an error occurred during the next + * measurement period. + * + * Otherwise returns a positive number of nanoseconds measuring the + * duration of the oldest completed query. + */ + nsecs_t getNextGlDuration() { + if (!mInitDone) { + // No start/stop called yet + return NO_DURATION_YET; + } + + GLint available; + glGetQueryObjectivEXT(mTimingQueries[mTimingQueryIndex], + GL_QUERY_RESULT_AVAILABLE_EXT, &available); + if (!available) { + return NO_DURATION_YET; + } + + GLint64 duration = FAILED_MEASUREMENT; + GLint disjointOccurred; + glGetIntegerv(GL_GPU_DISJOINT_EXT, &disjointOccurred); + + if (!disjointOccurred) { + glGetQueryObjecti64vEXT(mTimingQueries[mTimingQueryIndex], + GL_QUERY_RESULT_EXT, + &duration); + } + + mTimingQueryIndex = (mTimingQueryIndex + 1) % mTimingQueries.size(); + mFreeQueries++; + + return static_cast<nsecs_t>(duration); + } + + static bool isMeasurementSupported() { + const GLubyte* extensions = glGetString(GL_EXTENSIONS); + return checkForExtension(extensions, + reinterpret_cast<const GLubyte*>("GL_EXT_disjoint_timer_query")); + } + +}; + +PerfMeasurementContext* getContext(jlong context) { + return reinterpret_cast<PerfMeasurementContext*>(context); +} + +extern "C" { + +static jlong PerfMeasurement_nativeCreateContext(JNIEnv* env, jobject thiz, + jint maxQueryCount) { + PerfMeasurementContext *context = new PerfMeasurementContext(maxQueryCount); + return reinterpret_cast<jlong>(context); +} + +static void PerfMeasurement_nativeDeleteContext(JNIEnv* env, jobject thiz, + jlong contextHandle) { + PerfMeasurementContext *context = getContext(contextHandle); + delete(context); +} + +static jboolean PerfMeasurement_nativeQuerySupport(JNIEnv* env, jobject thiz) { + bool supported = PerfMeasurementContext::isMeasurementSupported(); + checkGlError(env); + return static_cast<jboolean>(supported); +} + +static void PerfMeasurement_nativeStartGlTimer(JNIEnv* env, jobject thiz, + jlong contextHandle) { + + PerfMeasurementContext *context = getContext(contextHandle); + status_t err = context->startGlTimer(); + if (err != OK) { + switch (err) { + case INVALID_OPERATION: + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Mismatched start/end GL timing calls"); + return; + case BAD_VALUE: + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Too many timing queries in progress, max %d", + context->getMaxQueryCount()); + return; + default: + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Unknown error starting GL timing"); + return; + } + } + checkGlError(env); +} + +static void PerfMeasurement_nativeStopGlTimer(JNIEnv* env, jobject thiz, + jlong contextHandle) { + + PerfMeasurementContext *context = getContext(contextHandle); + status_t err = context->stopGlTimer(); + if (err != OK) { + switch (err) { + case INVALID_OPERATION: + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Mismatched start/end GL timing calls"); + return; + default: + jniThrowExceptionFmt(env, "java/lang/IllegalStateException", + "Unknown error ending GL timing"); + return; + } + } + checkGlError(env); +} + +static jlong PerfMeasurement_nativeGetNextGlDuration(JNIEnv* env, + jobject thiz, jlong contextHandle) { + PerfMeasurementContext *context = getContext(contextHandle); + nsecs_t duration = context->getNextGlDuration(); + + checkGlError(env); + return static_cast<jlong>(duration); +} + +} // extern "C" + +static JNINativeMethod gPerfMeasurementMethods[] = { + { "nativeCreateContext", + "(I)J", + (jlong *)PerfMeasurement_nativeCreateContext }, + { "nativeDeleteContext", + "(J)V", + (void *)PerfMeasurement_nativeDeleteContext }, + { "nativeQuerySupport", + "()Z", + (jboolean *)PerfMeasurement_nativeQuerySupport }, + { "nativeStartGlTimer", + "(J)V", + (void *)PerfMeasurement_nativeStartGlTimer }, + { "nativeStopGlTimer", + "(J)V", + (void *)PerfMeasurement_nativeStopGlTimer }, + { "nativeGetNextGlDuration", + "(J)J", + (jlong *)PerfMeasurement_nativeGetNextGlDuration } +}; + + +// Get all the required offsets in java class and register native functions +int register_android_hardware_camera2_legacy_PerfMeasurement(JNIEnv* env) +{ + // Register native functions + return AndroidRuntime::registerNativeMethods(env, + PERF_MEASUREMENT_CLASS_NAME, + gPerfMeasurementMethods, + NELEM(gPerfMeasurementMethods)); +} diff --git a/core/jni/android_net_NetUtils.cpp b/core/jni/android_net_NetUtils.cpp index 6f89800..a75d547 100644 --- a/core/jni/android_net_NetUtils.cpp +++ b/core/jni/android_net_NetUtils.cpp @@ -285,6 +285,11 @@ static jboolean android_net_utils_bindSocketToNetwork(JNIEnv *env, jobject thiz, return (jboolean) !setNetworkForSocket(netId, socket); } +static jboolean android_net_utils_protectFromVpn(JNIEnv *env, jobject thiz, jint socket) +{ + return (jboolean) !protectFromVpn(socket); +} + // ---------------------------------------------------------------------------- /* @@ -308,6 +313,7 @@ static JNINativeMethod gNetworkUtilMethods[] = { { "bindProcessToNetworkForHostResolution", "(I)Z", (void*) android_net_utils_bindProcessToNetworkForHostResolution }, { "unbindProcessToNetworkForHostResolution", "()Z", (void*) android_net_utils_unbindProcessToNetworkForHostResolution }, { "bindSocketToNetwork", "(II)Z", (void*) android_net_utils_bindSocketToNetwork }, + { "protectFromVpn", "(I)Z", (void*)android_net_utils_protectFromVpn }, }; int register_android_net_NetworkUtils(JNIEnv* env) diff --git a/core/jni/android_util_Process.cpp b/core/jni/android_util_Process.cpp index a6b65cc..aaa680f 100644 --- a/core/jni/android_util_Process.cpp +++ b/core/jni/android_util_Process.cpp @@ -24,6 +24,7 @@ #include <cutils/sched_policy.h> #include <utils/String8.h> #include <utils/Vector.h> +#include <processgroup/processgroup.h> #include <android_runtime/AndroidRuntime.h> @@ -1002,6 +1003,16 @@ jintArray android_os_Process_getPidsForCommands(JNIEnv* env, jobject clazz, return pidArray; } +jint android_os_Process_killProcessGroup(JNIEnv* env, jobject clazz, jint uid, jint pid) +{ + return killProcessGroup(uid, pid, SIGKILL); +} + +void android_os_Process_removeAllProcessGroups(JNIEnv* env, jobject clazz) +{ + return removeAllProcessGroups(); +} + static const JNINativeMethod methods[] = { {"getUidForName", "(Ljava/lang/String;)I", (void*)android_os_Process_getUidForName}, {"getGidForName", "(Ljava/lang/String;)I", (void*)android_os_Process_getGidForName}, @@ -1029,6 +1040,8 @@ static const JNINativeMethod methods[] = { {"getPss", "(I)J", (void*)android_os_Process_getPss}, {"getPidsForCommands", "([Ljava/lang/String;)[I", (void*)android_os_Process_getPidsForCommands}, //{"setApplicationObject", "(Landroid/os/IBinder;)V", (void*)android_os_Process_setApplicationObject}, + {"killProcessGroup", "(II)I", (void*)android_os_Process_killProcessGroup}, + {"removeAllProcessGroups", "()V", (void*)android_os_Process_removeAllProcessGroups}, }; const char* const kProcessPathName = "android/os/Process"; diff --git a/core/jni/com_android_internal_os_Zygote.cpp b/core/jni/com_android_internal_os_Zygote.cpp index 0cdddba..989b60e 100644 --- a/core/jni/com_android_internal_os_Zygote.cpp +++ b/core/jni/com_android_internal_os_Zygote.cpp @@ -41,6 +41,7 @@ #include <cutils/sched_policy.h> #include <utils/String8.h> #include <selinux/android.h> +#include <processgroup/processgroup.h> #include "android_runtime/AndroidRuntime.h" #include "JNIHelp.h" @@ -435,6 +436,14 @@ static pid_t ForkAndSpecializeCommon(JNIEnv* env, uid_t uid, gid_t gid, jintArra } } + if (!is_system_server) { + int rc = createProcessGroup(uid, getpid()); + if (rc != 0) { + ALOGE("createProcessGroup(%d, %d) failed: %s", uid, pid, strerror(-rc)); + RuntimeAbort(env); + } + } + SetGids(env, javaGids); SetRLimits(env, javaRlimits); diff --git a/core/res/res/drawable/popup_background_material.xml b/core/res/res/drawable/popup_background_material.xml index 9e50790..b1f0cf5 100644 --- a/core/res/res/drawable/popup_background_material.xml +++ b/core/res/res/drawable/popup_background_material.xml @@ -14,7 +14,12 @@ limitations under the License. --> -<nine-patch xmlns:android="http://schemas.android.com/apk/res/android" - android:src="@drawable/popup_background_mtrl_mult" - android:tint="?attr/colorBackground" - android:tintMode="multiply" /> +<shape xmlns:android="http://schemas.android.com/apk/res/android" + android:shape="rectangle"> + + <corners + android:radius="2dp" /> + <solid + android:color="?attr/colorBackground" /> + +</shape> diff --git a/core/res/res/values/attrs.xml b/core/res/res/values/attrs.xml index ea9e189..9438fcc 100644 --- a/core/res/res/values/attrs.xml +++ b/core/res/res/values/attrs.xml @@ -730,6 +730,9 @@ <attr name="actionBarTabTextStyle" format="reference" /> <attr name="actionOverflowButtonStyle" format="reference" /> <attr name="actionOverflowMenuStyle" format="reference" /> + <!-- Reference to a theme that should be used to inflate popups + shown by widgets in the action bar. --> + <attr name="actionBarPopupTheme" format="reference" /> <!-- Reference to a style for the Action Bar --> <attr name="actionBarStyle" format="reference" /> <!-- Reference to a style for the split Action Bar. This style @@ -2517,6 +2520,9 @@ <enum name="blocksDescendants" value="2" /> </attr> + <!-- Set to true if this ViewGroup blocks focus in the presence of a touchscreen. --> + <attr name="touchscreenBlocksFocus" format="boolean" /> + <!-- Sets whether this ViewGroup should split MotionEvents to separate child views during touch event dispatch. If false (default), touch events will be dispatched to @@ -4057,6 +4063,8 @@ <declare-styleable name="PopupWindow"> <!-- The background to use for the popup window. --> <attr name="popupBackground" format="reference|color" /> + <!-- Window elevation to use for the popup window. --> + <attr name="popupElevation" format="dimension" /> <!-- The animation style to use for the popup window. --> <attr name="popupAnimationStyle" format="reference" /> <!-- Whether the popup window should overlap its anchor view. --> @@ -6778,10 +6786,20 @@ <attr name="itemPadding" format="dimension" /> <!-- Set true to hide the action bar on a vertical nested scroll of content. --> <attr name="hideOnContentScroll" format="boolean" /> + <!-- Minimum inset for content views within a bar. Navigation buttons and + menu views are excepted. Only valid for some themes and configurations. --> <attr name="contentInsetStart" format="dimension" /> + <!-- Minimum inset for content views within a bar. Navigation buttons and + menu views are excepted. Only valid for some themes and configurations. --> <attr name="contentInsetEnd" format="dimension" /> + <!-- Minimum inset for content views within a bar. Navigation buttons and + menu views are excepted. Only valid for some themes and configurations. --> <attr name="contentInsetLeft" format="dimension" /> + <!-- Minimum inset for content views within a bar. Navigation buttons and + menu views are excepted. Only valid for some themes and configurations. --> <attr name="contentInsetRight" format="dimension" /> + <!-- Elevation for the action bar itself --> + <attr name="elevation" /> </declare-styleable> <declare-styleable name="ActionMode"> diff --git a/core/res/res/values/attrs_manifest.xml b/core/res/res/values/attrs_manifest.xml index 9789eee..226e30a 100644 --- a/core/res/res/values/attrs_manifest.xml +++ b/core/res/res/values/attrs_manifest.xml @@ -2025,10 +2025,11 @@ <!-- Groups signing keys into a {@code KeySet} for easier reference in other APIs. However, currently no APIs use this. --> <attr name="keySet" /> - <declare-styleable name="PublicKey"> + <declare-styleable name="AndroidManifestPublicKey"> + <attr name="name" /> <attr name="value" /> </declare-styleable> - <declare-styleable name="KeySet"> + <declare-styleable name="AndroidManifestKeySet"> <attr name="name" /> </declare-styleable> diff --git a/core/res/res/values/public.xml b/core/res/res/values/public.xml index 1eb8946..a0ca06e 100644 --- a/core/res/res/values/public.xml +++ b/core/res/res/values/public.xml @@ -2231,6 +2231,8 @@ <public type="attr" name="buttonBarPositiveButtonStyle" /> <public type="attr" name="buttonBarNeutralButtonStyle" /> <public type="attr" name="buttonBarNegativeButtonStyle" /> + <public type="attr" name="popupElevation" /> + <public type="attr" name="actionBarPopupTheme" /> <public-padding type="dimen" name="l_resource_pad" end="0x01050010" /> @@ -2508,4 +2510,5 @@ a view visibility changes. --> <public type="transition" name="slide_left"/> <public type="attr" name="multiArch" /> + <public type="attr" name="touchscreenBlocksFocus" /> </resources> diff --git a/core/res/res/values/strings.xml b/core/res/res/values/strings.xml index e8bd99a..7c60c6e 100644 --- a/core/res/res/values/strings.xml +++ b/core/res/res/values/strings.xml @@ -2152,8 +2152,8 @@ <!-- Description of an application permission, listed so the user can choose whether they want to allow the application to do this. --> <string name="permdesc_accessDrmCertificates">Allows an application to provision and use DRM certficates. Should never be needed for normal apps.</string> - <string name="permlab_handoverStatus">Receive handover transfer broadcasts.</string> - <string name="permdesc_handoverStatus">Allows receiving handover transfer status information.</string> + <string name="permlab_handoverStatus">Receive Android Beam transfer status</string> + <string name="permdesc_handoverStatus">Allows this application to receive information about current Android Beam transfers</string> <!-- Policy administration --> diff --git a/core/res/res/values/styles_material.xml b/core/res/res/values/styles_material.xml index c1eb999..4623258 100644 --- a/core/res/res/values/styles_material.xml +++ b/core/res/res/values/styles_material.xml @@ -733,6 +733,7 @@ please see styles_device_defaults.xml. <style name="Widget.Material.ListPopupWindow" parent="Widget.ListPopupWindow"> <item name="dropDownSelector">?attr/listChoiceBackgroundIndicator</item> <item name="popupBackground">@drawable/popup_background_material</item> + <item name="popupElevation">@dimen/floating_window_z</item> <item name="popupAnimationStyle">@style/Animation.Material.Popup</item> <item name="dropDownVerticalOffset">0dip</item> <item name="dropDownHorizontalOffset">0dip</item> @@ -803,6 +804,7 @@ please see styles_device_defaults.xml. <item name="homeLayout">@layout/action_bar_home_material</item> <item name="gravity">center_vertical</item> <item name="contentInsetStart">16dp</item> + <item name="elevation">8dp</item> </style> <style name="Widget.Material.ActionBar.Solid"> diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index 2065088..cf0f7b7 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -1904,4 +1904,5 @@ <java-symbol type="bool" name="skipHoldBeforeMerge" /> <java-symbol type="bool" name="useImsAlwaysForEmergencyCall" /> + <java-symbol type="attr" name="touchscreenBlocksFocus" /> </resources> diff --git a/core/res/res/values/themes.xml b/core/res/res/values/themes.xml index b63a8c1..d61253f 100644 --- a/core/res/res/values/themes.xml +++ b/core/res/res/values/themes.xml @@ -362,6 +362,7 @@ please see themes_device_defaults.xml. <item name="actionMenuTextAppearance">@style/TextAppearance.Holo.Widget.ActionBar.Menu</item> <item name="actionMenuTextColor">?attr/textColorPrimary</item> <item name="actionBarWidgetTheme">@null</item> + <item name="actionBarPopupTheme">@null</item> <item name="actionBarTheme">@null</item> <item name="actionBarDivider">?attr/dividerVertical</item> <item name="actionBarItemBackground">?attr/selectableItemBackground</item> diff --git a/core/res/res/values/themes_holo.xml b/core/res/res/values/themes_holo.xml index 78405e3..a9150c6 100644 --- a/core/res/res/values/themes_holo.xml +++ b/core/res/res/values/themes_holo.xml @@ -341,6 +341,7 @@ please see themes_device_defaults.xml. <item name="actionBarSize">@dimen/action_bar_default_height</item> <item name="actionModePopupWindowStyle">@style/Widget.Holo.PopupWindow.ActionMode</item> <item name="actionBarWidgetTheme">@null</item> + <item name="actionBarPopupTheme">@null</item> <item name="actionBarTheme">@null</item> <item name="actionModeCutDrawable">@drawable/ic_menu_cut_holo_dark</item> diff --git a/core/res/res/values/themes_material.xml b/core/res/res/values/themes_material.xml index 472177f..47f3778 100644 --- a/core/res/res/values/themes_material.xml +++ b/core/res/res/values/themes_material.xml @@ -315,6 +315,7 @@ please see themes_device_defaults.xml. <item name="actionBarSize">@dimen/action_bar_default_height_material</item> <item name="actionModePopupWindowStyle">@style/Widget.Material.PopupWindow.ActionMode</item> <item name="actionBarWidgetTheme">@null</item> + <item name="actionBarPopupTheme">@null</item> <item name="actionBarTheme">@style/ThemeOverlay.Material.ActionBar</item> <item name="actionBarItemBackground">?attr/selectableItemBackgroundBorderless</item> @@ -498,7 +499,7 @@ please see themes_device_defaults.xml. <item name="windowFullscreen">false</item> <item name="windowOverscan">false</item> <item name="windowIsFloating">false</item> - <item name="windowContentOverlay">@drawable/ab_solid_shadow_material</item> + <item name="windowContentOverlay">@null</item> <item name="windowShowWallpaper">false</item> <item name="windowTitleStyle">@style/WindowTitle.Material</item> <item name="windowTitleSize">@dimen/action_bar_default_height_material</item> @@ -653,6 +654,7 @@ please see themes_device_defaults.xml. <item name="actionButtonStyle">@style/Widget.Material.Light.ActionButton</item> <item name="actionOverflowButtonStyle">@style/Widget.Material.Light.ActionButton.Overflow</item> <item name="actionOverflowMenuStyle">@style/Widget.Material.Light.PopupMenu.Overflow</item> + <item name="actionBarPopupTheme">@null</item> <item name="actionModeBackground">@drawable/cab_background_top_holo_light</item> <item name="actionModeSplitBackground">@drawable/cab_background_bottom_holo_light</item> <item name="actionModeCloseDrawable">@drawable/ic_cab_done_material</item> @@ -737,6 +739,7 @@ please see themes_device_defaults.xml. <style name="Theme.Material.Light.DarkActionBar"> <item name="actionBarWidgetTheme">@null</item> <item name="actionBarTheme">@style/ThemeOverlay.Material.Dark.ActionBar</item> + <item name="actionBarPopupTheme">@style/ThemeOverlay.Material.Light</item> <item name="colorPrimaryDark">@color/material_blue_grey_900</item> <item name="colorPrimary">@color/material_blue_grey_800</item> @@ -778,6 +781,7 @@ please see themes_device_defaults.xml. <item name="fastScrollPreviewBackgroundLeft">@drawable/fastscroll_label_left_holo_light</item> <item name="fastScrollPreviewBackgroundRight">@drawable/fastscroll_label_right_holo_light</item> + <item name="colorControlNormal">?attr/textColorSecondary</item> <item name="colorControlHighlight">@color/ripple_material_light</item> <item name="colorButtonNormal">@color/btn_default_material_light</item> </style> @@ -814,6 +818,7 @@ please see themes_device_defaults.xml. <item name="fastScrollPreviewBackgroundLeft">@drawable/fastscroll_label_left_holo_dark</item> <item name="fastScrollPreviewBackgroundRight">@drawable/fastscroll_label_right_holo_dark</item> + <item name="colorControlNormal">?attr/textColorSecondary</item> <item name="colorControlHighlight">@color/ripple_material_dark</item> <item name="colorButtonNormal">@color/btn_default_material_dark</item> </style> diff --git a/core/tests/coretests/apks/keyset/permUse/AndroidManifest.xml b/core/tests/coretests/apks/keyset/permUse/AndroidManifest.xml index 41a2974..b7645b0 100644 --- a/core/tests/coretests/apks/keyset/permUse/AndroidManifest.xml +++ b/core/tests/coretests/apks/keyset/permUse/AndroidManifest.xml @@ -18,14 +18,16 @@ <application android:hasCode="false"> </application> <uses-permission android:name="com.android.frameworks.coretests.keysets_permdef.keyset_perm" /> - <keys> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="> - <keyset android:name="A" /> - </publicKey> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ=="> - <keyset android:name="B" /> - </publicKey> - </keys> - <upgrade-keyset android:name="A"/> - <upgrade-keyset android:name="B"/> + <key-sets> + <key-set android:name="A"> + <public-key android:name="keyA" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="/> + </key-set> + <key-set android:name="B"> + <public-key android:name="keyB" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ==" /> + </key-set> + <upgrade-key-set android:name="A"/> + <upgrade-key-set android:name="B"/> + </key-sets> </manifest> diff --git a/core/tests/coretests/apks/keyset/uA/AndroidManifest.xml b/core/tests/coretests/apks/keyset/uA/AndroidManifest.xml index 87c420e..f31b75f 100644 --- a/core/tests/coretests/apks/keyset/uA/AndroidManifest.xml +++ b/core/tests/coretests/apks/keyset/uA/AndroidManifest.xml @@ -17,10 +17,11 @@ package="com.android.frameworks.coretests.keysets"> <application android:hasCode="false"> </application> - <keys> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="> - <keyset android:name="A" /> - </publicKey> - </keys> - <upgrade-keyset android:name="A"/> + <key-sets> + <key-set android:name="A" > + <public-key android:name="keyA" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="/> + </key-set> + <upgrade-key-set android:name="A"/> + </key-sets> </manifest> diff --git a/core/tests/coretests/apks/keyset/uAB/AndroidManifest.xml b/core/tests/coretests/apks/keyset/uAB/AndroidManifest.xml index a65f085..8ad3471 100644 --- a/core/tests/coretests/apks/keyset/uAB/AndroidManifest.xml +++ b/core/tests/coretests/apks/keyset/uAB/AndroidManifest.xml @@ -17,13 +17,13 @@ package="com.android.frameworks.coretests.keysets"> <application android:hasCode="false"> </application> - <keys> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="> - <keyset android:name="AB" /> - </publicKey> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ=="> - <keyset android:name="AB" /> - </publicKey> - </keys> - <upgrade-keyset android:name="AB"/> + <key-sets> + <key-set android:name="AB" > + <public-key android:name="keyA" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ==" /> + <public-key android:name="keyB" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ==" /> + </key-set> + <upgrade-key-set android:name="AB"/> + </key-sets> </manifest> diff --git a/core/tests/coretests/apks/keyset/uAuB/AndroidManifest.xml b/core/tests/coretests/apks/keyset/uAuB/AndroidManifest.xml index 5b0b864..cdbd639 100644 --- a/core/tests/coretests/apks/keyset/uAuB/AndroidManifest.xml +++ b/core/tests/coretests/apks/keyset/uAuB/AndroidManifest.xml @@ -17,14 +17,16 @@ package="com.android.frameworks.coretests.keysets"> <application android:hasCode="false"> </application> - <keys> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ=="> - <keyset android:name="A" /> - </publicKey> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ=="> - <keyset android:name="B" /> - </publicKey> - </keys> - <upgrade-keyset android:name="A"/> - <upgrade-keyset android:name="B"/> + <key-sets> + <key-set android:name="A" > + <public-key android:name="keyA" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJoN1Nsgqf0V4C/bbN8wo8O2X/S5D76+5Mb9mlIsHkUTUTbHCNk+LxHIUYLm89YbP9zImrV0bUHLUAZUyoMUCiMCAwEAAQ==" /> + </key-set> + <key-set android:name="B" > + <public-key android:name="keyB" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ==" /> + </key-set> + <upgrade-key-set android:name="A"/> + <upgrade-key-set android:name="B"/> + </key-sets> </manifest> diff --git a/core/tests/coretests/apks/keyset/uB/AndroidManifest.xml b/core/tests/coretests/apks/keyset/uB/AndroidManifest.xml index 9b89961..61063c3 100644 --- a/core/tests/coretests/apks/keyset/uB/AndroidManifest.xml +++ b/core/tests/coretests/apks/keyset/uB/AndroidManifest.xml @@ -17,10 +17,11 @@ package="com.android.frameworks.coretests.keysets"> <application android:hasCode="false"> </application> - <keys> - <publicKey android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ=="> - <keyset android:name="B" /> - </publicKey> - </keys> - <upgrade-keyset android:name="B"/> + <key-sets> + <key-set android:name="B" > + <public-key android:name="keyB" + android:value="MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAMTfQsY8UuXiXmvw/y7Tpr7HoyfAC0nE/8Qdk3ZtEr9asa5qqP0F6xzCI1PGVFV+WLVRwm6FdB9StENL5EKyQFcCAwEAAQ==" /> + </key-set> + <upgrade-key-set android:name="B"/> + </key-sets> </manifest> diff --git a/core/tests/inputmethodtests/run_core_inputmethod_test.sh b/core/tests/inputmethodtests/run_core_inputmethod_test.sh index e0f4f6d..ed8b7f7 100755 --- a/core/tests/inputmethodtests/run_core_inputmethod_test.sh +++ b/core/tests/inputmethodtests/run_core_inputmethod_test.sh @@ -21,4 +21,4 @@ if [[ $rebuild == true ]]; then $COMMAND fi -adb shell am instrument -w -e class android.os.InputMethodTest,android.os.InputMethodSubtypeArrayTest,android.os.InputMethodSubtypeSwitchingControllerTest,android.os.CursorAnchorInfoTest,android.os.SparseRectFArrayTest com.android.frameworks.coretests.inputmethod/android.test.InstrumentationTestRunner +adb shell am instrument -w -e class android.os.InputMethodTest,android.os.InputMethodSubtypeTest,android.os.InputMethodSubtypeArrayTest,android.os.InputMethodSubtypeSwitchingControllerTest,android.os.CursorAnchorInfoTest,android.os.SparseRectFArrayTest com.android.frameworks.coretests.inputmethod/android.test.InstrumentationTestRunner diff --git a/core/tests/inputmethodtests/src/android/os/InputMethodSubtypeTest.java b/core/tests/inputmethodtests/src/android/os/InputMethodSubtypeTest.java new file mode 100644 index 0000000..323a360 --- /dev/null +++ b/core/tests/inputmethodtests/src/android/os/InputMethodSubtypeTest.java @@ -0,0 +1,101 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.os; + +import android.test.InstrumentationTestCase; +import android.test.suitebuilder.annotation.SmallTest; +import android.view.inputmethod.InputMethodSubtype; +import android.view.inputmethod.InputMethodSubtype.InputMethodSubtypeBuilder; + +import java.util.Objects; + +public class InputMethodSubtypeTest extends InstrumentationTestCase { + + public void verifyLocale(final String localeString) { + // InputMethodSubtype#getLocale() returns exactly the same string that is passed to the + // constructor. + assertEquals(localeString, createDummySubtype(localeString).getLocale()); + + // InputMethodSubtype#getLocale() should be preserved via marshaling. + assertEquals(createDummySubtype(localeString).getLocale(), + cloneViaParcel(createDummySubtype(localeString)).getLocale()); + + // InputMethodSubtype#getLocale() should be preserved via marshaling. + assertEquals(createDummySubtype(localeString).getLocale(), + cloneViaParcel(cloneViaParcel(createDummySubtype(localeString))).getLocale()); + + // Make sure InputMethodSubtype#hashCode() returns the same hash code. + assertEquals(createDummySubtype(localeString).hashCode(), + createDummySubtype(localeString).hashCode()); + assertEquals(createDummySubtype(localeString).hashCode(), + cloneViaParcel(createDummySubtype(localeString)).hashCode()); + assertEquals(createDummySubtype(localeString).hashCode(), + cloneViaParcel(cloneViaParcel(createDummySubtype(localeString))).hashCode()); + } + + @SmallTest + public void testLocaleString() throws Exception { + // The locale string in InputMethodSubtype has accepted an arbitrary text actually, + // regardless of the validity of the text as a locale string. + verifyLocale("en_US"); + verifyLocale("apparently invalid locale string"); + verifyLocale("zz"); + verifyLocale("iw"); + verifyLocale("he"); + } + + @SmallTest + public void testDeprecatedLocaleString() throws Exception { + // Make sure "iw" is not automatically replaced with "he". + final InputMethodSubtype subtypeIw = createDummySubtype("iw"); + final InputMethodSubtype subtypeHe = createDummySubtype("he"); + assertEquals("iw", subtypeIw.getLocale()); + assertEquals("he", subtypeHe.getLocale()); + assertFalse(Objects.equals(subtypeIw, subtypeHe)); + assertFalse(Objects.equals(subtypeIw.hashCode(), subtypeHe.hashCode())); + + final InputMethodSubtype clonedSubtypeIw = cloneViaParcel(subtypeIw); + final InputMethodSubtype clonedSubtypeHe = cloneViaParcel(subtypeHe); + assertEquals(subtypeIw, clonedSubtypeIw); + assertEquals(subtypeHe, clonedSubtypeHe); + assertEquals("iw", clonedSubtypeIw.getLocale()); + assertEquals("he", clonedSubtypeHe.getLocale()); + } + + private static final InputMethodSubtype cloneViaParcel(final InputMethodSubtype original) { + Parcel parcel = null; + try { + parcel = Parcel.obtain(); + original.writeToParcel(parcel, 0); + parcel.setDataPosition(0); + return InputMethodSubtype.CREATOR.createFromParcel(parcel); + } finally { + if (parcel != null) { + parcel.recycle(); + } + } + } + + private static final InputMethodSubtype createDummySubtype(final String locale) { + final InputMethodSubtypeBuilder builder = new InputMethodSubtypeBuilder(); + return builder.setSubtypeNameResId(0) + .setSubtypeIconResId(0) + .setSubtypeLocale(locale) + .setIsAsciiCapable(true) + .build(); + } +} |