summaryrefslogtreecommitdiffstats
path: root/services/audioflinger
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge "Simplify ThreadBase::exit() aka requestExitAndWait"Glenn Kasten2012-02-102-9/+20
|\ \
| * | Simplify ThreadBase::exit() aka requestExitAndWaitGlenn Kasten2012-02-102-9/+20
| |/ | | | | | | | | | | | | | | | | | | | | | | We can remove mExiting and use Thread::exitPending() instead. The local sp<> on "this" in exit() is not needed, since the caller must also hold an sp<> in order to be calling us. (Unless it was using a raw pointer, but that would be dangerous for other reasons.) Add comment explaining the mLock in exit(). Change-Id: I319e5107533a1a7cdbd13c292685f3e2be60f6c4
* | Merge "Disable HQ resamplers for now until qualified"Glenn Kasten2012-02-102-2/+6
|\ \
| * | Disable HQ resamplers for now until qualifiedGlenn Kasten2012-02-092-2/+6
| |/ | | | | | | | | | | This saves about 6500 bytes. Change-Id: I87102fe561c95c19c9e615dea3de914f96639257
* | Merge "Move header declarations around for clarity"Glenn Kasten2012-02-101-35/+37
|\ \
| * | Move header declarations around for clarityGlenn Kasten2012-02-091-35/+37
| |/ | | | | | | | | | | | | | | Put IAudioFlinger methods in binder opcode order. Move hardware call state closer to where it is used. getMode() and btNrecIsOff() are private. Change-Id: Ie50340b396c39c763f2b155cbc08da8a0d0f2424
* | Merge "Camel case readability & private disconnect(bool)"Glenn Kasten2012-02-102-10/+12
|\ \
| * | Camel case readability & private disconnect(bool)Glenn Kasten2012-02-092-10/+12
| |/ | | | | | | Change-Id: If66516ed2703e048c5e6ccc6cd431446a024f4a1
* | Merge "Remove aliasing"Glenn Kasten2012-02-101-12/+11
|\ \
| * | Remove aliasingGlenn Kasten2012-02-091-12/+11
| |/ | | | | | | | | | | | | | | | | Code was aliasing mBuffer as buffer, but continuing to use both buffer and mBuffer after that point. This was at best misleading, and at worst could confuse the compiler into generating bad code. There was no performance advantage to the alias, in fact removing it saves 16 bytes. Change-Id: I55023ddba465d9be82f66745b088d18af658ac60
* | Merge "Use mul from audioutils"Glenn Kasten2012-02-101-15/+0
|\ \
| * | Use mul from audioutilsGlenn Kasten2012-02-091-15/+0
| |/ | | | | | | | | | | I verified that the disassembled output is identical. Change-Id: I34a76f0842ebc4aef2c923e079e38d0bc1f98b5c
* | Merge "Mark fields const if only set in constructor"Glenn Kasten2012-02-101-3/+3
|\ \
| * | Mark fields const if only set in constructorGlenn Kasten2012-02-091-3/+3
| |/ | | | | | | Change-Id: Iacd06bb9efaf708cf965033be1f2297b58f7f75c
* | Follow raw pointer and sp<> conventionsGlenn Kasten2012-02-101-2/+2
| | | | | | | | | | | | | | | | Unconditional delete for raw pointers. Use "if (sp != 0)" not "if (sp.get() != 0)" or "if (sp != NULL)". Use "if (raw != NULL)" not "if (raw)". Change-Id: I531a8da7c37149261ed2f34b862ec4896a4b785b
* | Merge "No newline or space at end of ALOG format string"Glenn Kasten2012-02-103-23/+23
|\ \
| * | No newline or space at end of ALOG format stringGlenn Kasten2012-02-083-23/+23
| |/ | | | | | | Change-Id: I0bef580cbc818cb7c87aea23919d26f1446cec32
* | Merge "Move declaration of stream_type_t up earlier"Glenn Kasten2012-02-101-13/+13
|\ \
| * | Move declaration of stream_type_t up earlierGlenn Kasten2012-02-081-13/+13
| |/ | | | | | | | | | | | | stream_type_t is used by AudioFlinger class, so it should be declared there. This way we don't have to peek into PlaybackThread to get the declaration. Change-Id: Ie08bab1604699214d1e8df2d48d3fbfbbc436e96
* | Merge "Fix typos in ALOG for pid vs tid"Glenn Kasten2012-02-102-7/+7
|\ \
| * | Fix typos in ALOG for pid vs tidGlenn Kasten2012-02-092-7/+7
| |/ | | | | | | Change-Id: I6dc70f137d0ff8a86427ab8882a81886e1de0782
* | Rename type() to streamType()Glenn Kasten2012-02-082-23/+14
|/ | | | | | | This avoids possible confusion with thread's type(). Also remove redundant cast "(audio_stream_type_t)". Change-Id: I320b9177b6c267a102d215f002228bcf988c437a
* Combine duplicate code & document wp<> in mClientsGlenn Kasten2012-02-082-30/+23
| | | | Change-Id: Iea8cfe8e57563337fb2484a1246ef79d6ad3db18
* Use audio_io_handle_t consistently instead of intGlenn Kasten2012-02-084-86/+103
| | | | | | | | Other: - add a comment to nextUniqueId - made ThreadBase::mId const, since it is only assigned in constructor. Change-Id: I4e8b7bec4e45badcde6274d574b8a9aabd046837
* Simplify destructorsGlenn Kasten2012-02-081-4/+2
| | | | | | Remove explicit clear() when the order doesn't matter. Change-Id: I5931bc7ef5f681c7ce329aa9ec0a6e46d34a56c5
* Effect UUID inputs passed by pointer are constGlenn Kasten2012-02-082-2/+2
| | | | Change-Id: I1f5c338bcb7368e3dd8cd5f804b2e6d9fbe087f8
* Merge "Use pid_t not int"Glenn Kasten2012-02-081-3/+3
|\
| * Use pid_t not intGlenn Kasten2012-02-031-3/+3
| | | | | | | | Change-Id: Iad1c2fd4152e94080ad8c65c13ddf4519fc2ed27
* | Merge "Don't double destruct audio_track_cblk_t"Glenn Kasten2012-02-081-2/+4
|\ \
| * | Don't double destruct audio_track_cblk_tGlenn Kasten2012-02-031-2/+4
| |/ | | | | | | | | | | | | | | | | Fortunately audio_track_cblk_t doesn't have a destructor, but for clarity remove the double destruction. Also add warning not to add any virtuals to audio_track_cblk_t. Change-Id: I70ebe1a70460c7002145b2cdf10f9f137396e6f3
* | Merge "AudioFlinger methods const and inline"Glenn Kasten2012-02-085-115/+48
|\ \
| * | AudioFlinger methods const and inlineGlenn Kasten2012-02-035-115/+48
| |/ | | | | | | | | | | This saves 1063 bytes and probably improves performance. Change-Id: I11cf0dfd925fbaec75e3d1b806852a538eae5518
* | Merge "Use virtual destructors"Glenn Kasten2012-02-083-11/+11
|\ \
| * | Use virtual destructorsGlenn Kasten2012-02-033-11/+11
| |/ | | | | | | | | | | | | | | | | | | It turns out to be just a comment, as all except AudioMixer are RefBase. There are only a few performance-sensitive cases where it's worth thinking about whether you need a virtual destructor, and the headache usually outweighs the benefit. Change-Id: I716292f9556ec17c29ce8c76ac8ae602cb496533
* | Merge "Improve performance for sp<> on stack"Glenn Kasten2012-02-081-36/+13
|\ \
| * | Improve performance for sp<> on stackGlenn Kasten2012-01-301-36/+13
| | | | | | | | | | | | | | | | | | | | | | | | Combine default constructor for sp<> immediately followed by assignment, as the reference-counting is relatively slow. Also return sp<> directly rather than via local variable, for the same reason. Change-Id: If55931f1e407994f6591ddde41b53db72fb4fc40
* | | Merge "Use 0 not NULL for sp<> and wp<>"Glenn Kasten2012-02-082-18/+20
|\ \ \
| * | | Use 0 not NULL for sp<> and wp<>Glenn Kasten2012-02-032-18/+20
| | |/ | |/| | | | | | | Change-Id: Id1f0c89acefaceed6cb9ca7c165fce895e46d85b
* | | Merge "Use bool instead of int"Glenn Kasten2012-02-081-17/+17
|\ \ \
| * | | Use bool instead of intGlenn Kasten2012-02-031-17/+17
| |/ / | | | | | | | | | | | | | | | The .h is not modified to avoid increasing data size. Change-Id: Ide4a821a5b16424ffa03471dfff98dc3e9b5f751
* | | Merge "Declare more IAudioFlinger methods const"Glenn Kasten2012-02-082-14/+16
|\ \ \
| * | | Declare more IAudioFlinger methods constGlenn Kasten2012-02-032-14/+16
| |/ / | | | | | | | | | | | | | | | | | | This is just documentation, as C++ method const-ness doesn't mean anything for a binder API. Instead, here const means "no side effects". Change-Id: Iaa9cd2fe477db10ae9a40cac4f79f0faa9b4e5e6
* | | Remove dead codeGlenn Kasten2012-02-034-11/+0
|/ / | | | | | | | | | | | | | | mFormat is unused in resampler mClientTid is unused local variable pid is unused in dump Change-Id: Ib156e38029366620bfeff2a13e73471867155a5b
* | Merge "Use audio_in_acoustics_t consistently"Glenn Kasten2012-02-034-6/+6
|\ \
| * | Use audio_in_acoustics_t consistentlyGlenn Kasten2012-01-274-6/+6
| | | | | | | | | | | | Change-Id: I0a9dd668fb2e57b1c3ece3190588194974b99062
* | | Merge "Use ToneGenerator::tone_type consistently"Glenn Kasten2012-02-032-3/+5
|\ \ \
| * | | Use ToneGenerator::tone_type consistentlyGlenn Kasten2012-01-272-3/+5
| |/ / | | | | | | | | | | | | | | | | | | Also remove defaults in startToneCommand(), they're not needed and the default for tone type was nonsense. Change-Id: I70fa8cee4f3dbb8c66ceb3719c8d3d2f447f05b9
* | | Use NULL not 0 for raw pointersGlenn Kasten2012-02-033-25/+25
| | | | | | | | | | | | | | | | | | Use if (p != NULL) instead of if (ptr) Change-Id: Iaec3413a59ccbf233c98fcd918cc7d70ac5da9fa
* | | Merge "For performance, return large objects by reference"Glenn Kasten2012-02-032-8/+8
|\ \ \
| * | | For performance, return large objects by referenceGlenn Kasten2012-01-302-8/+8
| | |/ | |/| | | | | | | Change-Id: Ibf737018ef1d3c7d717584615dcb2d4ecdb50c99
generated by cgit v1.1 at 2025-02-09 07:01:16 +0000