From 0604427a25db171492870d1f3f86f8117987e855 Mon Sep 17 00:00:00 2001 From: Yorke Lee Date: Tue, 14 Apr 2015 15:16:59 -0700 Subject: Changes for TelecomManager API review * clearAccounts -> clearPhoneAccounts * handleMMi(PhoneAccountHandle, String) -> handleMMi(String, PhoneAccountHandle) * hasMultipleCallCapableAccounts -> removed Bug: 20160799 Change-Id: Ifcd26474f04b71aa725299b6016004151b76bc31 --- api/current.txt | 1 + api/system-current.txt | 6 +++--- telecomm/java/android/telecom/TelecomManager.java | 26 +++++++++-------------- 3 files changed, 14 insertions(+), 19 deletions(-) diff --git a/api/current.txt b/api/current.txt index dc83f6e..da702db 100644 --- a/api/current.txt +++ b/api/current.txt @@ -29744,6 +29744,7 @@ package android.telecom { method public java.util.List getCallCapablePhoneAccounts(); method public android.telecom.PhoneAccount getPhoneAccount(android.telecom.PhoneAccountHandle); method public boolean handleMmi(java.lang.String); + method public boolean handleMmi(java.lang.String, android.telecom.PhoneAccountHandle); method public boolean isInCall(); method public void showInCallScreen(boolean); field public static final java.lang.String ACTION_SHOW_CALL_ACCESSIBILITY_SETTINGS = "android.telecom.action.SHOW_CALL_ACCESSIBILITY_SETTINGS"; diff --git a/api/system-current.txt b/api/system-current.txt index ac80474..e02ed44 100644 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -32258,7 +32258,8 @@ package android.telecom { method public void addNewIncomingCall(android.telecom.PhoneAccountHandle, android.os.Bundle); method public void addNewUnknownCall(android.telecom.PhoneAccountHandle, android.os.Bundle); method public void cancelMissedCallsNotification(); - method public void clearAccounts(); + method public deprecated void clearAccounts(); + method public void clearPhoneAccounts(); method public boolean endCall(); method public android.net.Uri getAdnUriForPhoneAccount(android.telecom.PhoneAccountHandle); method public java.util.List getAllPhoneAccountHandles(); @@ -32275,8 +32276,7 @@ package android.telecom { method public java.util.List getPhoneAccountsSupportingScheme(java.lang.String); method public java.util.List getRegisteredConnectionManagers(); method public boolean handleMmi(java.lang.String); - method public boolean handleMmi(android.telecom.PhoneAccountHandle, java.lang.String); - method public boolean hasMultipleCallCapableAccounts(); + method public boolean handleMmi(java.lang.String, android.telecom.PhoneAccountHandle); method public boolean hasVoiceMailNumber(android.telecom.PhoneAccountHandle); method public boolean isInCall(); method public boolean isRinging(); diff --git a/telecomm/java/android/telecom/TelecomManager.java b/telecomm/java/android/telecom/TelecomManager.java index ab7864b..642a386 100644 --- a/telecomm/java/android/telecom/TelecomManager.java +++ b/telecomm/java/android/telecom/TelecomManager.java @@ -532,19 +532,6 @@ public class TelecomManager { } /** - * Determine whether the device has more than one account registered that can make and receive - * phone calls. - * - * @return {@code true} if the device has more than one account registered and {@code false} - * otherwise. - * @hide - */ - @SystemApi - public boolean hasMultipleCallCapableAccounts() { - return getCallCapablePhoneAccounts().size() > 1; - } - - /** * Returns a list of all {@link PhoneAccount}s registered for the calling package. * * @return A list of {@code PhoneAccountHandle} objects. @@ -683,6 +670,15 @@ public class TelecomManager { * @hide */ @SystemApi + public void clearPhoneAccounts() { + clearAccounts(); + } + /** + * Remove all Accounts that belong to the calling package from the system. + * @deprecated Use {@link #clearPhoneAccounts()} instead. + * @hide + */ + @SystemApi public void clearAccounts() { try { if (isServiceConnected()) { @@ -1017,10 +1013,8 @@ public class TelecomManager { * @param accountHandle The handle for the account the MMI code should apply to. * @param dialString The digits to dial. * @return True if the digits were processed as an MMI code, false otherwise. - * @hide */ - @SystemApi - public boolean handleMmi(PhoneAccountHandle accountHandle, String dialString) { + public boolean handleMmi(String dialString, PhoneAccountHandle accountHandle) { ITelecomService service = getTelecomService(); if (service != null) { try { -- cgit v1.1