From 364703c6fa4aa1a7d2ef5b0c048ea2a0d57a4c40 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Wed, 30 Jun 2010 15:51:03 -0700 Subject: Fix the build. Change-Id: I08bd6daf25351daca3ae552e1cfcfce85eefa73b --- libs/hwui/GenerationCache.h | 8 ++++---- libs/hwui/TextureCache.cpp | 9 +++++---- libs/hwui/TextureCache.h | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libs/hwui/GenerationCache.h b/libs/hwui/GenerationCache.h index c4ff587..4a3ca77 100644 --- a/libs/hwui/GenerationCache.h +++ b/libs/hwui/GenerationCache.h @@ -41,9 +41,9 @@ public: void clear(); bool contains(K* key) const; - const V* get(K* key); + V* get(K* key); void put(K* key, V* value); - const V* remove(K* key); + V* remove(K* key); unsigned int size() const; @@ -108,7 +108,7 @@ bool GenerationCache::contains(K* key) const { } template -const V* GenerationCache::get(K* key) { +V* GenerationCache::get(K* key) { ssize_t index = mCache.indexOfKey(key); if (index >= 0) { sp > entry = mCache.valueAt(index); @@ -148,7 +148,7 @@ void GenerationCache::addToCache(sp > entry, K* key, V* valu } template -const V* GenerationCache::remove(K* key) { +V* GenerationCache::remove(K* key) { ssize_t index = mCache.indexOfKey(key); if (index >= 0) { sp > entry = mCache.valueAt(index); diff --git a/libs/hwui/TextureCache.cpp b/libs/hwui/TextureCache.cpp index b4a57ee..fd12a3c 100644 --- a/libs/hwui/TextureCache.cpp +++ b/libs/hwui/TextureCache.cpp @@ -40,7 +40,8 @@ void TextureCache::operator()(SkBitmap* key, Texture* value) { Texture* TextureCache::get(SkBitmap* bitmap) { Texture* texture = mCache.get(bitmap); if (!texture) { - texture = generateTexture(bitmap); + texture = new Texture; + generateTexture(bitmap, texture); mCache.put(bitmap, texture); } return texture; @@ -54,9 +55,7 @@ void TextureCache::clear() { mCache.clear(); } -Texture* TextureCache::generateTexture(SkBitmap* bitmap) { - Texture* texture = new Texture; - +void TextureCache::generateTexture(SkBitmap* bitmap, Texture* texture) { texture->width = bitmap->width(); texture->height = bitmap->height(); @@ -77,6 +76,8 @@ Texture* TextureCache::generateTexture(SkBitmap* bitmap) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, texture->width, texture->height, 0, GL_RGBA, GL_UNSIGNED_BYTE, bitmap->getPixels()); break; + default: + break; } return texture; diff --git a/libs/hwui/TextureCache.h b/libs/hwui/TextureCache.h index 42328f4..7f95366 100644 --- a/libs/hwui/TextureCache.h +++ b/libs/hwui/TextureCache.h @@ -37,7 +37,7 @@ public: void clear(); private: - Texture* generateTexture(SkBitmap* bitmap); + void generateTexture(SkBitmap* bitmap, Texture* texture); GenerationCache mCache; }; // class TextureCache -- cgit v1.1