From 43212264dd0eaa5deea6539b8d4eb3a3edd7d22d Mon Sep 17 00:00:00 2001 From: Svet Ganov Date: Thu, 11 Sep 2014 00:05:06 -0700 Subject: Fix edit text error state in the print UI. If the user input in the print UI is invalid we show an error icon next to it. The design requires no error message being shown in a popup but TextView does show the popup all the time. bug:16966145 Change-Id: I7aa1ec8093bc76e2f440bcb243609e92e049786b --- .../res/layout/print_activity_controls.xml | 8 ++-- .../printspooler/widget/CustomErrorEditText.java | 44 ++++++++++++++++++++++ 2 files changed, 48 insertions(+), 4 deletions(-) create mode 100644 packages/PrintSpooler/src/com/android/printspooler/widget/CustomErrorEditText.java diff --git a/packages/PrintSpooler/res/layout/print_activity_controls.xml b/packages/PrintSpooler/res/layout/print_activity_controls.xml index c2a0da9..f0b8adf 100644 --- a/packages/PrintSpooler/res/layout/print_activity_controls.xml +++ b/packages/PrintSpooler/res/layout/print_activity_controls.xml @@ -55,7 +55,7 @@ android:text="@string/label_copies"> - - + @@ -197,7 +197,7 @@ android:visibility="visible"> - - + diff --git a/packages/PrintSpooler/src/com/android/printspooler/widget/CustomErrorEditText.java b/packages/PrintSpooler/src/com/android/printspooler/widget/CustomErrorEditText.java new file mode 100644 index 0000000..b2aa008 --- /dev/null +++ b/packages/PrintSpooler/src/com/android/printspooler/widget/CustomErrorEditText.java @@ -0,0 +1,44 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.printspooler.widget; + +import android.content.Context; +import android.graphics.drawable.Drawable; +import android.util.AttributeSet; +import android.widget.EditText; + +/** + * EditText that shows an error without a popup. + */ +public final class CustomErrorEditText extends EditText { + private CharSequence mError; + + public CustomErrorEditText(Context context, AttributeSet attrs) { + super(context, attrs); + } + + @Override + public CharSequence getError() { + return mError; + } + + @Override + public void setError(CharSequence error, Drawable icon) { + setCompoundDrawables(null, null, icon, null); + mError = error; + } +} \ No newline at end of file -- cgit v1.1