From ea9af9e97b143200ef2d572c580b0e3368feab11 Mon Sep 17 00:00:00 2001 From: Wink Saville Date: Sun, 30 Jan 2011 16:16:20 -0800 Subject: Add debug for tracking bug 3404006. We need some additional debugging to help diagnose the cause of this bug. There is no logic changes just additional debugging. Change-Id: Ifc5d1c82904042fa87fd3b5b1066f58b62e7359c --- .../internal/telephony/DataConnectionTracker.java | 23 ++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/telephony/java/com/android/internal/telephony/DataConnectionTracker.java b/telephony/java/com/android/internal/telephony/DataConnectionTracker.java index 2343dd8..7f8485b 100644 --- a/telephony/java/com/android/internal/telephony/DataConnectionTracker.java +++ b/telephony/java/com/android/internal/telephony/DataConnectionTracker.java @@ -531,7 +531,9 @@ public abstract class DataConnectionTracker extends Handler { * {@code true} otherwise. */ public synchronized boolean getAnyDataEnabled() { - return (mInternalDataEnabled && mDataEnabled && (enabledCount != 0)); + boolean result = (mInternalDataEnabled && mDataEnabled && (enabledCount != 0)); + if (!result && DBG) log("getAnyDataEnabled " + result); + return result; } protected abstract void startNetStatPoll(); @@ -657,7 +659,13 @@ public abstract class DataConnectionTracker extends Handler { // disabled apn's still need avail/unavail notificiations - send them out protected void notifyOffApnsOfAvailability(String reason, boolean availability) { - if (mAvailability == availability) return; + if (mAvailability == availability) { + if (DBG) { + log("notifyOffApnsOfAvailability: no change in availability, " + + "not nofitying about reason='" + reason + "' availability=" + availability); + } + return; + } mAvailability = availability; for (int id = 0; id < APN_NUM_TYPES; id++) { if (!isApnIdEnabled(id)) { @@ -685,10 +693,13 @@ public abstract class DataConnectionTracker extends Handler { * @return {@code true} if data connectivity is possible, {@code false} otherwise. */ protected boolean isDataPossible() { - boolean possible = (isDataAllowed() - && !(getAnyDataEnabled() && (mState == State.FAILED || mState == State.IDLE))); - if (!possible && DBG && isDataAllowed()) { - log("Data not possible. No coverage: dataState = " + mState); + boolean dataAllowed = isDataAllowed(); + boolean anyDataEnabled = getAnyDataEnabled(); + boolean possible = (dataAllowed + && !(anyDataEnabled && (mState == State.FAILED || mState == State.IDLE))); + if (!possible && DBG) { + log("isDataPossible() " + possible + ", dataAllowed=" + dataAllowed + + " anyDataEnabled=" + anyDataEnabled + " dataState=" + mState); } return possible; } -- cgit v1.1