From 6c4b9de8f1fd594038793c3924b52a44138c319e Mon Sep 17 00:00:00 2001 From: Narayan Kamath Date: Fri, 8 Aug 2014 12:44:12 +0100 Subject: Validate instruction sets passed to installd. We don't want folks passing down arbitrary strings. bug: 16837404 Change-Id: I73ac66b376f1401f9f95f3c6323da6242ac8ed3d --- core/java/android/app/LoadedApk.java | 4 ---- 1 file changed, 4 deletions(-) (limited to 'core') diff --git a/core/java/android/app/LoadedApk.java b/core/java/android/app/LoadedApk.java index 24c2835..aa1f021 100644 --- a/core/java/android/app/LoadedApk.java +++ b/core/java/android/app/LoadedApk.java @@ -262,10 +262,6 @@ public final class LoadedApk { if (!Objects.equals(mPackageName, ActivityThread.currentPackageName())) { final String isa = VMRuntime.getRuntime().vmInstructionSet(); try { - // TODO: We can probably do away with the isa argument since - // the AM and PM have enough information to figure this out - // themselves. If we do need it, we should match it against the - // list of devices ISAs before sending it down to installd. ActivityThread.getPackageManager().performDexOptIfNeeded(mPackageName, isa); } catch (RemoteException re) { // Ignored. -- cgit v1.1