From 930d3af75f9e9663222f4c4a1d75b326cf811e35 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Fri, 30 Jul 2010 16:52:29 -0700 Subject: Do not deference before null check The return of parsePackageLite wasn't checked until after it was deferenced. Move the deference below the null check and remove redundant set. Bug: 2852726 Change-Id: I3eaaea5050948145eed44b64507dc846993d98eb --- core/java/android/content/pm/PackageParser.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core') diff --git a/core/java/android/content/pm/PackageParser.java b/core/java/android/content/pm/PackageParser.java index 73c4011..0b35d8b 100644 --- a/core/java/android/content/pm/PackageParser.java +++ b/core/java/android/content/pm/PackageParser.java @@ -587,7 +587,7 @@ public class PackageParser { * location from the apk location at the given file path. * @param packageFilePath file location of the apk * @param flags Special parse flags - * @return PackageLite object with package information. + * @return PackageLite object with package information or null on failure. */ public static PackageLite parsePackageLite(String packageFilePath, int flags) { XmlResourceParser parser = null; -- cgit v1.1