From 43a4a8c777fbb8f71540ac7fbe82674489ef557b Mon Sep 17 00:00:00 2001 From: Christopher Tate Date: Thu, 8 Jan 2015 18:42:33 -0800 Subject: Fix redundant file backups We'd observed a bug in which an unchanged file was nevertheless being redundantly transmitted for backup on every backup pass. The underlying issue turns out to have been the FileBackupHelper base implementation's logic for diffing the prior-state file set against the current state, in the case when there had been deletions of prior files. In addition, there was also a parallel bug in which file checksums were not calculated properly in some cases, leading to at least one additional redundant backup of the file in question. Bug 18694053 Change-Id: Ie0dec06486b5fef4624561737019569c85d6b2a0 --- include/androidfw/BackupHelpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include') diff --git a/include/androidfw/BackupHelpers.h b/include/androidfw/BackupHelpers.h index 1bb04a7..0841af6 100644 --- a/include/androidfw/BackupHelpers.h +++ b/include/androidfw/BackupHelpers.h @@ -152,7 +152,7 @@ private: KeyedVector m_files; }; -#define TEST_BACKUP_HELPERS 1 +//#define TEST_BACKUP_HELPERS 1 #if TEST_BACKUP_HELPERS int backup_helper_test_empty(); -- cgit v1.1