From 065fa8deb178f00ad9957d3212ec2620c46f78e4 Mon Sep 17 00:00:00 2001 From: Alex Sakhartchouk Date: Fri, 12 Aug 2011 11:30:30 -0700 Subject: Fix to the memory leak problem. Change-Id: I18dfa76ecae62ed5165415531adf3a13ad992b54 --- libs/rs/rsAllocation.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'libs/rs') diff --git a/libs/rs/rsAllocation.cpp b/libs/rs/rsAllocation.cpp index f3e0c0a..b59ade8 100644 --- a/libs/rs/rsAllocation.cpp +++ b/libs/rs/rsAllocation.cpp @@ -58,6 +58,19 @@ void Allocation::updateCache() { } Allocation::~Allocation() { + if (mHal.state.hasReferences && + (mHal.state.hasFaces || mHal.state.hasMipmaps)) { + LOGE("Cube/mip allocation with references unsupported, memory not cleaned up!"); + } + + uint32_t elemCount = mHal.state.dimensionX; + if (mHal.state.dimensionY > 1) { + elemCount *= mHal.state.dimensionY; + } + if (mHal.state.dimensionZ > 1) { + elemCount *= mHal.state.dimensionZ; + } + decRefs(getPtr(), elemCount, 0); mRSC->mHal.funcs.allocation.destroy(mRSC, this); } @@ -270,6 +283,9 @@ void Allocation::incRefs(const void *ptr, size_t ct, size_t startOff) const { } void Allocation::decRefs(const void *ptr, size_t ct, size_t startOff) const { + if (!mHal.state.hasReferences || !getIsScript()) { + return; + } const uint8_t *p = static_cast(ptr); const Element *e = mHal.state.type->getElement(); uint32_t stride = e->getSizeBytes(); -- cgit v1.1