From f2d28b74850ea0869aef2ce0727a6abb7b166a5c Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Thu, 24 Sep 2009 14:57:26 -0700 Subject: minor SurfaceFlinger code cleanup and remove unnecessary tests --- libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp') diff --git a/libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp b/libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp index 7bdf885..8a7abec 100644 --- a/libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp +++ b/libs/surfaceflinger/DisplayHardware/DisplayHardware.cpp @@ -160,7 +160,7 @@ void DisplayHardware::init(uint32_t dpy) if (mNativeWindow->isUpdateOnDemand()) { - mFlags |= UPDATE_ON_DEMAND; + mFlags |= PARTIAL_UPDATES; } if (eglGetConfigAttrib(display, config, EGL_CONFIG_CAVEAT, &dummy) == EGL_TRUE) { @@ -174,9 +174,9 @@ void DisplayHardware::init(uint32_t dpy) surface = eglCreateWindowSurface(display, config, mNativeWindow.get(), NULL); - if (mFlags & UPDATE_ON_DEMAND) { - // if we have update on demand, we definitely don't need to - // preserve the backbuffer, which is usually costly. + if (mFlags & PARTIAL_UPDATES) { + // if we have partial updates, we definitely don't need to + // preserve the backbuffer, which may be costly. eglSurfaceAttrib(display, surface, EGL_SWAP_BEHAVIOR, EGL_BUFFER_DESTROYED); } @@ -199,9 +199,9 @@ void DisplayHardware::init(uint32_t dpy) mFlags |= SWAP_RECTANGLE; } } - // when we have the choice between UPDATE_ON_DEMAND and SWAP_RECTANGLE - // choose UPDATE_ON_DEMAND, which is more efficient - if (mFlags & UPDATE_ON_DEMAND) + // when we have the choice between PARTIAL_UPDATES and SWAP_RECTANGLE + // choose PARTIAL_UPDATES, which should be more efficient + if (mFlags & PARTIAL_UPDATES) mFlags &= ~SWAP_RECTANGLE; #endif @@ -317,7 +317,7 @@ void DisplayHardware::flip(const Region& dirty) const } #endif - if (mFlags & UPDATE_ON_DEMAND) { + if (mFlags & PARTIAL_UPDATES) { mNativeWindow->setUpdateRectangle(dirty.getBounds()); } -- cgit v1.1