From 94c1f148bb655a3dd3c2a2167476239b41305ff0 Mon Sep 17 00:00:00 2001 From: Jamie Gennis Date: Sun, 30 Oct 2011 18:10:41 -0700 Subject: BlobCache: remove the mutex locking This change removes the mutex from the BlobCache class. The caller must be responsible for thread synchronization in order to properly implement the Flattenable interface, which is coming soon. Otherwise would be the potential for the cache contents to change between the call to the getFlattenedSize and flatten methods. Because the caller must do this synchronization anyway there's no reason to also some synchronization inside BlobCache. Change-Id: Ie1f4f6f82b78744f46a41ce863cac0cad276a20e --- libs/utils/BlobCache.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'libs') diff --git a/libs/utils/BlobCache.cpp b/libs/utils/BlobCache.cpp index 590576a..15155b2 100644 --- a/libs/utils/BlobCache.cpp +++ b/libs/utils/BlobCache.cpp @@ -67,7 +67,6 @@ void BlobCache::set(const void* key, size_t keySize, const void* value, return; } - Mutex::Autolock lock(mMutex); sp dummyKey(new Blob(key, keySize, false)); CacheEntry dummyEntry(dummyKey, NULL); @@ -129,7 +128,6 @@ size_t BlobCache::get(const void* key, size_t keySize, void* value, keySize, mMaxKeySize); return 0; } - Mutex::Autolock lock(mMutex); sp dummyKey(new Blob(key, keySize, false)); CacheEntry dummyEntry(dummyKey, NULL); ssize_t index = mCacheEntries.indexOf(dummyEntry); -- cgit v1.1