From 5cafc52fb10bd05c587a7dec41c953c0722f302a Mon Sep 17 00:00:00 2001 From: Chet Haase Date: Tue, 23 Nov 2010 13:47:26 -0800 Subject: Fix hang in native bitmap recycling due to nested mutex locks Change-Id: Ic37d5408ddb3f68aba6520fb0c78ffde91dfbe62 --- libs/hwui/ResourceCache.cpp | 5 ----- libs/hwui/ResourceCache.h | 1 - 2 files changed, 6 deletions(-) (limited to 'libs') diff --git a/libs/hwui/ResourceCache.cpp b/libs/hwui/ResourceCache.cpp index 5ebd2c0..00de39b 100644 --- a/libs/hwui/ResourceCache.cpp +++ b/libs/hwui/ResourceCache.cpp @@ -111,11 +111,6 @@ void ResourceCache::recycle(SkBitmap* resource) { resource->setPixels(NULL, NULL); return; } - recycle((void*) resource); -} - -void ResourceCache::recycle(void* resource) { - Mutex::Autolock _l(mLock); ResourceReference* ref = mCache->indexOfKey(resource) >= 0 ? mCache->valueFor(resource) : NULL; if (ref == NULL) { // Should not get here - shouldn't get a call to recycle if we're not yet tracking it diff --git a/libs/hwui/ResourceCache.h b/libs/hwui/ResourceCache.h index b0abe2c..1bb4390 100644 --- a/libs/hwui/ResourceCache.h +++ b/libs/hwui/ResourceCache.h @@ -61,7 +61,6 @@ public: void decrementRefcount(SkBitmap* resource); void decrementRefcount(SkiaShader* resource); void decrementRefcount(SkiaColorFilter* resource); - void recycle(void* resource); void recycle(SkBitmap* resource); void destructor(SkBitmap* resource); void destructor(SkiaShader* resource); -- cgit v1.1