From 457d5ae3c9e40c8336b65ea954d1bd5ae1622917 Mon Sep 17 00:00:00 2001 From: James Dong Date: Wed, 9 Jun 2010 10:19:33 -0700 Subject: Fix a potential(observed sometimes) media server crash The problem is that we are referring an temp object returned from a function call. When the function call returned, the temp object is gone; and thus the reference may be invalidated. -- rebased bug - 2734946 Change-Id: I1993c4462df95610ca478f816adc30058af5850e --- media/jni/android_media_MediaRecorder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'media/jni') diff --git a/media/jni/android_media_MediaRecorder.cpp b/media/jni/android_media_MediaRecorder.cpp index 3d90650..c113ffe 100644 --- a/media/jni/android_media_MediaRecorder.cpp +++ b/media/jni/android_media_MediaRecorder.cpp @@ -317,7 +317,7 @@ android_media_MediaRecorder_prepare(JNIEnv *env, jobject thiz) jobject surface = env->GetObjectField(thiz, fields.surface); if (surface != NULL) { - const sp& native_surface = get_surface(env, surface); + const sp native_surface = get_surface(env, surface); LOGI("prepare: surface=%p (identity=%d)", native_surface.get(), native_surface->getIdentity()); if (process_media_recorder_call(env, mr->setPreviewSurface(native_surface), "java/lang/RuntimeException", "setPreviewSurface failed.")) { return; -- cgit v1.1