From 3115960bdeb89f23131c5abf6eebc8c7e0fd8b9c Mon Sep 17 00:00:00 2001 From: Paul McLean Date: Tue, 4 Aug 2015 13:57:29 -0600 Subject: Consider channel index masks when calculating channel counts. Bug: 22874806 Change-Id: I04b74f5939bb81350d9e37b9629f8bbc242bffe7 --- media/java/android/media/AudioDeviceInfo.java | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) (limited to 'media') diff --git a/media/java/android/media/AudioDeviceInfo.java b/media/java/android/media/AudioDeviceInfo.java index bdb1f58..c73f596 100644 --- a/media/java/android/media/AudioDeviceInfo.java +++ b/media/java/android/media/AudioDeviceInfo.java @@ -19,6 +19,8 @@ package android.media; import android.annotation.NonNull; import android.util.SparseIntArray; +import java.util.TreeSet; + /** * Class to provide information about the audio devices. */ @@ -185,13 +187,24 @@ public final class AudioDeviceInfo { * can be configured. */ public @NonNull int[] getChannelCounts() { - int[] masks = getChannelMasks(); - int[] counts = new int[masks.length]; - // TODO: consider channel index masks - for (int mask_index = 0; mask_index < masks.length; mask_index++) { - counts[mask_index] = isSink() - ? AudioFormat.channelCountFromOutChannelMask(masks[mask_index]) - : AudioFormat.channelCountFromInChannelMask(masks[mask_index]); + TreeSet countSet = new TreeSet(); + + // Channel Masks + for (int mask : getChannelMasks()) { + countSet.add(isSink() ? + AudioFormat.channelCountFromOutChannelMask(mask) + : AudioFormat.channelCountFromInChannelMask(mask)); + } + + // Index Masks + for (int index_mask : getChannelIndexMasks()) { + countSet.add(Integer.bitCount(index_mask)); + } + + int[] counts = new int[countSet.size()]; + int index = 0; + for (int count : countSet) { + counts[index++] = count; } return counts; } -- cgit v1.1